On Tue, 28 Jul 2020 13:25:57 +0200
Halil Pasic <pa...@linux.ibm.com> wrote:
> On Tue, 28 Jul 2020 12:31:51 +0200
> Cornelia Huck <coh...@redhat.com> wrote:
>
> > On Fri, 17 Jul 2020 11:29:27 +0200
> > Marc Hartmayer <mhart...@linux.ibm.com> wrote:
> >
> > > From: Halil Pasic <pa...@linux.ibm.com>
> > >
> > > Wire up the CCW device for vhost-user-fs.
> > >
> > > Signed-off-by: Halil Pasic <pa...@linux.ibm.com>
> > > ---
> > > hw/s390x/Makefile.objs | 1 +
> > > hw/s390x/vhost-user-fs-ccw.c | 73 ++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 74 insertions(+)
> > > create mode 100644 hw/s390x/vhost-user-fs-ccw.c
(...)
> > > +static void vhost_user_fs_ccw_instance_init(Object *obj)
> > > +{
> > > + VHostUserFSCcw *dev = VHOST_USER_FS_CCW(obj);
> > > +
> >
> > This needs
> >
> > ccw_dev->force_revision_1 = true;
> >
>
> I'm OK with that as well. Just out of curiosity, why do we need it? Is
> there a virtio-ccw revision 1 feature this device inherently needs?
Yes, the VERSION_1 feature :)
(All newer virtio devices are virtio-1 only, and the code has recently
started enforcing this.)
