Re: [PATCH v5 6/6] target/ppc: add vmsumudm vmsumcud instructions

On 7/23/20 9:58 PM, Lijun Pan wrote: > vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo > VA-form. > vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned > Doubleword VA-form. > > Signed-off-by: Lijun Pan > --- > v5: update instruction flag for vmsumc

Re: [PATCH v7 40/47] block: Inline bdrv_co_block_status_from_*()

On 25.06.2020 18:22, Max Reitz wrote: With bdrv_filter_bs(), we can easily handle this default filter behavior in bdrv_co_block_status(). blkdebug wants to have an additional assertion, so it keeps its own implementation, except bdrv_co_block_status_from_file() needs to be inlined there. Sugges

Re: [PATCH v3 17/21] migration/savevm: don't worry if bitmap migration postcopy failed

On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: First, if only bitmaps postcopy enabled (not ram postcopy) is enabled (and not ram postcopy), postcopy_pause_incoming crashes on assertion assert(mis->to_src_file). on an And anyway, bitmaps postcopy is not prepared to be somehow re

[PATCH] linux-user: Fix syscall rt_sigtimedwait() implementation

Implementation of 'rt_sigtimedwait()' in 'syscall.c' uses the function 'target_to_host_timespec()' to transfer the value of 'struct timespec' from target to host. However, the implementation doesn't check whether this conversion succeeds and thus can cause an unaproppriate error instead of the 'EFA

Re: [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers

On 7/23/20 11:45 PM, Alex Bennée wrote: > From: Laszlo Ersek > > Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an > object that has static storage duration shall be constant expressions or > string literals". > > The compound literal produced by the make_floatx80() macro is

Re: [PATCH v3 06/16] accel/tcg: better handle memory constrained systems

On 7/23/20 11:44 PM, Alex Bennée wrote: > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fills up > can put the machine under increased memory pres

Re: [PATCH v3 12/16] linux-user: fix clock_nanosleep()

On 7/23/20 11:45 PM, Alex Bennée wrote: > From: Laurent Vivier > > If the call is interrupted by a signal handler, it fails with error EINTR > and if "remain" is not NULL and "flags" is not TIMER_ABSTIME, it returns > the remaining unslept time in "remain". > > Update linux-user to not overwrite

Re: [PATCH v3 13/16] linux-user,ppc: fix clock_nanosleep() for linux-user-ppc

On 7/23/20 11:45 PM, Alex Bennée wrote: > From: Laurent Vivier > > Our safe_clock_nanosleep() returns -1 and updates errno. > > We don't need to update the CRF bit in syscall.c because it will > be updated in ppc/cpu_loop.c as the return value is negative. > > Signed-off-by: Laurent Vivier > S

Re: [PATCH 2/2] tests: Exclude 'boot_linux.py' from fetch-acceptance rule

Hi Philippe, On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote: The boot_linux.py file triggers an exception: $ make fetch-acceptance AVOCADO tests/acceptance Fetching assets from tests/acceptance/empty_cpu_model.py. Fetching assets from tests/acceptance/vnc.py. Fetching assets fr

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

Ping? On 7/20/20 8:40 AM, Richard Henderson wrote: > We forgot to update cc_op before these branch insns, > which lead to losing track of the current eflags. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1888165 > Signed-off-by: Richard Henderson > --- > target/i386/translate.c | 1 + > 1 f

Re: [PATCH v5 6/6] target/ppc: add vmsumudm vmsumcud instructions

> On Jul 24, 2020, at 1:00 PM, Richard Henderson > wrote: > > On 7/23/20 9:58 PM, Lijun Pan wrote: >> vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo >> VA-form. >> vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned >> Doubleword VA-form. >> >>

Re: [PATCH 2/2] tests: Exclude 'boot_linux.py' from fetch-acceptance rule

On Fri, Jul 24, 2020 at 3:26 PM Wainer dos Santos Moschetta wrote: > > Hi Philippe, > > On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote: > > The boot_linux.py file triggers an exception: > > > >$ make fetch-acceptance > >AVOCADO tests/acceptance > >Fetching assets from tests/acceptanc

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

Looks good, will queue when I am back---or just send a pull request yourself if you prefer. Paolo Il ven 24 lug 2020, 20:35 Richard Henderson ha scritto: > Ping? > > On 7/20/20 8:40 AM, Richard Henderson wrote: > > We forgot to update cc_op before these branch insns, > > which lead to losing tr

Re: [PATCH 1/2] tests: Add 'fetch-acceptance' rule

Hello, On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote: Add a rule to fetch acceptance test assets. This is particularly useful in a CI context, when a single job can fetch and save the cache so other jobs reuse it directly. It is also useful to measure the time spent downloading the assets v

Re: [PATCH v3 20/21] qemu-iotests/199: add early shutdown case to bitmaps postcopy

On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Previous patches fixed two crashes which may occur on shutdown prior to bitmaps postcopy finished. Check that it works now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/199 | 24 +

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

Richard Henderson writes: > We forgot to update cc_op before these branch insns, > which lead to losing track of the current eflags. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1888165 > Signed-off-by: Richard Henderson > --- > target/i386/translate.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH] linux-user: Fix syscall rt_sigtimedwait() implementation

Le 24/07/2020 à 20:16, Filip Bozuta a écrit : > Implementation of 'rt_sigtimedwait()' in 'syscall.c' uses the > function 'target_to_host_timespec()' to transfer the value of > 'struct timespec' from target to host. However, the implementation > doesn't check whether this conversion succeeds and thu

[PATCH v2] cputlb: Make store_helper less fragile to compiler optimizations

This change has no functional change. There is a potential link error with "undefined symbol: qemu_build_not_reached" due to how `store_helper` is structured. This does not produce at current QEMU head, but was reproducible at v4.2.0 with `clang-10 -O2 -fexperimental-new-pass-manager`. The curren

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

24.07.2020 20:35, Eric Blake wrote: On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy recovering) because of dirty-bitmaps migration failure. Instead we should just lose unfinished bitmaps. Still we have t

[PATCH] linux-user: Ensure mmap_min_addr is non-zero

When the chroot does not have /proc mounted, we can read neither /proc/sys/vm/mmap_min_addr nor /proc/sys/maps. The enforcement of mmap_min_addr in the host kernel is done by the security module, and so does not apply to processes owned by root. Which leads pgd_find_hole_fallback to succeed in pr

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

On 7/24/20 11:53 AM, Paolo Bonzini wrote: > Looks good, will queue when I am back---or just send a pull request yourself > if > you prefer. Ok, will do. Thanks. r~ > > Paolo > > Il ven 24 lug 2020, 20:35 Richard Henderson > ha scritto: > > Ping? >

[Bug 1888728] Re: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' failed.

For the record, reproducing this problem requires root, thus trying to reproduce it outside of a chroot is non-obvious. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07224.html ** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Ric

Re: Testing the virtio-vhost-user QEMU patch

Stefan Hajnoczi writes: > On Fri, Jul 24, 2020 at 10:58:45AM +, Alyssa Ross wrote: >> Alyssa Ross writes: >> >> > Stefan Hajnoczi writes: >> > >> >> On Tue, Jul 21, 2020 at 07:14:38AM +, Alyssa Ross wrote: >> >>> Hi -- I hope it's okay me reaching out like this. >> >>> >> >>> I've bee

Re: [PATCH v5 6/6] target/ppc: add vmsumudm vmsumcud instructions

> On Jul 24, 2020, at 1:46 PM, Lijun Pan wrote: > > > >> On Jul 24, 2020, at 1:00 PM, Richard Henderson > > wrote: >> >> On 7/23/20 9:58 PM, Lijun Pan wrote: >>> vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo >>> VA-form. >>> vm

[PULL v1 2/3] tpm: Improve help on TPM types when none are available

From: Markus Armbruster Help is a bit awkward when no TPM types are built into QEMU: $ qemu-system-x86_64 -tpmdev nonexistent,id=tpm0 qemu-system-x86_64: -tpmdev nonexistent,id=tpm0: Parameter 'type' expects a TPM backend type Supported TPM types (choose only one): Improve to

[PULL v1 0/3] Merge tpm 2020/07/24 v1

This series of patches corrects bad error reporting due to erroneous or missing TPM related command line parameters. Regards, Stefan The following changes since commit 7adfbea8fd1efce36019a0c2f198ca73be9d3f18: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-for-5.1-pull-req

[PULL v1 1/3] Revert "tpm: Clean up error reporting in tpm_init_tpmdev()"

From: Markus Armbruster This reverts commit d10e05f15d5c3dd5e5cc59c5dfff460d89d48580. We report some -tpmdev failures, but then continue as if all was fine. Reproducer: $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -chardev null,id=tpm0 -tpmdev emulator,id=tpm0,chardev=c

[PULL v1 3/3] tpm_emulator: Report an error if chardev is missing

This patch fixes the odd error reporting when trying to send a file descriptor to the TPM emulator if one has not passed a valid chardev. $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 qemu-system-x86_64: -tpmdev emulator,id=tpm0: tpm-emulator: Failed to send CMD_SET_DATAFD: Success

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

On 2020/7/24 下午11:34, Cornelia Huck wrote: On Fri, 24 Jul 2020 11:17:57 -0400 "Michael S. Tsirkin" wrote: On Fri, Jul 24, 2020 at 04:56:27PM +0200, Cornelia Huck wrote: On Fri, 24 Jul 2020 09:30:58 -0400 "Michael S. Tsirkin" wrote: On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huc

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

That's OK for unicore32 target. Acked-by: Guan Xuetao > -原始邮件- > 发件人: "Thomas Huth" > 发送时间: 2020-07-23 21:22:19 (星期四) > 收件人: "Guan Xuetao" , qemu-devel@nongnu.org > 抄送: "Philippe Mathieu-Daudé" , qemu-triv...@nongnu.org, > "Richard Henderson" > 主题: [PATCH] target/unicore32: Remove CU

Re: [PATCH 1/1] scripts/performance: Add bisect.py script

On 7/21/20 7:15 PM, Ahmed Karaman wrote: Python script that locates the commit that caused a performance degradation or improvement in QEMU using the git bisect command (binary search). Syntax: bisect.py [-h] -s,--start START [-e,--end END] [-q,--qemu QEMU] \ --target TARGET --tool {perf,callgri

[Bug 1888918] [NEW] qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

Public bug reported: When emulating certain floating point instructions or vector instructions on PowerPC machines, QEMU does not properly generate the SPE/Embedded Floating-Point Unavailable interrupt. As described in the Signal Processing Engine (SPE) Programming Environments Manual, Rev. 0, av

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

Attaching the output of the test module (above) when run on a real MPC8548. This is to establish a baseline validating which instructions shall or shall not generate the SPE/Embedded Floating-Point Unavailable interrupt. Note that on the MPC8548, it is observed that the "brinc" instruction does ge

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

Attaching the test program mentioned in the description. This program (a kernel module, in fact) can be loaded on a Linux system both in QEMU or on real hardware. In the next comments, I will attach the detailed output of the test program. ** Attachment added: "SPE test module" https://bugs.l

[RFC PATCH 2/8] migration/dirtyrate: Add block_dirty_info to store dirtypage info

From: Zheng Chuan Add block_dirty_info to store dirtypage info for each ramblock Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.h | 13 + 1 file changed, 13 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h index 9a5c228..34

[RFC PATCH 0/8] *** A Method for evaluating dirty page rate ***

From: Zheng Chuan Sometimes it is neccessary to evaluate dirty page rate before migration. Users could decide whether to proceed migration based on the evaluation in case of vm performance loss due to heavy workload. Unlikey simulating dirtylog sync which could do harm on runnning vm, we provide

[RFC PATCH 1/8] migration/dirtyrate: Add get_dirtyrate_thread() function

From: Zheng Chuan Add get_dirtyrate_thread() functions Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 63 +++ migration/dirtyrate.h | 38 +++ 2 files changed, 101 insertions(+) cr

[RFC PATCH 3/8] migration/dirtyrate: Add dirtyrate statistics series functions

From: Zheng Chuan Add dirtyrate statistics to record/update dirtyrate info. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 47 ++- migration/dirtyrate.h | 11 +++ 2 files changed, 41 insertions(+), 17 del

[RFC PATCH 5/8] migration/dirtyrate: Compare hash results for recorded ramblock

From: Zheng Chuan Compare hash results for recorded ramblock. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.

[RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

From: Zheng Chuan Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called by libvirt api. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/Makefile.objs | 1 + migration/dirtyrate.c | 45 + qapi/mi

[RFC PATCH 4/8] migration/dirtyrate: Record hash results for each ramblock

From: Zheng Chuan Record hash results for each ramblock. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 157 ++ migration/dirtyrate.h | 1 + 2 files changed, 158 insertions(+) diff --git a/migration/dirtyr

[RFC PATCH 7/8] migration/dirtyrate: Implement calculate_dirtyrate() function

From: Zheng Chuan Implement calculate_dirtyrate() function. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 53 +-- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/migration/dirtyrate.c b/migrat

[RFC PATCH 6/8] migration/dirtyrate: Implement get_sample_gap_period() and block_sample_gap_period()

From: Zheng Chuan Implement get_sample_gap_period() and block_sample_gap_period() to sleep specific time between sample actions. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 28 migration/dirtyrate.h | 6 +- 2 files chan

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

I have already written a patch for this issue, that I will be submitting to the community in the next few days. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888918 Title: qemu-ppc: Floating point

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

Attaching the output of the test module run on QEMU. As shown in the description, 39 instructions do not comply with the rule described in the Signal Processing Engine (SPE) Programming Environments Manual, Rev. 0. QEMU was run as follows: # qemu/ppc-softmmu/qemu-system-ppc -nographic -machine mp

[Bug 1611394] Re: qemu-ppc: Scalar Single-Precision Floating-Point instructions should not test MSR[SPV]

I have filed a broader ticket, Bug #1888918, reporting a very similar issue that leads to corruption/bad arithmetic when using double- precision & vector instructions. I will be submitting a patch in the next few days that will also address this ticket. -- You received this bug notification beca

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

** Changed in: qemu Assignee: (unassigned) => Matthieu Bucchianeri (matthieu-bucchianeri) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888918 Title: qemu-ppc: Floating point instructions do

[Bug 1888918] Re: qemu-system-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

** Summary changed: - qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt + qemu-system-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt ** Description changed: Whe

[PATCH v1 2/3] hw/intc: ibex_plic: Don't allow repeat interrupts on claimed lines

Once an interrupt has been claimed, but before it has been compelted we shouldn't receive any more pending interrupts. This patche keeps track of this to ensure that we don't see any more interrupts until it is completed. Signed-off-by: Alistair Francis --- include/hw/intc/ibex_plic.h | 1 + hw

[PATCH v1 0/3] hw/intc: A few fixes for the Ibex PLIC

Recently some SiFive PLIC fixes have been merged into QEMU, this applies those fixes to the Ibex PLIC as well as an update on how claiming interrupts works. Alistair Francis (3): hw/intc: ibex_plic: Update the pending irqs hw/intc: ibex_plic: Don't allow repeat interrupts on claimed lines hw

[PATCH v1 1/3] hw/intc: ibex_plic: Update the pending irqs

After a claim or a priority change we need to update the pending interrupts. This is based on the same patch for the SiFive PLIC: 55765822804f5a58594e "riscv: plic: Add a couple of mising sifive_plic_update calls" Signed-off-by: Alistair Francis Cc: Jessica Clarke --- hw/intc/ibex_plic.c | 4 ++

[PATCH v1 3/3] hw/intc: ibex_plic: Honour source priorities

This patch follows what commit aa4d30f6618dc "riscv: plic: Honour source priorities" does and ensures that the highest priority interrupt will be serviced first. Signed-off-by: Alistair Francis Cc: Jessica Clarke --- hw/intc/ibex_plic.c | 15 ++- 1 file changed, 10 insertions(+), 5

<    1   2   3