roms/seabios-hppa can't be built with gcc-10: -fno-ipa-sra

2020-07-23 Thread Michael Tokarev
Switching to gcc-10 makes seabios-hppa unbuildable. It fails at the final linking step with a lot of missing references to memcpy & memcmp all over the places. The notable difference between gcc-10 and previous gcc is that ccode32flat.o does _not_ have the text for these two functions but have two

Re: [virtio-comment] [RFC] ivshmem v2: Shared memory device specification

2020-07-23 Thread Jan Kiszka
On 23.07.20 08:54, Stefan Hajnoczi wrote: On Fri, Jul 17, 2020 at 06:15:58PM +0200, Jan Kiszka wrote: On 15.07.20 15:27, Stefan Hajnoczi wrote: On Mon, May 25, 2020 at 09:58:28AM +0200, Jan Kiszka wrote: Thanks for the responses. It would be great to update the spec with these clarifications.

Re: [PATCH] virtio: Drop broken and superfluous object_property_set_link()

2020-07-23 Thread Cornelia Huck
On Tue, 21 Jul 2020 14:11:53 +0200 Markus Armbruster wrote: > virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's > property "cryptodev" to vcrypto's property: > > object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng), > NULL);

Re: [RFC v2 19/76] target/riscv: rvv-0.9: add narrower_nanbox_fpr helper

2020-07-23 Thread Frank Chang
On Thu, Jul 23, 2020 at 3:15 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/22/20 2:15 AM, frank.ch...@sifive.com wrote: > > From: Frank Chang > > > > For floating-point operations, the scalar can be taken from a scalar > > f register. If FLEN > SEW, the value in the f registe

Re: [PATCH] Fix vhost-user buffer over-read on ram hot-unplug

2020-07-23 Thread Marc-André Lureau
On Fri, Jul 17, 2020 at 8:21 AM Raphael Norwitz wrote: > > The VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS vhost-user protocol > feature introduced a shadow-table, used by the backend to dynamically > determine how a vdev's memory regions have changed since the last > vhost_user_set_mem_table() call

Re: [PATCH for-5.1] nbd: Fix large trim/zero requests

2020-07-23 Thread Vladimir Sementsov-Ogievskiy
23.07.2020 00:22, Eric Blake wrote: Although qemu as NBD client limits requests to <2G, the NBD protocol allows clients to send requests almost all the way up to 4G. But because our block layer is not yet 64-bit clean, we accidentally wrap such requests into a negative size, and fail with EIO in

Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-23 Thread Markus Armbruster
Cc: Vladimir Laszlo Ersek writes: > On 07/21/20 10:33, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 07/20/20 14:35, Philippe Mathieu-Daudé wrote: Commits b6d7e9b66f..a43770df5d simplified the error propagation. Similarly to commit 6fd5bef10b "qom: Make functions taking E

[PATCH] trace/simple: Allow enabling simple traces from command line

2020-07-23 Thread Josh DuBois
The simple trace backend is enabled / disabled with a call to st_set_trace_file_enabled(). When initializing tracing from the command-line, this must be enabled on startup. (Prior to db25d56c014aa1a9, command-line initialization of simple trace worked because every call to st_set_trace_file enable

Re: [PATCH v2 11/20] qapi: backup: add x-max-chunk and x-max-workers parameters

2020-07-23 Thread Max Reitz
On 22.07.20 14:22, Max Reitz wrote: > On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: >> Add new parameters to configure future backup features. The patch >> doesn't introduce aio backup requests (so we actually have only one >> worker) neither requests larger than one cluster. Still, formal

Re: [PATCH v2 12/20] iotests: 56: prepare for backup over block-copy

2020-07-23 Thread Max Reitz
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > After introducing parallel async copy requests instead of plain > cluster-by-cluster copying loop, we'll have to wait for paused status, > as we need to wait for several parallel request. So, let's gently wait > instead of just asserting that

Re: [PATCH v2 13/20] iotests: 129: prepare for backup over block-copy

2020-07-23 Thread Max Reitz
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > After introducing parallel async copy requests instead of plain > cluster-by-cluster copying loop, backup job may finish earlier than > final assertion in do_test_stop. Let's require slow backup explicitly > by specifying speed parameter. Is

Re: [PATCH v0 0/4] background snapshot

2020-07-23 Thread Denis Plotnikov
On 22.07.2020 19:30, Peter Xu wrote: On Wed, Jul 22, 2020 at 06:47:44PM +0300, Denis Plotnikov wrote: On 22.07.2020 18:42, Denis Plotnikov wrote: On 22.07.2020 17:50, Peter Xu wrote: Hi, Denis, Hi, Peter ... How to use: 1. enable background snapshot capability     virsh qemu-monitor-c

Re: [PATCH v2 14/20] iotests: 185: prepare for backup over block-copy

2020-07-23 Thread Max Reitz
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > The further change of moving backup to be a on block-copy call will -on? > make copying chunk-size and cluster-size a separate things. So, even s/a/two/ > with 64k cluster sized qcow2 image, default chunk would be 1M. > 185 test however a

Re: [PATCH] spice: simplify chardev setup

2020-07-23 Thread Christophe de Dinechin
On 2020-07-22 at 13:18 CEST, Gerd Hoffmann wrote... > On Wed, Jul 22, 2020 at 12:19:43PM +0200, Christophe de Dinechin wrote: >> >> On 2020-07-22 at 11:20 CEST, Christophe de Dinechin wrote... >> > On 2020-07-22 at 10:49 CEST, Gerd Hoffmann wrote... >> >> Initialize spice before chardevs. That a

Re: [PATCH v2 15/20] iotests: 219: prepare for backup over block-copy

2020-07-23 Thread Max Reitz
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > The further change of moving backup to be a on block-copy call will -on? > make copying chunk-size and cluster-size a separate things. So, even s/a/two/ > with 64k cluster sized qcow2 image, default chunk would be 1M. > Test 219 depends o

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: > > On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: > > > On 22.07.20 19:35, Eduardo Habkost wrote: > > > > Hi Jan, > > > > > > > > What was the last version where it worke

Re: [PATCH v2 16/20] iotests: 257: prepare for backup over block-copy

2020-07-23 Thread Max Reitz
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > Iotest 257 dumps a lot of in-progress information of backup job, such > as offset and bitmap dirtiness. Further commit will move backup to be > one block-copy call, which will introduce async parallel requests > instead of plain cluster-by-cl

Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/22/20 10:40 PM, Stefan Weil wrote: Fixes: b98e8d1230 ("sd/milkymist-memcard: Plug minor memory leak in realize") Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Stefan Weil > --- > hw/sd/milkymist-memcard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw

[PATCH v2] hw/misc/edu: support pci device state migration

2020-07-23 Thread Zeng Guang
Currently edu device doesn't support live migration. Part of PCI configuration information would be lost after migration. PCI device state in source VM: Bus 0, device 3, function 0: Class 0255: PCI device 1234:11e8 PCI subsystem 1af4:1100 IRQ 11, pin A BAR0: 32 bit memo

Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems

2020-07-23 Thread Daniel P . Berrangé
On Wed, Jul 22, 2020 at 12:02:59PM -0700, Richard Henderson wrote: > On 7/22/20 9:44 AM, Daniel P. Berrangé wrote: > > OpenStack uses TCG in alot of their CI infrastructure for example > > and runs multiple VMs. If there's 4 VMs, that's another 4 GB of > > RAM usage just silently added on top of th

Re: What is TYPE_TPM_TIS_ISA? (Not an ISA Device)

2020-07-23 Thread Markus Armbruster
Stefan Berger writes: > On 7/22/20 1:55 AM, Markus Armbruster wrote: >> pm socket --tpmstate dir=tpm --ctrl type=unixio,path=tpm/swtpm-soc >> running in another terminal. >> 3/ no machine plug it using isa_register_ioport() (it is not registered to the ISA memory space) >>> There's

[PATCH-for-5.1?] qapi/error: Check format string argument in error_propagate_prepend()

2020-07-23 Thread Philippe Mathieu-Daudé
error_propagate_prepend() "behaves like error_prepend()", and error_prepend() uses "formatting @fmt, ... like printf()". error_prepend() checks its format string argument, but error_propagate_prepend() does not. Fix that. This would have catched the invalid format introduced in commit b98e8d1230f:

Re: [PATCH 3/4] error: Remove NULL checks on error_propagate() calls (again)

2020-07-23 Thread Markus Armbruster
Eric Blake writes: > On 7/22/20 3:40 AM, Markus Armbruster wrote: >> Patch created mechanically by rerunning: >> >> $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ >> --macro-file scripts/cocci-macro-file.h \ >> --use-gitgrep . >> >> Cc: Jens Fr

Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems

2020-07-23 Thread Alex Bennée
Daniel P. Berrangé writes: > On Wed, Jul 22, 2020 at 12:02:59PM -0700, Richard Henderson wrote: >> On 7/22/20 9:44 AM, Daniel P. Berrangé wrote: >> > OpenStack uses TCG in alot of their CI infrastructure for example >> > and runs multiple VMs. If there's 4 VMs, that's another 4 GB of >> > RAM u

Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 10:22:25AM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Wed, Jul 22, 2020 at 12:02:59PM -0700, Richard Henderson wrote: > >> On 7/22/20 9:44 AM, Daniel P. Berrangé wrote: > >> > OpenStack uses TCG in alot of their CI infrastructure for example > >> >

Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string

2020-07-23 Thread Markus Armbruster
Stefan Weil writes: Let's add Fixes: b98e8d1230ff7023bb34ddeb7194424dfcbaf789 > Signed-off-by: Stefan Weil > --- > hw/sd/milkymist-memcard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c > index afdb8aa0c0..11f

Re: [PATCH-for-5.1?] qapi/error: Check format string argument in error_propagate_prepend()

2020-07-23 Thread Stefan Weil
Am 23.07.20 um 11:13 schrieb Philippe Mathieu-Daudé: > error_propagate_prepend() "behaves like error_prepend()", and > error_prepend() uses "formatting @fmt, ... like printf()". > error_prepend() checks its format string argument, but > error_propagate_prepend() does not. Fix that. > > This would

Re: [PATCH v2 17/20] backup: move to block-copy

2020-07-23 Thread Max Reitz
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: > This brings async request handling and block-status driven chunk sizes > to backup out of the box, which improves backup performance. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block-copy.h | 9 +-- > block/bac

Re: [PATCH-for-5.1?] qapi/error: Check format string argument in error_propagate_prepend()

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 11:44 AM, Stefan Weil wrote: > Am 23.07.20 um 11:13 schrieb Philippe Mathieu-Daudé: > >> error_propagate_prepend() "behaves like error_prepend()", and >> error_prepend() uses "formatting @fmt, ... like printf()". >> error_prepend() checks its format string argument, but >> error_propaga

Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems

2020-07-23 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Jul 23, 2020 at 10:22:25AM +0100, Alex Bennée wrote: >> >> Daniel P. Berrangé writes: >> >> > On Wed, Jul 22, 2020 at 12:02:59PM -0700, Richard Henderson wrote: >> >> On 7/22/20 9:44 AM, Daniel P. Berrangé wrote: >> >> > OpenStack uses TCG in alot of thei

Re: Replacing existing kernel with new on qemuriscv64

2020-07-23 Thread Pankaj Vinadrao Joshi
Hi, yes am building it natively for riscv (sifive's u540 hardware ) and in /boot i am able to find System.map-5.7.2 and vmlinux-5.7.2 root@exaleapsemi:~/linux-stable# make install make: Warning: File '.vmlinux.cmd' has modification time 1221719 s in the future make[1]: Warning: File 'arch/riscv/

[PATCH-for-5.2] qapi/error: Make error_vprepend() static

2020-07-23 Thread Philippe Mathieu-Daudé
error_vprepend() is only used by util/error.c where it is defined. Make it static to reduce its scope. Signed-off-by: Philippe Mathieu-Daudé --- include/qapi/error.h | 6 -- util/error.c | 6 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/include/qapi/error.h b

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Philippe Mathieu-Daudé
+Vitaly On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: >> On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: >>> On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: On 22.07.20 19:35, Eduardo Habkost wrote: > Hi Ja

Re: please try to avoid sending pullreqs late on release-candidate day

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 8:28 AM, Markus Armbruster wrote: > Alex Bennée writes: > >> Kevin Wolf writes: >> >>> Am 21.07.2020 um 17:56 hat Peter Maydell geschrieben: It is not helpful if everybody sends their pullrequests late on the Tuesday afternoon, as there just isn't enough time in the day

[PATCH] linux-user: Use getcwd syscall directly

2020-07-23 Thread Andreas Schwab
The glibc getcwd function returns different errors than the getcwd syscall, which triggers an assertion failure in the glibc getcwd function when running under the emulation. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) dif

Re: [PATCH-for-5.2] qapi/error: Make error_vprepend() static

2020-07-23 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年7月23日周四 下午6:15写道: > > error_vprepend() is only used by util/error.c where it is > defined. Make it static to reduce its scope. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang > --- > include/qapi/error.h | 6 -- > util/error.c | 6 +

Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string

2020-07-23 Thread Li Qiang
Stefan Weil 于2020年7月23日周四 上午4:41写道: > > Signed-off-by: Stefan Weil Reviewed-by: Li Qiang > --- > hw/sd/milkymist-memcard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c > index afdb8aa0c0..11f61294fc 100644 > ---

Re: [PATCH for-5.1] Fix grammar in documentation

2020-07-23 Thread Peter Maydell
On Wed, 22 Jul 2020 at 22:06, Stefan Weil wrote: > > Signed-off-by: Stefan Weil > --- > docs/system/build-platforms.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/system/build-platforms.rst b/docs/system/build-platforms.rst > index c2b92a9698..9734eba2f1

Re: [RFC PATCH-for-5.1 2/2] tpm: List the available TPM backends

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/22/20 11:44 PM, Stefan Berger wrote: > On 7/22/20 7:23 AM, Philippe Mathieu-Daudé wrote: >> When an incorrect backend is selected, tpm_display_backend_drivers() >> is supposed to list the available backends. However the error is >> directly propagated, and we never display the list. The user o

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-23 Thread Peter Maydell
On Wed, 22 Jul 2020 at 10:00, Jason Wang wrote: > > In loopback mode, e1000e RX can DMA into TX doorbell which requires > TX to be reentrant. This patch make e1000e's TX routine reentrant by > introducing a per device boolean for recording whether or not a TX > rountine is being called and return

[PATCH-for-5.1 v2 0/2] tpm: Improve error reporting

2020-07-23 Thread Philippe Mathieu-Daudé
Improve error reporting by listing TPM backends. Philippe Mathieu-Daudé (2): tpm: Display when no backend is available tpm: List the available TPM backends tpm.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(-) -- 2.21.3

[PATCH-for-5.1 v2 1/2] tpm: Display when no backend is available

2020-07-23 Thread Philippe Mathieu-Daudé
Display "No TPM backend available in this binary." error when no backend is available. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- tpm.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tpm.c b/tpm.c index fe03b24858..e36803a64d 100644 --- a/tp

[PATCH-for-5.1 v2 2/2] tpm: List the available TPM backends

2020-07-23 Thread Philippe Mathieu-Daudé
When an incorrect backend is selected, tpm_display_backend_drivers() is supposed to list the available backends. However the error is directly propagated, and we never display the list. The user only gets "Parameter 'type' expects a TPM backend type" error. Convert the fprintf(stderr,) calls to er

Re: [PATCH v2] hw/misc/edu: support pci device state migration

2020-07-23 Thread Peter Maydell
On Thu, 23 Jul 2020 at 10:01, Zeng Guang wrote: > > Currently edu device doesn't support live migration. Part of PCI > configuration information would be lost after migration. > > PCI device state in source VM: > Bus 0, device 3, function 0: > Class 0255: PCI device 1234:11e8 > P

Re: [PULL 0/2] fw_cfg patches for 2020-07-21

2020-07-23 Thread Peter Maydell
On Tue, 21 Jul 2020 at 18:54, Philippe Mathieu-Daudé wrote: > > The following changes since commit 90218a9a393c7925f330e7dcc08658e2a01d3bd4: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07= > -21' into staging (2020-07-21 10:24:38 +0100) > > are available in the G

Re: [PATCH-for-5.1 1/2] tpm: Display when no backend is available

2020-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Display "No TPM backend available in this binary." error when > no backend is available. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tpm.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/tpm.c b/tpm.c > index fe03b24858..e36

[PATCH] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Wang King
From: Hogan Wang The pci host config register is used to save PCI address for read/write config data. If guest write a value to config register, and then pause the vcpu to migrate, After the migration, the guest continue to write pci config data, and the write data will be ignored because of new

Re: [PATCH-for-5.1 v2 2/2] tpm: List the available TPM backends

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 12:39 PM, Philippe Mathieu-Daudé wrote: > When an incorrect backend is selected, tpm_display_backend_drivers() > is supposed to list the available backends. However the error is > directly propagated, and we never display the list. The user only > gets "Parameter 'type' expects a TPM bac

Re: [PATCH 1/2] ppc: Rename current DAWR macros

2020-07-23 Thread Cornelia Huck
On Thu, 23 Jul 2020 16:12:19 +0530 Ravi Bangoria wrote: > Power10 is introducing second DAWR. Use real register names (with > suffix 0) from ISA for current macros. > > Signed-off-by: Ravi Bangoria > --- > include/hw/ppc/spapr.h | 2 +- > linux-headers/asm-powerpc/kvm.h | 4 ++-- > ta

Re: [PATCH 2/2] ppc: Enable 2nd DAWR support on p10

2020-07-23 Thread Cornelia Huck
On Thu, 23 Jul 2020 16:12:20 +0530 Ravi Bangoria wrote: > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > availability of 2nd DAWR registers. i.e. If this bit is set, 2nd > DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to > find whether kvm supports 2nd DA

Re: [RFC PATCH-for-5.1 2/2] tpm: List the available TPM backends

2020-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > When an incorrect backend is selected, tpm_display_backend_drivers() > is supposed to list the available backends. However the error is > directly propagated, and we never display the list. The user only > gets "Parameter 'type' expects a TPM backend type" error.

Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-23 Thread Laszlo Ersek
+Igor, and question below On 07/23/20 09:37, Markus Armbruster wrote: > You must use ERRP_GUARD() in functions that dereference their @errp > parameter (so that works even when the argument is null) or pass it to > error_prepend() or error_append_hint() (so they get reached even when > the argume

Re: please try to avoid sending pullreqs late on release-candidate day

2020-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/23/20 8:28 AM, Markus Armbruster wrote: >> Alex Bennée writes: >> >>> Kevin Wolf writes: >>> Am 21.07.2020 um 17:56 hat Peter Maydell geschrieben: > It is not helpful if everybody sends their pullrequests late > on the Tuesday afternoon, as th

[PATCH] qapi: enable use of g_autoptr with QAPI types

2020-07-23 Thread Daniel P . Berrangé
Currently QAPI generates a type and function for free'ing it: typedef struct QCryptoBlockCreateOptions QCryptoBlockCreateOptions; void qapi_free_QCryptoBlockCreateOptions(QCryptoBlockCreateOptions *obj); This is used in the traditional manner: QCryptoBlockCreateOptions *opts = NULL; opt

[PATCH-for-5.1?] exec/memory: Fix memory_region_init_alias() documentation

2020-07-23 Thread Philippe Mathieu-Daudé
The @size argument refers to the size of the aliased section, not the original region. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 307e527835..10a809ee1

[no subject]

2020-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > error_vprepend() is only used by util/error.c where it is > defined. Make it static to reduce its scope. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qapi/error.h | 6 -- > util/error.c | 6 +- > 2 files changed, 5 insertions(+), 7 d

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-07-23 Thread Nirman Narang
I ran the following commands: #apt install debootstrap #debootstrap_dir=debootstrap #debootstrap --arch=s390x --foreign sid "$debootstrap_dir" #sudo mkdir -p "${debootstrap_dir}/usr/bin" #sudo cp "$(which qemu-s390x-static)" "${debootstrap_dir}/usr/bin" #sudo cp "$(which qemu-s390x)" "${debootstra

Re: [PATCH for-5.1] nbd: Fix large trim/zero requests

2020-07-23 Thread Eric Blake
On 7/23/20 2:23 AM, Vladimir Sementsov-Ogievskiy wrote: 23.07.2020 00:22, Eric Blake wrote: Although qemu as NBD client limits requests to <2G, the NBD protocol allows clients to send requests almost all the way up to 4G.  But because our block layer is not yet 64-bit clean, we accidentally wrap

Re: [PATCH] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Laszlo Ersek
On 07/23/20 12:49, Wang King wrote: > From: Hogan Wang > > The pci host config register is used to save PCI address for > read/write config data. If guest write a value to config register, > and then pause the vcpu to migrate, After the migration, the guest > continue to write pci config data, an

Re: [PATCH] qapi: enable use of g_autoptr with QAPI types

2020-07-23 Thread Eric Blake
On 7/23/20 6:12 AM, Daniel P. Berrangé wrote: Currently QAPI generates a type and function for free'ing it: typedef struct QCryptoBlockCreateOptions QCryptoBlockCreateOptions; void qapi_free_QCryptoBlockCreateOptions(QCryptoBlockCreateOptions *obj); The above code example now becomes

Re: [PATCH] qapi: enable use of g_autoptr with QAPI types

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 06:49:44AM -0500, Eric Blake wrote: > On 7/23/20 6:12 AM, Daniel P. Berrangé wrote: > > Currently QAPI generates a type and function for free'ing it: > > > >typedef struct QCryptoBlockCreateOptions QCryptoBlockCreateOptions; > >void qapi_free_QCryptoBlockCreateOptio

Re: [PATCH 0/2] virtio: non-legacy device handling

2020-07-23 Thread David Hildenbrand
On 23.07.20 08:33, Cornelia Huck wrote: > On Mon, 20 Jul 2020 11:07:51 +0200 > David Hildenbrand wrote: > >> On 20.07.20 11:03, Michael S. Tsirkin wrote: >>> On Mon, Jul 20, 2020 at 10:09:57AM +0200, David Hildenbrand wrote: On 07.07.20 12:54, Cornelia Huck wrote: > As discussed in "

[PATCH for-5.1 1/2] Revert "tpm: Clean up error reporting in tpm_init_tpmdev()"

2020-07-23 Thread Markus Armbruster
This reverts commit d10e05f15d5c3dd5e5cc59c5dfff460d89d48580. We report some -tpmdev failures, but then continue as if all was fine. Reproducer: $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -chardev null,id=tpm0 -tpmdev emulator,id=tpm0,chardev=chrtpm -device tpm-tis,tpmd

[PATCH for-5.1 2/2] tpm: Improve help on TPM types when none are available

2020-07-23 Thread Markus Armbruster
Help is a bit awkward when no TPM types are built into QEMU: $ upstream-qemu -tpmdev nonexistent,id=tpm0 upstream-qemu: -tpmdev nonexistent,id=tpm0: Parameter 'type' expects a TPM backend type Supported TPM types (choose only one): Improve to upstream-qemu: -tpmdev nonexistent,i

[PATCH for-5.1 0/2] tpm: Fix error reporting, improve help

2020-07-23 Thread Markus Armbruster
The alternative to PATCH 1 is a proper conversion to Error, as discussed in Subject: Re: What is TYPE_TPM_TIS_ISA? (Not an ISA Device) Message-ID: <87tuxyoauy@dusky.pond.sub.org> Such a conversion would be much too invasive for 5.1. Going the other way, like PATCH 1 does, is simple e

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-23 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 10:25:35AM +0800, Jason Wang wrote: > > On 2020/7/22 下午8:53, Michael Tokarev wrote: > > FWIW, this is not "making TX reentrant", it is about forbidding > > reentrancy instead :) > > > > /mjt > > > Indeed, I will rename the title. Please also include a comment explaining

Re: [PATCH v2 2/3] trace: Add support for recorder back-end

2020-07-23 Thread Christophe de Dinechin
On 2020-06-30 at 15:02 CEST, Daniel P. Berrangé wrote... > On Fri, Jun 26, 2020 at 06:27:05PM +0200, Christophe de Dinechin wrote: >> The recorder library provides support for low-cost continuous >> recording of events, which can then be replayed. This makes it >> possible to collect data "after th

Re: [PATCH-for-5.1 v2 0/2] tpm: Improve error reporting

2020-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Improve error reporting by listing TPM backends. Let's first decide whether to revert commit d10e05f15d5.

Re: [PATCH 0/2] virtio: non-legacy device handling

2020-07-23 Thread Cornelia Huck
On Thu, 23 Jul 2020 13:57:08 +0200 David Hildenbrand wrote: > On 23.07.20 08:33, Cornelia Huck wrote: > > On Mon, 20 Jul 2020 11:07:51 +0200 > > David Hildenbrand wrote: > > > >> On 20.07.20 11:03, Michael S. Tsirkin wrote: > >>> On Mon, Jul 20, 2020 at 10:09:57AM +0200, David Hildenbrand w

Re: [PATCH for-5.1 2/3] virtiofsd: add container-friendly -o chroot sandboxing option

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 05:58:11PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 22, 2020 at 02:02:05PM +0100, Stefan Hajnoczi wrote: > > virtiofsd cannot run in an unprivileged container because CAP_SYS_ADMIN > > is required to create namespaces. > > > > Introduce a weaker sandbox that is suffic

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Vitaly Kuznetsov
Philippe Mathieu-Daudé writes: > +Vitaly > > On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: >> * Eduardo Habkost (ehabk...@redhat.com) wrote: >>> On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: > On 22.07.20

[PATCH v2] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Wang King
From: Hogan Wang The pci host config register is used to save PCI address for read/write config data. If guest write a value to config register, and then pause the vcpu to migrate, After the migration, the guest continue to write pci config data, and the write data will be ignored because of new

[PATCH 1/4] tests/docker: Add python3-venv and netcat to the debian-amd64 container

2020-07-23 Thread Thomas Huth
Without python3-venv, I get the following message when trying to run the acceptance tests within the debian container: The virtual environment was not created successfully because ensurepip is not available. On Debian/Ubuntu systems, you need to install the python3-venv package using the follo

[PATCH 2/4] iotests: Select a default machine for the rx and avr targets

2020-07-23 Thread Thomas Huth
If you are building only with either the new rx-softmmu or avr-softmmu target, "make check-block" fails a couple of tests since there is no default machine defined in these new targets. We have to select a machine in the "check" script for these, just like we already do for the arm- and tricore-sof

[PATCH 0/4] Test more in less time in the Gitlab-CI

2020-07-23 Thread Thomas Huth
This patch series adds two new "build-system" pipelines to the Gitlab-CI, one based on Debian and one on CentOS. We then use these build pipelines to test the targets that were missing so far (e.g. the two new targets rx-softmmu and avr-softmmu), and move some of the targets from the other build-sy

[PATCH 4/4] gitlab-ci.yml: Add build-system-debian and build-system-centos jobs

2020-07-23 Thread Thomas Huth
We were missing the two new targets avr-softmmu and rx-softmmu in the gitlab-CI so far, and did not add some of the "other endianess" targets like sh4eb-softmmu yet. Since the current build-system-* jobs run already for a very long time, let's do not add these missing targets there, but introduce t

[PATCH 3/4] tests/acceptance: Disable the rx sash and arm cubieboard replay test on Gitlab

2020-07-23 Thread Thomas Huth
These tests always time out on Gitlab, not sure what's happening here. Let's disable them until somebody has enough spare time to debug the issues. Signed-off-by: Thomas Huth --- tests/acceptance/machine_rx_gdbsim.py | 4 tests/acceptance/replay_kernel.py | 1 + 2 files changed, 5 inser

Re: [Virtio-fs] [PATCH for-5.1 2/3] virtiofsd: add container-friendly -o chroot sandboxing option

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 02:17:10PM -0400, Vivek Goyal wrote: > On Wed, Jul 22, 2020 at 02:02:05PM +0100, Stefan Hajnoczi wrote: > > virtiofsd cannot run in an unprivileged container because CAP_SYS_ADMIN > > is required to create namespaces. > > > > Introduce a weaker sandbox that is sufficient in

Re: [PATCH for-5.1 2/3] virtiofsd: add container-friendly -o chroot sandboxing option

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 06:58:20PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > virtiofsd cannot run in an unprivileged container because CAP_SYS_ADMIN > > is required to create namespaces. > > > > Introduce a weaker sandbox that is sufficient in contai

Re: [PATCH for-5.1 2/3] virtiofsd: add container-friendly -o chroot sandboxing option

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 08:03:18PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > +/* > > + * Make the shared directory the file system root so that FUSE_OPEN > > + * (lo_open()) cannot escape the shared directory by opening a symlink. > > +

Re: [PATCH 13/13] ssh: add GUri-based URI parsing

2020-07-23 Thread Richard W.M. Jones
On Thu, Jul 09, 2020 at 11:42:34PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > block/ssh.c | 75 + > 1 file changed, 58 insertions(+), 17 deletions(-) > > diff --git a/block/ssh.c b/block/ssh.c > index c8f6ad79e

Re: [PATCH 05/13] block/ssh: auto-ify URI parsing variables

2020-07-23 Thread Richard W.M. Jones
On Thu, Jul 09, 2020 at 11:42:26PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > block/ssh.c | 23 +++ > 1 file changed, 7 insertions(+), 16 deletions(-) > > diff --git a/block/ssh.c b/block/ssh.c > index 098dbe03c15..c8f6ad79e3c 100644 > --- a/

Re: [PATCH 3/4] tests/acceptance: Disable the rx sash and arm cubieboard replay test on Gitlab

2020-07-23 Thread Wainer dos Santos Moschetta
On 7/23/20 9:27 AM, Thomas Huth wrote: These tests always time out on Gitlab, not sure what's happening here. Let's disable them until somebody has enough spare time to debug the issues. It's fair to me. Signed-off-by: Thomas Huth --- tests/acceptance/machine_rx_gdbsim.py | 4 tes

Re: [PULL 0/4] AVR patches for 2020-07-21

2020-07-23 Thread Peter Maydell
On Tue, 21 Jul 2020 at 19:03, Philippe Mathieu-Daudé wrote: > > The following changes since commit 90218a9a393c7925f330e7dcc08658e2a01d3bd4: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07= > -21' into staging (2020-07-21 10:24:38 +0100) > > are available in the G

Re: [PATCH] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Michael S. Tsirkin
On Thu, Jul 23, 2020 at 06:49:35PM +0800, Wang King wrote: > From: Hogan Wang > > The pci host config register is used to save PCI address for > read/write config data. If guest write a value to config register, > and then pause the vcpu to migrate, After the migration, the guest > continue to wr

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Michael S. Tsirkin
On Fri, Jul 10, 2020 at 10:42:58AM +0100, Anthony PERARD wrote: > On Thu, Jul 02, 2020 at 07:12:08AM -0400, Michael S. Tsirkin wrote: > > memory: align to min access size > > > > If impl.min_access_size > valid.min_access_size access callbacks > > can get a misaligned access as size is increased.

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 11:05:06AM +0200, Cédric Le Goater wrote: > On 7/2/20 1:12 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 01, 2020 at 01:48:36PM +0100, Anthony PERARD wrote: > >> On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: > >>> On Wed, Jul 01, 2020 at 12:05:49PM +01

Re: [PATCH v2] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Michael S. Tsirkin
On Thu, Jul 23, 2020 at 08:23:01PM +0800, Wang King wrote: > From: Hogan Wang > > The pci host config register is used to save PCI address for > read/write config data. If guest write a value to config register, > and then pause the vcpu to migrate, After the migration, the guest > continue to wr

Re: [Virtio-fs] [PATCH for-5.1 0/3] virtiofsd: allow virtiofsd to run in a container

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 02:19:14PM -0400, Vivek Goyal wrote: > On Wed, Jul 22, 2020 at 02:02:03PM +0100, Stefan Hajnoczi wrote: > > Container runtimes handle namespace setup and remove privileges needed by > > virtiofsd to perform sandboxing. Luckily the container environment already > > provides m

Re: [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-23 Thread Stefan Hajnoczi
On Wed, Jul 22, 2020 at 06:03:28PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 22, 2020 at 02:02:06PM +0100, Stefan Hajnoczi wrote: > > An assertion failure is raised during request processing if > > unshare(CLONE_FS) fails. Implement a probe at startup so the problem can > > be detected right a

Re: [PATCH for-5.1 1/2] Revert "tpm: Clean up error reporting in tpm_init_tpmdev()"

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 1:58 PM, Markus Armbruster wrote: > This reverts commit d10e05f15d5c3dd5e5cc59c5dfff460d89d48580. > > We report some -tpmdev failures, but then continue as if all was fine. > Reproducer: > > $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -chardev > null,id=tpm0 -

Re: [PATCH for-5.1 2/2] tpm: Improve help on TPM types when none are available

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 1:58 PM, Markus Armbruster wrote: > Help is a bit awkward when no TPM types are built into QEMU: > > $ upstream-qemu -tpmdev nonexistent,id=tpm0 > upstream-qemu: -tpmdev nonexistent,id=tpm0: Parameter 'type' expects a > TPM backend type > Supported TPM types (choose only on

Re: [PATCH] qapi: enable use of g_autoptr with QAPI types

2020-07-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jul 23, 2020 at 06:49:44AM -0500, Eric Blake wrote: >> On 7/23/20 6:12 AM, Daniel P. Berrangé wrote: >> > Currently QAPI generates a type and function for free'ing it: >> > >> >typedef struct QCryptoBlockCreateOptions QCryptoBlockCreateOptions; >> >vo

Re: [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 01:46:11PM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 22, 2020 at 06:03:28PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 22, 2020 at 02:02:06PM +0100, Stefan Hajnoczi wrote: > > > An assertion failure is raised during request processing if > > > unshare(CLONE_FS) fails

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Dr. David Alan Gilbert
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > +Vitaly > > > > On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: > >> * Eduardo Habkost (ehabk...@redhat.com) wrote: > >>> On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: > On Wed, Jul

[PATCH v1] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Wang King
From: Hogan Wang The pci host config register is used to save PCI address for read/write config data. If guest write a value to config register, and then pause the vcpu to migrate, After the migration, the guest continue to write pci config data, and the write data will be ignored because of new

Re: [PATCH] qapi: enable use of g_autoptr with QAPI types

2020-07-23 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 02:50:51PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Jul 23, 2020 at 06:49:44AM -0500, Eric Blake wrote: > >> On 7/23/20 6:12 AM, Daniel P. Berrangé wrote: > >> > Currently QAPI generates a type and function for free'ing it: > >> > > >> >

Re: [PATCH] hw/pci-host: save/restore pci host config register

2020-07-23 Thread Michael S. Tsirkin
On Thu, Jul 23, 2020 at 01:48:47PM +0200, Laszlo Ersek wrote: > On 07/23/20 12:49, Wang King wrote: > > From: Hogan Wang > > > > The pci host config register is used to save PCI address for > > read/write config data. If guest write a value to config register, > > and then pause the vcpu to migra

Re: [PATCH 3/4] tests/acceptance: Disable the rx sash and arm cubieboard replay test on Gitlab

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 2:27 PM, Thomas Huth wrote: > These tests always time out on Gitlab, not sure what's happening here. > Let's disable them until somebody has enough spare time to debug the > issues. Is the Avocado cache working? Is it failing with an empty cache? If so, maybe we need to run avocado cach

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Michael Tokarev
01.07.2020 15:48, Anthony PERARD wrote: > I actually tried, but when reading `addr` or `addr+1` I had the same > value. So I guess `addr` wasn't taken into account. AFAICS, these registers aren't actually supposed to be accessed like this as addr+1. ACPI and ISA spec states multiple times that `a

  1   2   3   4   >