On Tue, 21 Jul 2020 14:11:53 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's > property "cryptodev" to vcrypto's property: > > object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng), > NULL); > > Since it does so only after realize, this always fails, but the error > is ignored. > > It's actually superfluous: vcrypto's property is an alias of > vcrypto->vdev's property, created by virtio_instance_init_common(). > > Drop the call. > > Same for virtio_ccw_crypto_realize(), virtio_rng_pci_realize(), > virtio_ccw_rng_realize(). > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/s390x/virtio-ccw-crypto.c | 3 --- > hw/s390x/virtio-ccw-rng.c | 3 --- > hw/virtio/virtio-crypto-pci.c | 2 -- > hw/virtio/virtio-rng-pci.c | 3 --- > 4 files changed, 11 deletions(-) Reviewed-by: Cornelia Huck <coh...@redhat.com>
