Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-16 Thread Claudio Fontana
Small update on this, On 7/15/20 1:10 PM, Claudio Fontana wrote: > Hi Thomas, > > On 7/14/20 4:35 PM, Thomas Huth wrote: >> On 14/07/2020 16.29, Claudio Fontana wrote: >>> Hello, >>> >>> I have some tiny progress in narrowing down this issue, possibly a qcow2 >>> issue, still unclear, >>> but in

Re: [RFC PATCH-for-5.2 v2 2/2] block/block-backend: Let blk_attach_dev() provide helpful error

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 02:37:04PM +0200, Philippe Mathieu-Daudé wrote: > Let blk_attach_dev() take an Error* object to return helpful > information. Adapt the callers. > > $ qemu-system-arm -M n800 > qemu-system-arm: sd_init failed: cannot attach blk 'sd0' to device 'sd-card' > blk 'sd0' is

Re: [PATCH v5 19/20] tests/acpi: add microvm test

2020-07-16 Thread Igor Mammedov
On Thu, 16 Jul 2020 11:10:35 +0200 Gerd Hoffmann wrote: > Hi, > > > > +data.required_struct_types = base_required_struct_types; > > > +data.required_struct_types_len = > > > ARRAY_SIZE(base_required_struct_types); > > I vaguely recall this belongs to smbios tables, does actually mic

[RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Thomas Huth
When using --enable-werror for the macOS builders in the Cirrus-CI, the atomic64 test is currently failing, and config.log shows a bunch of error messages like this: config-temp/qemu-conf.c:6:7: error: implicit declaration of function '__atomic_load_8' is invalid in C99 [-Werror,-Wimplicit-funct

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread David Gibson
On Thu, Jul 16, 2020 at 12:32:44PM +0200, Greg Kurz wrote: > On Thu, 16 Jul 2020 14:45:40 +1000 > David Gibson wrote: > > > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > > > Some recent error handling cleanups unveiled issues with our support of > > > PCI bridges: > > > > > > 1) Q

RE: [PATCH v3 0/3] Make hcd-xhci independent of pci hooks

2020-07-16 Thread Sai Pavan Boddu
Hi Gred, > -Original Message- > From: Gerd Hoffmann > Sent: Wednesday, July 15, 2020 4:21 PM > To: Sai Pavan Boddu > Cc: Peter Maydell ; Markus Armbruster > ; Thomas Huth ; Eduardo > Habkost ; qemu-devel@nongnu.org; Alistair Francis > ; 'Marc-André Lureau' > ; Ying Fang ; > Paolo Bonzini

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Alex Bennée
Robert Foley writes: > On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: >> >> >> Robert Foley writes: >> >> > The changes to console_socket.py and machine.py are to >> > cleanup for pylint and flake8. >> > >> > Signed-off-by: Robert Foley >> > --- >> > python/qemu/console_socket.py | 58 +++

Re: [PATCH v8 08/18] hw/arm/allwinner: add SD/MMC host controller

2020-07-16 Thread Philippe Mathieu-Daudé
Hi Niek, On 3/11/20 11:18 PM, Niek Linnenbank wrote: > The Allwinner System on Chip families sun4i and above contain > an integrated storage controller for Secure Digital (SD) and > Multi Media Card (MMC) interfaces. This commit adds support > for the Allwinner SD/MMC storage controller with the f

Re: TB Cache size grows out of control with qemu 5.0

2020-07-16 Thread Christian Ehrhardt
On Wed, Jul 15, 2020 at 5:58 PM BALATON Zoltan wrote: > See commit 47a2def4533a2807e48954abd50b32ecb1aaf29a and the next two > following it. > Thank you Zoltan for pointing out this commit, I agree that this seems to be the trigger for the issues I'm seeing. Unfortunately the common CI host size

[PATCH for-5.1] iotests/030: Reduce job speed to make race less likely

2020-07-16 Thread Kevin Wolf
It can happen that the throttling of the stream job doesn't make it slow enough that we can be sure that it still exists when it is referenced again. Just use a much smaller speed to make this very unlikely to happen again. Reported-by: Peter Maydell Signed-off-by: Kevin Wolf --- tests/qemu-iot

Re: [PULL 00/12] Block patches

2020-07-16 Thread Kevin Wolf
Am 16.07.2020 um 14:40 hat Peter Maydell geschrieben: > On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > > > We can "fix" it for probably all realistic cases by lowering the speed > > of the block job significantly. It's still not fully fixed for all > > theoretical cases, but the pattern of sta

Re: [PATCH v2] crypto: use a stronger private key for tests

2020-07-16 Thread Kevin Wolf
Am 15.07.2020 um 17:47 hat Daniel P. Berrangé geschrieben: > The unit tests using the x509 crypto functionality have started > failing in Fedora 33 rawhide with a message like > > The certificate uses an insecure algorithm > > This is result of Fedora changes to support strong crypto [1].

Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200716101442.48057-1-...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH v8 08/18] hw/arm/allwinner: add SD/MMC host controller

2020-07-16 Thread Philippe Mathieu-Daudé
On 3/11/20 11:18 PM, Niek Linnenbank wrote: > The Allwinner System on Chip families sun4i and above contain > an integrated storage controller for Secure Digital (SD) and > Multi Media Card (MMC) interfaces. This commit adds support > for the Allwinner SD/MMC storage controller with the following >

Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-16 Thread Alex Bennée
Robert Foley writes: > The primary purpose of this change is to clean up > machine.py's console_socket property to return a single type, > a ConsoleSocket. > > ConsoleSocket now derives from a socket, which means that > in the default case (of not draining), machine.py > will see the same behav

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 3:13 PM, Alex Bennée wrote: > > Robert Foley writes: > >> On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: >>> >>> >>> Robert Foley writes: >>> The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Signed-off-by: Robert Foley

Re: [PATCH 0/2] virtio: non-legacy device handling

2020-07-16 Thread Cornelia Huck
On Tue, 7 Jul 2020 12:54:44 +0200 Cornelia Huck wrote: > As discussed in "virtio-fs: force virtio 1.x usage", it seems like > a good idea to make sure that any new virtio device (which does not > support legacy virtio) is indeed a non-transitional device, just to > catch accidental misconfigurat

Re: [PULL 0/7] Net patches

2020-07-16 Thread Peter Maydell
On Wed, 15 Jul 2020 at 14:53, Jason Wang wrote: > > The following changes since commit 673205379fb499d2b72f2985b47ec7114282f5fe: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/python-next-20200714' into staging (2020-07-15 > 13:04:27 +0100) > > are available in the git reposito

[PATCH v2 0/3] migration: Add block-bitmap-mapping parameter

2020-07-16 Thread Max Reitz
RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg09792.html Branch: https://github.com/XanClic/qemu.git migration-bitmap-mapp

[PATCH v2 2/3] iotests.py: Add wait_for_runstate()

2020-07-16 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 3590ed78a0..fb240a334c 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -803,6 +8

[PATCH v2 1/3] migration: Add block-bitmap-mapping parameter

2020-07-16 Thread Max Reitz
This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu (

[PATCH v2 3/3] iotests: Test node/bitmap aliases during migration

2020-07-16 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/300 | 511 + tests/qemu-iotests/300.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 517 insertions(+) create mode 100755 tests/qemu-iotests/300 create mode 100644 tests/qemu-iotests/300.out

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Markus Armbruster
David Gibson writes: > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: >> Some recent error handling cleanups unveiled issues with our support of >> PCI bridges: >> >> 1) QEMU aborts when using non-standard PCI bridge types, >>unveiled by commit 7ef1553dac "spapr_pci: Drop some de

Re: [PATCH v2] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-16 Thread Peter Maydell
On Thu, 16 Jul 2020 at 07:07, Cédric Le Goater wrote: > > On 7/15/20 7:34 PM, erik-smit wrote: > > Signed-off-by: erik-smit > > Reviewed-by: Cédric Le Goater Thanks; I've put this in my list of patches to put in via target-arm.next once 5.1 is released. If I seem to have forgotten about it plea

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200716131101.18462-1-th...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH QEMU v2 4/5] ARM: PL061: Add gpiodev support

2020-07-16 Thread Geert Uytterhoeven
Hi Philippe, On Thu, Apr 23, 2020 at 12:08 PM Philippe Mathieu-Daudé wrote: > On 4/23/20 11:33 AM, Philippe Mathieu-Daudé wrote: > > On 4/23/20 11:01 AM, Geert Uytterhoeven wrote: > >> Make the PL061 GPIO controller user-creatable, and allow the user to tie > >> a newly created instance to a gpio

[RFC PATCH] os-posix: fix regression for install-less datadir location

2020-07-16 Thread Marc-André Lureau
os_find_datadir() used to check the ../share/qemu location (regardless of CONFIG_QEMU_DATADIR). It turns out that people rely on that location for running qemu in an arbitrary "install-less/portable" fashion. Change the logic to return that directory as a last resort. (this is an alternative to th

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-07-16 Thread Marc-André Lureau
Hi On Tue, Jun 16, 2020 at 2:59 AM Joe Slater wrote: > Always look for ../share/qemu then ../pc-bios when looking for datadir. > > Signed-off-by: Joe Slater > Looks good to me, with: Fixes: 6dd2dacedd83d12328 ("os-posix: simplify os_find_datadir") Reviewed-by: Marc-André Lureau Alternatively

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 15:11:01 CEST Thomas Huth wrote: > When using --enable-werror for the macOS builders in the Cirrus-CI, > the atomic64 test is currently failing, and config.log shows a bunch > of error messages like this: > > config-temp/qemu-conf.c:6:7: error: implicit declaration of

Re: [RFC PATCH] os-posix: fix regression for install-less datadir location

2020-07-16 Thread Marc-André Lureau
Hi On Thu, Jul 16, 2020 at 6:11 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > os_find_datadir() used to check the ../share/qemu location (regardless > of CONFIG_QEMU_DATADIR). It turns out that people rely on that location > for running qemu in an arbitrary "install-less/portable"

Re: [PATCH for-5.1 0/3] target/arm: MTE improvements

2020-07-16 Thread Peter Maydell
On Mon, 13 Jul 2020 at 22:33, Richard Henderson wrote: > > Since MTE is new, and guest support for MTE is still under > development, let's disable it by default. > > Peter mentioned memory hotplug on IRC as something that > would break MTE's assumptions. By putting the enable flag > on the machin

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Markus Armbruster
David Gibson writes: > On Thu, Jul 16, 2020 at 12:32:44PM +0200, Greg Kurz wrote: >> On Thu, 16 Jul 2020 14:45:40 +1000 >> David Gibson wrote: >> >> > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: >> > > Some recent error handling cleanups unveiled issues with our support of >> > >

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 03:11:01PM +0200, Thomas Huth wrote: > When using --enable-werror for the macOS builders in the Cirrus-CI, > the atomic64 test is currently failing, and config.log shows a bunch > of error messages like this: > > config-temp/qemu-conf.c:6:7: error: implicit declaration of

[PATCH for-5.1 v2 1/2] block: Require aligned image size to avoid assertion failure

2020-07-16 Thread Kevin Wolf
Unaligned requests will automatically be aligned to bl.request_alignment and we can't extend write requests to access space beyond the end of the image without resizing the image, so if we have the WRITE permission, but not the RESIZE one, it's required that the image size is aligned. Failing to m

[PATCH for-5.1 v2 2/2] file-posix: Allow byte-aligned O_DIRECT with NFS

2020-07-16 Thread Kevin Wolf
Since commit a6b257a08e3 ('file-posix: Handle undetectable alignment'), we assume that if we open a file with O_DIRECT and alignment probing returns 1, we just couldn't find out the real alignment requirement because some filesystems make the requirement only for allocated blocks. In this case, a s

[PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size

2020-07-16 Thread Kevin Wolf
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1834646 Patch 1 fixes the assertion failure by failing gracefully when opening an image whose size isn't aligned to the required request alignment. Patch 2 relaxes the restrictions for NFS, which actually supports byte alignment, but incorrectly

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Thomas Huth
On 16/07/2020 16.25, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 03:11:01PM +0200, Thomas Huth wrote: >> When using --enable-werror for the macOS builders in the Cirrus-CI, >> the atomic64 test is currently failing, and config.log shows a bunch >> of error messages like this: >> >> config-

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Thomas Huth
On 16/07/2020 16.15, Christian Schoenebeck wrote: > On Donnerstag, 16. Juli 2020 15:11:01 CEST Thomas Huth wrote: >> When using --enable-werror for the macOS builders in the Cirrus-CI, >> the atomic64 test is currently failing, and config.log shows a bunch >> of error messages like this: >> >> con

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Andrey Shinkevich
On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that f

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 17:36, Andrey Shinkevich wrote: On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of th

Re: [PATCH] util: qemu_get_thread_id for OpenBSD

2020-07-16 Thread Peter Maydell
On Wed, 15 Jul 2020 at 08:41, Brad Smith wrote: > > On 7/15/2020 12:54 AM, Thomas Huth wrote: > > On 14/07/2020 23.26, David CARLIER wrote: > >> From 9c7f54c67d40fae0174ba795fbaad829cd59c264 Mon Sep 17 00:00:00 2001 > >> From: David Carlier > >> Date: Tue, 14 Jul 2020 23:23:55 +0100 > >> Subject

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 16:01:18 +0200 Markus Armbruster wrote: > David Gibson writes: > > > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > >> Some recent error handling cleanups unveiled issues with our support of > >> PCI bridges: > >> > >> 1) QEMU aborts when using non-standard PC

Re: [PATCH-for-5.2] hw/s390x: Move S390_ADAPTER_SUPPRESSIBLE from 'css.h' to 's390_flic.h'

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 1:11 PM, Cornelia Huck wrote: > On Wed, 15 Jul 2020 15:18:45 +0200 > Philippe Mathieu-Daudé wrote: > >> Not all s390x devices require to have access to the CPU internals. >> >> To reduce the include dependencies on "s390x/css.h", move the >> S390_ADAPTER_SUPPRESSIBLE definition to "s39

[PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-16 Thread Laszlo Ersek
Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an object that has static storage duration shall be constant expressions or string literals". The compound literal produced by the make_floatx80() macro is not such a constant expression, per 6.6p7-9. (An implementation may accept

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Andrey Shinkevich
On 16.07.2020 17:38, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:36, Andrey Shinkevich wrote: On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here

Re: [PATCH for-5.1] iotests/030: Reduce job speed to make race less likely

2020-07-16 Thread Max Reitz
On 16.07.20 15:28, Kevin Wolf wrote: > It can happen that the throttling of the stream job doesn't make it slow > enough that we can be sure that it still exists when it is referenced > again. Just use a much smaller speed to make this very unlikely to > happen again. > > Reported-by: Peter Maydel

Re: [PATCH v7 01/47] block: Add child access functions

2020-07-16 Thread Max Reitz
On 13.07.20 11:06, Vladimir Sementsov-Ogievskiy wrote: > 25.06.2020 18:21, Max Reitz wrote: >> There are BDS children that the general block layer code can access, >> namely bs->file and bs->backing.  Since the introduction of filters and >> external data files, their meaning is not quite clear.  b

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 17:44, Andrey Shinkevich wrote: On 16.07.2020 17:38, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:36, Andrey Shinkevich wrote: On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list

[PATCH] docs/s390x: fix vfio-ccw type

2020-07-16 Thread Cornelia Huck
Fix the type name in the mdevctl example. Signed-off-by: Cornelia Huck --- I always seem to get this one wrong, and mdevctl does not complain until it wants to start the device... --- docs/system/s390x/vfio-ccw.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system

Re: [PATCH v7 02/47] block: Add chain helper functions

2020-07-16 Thread Max Reitz
On 13.07.20 12:18, Vladimir Sementsov-Ogievskiy wrote: > 25.06.2020 18:21, Max Reitz wrote: >> Add some helper functions for skipping filters in a chain of block >> nodes. >> >> Signed-off-by: Max Reitz >> --- >>   include/block/block_int.h |  3 +++ >>   block.c   | 55

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 16:25:18 CEST Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 03:11:01PM +0200, Thomas Huth wrote: > > When using --enable-werror for the macOS builders in the Cirrus-CI, > > the atomic64 test is currently failing, and config.log shows a bunch > > > > of error mess

Re: [PATCH v7 14/47] stream: Deal with filters

2020-07-16 Thread Max Reitz
On 10.07.20 19:41, Andrey Shinkevich wrote: > On 10.07.2020 18:24, Max Reitz wrote: >> On 09.07.20 16:52, Andrey Shinkevich wrote: >>> On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead tra

[PATCH] qapi: fix memory leak in visit_type_UserDefOneList

2020-07-16 Thread Li Qiang
While executing 'tests/test-qobject-input-visitor'. I got following error: /visitor/input/fail/alternate: OK /visitor/input/fail/union-list: OK = ==4353==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 obj

Re: [PATCH v7 17/47] block: Re-evaluate backing file handling in reopen

2020-07-16 Thread Max Reitz
On 10.07.20 21:42, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Reopening a node's backing child needs a bit of special handling because >> the "backing" child has different defaults than all other children >> (among other things).  Adding filter support here is a bit more >>

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 16:23:52 +0200 Markus Armbruster wrote: > David Gibson writes: > > > On Thu, Jul 16, 2020 at 12:32:44PM +0200, Greg Kurz wrote: > >> On Thu, 16 Jul 2020 14:45:40 +1000 > >> David Gibson wrote: > >> > >> > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > >> > >

[PATCH for-5.1] qapi: Fix visit_type_STRUCT() not to fail for null object

2020-07-16 Thread Markus Armbruster
To make deallocating partially constructed objects work, the visit_type_STRUCT() need to succeed without doing anything when passed a null object. Commit cdd2b228b9 "qapi: Smooth visitor error checking in generated code" broke that. To reproduce, run tests/test-qobject-input-visitor with AddressS

Re: [PATCH v6 0/3] modify CPU model info

2020-07-16 Thread Eduardo Habkost
On Tue, Jul 14, 2020 at 04:41:45PM +0800, Chenyi Qiang wrote: > Add the missing VMX features in Skylake-Server, Cascadelake-Server and > Icelake-Server CPU models. In Icelake-Server CPU model, it lacks sha_ni, > avx512ifma, rdpid and fsrm. The model number of Icelake-Server also needs > to be fixed

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 4:42 PM, Laszlo Ersek wrote: > Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an > object that has static storage duration shall be constant expressions or > string literals". > > The compound literal produced by the make_floatx80() macro is not such a > constant ex

Re: [PATCH v7 19/47] vmdk: Drop vmdk_co_flush()

2020-07-16 Thread Max Reitz
On 14.07.20 16:52, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Before HEAD^, we needed this because bdrv_co_flush() by itself would >> only flush bs->file.  With HEAD^, bdrv_co_flush() will flush all >> children on which a WRITE or WRITE_UNCHANGED permission has been taken.

Re: [PATCH v7 20/47] block: Iterate over children in refresh_limits

2020-07-16 Thread Max Reitz
On 14.07.20 20:37, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Instead of looking at just bs->file and bs->backing, we should look at >> all children that could end up receiving forwarded requests. >> >> Signed-off-by: Max Reitz >> --- >>   block/io.c | 32 -

Re: [PATCH 2/2] i386/cpu: Mask off unsupported XSAVE components

2020-07-16 Thread Eduardo Habkost
On Thu, Jul 16, 2020 at 04:20:19PM +0800, Xiaoyao Li wrote: > When setting up XSAVE components, it needs to mask off those unsupported > by KVM. > > Signed-off-by: Xiaoyao Li We must never disable CPUID features silently based on host capabilities, otherwise we can't guarantee guest ABI stabilit

Re: [PATCH 1/2] i386/cpu: Clear FEAT_XSAVE_COMP_{LO,HI} when XSAVE is not available

2020-07-16 Thread Eduardo Habkost
On Thu, Jul 16, 2020 at 04:20:18PM +0800, Xiaoyao Li wrote: > Per Intel SDM vol 1, 13.2, if CPUID.1:ECX.XSAVE[bit 26] is 0, the > processor provides no further enumeration through CPUID function 0DH. Can you explain what's the bug you are trying to fix? env->features[FEAT_XSAVE_COMP_*] is already

[Bug 1887820] [NEW] TCG test targets missing from 'make check-help'

2020-07-16 Thread Philippe Mathieu-Daudé
Public bug reported: We can run the TCG tests using: $ make run-tcg-tests-$TARGET-softmmu This is not listed in 'make check-help'. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [PATCH v7 21/47] block: Use CAFs in bdrv_refresh_filename()

2020-07-16 Thread Max Reitz
On 15.07.20 14:52, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> bdrv_refresh_filename() and the kind of related bdrv_dirname() should >> look to the primary child when they wish to copy the underlying file's >> filename. >> >> Signed-off-by: Max Reitz >> --- >>   block.c | 2

Re: [PATCH 1/2] i386/cpu: Clear FEAT_XSAVE_COMP_{LO, HI} when XSAVE is not available

2020-07-16 Thread Xiaoyao Li
On 7/16/2020 11:15 PM, Eduardo Habkost wrote: On Thu, Jul 16, 2020 at 04:20:18PM +0800, Xiaoyao Li wrote: Per Intel SDM vol 1, 13.2, if CPUID.1:ECX.XSAVE[bit 26] is 0, the processor provides no further enumeration through CPUID function 0DH. Can you explain what's the bug you are trying to fix

Re: [PATCH v7 02/47] block: Add chain helper functions

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 17:50, Max Reitz wrote: On 13.07.20 12:18, Vladimir Sementsov-Ogievskiy wrote: 25.06.2020 18:21, Max Reitz wrote: Add some helper functions for skipping filters in a chain of block nodes. Signed-off-by: Max Reitz ---   include/block/block_int.h |  3 +++   block.c 

Re: [PATCH 2/2] i386/cpu: Mask off unsupported XSAVE components

2020-07-16 Thread Xiaoyao Li
On 7/16/2020 11:14 PM, Eduardo Habkost wrote: On Thu, Jul 16, 2020 at 04:20:19PM +0800, Xiaoyao Li wrote: When setting up XSAVE components, it needs to mask off those unsupported by KVM. Signed-off-by: Xiaoyao Li We must never disable CPUID features silently based on host capabilities, other

Re: [PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

2020-07-16 Thread Andrey Shinkevich
On 16.07.2020 13:24, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, make a light copy of the initial __dict__ and extend the copy by adding lists we have to print in the JSON output. Signed

Re: [PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 18:34, Andrey Shinkevich wrote: On 16.07.2020 13:24, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, make a light copy of the initial __dict__ and extend the copy by adding lists

[PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

2020-07-16 Thread Peter Maydell
Add a documentation comment for qemu_get_thread_id(): since this is rather host-OS-specific it's useful if people writing the implementation and people thinking of using the function know what the purpose and limitations are. Signed-off-by: Peter Maydell --- Based on conversation with Dan on IRC,

[PATCH] introduce VFIO-over-socket protocol specificaion

2020-07-16 Thread Thanos Makatos
This patch introduces the VFIO-over-socket protocol specification, which is designed to allow devices to be emulated outside QEMU, in a separate process. VFIO-over-socket reuses the existing VFIO defines, structs and concepts. It has been earlier discussed as an RFC in: "RFC: use VFIO over a UNIX

Re: [PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

2020-07-16 Thread Andrey Shinkevich
On 16.07.2020 18:40, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 18:34, Andrey Shinkevich wrote: On 16.07.2020 13:24, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, make a light copy of

[Bug 1880822] Re: CVE-2020-13253 QEMU: sd: OOB access could crash the guest resulting in DoS

2020-07-16 Thread Philippe Mathieu-Daudé
Fixed in commit 790762e54871143415bffcec4cb3c022c3cd. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880822 Title: CVE-2020-1325

Re: [PATCH for-5.1] qapi: Fix visit_type_STRUCT() not to fail for null object

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200716150617.4027356-1-arm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs

2020-07-16 Thread Reza Arbab
On Thu, Jul 16, 2020 at 06:42:11AM -0300, Daniel Henrique Barboza wrote: Which would translate here to: uint32_t associativity[] = { cpu_to_be32(0x4), cpu_to_be32(nvslot->numa_id), cpu_to_be32(nvslot->numa_id), cpu_to_be32(nvslot->numa_id),

Re: [PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 18:52, Andrey Shinkevich wrote: On 16.07.2020 18:40, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 18:34, Andrey Shinkevich wrote: On 16.07.2020 13:24, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: As __dict__ is being extended with class members w

Re: [PATCH v3 7/9] tz-ppc: add dummy read/write methods

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:31, P J P wrote: > > From: Prasad J Pandit > > Add tz-ppc-dummy mmio read/write methods to avoid assert failure > during initialisation. > > Signed-off-by: Prasad J Pandit > -- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH] e1000e: using bottom half to send packets

2020-07-16 Thread Li Qiang
Alexander Bulekov reported a UAF bug related e1000e packets send. -->https://bugs.launchpad.net/qemu/+bug/1886362 This is because the guest trigger a e1000e packet send and set the data's address to e1000e's MMIO address. So when the e1000e do DMA it will write the MMIO again and trigger re-entra

Re: [PATCH for-5.1] qapi: Fix visit_type_STRUCT() not to fail for null object

2020-07-16 Thread Li Qiang
Markus Armbruster 于2020年7月16日周四 下午11:07写道: > > To make deallocating partially constructed objects work, the > visit_type_STRUCT() need to succeed without doing anything when passed > a null object. > > Commit cdd2b228b9 "qapi: Smooth visitor error checking in generated > code" broke that. To repr

Re: [PATCH v3 8/9] imx7-ccm: add digprog mmio write method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:31, P J P wrote: > > From: Prasad J Pandit > > Add digprog mmio write method to avoid assert failure during > initialisation. > > Reviewed-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/misc/imx7_ccm.c | 7 +++ > 1 file changed, 7 insertions(+) > > Updat

Re: TB Cache size grows out of control with qemu 5.0

2020-07-16 Thread Alex Bennée
Christian Ehrhardt writes: > On Wed, Jul 15, 2020 at 5:58 PM BALATON Zoltan wrote: > >> See commit 47a2def4533a2807e48954abd50b32ecb1aaf29a and the next two >> following it. >> > > Thank you Zoltan for pointing out this commit, I agree that this seems to be > the trigger for the issues I'm see

Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method

2020-07-16 Thread Peter Maydell
On Mon, 29 Jun 2020 at 12:18, Li Qiang wrote: > > P J P 于2020年6月25日周四 上午3:01写道: > > > > From: Prasad J Pandit > > > > Add nrf51_soc mmio read method to avoid NULL pointer dereference > > issue. > > > > Reported-by: Lei Sun > > Signed-off-by: Prasad J Pandit > > --- > > hw/nvram/nrf51_nvm.c |

Re: [PATCH v3 5/9] nvram: add nrf51_soc flash read method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:31, P J P wrote: > > From: Prasad J Pandit > > Add nrf51_soc mmio read method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Signed-off-by: Prasad J Pandit > --- > hw/nvram/nrf51_nvm.c | 5 + > 1 file changed, 5 insertions(+) > > Update v3:

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-16 Thread Alex Bennée
Laszlo Ersek writes: > Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an > object that has static storage duration shall be constant expressions or > string literals". > > The compound literal produced by the make_floatx80() macro is not such a > constant expression, per 6.

Re: [PATCH v3 6/9] spapr_pci: add spapr msi read method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:31, P J P wrote: > > From: Prasad J Pandit > > Add spapr msi mmio read method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Acked-by: David Gibson > Reviewed-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/ppc/spapr_pci.c | 13 ++

Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs

2020-07-16 Thread Daniel Henrique Barboza
On 7/16/20 1:00 PM, Reza Arbab wrote: On Thu, Jul 16, 2020 at 06:42:11AM -0300, Daniel Henrique Barboza wrote: Which would translate here to:    uint32_t associativity[] = {    cpu_to_be32(0x4),    cpu_to_be32(nvslot->numa_id),    cpu_to_be32(nvslot->numa_id),    

Re: [PATCH] gitlab-ci.yml: Add fuzzer tests

2020-07-16 Thread Alexander Bulekov
On 200716 1209, Thomas Huth wrote: > So far we neither compile-tested nor run any of the new fuzzers in our CI, > which led to some build failures of the fuzzer code in the past weeks. > To avoid this problem, add a job to compile the fuzzer code and run some > loops (which likely don't find any ne

[PATCH] gitlab-ci.yml: Add oss-fuzz build tests

2020-07-16 Thread Alexander Bulekov
This tries to build and run the fuzzers with the same build-script used by oss-fuzz. This doesn't guarantee that the builds on oss-fuzz will also succeed, since oss-fuzz provides its own compiler and fuzzer vars, but it can catch changes that are not compatible with the the ./scripts/oss-fuzz/build

Re: [PATCH v3 2/9] pci-host: add pcie-msi read method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:30, P J P wrote: > > From: Prasad J Pandit > > Add pcie-msi mmio read method to avoid NULL pointer dereference > issue. This change is specific to the designware pci host controller; it would be nice to have "designware" in the commit subject. > Reported-by: Lei Sun

Re: [PATCH] introduce VFIO-over-socket protocol specificaion

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1594913503-52271-1-git-send-email-thanos.maka...@nutanix.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TES

Re: [PATCH] introduce VFIO-over-socket protocol specificaion

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1594913503-52271-1-git-send-email-thanos.maka...@nutanix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1594913503-52271-1-git-send-email-thanos.maka...@nutanix.com Subject: [

Re: [PATCH v3 8/9] imx7-ccm: add digprog mmio write method

2020-07-16 Thread P J P
+-- On Thu, 16 Jul 2020, Peter Maydell wrote --+ | > +static void imx7_digprog_write(void *opaque, hwaddr addr, | > +uint64_t data, unsigned size) | > +{ | > +qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__); | > +} | | This covers a single reg

Re: [PATCH v3 8/9] imx7-ccm: add digprog mmio write method

2020-07-16 Thread Peter Maydell
On Thu, 16 Jul 2020 at 17:55, P J P wrote: > > +-- On Thu, 16 Jul 2020, Peter Maydell wrote --+ > | > +static void imx7_digprog_write(void *opaque, hwaddr addr, > | > +uint64_t data, unsigned size) > | > +{ > | > +qemu_log_mask(LOG_UNIMP, "%s not impleme

Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-16 Thread Robert Foley
On Thu, 16 Jul 2020 at 09:42, Alex Bennée wrote: > > > +self._drain_thread = None > > +socket.socket.__init__(self, socket.AF_UNIX, socket.SOCK_STREAM) > > +self.connect(address) > > +self._drain = drain > > We end up with two variables that represent the fact we h

[PATCH v4 for-5.2 0/2] spapr: Improve error reporting in spapr_caps.c

2020-07-16 Thread Greg Kurz
Nested KVM HV only works if the kernel is using the radix MMU mode, ie. the CPU is POWER9 and it is not running in some pre-power9 compat mode. Otherwise, the KVM HV module fails to load in the guest with -ENODEV. It might be painful for a user to discover this late that nested cannot work with the

[PATCH v4 for-5.2 2/2] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-07-16 Thread Greg Kurz
Nested KVM HV only works if the kernel is using the radix MMU mode, ie. the CPU is POWER9 and it is not running in some pre-power9 compat mode. Otherwise, the KVM HV module fails to load in the guest with -ENODEV. It might be painful for a user to discover this late that nested cannot work with the

[PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-16 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes &error_fatal, all functions must also call the ERRP_GUARD() macro for error_append_hint() to be functional. While h

Re: [PATCH v3 9/9] memory: assert MemoryRegionOps callbacks are defined

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:31, P J P wrote: > > From: Prasad J Pandit > > When registering a MemoryRegionOps object, assert that its > read/write callback methods are defined. This avoids potential > guest crash via a NULL pointer dereference. > > Suggested-by: Peter Maydell > Reviewed-by: Li Qia

Re: [PATCH v3 1/9] hw/pci-host: add pci-intack write method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:29, P J P wrote: > > From: Prasad J Pandit > > Add pci-intack mmio write method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Reviewed-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/pci-host/prep.c | 8 > 1 file changed, 8 i

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:30, P J P wrote: > > From: Prasad J Pandit > > Add vfio quirk device mmio write method to avoid NULL pointer > dereference issue. > > Reported-by: Lei Sun > Reviewed-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/vfio/pci-quirks.c | 8 > 1 file cha

<    1   2   3   >