On Thu, 16 Jul 2020 11:10:35 +0200 Gerd Hoffmann <kra...@redhat.com> wrote:
> Hi, > > > > + data.required_struct_types = base_required_struct_types; > > > + data.required_struct_types_len = > > > ARRAY_SIZE(base_required_struct_types); > > I vaguely recall this belongs to smbios tables, does actually microvm > > provide them? > > Checked. Yes, it tests smbios tables. > > seabios generates something in case qemu doesn't provide smbios tables, > so the test works. We don't actually test qemu though, so it probably > makes sense to drop that for microvm until we actually generate smbios > tables. Should we? if dropping it just works, then yes, otherwise I wouldn't bother. > > take care, > Gerd >
