Re: [PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

2020-07-13 Thread Alex Bennée
Richard Henderson writes: > On 7/9/20 7:13 AM, Alex Bennée wrote: >> Not all compilers support the -Wpsabi (clang-9 in my case). >> >> Fixes: bac8d222a >> Signed-off-by: Alex Bennée >> --- >> tests/plugin/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t

Re: [RFC 00/65] target/riscv: support vector extension v0.9

2020-07-13 Thread Richard Henderson
On 7/12/20 7:02 PM, Frank Chang wrote: > Does decodetree support any feature for multi-version opcodes? > Or if it can use something like C macros to compile with the opcodes by the > vspec > user assigned? If there's any good way to keep both versions, then I can try > to > rearrange > my codes

Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-13 Thread Babu Moger
On 7/13/20 11:17 AM, Igor Mammedov wrote: > On Mon, 13 Jul 2020 10:02:22 -0500 > Babu Moger wrote: > >>> -Original Message- >>> From: Igor Mammedov >>> Sent: Monday, July 13, 2020 4:08 AM >>> To: Moger, Babu >>> Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- >>

Re: [RFC 00/65] target/riscv: support vector extension v0.9

2020-07-13 Thread Frank Chang
On Tue, Jul 14, 2020 at 12:41 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/12/20 7:02 PM, Frank Chang wrote: > > Does decodetree support any feature for multi-version opcodes? > > Or if it can use something like C macros to compile with the opcodes by > the vspec > > user ass

Re: [PATCH v3 03/11] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 6:36 PM, Philippe Mathieu-Daudé wrote: > On 6/15/20 4:06 PM, Peter Maydell wrote: >> On Fri, 5 Jun 2020 at 11:25, Philippe Mathieu-Daudé >> wrote: >>> >>> From: Philippe Mathieu-Daudé >>> >>> Only move the state machine to ReceivingData if there is no >>> pending error. This avoids l

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-13 Thread Kevin Wolf
Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > Unaligned requests will automatically be aligned to bl.request_alignment > > and we don't want to extend requests to access space beyond the end of > > the image, so it's required that th

Re: [PATCH v5 03/12] python/machine.py: Add _early_cleanup hook

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > Some parts of cleanup need to occur prior to shutdown, otherwise > shutdown might break. Move this into a suitably named method/callback. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 24 +++- > 1 file changed, 15 inserti

[PATCH v5] scripts/simplebench: compare write request performance

2020-07-13 Thread Andrey Shinkevich
The script 'bench_write_req.py' allows comparing performances of write request for two qemu-img binary files. An example with (qemu-img binary 1) and without (qemu-img binary 2) the applied patch "qcow2: skip writing zero buffers to empty COW areas" (git commit ID: c8bb23cbdbe32f5) has the followin

Re: [PATCH v5 01/12] python/machine.py: consolidate _post_shutdown()

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > Move more cleanup actions into _post_shutdown. As a change, if QEMU > should so happen to be terminated during a call to wait(), that event > will now be logged. > > This is not likely to occur during normative use. > > Signed-off-by: John Snow > --- > pyt

Re: [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait() calls, too

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > This is primarily for consistency, and is a step towards wait() and > shutdown() sharing the same implementation so that the two cleanup paths > cannot diverge. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 1 + > 1 file changed, 1 insertion

Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-13 Thread Igor Mammedov
On Mon, 13 Jul 2020 11:43:33 -0500 Babu Moger wrote: > On 7/13/20 11:17 AM, Igor Mammedov wrote: > > On Mon, 13 Jul 2020 10:02:22 -0500 > > Babu Moger wrote: > > > >>> -Original Message- > >>> From: Igor Mammedov > >>> Sent: Monday, July 13, 2020 4:08 AM > >>> To: Moger, Babu > >>>

Re: [RFC 62/65] fpu: add api to handle alternative sNaN propagation

2020-07-13 Thread Chih-Min Chao
On Fri, Jul 10, 2020 at 8:15 PM Alex Bennée wrote: > > frank.ch...@sifive.com writes: > > > From: Chih-Min Chao > > > > Signed-off-by: Chih-Min Chao > > Signed-off-by: Frank Chang > > --- > > fpu/softfloat.c | 68 + > > include/fpu/softfloat.h |

Re: [PATCH v5 09/11] hw/ssi: NPCM7xx Flash Interface Unit device model

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/12/20 7:42 AM, Havard Skinnemoen wrote: > On Thu, Jul 9, 2020 at 10:00 AM Philippe Mathieu-Daudé > wrote: >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >>> This implements a device model for the NPCM7xx SPI flash controller. >>> >>> Direct reads and writes, and user-mode transactions have b

[PATCH 1/2] i368/cpu: Clear env->user_features after loading versioned CPU model

2020-07-13 Thread Xiaoyao Li
Features defined in versioned CPU model are recorded in env->user_features since they are updated as property. It's unwated because they are not user specified. Simply clear env->user_features as a fix. It won't clear user specified features because user specified features are filled to env->user_

[PATCH 0/2] Fixes for env->user_features

2020-07-13 Thread Xiaoyao Li
Patch 1 fixes the env->features set by versioned CPU model. Patch 2 fixed the env->features set by unavailable_features due to feature_dependencies[] checking. Xiaoyao Li (2): i368/cpu: Clear env->user_features after loading versioned CPU model i386/cpu: Don't add unavailable_features to env-

[PATCH 2/2] i386/cpu: Don't add unavailable_features to env->user_features

2020-07-13 Thread Xiaoyao Li
Features unavailable due to absent of their dependent features should not be added to env->user_features. env->user_features only contains the feature explicity specified with -feature/+feature by user. Fixes: 99e24dbdaa68 ("target/i386: introduce generic feature dependency mechanism") Signed-off

[Bug 1884719] Re: Function not implemented when using libaio

2020-07-13 Thread Martin Grigorov
Could I help somehow to resolve this issue ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1884719 Title: Function not implemented when using libaio Status in QEMU: New Bug description: Hello

Re: [PATCH] docker.py: fix fetching of FROM layers

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 4:58 PM, Alex Bennée wrote: > This worked on a system that was already bootstrapped because the > stage 2 images already existed even if they wouldn't be used. What we > should have pulled down was the FROM line containers first because > building on gitlab doesn't have the advantage of

Re: [PATCH v5 06/11] hw/arm: Load -bios image as a boot ROM for npcm7xx

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > If a -bios option is specified on the command line, load the image into > the internal ROM memory region, which contains the first instructions > run by the CPU after reset. > > A minimal Apache-2.0-licensed boot ROM can be found at > > https://github

Seeing a problem in multi hw thread runs where memory mapped pcie device register reads are returning incorrect values using QEMU 4.2

2020-07-13 Thread Mark Wood-Patrick
Background == I have a test environment which runs QEMU 4.2 with a plugin that runs two copies of a PCIE device simulator on Ubuntu 18.04/CentOS 7.5 host and with an Ubuntu 18.04 guest. When running with a single QEMU hw thread/CPU using: -cpu kvm64,+lahf_lm -M q35,kernel-irqc

[PULL 1/3] migration: fix memory leak in qmp_migrate_set_parameters

2020-07-13 Thread Juan Quintela
From: Zheng Chuan "tmp.tls_hostname" and "tmp.tls_creds" allocated by migrate_params_test_apply() is forgot to free at the end of qmp_migrate_set_parameters(). Fix that. The leak stack: Direct leak of 2 byte(s) in 2 object(s) allocated from: #0 0xb597c20b in __interceptor_malloc (/usr/lib

[PULL 3/3] migration/migration.c: Remove superfluous breaks

2020-07-13 Thread Juan Quintela
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang Signed-off-by: Yi Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- migration/migration.c | 2 -- 1 f

[PULL 2/3] migration/savevm: respect qemu_fclose() error code in save_snapshot()

2020-07-13 Thread Juan Quintela
From: "Denis V. Lunev" qemu_fclose() could return error, f.e. if bdrv_co_flush() will return the error. This validation will become more important once we will start waiting of asynchronous IO operations, started from bdrv_write_vmstate(), which are coming soon. Signed-off-by: Denis V. Lunev R

[PULL 0/3] Migration patches

2020-07-13 Thread Juan Quintela
The following changes since commit 9f526fce49c6ac48114ed04914b5a76e4db75785: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-misc-110720-2' into staging (2020-07-12 15:32:05 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/mig

[PATCH for-5.1 3/4] docs/system: Briefly document gumstix boards

2020-07-13 Thread Peter Maydell
Add skeletal documentation of the gumstix boards ('connex' and 'verdex'). Signed-off-by: Peter Maydell --- docs/system/arm/gumstix.rst | 21 + docs/system/target-arm.rst | 1 + MAINTAINERS | 1 + 3 files changed, 23 insertions(+) create mode 100644 docs/sy

[PATCH for-5.1 2/4] docs/system: Briefly document collie board

2020-07-13 Thread Peter Maydell
Add skeletal documentation of the collie board. Signed-off-by: Peter Maydell --- docs/system/arm/collie.rst | 16 docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 18 insertions(+) create mode 100644 docs/system/arm/collie.rst diff --git a/

[PATCH for-5.1 0/4] Document virt and a few other Arm boards

2020-07-13 Thread Peter Maydell
This series adds some documentation to the system manual for previously undocumented Arm board types. The first 3 patches are very minimalist documentation of the canon-a1000, collie and gumstix board families. The info was obtained by looking at source code comments, a brief scan of what kinds o

[PATCH for-5.1 4/4] docs/system: Document the arm virt board

2020-07-13 Thread Peter Maydell
Document the arm 'virt' board, which has been undocumented for far too long given that it is the main recommended board type for arm guests. Signed-off-by: Peter Maydell --- docs/system/arm/virt.rst | 157 + docs/system/target-arm.rst | 1 + MAINTAINERS

[PATCH for-5.1 1/4] docs/system: Briefly document canon-a1100 board

2020-07-13 Thread Peter Maydell
Add skeletal documentation of the canon-a1100 board. Signed-off-by: Peter Maydell --- docs/system/arm/digic.rst | 11 +++ docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 13 insertions(+) create mode 100644 docs/system/arm/digic.rst diff --git a/d

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 4:57 PM, Cédric Le Goater wrote: > On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >> This allows these NPCM7xx-based boards to boot from a flash image, e.g. >> one built with OpenBMC. For example like this: >> >> IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc >> qemu-system-arm -mac

Re: [PULL 0/4] Fixes 20200713 patches

2020-07-13 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/fixes-20200713-pull-request > > for you to fetch changes up to 631009e775a91018a62e2670b4473e99916f858f: > > usb: fix u

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 7:59 PM, Philippe Mathieu-Daudé wrote: > On 7/13/20 4:57 PM, Cédric Le Goater wrote: >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >>> This allows these NPCM7xx-based boards to boot from a flash image, e.g. >>> one built with OpenBMC. For example like this: >>> >>> IMAGE=${OPENBMC}/buil

Re: [PATCH 0/2] Fixes for env->user_features

2020-07-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200713174436.41070-1-xiaoyao...@intel.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

[Bug 1838763] Re: Bugs in SSH module (ssh.c)

2020-07-13 Thread Thomas Huth
I think that libssh in Ubuntu 18.04 is just broken. I don't think that we'll include a work-around in QEMU for this anymore, now that 20.04 is already released and works fine. Thus closing this as WONTFIX. ** Changed in: qemu Status: Confirmed => Won't Fix -- You received this bug notific

[PATCH] gitlab-ci/containers: Add missing wildcard where we should look for changes

2020-07-13 Thread Thomas Huth
The tests/docker/* wildcard seems to only match the files that are directly in the tests/docker folder - but changes to the files in the directory tests/docker/dockerfiles are currently ignored. Seems like we need a separate entry to match the files in that folder. With this wildcard added, the sta

Re: [PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

2020-07-13 Thread Thomas Huth
On 13/07/2020 18.39, Alex Bennée wrote: > > Richard Henderson writes: > >> On 7/9/20 7:13 AM, Alex Bennée wrote: >>> Not all compilers support the -Wpsabi (clang-9 in my case). >>> >>> Fixes: bac8d222a >>> Signed-off-by: Alex Bennée >>> --- >>> tests/plugin/Makefile | 2 +- >>> 1 file changed,

[PATCH v2 0/9] hw/sd/sdcard: Fix CVE-2020-13253

2020-07-13 Thread Philippe Mathieu-Daudé
This series fixes CVE-2020-13253 by only allowing SD card image sizes power of 2, and not switching to SEND_DATA state when the address is invalid (out of range). Patches missing review: 3: boot_linux: Tag tests using a SD card with 'device:sd' 4: boot_linux: Expand SD card image to power of 2

[PATCH v2 1/9] MAINTAINERS: Cc qemu-block mailing list

2020-07-13 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé We forgot to include the qemu-block mailing list while adding this section in commit 076a0fc32a7. Fix this. Suggested-by: Paolo Bonzini Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200630133912.9428-2-f4...@amsat.org> --- MAINTA

[PATCH v2 2/9] docs/orangepi: Add instructions for resizing SD image to power of two

2020-07-13 Thread Philippe Mathieu-Daudé
From: Niek Linnenbank SD cards need to have a size of a power of two. Update the Orange Pi machine documentation to include instructions for resizing downloaded images using the qemu-img command. Signed-off-by: Niek Linnenbank Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200712183708.154

[PATCH v2 7/9] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-13 Thread Philippe Mathieu-Daudé
QEMU allows to create SD card with unrealistic sizes. This could work, but some guests (at least Linux) consider sizes that are not a power of 2 as a firmware bug and fix the card size to the next power of 2. While the possibility to use small SD card images has been seen as a feature, it became a

[PATCH v2 5/9] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards

2020-07-13 Thread Philippe Mathieu-Daudé
Only SCSD cards support Class 6 (Block Oriented Write Protection) commands. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.14 Command Functional Difference in Card Capacity Types * Write Protected Group SDHC and SDXC do not support write-protected groups. Issuing

[PATCH v2 3/9] tests/acceptance/boot_linux: Tag tests using a SD card with 'device:sd'

2020-07-13 Thread Philippe Mathieu-Daudé
Avocado tags are handy to automatically select tests matching the tags. Since these tests use a SD card, tag them. We can run all the tests using a SD card at once with: $ avocado --show=app run -t u-boot tests/acceptance/ $ AVOCADO_ALLOW_LARGE_STORAGE=ok \ avocado --show=app \ run

[PATCH v2 4/9] tests/acceptance/boot_linux: Expand SD card image to power of 2

2020-07-13 Thread Philippe Mathieu-Daudé
In few commits we won't allow SD card images with invalid size (not aligned to a power of 2). Prepare the tests: add the pow2ceil() and image_pow2ceil_expand() methods and resize the images (expanding) of the tests using SD cards. Signed-off-by: Philippe Mathieu-Daudé --- Since v1: Addressed revi

[PATCH v2 9/9] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-13 Thread Philippe Mathieu-Daudé
Only move the state machine to ReceivingData if there is no pending error. This avoids later OOB access while processing commands queued. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.3 Data Read Read command is rejected if BLOCK_LEN_ERROR or ADDRESS_ERROR occurred

[PATCH v2 6/9] hw/sd/sdcard: Simplify realize() a bit

2020-07-13 Thread Philippe Mathieu-Daudé
We don't need to check if sd->blk is set twice. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20200630133912.9428-18-f4...@amsat.org> --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/s

[PATCH v2 8/9] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

2020-07-13 Thread Philippe Mathieu-Daudé
To make the next commit easier to review, clean this code first. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20200630133912.9428-3-f4...@amsat.org> --- hw/sd/sd.c | 24 1 file changed, 16 insertions(+), 8

Re: [PATCH 1/2] i368/cpu: Clear env->user_features after loading versioned CPU model

2020-07-13 Thread Eduardo Habkost
On Tue, Jul 14, 2020 at 01:44:35AM +0800, Xiaoyao Li wrote: > Features defined in versioned CPU model are recorded in env->user_features > since they are updated as property. It's unwated because they are not > user specified. > > Simply clear env->user_features as a fix. It won't clear user speci

Re: [PATCH] linux-user: syscall: ioctls: support DRM_IOCTL_I915_GETPARAM

2020-07-13 Thread Laurent Vivier
Le 12/07/2020 à 05:41, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > It is for i915 drm command, and next, I shall send another i915 commands > implementations. > > Signed-off-by: Chen Gang > --- > linux-user/ioctls.h| 3 +++ > linux-user/syscall.c | 39 +

Re: [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols

2020-07-13 Thread Laurent Vivier
Le 07/07/2020 à 02:10, Josh Kunz a écrit : > Linux uses the EPROTONOSUPPORT error code[1] if the users requests a > netlink socket with an unsupported netlink protocol. This change > switches linux-user to use the same code as Linux, instead of > EPFNOSUPPORT (which AFAIK is just an anachronistic v

Re: [PATCH for-5.1 3/4] docs/system: Briefly document gumstix boards

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 7:57 PM, Peter Maydell wrote: > Add skeletal documentation of the gumstix boards > ('connex' and 'verdex'). > > Signed-off-by: Peter Maydell > --- > docs/system/arm/gumstix.rst | 21 + > docs/system/target-arm.rst | 1 + > MAINTAINERS | 1 + > 3

Re: [PATCH 2/2] i386/cpu: Don't add unavailable_features to env->user_features

2020-07-13 Thread Eduardo Habkost
On Tue, Jul 14, 2020 at 01:44:36AM +0800, Xiaoyao Li wrote: > Features unavailable due to absent of their dependent features should > not be added to env->user_features. env->user_features only contains the > feature explicity specified with -feature/+feature by user. > > Fixes: 99e24dbdaa68 ("tar

[RFC PATCH] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

2020-07-13 Thread Thomas Huth
The libssh problem only exists in Ubuntu 18.04 - we can enable it in 20.04 again. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/docker/dockerfiles/ubuntu2004.docker b/tests/docker/dockerfiles/ubuntu2004.dock

Re: [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks

2020-07-13 Thread P J P
+-- On Tue, 30 Jun 2020, P J P wrote --+ | * This series asserts that MemoryRegionOps objects define read/write | callback methods. Thus avoids potential NULL pointer dereference. | ex. -> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2 | | * Also adds va

Re: [PATCH v2 3/9] tests/acceptance/boot_linux: Tag tests using a SD card with 'device:sd'

2020-07-13 Thread Alistair Francis
On Mon, Jul 13, 2020 at 11:34 AM Philippe Mathieu-Daudé wrote: > > Avocado tags are handy to automatically select tests matching > the tags. Since these tests use a SD card, tag them. > > We can run all the tests using a SD card at once with: > > $ avocado --show=app run -t u-boot tests/acceptan

Re: [PATCH] target/arm/kvm: Remove superfluous break

2020-07-13 Thread Richard Henderson
On 7/12/20 5:33 PM, Yi Wang wrote: > From: Liao Pingfang > > Remove superfluous break. > > Signed-off-by: Liao Pingfang > --- > target/arm/kvm64.c | 1 - > 1 file changed, 1 deletion(-) CC: Peter Maydell. Reviewed-by: Richard Henderson r~

Re: [RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > fpu/softfloat-specialize.inc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson This one should go into 5.1. Are you collecting, Alex? r~

Re: [RFC PATCH 2/8] fpu/softfloat: use the similiar logic to recognize sNaN and qNaN

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > fpu/softfloat-specialize.inc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fpu/softfloat-specialize.inc.c b/fpu/softfloat-specialize.inc.c > index 034d18199c..6b778a7830 100644 > --- a/

Re: [RFC PATCH 3/8] fpu/softfloat: add FloatFmt for bfloat16

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > fpu/softfloat.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-13 Thread Lijun Pan
> On Jul 13, 2020, at 12:14 AM, David Gibson > wrote: > > On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: >> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. >> >> Signed-off-by: Lijun Pan >> --- >> v4: add missing changes, and split to 5/11, 6/11, 7/11 >> v3: use

Re: [RFC PATCH 3/8] fpu/softfloat: add FloatFmt for bfloat16

2020-07-13 Thread Richard Henderson
On 7/13/20 12:18 PM, Richard Henderson wrote: > On 7/12/20 4:45 PM, LIU Zhiwei wrote: >> Signed-off-by: LIU Zhiwei >> --- >> fpu/softfloat.c | 4 >> 1 file changed, 4 insertions(+) > > Reviewed-by: Richard Henderson Actually, it occurs to me that clang probably warns for unused variable.

Re: [PATCH v3 1/2] linux-user: refactor ipc syscall

2020-07-13 Thread Laurent Vivier
Le 10/07/2020 à 14:46, Laurent Vivier a écrit : > Le 26/06/2020 à 14:46, Matus Kysel a écrit : >> Refactoring ipc syscall for s390x and SPARC, so it matches glibc >> implementation >> >> Signed-off-by: Matus Kysel >> --- >> linux-user/syscall.c | 26 +- >> 1 file changed,

Re: [PATCH v3 2/2] linux-user: support of semtimedop syscall

2020-07-13 Thread Laurent Vivier
Le 26/06/2020 à 14:46, Matus Kysel a écrit : > We should add support of semtimedop syscall as new version of glibc > 2.31 uses semop based on semtimedop > (commit: > https://gitlab.com/freedesktop-sdk/mirrors/sourceware/glibc/-/commit/765cdd0bffd77960ae852104fc4ea5edcdb8aed3 > ). > > Signed-off-

Re: [RFC PATCH 4/8] fpu/softfloat: add pack and unpack interfaces for bfloat16

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > fpu/softfloat.c | 20 > 1 file changed, 20 insertions(+) Similarly, all of the static inlines are unused and clang will warn. Needs merging with subsequent. Otherwise the actual code looks good. r~

Re: [PATCH] linux-user: Fix Coverity CID 1430271 / CID 1430272

2020-07-13 Thread Laurent Vivier
Le 09/07/2020 à 22:00, Laurent Vivier a écrit : > In new functions print_ioctl() and print_syscall_ret_ioctl(), we don't > check if lock_user() returns NULL and this would cause a segfault in > thunk_print(). > > If lock_user() returns NULL don't call thunk_print() but prints only the > value of t

Re: [PATCH 1/2] linux-user: add new netlink types

2020-07-13 Thread Laurent Vivier
Le 09/07/2020 à 09:23, Laurent Vivier a écrit : > Only implement IFLA_PERM_ADDRESS to fix the following error: > > Unknown host QEMU_IFLA type: 54 > > The couple of other ones, IFLA_PROP_LIST and IFLA_ALT_IFNAME, have > been introduced to be used with RTM_NEWLINKPROP, RTM_DELLINKPROP and > RTM_

Re: [RFC PATCH 5/8] fpu/softfloat: define brain floating-point types

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > include/fpu/softfloat-types.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/fpu/softfloat-types.h b/include/fpu/softfloat-types.h > index 7680193ebc..8f8fdfeecf 100644 > --- a/include/fpu/softflo

Re: [PATCH 2/2] linux-user: add netlink RTM_SETLINK command

2020-07-13 Thread Laurent Vivier
Le 09/07/2020 à 09:23, Laurent Vivier a écrit : > This command is needed to be able to boot systemd in a container. > > $ sudo systemd-nspawn -D /chroot/armhf/sid/ -b > Spawning container sid on /chroot/armhf/sid. > Press ^] three times within 1s to kill container. > systemd 245.6-2 runnin

Re: [PATCH] linux-user: Add several IFTUN ioctls

2020-07-13 Thread Laurent Vivier
Le 10/07/2020 à 21:53, Josh Kunz a écrit : > This change includes most widely-available if_tun ioctls that are > integer typed. > > Tested by compiling all linux-user emulators. This patch has also been > used successfully to run several binaries that utilize these ioctls for > several months. >

Re: [PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err()

2020-07-13 Thread Laurent Vivier
Le 08/07/2020 à 17:24, Laurent Vivier a écrit : > errno of the target is returned as a negative value by the syscall, > not in the host errno variable. > > The emulation of the target syscall can return an error while the > host doesn't set an errno value. Target errnos and host errnos can > also

RE: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-13 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Monday, July 13, 2020 12:32 PM > To: Moger, Babu > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- > de...@nongnu.org > Subject: Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from > CpuInstanceProperties > > On

Re: [PATCH v3] target/ppc: add vmsumudm vmsumcud instructions

2020-07-13 Thread Lijun Pan
> On Jul 6, 2020, at 2:53 AM, David Gibson wrote: > > On Mon, Jun 22, 2020 at 11:25:01PM -0500, Lijun Pan wrote: >> vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo >> VA-form. >> vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned >> Doubleword VA

Re: [RFC PATCH 6/8] fpu/softfloat: define operation for bfloat16

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > @@ -3039,7 +3143,7 @@ static FloatParts scalbn_decomposed > return return_nan(a, s); > } > if (a.cls == float_class_normal) { > -/* The largest float type (even though not supported by FloatParts) > +/* The largest float typ

Re: [PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative

2020-07-13 Thread Laurent Vivier
Le 08/07/2020 à 17:24, Laurent Vivier a écrit : > print_syscall_err() relies on the sign of the returned value to know > if it is an errno value or not. > > But in some cases the returned value can have the most signicant bit > set without being an errno. > > This patch restores previous behaviou

Re: [PATCH v2 8/9] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

2020-07-13 Thread Alexander Bulekov
On 200713 2032, Philippe Mathieu-Daudé wrote: > To make the next commit easier to review, clean this code first. > > Reviewed-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis > Message-Id: <20200630133912.9428-3-f4...@amsat.org> > --- Reviewed-by: Alexa

Re: [RFC PATCH 7/8] fpu/softfloat: define covert operation for bfloat16

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > fpu/softfloat.c | 223 > include/fpu/softfloat.h | 48 + > 2 files changed, 271 insertions(+) Reviewed-by: Richard Henderson Some "brain" references in here too.

Re: [RFC PATCH] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 8:52 PM, Thomas Huth wrote: > The libssh problem only exists in Ubuntu 18.04 - we can enable it > in 20.04 again. > > Signed-off-by: Thomas Huth > --- > tests/docker/dockerfiles/ubuntu2004.docker | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/docker/dockerfiles/ubun

Re: [PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

2020-07-13 Thread Alex Bennée
Thomas Huth writes: > On 13/07/2020 18.39, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 7/9/20 7:13 AM, Alex Bennée wrote: Not all compilers support the -Wpsabi (clang-9 in my case). Fixes: bac8d222a Signed-off-by: Alex Bennée --- tests/plugin/

Re: [PATCH v2 2/9] docs/orangepi: Add instructions for resizing SD image to power of two

2020-07-13 Thread Alistair Francis
On Mon, Jul 13, 2020 at 11:32 AM Philippe Mathieu-Daudé wrote: > > From: Niek Linnenbank > > SD cards need to have a size of a power of two. > Update the Orange Pi machine documentation to include > instructions for resizing downloaded images using the > qemu-img command. > > Signed-off-by: Niek

Re: [PATCH v4 08/11] target/ppc: add vmulh{su}w instructions

2020-07-13 Thread Lijun Pan
> On Jul 1, 2020, at 6:43 PM, Lijun Pan wrote: > > vmulhsw: Vector Multiply High Signed Word > vmulhuw: Vector Multiply High Unsigned Word > > Signed-off-by: Lijun Pan > --- > Reviewed-by: Richard Henderson > v3: inline the helper_vmulh{su}w multiply directly instead of using macro > v2: fi

Re: [RFC PATCH 8/8] fpu/softfloat: define misc operation for bfloat16

2020-07-13 Thread Richard Henderson
On 7/12/20 4:45 PM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > fpu/softfloat-specialize.inc.c | 38 +++ > include/fpu/softfloat.h| 41 ++ > 2 files changed, 79 insertions(+) Reviewed-by: Richard Henderson s/brain fl

Re: [PATCH v4 10/11] target/ppc: add vmulh{su}d instructions

2020-07-13 Thread Lijun Pan
> On Jul 1, 2020, at 6:47 PM, Lijun Pan wrote: > > vmulhsd: Vector Multiply High Signed Doubleword > vmulhud: Vector Multiply High Unsigned Doubleword > > Signed-off-by: Lijun Pan > --- > Reviewed-by: Richard Henderson > v3: simplify helper_vmulh{su}d > v2: fix coding style >use Power

Re: [PATCH v4 11/11] target/ppc: add vdiv{su}{wd} vmod{su}{wd} instructions

2020-07-13 Thread Lijun Pan
> On Jul 1, 2020, at 6:47 PM, Lijun Pan wrote: > > vdivsw: Vector Divide Signed Word > vdivuw: Vector Divide Unsigned Word > vdivsd: Vector Divide Signed Doubleword > vdivud: Vector Divide Unsigned Doubleword > vmodsw: Vector Modulo Signed Word > vmoduw: Vector Modulo Unsigned Word > vmodsd: V

Re: [PATCH v2 4/9] tests/acceptance/boot_linux: Expand SD card image to power of 2

2020-07-13 Thread Alistair Francis
On Mon, Jul 13, 2020 at 11:34 AM Philippe Mathieu-Daudé wrote: > > In few commits we won't allow SD card images with invalid size > (not aligned to a power of 2). Prepare the tests: add the > pow2ceil() and image_pow2ceil_expand() methods and resize the > images (expanding) of the tests using SD c

Re: [PATCH v2 7/9] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-13 Thread Alistair Francis
On Mon, Jul 13, 2020 at 11:33 AM Philippe Mathieu-Daudé wrote: > > QEMU allows to create SD card with unrealistic sizes. This could > work, but some guests (at least Linux) consider sizes that are not > a power of 2 as a firmware bug and fix the card size to the next > power of 2. > > While the po

Re: [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 8:58 PM, P J P wrote: > +-- On Tue, 30 Jun 2020, P J P wrote --+ > | * This series asserts that MemoryRegionOps objects define read/write > | callback methods. Thus avoids potential NULL pointer dereference. > | ex. -> > https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1

Re: [PATCH v4 07/11] target/ppc: add vmulld to INDEX_op_mul_vec case

2020-07-13 Thread Lijun Pan
> On Jul 1, 2020, at 6:43 PM, Lijun Pan wrote: > > Group vmuluwm and vmulld. Make vmulld-specific > changes since it belongs to new ISA 3.1. > > Signed-off-by: Lijun Pan > --- > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style >us

Re: [PATCH v1] target/riscv: fix pmp implementation

2020-07-13 Thread Alistair Francis
On Mon, Jul 13, 2020 at 3:10 AM Alexandre Mergnat wrote: > > Le ven. 10 juil. 2020 à 22:35, Alistair Francis a > écrit : > > > > On Mon, Jul 6, 2020 at 2:45 AM Alexandre Mergnat > > wrote: > > > > > > The end address calculation for NA4 mode is wrong because the address > > > used isn't shifte

[Bug 1884719] Re: Function not implemented when using libaio

2020-07-13 Thread Laurent Vivier
Martin, do you want to propose some patches to fix the problem? Thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1884719 Title: Function not implemented when using libaio Status in QEMU: N

Re: [RFC PATCH] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

2020-07-13 Thread Alex Bennée
Thomas Huth writes: > The libssh problem only exists in Ubuntu 18.04 - we can enable it > in 20.04 again. Queued to misc/for-5.1-rc0, thanks. > > Signed-off-by: Thomas Huth > --- > tests/docker/dockerfiles/ubuntu2004.docker | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/do

Re: [RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

2020-07-13 Thread Alex Bennée
LIU Zhiwei writes: > Signed-off-by: LIU Zhiwei Queued to misc/for-5.1-rc0, thanks. -- Alex Bennée

[PATCH v2 00/11] misc fixes for rc0 (docker, plugins, softfloat)

2020-07-13 Thread Alex Bennée
Hi, These are some candidate patches for rc0 along with a few plugin patches that haven't yet gotten review. The new functionality won't get added to the PR but I'd like to get the cputlb fix in. I've also had another run at fixing the -Wpsabi problem. The following still need review: - docs/de

[PATCH v2 04/11] fpu/softfloat: fix up float16 nan recognition

2020-07-13 Thread Alex Bennée
From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200712234521.3972-2-zhiwei_...@c-sky.com> --- fpu/softfloat-specialize.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat-specialize.inc

[PATCH v2 01/11] configure: remove all dependencies on a (re)configure

2020-07-13 Thread Alex Bennée
The previous code was brittle and missed cases such as the mipn32 variants which for some reason has the 64 bit syscalls. This leads to a number of binary targets having deps lines like: all.clang-sanitizer/mipsn32el-linux-user/linux-user/signal.d 140: /home/alex/lsrc/qemu.git/linux-user/mips

[PATCH v2 10/11] plugins: add API to return a name for a IO device

2020-07-13 Thread Alex Bennée
This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée [r-b provisional given change to g_intern_string] Reviewed-by: Clement Deschamps Reviewed-by: Emilio G. Cota --- v3 - return a non-freeable const g_intern_string() - checkpatch cleanups --- inc

[PATCH v2 02/11] tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

2020-07-13 Thread Alex Bennée
From: Thomas Huth The libssh problem only exists in Ubuntu 18.04 - we can enable it in 20.04 again. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200713185237.9419-1-th...@redhat.com> --- tests/docker/dockerfiles/ubuntu2004.docker |

[PATCH v2 06/11] cputlb: ensure we save the IOTLB data in case of reset

2020-07-13 Thread Alex Bennée
Any write to a device might cause a re-arrangement of memory triggering a TLB flush and potential re-size of the TLB invalidating previous entries. This would cause users of qemu_plugin_get_hwaddr() to see the warning: invalid use of qemu_plugin_get_hwaddr because of the failed tlb_lookup which

[PATCH v2 08/11] docs/devel: fix grammar in multi-thread-tcg

2020-07-13 Thread Alex Bennée
Review comment came just too late ;-) Signed-off-by: Alex Bennée --- docs/devel/multi-thread-tcg.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/multi-thread-tcg.rst b/docs/devel/multi-thread-tcg.rst index 42158b77c7..21483870db 100644 --- a/docs/devel/multi-th

[PATCH v2 09/11] hw/virtio/pci: include vdev name in registered PCI sections

2020-07-13 Thread Alex Bennée
When viewing/debugging memory regions it is sometimes hard to figure out which PCI device something belongs to. Make the names unique by including the vdev name in the name string. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- v2 - swap ()

[PATCH v2 05/11] tests/plugins: don't unconditionally add -Wpsabi

2020-07-13 Thread Alex Bennée
Not all compilers support the -Wpsabi (clang-9 in my case). To handle this gracefully we pare back the shared build machinery so the Makefile is relatively "standalone". We still take advantage of config-host.mak as configure has done a bunch of probing for us but that is it. Fixes: bac8d222a Sign

[PATCH v2 03/11] docker.py: fix fetching of FROM layers

2020-07-13 Thread Alex Bennée
This worked on a system that was already bootstrapped because the stage 2 images already existed even if they wouldn't be used. What we should have pulled down was the FROM line containers first because building on gitlab doesn't have the advantage of using our build system to build the pre-requisi

<    1   2   3   4   5   >