On 11.07.2020 22:11, Vladimir Sementsov-Ogievskiy wrote:
03.07.2020 16:13, Andrey Shinkevich wrote:
Read and dump entries from the bitmap directory of QCOW2 image.
It extends the output in the test case #291.
...
diff --git a/tests/qemu-iotests/qcow2_format.py
b/tests/qemu-iotests/qcow2_fo
On 7/12/20 8:37 PM, Niek Linnenbank wrote:
> SD cards need to have a size of a power of two. This commit updates
> the Orange Pi machine documentation to include instructions for
> resizing downloaded images using the qemu-img command.
>
> Signed-off-by: Niek Linnenbank
> ---
> docs/system/arm/o
On 09/07/2020 12.13, Philippe Mathieu-Daudé wrote:
> On 7/9/20 10:55 AM, Erik Skultety wrote:
>> On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote:
>>> This script is intended to be used right after a push to a branch.
>>>
>>> By default, it will look for the pipeline associated with the
12.07.2020 15:00, Simon John wrote:
> macos guests no longer boot after commit
> 5d971f9e672507210e77d020d89e0e89165c8fc9
>
> acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows 4
> bytes.
>
> Fixes: 5d971f9e672507210e7 (memory: Revert "memory: accept mismatching sizes
On 7/11/2020 12:48 AM, Eduardo Habkost wrote:
On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote:
On 7/10/2020 6:12 AM, Eduardo Habkost wrote:
I'm very sorry for taking so long to review this. Question
below:
On Fri, Jun 19, 2020 at 03:31:11PM +0800, Chenyi Qiang wrote:
Add s
Add the command key to the qcow2.py arguments list to dump QCOW2
metadata in JSON format. Here is the suggested way to do that. The
implementation of the dump in JSON format is in the patch that follows.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/qcow2.py| 19 +++
Let us differ binary data type from string one for the extension data
variable and keep the string as the QcowHeaderExtension class member.
Signed-off-by: Andrey Shinkevich
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/qcow2_format.py | 14 ---
Add bitmap table information to the QCOW2 metadata dump.
It extends the output of the test case #291
Bitmap name bitmap-1
...
Bitmap table typeoffset size
0 serialized 4718592 65536
1 serialized 4294
There are two ways to initialize a class derived from Qcow2Struct:
1. Pass a block of binary data to the constructor.
2. Pass the file descriptor to allow reading the file from constructor.
Let's change the Qcow2BitmapExt initialization method from 1 to 2 to
support a scattered reading in the initi
As __dict__ is being extended with class members we do not want to
print, make a light copy of the initial __dict__ and extend the copy
by adding lists we have to print in the JSON output.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/qcow2_format.py | 4
1 file changed, 4 inserti
Read and dump entries from the bitmap directory of QCOW2 image.
It extends the output in the test case #291.
Header extension:
magic 0x23852875 (Bitmaps)
...
Bitmap name bitmap-1
bitmap_table_offset 0xf
bitmap_table_size 1
flags
Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py.
v9:
01: In patch 0003, removed explicit constructor in the class Qcow2BitmapExt.
02: In patch 0004, the format string was changed.
Andrey Shinkevich (10):
qcow2: Fix capitalization of header extension constant.
The cluster size of an image is the QcowHeader class member and may be
obtained by dependent extension structures such as Qcow2BitmapExt for
further bitmap table details print.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/qcow2_format.py | 17 +++--
1 file changed, 11 inse
Introduce the class BitmapFlags that parses a bitmap flags mask.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/qcow2_format.py | 16
1 file changed, 16 insertions(+)
diff --git a/tests/qemu-iotests/qcow2_format.py
b/tests/q
Make the capitalization of the hexadecimal numbers consistent for the
QCOW2 header extension constants in docs/interop/qcow2.txt.
Suggested-by: Eric Blake
Signed-off-by: Andrey Shinkevich
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 2 +-
docs/interop/qcow2.txt | 2 +-
Implementation of dumping QCOW2 image metadata.
The sample output:
{
"Header_extensions": [
{
"name": "Feature table",
"magic": 1745090647,
"length": 192,
"data_str": ""
},
{
"name": "Bitmaps",
"magi
On 10/07/2020 12.55, Cornelia Huck wrote:
> On Thu, 9 Jul 2020 18:04:39 +0200
> Thomas Huth wrote:
>
>> There is some additional information about the 3270 support in our
>> Wiki at https://wiki.qemu.org/Features/3270 - so let's include this
>> information into the main documentation now to have
13.07.2020 10:20, Michael Tokarev пишет:
> 12.07.2020 15:00, Simon John wrote:
>> macos guests no longer boot after commit
>> 5d971f9e672507210e77d020d89e0e89165c8fc9
>>
>> acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows
>> 4 bytes.
>>
>> Fixes: 5d971f9e672507210e7 (me
On 7/13/2020 3:23 PM, Chenyi Qiang wrote:
On 7/11/2020 12:48 AM, Eduardo Habkost wrote:
On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote:
On 7/10/2020 6:12 AM, Eduardo Habkost wrote:
I'm very sorry for taking so long to review this. Question
below:
On Fri, Jun 19, 2020 at 03
There is some additional information about the 3270 support in our Wiki
at https://wiki.qemu.org/Features/3270 - so let's include this information
into the main documentation now to have one single source of information
(the Wiki page could later be removed).
While at it, I also shortened the line
On Jun 30 13:04, Philippe Mathieu-Daudé wrote:
> Improvements for the I/O BAR structure:
> - correct pmrmsc register size (Klaus)
> - pack structures
> - align to 4KB
>
> Since v2:
> - Added Klaus' tags with correct address
>
> $ git backport-diff -u v2
> Key:
> [] : patches are identical
> [
On 7/1/20 7:17 AM, Erik Smit wrote:
> Hi Joel,
>
> On Wed, 1 Jul 2020 at 02:54, Joel Stanley wrote:
>>
>> On Tue, 30 Jun 2020 at 15:32, Erik Smit wrote:
>>>
>>> Hi Philippe,
>>>
>>> On Tue, 30 Jun 2020 at 17:29, Philippe Mathieu-Daudé
>>> wrote:
Hi Erik,
On 6/30/20 5:11 PM,
On 11.07.20 10:57, Alex Bennée wrote:
>
> Max Reitz writes:
>
>> Otherwise the result is basically unpredictable.
>>
>> (Note that the precise environment variable to control sorting order is
>> LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
>> sorting order to be messed up
Hi Cédric,
On Mon, 13 Jul 2020 at 09:52, Cédric Le Goater wrote:
>
> With this patch, the supermicro firmware boots further but there is still
> an issue. It might be the flash definition I used. The machine is detected
> as an AST2300 SoC which is weird.
> BMC flash ID:0x19ba20
> Unable to hand
Hi,
On 7/11/20 2:28 PM, 林奕帆 wrote:
> Hello
> I am a student from Fudan University in China. I am doing research on
> CVE patch recently. But i can not find the PATCH COMMIT of
> CVE-2019-12247 cve-2019-12155 cve-2019-6778.Can you give me the commit
> fix this cve?
* CVE-2019-12247
I don't kno
On 7/10/20 11:57 PM, John Snow wrote:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> Signed-off-by: John Snow
> ---
> MAINTAINERS | 9 +
On 7/10/20 8:22 PM, Alex Bennée wrote:
> Like the sed we include earlier we want something more recent for
> iotests to work.
>
> Fixes: 57ee95ed
> Cc: Max Reitz
> Signed-off-by: Alex Bennée
> ---
> .cirrus.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.cirru
13.07.2020 10:07, Andrey Shinkevich wrote:
On 11.07.2020 22:11, Vladimir Sementsov-Ogievskiy wrote:
03.07.2020 16:13, Andrey Shinkevich wrote:
Read and dump entries from the bitmap directory of QCOW2 image.
It extends the output in the test case #291.
...
diff --git a/tests/qemu-iotests/q
This is a regression from commit d2623129a7d ("qom: Drop parameter @errp
of object_property_add() & friends").
(qemu) chardev-add id=null,backend=null
(qemu) chardev-add id=null,backend=null
Unexpected error in object_property_try_add() at
/home/elmarco/src/qemu/qom/object.c:1166:
attempt to add
The following changes since commit d34498309cff7560ac90c422c56e3137e6a64b19:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/avr-port-20200711'
into staging (2020-07-11 19:27:59 +0100)
are available in the Git repository at:
https://github.com/elmarco/qemu.git tags/chardev-pull-req
From: Li Feng
When the disconnect event is triggered in the connecting stage,
the tcp_chr_disconnect_locked may be called twice.
The first call:
#0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at
chardev/char-socket.c:120
#1 0x5558e38c in tcp_chr_disconnect_locked (chr=)
With a reconnect socket, qemu_char_open() will start a background
thread. It should keep a reference on the chardev.
Fixes invalid read:
READ of size 8 at 0x604ac858 thread T7
#0 0x598d37b8 in unix_connect_saddr
/home/elmarco/src/qq/util/qemu-sockets.c:954
#1 0x598d4751 in soc
From: Philippe Mathieu-Daudé
This test never required "chardev/char-mux.h", remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-3-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
tests/test-char.c | 1 -
1 file changed, 1 del
From: Philippe Mathieu-Daudé
The msmouse / wctablet / testdev character devices are only
used by system emulation. Remove them from user mode and tools.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-4-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc
From: Philippe Mathieu-Daudé
monitor/misc.c never required "chardev/char-mux.h", remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-2-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
monitor/misc.c | 1 -
1 file changed, 1 d
From: Philippe Mathieu-Daudé
Split out code only used during system emulation,
to reduce code pulled in user emulation and tools.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-6-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
cha
From: Philippe Mathieu-Daudé
No file out of chardev/ requires access to this header,
restrict its scope.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200423202112.644-5-phi...@redhat.com>
Reviewed-by: Richard Henderson
Signed-off-by: Marc-André Lureau
---
include/chardev/char-mux.h =
Hi
On Mon, Jul 13, 2020 at 12:16 PM Philippe Mathieu-Daudé
wrote:
> * CVE-2019-6778
>
> This one is in SLiRP, Cc'ing Samuel and Marc-André.
I was about to send a patch to update slirp to 4.3.1. Note that this
particular CVE should be fixed since 4.1, where "emu" support is
disabled.
On 7/13/20 10:06 AM, Erik Smit wrote:
> Hi Cédric,
>
> On Mon, 13 Jul 2020 at 09:52, Cédric Le Goater wrote:
>>
>> With this patch, the supermicro firmware boots further but there is still
>> an issue. It might be the flash definition I used. The machine is detected
>> as an AST2300 SoC which is
Switch from stable-4.2 branch back to master (which is actually
maintained, I think we tend to forget about stable...).
git shortlog 2faae0f7..a62d3673:
5eraph (2):
disable_dns option
limit vnameserver_addr to port 53
Akihiro Suda (1):
libslirp.h: fix SlirpConfig v3 documentati
13.07.2020 07:49, Andrey Shinkevich wrote:
On 11.07.2020 19:34, Vladimir Sementsov-Ogievskiy wrote:
03.07.2020 16:13, Andrey Shinkevich wrote:
There are two ways to initialize a class derived from Qcow2Struct:
1. Pass a block of binary data to the constructor.
2. Pass the file descriptor to all
On Sat, 11 Jul 2020 at 18:07, Alex Bennée wrote:
>
> Fixed a few, dropped a few, added a few
>
> ---
>
> The following changes since commit 827937158b72ce2265841ff528bba3c44a1bfbc8:
>
> Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20200710' into
> staging (2020-07-11 13:56:03 +01
Hello,
On 7/13/20 10:06 AM, Erik Smit wrote:
> Hi Cédric,
>
> On Mon, 13 Jul 2020 at 09:52, Cédric Le Goater wrote:
>>
>> With this patch, the supermicro firmware boots further but there is still
>> an issue. It might be the flash definition I used. The machine is detected
>> as an AST2300 SoC w
On Thu, 25 Jun 2020 07:50:11 +0300
Jon Doron wrote:
> Signed-off-by: Jon Doron
Reviewed-by: Igor Mammedov
> ---
> hw/i386/acpi-build.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 91af0d2d0d..1f938a
On 7/10/20 4:04 PM, Philippe Mathieu-Daudé wrote:
> On 7/8/20 11:52 AM, Stefan Hajnoczi wrote:
>>
>> There is a snowball effect where the experience is improved the more
>> GitLab features we use, so I hope that most of these migrations will
>> be possible.
>
> I've been looking at other features
On Thu, 25 Jun 2020 07:50:09 +0300
Jon Doron wrote:
> After doing further tests and looking at the latest HyperV ACPI DSDT.
> Do minor fix to our VMBus ACPI entry.
Michael,
could you queue it for 5.1, pls?
> v4:
> * Removed the patch which adds _ADR definition to the VMBus
> * Correct the cha
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two qemu-img binary files.
An example with (qemu-img binary 1) and wi
On Thu, 25 Jun 2020 07:50:09 +0300
Jon Doron wrote:
> After doing further tests and looking at the latest HyperV ACPI DSDT.
> Do minor fix to our VMBus ACPI entry.
Jon,
vmbus feature needs a testcase, could you look into it please?
(see tests/qtest/bios-tables-test.c for an example.
also look i
On Fri, Jul 10, 2020 at 10:03:56PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > Total execution time with "-m slow" and x86_64 QEMU, drops from 3
> > minutes 15 seconds, down to 54 seconds.
> >
> > Individual tests drop from 17-20 seconds, down to 3-4 seconds.
>
> Nice!
>
On Mon, 29 Jun 2020 16:09:37 +0200
Andrew Jones wrote:
> The flash device is exclusively for the host-controlled firmware, so
> we should not expose it to the OS. Exposing it risks the OS messing
> with it, which could break firmware runtime services and surprise the
> OS when all its changes dis
On Mon, 13 Jul 2020 at 09:39, Philippe Mathieu-Daudé wrote:
>
> On 7/10/20 4:04 PM, Philippe Mathieu-Daudé wrote:
>
> > 7/ License Compliance
> >
> > https://docs.gitlab.com/ee/user/compliance/license_compliance/
>
> WRT IRC feedback QEMU licensing is a lost cause, I can not tell,
> but I think if
On Fri, Jul 03, 2020 at 08:34:50PM +0200, Philippe Mathieu-Daudé wrote:
(Was on PTO; just catching up.)
> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
>
> Cc: Laszlo Ersek
> Cc: Gerd Hoffma
On Thu, Jun 25, 2020 at 9:55 PM Vivek Goyal wrote:
>
> On Thu, Jun 25, 2020 at 12:19:39PM +0900, Chirantan Ekbote wrote:
> [..]
> > > Chirantan,
> > >
> > > So you ended up renaming all "trusted", "security" and "system" xattrs?
> > > Only "user" xattrs are complete passthrough?
> > >
> >
> > No,
In some shells, we can't use == sign (as example, in dash).
Signed-off-by: Alexey Kirillov
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 31e2ddbf28..f65914f98f 100755
--- a/configure
+++ b/configure
@@ -6486,7 +6486,7 @@ EOF
fi
if
Hi Peter,
On 6/28/20 11:42 PM, Peter Maydell wrote:
> Replace the free-floating set of IRQs and palmte_onoff_gpios()
> function with a simple QOM device that encapsulates this
> behaviour.
>
> This fixes Coverity issue CID 1421944, which points out that
> the memory returned by qemu_allocate_irqs
On Mon, 13 Jul 2020 at 10:37, Cédric Le Goater wrote:
> On 7/13/20 10:06 AM, Erik Smit wrote:
> > On Mon, 13 Jul 2020 at 09:52, Cédric Le Goater wrote:
> >>
> >> With this patch, the supermicro firmware boots further but there is still
> >> an issue. It might be the flash definition I used. The m
From: Liao Pingfang
Remove superfluous break.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/arm/kvm64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 1169237..ef1e960 100644
--- a/target/
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
tcg/riscv/tcg-target.inc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/ris
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before it.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
fsdev/virtfs-proxy-helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/
Hi Alexey,
On 7/13/20 10:55 AM, Alexey Kirillov wrote:
> In some shells, we can't use == sign (as example, in dash).
>
> Signed-off-by: Alexey Kirillov
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 31e2ddbf28..f65914f98
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
scsi/utils.c | 4
1 file changed, 4 deletions(-)
diff --git a/scsi/utils.c b/scsi/utils.c
index c50e81f..b37c2
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/ppc/misc_helper.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/target/ppc/misc_helper.c b/target/p
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
migration/migration.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/migration/migration.c b/migration/migratio
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
block/vmdk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 28cec50..8f222e3
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/pflash_cfi01.c | 1 -
hw/display/cirrus_vga.c | 1 -
hw/display/qxl-logger.c | 2 --
hw/gpio/
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/sh4/translate.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/sh4/translate.c b/target/sh4/tran
From: Liao Pingfang
Remove the superfluous break, as there is a "return" before.
Signed-off-by: Liao Pingfang a
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
ui/vnc-enc-tight.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 1e
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/cris/translate.c | 7 +++
target/cris/translate_v10.inc.c | 2 --
2 files changed, 3 insertions(+)
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
---
target/openrisc/sys_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/openrisc/sys_helper.c b/targ
Hello,
Ping...
Anyone have comments about this path?
To reduce the downtime during checkpoints, the patch tries to migrate
memory page as many as possible just before entering COLO state.
Thanks.
Regards,
Derek
On 2020/6/21 上午10:10, Derek Su wrote:
To reduce the guest's downtime during che
25.06.2020 18:21, Max Reitz wrote:
There are BDS children that the general block layer code can access,
namely bs->file and bs->backing. Since the introduction of filters and
external data files, their meaning is not quite clear. bs->backing can
be a COW source, or it can be a filtered child; b
On 7/13/20 11:04 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove the superfluous break, as there is a "return" before it.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
Hmm I never reviewed this patch, only the openrisc one:
https://lists
On 10.07.20 18:12, Max Reitz wrote:
> On 07.07.20 18:17, Kevin Wolf wrote:
>> Am 07.07.2020 um 16:23 hat Kevin Wolf geschrieben:
>>> Espeically when O_DIRECT is used with image files so that the page cache
>>> indirection can't cause a merge of allocating requests, the file will
>>> fragment on the
On Wed, 01 Jul 2020 12:31:01 -0500
Babu Moger wrote:
> This is in preparation to build the apic_id from user
> provided topology information.
>
> Signed-off-by: Babu Moger
> ---
> include/hw/i386/topology.h | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/includ
On 7/13/20 11:05 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
FYI the subject should say this is "PATCH v2", see:
https://wiki.qemu.o
Hi Paolo,
On 7/12/20 6:11 PM, Paolo Bonzini wrote:
> On 12/07/20 12:00, Claudio Fontana wrote:
>> Note: only the === -blockdev with a backing file === part of test 267 fails.
>> -blockdev with NBD is ok, like all the rest.
>>
>>
>> Interesting facts about s390 in particular: its save/load code in
On Fri, Jul 10, 2020 at 05:24:07PM +0200, David Hildenbrand wrote:
> On 10.07.20 17:18, Heiko Carstens wrote:
> > On Fri, Jul 10, 2020 at 02:12:33PM +0200, David Hildenbrand wrote:
> >>> Note: Reading about diag260 subcode 0xc, we could modify Linux to query
> >>> the maximum possible pfn via diag2
On 7/13/20 10:58 AM, Erik Smit wrote:
> On Mon, 13 Jul 2020 at 10:37, Cédric Le Goater wrote:
>> On 7/13/20 10:06 AM, Erik Smit wrote:
>>> On Mon, 13 Jul 2020 at 09:52, Cédric Le Goater wrote:
With this patch, the supermicro firmware boots further but there is still
an issue. It mi
On Wed, 01 Jul 2020 12:31:08 -0500
Babu Moger wrote:
> Build apic_id from CpuInstanceProperties if numa configured.
> Use the node_id from user provided numa information. This
> will avoid conflicts between numa information and apic_id
> generated.
>
> Re-arranged the code little bit to make sur
On 06.07.20 22:39, Eric Blake wrote:
> During 'qemu-img create ... 2>&1', if --quiet is not in force, we can
> end up with buffered I/O in stdout that was produced before failure,
> but which appears in output after failure. This is confusing; the fix
> is to flush stdout prior to attempting anyth
Eduardo Habkost writes:
> On Fri, Jul 10, 2020 at 11:05:29AM +0200, Philippe Mathieu-Daudé wrote:
>> +Stefan for tracing PoV
>>
>> On 7/9/20 9:48 PM, Eduardo Habkost wrote:
>> > On Fri, Jun 26, 2020 at 04:26:33PM +0200, Philippe Mathieu-Daudé
>> > wrote:
>> >> On 6/26/20 1:00 PM, BALA
On Mon, 13 Jul 2020 09:51:12 +0200
Thomas Huth wrote:
> There is some additional information about the 3270 support in our Wiki
> at https://wiki.qemu.org/Features/3270 - so let's include this information
> into the main documentation now to have one single source of information
> (the Wiki page
On 7/10/20 7:06 AM, John Snow wrote:
> It's not important to do this before waiting for the process to exit, so
> it can be done during generic post-shutdown cleanup.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Re
On 7/10/20 7:06 AM, John Snow wrote:
> If the VM is not launched, don't try to shut it down. As a change,
> _post_shutdown now unconditionally also calls _early_cleanup in order to
> offer comprehensive object cleanup in failure cases.
>
> As a courtesy, treat it as a NOP instead of rejecting it a
On 7/10/20 7:06 AM, John Snow wrote:
> At this point, shutdown(has_quit=True) and wait() do essentially the
> same thing; they perform cleanup without actually instructing QEMU to
> quit.
>
> Define one in terms of the other.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 17
On 7/10/20 7:06 AM, John Snow wrote:
> Three seconds is hardcoded. Use it as a default parameter instead, and use
> that
> value for both waits that may occur in the function.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 8 +---
> 1 file changed, 5 insertions(+), 3 deletion
On 7/10/20 7:06 AM, John Snow wrote:
> If the user kills QEMU on purpose, we don't need to warn them about that
> having happened: they know already.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Good idea :)
Review
On 7/10/20 7:06 AM, John Snow wrote:
> Machine.wait() does not appear to be used except in the acceptance tests,
> and an infinite timeout by default in a test suite is not the most helpful.
>
> Change it to 3 seconds, like the default shutdown timeout.
>
> Signed-off-by: John Snow
> ---
> pyth
On 13/07/2020 11.03, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous break.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/kvm64.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/kvm64.c b/ta
On 7/10/20 7:22 AM, John Snow wrote:
> As always, Optional[T] causes problems with unchecked access. Add a
> helper that asserts the pipe is present before we attempt to talk with
> it.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 16 +++-
> 1 file changed, 11 insert
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> scsi/utils.c | 4
> 1 file changed, 4 deletions(-)
>
> d
On 13/07/2020 11.03, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/ppc/misc_helper.c | 5 -
> 1 file changed, 5 deleti
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> tcg/riscv/tcg-target.inc.c | 2 --
> 1 file changed, 2 deletio
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang a
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> ui/vnc-enc-tight.c | 1 -
> 1 file changed, 1 deletion(-)
>
> d
On 7/10/20 7:22 AM, John Snow wrote:
> These should all be purely annotations with no changes in behavior at
> all. You need to be in the python folder, but you should be able to
> confirm that these annotations are correct (or at least self-consistent)
> by running `mypy --strict qemu`.
>
> Signe
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> block/vmdk.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> dif
On 7/10/20 7:22 AM, John Snow wrote:
> Like many other Optional[] types, it's not always a given that this
> object will be set. Wrap it in a type-shim that raises a meaningful
> error and will always return a concrete type.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py | 24 ++
On Thu, 9 Jul 2020 00:46:11 +0200
Julia Suvorova wrote:
> Returns the current host bus with ACPI PCI hot-plug support: q35 or i440fx.
>
> Signed-off-by: Julia Suvorova
> ---
> hw/i386/acpi-build.h | 2 ++
> hw/acpi/pcihp.c | 13 +
> hw/i386/acpi-build.c | 2 +-
> 3 files ch
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/cris/translate.c | 7 +++
> target/cris/tran
1 - 100 of 480 matches
Mail list logo
