On 7/10/20 7:06 AM, John Snow wrote: > Machine.wait() does not appear to be used except in the acceptance tests, > and an infinite timeout by default in a test suite is not the most helpful. > > Change it to 3 seconds, like the default shutdown timeout. > > Signed-off-by: John Snow <js...@redhat.com> > --- > python/qemu/machine.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/python/qemu/machine.py b/python/qemu/machine.py > index 02d66e3cff..d08a8e4a6e 100644 > --- a/python/qemu/machine.py > +++ b/python/qemu/machine.py > @@ -472,12 +472,12 @@ def kill(self): > """ > self.shutdown(hard=True) > > - def wait(self, timeout: Optional[int] = None) -> None: > + def wait(self, timeout: Optional[int] = 3) -> None: > """ > Wait for the VM to power off and perform post-shutdown cleanup. > > :param timeout: Optional timeout in seconds. > - Default None, an infinite wait. > + Default 3 seconds, A value of None is an infinite > wait. > """ > self.shutdown(has_quit=True, timeout=timeout) > >
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
