Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

On 7/8/20 8:41 PM, Paolo Bonzini wrote: > > > Il mer 8 lug 2020, 20:25 Claudio Fontana > ha scritto: > > What I did notice is that all the code that directly or indirectly uses > the functions is under an > > if (0) ( > ) > > since tcg_enabled is the

[PATCH 1/2] linux-user: add new netlink types

Only implement IFLA_PERM_ADDRESS to fix the following error: Unknown host QEMU_IFLA type: 54 The couple of other ones, IFLA_PROP_LIST and IFLA_ALT_IFNAME, have been introduced to be used with RTM_NEWLINKPROP, RTM_DELLINKPROP and RTM_GETLINKPROP that are not implemented by QEMU. Signed-off-by:

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

On Wed, Jul 8, 2020 at 10:34 PM Philippe Mathieu-Daudé wrote: > > On 7/9/20 2:06 AM, Havard Skinnemoen wrote: > > On Wed, Jul 8, 2020 at 11:13 AM Havard Skinnemoen > > wrote: > >> On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé > >> wrote: > >>> On 7/7/20 8:47 PM, Havard Skinnemoen wrote

[PATCH 2/2] linux-user: add netlink RTM_SETLINK command

This command is needed to be able to boot systemd in a container. $ sudo systemd-nspawn -D /chroot/armhf/sid/ -b Spawning container sid on /chroot/armhf/sid. Press ^] three times within 1s to kill container. systemd 245.6-2 running in system mode. Detected virtualization systemd-nspawn.

Re: Failure prints during format or mounting a usb storage device

> Starting at line 1746 is the first CBW, it's for an Inquiry command. > > Starting at line 1759 is the response, notice at line 1761 the MSD debug > says "Data in 64/36", which is strange. Not really. First is the packet size, second is the (remaining) data size. Inquiry data is 36 bytes, and

[PATCH] migration: fix memory leak in qmp_migrate_set_parameters

From: Zheng Chuan "tmp.tls_hostname" and "tmp.tls_creds" allocated by migrate_params_test_apply() is forgot to free at the end of qmp_migrate_set_parameters(). Fix that. The leak stack: Direct leak of 2 byte(s) in 2 object(s) allocated from: #0 0xb597c20b in __interceptor_malloc (/usr/lib

Re: [PATCH v7 00/47] block: Deal with filters

On 08.07.20 22:37, Eric Blake wrote: > On 7/8/20 2:46 PM, Andrey Shinkevich wrote: >> >> On 08.07.2020 20:32, Eric Blake wrote: >>> On 7/8/20 12:20 PM, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: > v6: > https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg017

Re: [PATCH v7 00/47] block: Deal with filters

On 08.07.20 22:47, Eric Blake wrote: > On 7/8/20 12:20 PM, Andrey Shinkevich wrote: >> On 25.06.2020 18:21, Max Reitz wrote: >>> v6: >>> https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html >>> >>> Branch: https://github.com/XanClic/qemu.git child-access-functions-v7 >>> Branch: h

Re: [PATCH v7 02/47] block: Add chain helper functions

On 08.07.20 19:20, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Add some helper functions for skipping filters in a chain of block >> nodes. >> >> Signed-off-by: Max Reitz >> --- >>   include/block/block_int.h |  3 +++ >>   block.c   | 55

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Keep-alive won't hurt, let's try to enable it even if not requested by > user. Keep-alive intentionally breaks TCP connections earlier than normal in face of transient networking problems. The question is more about w

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Laurent Vivier (laurent-vivier) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886811 Title:

Re: [PATCH 1/2] sockets: keep-alive settings

On Wed, Jul 08, 2020 at 10:15:38PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Introduce keep-alive settings (TCP_KEEPCNT, TCP_KEEPIDLE, > TCP_KEEPINTVL) and chose some defaults. > > The linux default of 2 hours for /proc/tcp_keepalive_time > (corresponding to TCP_KEEPIDLE) makes keep-alive optio

Re: [PATCH 0/2] keepalive default

On Wed, Jul 08, 2020 at 10:15:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We understood, that keepalive is almost superfluous with default 2 hours > in /proc/tcp_keepalive_time. Forcing user to setup keepalive for the > whole system doesn't seem right, better setup it per-socket.

[PATCH] tests/qtest/fuzz: Add missing spaces in description

There should be a space between "forking" and "for". Signed-off-by: Thomas Huth --- tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/fuzz/virtio_scsi_fuzz.c b/tests/qtest/fuzz/virtio_scsi_fuzz.c index 51dce491ab..3a9ea13736

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote: > GCC supports "#pragma GCC diagnostic" since version 4.6, and > Clang seems to support it, too, since its early versions 3.x. > That means that our minimum required compiler versions all support > this pragma already and we can remove th

[PATCH] docs/devel/fuzzing: Fix bugs in documentation

Fix typo - the option is called "--fuzz-target" and not "--fuzz_taget". Also use a different fuzzer in the example, since "virtio-net-fork-fuzz" does not seem to be a valid fuzzer target (anymore?). Signed-off-by: Thomas Huth --- docs/devel/fuzzing.txt | 6 +++--- 1 file changed, 3 insertions(+)

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

09.07.2020 11:29, Daniel P. Berrangé wrote: On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: Keep-alive won't hurt, let's try to enable it even if not requested by user. Keep-alive intentionally breaks TCP connections earlier than normal in face of transient networ

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and that

Re: [PATCH v2 1/2] GitLab Gating CI: introduce pipeline-status contrib script

On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote: > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or with

Re: [PATCH v7 12/47] block: Use bdrv_filter_(bs|child) where obvious

On 08.07.20 20:24, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Places that use patterns like >> >> if (bs->drv->is_filter && bs->file) { >> ... something about bs->file->bs ... >> } >> >> should be >> >> BlockDriverState *filtered = bdrv_filter_bs(bs)

Re: [PATCH v7 00/47] block: Deal with filters

On 09.07.2020 11:20, Max Reitz wrote: On 08.07.20 22:47, Eric Blake wrote: On 7/8/20 12:20 PM, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html Branch: https://github.com/XanClic/qemu.git child-access-fun

Re: [PATCH v7 02/47] block: Add chain helper functions

On 09.07.2020 11:24, Max Reitz wrote: On 08.07.20 19:20, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Add some helper functions for skipping filters in a chain of block nodes. Signed-off-by: Max Reitz ---   include/block/block_int.h |  3 +++   block.c   | 5

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

On 7/9/20 11:29 AM, Daniel P. Berrangé wrote: > On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Keep-alive won't hurt, let's try to enable it even if not requested by >> user. > Keep-alive intentionally breaks TCP connections earlier than normal > in face of transie

Re: [PATCH v7 12/47] block: Use bdrv_filter_(bs|child) where obvious

On 09.07.2020 11:59, Max Reitz wrote: On 08.07.20 20:24, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Places that use patterns like if (bs->drv->is_filter && bs->file) { ... something about bs->file->bs ... } should be BlockDriverState *filtered

Re: [PATCH RFC 4/5] s390x: implement virtio-mem-ccw

On Wed, 8 Jul 2020 20:51:34 +0200 David Hildenbrand wrote: > Add a proper CCW proxy device, similar to the PCI variant. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/virtio-ccw-mem.c | 165 ++ > hw/s390x/virtio-ccw.h | 13 +++ > 2 files changed

Re: [PATCH RFC 4/5] s390x: implement virtio-mem-ccw

On 09.07.20 11:24, Cornelia Huck wrote: > On Wed, 8 Jul 2020 20:51:34 +0200 > David Hildenbrand wrote: > >> Add a proper CCW proxy device, similar to the PCI variant. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/virtio-ccw-mem.c | 165 ++ >> hw/

Re: qemu-system-ppc64 abort()s with pcie bridges

On Wed, 8 Jul 2020 11:57:03 +0200 Greg Kurz wrote: > On Wed, 8 Jul 2020 10:03:47 +0200 > Thomas Huth wrote: > > > > > Hi, > > > > qemu-system-ppc64 currently abort()s when it is started with a pcie > > bridge device: > > > > $ qemu-system-ppc64 -M pseries-5.1 -device pcie-pci-bridge > > Une

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

On Wed, 2020-05-27 at 14:11 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:46PM +0300, Maxim Levitsky wrote: > > /* The operands of the minus operator must have the same type, > > * which must be the one that we specify in the cast. > > diff --git a/qdev-monitor.c b/qdev-monitor.c

Re: [PATCH] migration: fix memory leak in qmp_migrate_set_parameters

Chuan Zheng wrote: > From: Zheng Chuan > > "tmp.tls_hostname" and "tmp.tls_creds" allocated by > migrate_params_test_apply() > is forgot to free at the end of qmp_migrate_set_parameters(). Fix that. > > The leak stack: > Direct leak of 2 byte(s) in 2 object(s) allocated from: >#0 0xb597c

Re: [PATCH v2 3/7] device-core: use RCU for list of childs of a bus

On Wed, 2020-05-27 at 15:45 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:47PM +0300, Maxim Levitsky wrote: > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > > index d87d989e72..ef47cb2d9c 100644 > > --- a/include/hw/qdev-core.h > > +++ b/include/hw/qdev-core.h > >

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

Hi, > > (CCing libvir-list, and people who were included in the OVMF > > thread[1]) > > > > [1] > > https://lore.kernel.org/qemu-devel/99779e9c-f05f-501b-b4be-ff719f140...@canonical.com/ > > Also, it's important that we work with libvirt and management > > software to ensure they have appropr

Re: [PATCH] cpu: Add starts_halted() method

On Thu, 9 Jul 2020 07:11:09 +0200 Philippe Mathieu-Daudé wrote: > On 7/8/20 11:39 PM, Eduardo Habkost wrote: > > On Wed, Jul 08, 2020 at 06:45:57PM +0200, Philippe Mathieu-Daudé wrote: > >> On 7/8/20 5:25 PM, Eduardo Habkost wrote: > >>> On Wed, Jul 08, 2020 at 02:14:03PM +0100, Peter Maydell wr

Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

On 09/07/20 08:59, Claudio Fontana wrote: > anything else that we could use to find the real problem? I'm using $ gcc -v ... gcc version 8.3.1 20191121 (Red Hat 8.3.1-5) (GCC) $ ld -v GNU ld version 2.30-68.el8 > Of course I can try a blind fix, where I suggest to explicitly provide the > stubs

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

On Thu, 2020-07-09 at 11:44 +0200, Gerd Hoffmann wrote: > Hi, > > > > (CCing libvir-list, and people who were included in the OVMF > > > thread[1]) > > > > > > [1] > > > https://lore.kernel.org/qemu-devel/99779e9c-f05f-501b-b4be-ff719f140...@canonical.com/ > > > Also, it's important that we wo

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

On 09/07/20 07:34, Thomas Huth wrote: > GCC supports "#pragma GCC diagnostic" since version 4.6, and > Clang seems to support it, too, since its early versions 3.x. > That means that our minimum required compiler versions all support > this pragma already and we can remove the test from configure a

Re: [PATCH 1/2] hw/riscv: Modify MROM size to end at 0x10000

Hi Philippe, On Thu, Jul 9, 2020 at 1:15 PM Philippe Mathieu-Daudé wrote: > > On 7/9/20 3:09 AM, Bin Meng wrote: > > From: Bin Meng > > > > At present the size of Mask ROM for sifive_u / spike / virt machines > > is set to 0x11000, which ends at an unusual address. This changes the > > size to 0

[PATCH v2 1/2] hw/riscv: Modify MROM size to end at 0x10000

From: Bin Meng At present the size of Mask ROM for sifive_u / spike / virt machines is set to 0x11000, which ends at an unusual address. This changes the size to 0xf000 so that it ends at 0x1. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- (no changes since v1) hw/riscv

[PATCH v2 2/2] hw/riscv: sifive_u: Provide a reliable way for bootloader to detect whether it is running in QEMU

From: Bin Meng The reset vector codes are subject to change, e.g.: with recent fw_dynamic type image support, it breaks oreboot again. Add a subregion in the MROM, with the size of machine RAM stored, so that we can provide a reliable way for bootloader to detect whether it is running in QEMU.

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On 7/9/20 4:46 AM, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and that > are setup and ready

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

On 09/07/20 11:55, Mohammed Gamal wrote: >> Ideally we would simply outlaw (3), but it's hard for backward >> compatibility reasons. Second best solution is a flag somewhere >> (msr, cpuid, ...) telling the guest firmware "you can use >> GUEST_MAXPHYADDR, we guarantee it is <= HOST_MAXPHYADDR". >

Re: [PATCH v2 1/2] GitLab Gating CI: introduce pipeline-status contrib script

On 7/9/20 10:55 AM, Erik Skultety wrote: > On Wed, Jul 08, 2020 at 10:46:56PM -0400, Cleber Rosa wrote: >> This script is intended to be used right after a push to a branch. >> >> By default, it will look for the pipeline associated with the commit >> that is the HEAD of the *local* staging branch.

Re: [PATCH v10 02/34] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset()

On 03.07.20 17:57, Alberto Garcia wrote: > qcow2_get_cluster_offset() takes an (unaligned) guest offset and > returns the (aligned) offset of the corresponding cluster in the qcow2 > image. > > In practice none of the callers need to know where the cluster starts > so this patch makes the function

Re: Migrating custom qemu.org infrastructure to GitLab

Hi, > > 2. wiki.qemu.org is a MediaWiki instance. Account creation is a hurdle > > to one-time or new contributors. It is unclear whether GitLab's wiki > > is expressive enough for a lossless conversion of the existing QEMU > > wiki. Any volunteers interested in evaluating the wiki migration wou

Re: [PATCH] cpu: Add starts_halted() method

On 7/9/20 11:54 AM, Greg Kurz wrote: > On Thu, 9 Jul 2020 07:11:09 +0200 > Philippe Mathieu-Daudé wrote: >> On 7/8/20 11:39 PM, Eduardo Habkost wrote: >>> On Wed, Jul 08, 2020 at 06:45:57PM +0200, Philippe Mathieu-Daudé wrote: On 7/8/20 5:25 PM, Eduardo Habkost wrote: > On Wed, Jul 08, 2

Re: Migrating custom qemu.org infrastructure to GitLab

On 09/07/2020 12.16, Gerd Hoffmann wrote: > Hi, > >>> 2. wiki.qemu.org is a MediaWiki instance. Account creation is a hurdle >>> to one-time or new contributors. It is unclear whether GitLab's wiki >>> is expressive enough for a lossless conversion of the existing QEMU >>> wiki. Any volunteers i

Re: [PATCH v2 4/7] device-core: use atomic_set on .realized property

On Wed, 2020-05-27 at 16:00 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:48PM +0300, Maxim Levitsky wrote: > > Some code might race with placement of new devices on a bus. > > We currently first place a (unrealized) device on the bus > > and then realize it. > > > > As a workaroun

Re: [PATCH] cpu: Add starts_halted() method

On 7/9/20 5:26 AM, Thiago Jung Bauermann wrote: > > Thiago Jung Bauermann writes: > >> I'm seeing the vcpu being KVM_RUN'd too early twice during hotplug. >> Both of them are before cpu_reset() and ppc_cpu_reset(). > > Hm, rereading the message obviously the above is partially wrong. The > seco

Re: [PATCH 1/7] migration/savevm: respect qemu_fclose() error code in save_snapshot()

"Denis V. Lunev" wrote: > qemu_fclose() could return error, f.e. if bdrv_co_flush() will return > the error. > > This validation will become more important once we will start waiting of > asynchronous IO operations, started from bdrv_write_vmstate(), which are > coming soon. > > Signed-off-by: Den

Re: [PULL 13/29] qapi: Flatten object-add

Paolo Bonzini writes: > On 08/07/20 18:05, Kevin Wolf wrote: >> Markus was going to introduce new QAPI schema syntax that would allow to >> specify a few options explicitly and then one option for "the rest" that >> would just be mapped to a QDict like "any" or "gen": false, and that >> wouldn't

Re: [PULL 00/12] Block layer patches

Am 07.07.2020 um 18:34 hat Kevin Wolf geschrieben: > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging > (2020-07-06 11:40:10 +0100) > > are available in the Git r

Re: [PATCH] tests/qtest/fuzz: Add missing spaces in description

On 7/9/20 10:37 AM, Thomas Huth wrote: > There should be a space between "forking" and "for". > > Signed-off-by: Thomas Huth > --- > tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/fuzz/virtio_scsi_fuzz.c > b/tests/qt

Re: [PULL 0/3] M68k next patches

On Mon, 6 Jul 2020 at 21:06, Laurent Vivier wrote: > > The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02' > into staging (2020-07-02 15:54:09 +0100) > > are available in the Git repository at:

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and tha

Re: [PULL v2 00/41] virtio,acpi: features, fixes, cleanups.

On Tue, 7 Jul 2020 at 18:50, Peter Maydell wrote: > > On Tue, 7 Jul 2020 at 13:04, Michael S. Tsirkin wrote: > > Precisely. Sorry about missing this. > > I made this change and pushed to the same tag - don't want to spam > > the list for a small thing like this. Can you pick this up pls? > > Comm

Re: Migrating custom qemu.org infrastructure to GitLab

On 09/07/20 12:22, Thomas Huth wrote: > FWIW, seems like we could use the "pandoc" tool to convert Mediawiki > (our old Wiki) to Markdown (Gitlab wiki). I've done a quick test and > converted https://wiki.qemu.org/Contribute/MailingLists into > https://gitlab.com/huth/qemu/-/wikis/Contribute/Mailin

Re: [PATCH v2 6/7] scsi: Add scsi_device_get

On Wed, 2020-05-27 at 16:27 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:50PM +0300, Maxim Levitsky wrote: > > +/* > > + * This function works like scsi_device_get but doesn't take a refernce > > s/refernce/reference/ > > > + * to the returned object. Intended for legacy code >

Re: [PATCH RFC 2/5] s390x: implement diag260

On Wed, 8 Jul 2020 20:51:32 +0200 David Hildenbrand wrote: > Let's implement the "storage configuration" part of diag260. This diag > is found under z/VM, to indicate usable chunks of memory tot he guest OS. > As I don't have access to documentation, I have no clue what the actual > error cases

Re: [PATCH v2 7/7] virtio-scsi: use scsi_device_get

On Wed, 2020-05-27 at 16:50 +0100, Stefan Hajnoczi wrote: > On Mon, May 11, 2020 at 07:09:51PM +0300, Maxim Levitsky wrote: > > This will help us to avoid the scsi device disappearing > > after we took a reference to it. > > > > It doesn't by itself forbid case when we try to access > > an unreali

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote: > diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c > index f0b66320e1..a4e6446ed9 100644 > --- a/util/coroutine-ucontext.c > +++ b/util/coroutine-ucontext.c > @@ -237,19 +237,15 @@ Coroutine *qemu_coroutine_new(void) >

Re: [PATCH RFC 2/5] s390x: implement diag260

On 08.07.20 20:51, David Hildenbrand wrote: > Let's implement the "storage configuration" part of diag260. This diag > is found under z/VM, to indicate usable chunks of memory tot he guest OS. > As I don't have access to documentation, I have no clue what the actual > error cases are, and which o

Re: [PATCH] cpu: Add starts_halted() method

On Thu, 9 Jul 2020 12:18:06 +0200 Philippe Mathieu-Daudé wrote: > On 7/9/20 11:54 AM, Greg Kurz wrote: > > On Thu, 9 Jul 2020 07:11:09 +0200 > > Philippe Mathieu-Daudé wrote: > >> On 7/8/20 11:39 PM, Eduardo Habkost wrote: > >>> On Wed, Jul 08, 2020 at 06:45:57PM +0200, Philippe Mathieu-Daudé w

Re: [PATCH RFC 3/5] s390x: prepare device memory address space

On Wed, 8 Jul 2020 20:51:33 +0200 David Hildenbrand wrote: > Let's allocate the device memory information and setup the device > memory address space. Expose the maximum ramsize via SCLP and the actual > initial ramsize via diag260. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-v

Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

On 09/07/2020 12.51, Stefan Hajnoczi wrote: > On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote: >> diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c >> index f0b66320e1..a4e6446ed9 100644 >> --- a/util/coroutine-ucontext.c >> +++ b/util/coroutine-ucontext.c >> @@ -237,19

[PATCH] iotests: Simplify _filter_img_create() a bit

Not only is it a bit stupid to try to filter multi-line "Formatting" output (because we only need it for a single test, which can easily be amended to no longer need it), it is also problematic when there can be output after a "Formatting" line that we do not want to filter as if it were part of it

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On Thu, 2020-07-09 at 11:30 +0100, Daniel P. Berrangé wrote: > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > +- name: Installation of basic packages to build QEMU > > + hosts: all > > + vars_files: > > +- vars.yml > > + tasks: > > +- name: Install basic packages to bui

[PATCH] tests: improve performance of device-introspect-test

Total execution time with "-m slow" and x86_64 QEMU, drops from 3 minutes 15 seconds, down to 54 seconds. Individual tests drop from 17-20 seconds, down to 3-4 seconds. The cost of this change is that any QOM bugs resulting in the test failure will not be directly associated with the device that

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

On Tue, 7 Jul 2020 at 08:09, Alex Bennée wrote: > > There will be some docker failures until the official repository has > seeded but local builds should continue to work. > > > > The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: > > Merge remote-tracking branch

Re: [qemu-web PATCH] new page: conservancy.md

On 07/07/2020 17.19, Paolo Bonzini wrote: > On 07/07/20 16:51, Alex Bennée wrote: >> +QEMU interacts with Conservancy through a Leadership Committee, >> +currently composed of the following members: >> + >> +* Alex Bennée >> +* Paolo Bonzini >> +* Andreas Färber >> +* Alexander Graf >> +* Stefan Ha

QEMU | Pipeline #164743957 has failed for master | 48f22ad0

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 48f22ad0 ( https://gitlab.com/qemu-project/qemu/-/commit/48f22ad04ead83e61b4b35871ec6f6109779b791 ) Commit Message: Merge remote-tr

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

"Denis V. Lunev" writes: > On 7/9/20 11:29 AM, Daniel P. Berrangé wrote: >> On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> Keep-alive won't hurt, let's try to enable it even if not requested by >>> user. >> Keep-alive intentionally breaks TCP connections earlier

[Bug 1886076] Re: risc-v pmp implementation error

Nicolas, to be reviewed your patch must be sent to qemu-devel@nongnu.org -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886076 Title: risc-v pmp implementation error Status in QEMU: New Bug de

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

Maxim Levitsky writes: > This allows to preserve the semantics of hmp_device_del, > that the device is deleted immediatly which was changed by previos > patch that delayed this to RCU callback > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Maxim Levitsky > --- > include/qemu/rcu.h | 1 + >

Re: [PATCH] tests: improve performance of device-introspect-test

On 09/07/2020 13:28, Daniel P. Berrangé wrote: > Total execution time with "-m slow" and x86_64 QEMU, drops from 3 > minutes 15 seconds, down to 54 seconds. > > Individual tests drop from 17-20 seconds, down to 3-4 seconds. > > The cost of this change is that any QOM bugs resulting in the test >

Re: [qemu-web PATCH] new page: conservancy.md

On 09/07/20 13:32, Thomas Huth wrote: > Paolo, could you please update the link on > https://wiki.qemu.org/Main_Page ? I do not have the access rights to > edit that page. Once that is done, I think we can delete the old page > https://wiki.qemu.org/Conservancy in the wiki (or turn it into a > redi

Re: [PATCH v2 1/2] GitLab Gating CI: introduce pipeline-status contrib script

On 09/07/2020 04.46, Cleber Rosa wrote: > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or with the `--wait` option

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

On 2020-07-08 15:11, Paolo Bonzini wrote: On 08/07/20 16:44, lma wrote: Is the 'block_resize' mandatory to notify guest os after online resizing a lun passed through disk? I'm curious it because I found there're couple of ways can make guest os realize the disk capacity change. e.g: * run 'b

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

On Thu, Jul 09, 2020 at 11:49:17AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 09.07.2020 11:29, Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Keep-alive won't hurt, let's try to enable it even if not requested by > > > user.

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

On Thu, 2020-07-09 at 13:42 +0200, Markus Armbruster wrote: > Maxim Levitsky writes: > > > This allows to preserve the semantics of hmp_device_del, > > that the device is deleted immediatly which was changed by previos > > patch that delayed this to RCU callback > > > > Suggested-by: Stefan Hajn

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

> >On Mon, 29 Jun 2020 at 09:17, Wentong Wu wrote: > > > > wrctl instruction on nios2 target will cause checking cpu > > interrupt but tcg_handle_interrupt() will call cpu_abort() > > if the CPU gets an interrupt while it's not in 'can do IO' > > state, so add gen_io_start around wrctl instruction

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

On 09/07/20 13:52, Lin Ma wrote: >> It's not recommended however, because block_resize will report the >> change to the guest directly with a CAPACITY HAS CHANGED unit attention >> condition. > > Got it, The 'block_resize' is the recommended or necessary step, Even for > passthrough disk online re

Re: [PATCH] tests: improve performance of device-introspect-test

On Thu, Jul 09, 2020 at 01:44:45PM +0200, Laurent Vivier wrote: > On 09/07/2020 13:28, Daniel P. Berrangé wrote: > > Total execution time with "-m slow" and x86_64 QEMU, drops from 3 > > minutes 15 seconds, down to 54 seconds. > > > > Individual tests drop from 17-20 seconds, down to 3-4 seconds.

Re: [PATCH v2 2/7] Implement drain_call_rcu and use it in hmp_device_del

On 09/07/20 13:56, Maxim Levitsky wrote: > On Thu, 2020-07-09 at 13:42 +0200, Markus Armbruster wrote: >> Maxim Levitsky writes: >> >>> This allows to preserve the semantics of hmp_device_del, >>> that the device is deleted immediatly which was changed by previos >>> patch that delayed this to RCU

Re: Questions about online resizing a lun passthrough disk with virtio-scsi

On 2020-07-09 12:00, Paolo Bonzini wrote: On 09/07/20 13:52, Lin Ma wrote: It's not recommended however, because block_resize will report the change to the guest directly with a CAPACITY HAS CHANGED unit attention condition. Got it, The 'block_resize' is the recommended or necessary step, Ev

Re: [PATCH v10 21/34] qcow2: Add subcluster support to qcow2_get_host_offset()

On 03.07.20 17:58, Alberto Garcia wrote: > The logic of this function remains pretty much the same, except that > it uses count_contiguous_subclusters(), which combines the logic of > count_contiguous_clusters() / count_contiguous_clusters_unallocated() > and checks individual subclusters. > > qco

Re: Migrating custom qemu.org infrastructure to GitLab

On 09/07/2020 12.33, Paolo Bonzini wrote: > On 09/07/20 12:22, Thomas Huth wrote: >> FWIW, seems like we could use the "pandoc" tool to convert Mediawiki >> (our old Wiki) to Markdown (Gitlab wiki). I've done a quick test and >> converted https://wiki.qemu.org/Contribute/MailingLists into >> https:

Re: [PATCH] tests: improve performance of device-introspect-test

On 09/07/2020 13:59, Daniel P. Berrangé wrote: > On Thu, Jul 09, 2020 at 01:44:45PM +0200, Laurent Vivier wrote: >> On 09/07/2020 13:28, Daniel P. Berrangé wrote: >>> Total execution time with "-m slow" and x86_64 QEMU, drops from 3 >>> minutes 15 seconds, down to 54 seconds. >>> >>> Individual tes

Re: [PATCH] iotests: Simplify _filter_img_create() a bit

Am 09.07.2020 um 13:02 hat Max Reitz geschrieben: > Not only is it a bit stupid to try to filter multi-line "Formatting" > output (because we only need it for a single test, which can easily be > amended to no longer need it), it is also problematic when there can be > output after a "Formatting" l

Re: [PATCH] hw/timer/a9gtimer: Clear pending interrupt, after the clear of Event flag

On 6/26/20 4:46 PM, Peter Maydell wrote: On Tue, 16 Jun 2020 at 08:04, Václav Vanc wrote: On 6/15/20 1:04 PM, Peter Maydell wrote: We must distinguish between two cases: 1, Auto-increment is disabled. I just run some test on SABRE Lite (i.MX6) board. I had auto-increment disabled, I verifie

Re: [PATCH v10 28/34] qcow2: Add subcluster support to qcow2_co_pwrite_zeroes()

On 03.07.20 17:58, Alberto Garcia wrote: > This works now at the subcluster level and pwrite_zeroes_alignment is > updated accordingly. > > qcow2_cluster_zeroize() is turned into qcow2_subcluster_zeroize() with > the following changes: > >- The request can now be subcluster-aligned. > >-

[PULL v2] Block layer patches

The following changes since commit 8796c64ecdfd34be394ea277a53df0c76996: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20200706-pull-request' into staging (2020-07-08 16:33:59 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream fo

Re: [PATCH] cpu: Add starts_halted() method

On 7/9/20 12:55 PM, Greg Kurz wrote: > On Thu, 9 Jul 2020 12:18:06 +0200 > Philippe Mathieu-Daudé wrote: > >> On 7/9/20 11:54 AM, Greg Kurz wrote: >>> On Thu, 9 Jul 2020 07:11:09 +0200 >>> Philippe Mathieu-Daudé wrote: On 7/8/20 11:39 PM, Eduardo Habkost wrote: > On Wed, Jul 08, 2020 at

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

On 7/9/20 1:31 PM, Peter Maydell wrote: > On Tue, 7 Jul 2020 at 08:09, Alex Bennée wrote: >> >> There will be some docker failures until the official repository has >> seeded but local builds should continue to work. >> >> >> >> The following changes since commit eb6490f544388dd24c0d054a96dd3

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

Hi, > > +scope = aml_scope("\\"); > > +pkg = aml_package(4); > > +aml_append(pkg, aml_int(5)); /* SLEEP_CONTROL_REG.SLP_TYP */ > > I'm not sure what does the comment refer to here. It's the register field the value gets written to. With full acpi this is PM1a_CNT.SLP_TYP, hw-reduce

Re: [PATCH] ossaudio: fix out of bounds write

> > diff --git a/audio/ossaudio.c b/audio/ossaudio.c > > index f88d076ec2..a7dcaa31ad 100644 > > --- a/audio/ossaudio.c > > +++ b/audio/ossaudio.c > > @@ -691,6 +691,7 @@ static size_t oss_read(HWVoiceIn *hw, void *buf, size_t > > len) > > len, dst); > >

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

On Thu, 9 Jul 2020 at 13:24, Philippe Mathieu-Daudé wrote: > libssh is bugged on Ubuntu 18.04. > https://bugs.launchpad.net/qemu/+bug/1838763 > > We need to use 'configure --disable-libssh' there. Ah, thanks. I guess libssh recently got installed on that box. -- PMM

Updates on libcapstone?

Hi Richard, We are using libcapstone since almost 3 years for the arm/i386/ppc 'base' architectures. The library is still optional in ./configure. I wonder if we can make it a strong requisite, this way we could get rid of disas/{arm.c,arm-a64.cc,i386.c,ppc.c} and the disas/libvixl submodule, then

Re: [PATCH v10 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

On 03.07.20 17:58, Alberto Garcia wrote: > Now that the implementation of subclusters is complete we can finally > add the necessary options to create and read images with this feature, > which we call "extended L2 entries". > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > Reviewed-

Delete some Wiki pages (was: Migrating custom qemu.org infrastructure to GitLab)

On 09/07/2020 12.33, Paolo Bonzini wrote: > On 09/07/20 12:22, Thomas Huth wrote: >> FWIW, seems like we could use the "pandoc" tool to convert Mediawiki >> (our old Wiki) to Markdown (Gitlab wiki). I've done a quick test and >> converted https://wiki.qemu.org/Contribute/MailingLists into >> https:

Re: [PATCH] cpu: Add starts_halted() method

On Thu, 9 Jul 2020 14:21:04 +0200 Philippe Mathieu-Daudé wrote: > On 7/9/20 12:55 PM, Greg Kurz wrote: > > On Thu, 9 Jul 2020 12:18:06 +0200 > > Philippe Mathieu-Daudé wrote: > > [...] > >>> > >>> FYI, PAPR requires all vCPUs to be "stopped" by default. It is up to the > >>> guest to start the

Re: [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork

On 7/9/20 7:15 AM, Thomas Huth wrote: > On 09/07/2020 07.09, Philippe Mathieu-Daudé wrote: >> On 7/9/20 7:03 AM, Philippe Mathieu-Daudé wrote: >>> On 7/8/20 10:01 PM, Alexander Bulekov wrote: In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced in d6919e4cb6. I added a c

  1   2   3   4   >