Hi Philippe, On Thu, Jul 9, 2020 at 1:15 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > On 7/9/20 3:09 AM, Bin Meng wrote: > > From: Bin Meng <bin.m...@windriver.com> > > > > At present the size of Mask ROM for sifive_u / spike / virt machines > > is set to 0x11000, which ends at an unusual address. This changes the > > size to 0xf000 so that it ends at 0x10000. > > Maybe the size is correct but the first 4K are shadowed by the DEBUG > region? >
The DEBUG region does not match what the SiFive FU540 manual says. But we don't support DEBUG in QEMU anyway :) > Anyway for QEMU this patch is an improvement, so: > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > Thanks for the review! Regards, Bin
