On Thu, Jun 25, 2020 at 10:35 PM Laurent Vivier wrote:
>
> On 22/06/2020 17:37, Cindy Lu wrote:
> > use the vhost_dev_start callback to send the status to backend
>
> I agree with Jason, squash this patch with the previous one.
>
will fix this
> > Signed-off-by: Cindy Lu
> > ---
> > hw/virtio/vh
On Wed, Jun 24, 2020 at 9:25 PM Laurent Vivier wrote:
>
> On 22/06/2020 17:37, Cindy Lu wrote:
> > From: Jason Wang
> >
> > With version 1, we can detect whether a queue is enabled via
> > queue_enabled.
> >
> > Signed-off-by: Jason Wang
> > Signed-off-by: Cindy Lu
> > ---
> > hw/virtio/virtio
By default the virtio-iommu translates MSI transactions. This
behavior is inherited from ARM SMMU. However the virt machine
code knows where the MSI doorbells are, so we can easily
declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that
setting the guest iommu subsystem will not need to map
At the moment the virtio-iommu translates MSI transactions.
This behavior is inherited from ARM SMMU. The virt machine
code knows where the guest MSI doorbells are so we can easily
declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that
setting the guest will not map MSIs through the IOMMU
The machine may need to pass reserved regions to the
virtio-iommu-pci device (such as the MSI window on x86
or the MSI doorbells on ARM).
So let's add an array of Interval properties.
Note: if some reserved regions are already set by the
machine code - which should be the case in general -,
the l
This patch implements the PROBE request. At the moment,
only THE RESV_MEM property is handled. The first goal is
to report iommu wide reserved regions such as the MSI regions
set by the machine code. On x86 this will be the IOAPIC MSI
region, [0xFEE0 - 0xFEEF], on ARM this may be the ITS
do
Introduce a new property defining a reserved region:
::.
This will be used to encode reserved IOVA regions.
For instance, in virtio-iommu use case, reserved IOVA regions
will be passed by the machine code to the virtio-iommu-pci
device (an array of those). The type of the reserved region
will mat
When translating an address we need to check if it belongs to
a reserved virtual address range. If it does, there are 2 cases:
- it belongs to a RESERVED region: the guest should neither use
this address in a MAP not instruct the end-point to DMA on
them. We report an error
- It belongs to an
Coverity noticed commit 950c4e6c94 introduced a dereference before
null check in get_opt_value (CID1391003):
In get_opt_value: All paths that lead to this null pointer
comparison already dereference the pointer earlier (CWE-476)
We fixed this in commit 6e3ad3f0e31, but relaxed the check in co
On 6/28/20 9:54 PM, Peter Maydell wrote:
> In bcm2835_fb_mbox_push(), Coverity complains (CID 1429989) that we
> pass a pointer to a local struct to another function without
> initializing all its fields. This is a real bug:
> bcm2835_fb_reconfigure() copies the whole of our new BCM2385FBConfig
>
On 6/27/20 5:11 PM, Peter Maydell wrote:
> On Sat, 27 Jun 2020 at 12:53, Markus Armbruster wrote:
>> Peter Maydell writes:
>>> Hi. I've just noticed that this commit added new global-scope
>>> functions to header files without documentation comments, eg
>>>
>>> bool qdev_realize_and_unref(DeviceS
On 6/28/20 7:05 PM, Peter Maydell wrote:
> On Sun, 28 Jun 2020 at 17:46, Jean-Christophe DUBOIS
> wrote:
>>
>> Le 28/06/2020 à 16:38, Peter Maydell a écrit :
>>> On Sun, 28 Jun 2020 at 11:56, Jean-Christophe DUBOIS
>>> wrote:
jcd@jcd-UX305CA:~/Projects/µCOS/work$
../../qemu/qemu/arm-sof
Hi Richard,
Thanks for taking a look and confirming that you managed to reproduce the
problem.
I forgot to mention that I'm using x86_64 hosts, not i686. I hope there are not
two unrelated issues...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subs
When adding the generic PCA955xClass in commit 736132e455, we
forgot to set the class_size field. Fill it now to avoid:
(gdb) run -machine mcimx6ul-evk -m 128M -display none -serial stdio -kernel
./OS.elf
Starting program: ../../qemu/qemu/arm-softmmu/qemu-system-arm -machine
mcimx6ul-evk -m
25.06.2020 17:25, Vladimir Sementsov-Ogievskiy wrote:
client_close doesn't guarantee that client is closed: nbd_trip() keeps
reference to it. Let's wait for nbd_trip to finish.
Without this fix, the following crash is possible:
- export bitmap through unternal Qemu NBD server
- connect a client
Fix has been included:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ee760ac80ac1f1
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882065
Ti
If something goes wrong during precopy, before stopping the VM, we will
never send a S_DONE indication to the VM, resulting in the hinted pages
not getting released to be used by the guest OS (e.g., Linux).
Easy to reproduce:
1. Start migration (e.g., HMP "migrate -d 'exec:gzip -c > STATEFILE.gz'"
On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> From: Huacai Chen
>
> Add myself as the maintainer for Loongson-3 virtual platforms, and
> also add Jiaxun Yang as the reviewer.
>
> Signed-off-by: Huacai Chen
> Co-developed-by: Jiaxun Yang
> Reviewed-by: Aleksandar Markovic
> Signed-off-by: A
On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> This commit creates a new 'Miscellaneous' section which hosts a new
> 'Performance Tools and Tests' subsection. This subsection will contain
> the the performance scripts and benchmarks written as a part of the
> 'TCG Continuous Benchmarking' project
On Sun, Jun 28, 2020 at 04:04:58PM +0100, Beata Michalska wrote:
> On ARMv7 & ARMv8 some load/store instructions might trigger a data abort
> exception with no valid ISS info to be decoded. The lack of decode info
> makes it at least tricky to emulate those instruction which is one of the
> (many)
In line the semantics of DISAS_UPDATE on nios2 target with other targets
which is to explicitly write the PC back into the cpu state before doing
a tcg_gen_exit_tb().
Signed-off-by: Wentong Wu
---
target/nios2/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target
Add DISAS_NORETURN case for nothing more to generate because at runtime
execution will never return from some helper call. And at the same time
replace DISAS_UPDATE in t_gen_helper_raise_exception and gen_exception
with the newly added DISAS_NORETURN.
Signed-off-by: Wentong Wu
---
target/nios2/t
wrctl instruction on nios2 target will cause checking cpu
interrupt but tcg_handle_interrupt() will call cpu_abort()
if the CPU gets an interrupt while it's not in 'can do IO'
state, so add gen_io_start around wrctl instruction. Also
at the same time, end the onging TB with DISAS_UPDATE.
Signed-of
On Sun, Jun 28, 2020 at 04:04:59PM +0100, Beata Michalska wrote:
> Injecting external data abort through KVM might trigger
> an issue on kernels that do not get updated to include the KVM fix.
> For those and aarch32 guests, the injected abort gets misconfigured
> to be an implementation defined ex
+Cleber/Wainer.
On 6/26/20 10:41 PM, John Snow wrote:
> Based-on: 20200626202350.11060-1-js...@redhat.com
>
> This series modifies the python/qemu library to comply with mypy --strict.
> This requires my "refactor shutdown" patch as a pre-requisite.
>
> v4:
> 001/16:[] [--] 'python/qmp.py: D
24.06.2020 19:43, Markus Armbruster wrote:
When migrate_add_blocker(blocker, &errp) is followed by
error_propagate(errp, err), we can often just as well do
migrate_add_blocker(..., errp).
Do that with this Coccinelle script:
@@
expression blocker, err, errp;
expression ret;
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Create a header file for the hw/misc/max111x device, in the
> usual modern style for QOM devices:
> * definition of the TYPE_ constants and macros
> * definition of the device's state struct so that it can
>be embedded in other structs if desired
>
Hi Markus
On 6/25/20 11:24 AM, Markus Armbruster wrote:
> Eric Auger writes:
>
>> object_property_add() does not allow object_property_try_add()
>> to gracefully fail as &error_abort is passed as an error handle.
>>
>> However such failure can easily be triggered from the QMP shell when,
>> for
* Markus Armbruster (arm...@redhat.com) wrote:
> Cc: David for insurance against me spewing nonsense about migration.
>
> John Snow writes:
>
> > On 6/25/20 12:45 AM, Markus Armbruster wrote:
> >> John Snow writes:
> >>
> >>> On 6/22/20 5:42 AM, Markus Armbruster wrote:
> There are three
On Thu, 2020-06-25 at 14:55 +0200, Max Reitz wrote:
> This function will be used by the next patch, which intends to check
> both the exit code and qemu-img's output.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/iotests.py | 34 +-
> 1 file changed, 17
On 6/28/20 4:24 PM, Peter Maydell wrote:
> The spitz board has been around a long time, and still has a fair number
> of hard-coded tab characters in it. We're about to do some work on
> this source file, so start out by expanding out the tabs.
>
> This commit is a pure whitespace only change.
>
On 6/28/20 4:24 PM, Peter Maydell wrote:
> For the four Spitz-family machines (akita, borzoi, spitz, terrier)
> create a proper abstract class SpitzMachineClass which encapsulates
> the common behaviour, rather than having them all derive directly
> from TYPE_MACHINE:
> * instead of each machine c
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Add some QOM properties to the max111x ADC device to allow the
> initial values to be configured. Currently this is done by
> board code calling max111x_set_input() after it creates the
> device, which doesn't work on system reset.
>
> This requires us to
On 6/28/20 4:24 PM, Peter Maydell wrote:
> The max111x is a proper qdev device; we can use dc->vmsd rather than
> directly calling vmstate_register().
>
> It's possible that this is a migration compat break, but the only
> boards that use this device are the spitz-family ('akita', 'borzoi',
> 'spi
On Mon, Jun 29, 2020 at 09:08:58AM +0200, Philippe Mathieu-Daudé wrote:
> Coverity noticed commit 950c4e6c94 introduced a dereference before
> null check in get_opt_value (CID1391003):
>
> In get_opt_value: All paths that lead to this null pointer
> comparison already dereference the pointer e
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Add an ssi_realize_and_unref(), for the benefit of callers
> who want to be able to create an SSI device, set QOM properties
> on it, and then do the realize-and-unref afterwards.
>
> The API works on the same principle as the recently added
> qdev_realiz
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Use the new max111x qdev properties to set the initial input
> values rather than calling max111x_set_input(); this means that
> on system reset the inputs will correctly return to their initial
> values.
>
> Signed-off-by: Peter Maydell
> ---
> hw/arm/
24.06.2020 19:43, Markus Armbruster wrote:
Convert uses like
opts = qemu_opts_create(..., &err);
if (err) {
...
}
to
opts = qemu_opts_create(..., &err);
if (!opts) {
...
}
Eliminate error_propagate() that are now unnecessary. Delete @err
that a
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Currently we have a free-floating set of IRQs and a function
> spitz_out_switch() which handle some miscellaneous GPIO lines for the
> spitz board. Encapsulate this behaviour in a simple QOM device.
>
> At this point we can finally remove the 'max' g
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Instead of logging guest accesses to invalid register offsets in this
> device using zaurus_printf() (which just prints to stderr), use the
> usual qemu_log_mask(LOG_GUEST_ERROR,...).
>
> Since this was the only use of the zaurus_printf() macro outside
>
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Instead of logging guest accesses to invalid register offsets in the
> Spitz flash device with zaurus_printf() (which just prints to stderr),
> use the usual qemu_log_mask(LOG_GUEST_ERROR,...).
>
> Signed-off-by: Peter Maydell
Reviewed-by: Philippe Math
On 6/28/20 4:24 PM, Peter Maydell wrote:
> Instead of using printf() for logging guest accesses to invalid
> register offsets in the pxa2xx PIC device, use the usual
> qemu_log_mask(LOG_GUEST_ERROR,...).
>
> This was the only user of the REG_FMT macro in pxa.h, so we can
> remove that.
>
> Signed
On 6/28/20 4:24 PM, Peter Maydell wrote:
> The QOM types "spitz-lcdtg" and "corgi-ssp" are missing the
> usual QOM TYPE and casting macros; provide and use them.
>
> In particular, we can safely use the QOM cast macros instead of
> FROM_SSI_SLAVE() because in both cases the 'ssidev' field of
> the
On 6/28/20 4:24 PM, Peter Maydell wrote:
> The FROM_SSI_SLAVE() macro predates QOM and is used as a typesafe way
> to cast from an SSISlave* to the instance struct of a subtype of
> TYPE_SSI_SLAVE. Switch to using the QOM cast macros instead, which
> have the same effect (by writing the QOM macros
> -邮件原件-
> 发件人: Stefan Hajnoczi
> 发送时间: 2020年6月22日 20:14
> 收件人: Lin Ma
> 抄送: qemu-devel@nongnu.org; f...@euphon.net; kw...@redhat.com;
> mre...@redhat.com; pbonz...@redhat.com
> 主题: Re: [PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16
> command
>
> On Wed, Jun 17, 2020 a
P J P 于2020年6月25日周四 上午2:59写道：
>
> From: Prasad J Pandit
>
> Add pci-intack mmio write method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun
> Signed-off-by: Prasad J Pandit
Reviewed-by: Li Qiang
> ---
> hw/pci-host/prep.c | 8
> 1 file changed, 8 insertions(+)
On 2020-06-26 at 19:20 CEST, Daniel P. Berrangé wrote...
> On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote:
>> If we want to build spice as a separately loadable module, we need to
>> put all the spice code in one loadable module, because the build
>> system does not know h
On 26/06/2020 20.13, Alex Bennée wrote:
The sooner we deprecate in-tree builds the sooner this mess of regexes
can be thrown away.
Signed-off-by: Alex Bennée
---
v2
- just use explicit !/.gitlab-ci.d
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitigno
24.06.2020 19:43, Markus Armbruster wrote:
This is to make the next commit easier to review.
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 2020-06-26 at 19:26 CEST, Daniel P. Berrangé wrote...
> On Fri, Jun 26, 2020 at 06:43:05PM +0200, Christophe de Dinechin wrote:
>> Instead of adding the spice build flags to the top-level build
>> options, add them where they are necessary. This is a step to move the
>> burden of linking with
P J P 于2020年6月25日周四 上午2:59写道：
>
> From: Prasad J Pandit
>
> Add pcie-msi mmio read method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun
> Signed-off-by: Prasad J Pandit
Reviewed-by: Li Qiang
> ---
> hw/pci-host/designware.c | 9 +
> 1 file changed, 9 insertion
move arch_init, balloon, cpus, ioport, memory, memory_mapping, qtest.
They are all specific to CONFIG_SOFTMMU.
Signed-off-by: Claudio Fontana
Reviewed-by: Alex Bennée
Reviewed-by: Laurent Vivier
Reviewed-by: Thomas Huth
---
MAINTAINERS | 12 ++--
Make
refactoring of cpus.c continues with cpu timer state extraction.
cpu-timers: responsible for the cpu timers state, and for access to
cpu clocks and ticks.
icount: counts the TCG instructions executed. As such it is specific to
the TCG accelerator. Therefore, it is built only under CONFIG_TCG.
On
Motivation and higher level steps:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html
Previous series: [RFC RESEND v7 0/4] QEMU cpus.c refactoring
This series is already reviewed, and is a split of the first three patches
from the previous series (RFC). The forth and last of the
move the vcpu throttling functionality into its own module.
This functionality is not specific to any accelerator,
and it is used currently by migration to slow down guests to try to
have migrations converge, and by the cocoa MacOS UI to throttle speed.
cpu-throttle contains the controls to adjus
P J P 于2020年6月25日周四 上午2:59写道：
>
> From: Prasad J Pandit
>
> Add vfio quirk device mmio write method to avoid NULL pointer
> dereference issue.
>
> Reported-by: Lei Sun
> Signed-off-by: Prasad J Pandit
Reviewed-by: Li Qiang
> ---
> hw/vfio/pci-quirks.c | 8
> 1 file changed, 8 inser
24.06.2020 19:43, Markus Armbruster wrote:
This is to make the next commit easier to review.
Signed-off-by: Markus Armbruster
---
util/qemu-option.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
Hi Peter,
On 6/28/20 10:37 PM, Peter Maydell wrote:
> Currently we have a free-floating set of IRQs and a function
> tosa_out_switch() which handle the GPIO lines on the tosa board which
> connect to LEDs, and another free-floating IRQ and tosa_reset()
> function to handle the GPIO line that reset
24.06.2020 19:43, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
29.06.2020 12:36, Vladimir Sementsov-Ogievskiy wrote:
24.06.2020 19:43, Markus Armbruster wrote:
This is to make the next commit easier to review.
Signed-off-by: Markus Armbruster
---
util/qemu-option.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
On Mon, Jun 29, 2020 at 11:22:40AM +0200, Christophe de Dinechin wrote:
>
> On 2020-06-26 at 19:20 CEST, Daniel P. Berrangé wrote...
> > On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote:
> >> If we want to build spice as a separately loadable module, we need to
> >> put all t
The vmgenid.o is the only file that is not in alphabetical order.
Signed-off-by: Christophe de Dinechin
---
stubs/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index f32b9e47a3..1df8bb3814 100644
--- a/stubs/Makefile.o
Hi Michael,
On 3/6/20 2:34 PM, Michael Rolnik wrote:
> Hi all.
>
> are there any action items for me?
FYI QEMU 5.1 soft freeze is next Tuesday, so even if Aleksandar
respin this week, it is very unlikely Richard and myself have
time to review it again before next week.
TBH let face it, AVR won'
each accelerator registers a new "CpusAccel" interface
implementation on initialization, providing functions for
starting a vcpu, kicking a vcpu, and sychronizing state.
This way the code in cpus.c is now all general softmmu code,
nothing accelerator-specific anymore.
There is still some ifdeffer
Motivation and higher level steps:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html
This is based on and requires "QEMU cpus.c refactoring part1":
https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09401.html
OPEN ITEMS:
* needs review
* requires HVF patches before thi
On 26/06/2020 20.13, Alex Bennée wrote:
From: Daniel P. Berrangé
We have a number of container images in tests/docker/dockerfiles
that are intended to provide well defined environments for doing
test builds. We want our CI system to use these containers too.
This introduces builds of all of th
David Gibson 于2020年6月25日周四 上午10:09写道：
>
> On Thu, Jun 25, 2020 at 12:25:20AM +0530, P J P wrote:
> > From: Prasad J Pandit
> >
> > Add spapr msi mmio read method to avoid NULL pointer dereference
> > issue.
> >
> > Reported-by: Lei Sun
> > Signed-off-by: Prasad J Pandit
>
Reviewed-by: Li Qiang
понедељак, 29. јун 2020., Philippe Mathieu-Daudé је
написао/ла:
> On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> > From: Huacai Chen
> >
> > Add myself as the maintainer for Loongson-3 virtual platforms, and
> > also add Jiaxun Yang as the reviewer.
> >
> > Signed-off-by: Huacai Chen
> > Co-d
On 6/26/20 6:43 PM, Christophe de Dinechin wrote:
> Signed-off-by: Christophe de Dinechin
> ---
> hw/display/qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index d5627119ec..28caf878cd 100644
> --- a/hw/display/qxl.c
> +++ b/h
Hi Yoshinori,
On 6/25/20 11:25 AM, Peter Maydell wrote:
> On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote:
>>
>> From: Yoshinori Sato
>>
>> renesas_tmr: 8bit timer modules.
>
> Hi; the recent Coverity run reports a potential bug in this
> code: (CID 1429976)
>
>
>> +static uint16_t
* Alex Williamson (alex.william...@redhat.com) wrote:
> On Fri, 26 Jun 2020 13:16:13 +0100
> "Dr. David Alan Gilbert" wrote:
>
> > * Alex Williamson (alex.william...@redhat.com) wrote:
> > > On Wed, 24 Jun 2020 19:59:39 +0530
> > > Kirti Wankhede wrote:
> > >
> > > > On 6/23/2020 1:58 AM, Ale
On 6/26/20 8:13 PM, Alex Bennée wrote:
> Most of the time we are just rebuilding the same things. We can skip
> this although currently there is no mechanism for picking up new
> distro releases.
>
> Rather than try to be too fine grained allow any change to trigger all
> the images being rebuilt.
On 6/26/20 8:13 PM, Alex Bennée wrote:
> As we run check-qtest in "SLOW" mode this can timeout so split into
> two jobs.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.yml | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --
25.06.2020 16:12, Markus Armbruster wrote:
Eric Blake writes:
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
util/qemu-option.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
i
On 6/26/20 8:13 PM, Alex Bennée wrote:
> Switch to building in the new debian-all-test-cross image which has
> most of the cross compilers inline.
>
> Signed-off-by: Alex Bennée
> ---
> .gitlab-ci.yml | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/.gitlab-ci.yml
On 6/26/20 8:13 PM, Alex Bennée wrote:
> The sooner we deprecate in-tree builds the sooner this mess of regexes
> can be thrown away.
:S
Reviewed-by: Philippe Mathieu-Daudé
>
> Signed-off-by: Alex Bennée
>
> ---
> v2
> - just use explicit !/.gitlab-ci.d
> ---
> .gitignore | 1 +
> 1 file
On Fri, Jun 26, 2020 at 07:13:56PM +0100, Alex Bennée wrote:
> Most of the time we are just rebuilding the same things. We can skip
> this although currently there is no mechanism for picking up new
> distro releases.
>
> Rather than try to be too fine grained allow any change to trigger all
> the
On 6/26/20 8:13 PM, Alex Bennée wrote:
> We've been misusing the tag naming scheme for some time by overloading
> the post : section with the image type. Really it should be saved for
> the revision of that particular build. Move the details to the other
> side so we have:
>
> qemu/image-name
>
On 6/26/20 8:13 PM, Alex Bennée wrote:
> From: Robert Foley
>
> This change converts existing scripts to using for example self.ROOT_PASS,
> to self._config['root_pass'].
> We made similar changes for GUEST_USER, and GUEST_PASS.
> This allows us also to remove the change in basevm.py,
> which add
24.06.2020 19:43, Markus Armbruster wrote:
There is just one use so far. The next commit will add more.
Signed-off-by: Markus Armbruster
---
util/qemu-option.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-opt
Christophe de Dinechin writes:
> The vmgenid.o is the only file that is not in alphabetical order.
>
> Signed-off-by: Christophe de Dinechin
Reviewed-by: Alex Bennée
> ---
> stubs/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/Makefile.objs b/s
Daniel P. Berrangé writes:
> On Fri, Jun 26, 2020 at 07:13:56PM +0100, Alex Bennée wrote:
>> Most of the time we are just rebuilding the same things. We can skip
>> this although currently there is no mechanism for picking up new
>> distro releases.
>>
>> Rather than try to be too fine grained
Hi Alex,
On 6/26/20 8:13 PM, Alex Bennée wrote:
> We need additional python packages to run check-acceptance. Add them
> to the docker images we will be using later.
I'm not sure everybody is interested by that. Maybe we could add an
extra 'acceptance-testing' Docker layer on top and use these im
On Thu, 2020-06-25 at 14:55 +0200, Max Reitz wrote:
> Similar to _require_working_luks for bash tests, these functions can be
> used to check whether our luks driver can actually create images.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/iotests.py | 39 ++
Hello Christophe,
On 6/26/20 6:42 PM, Christophe de Dinechin wrote:
> In order to facilitate the move of large chunks of functionality to
> load modules, it is simpler to create a wrapper with the same name
> that simply relays the implementation. For efficiency, this is
> typically done using inl
On 26/06/2020 20.13, Alex Bennée wrote:
From: Daniel P. Berrangé
Now that we're building standard container images from
dockerfiles in tests/docker/dockerfiles, we can convert
the build jobs to use them. The key benefit of this is
that a contributor can now more easily replicate the CI
environm
Cc'ing Wainer
On 6/26/20 8:13 PM, Alex Bennée wrote:
> As part of migrating things from Travis to GitLab add the acceptance
> tests. To do this:
>
> - rename system1 to system-ubuntu-main
> - rename system2 to system-fedora-misc
> - split into build/check/acceptance
> - remove -j from che
On 26/06/2020 20.13, Alex Bennée wrote:
We need additional python packages to run check-acceptance. Add them
to the docker images we will be using later.
Signed-off-by: Alex Bennée
---
tests/docker/dockerfiles/fedora.docker | 7 +++
tests/docker/dockerfiles/ubuntu2004.docker | 10 ++
On 6/26/20 8:13 PM, Alex Bennée wrote:
> We happily use all the cross images for both cross-building QEMU as
> well as building the linux-user tests. However calling docker from
> within docker seems not to work. As we can build in Debian anyway why
> not include an image that has all the compilers
On 6/29/20 11:49 AM, Christophe de Dinechin wrote:
> The vmgenid.o is the only file that is not in alphabetical order.
>
> Signed-off-by: Christophe de Dinechin
> ---
> stubs/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubs/Makefile.objs b/stubs/Makef
On Thu, Jun 25, 2020 at 01:07:14PM +, Lin Ma wrote:
> On 2020-06-25 20:59, Lin Ma wrote:
> > Please initialize is_deallocated to false at the beginning of the
> > function to avoid accidental uninitialized variable accesses in the
> > caller.
>
> It has already been initialized to 0 by 'data =
Hi,
The second report of the TCG Continuous Benchmarking series builds
upon the QEMU performance metrics calculated in the previous report.
This report presents a method to dissect the number of instructions
executed by a QEMU invocation into three main phases:
- Code Generation
- JIT Execution
-
virtio-fs devices are only specified for virtio-1, so it is unclear
how a legacy or transitional device should behave.
Signed-off-by: Cornelia Huck
---
Forcing off legacy now (after the virtio-fs device has already been
available) may have unintended consequences, therefore RFC.
By default, a v
понедељак, 29. јун 2020., Philippe Mathieu-Daudé је
написао/ла:
> On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> > This commit creates a new 'Miscellaneous' section which hosts a new
> > 'Performance Tools and Tests' subsection. This subsection will contain
> > the the performance scripts and b
On 26/06/2020 20.13, Alex Bennée wrote:
As part of migrating things from Travis to GitLab add the acceptance
tests. To do this:
- rename system1 to system-ubuntu-main
- rename system2 to system-fedora-misc
- split into build/check/acceptance
- remove -j from check stages
- use art
24.06.2020 19:43, Markus Armbruster wrote:
opt_set() frees its argument @value on failure. Slightly unclean;
functions ideally do nothing on failure.
To tidy this up, move opt_create() from opt_set() into its callers,
along with the cleanup.
Hmm, let me think a bit..
So, prior to this patch:
On Thu, Jun 25, 2020 at 01:31:56PM +, Lin Ma wrote:
> On 2020-06-25 21:25, Lin Ma wrote:
> >> +/*
> >> + * 8 + 16 is the length in bytes of response header and
> >> + * one LBA status descriptor
> >> + */
> >> +memset(outbuf, 0, 8 + 16);
> >> +outbuf[3] = 20;
> >> +o
понедељак, 29. јун 2020., Ahmed Karaman је
написао/ла:
> Hi,
>
> The second report of the TCG Continuous Benchmarking series builds
> upon the QEMU performance metrics calculated in the previous report.
> This report presents a method to dissect the number of instructions
> executed by a QEMU inv
On Wed, 24 Jun 2020 18:43:01 +0200
Markus Armbruster wrote:
> Convert
>
> foo(..., &err);
> if (err) {
> ...
> }
>
> to
>
> if (!foo(..., &err)) {
> ...
> }
>
> for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and their
> wrappers isa_realize_an
On Tue, Jun 23, 2020 at 07:39:58AM -, Martin Grigorov wrote:
> Public bug reported:
CCing Filip and Laurent, who may be interested in adding Linux AIO
syscalls to qemu-user.
>
> Hello
>
> I experience "Function not implemented" errors when trying to use Linux
> libaio library in foreign arc
1 - 100 of 409 matches
Mail list logo
