On Wed, Jun 24, 2020 at 9:25 PM Laurent Vivier <lviv...@redhat.com> wrote: > > On 22/06/2020 17:37, Cindy Lu wrote: > > From: Jason Wang <jasow...@redhat.com> > > > > With version 1, we can detect whether a queue is enabled via > > queue_enabled. > > > > Signed-off-by: Jason Wang <jasow...@redhat.com> > > Signed-off-by: Cindy Lu <l...@redhat.com> > > --- > > hw/virtio/virtio-pci.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > > index 4cb784389c..3918aa9f6c 100644 > > --- a/hw/virtio/virtio-pci.c > > +++ b/hw/virtio/virtio-pci.c > > @@ -1107,6 +1107,23 @@ static AddressSpace > > *virtio_pci_get_dma_as(DeviceState *d) > > return pci_get_address_space(dev); > > } > > > > +static bool virtio_queue_check_enabled(VirtIODevice *vdev, int n) > > +{ > > + return virtio_queue_get_desc_addr(vdev, n) != 0; > > +} > > This function is already defined under a different name in > hw/virtio/virtio.c: > > > 3287 bool virtio_queue_enabled(VirtIODevice *vdev, int n) > 3288 { > 3289 return virtio_queue_get_desc_addr(vdev, n) != 0; > 3290 } > > As this file includes "hw/virtio/virtio.h" you can use it directly. > Thanks Laurent, Will fix this > Thanks, > Laurent >