[PULL 57/57] target/arm: Enable MTE

From: Richard Henderson We now implement all of the components of MTE, without actually supporting any tagged memory. All MTE instructions will work, trivially, so we can enable support. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20200626033144.790098-46-richard.h

[PULL 51/57] target/arm: Implement data cache set allocation tags

From: Richard Henderson This is DC GVA and DC GZVA, and the tag check for DC ZVA. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20200626033144.790098-40-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 4 +++- target/arm/he

Re: [RFC PATCH 3/3] fuzz: Add callbacks for dma-access functions

On Tue, Jun 23, 2020 at 10:55:00AM -0400, Alexander Bulekov wrote: > On 200623 1514, Stefan Hajnoczi wrote: > > On Thu, Jun 11, 2020 at 01:56:51AM -0400, Alexander Bulekov wrote: > > > Signed-off-by: Alexander Bulekov > > > --- > > > exec.c| 17 - >

[PULL 54/57] target/arm: Cache the Tagged bit for a page in MemTxAttrs

From: Richard Henderson This "bit" is a particular value of the page's MemAttr. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20200626033144.790098-43-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.c | 48

Re: [PATCH v5] tcg: Sanitize shift constants on ppc64le so that shift operations with large constants don't generate invalid instructions.

On 6/7/20 2:10 PM, agrecascino...@gmail.com wrote: > From: "Catherine A. Frederick" > > Signed-off-by: Catherine A. Frederick > --- > Okay, I removed the bad "fix" on sar_i64, and the asserts in the various > functions. > Crossing my fingers here. > > tcg/ppc/tcg-target.inc.c | 34 ++

Re: [PATCH v9 0/5] vhost-user block device backend implementation

On Thu, Jun 25, 2020 at 08:46:56PM +0800, Coiby Xu wrote: > On Fri, Jun 19, 2020 at 01:07:46PM +0100, Stefan Hajnoczi wrote: > > On Mon, Jun 15, 2020 at 02:39:02AM +0800, Coiby Xu wrote: > > > v9 > > > - move logical block size check function to a utility function > > > - fix issues regarding lic

Re: [PULL 00/57] target-arm queue

Patchew URL: https://patchew.org/QEMU/20200626151424.30117-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/57] target-arm queue Type: series Message-id: 20200626151424.30117-1-peter.mayd...@linaro.o

Re: [PULL 00/12] Block patches

On Fri, 26 Jun 2020 at 14:01, Stefan Hajnoczi wrote: > > On Fri, Jun 26, 2020 at 11:49 AM Peter Maydell > wrote: > > > > On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > > > On Wed, 24 Jun 2020 at 11:02, Stefan H

Re: fpu/softfloat: a question on BFloat 16 support on QEMU

On 6/17/20 12:09 AM, LIU Zhiwei wrote: > If I want to test bfloat16 interfaces, could you give some advice? Should I > need to modify berkeley-testfloat-3 to support the bfloat16 test. I think we'll have to write some new code for this. Easiest might be: (1) shift left to convert bfloat16 to fl

Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description

пет, 26. јун 2020. у 12:27 Philippe Mathieu-Daudé је написао/ла: > > This RFC is simply a proof-of-concept to see if I correctly > understood Markus' suggestion, see the thread around: > https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg08652.html > > Philippe Mathieu-Daudé (3): > hw/i2c/

Re: [PULL 00/57] target-arm queue

Patchew URL: https://patchew.org/QEMU/20200626151424.30117-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/57] target-arm queue Type: series Message-id: 20200626151424.30117-1-peter.mayd...@linaro.o

[PATCH v2 1/3] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

In util/Makefile.objs, there is a setting for dbus.o-libs. Trying to copy-paste that to add a library for module.o that was was not otherwise linked yields link errors on a number of binaries, e.g. qemu-ga, with unsatisfied symbols in libqemuutil.a(module.o). The reason is that library dependencies

[PATCH v2 0/3] trace: Add a trace backend for the recorder library

The recorder library implements low-cost always-on tracing, with three usage models: 1. Flight recorder: Dump information on recent events in case of crash 2. Tracing: Individual traces can be enabled using environment variables 3. Real-time graphing / control, using the recorder_scope application

[PATCH v4 01/14] MAINTAINERS: Cc qemu-block mailing list

From: Philippe Mathieu-Daudé We forgot to include the qemu-block mailing list while adding this section in commit 076a0fc32a7. Fix this. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAIN

[PATCH v4 02/14] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

From: Philippe Mathieu-Daudé To make the next commit easier to review, clean this code first. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c i

[PATCH v2 2/3] trace: Add support for recorder back-end

The recorder library provides support for low-cost continuous recording of events, which can then be replayed. This makes it possible to collect data "after the fact",for example to show the events that led to a crash. Recorder support in qemu is implemented using the existing tracing interface. I

[PATCH v2 3/3] trace: Example of "centralized" recorder tracing

This is an example showing how the recorder can be used to have one "topic" covering multiple entries. Here, the topic is "lock". Here are a few use cases: - Checking locks: RECORDER_TRACES=lock qemu - Graphic visualization of locks: RECORDER_TRACES="lock=state,id" qemu & recorder_sco

[PATCH v4 03/14] hw/sd/sdcard: Move some definitions to use them earlier

Move some definitions to use them earlier. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index cac8d7d828..4816b4a462 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -80,6 +80,12 @@ enum S

[PATCH v4 07/14] hw/sd/sdcard: Check address is in range

As a defense, assert if the requested address is out of the card area. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 871c30a67f..0b606e9054 100644 --- a/hw/sd/sd.c +++ b/hw/sd/

[PATCH v4 05/14] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

Only move the state machine to ReceivingData if there is no pending error. This avoids later OOB access while processing commands queued. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.3 Data Read Read command is rejected if BLOCK_LEN_ERROR or ADDRESS_ERROR occurred

[PATCH v4 00/14] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

Patches 5 & 6 fix CVE-2020-13253. The rest are (accumulated) cleanups. Missing review: [PATCH 01/14] MAINTAINERS: Cc qemu-block mailing list [PATCH 03/14] hw/sd/sdcard: Move some definitions to use them earlier [PATCH 04/14] hw/sd/sdcard: Use the HWBLOCK_SIZE definition [PATCH 05/14] hw/sd/sdcard:

[PATCH v4 04/14] hw/sd/sdcard: Use the HWBLOCK_SIZE definition

Replace the following different uses of the same value by the same HWBLOCK_SIZE definition: - 512 (magic value) - 0x200 (magic value) - 1 << HWBLOCK_SHIFT Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --gi

[PATCH v4 09/14] hw/sd/sdcard: Simplify cmd_valid_while_locked()

cmd_valid_while_locked() only needs to read SDRequest->cmd, pass it directly and make it const. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 7d20f344b

[PATCH v4 06/14] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards

Only SCSD cards support Class 6 (Block Oriented Write Protection) commands. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.14 Command Functional Difference in Card Capacity Types * Write Protected Group SDHC and SDXC do not support write-protected groups. Issuing

[PATCH v4 10/14] hw/sd/sdcard: Constify sd_crc*()'s message argument

CRC functions don't modify the buffer argument, make it const. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index b887dce0e1..a0500f4551 100644 --- a/hw/sd/s

[PATCH v4 08/14] hw/sd/sdcard: Update the SDState documentation

Add more descriptive comments to keep a clear separation between static property vs runtime changeable. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c

[PATCH v4 14/14] hw/sd/sdcard: Simplify realize() a bit

We don't need to check if sd->blk is set twice. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 8fdee4ed56..46cd7c1aba 100644 --- a/hw/sd/sd.c +++ b/hw/sd

[PATCH v4 12/14] hw/sd/sdcard: Correctly display the command name in trace events

Some ACMD were incorrectly displayed. Fix by remembering if we are processing a ACMD (with current_cmd_is_acmd) and add the sd_current_cmd_name() helper, which display to correct name regardless it is a CMD or ACMD. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 17 ++--- 1 f

[PATCH v4 13/14] hw/sd/sdcard: Display offset in read/write_data() trace events

Having 'base address' and 'relative offset' displayed separately is more helpful than the absolute address. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 hw/sd/trace-events | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff -

[PATCH v4 11/14] hw/sd/sdcard: Make iolen unsigned

From: Philippe Mathieu-Daudé I/O request length can not be negative. Signed-off-by: Philippe Mathieu-Daudé --- v4: Use uint32_t (pm215) --- hw/sd/sd.c | 2 +- hw/sd/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index a0500f4

Re: [PATCH v2 0/3] trace: Add a trace backend for the recorder library

Patchew URL: https://patchew.org/QEMU/20200626162706.3304357-1-dinec...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 0/3] trace: Add a trace backend for the recorder library Type: series Message-id: 20200626162

Re: [PATCH v4 00/14] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

On Fri, Jun 26, 2020 at 6:28 PM Philippe Mathieu-Daudé wrote: > > Patches 5 & 6 fix CVE-2020-13253. > The rest are (accumulated) cleanups. Wrong branch... sorry for the noise :/

[PATCH v5 02/15] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

From: Philippe Mathieu-Daudé To make the next commit easier to review, clean this code first. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c i

[PATCH v5 01/15] MAINTAINERS: Cc qemu-block mailing list

From: Philippe Mathieu-Daudé We forgot to include the qemu-block mailing list while adding this section in commit 076a0fc32a7. Fix this. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAIN

[PATCH v5 00/15] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

Patches 5 & 6 fix CVE-2020-13253. The rest are (accumulated) cleanups. Missing review: [PATCH 01/15] MAINTAINERS: Cc qemu-block mailing list [PATCH 03/15] hw/sd/sdcard: Move some definitions to use them [PATCH 04/15] hw/sd/sdcard: Use the HWBLOCK_SIZE definition [PATCH 05/15] hw/sd/sdcard: Do not

[PATCH v5 07/15] hw/sd/sdcard: Initialize constant values first

Reorder initialization code, constant values first. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 871c30a67f..22392e5084 100644 --- a/hw/sd/sd.c +++ b/hw/sd

[PATCH v5 06/15] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards

Only SCSD cards support Class 6 (Block Oriented Write Protection) commands. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.14 Command Functional Difference in Card Capacity Types * Write Protected Group SDHC and SDXC do not support write-protected groups. Issuing

[PATCH v5 04/15] hw/sd/sdcard: Use the HWBLOCK_SIZE definition

Replace the following different uses of the same value by the same HWBLOCK_SIZE definition: - 512 (magic value) - 0x200 (magic value) - 1 << HWBLOCK_SHIFT Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --gi

[PATCH v5 03/15] hw/sd/sdcard: Move some definitions to use them earlier

Move some definitions to use them earlier. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index cac8d7d828..4816b4a462 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -80,6 +80,12 @@ enum S

[PATCH v5 05/15] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

Only move the state machine to ReceivingData if there is no pending error. This avoids later OOB access while processing commands queued. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.3 Data Read Read command is rejected if BLOCK_LEN_ERROR or ADDRESS_ERROR occurred

[PATCH 01/10] modules: Provide macros making it easier to identify module exports

In order to facilitate the move of large chunks of functionality to load modules, it is simpler to create a wrapper with the same name that simply relays the implementation. For efficiency, this is typically done using inline functions in the header for the corresponding functionality. In that case

[PATCH v5 09/15] hw/sd/sdcard: Update the SDState documentation

Add more descriptive comments to keep a clear separation between static property vs runtime changeable. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c

[PATCH v5 08/15] hw/sd/sdcard: Check address is in range

As a defense, assert if the requested address is out of the card area. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 22392e5084..2689a27b49 10

[PATCH 02/10] minikconf: Pass variables for modules

Signed-off-by: Christophe de Dinechin --- scripts/minikconf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/minikconf.py b/scripts/minikconf.py index bcd91015d3..d60add97f6 100755 --- a/scripts/minikconf.py +++ b/scripts/minikconf.py @@ -690,10 +690,10 @@ if __n

[PATCH v5 11/15] hw/sd/sdcard: Constify sd_crc*()'s message argument

CRC functions don't modify the buffer argument, make it const. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 115a5aa4c3..486538afc2 100644 --- a/hw/sd/s

[PATCH v5 10/15] hw/sd/sdcard: Simplify cmd_valid_while_locked()

cmd_valid_while_locked() only needs to read SDRequest->cmd, pass it directly and make it const. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index d9ae4090f

[PATCH v5 13/15] hw/sd/sdcard: Correctly display the command name in trace events

Some ACMD were incorrectly displayed. Fix by remembering if we are processing a ACMD (with current_cmd_is_acmd) and add the sd_current_cmd_name() helper, which display to correct name regardless it is a CMD or ACMD. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 17 ++--- 1 f

[PATCH v5 14/15] hw/sd/sdcard: Display offset in read/write_data() trace events

Having 'base address' and 'relative offset' displayed separately is more helpful than the absolute address. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 hw/sd/trace-events | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff -

[PATCH 03/10] spice: Make spice a module configuration

This commit changes the spice configuration 'm' by default, and moves the spice components to obj-m variables. It is sufficient to build without modules enable, but does not link correctly yet, since no shims have been created for the missing functions yet. Signed-off-by: Christophe de Dinechin -

[PATCH v5 12/15] hw/sd/sdcard: Make iolen unsigned

From: Philippe Mathieu-Daudé I/O request length can not be negative. Signed-off-by: Philippe Mathieu-Daudé --- v4: Use uint32_t (pm215) --- hw/sd/sd.c | 2 +- hw/sd/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 486538a

[PATCH 04/10] spice: Move all the spice-related code in spice-app.so

If we want to build spice as a separately loadable module, we need to put all the spice code in one loadable module, because the build system does not know how to deal with dependencies yet. Signed-off-by: Christophe de Dinechin --- audio/Makefile.objs | 2 +- chardev/Makefile.objs | 3 +-- ui

[PATCH v5 15/15] hw/sd/sdcard: Simplify realize() a bit

We don't need to check if sd->blk is set twice. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index f0b5527eaf..27a7862c98 100644 --- a/hw/sd/sd.c +++ b/hw/sd

Re: [PATCH] hw/arm: Add 'virtm' hardware

Peter Maydell writes: > So, I'm really dubious about adding more "virtual" > not-real-hardware boards. We have "virt" because we > absolutely have to have it for KVM purposes; but otherwise > "emulate real hardware" gives us a concrete specification > of what we're trying to do and tends to lead

[PATCH 05/10] build: Avoid build failure when building drivers as modules

Signed-off-by: Gerd Hoffmann Signed-off-by: Christophe de Dinechin --- Makefile.objs| 1 + Makefile.target | 7 +++ hw/Makefile.objs | 1 + 3 files changed, 9 insertions(+) diff --git a/Makefile.objs b/Makefile.objs index e38768c8d5..6703353493 100644 --- a/Makefile.objs +++ b/Makefile

[PATCH 07/10] qxl - FIXME: Build as module

Forcibly build qxl as a module to see if we can load it Signed-off-by: Christophe de Dinechin --- hw/display/Makefile.objs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs index 77a7d622bd..f51411619b 100644 --- a/hw/displa

[PATCH 00/10] RFC: Move SPICE to a load module

There has been a bit of discussion regarding the possibility to move SPICE code to a module in order to reduce the attack surface and memory usage when SPICE is not used. This WIP series proposes one way to do it that is relatively cheap in terms of code changes, relative to other ideas I tested,

[PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files

Instead of adding the spice build flags to the top-level build options, add them where they are necessary. This is a step to move the burden of linking with spice libraries away from the top-level qemu. Signed-off-by: Christophe de Dinechin --- configure| 4 ++-- hw/display/Make

Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description

On 6/26/20 5:59 PM, Aleksandar Markovic wrote: > пет, 26. јун 2020. у 12:27 Philippe Mathieu-Daudé је > написао/ла: >> >> This RFC is simply a proof-of-concept to see if I correctly >> understood Markus' suggestion, see the thread around: >> https://lists.gnu.org/archive/html/qemu-devel/2020-06/ms

[PATCH 06/10] trivial: Remove extra trailing whitespace

Signed-off-by: Christophe de Dinechin --- hw/display/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index d5627119ec..28caf878cd 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -51,7 +51,7 @@ #undef ALIGN #define ALIGN(a, b)

[PATCH 09/10] spice: Put spice functions in a separate load module

Use the MODIFACE and MODIMPL macros to to redirect the highest-level qemu_spice functions into the spice-app.so load module when SPICE is compiled as a module. With these changes, the following shared libraries are no longer necessary in the top-level qemu binary: libspice-server.so.1 =>

[PATCH 10/10] REMOVE: Instrumentation to show the module functions being replaced

Signed-off-by: Christophe de Dinechin --- include/qemu/module.h | 4 1 file changed, 4 insertions(+) diff --git a/include/qemu/module.h b/include/qemu/module.h index 1922a0293c..8d6e10ba81 100644 --- a/include/qemu/module.h +++ b/include/qemu/module.h @@ -14,10 +14,13 @@ #ifndef QEMU_MODUL

[PATCH v4 2/3] scripts/performance: Add topN_callgrind.py script

Python script that prints the top N most executed functions in QEMU using callgrind. Syntax: topN_callgrind.py [-h] [-n] -- \ [] \ [] [-h] - Print the script arguments help message. [-n] - Specify the number of top functions to print. - If this

[PATCH v4 0/3] Add Scripts for Finding Top 25 Executed Functions

Greetings, As a part of the TCG Continous Benchmarking project for GSoC this year, detailed reports discussing different performance measurement methodologies and analysis results will be sent here on the mailing list. The project's first report was published on the mailing list on the 22nd of Ju

Re: [PATCH v3 2/3] RISC-V: Copy the fdt in dram instead of ROM

On Fri, Jun 26, 2020 at 4:50 AM Bin Meng wrote: > > Hi Atish, > > On Fri, Jun 26, 2020 at 8:33 AM Atish Patra wrote: > > > > Currently, the fdt is copied to the ROM after the reset vector. The firmware > > has to copy it to DRAM. Instead of this, directly copy the device tree to a > > pre-compute

[PATCH v4 1/3] scripts/performance: Add topN_perf.py script

Syntax: topN_perf.py [-h] [-n] -- \ [] \ [] [-h] - Print the script arguments help message. [-n] - Specify the number of top functions to print. - If this flag is not specified, the tool defaults to 25. Example of usage: topN_perf.py -n 20 -- qemu-arm co

Re: [PATCH] migration/block-dirty-bitmap: fix add_bitmaps_to_list

26.06.2020 17:34, Eric Blake wrote: On 6/26/20 8:06 AM, Vladimir Sementsov-Ogievskiy wrote: We shouldn't fail, if found unnamed bitmap in a unnamed node or node We shouldn't fail when finding an unnamed with auto-generated node name, as bitmap migration ignores such bitmaps at all. such bi

[PATCH v4 3/3] MAINTAINERS: Add 'Performance Tools and Tests'subsection

This commit creates a new 'Miscellaneous' section which hosts a new 'Performance Tools and Tests' subsection. The subsection will contain the the performance scripts and benchmarks written as a part of the 'TCG Continuous Benchmarking' project. Signed-off-by: Ahmed Karaman Reviewed-by: Alex Benné

Re: [PATCH v4 00/14] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

Patchew URL: https://patchew.org/QEMU/20200626162818.25840-1-f4...@amsat.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /

Re: [PATCH v4 00/14] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

Patchew URL: https://patchew.org/QEMU/20200626162818.25840-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

QEMU | Pipeline #160548290 has failed for master | 87fb952d

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 87fb952d ( https://gitlab.com/qemu-project/qemu/-/commit/87fb952da83b223c82048a29aaf03680af1ea92f ) Commit Message: Merge remote-tr

[PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

This is a cleanup patch to follow-up the patch which introduced TSAN. This patch makes separate start_switch_fiber_ functions for TSAN and ASAN. This does two things: 1. Unrelated ASAN and TSAN code is separate and each function only has arguments that are actually needed. 2. The co->tsan_calle

Re: [PATCH v5 00/15] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

Patchew URL: https://patchew.org/QEMU/20200626164026.766-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote: > If we want to build spice as a separately loadable module, we need to > put all the spice code in one loadable module, because the build > system does not know how to deal with dependencies yet. > > Signed-off-by: Christophe

Re: [PATCH 07/46] error: Avoid more error_propagate() when error is not used here

24.06.2020 19:43, Markus Armbruster wrote: When all we do with an Error we receive into a local variable is propagating to somewhere else, we can just as well receive it there right away. The previous commit did that for simple cases with Coccinelle. Do it for a few more manually. Signed-off-b

Re: [PULL v2 00/31] Misc patches for 2020-06-24

On Fri, 26 Jun 2020 at 14:57, Paolo Bonzini wrote: > > The following changes since commit 5acc270a355120ce967ca1f1eeca0abbdb9303c8: > > Merge remote-tracking branch 'remotes/xtensa/tags/20200625-xtensa' into > staging (2020-06-25 21:20:45 +0100) > > are available in the Git repository at: > >

Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules

On Fri, Jun 26, 2020 at 06:43:02PM +0200, Christophe de Dinechin wrote: > Signed-off-by: Gerd Hoffmann > Signed-off-by: Christophe de Dinechin > --- > Makefile.objs| 1 + > Makefile.target | 7 +++ > hw/Makefile.objs | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/Makefile.o

Re: [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files

On Fri, Jun 26, 2020 at 06:43:05PM +0200, Christophe de Dinechin wrote: > Instead of adding the spice build flags to the top-level build > options, add them where they are necessary. This is a step to move the > burden of linking with spice libraries away from the top-level qemu. > > Signed-off-by

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: > On 6/17/20 7:13 PM, Philippe Mathieu-Daudé wrote: >> On 6/16/20 11:49 PM, Cleber Rosa wrote: >>> On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: On 6/9/20 11:55 PM, John Snow wrote: > > > On 6/9/2

Re: [PATCH 10/10] REMOVE: Instrumentation to show the module functions being replaced

On Fri, Jun 26, 2020 at 06:43:07PM +0200, Christophe de Dinechin wrote: > Signed-off-by: Christophe de Dinechin > --- > include/qemu/module.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/qemu/module.h b/include/qemu/module.h > index 1922a0293c..8d6e10ba81 100644 > ---

Re: [PATCH] hw/arm: Add 'virtm' hardware

On Fri, 26 Jun 2020 at 17:40, Keith Packard wrote: > > Peter Maydell writes: > > > So, I'm really dubious about adding more "virtual" > > not-real-hardware boards. We have "virt" because we > > absolutely have to have it for KVM purposes; but otherwise > > "emulate real hardware" gives us a concr

Re: [PATCH 09/10] spice: Put spice functions in a separate load module

On Fri, Jun 26, 2020 at 06:43:06PM +0200, Christophe de Dinechin wrote: > Use the MODIFACE and MODIMPL macros to to redirect the highest-level > qemu_spice functions into the spice-app.so load module when SPICE is > compiled as a module. > > With these changes, the following shared libraries are n

Re: [PATCH v5 08/15] hw/sd/sdcard: Check address is in range

On 6/26/20 6:40 PM, Philippe Mathieu-Daudé wrote: > As a defense, assert if the requested address is out of the card area. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > >

Re: [PATCH] hw/arm: Add 'virtm' hardware

On Fri, Jun 26, 2020 at 10:32 AM Peter Maydell wrote: > You might find the user-mode qemu-arm sufficient for that > kind of thing. I know some gcc tests run that way. You > get a processor, semihosting, and whatever memory your > ELF file's data segment says you have (plus anything > you care to m

[PATCH v2] timer: Handle decrements of PIT counter

There's a fallback to PIT if TSC is not present but it doesn't work properly. It prevents boot from floppy on isapc and 486 cpu [1][2]. SeaBIOS configures PIT in Mode 2. PIT counter is decremented in the mode but timer_adjust_bits() thinks that the counter overflows and increases 32-bit tick count

[PATCH v3 01/30] iotests: Fix 051 output after qdev_init_nofail() removal

From: Philippe Mathieu-Daudé Commit 96927c744 replaced qdev_init_nofail() call by isa_realize_and_unref() which has a different error message. Update the test output accordingly. Gitlab CI error after merging b77b5b3dc7: https://gitlab.com/qemu-project/qemu/-/jobs/597414772#L4375 Reported-by: T

[PATCH v3 05/30] tests/vm: Added configuration file support

From: Robert Foley Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example conf_example_aarch64.yml an

[PATCH v3 00/30] testing/next (gitlab, vm, docker)

Hi, This is the next iteration of my testing/next queue. The main changes from the last post: https://patchew.org/QEMU/20200624140446.15380-1-alex.ben...@linaro.org/ The GitLab docker patches are almost ready although there are a couple of problems running on GitLab's infrastructure which need

[PATCH v3 12/30] tests/vm: switch from optsparse to argparse

optparse has been deprecated since version 3.2 and argparse is the blessed replacement. Take the opportunity to enhance our help output showing defaults when called. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Robert Foley --- v2 - add explicit parser.add_argument

[PATCH v3 18/30] gitlab: introduce explicit "container" and "build" stages

From: Daniel P. Berrangé If no stage is listed, jobs get put in an implicit "test" stage. Some jobs which create container images to be used by later stages are currently listed as in a "build" stages. Signed-off-by: Daniel P. Berrangé Acked-by: Laszlo Ersek Signed-off-by: Alex Bennée Reviewe

[PATCH v3 02/30] crypto/linux_keyring: fix 'secret_keyring' configure test

From: David Edmondson The configure test for 'secret_keyring' incorrectly checked the 'have_keyring' variable. Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15 Signed-off-by: David Edmondson Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20200618092636.71832-1-david.edmond...

[PATCH v3 04/30] tests/vm: Add configuration to basevm.py

From: Robert Foley Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration

[PATCH v3 21/30] gitlab: build containers with buildkit and metadata

According to the documentation to be able to use --cache-from for remote registries you need to enable both buildkit and inline the metadata. We want to do this to support pulling from gitlab when users build their local docker images. Signed-off-by: Alex Bennée --- .gitlab-ci.d/containers.yml |

[PATCH v3 03/30] tests/vm: pass args through to BaseVM's __init__

From: Robert Foley Adding the args parameter to BaseVM's __init__. We will shortly need to pass more parameters to the class so let's just pass args rather than growing the parameter list. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phil

[PATCH v3 11/30] tests/vm: Add workaround to consume console

From: Robert Foley This adds support to basevm.py so that we always drain the console chars. This makes use of support added in an earlier commit that allows QEMUMachine to use the ConsoleSocket. This is a workaround we found was needed since there is a known issue where QEMU will hang waiting

[PATCH v3 17/30] gitlab-ci: Fix the change rules after moving the YML files

From: Thomas Huth The edk2.yml and opensbi.yml files have recently been moved/renamed, but the change has not been reflected in the rules in the YML files yet. Fixes: 922febe2af ("Move edk2 and opensbi YAML files to .gitlab-ci.d folder") Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PATCH v3 06/30] tests/vm: Add common Ubuntu python module

From: Robert Foley Add a common Ubuntu python module and make use of it with the ubuntu.i386 script. This is preparation for adding an Ubuntu script ubuntu.aarch64. Splitting out the common logic such as build_image() will reduce duplication. Signed-off-by: Robert Foley Tested-by: Philippe Mat

[PATCH v3 07/30] tests/vm: Added a new script for ubuntu.aarch64.

From: Robert Foley ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Signed-off-by:

[PATCH v3 13/30] tests/vm: allow us to take advantage of MTTCG

We currently limit TCG guests to -smp 1 but now we have added some aarch64 guests we can do better when running on x86_64 hardware. Raise the limit for TCG guests when it is safe to do so. Signed-off-by: Alex Bennée Reviewed-by: Robert Foley --- tests/vm/basevm.py | 6 ++ 1 file changed, 6

Re: [PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

24.06.2020 19:43, Markus Armbruster wrote: Replace error_setg(&err, ...); error_propagate(errp, err); by error_setg(errp, ...); Related pattern: if (...) { error_setg(&err, ...); goto out; } ... out: error_propagate(errp, err); retu

[PATCH v3 08/30] tests/vm: Added a new script for centos.aarch64.

From: Robert Foley centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20200601211421.1277-7-robert.fo...@linar

<    1   2   3   4   5   6   >