On Fri, Jun 26, 2020 at 06:43:07PM +0200, Christophe de Dinechin wrote:
> Signed-off-by: Christophe de Dinechin <dinec...@redhat.com>
> ---
> include/qemu/module.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/qemu/module.h b/include/qemu/module.h
> index 1922a0293c..8d6e10ba81 100644
> --- a/include/qemu/module.h
> +++ b/include/qemu/module.h
> @@ -14,10 +14,13 @@
> #ifndef QEMU_MODULE_H
> #define QEMU_MODULE_H
>
> +#include "trace/recorder.h"
>
> #define DSO_STAMP_FUN glue(qemu_stamp, CONFIG_STAMP)
> #define DSO_STAMP_FUN_STR stringify(DSO_STAMP_FUN)
>
> +RECORDER_DECLARE(modules);
> +
> #ifdef BUILD_DSO
> void DSO_STAMP_FUN(void);
> /* This is a dummy symbol to identify a loaded DSO as a QEMU module, so we
> can
> @@ -55,6 +58,7 @@ static void __attribute__((constructor)) do_qemu_init_ ##
> function(void) \
> static void __attribute__((constructor)) Name##_register(void) \
> { \
> Name = Name##_implementation; \
> + record(modules, "Setting " #Name " to %p", Name); \
> } \
> Ret Name##_implementation Args
> #else /* !CONFIG_MODULES */
Contrary to the commit $SUBJECT, I think you should keep this, not remove
it. It should use QEMU's trace backend though.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
