On Tue, 16 Jun 2020 08:45:14 +0200
Christian Borntraeger wrote:
> On 16.06.20 08:33, Cornelia Huck wrote:
> > On Tue, 16 Jun 2020 07:58:53 +0200
> > Christian Borntraeger wrote:
> >
> >> On 16.06.20 06:50, Halil Pasic wrote:
> >>> The atomic_cmpxchg() loop is broken because we occasionally
Patchew URL:
https://patchew.org/QEMU/20200619062518.1718523-1-alistair.fran...@wdc.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/b
Add the missing features(sha-ni, avx512ifma, rdpid, fsrm) in the
Icelake-Server CPU model.
Signed-off-by: Chenyi Qiang
---
target/i386/cpu.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 1f3d8db842..3c81ca543f 100644
--- a/target/i386
Add some missing VMX features in Skylake-Server, Cascadelake-Server and
Icelake-Server CPU models based on the output of Paolo's script.
Signed-off-by: Chenyi Qiang
---
target/i386/cpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.
Add the missing VMX features in Skylake-Server, Cascadelake-Server and
Icelake-Server CPU models. In Icelake-Server CPU model, it lacks sha_ni,
avx512ifma, rdpid and fsrm. The model number of Icelake-Server also needs
to be fixed.
Changes in v5:
- exclude Icelake-Client CPU model deprecati
According to the Intel Icelake family list, Icelake-Server uses model
number 106(0x6A).
Signed-off-by: Chenyi Qiang
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 3c81ca543f..f919607fa0 100644
--- a/target/i38
For CPUs support fast short REP MOV[CPUID.(EAX=7,ECX=0):EDX(bit4)], e.g
Icelake and Tigerlake, expose it to the guest VM.
Signed-off-by: Chenyi Qiang
---
target/i386/cpu.c | 2 +-
target/i386/cpu.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i
On 18.06.20 01:56, Halil Pasic wrote:
> On Tue, 16 Jun 2020 08:33:33 +0200
> Cornelia Huck wrote:
>
>>> #define atomic_cmpxchg__nocheck(ptr, old, new)({\
>>>
>>>
>>> typeof_strip_qual(*ptr) _old = (old); \
>>>
>>>
>>> (v
Patchew URL:
https://patchew.org/QEMU/20200619073114.24303-1-chenyi.qi...@intel.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
On Thu, Jun 18, 2020 at 01:11:44PM +0200, Christophe de Dinechin wrote:
> Hi Gerd,
>
>
> When I build qemu on master with moduels enabled, and run with spice, I
> occasionally see:
>
> qemu-system-x86_64: util/module.c:136: module_load_file: Assertion
> `QTAILQ_EMPTY(&dso_init_list)' failed.
On 18.06.20 14:03, Alberto Garcia wrote:
> On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote:
>> Sorry for the long delay. :/
>
> And sorry for my long delay as well.
>
>> The patch itself looks good, but I’m not sure whether it is extensive
>> enough. Let me just jump straight to the problem
On 6/19/20 12:22 AM, Collin Walling wrote:
> Functions within read scp/cpu info will need access to the machine
> state. Let's make a call to retrieve the machine state once and
> pass the appropriate data to the respective functions.
>
> Signed-off-by: Collin Walling
> Reviewed-by: David Hildenb
On Fri, 19 Jun 2020 09:33:44 +0200
David Hildenbrand wrote:
> On 18.06.20 01:56, Halil Pasic wrote:
> > On Tue, 16 Jun 2020 08:33:33 +0200
> > Cornelia Huck wrote:
> >
> >>> #define atomic_cmpxchg__nocheck(ptr, old, new)({
> >>> \
> >>>
> >>> typeof_strip_qual
On 6/19/20 12:22 AM, Collin Walling wrote:
> The header of the SCCB contains the actual length of the SCCB. Instead
> of using a static 4K size, let's allow for a variable size determined
> by the value set in the header. The proper checks are already in place
> to ensure the SCCB length is suffice
Cornelia Huck writes:
> On Thu, 18 Jun 2020 19:00:34 +0200
> Aleksandar Markovic wrote:
>
>> четвртак, 18. јун 2020., Cornelia Huck је написао/ла:
>>
>> > On Mon, 15 Jun 2020 15:18:48 -
>> > Alex Bennée <1883...@bugs.launchpad.net> wrote:
>> >
>> > > Public bug reported:
>> > >
>> >
On 6/19/20 12:22 AM, Collin Walling wrote:
> The start of the CPU entry region in the Read SCP Info response data is
> denoted by the offset_cpu field. As such, QEMU needs to begin creating
> entries at this address. Note that the length of the Read SCP Info data
> (data_len) denotes the same value
* Vivek Goyal (vgo...@redhat.com) wrote:
> On Thu, Jun 18, 2020 at 08:16:55PM +0100, Dr. David Alan Gilbert wrote:
> > * Vivek Goyal (vgo...@redhat.com) wrote:
> > > On Thu, Apr 16, 2020 at 05:49:05PM +0100, Stefan Hajnoczi wrote:
> > > > virtiofsd doesn't need of all Linux capabilities(7) availabl
On 19.06.20 04:05, David Gibson wrote:
> A number of hardware platforms are implementing mechanisms whereby the
> hypervisor does not have unfettered access to guest memory, in order
> to mitigate the security impact of a compromised hypervisor.
>
> AMD's SEV implements this with in-cpu memory enc
On 6/11/20 8:21 PM, Denis V. Lunev wrote:
> On 6/11/20 8:16 PM, Denis V. Lunev wrote:
>> Nowaday SCSI drivers in guests are able to align UNMAP requests before
>> sending to the device. Right now QEMU provides an ability to set
>> this via "discard_granularity" property of the block device which co
* Chirantan Ekbote (chiran...@chromium.org) wrote:
> On Fri, Jun 19, 2020 at 4:27 AM Vivek Goyal wrote:
> >
> > On Thu, Jun 18, 2020 at 08:16:55PM +0100, Dr. David Alan Gilbert wrote:
> > > * Vivek Goyal (vgo...@redhat.com) wrote:
> > > > On Thu, Apr 16, 2020 at 05:49:05PM +0100, Stefan Hajnoczi w
acpi aml generator needs this, but it is in floppy code now
so we can make the function static.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: John Snow
---
include/hw/block/fdc.h | 2 --
hw/block/fdc.c | 4 ++--
2 files changed,
The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits)
is not used any more, remove it from DSDT.
piix4 DSDT changes:
Scope (_SB.PCI0)
{
-Device (PX13)
-{
-Name (_ADR, 0x00010003) // _ADR: Address
-OperationRegion (P13C, PCI_Config, Zero,
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test-allowed-diff.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..8992f1f12b77 100644
--- a/tests/qtest
DSDT change: isa device order changes in case MI1 (ipmi) is present.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/block/fdc.c | 83
hw/i386/acpi-build.c | 83
stubs/cmos.c |
First batch of microvm patches, some generic acpi stuff.
Split the acpi-build.c monster, specifically split the
pc and q35 and pci bits into a separate file which we
can skip building at some point in the future.
v2 changes: leave acpi-build.c largely as-is, move useful
bits to other places to all
DSDT change: isa device order changes in case MI1 (ipmi) is present.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
---
hw/i386/acpi-build.c | 39 ---
hw/input/pckbd.c | 31 +++
2 f
The _STA methods for COM+LPT used to reference them,
but that isn't the case any more.
piix4 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x0001) // _ADR: Address
OperationRegion (P40C, PCI_Config, 0x60, 0x04)
-
Makes it easier to create good commit messages from the logs.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
---
tests/qtest/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
i
Seems to be unused.
ich9 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x001F) // _ADR: Address
OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
-OperationRegion (LPCD, PCI_Config, 0x80, 0x02)
-Field (L
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
in
Signed-off-by: Gerd Hoffmann
---
tests/data/acpi/pc/DSDT | Bin 5014 -> 4934 bytes
tests/data/acpi/pc/DSDT.acpihmat | Bin 6338 -> 6258 bytes
tests/data/acpi/pc/DSDT.bridge| Bin 6873 -> 6793 bytes
tests/data/acpi/pc/DSDT.cphp | Bin 5477 -> 5397 bytes
tests/data/acpi/pc/DSDT.
Add helper function to add fw_cfg device,
also move code to hw/i386/fw_cfg.c.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
---
hw/i386/fw_cfg.h | 1 +
hw/i386/acpi-build.c | 24 +---
hw/i386/fw_cfg.c | 28 +
On 2020/6/18 下午9:45, Maxime Coquelin wrote:
This patch specifies the VHOST_USER_SET_STATUS and
VHOST_USER_GET_STATUS requests, which are sent by
the master to update and query the Virtio status
in the backend.
Signed-off-by: Maxime Coquelin
---
Changes since v2:
=
- Typo: fix
On 6/19/20 12:22 AM, Collin Walling wrote:
> DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage
> of diagnostic information that is collected by the firmware in the case
> of hardware/firmware service events.
>
> QEMU handles the instruction by storing the info in the CPU stat
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: John Snow
---
include/hw/block/fdc.h | 1 +
include/hw/i386/pc.h | 1 -
hw/block/fdc.c | 26 +-
hw/i386/pc.c | 25 -
4 files changed, 26 insertions(+)
Hi,
> > Hmm, I guess feeding silence into jack needs some cpu cycles?
> > Maybe add a timer to close the jack server connection? Keep the
> > connection open for re-use for a while, but in case the guest stops
> > playing sound altogether close the jack connection after being unused
> > for a f
On 06/18/20 09:50, Auger Eric wrote:
> Hi Stefan, Igor,
>
> On 6/16/20 4:11 PM, Stefan Berger wrote:
>> On 6/16/20 8:33 AM, Igor Mammedov wrote:
>>>
>>> nevertheless looks like faithfull conversion,
>>> btw why you didn't drop Acpi20TPM2 structure definition?
>>>
>> If we get rid of the table we s
Hi Laszlo,
On 6/19/20 11:38 AM, Laszlo Ersek wrote:
> On 06/18/20 09:50, Auger Eric wrote:
>> Hi Stefan, Igor,
>>
>> On 6/16/20 4:11 PM, Stefan Berger wrote:
>>> On 6/16/20 8:33 AM, Igor Mammedov wrote:
nevertheless looks like faithfull conversion,
btw why you didn't drop Acpi20TPM2
On Fri, 19 Jun 2020 10:28:22 +0200
David Hildenbrand wrote:
> On 19.06.20 04:05, David Gibson wrote:
> > A number of hardware platforms are implementing mechanisms whereby the
> > hypervisor does not have unfettered access to guest memory, in order
> > to mitigate the security impact of a comprom
On Fri, Jun 19, 2020 at 10:28:22AM +0200, David Hildenbrand wrote:
> On 19.06.20 04:05, David Gibson wrote:
> > A number of hardware platforms are implementing mechanisms whereby the
> > hypervisor does not have unfettered access to guest memory, in order
> > to mitigate the security impact of a co
Patchew URL: https://patchew.org/QEMU/20200619091905.21676-1-kra...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export
Since commit d70c996df23f, when enabling the PMU we get:
$ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3
Segmentation fault (core dumped)
Thread 1 "qemu-system-aar" received signal SIGSEGV, Segmentation fault.
0xaae356d0 in kvm_ioctl (s=0x0, type=44547) at
>> "host-trust-limitation" sounds like "I am the hypervisor, I configure
>> limited trust into myself". Also, "untrusted-host" would be a little bit
>> nicer (I think trust is a black/white thing).
>>
>> However, once we have multiple options to protect a guest (memory
>> encryption, unmapping gue
>> However, once we have multiple options to protect a guest (memory
>> encryption, unmapping guest pages ,...) the name will no longer really
>> suffice to configure QEMU, no?
>
> That's why it takes a parameter. It points to an object which can
> itself have more properties to configure the det
On Fri, 19 Jun 2020 11:56:49 +0200
David Hildenbrand wrote:
> >>> For now this series covers just AMD SEV and POWER PEF. I'm hoping it
> >>> can be extended to cover the Intel and s390 mechanisms as well,
> >>> though.
> >>
> >> The only approach on s390x to not glue command line properties
It is not used outside the module.
Actually there are 2 kind of waiters:
- for a slot and
- for all tasks to finish
This patch limits external API to listed types.
Signed-off-by: Denis V. Lunev
Suggested-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Vladimir Sementsov-Ogievskiy
CC: Kevin Wolf
Right now bdrv_fclose() is just calling bdrv_flush().
The problem is that migration code is working inefficiently from block
layer terms and are frequently called for very small pieces of
unaligned data. Block layer is capable to work this way, but this is very
slow.
This patch is a preparation f
bdrv_save_vmstate() returns either error with negative return value or
size. Thus this check is useless.
Signed-off-by: Denis V. Lunev
Suggested-by: Eric Blake
CC: Kevin Wolf
CC: Max Reitz
CC: Stefan Hajnoczi
CC: Fam Zheng
CC: Juan Quintela
CC: "Dr. David Alan Gilbert"
CC: Vladimir Sements
qemu_fclose() could return error, f.e. if bdrv_co_flush() will return
the error.
This validation will become more important once we will start waiting of
asynchronous IO operations, started from bdrv_write_vmstate(), which are
coming soon.
Signed-off-by: Denis V. Lunev
Reviewed-by: "Dr. David Al
This series do standard basic things:
- it creates intermediate buffer for all writes from QEMU migration code
to QCOW2 image,
- this buffer is sent to disk asynchronously, allowing several writes to
run in parallel.
In general, migration code is fantastically inefficent (by observation),
buff
From: Vladimir Sementsov-Ogievskiy
Currently, aio task pool assumes that there is a main coroutine, which
creates tasks and wait for them. Let's remove the restriction by using
CoQueue. Code becomes clearer, interface more obvious.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Deni
On 19.06.20 12:05, Cornelia Huck wrote:
> On Fri, 19 Jun 2020 11:56:49 +0200
> David Hildenbrand wrote:
>
> For now this series covers just AMD SEV and POWER PEF. I'm hoping it
> can be extended to cover the Intel and s390 mechanisms as well,
> though.
The only approach
This patch does 2 standard basic things:
- it creates intermediate buffer for all writes from QEMU migration code
to block driver,
- this buffer is sent to disk asynchronously, allowing several writes to
run in parallel.
Thus bdrv_vmstate_write() is becoming asynchronous. All pending operation
Several components used by qemu-storage-daemon have cleanup functions
that aren't called. Keep the "valgrind --leak-check=full" as clean as
possible by invoking the necessary cleanup functions.
Signed-off-by: Stefan Hajnoczi
---
qemu-storage-daemon.c | 4
1 file changed, 4 insertions(+)
di
The --object option is supported by qemu-storage-daemon but the
qemu_object_opts QemuOptsList wasn't being added. As a result calls to
qemu_find_opts("object") failed with "There is no option group
'object'".
This patch fixes the object-del QMP command.
Signed-off-by: Stefan Hajnoczi
---
qemu-s
Small fixes for qemu-storage-daemon.
Stefan Hajnoczi (2):
qemu-storage-daemon: remember to add qemu_object_opts
qemu-storage-daemon: add missing cleanup calls
qemu-storage-daemon.c | 5 +
1 file changed, 5 insertions(+)
--
2.26.2
On Fri, Jun 19, 2020 at 12:06:02PM +1000, David Gibson wrote:
> The default behaviour for virtio devices is not to use the platforms normal
> DMA paths, but instead to use the fact that it's running in a hypervisor
> to directly access guest memory. That doesn't work if the guest's memory
> is pro
Patchew URL: https://patchew.org/QEMU/20200619095542.2095-1-phi...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export
On Fri, Jun 19, 2020 at 11:55:42AM +0200, Philippe Mathieu-Daudé wrote:
> Since commit d70c996df23f, when enabling the PMU we get:
>
> $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3
> Segmentation fault (core dumped)
>
> Thread 1 "qemu-system-aar" received signal SIG
On 6/19/20 12:23 PM, Andrew Jones wrote:
> On Fri, Jun 19, 2020 at 11:55:42AM +0200, Philippe Mathieu-Daudé wrote:
>> Since commit d70c996df23f, when enabling the PMU we get:
>>
>> $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3
>> Segmentation fault (core dumped)
>>
>>
Fix typo.
Fixes: acd0c9416d48 ("xen: fix build without pci passthrough")
Signed-off-by: Anthony PERARD
---
hw/xen/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index 3fc715e5954d..502b32d877a0 100644
--- a/hw/xen/Mak
On Tue, 24 Jul 2018 at 11:51, Alex Bennée wrote:
>
> Not all docker images can run the check step. Let's move everything
> into a common helper so we don't need to replicate checks in the
> future.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philippe Mathieu
Signed-off-by: Max Reitz
---
tests/qemu-iotests/244 | 65 ++
tests/qemu-iotests/244.out | 23 ++
2 files changed, 88 insertions(+)
diff --git a/tests/qemu-iotests/244 b/tests/qemu-iotests/244
index efe3c0428b..c2fdeab0c7 100755
--- a/tests/qemu
On 6/19/20 12:31 PM, Anthony PERARD wrote:
> Fix typo.
>
> Fixes: acd0c9416d48 ("xen: fix build without pci passthrough")
> Signed-off-by: Anthony PERARD
> ---
> hw/xen/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.
Setting the qcow2 data-file-raw bit means that you can ignore the
qcow2 metadata when reading from the external data file. It does not
mean that you have to ignore it, though. Therefore, the data read must
be the same regardless of whether you interpret the metadata or whether
you ignore it, and
Hi,
As discussed here:
https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html
https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00329.html
https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00240.html
I think that qcow2 images with data-file-raw should always h
On Thu, 18 Jun 2020 at 14:21, Jason Wang wrote:
>
> The following changes since commit 3f429a3400822141651486193d6af625eeab05a5:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/microvm-20200617-pull-request' into staging (2020-06-18
> 11:23:15 +0100)
>
> are available in the git reposi
> -Original Message-
> From: Anthony PERARD
> Sent: 19 June 2020 11:31
> To: qemu-devel@nongnu.org
> Cc: Paolo Bonzini ; Anthony PERARD
> ; Stefano
> Stabellini ; Paul Durrant ;
> xen-de...@lists.xenproject.org
> Subject: [PATCH] xen: Actually fix build without passthrough
>
> Fix ty
On Fri, 19 Jun 2020 at 04:19, Jason Wang wrote:
>
>
> On 2020/6/18 下午10:05, no-re...@patchew.org wrote:
> > /tmp/qemu-test/src/tests/qht-bench.c:287:29: error: implicit conversion
> > from 'unsigned long' to 'double' changes value from 18446744073709551615 to
> > 18446744073709551616 [-Werror,-W
+-- On Thu, 18 Jun 2020, Paolo Bonzini wrote --+
| On 18/06/20 15:12, Alex Bennée wrote:
| > If you look at memory_region_dispatch_write you can see that
| > mr->ops->write being empty is acceptable because it implies
| > mr->ops->write_with_attrs is set instead. I think the same is true for
|
On 6/19/20 12:22 AM, Collin Walling wrote:
> Rework the SCLP boundary check to account for different SCLP commands
> (eventually) allowing different boundary sizes.
>
> Move the length check code into a separate function, and introduce a
> new function to determine the length of the read SCP data
On 6/16/20 2:22 AM, BALATON Zoltan wrote:
> Instead of open coding op with different sizes using a switch and type
> casting it can be written more compactly using stn_he_p/ldn_he_p.
>
> Suggested-by: Peter Maydell
> Signed-off-by: BALATON Zoltan
> ---
> hw/display/sm501.c | 12 +---
>
On 19/06/20 12:48, P J P wrote:
> | - hw/nvram/nrf51_nvm.c's flash_ops which is fixed if ROMD regions are
> | changed not to require a read callback.
> |
> | - designware_pci_host_msi_ops which is broken and should have a dummy
> | read callback.
>
>
> ie. we add these routines along with the as
Patchew URL: https://patchew.org/QEMU/20200619100708.30440-1-...@openvz.org/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export AR
On Wed, 3 Jun 2020 at 02:13, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> v3: Require pre-cleaned addresses.
> v6: Check full mte enabled. Reorg the helpers
Reviewed-by: Peter Maydell
thanks
-- PMM
On Fri 19 Jun 2020 09:57:27 AM CEST, Max Reitz wrote:
>> If two images have the same contents but then you compare them
>> changing the backing file of one of them you can also get a content
>> mismatch. How is this different?
>
> It’s different in that files with data-file-raw can’t have backing
>
On 6/18/20 2:33 PM, Philippe Mathieu-Daudé wrote:
> From: Alex Bennée
>
> As we encode the base architecture in configure.sh, we can emit
> the base-arch() function into config-host.mak.
>
> Signed-off-by: Alex Bennée
I'm not sure it is implicit by the S-o-b tag following, so:
Reviewed-by: Ph
* Chirantan Ekbote (chiran...@chromium.org) wrote:
> On Fri, Jun 19, 2020 at 5:40 PM Dr. David Alan Gilbert
> wrote:
> >
> > * Chirantan Ekbote (chiran...@chromium.org) wrote:
> >
> > > We ended up working around it by prefixing "user.virtiofs." to the
> > > xattr name[2], which has its own proble
Patchew URL:
https://patchew.org/QEMU/20200619101132.2401756-1-stefa...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
e
On 19/06/20 07:46, Pavel Dovgalyuk wrote:
> I think, that we need some efforts from target maintainers to remove all such
> calls.
I'll take care of target/i386 (which does need one of the three
gen_io_end calls that are left).
>> Q2: is it a requirement that after an insn which is a "known
>>
On 6/19/20 5:43 AM, Auger Eric wrote:
Hi Laszlo,
On 6/19/20 11:38 AM, Laszlo Ersek wrote:
On 06/18/20 09:50, Auger Eric wrote:
Hi Stefan, Igor,
On 6/16/20 4:11 PM, Stefan Berger wrote:
On 6/16/20 8:33 AM, Igor Mammedov wrote:
nevertheless looks like faithfull conversion,
btw why you didn't
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 292ef18a (
https://gitlab.com/qemu-project/qemu/-/commit/292ef18a38270e1cb8e9a3dc06bca589068f293d
)
Commit Message: Merge remote-tr
Patchew URL:
https://patchew.org/QEMU/20200619103115.254127-1-anthony.per...@citrix.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/b
On Fri, Jun 19, 2020 at 02:51:51AM -0700, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200619091905.21676-1-kra...@redhat.com/
>
>
>
> Hi,
>
> This series failed the asan build test. Please find the testing commands and
> their output below. If you have Docker instal
On Fri, Jun 19, 2020 at 09:27:46AM +0100, Dr. David Alan Gilbert wrote:
> * Vivek Goyal (vgo...@redhat.com) wrote:
> > On Thu, Jun 18, 2020 at 08:16:55PM +0100, Dr. David Alan Gilbert wrote:
> > > * Vivek Goyal (vgo...@redhat.com) wrote:
> > > > On Thu, Apr 16, 2020 at 05:49:05PM +0100, Stefan Hajn
On Fri, Jun 19, 2020 at 11:55:42AM +0200, Philippe Mathieu-Daudé wrote:
> Since commit d70c996df23f, when enabling the PMU we get:
>
> $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3
> Segmentation fault (core dumped)
>
> Thread 1 "qemu-system-aar" received signal SIG
On Fri, Jun 19, 2020 at 11:12:45AM +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 19, 2020 at 12:06:02PM +1000, David Gibson wrote:
> > The default behaviour for virtio devices is not to use the platforms normal
> > DMA paths, but instead to use the fact that it's running in a hypervisor
> > to di
On Fri, Jun 19, 2020 at 07:46:14AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jun 19, 2020 at 11:12:45AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Jun 19, 2020 at 12:06:02PM +1000, David Gibson wrote:
> > > The default behaviour for virtio devices is not to use the platforms
> > > normal
> > >
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Fri, Jun 19, 2020 at 09:27:46AM +0100, Dr. David Alan Gilbert wrote:
> > * Vivek Goyal (vgo...@redhat.com) wrote:
> > > On Thu, Jun 18, 2020 at 08:16:55PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Vivek Goyal (vgo...@redhat.com) wrote:
> >
Patchew URL: https://patchew.org/QEMU/20200619104012.235977-1-mre...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
expor
Hello Bastian,
I assume that your review comments, which Georg has answered, are solved. I
will implement the remaining suggestions in a new version of the patch.
Regards,
Andreas
> -Ursprüngliche Nachricht-
> Von: Hofstetter, Georg (EFS-GH2)
> Gesendet: Mittwoch, 10. Juni 2020 15:50
vhost_user_server_set_aio_context() operates on a VuServer object. Make
that the first argument of the function since it is conventional to
define functions with the object they act on as the first argument. In
other words, obj_action(obj, args...) is commonly used and not
obj_action(arg1, ..., obj
The event loop has the concept of "external" fd handlers that process
requests from outside clients such as the guest. External fd handlers
are disabled during critical sections where new requests are not
allowed.
The vhost-user-server seems like an "external" client to me and
therefore should mar
Commit b650d5f4b1cd3f9f8c4fdb319838c5c1e0695e41 ("Lift max ram slots
limit in libvhost-user") renamed this constant. Use the array size
instead of hard-coding a particular constant in the error message.
Signed-off-by: Stefan Hajnoczi
---
util/vhost-user-server.c | 4 ++--
1 file changed, 2 inser
QEMU uses the gtkdoc style for API doc comments. For examples, see
include/qom/object.h.
Fully document the function with up-to-date information (the min/max
values were outdated).
Signed-off-by: Stefan Hajnoczi
---
util/block-helpers.c | 18 ++
1 file changed, 10 insertions(+),
Signed-off-by: Stefan Hajnoczi
---
util/vhost-user-server.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c
index e94a8d8a83..49ada8bc78 100644
--- a/util/vhost-user-server.c
+++ b/util/vhost-user-server.c
@@ -7,7 +7,6 @@
* later. See the
Move the constants from hw/core/qdev-properties.c to
util/block-helpers.h so that knowledge of the min/max values is
encapsulated in block-helpers code.
Callers should not assume specific min/max values. In fact, the values
in hw/core/qdev-properties.c and util/block-helpers.c did not match. Use
t
The uint16_t type is too small for MAX_BLOCK_SIZE (2 MiB). The int64_t
type is widely used in QEMU as a type for disk offsets and sizes, so
it's an appropriate type to use here. It will work for all callers.
Signed-off-by: Stefan Hajnoczi
---
util/block-helpers.h | 2 +-
util/block-helpers.c | 4
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Since commit d70c996df23f, when enabling the PMU we get:
>
> $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3
> Segmentation fault (core dumped)
>
> Thread 1 "qemu-system-aar" received signal SIGSEGV, Segmentation f
If we use errp then we won't know when check_block_size() fails when
errp is NULL.
The purpose of local_err is to detect an error has occurred even if the
caller doesn't care about the specific error and has passed a NULL errp.
Signed-off-by: Stefan Hajnoczi
---
hw/core/qdev-properties.c | 5 ++
1 - 100 of 486 matches
Mail list logo
