On 6/16/20 2:22 AM, BALATON Zoltan wrote:
> Instead of open coding op with different sizes using a switch and type
> casting it can be written more compactly using stn_he_p/ldn_he_p.
>
> Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
> ---
> hw/display/sm501.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index b6356ea1ee..6e914d3162 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -766,17 +766,7 @@ static void sm501_2d_operation(SM501State *s)
> for (y = 0; y < height; y++) {
> i = (dst_x + (dst_y + y) * dst_pitch) * bypp;
> for (x = 0; x < width; x++, i += bypp) {
> - switch (format) {
> - case 0:
> - d[i] = ~d[i];
> - break;
> - case 1:
> - *(uint16_t *)&d[i] = ~*(uint16_t *)&d[i];
> - break;
> - case 2:
> - *(uint32_t *)&d[i] = ~*(uint32_t *)&d[i];
> - break;
> - }
> + stn_he_p(&d[i], bypp, ~ldn_he_p(&d[i], bypp));
> }
> }
> } else {
>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
