Understanding initialization order for spice in qemu

Hi Gerd, When I build qemu on master with moduels enabled, and run with spice, I occasionally see: qemu-system-x86_64: util/module.c:136: module_load_file: Assertion `QTAILQ_EMPTY(&dso_init_list)' failed. Interestingly, I seem to have seen that only on master, but not on my own branch. Have

Re: [PATCH v7 06/42] target/arm: Add DISAS_UPDATE_NOCHAIN

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Add an option that writes back the PC, like DISAS_UPDATE_EXIT, > but does not exit back to the main loop. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 0/4] Microvm 20200617 patches

On Wed, 17 Jun 2020 at 13:33, Gerd Hoffmann wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the Git

[PATCH] docs: vhost-user: add Virtio status protocol feature

This patch specifies the VHOST_USER_SET_STATUS and VHOST_USER_GET_STATUS requests, which are sent by the master to update and query the Virtio status in the backend. Signed-off-by: Maxime Coquelin --- Changes since v1: = - Only keep the spec part in this patch, the implementation

Re: Understanding initialization order for spice in qemu

Christophe de Dinechin writes: > Hi Gerd, > > > When I build qemu on master with moduels enabled, and run with spice, I > occasionally see: > > qemu-system-x86_64: util/module.c:136: module_load_file: Assertion > `QTAILQ_EMPTY(&dso_init_list)' failed. > > Interestingly, I seem to have seen t

Re: [PATCH v7 07/42] target/arm: Add MTE system registers

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > This is TFSRE0_EL1, TFSR_EL1, TFSR_EL2, TFSR_EL3, > RGSR_EL1, GCR_EL1, GMID_EL1, and PSTATE.TCO. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

QEMU | Pipeline #157572877 has failed for master | bac8d222

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: bac8d222 ( https://gitlab.com/qemu-project/qemu/-/commit/bac8d222a19f4a30d0a17980bd932f23a6af77bb ) Commit Message: configure: Add

Re: [PATCH v7 08/42] target/arm: Add MTE bits to tb_flags

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Cache the composite ATA setting. > > Cache when MTE is fully enabled, i.e. access to tags are enabled > and tag checks affect the PE. Do this for both the normal context > and the UNPRIV context. > > Signed-off-by: Richard Henderson Revi

Re: [PATCH 4/5] GitLab Gating CI: introduce pipeline-status contrib script

On Thu, Mar 12, 2020 at 03:36:15PM -0400, Cleber Rosa wrote: > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or wit

Re: [PATCH v7 09/42] target/arm: Implement the IRG instruction

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Update to 00eac5. > Merge choose_random_nonexcluded_tag into helper_irg since > that pseudo function no longer exists separately. > v6: Remove obsolete logical/physical tag distinction;

Re: [Bug 1883560] [NEW] mips linux-user builds occasionly crash randomly only to be fixed by a full clean re-build

On Mon, 15 Jun 2020 15:18:48 - Alex Bennée <1883...@bugs.launchpad.net> wrote: > Public bug reported: > > >From time to time I find check-tcg crashes with a one of the MIPS > binaries. The last time it crashed was running the test: > > ./mips64el-linux-user/qemu-mips64el ./tests/tcg/mips

Re: [PATCH] docs: vhost-user: add Virtio status protocol feature

Patchew URL: https://patchew.org/QEMU/20200618112908.130528-1-maxime.coque...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/

Re: [PATCH v2 0/2] target/mips: Add two groups of loongson-ext instructions

среда, 17. јун 2020., Jiaxun Yang је написао/ла: > > > 在 2020/6/16 22:41, Aleksandar Markovic 写道: > >> >> >> уторак, 16. јун 2020., Jiaxun Yang > jiaxun.y...@flygoat.com>> је написао/ла: >> >> >> >> 在 2020/6/16 18:38, Aleksandar Markovic 写道: >> >> >> >> уторак, 16. јун 2020., Jiaxun Y

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote: > Sorry for the long delay. :/ And sorry for my long delay as well. > The patch itself looks good, but I’m not sure whether it is extensive > enough. Let me just jump straight to the problem: > > $ ./qemu-img create -f qcow2 \ > -o data_f

[PATCH v1] memory: assert MemoryRegionOps callbacks are defined

From: Prasad J Pandit When registering a MemoryRegionOps object, assert that its read/write callback methods are defined. This avoids potential guest crash via a NULL pointer dereference. Suggested-by: Peter Maydell Signed-off-by: Prasad J Pandit --- memory.c | 5 + 1 file changed, 5 inse

Re: qemu-pr-helper -v suppresses errors, isn't that weird?

On 18/06/20 07:32, Markus Armbruster wrote: > prh_co_entry() reports reports errors reading requests / writing > responses only when @verbose (command line -v); relevant code appended > for you convenience. > > Sure these are *errors*? The program recovers and continues, and this > is deemed norm

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

On 16/06/20 09:51, Philippe Mathieu-Daudé wrote: > This series contains few patches resulting from the notes I > took while reviewing Mark ADB series last Sunday, in particular: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html > > I have another patch for hw/input/hid.c but I pr

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

On 6/18/20 2:23 PM, Paolo Bonzini wrote: > On 16/06/20 09:51, Philippe Mathieu-Daudé wrote: >> This series contains few patches resulting from the notes I >> took while reviewing Mark ADB series last Sunday, in particular: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html >> >> I

[PATCH v3] arm/virt: Add memory hot remove support

This adds support for memory(pc-dimm) hot remove on arm/virt that uses acpi ged device. NVDIMM hot removal is not yet supported. Signed-off-by: Shameer Kolothum --- V2 --> v3 -Addressed Eric's review comment and added check for NVDIMM. RFC v1 --> v2 -Rebased on top of latest Qemu master. -

[PATCH v9 02/10] MAINTAINERS: Add an 'overall' entry for accelerators

Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5184cf46b3..426439a2c3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -416,6 +416,17 @@ S

[PATCH v9 00/10] accel: Allow targets to use Kconfig

Missing review: - 03/10 MAINTAINERS: Cover the HAX accelerator stub - 04/10 configure: Generate rule to calculate base arch of target This series include generic patches I took of the KVM/ARM specific series which will follow. - Update accelerators in MAINTAINERS - Add accel/Kconfig - Allow targe

[PATCH v9 03/10] MAINTAINERS: Cover the HAX accelerator stub

Cover accel/stubs/hax-stub.c in the HAXM section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 426439a2c3..cebb0d385a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -476,6 +476,7 @@ M: Colin Xu L: haxm-

[PATCH v9 06/10] Makefile: Write MINIKCONF variables as one entry per line

Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++--- 1 file changed, 6 insertions(+)

[PATCH v9 09/10] Makefile: Allow target-specific optional Kconfig

Allow use of target-specific Kconfig file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 00e8553745..c131c4e99d 100644 --- a/Makefile ++

[PATCH v9 01/10] MAINTAINERS: Fix KVM path expansion glob

The KVM files has been moved from target-ARCH to the target/ARCH/ folder in commit fcf5ef2a. Fix the pathname expansion. Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Signed-off-by: Philippe Math

QEMU | Pipeline #157595486 has failed for master | 3f429a34

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 3f429a34 ( https://gitlab.com/qemu-project/qemu/-/commit/3f429a3400822141651486193d6af625eeab05a5 ) Commit Message: Merge remote-tr

[PATCH v9 07/10] accel/Kconfig: Extract accel selectors into their own config

Move the accel selectors from the global Kconfig.host to their own Kconfig file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + Kconfig.host | 7 --- accel/Kconfig | 6 ++ 3 files changed, 7 insertions(+), 7 delet

[PATCH v9 05/10] Makefile: Remove dangerous EOL trailing backslash

One might get caught trying to understand unexpected Makefile behavior. Trailing backslash can help to split very long lines, but are rather dangerous when nothing follow. Preserve other developers debugging time by removing this one. Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis Review

[PATCH v9 04/10] configure: Generate rule to calculate the base architecture of a target

From: Alex Bennée As we encode the base architecture in configure.sh, we can emit the base-arch() function into config-host.mak. Signed-off-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/

[PATCH v9 10/10] accel/tcg: Add stub for probe_access()

From: Philippe Mathieu-Daudé The TCG helpers were added in b92e5a22ec3 in softmmu_template.h. probe_write() was added in there in 3b4afc9e75a to be moved out to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored as probe_access() in c25c283df0f. Since it is a TCG specific helper, add a s

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined

Patchew URL: https://patchew.org/QEMU/20200618121218.215808-1-ppan...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash exp

[PATCH v9 08/10] accel/Kconfig: Add the TCG selector

Expose the CONFIG_TCG selector to let minikconf.py uses it. When building with --disable-tcg build, this helps to deselect devices that are TCG-dependent. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + accel/Kconfig | 3 +

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

On 18/06/20 14:26, Philippe Mathieu-Daudé wrote: >> This is in principle a very good idea; however, util/qemu-timer.c does >> not use the scale to coalesce low-precision timers with nearby >> high-precision ones. > IOW this doesn't reduce the pressure, but simply makes the code easier? Easier, or

Re: [PATCH] docs: vhost-user: add Virtio status protocol feature

On 2020/6/18 下午7:29, Maxime Coquelin wrote: This patch specifies the VHOST_USER_SET_STATUS and VHOST_USER_GET_STATUS requests, which are sent by the master to update and query the Virtio status in the backend. Signed-off-by: Maxime Coquelin --- Changes since v1: = - Only keep

Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

On 13.06.20 22:07, Alexander Duyck wrote: > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > wrote: >> >> From: Alexander Duyck >> >> In an upcoming patch a feature named Free Page Reporting is about to be >> added. In order to avoid any confusion we should drop the use of the word >> 'report' w

Re: [PATCH v2 0/2] target/mips: Add two groups of loongson-ext instructions

在 2020/6/18 20:00, Aleksandar Markovic 写道: среда, 17. јун 2020., Jiaxun Yang > је написао/ла: 在 2020/6/16 22:41, Aleksandar Markovic 写道: уторак, 16. јун 2020., Jiaxun Yang mailto:jiaxun.y...@flygoat.com>

Re: [PATCH v3] arm/virt: Add memory hot remove support

Patchew URL: https://patchew.org/QEMU/20200618122129.7704-1-shameerali.kolothum.th...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined

P J P writes: > From: Prasad J Pandit > > When registering a MemoryRegionOps object, assert that its > read/write callback methods are defined. This avoids potential > guest crash via a NULL pointer dereference. > > Suggested-by: Peter Maydell > Signed-off-by: Prasad J Pandit > --- > memory

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

On 09.06.20 22:52, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Add class for bitmap extension and dump its fields. Further work is to > dump bitmap directory. > > Test new functionality inside 291 iotest. Unfortunately, it also breaks 291 with an external data file, which worked

Re: [PATCH v7 10/42] target/arm: Implement the ADDG, SUBG instructions

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Shift offset in translate; use extract32. > v6: Implement inline for !ATA. > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 2481561925..a18d71ad98 100644 > --- a/t

Re: [PATCH v7 11/42] target/arm: Implement the GMI instruction

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v6: Inline the operation. > --- > target/arm/translate-a64.c | 15 +++ > 1 file changed, 15 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

[PULL V2 00/33] Net patches

The following changes since commit 3f429a3400822141651486193d6af625eeab05a5: Merge remote-tracking branch 'remotes/kraxel/tags/microvm-20200617-pull-request' into staging (2020-06-18 11:23:15 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-

[PULL V2 01/33] virtio-net: implement RSS configuration command

From: Yuri Benditovich Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 167 +

[PULL V2 11/33] net: cadence_gem: Fix debug statements

From: Sai Pavan Boddu Enabling debug breaks the build, Fix them and make debug statements always compilable. Fix few statements to use sized integer casting. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 27 +---

[PULL V2 04/33] virtio-net: reference implementation of hash report

From: Yuri Benditovich Suggest VIRTIO_NET_F_HASH_REPORT if specified in device parameters. If the VIRTIO_NET_F_HASH_REPORT is set, the device extends configuration space. If the feature is negotiated, the packet layout is extended to accomodate the hash information. In this case deliver packet's

[PULL V2 06/33] virtio-net: add migration support for RSS and hash report

From: Yuri Benditovich Save and restore RSS/hash report configuration. Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 6

[PULL V2 03/33] tap: allow extended virtio header with hash info

From: Yuri Benditovich Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- net/tap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index 6207f61..ca48f2a 100644 --- a/net/tap.c +++ b/net/tap.c @@ -254,7 +254,8 @@ static void tap_set_vnet_

[PULL V2 07/33] virtio-net: align RSC fields with updated virtio-net header

From: Yuri Benditovich Removal of duplicated RSC definitions. Changing names of the fields to ones defined in the Linux header. Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 28 1 file changed, 4 insertions(+), 24 deletions(-)

[PULL V2 14/33] net: cadence_gem: Define access permission for interrupt registers

From: Sai Pavan Boddu Q1 to Q7 ISR's are clear-on-read, IER/IDR registers are write-only, mask reg are read-only. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PULL V2 02/33] virtio-net: implement RX RSS processing

From: Yuri Benditovich If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- hw/net/Makefile.objs | 1 + hw/net/virtio-net

[PULL V2 08/33] Fix tulip breakage

From: Helge Deller The tulip network driver in a qemu-system-hppa emulation is broken in the sense that bigger network packages aren't received any longer and thus even running e.g. "apt update" inside the VM fails. The breakage was introduced by commit 8ffb7265af ("check frame size and r/w data

[PULL V2 05/33] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

From: Yuri Benditovich Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is 16-bit field. Signed-off-by: Michael S. Tsirkin Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- include/migration/vmstate.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/mig

[PULL V2 15/33] net: cadence_gem: Set ISR according to queue in use

From: Sai Pavan Boddu Set ISR according to queue in use, added interrupt support for all queues. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-

[PULL V2 13/33] net: cadence_gem: Fix irq update w.r.t queue

From: Sai Pavan Boddu Set irq's specific to a queue, present implementation is setting q1 irq based on q0 status. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 25 +++-- 1 file changed, 3 insertions(+),

[PULL V2 18/33] net: cadence_gem: Add support for jumbo frames

From: Sai Pavan Boddu Add a property "jumbo-max-len", which sets default value of jumbo frames up to 16,383 bytes. Add Frame length checks for standard and jumbo frames. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c |

[PULL V2 17/33] net: cadence_gem: Fix up code style

From: Sai Pavan Boddu Fix the code style for register definitions. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 204 ++- 1 file changed, 103 insertions(+), 101 deletions(-)

[PULL V2 09/33] hw/net/tulip: Fix 'Descriptor Error' definition

From: Philippe Mathieu-Daudé Bit #14 is "DE" for 'Descriptor Error': When set, indicates a frame truncation caused by a frame that does not fit within the current descriptor buffers, and that the 21143 does not own the next descriptor. [Table 4-1. RDES0 Bit Fields Description] Signed-o

[PULL V2 19/33] net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg

From: Sai Pavan Boddu Advertise support of clear-on-read for ISR registers. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/caden

[PULL V2 22/33] net: cadence_gem: Fix RX address filtering

From: Tong Ho Two defects are fixed: 1/ Detection of multicast frames 2/ Treating drop of mis-addressed frames as non-error Signed-off-by: Tong Ho Signed-off-by: Edgar E. Iglesias Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_ge

[PULL V2 10/33] hw/net/tulip: Log descriptor overflows

From: Philippe Mathieu-Daudé Log with GUEST_ERROR what the guest is doing wrong. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- hw/net/tulip.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/net/tulip.c b/hw/net/tulip.c index 57ecbe2..4487fd6 100644 --- a/hw/

[PULL V2 21/33] net: cadence_gem: TX_LAST bit should be set by guest

From: Sai Pavan Boddu TX_LAST bit should not be set by hardware, its set by guest to inform the last bd of the frame. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 6 -- 1 file changed,

[PULL V2 31/33] hw/net/e1000e: Do not abort() on invalid PSRCTL register value

From: Philippe Mathieu-Daudé libFuzzer found using 'qemu-system-i386 -M q35': qemu: hardware error: e1000e: PSRCTL.BSIZE0 cannot be zero CPU #0: EAX= EBX= ECX= EDX=0663 ESI= EDI= EBP= ESP= EIP=fff0 EFL=0002 [---] CPL=0 II=0

[PULL V2 12/33] net: cadence_gem: Fix the queue address update during wrap around

From: Sai Pavan Boddu During wrap around and reset, queues are pointing to initial base address of queue 0, irrespective of what queue we are dealing with. Fix it by assigning proper base address every time. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wan

[PULL V2 24/33] net/colo-compare.c: Create event_bh with the right AioContext

From: Lukas Straub qemu_bh_new will set the bh to be executed in the main loop. This causes crashes as colo_compare_handle_event assumes that it has exclusive access the queues, which are also concurrently accessed in the iothread. Create the bh with the AioContext of the iothread to fulfill the

[PULL V2 25/33] chardev/char.c: Use qemu_co_sleep_ns if in coroutine

From: Lukas Straub To be able to convert compare_chr_send to a coroutine in the next commit, use qemu_co_sleep_ns if in coroutine. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Reviewed-by: Zhang Chen Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Zhang Chen Signed-off-by:

[PULL V2 26/33] net/colo-compare.c: Fix deadlock in compare_chr_send

From: Lukas Straub The chr_out chardev is connected to a filter-redirector running in the main loop. qemu_chr_fe_write_all might block here in compare_chr_send if the (socket-)buffer is full. If another filter-redirector in the main loop want's to send data to chr_pri_in it might also block if th

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

18.06.2020 16:13, Max Reitz wrote: On 09.06.20 22:52, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Add class for bitmap extension and dump its fields. Further work is to dump bitmap directory. Test new functionality inside 291 iotest. Unfortunately, it also breaks 291 with an extern

[PULL V2 16/33] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState

From: Sai Pavan Boddu Moving this buffers to CadenceGEMState, as their size will be increased more when JUMBO frames support is added. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 38 +--

[PULL V2 27/33] net/colo-compare.c: Only hexdump packets if tracing is enabled

From: Lukas Straub Else the log will be flooded if there is a lot of network traffic. Signed-off-by: Lukas Straub Reviewed-by: Zhang Chen Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 10 +

[PULL V2 28/33] net/colo-compare.c: Check that colo-compare is active

From: Lukas Straub If the colo-compare object is removed before failover and a checkpoint happens, qemu crashes because it tries to lock the destroyed event_mtx in colo_notify_compares_event. Fix this by checking if everything is initialized by introducing a new variable colo_compare_active whic

[PULL V2 20/33] net: cadence_gem: Update the reset value for interrupt mask register

From: Sai Pavan Boddu Mask all interrupt on reset. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 2211550..df6d818 100644 --

[PULL V2 32/33] net: Drop the legacy "name" parameter from the -net option

From: Thomas Huth It's been deprecated since QEMU v3.1, so it's time to finally remove it. The "id" parameter can simply be used instead. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- docs/system/deprecated.rst | 15 +-- net/net.c

[PULL V2 23/33] net: use peer when purging queue in qemu_flush_or_purge_queue_packets()

The sender of packet will be checked in the qemu_net_queue_purge() but we use NetClientState not its peer when trying to purge the incoming queue in qemu_flush_or_purge_packets(). This will trigger the assert in virtio_net_reset since we can't pass the sender check: hw/net/virtio-net.c:533: void v

[PULL V2 30/33] colo-compare: Fix memory leak in packet_enqueue()

From: Derek Su The patch is to fix the "pkt" memory leak in packet_enqueue(). The allocated "pkt" needs to be freed if the colo compare primary or secondary queue is too big. Replace the error_report of full queue with a trace event. Signed-off-by: Derek Su Reviewed-by: Zhang Chen Reviewed-by

[PULL V2 33/33] net: Drop the NetLegacy structure, always use Netdev instead

From: Thomas Huth Now that the "name" parameter is gone, there is hardly any difference between NetLegacy and Netdev anymore, so we can drop NetLegacy and always use Netdev to simplify the code quite a bit. The only two differences that were really left between Netdev and NetLegacy: 1) NetLegac

[PULL V2 29/33] net/colo-compare.c: Correct ordering in complete and finalize

From: Lukas Straub In colo_compare_complete, insert CompareState into net_compares only after everything has been initialized. In colo_compare_finalize, remove CompareState from net_compares before anything is deinitialized. Signed-off-by: Lukas Straub Reviewed-by: Zhang Chen Signed-off-by: Zh

Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig

Patchew URL: https://patchew.org/QEMU/20200618123342.10693-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v7 14/42] target/arm: Add helper_probe_access

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Raise an exception if the given virtual memory is not accessible. > > Signed-off-by: Richard Henderson > --- > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 0ee2ef403e..b032829194 100644 > --- a/target/arm/t

Re: [PATCH v9 2/5] generic vhost user server

Am 14.06.2020 um 20:39 hat Coiby Xu geschrieben: > Sharing QEMU devices via vhost-user protocol. > > Only one vhost-user client can connect to the server one time. > > Signed-off-by: Coiby Xu > --- > util/Makefile.objs | 1 + > util/vhost-user-server.c | 400

Re: [PATCH v7 13/42] target/arm: Define arm_cpu_do_unaligned_access for user-only

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > We need this to raise unaligned exceptions from user mode. > > Signed-off-by: Richard Henderson > --- > v6: Use EXCP_UNALIGNED for user-only and update cpu_loop.c. Could you update the comment in cpu.h, maybe something like: #define EXCP_

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined

On 18/06/20 15:12, Alex Bennée wrote: >> >> @@ -1495,6 +1495,9 @@ void memory_region_init_io(MemoryRegion *mr, >> const char *name, >> uint64_t size) >> { >> +assert(ops); >> +assert(ops->read); >> +assert(ops->write); > > If you

[PATCH v3] docs: vhost-user: add Virtio status protocol feature

This patch specifies the VHOST_USER_SET_STATUS and VHOST_USER_GET_STATUS requests, which are sent by the master to update and query the Virtio status in the backend. Signed-off-by: Maxime Coquelin --- Changes since v2: = - Typo: fix missing # (Jason) Changes since v1: ===

Re: [PATCH] docs: vhost-user: add Virtio status protocol feature

On 6/18/20 2:50 PM, Jason Wang wrote: > > On 2020/6/18 下午7:29, Maxime Coquelin wrote: >> This patch specifies the VHOST_USER_SET_STATUS and >> VHOST_USER_GET_STATUS requests, which are sent by >> the master to update and query the Virtio status >> in the backend. >> >> Signed-off-by: Maxime Coq

Re: [PATCH v9 3/5] move logical block size check function to a common utility function

Am 14.06.2020 um 20:39 hat Coiby Xu geschrieben: > Move logical block size check function in > hw/core/qdev-properties.c:set_blocksize() to util/block-helpers.c > > Signed-off-by: Coiby Xu Just a heads-up that you'll probably need to rebase this after the pull request I sent yesterday is merged

Re: [PATCH 72/78] 9p: Lock directory streams with a CoMutex

On Mittwoch, 17. Juni 2020 00:46:26 CEST Michael Roth wrote: > > > Indeed, for that particular stable branch I would see the following 9p > > > fixes as additional candidates (chronologically top down): > > > > > > 841b8d099c [trivial] 9pfs: local: Fix possible memory leak in > > > local_link() >

Re: [PATCH v7 15/42] target/arm: Implement LDG, STG, ST2G instructions

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Split out allocation_tag_mem. Handle atomicity of stores. > v3: Add X[t] input to these insns; require pre-cleaned addresses. > v5: Fix !32-byte aligned operation of st2g. > v6: Fix op2 extract

Re: [PULL V2 00/33] Net patches

Patchew URL: https://patchew.org/QEMU/1592486508-6135-1-git-send-email-jasow...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

Re: [PATCH v7 17/42] target/arm: Restrict the values of DCZID.BS under TCG

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > We can simplify our DC_ZVA if we recognize that the largest BS > that we actually use in system mode is 64. Let us just assert > that it fits within TARGET_PAGE_SIZE. > > For DC_GVA and STZGM, we want to be able to write whole bytes > of t

Re: [PATCH v7 18/42] target/arm: Simplify DC_ZVA

On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Now that we know that the operation is on a single page, > we need not loop over pages while probing. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-a64.c | 94 +++-- > 1 file changed, 2

Re: [PATCH v2 1/2] linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS

Le 16/06/2020 à 12:51, Filip Bozuta a écrit : > From: Filip Bozuta > > Socket ioctls SIOCGSTAMP and SIOCGSTAMPNS, used for timestamping the socket > connection, are defined in file "ioctls.h" differently from other ioctls. > The reason for this difference is explained in the comments above their

Re: [PATCH v3] docs: vhost-user: add Virtio status protocol feature

Patchew URL: https://patchew.org/QEMU/20200618134501.145747-1-maxime.coque...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined

On Thu, 18 Jun 2020 at 14:35, Paolo Bonzini wrote: > - tz_ppc_dummy_ops which is broken and should just use NULL ops Why is it broken? The intention is to create a MemoryRegion which asserts if it's ever used (because it is a QEMU bug if board code ever actually maps that MemoryRegion into anythi

Re: [PULL 00/43] Block layer patches

On Wed, 17 Jun 2020 at 15:49, Kevin Wolf wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the Git re

Re: [PATCH v3 06/17] block/io: support int64_t bytes in bdrv_aligned_pwritev()

On Thu 30 Apr 2020 01:10:22 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > W

Re: [PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

On Fri 22 May 2020 05:14:36 PM CEST, Eric Blake wrote: >> static int coroutine_fn bdrv_aligned_preadv(BdrvChild *child, >> -BdrvTrackedRequest *req, int64_t offset, unsigned int bytes, >> +BdrvTrackedRequest *req, int64_t offset, int64_t bytes, >> int64_t align, QEMUIOVector *qiov,

Re: [PATCH v4 1/6] linux-user: Extend strace support to enable argument printing after syscall execution

Le 16/06/2020 à 12:39, Filip Bozuta a écrit : > From: Filip Bozuta > > Structure "struct syscallname" in file "strace.c" is used for "-strace" > to print arguments and return values of syscalls. The last field of > this structure "result" represents the calling function that prints th

Re: [PATCH v4 6/6] linux-user: Add strace support for printing arguments of fallocate()

Le 16/06/2020 à 12:39, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements strace argument printing functionality for following > syscall: > > *fallocate - manipulate file space > > int fallocate(int fd, int mode, off_t offset, off_t len) > man page: https

Re: [PATCH v4 3/6] linux-user: Add strace support for printing argument of syscalls used for extended attributes

Le 16/06/2020 à 12:39, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements strace argument printing functionality for following > syscalls: > > *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value > > ssize_t getxattr(const char *path, const char

Re: [PATCH v3] arm/virt: Add memory hot remove support

Hi Shameer, On 6/18/20 2:21 PM, Shameer Kolothum wrote: > This adds support for memory(pc-dimm) hot remove on arm/virt that > uses acpi ged device. > > NVDIMM hot removal is not yet supported. > > Signed-off-by: Shameer Kolothum > --- > V2 --> v3 > -Addressed Eric's review comment and added c

Re: [PATCH v2 2/2] linux-user: Add strace support for printing arguments of ioctl()

Le 16/06/2020 à 12:51, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements functionality for strace argument printing for ioctls. > When running ioctls through qemu with "-strace", they get printed in format: > > "ioctl(fd_num,0x*,0x*) = ret_value" > > where the request co

  1   2   3   4   >