Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

2020-06-15 Thread Paolo Bonzini
On 15/06/20 07:17, Thomas Huth wrote: > That depends ... Marc-André, Paolo, what's the status of the meson patch > series? Do you think it will be merged for the next release already? If > so, it does not make much sense to respin my distclean patch. Otherwise > I could do another iteration... I p

Re: [PATCH] qga: fix assert regression on guest-shutdown

2020-06-15 Thread Christian Ehrhardt
On Tue, Jun 9, 2020 at 1:15 PM Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Thu, Jun 4, 2020 at 3:43 PM Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > >> >> >> On Thu, Jun 4, 2020 at 11:46 AM Marc-André Lureau < >> marcandre.lur...@redhat.com> wrote: >>

[PATCH] hw/scsi/megasas: Fix possible out-of-bounds array access in tracepoints

2020-06-15 Thread Thomas Huth
Some tracepoints in megasas.c use a guest-controlled value as an index into the mfi_frame_desc[] array. Thus a malicious guest could cause an out-of-bounds error here. Fortunately, the impact is very low since this can only happen when the corresponding tracepoints have been enabled before, but the

Re: [PATCH v2] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Thomas Huth
On 15/06/2020 08.57, Philippe Mathieu-Daudé wrote: > The git-submodule.sh script is called by make and initialize the > submodules listed in the GIT_SUBMODULES variable generated by > ./configure. > > Add SLOF when we build the ppc64-softmmu target for the pSeries > machines (which use SLOF). This

Re: [PATCH v8 00/10] accel: Allow targets to use Kconfig

2020-06-15 Thread Philippe Mathieu-Daudé
Hi Paolo, FYI this series applies cleanly on current master (7d3660e798 merging your for-upstream 3575b0aea9). On 6/8/20 6:38 PM, Philippe Mathieu-Daudé wrote: > Missing review: > - 03/10 MAINTAINERS: Cover the HAX accelerator stub > - 04/10 configure: Generate rule to calculate base arch of targ

Re: [PATCH] linux-user: mremap fails with EFAULT if address range overlaps with stack guard

2020-06-15 Thread Tobias Koch
Hi Laurent, the code in musl libc probing the stack is in     https://git.musl-libc.org/cgit/musl/plain/src/thread/pthread_getattr_np.c The setup in elfload.c does work, but only when reserved_va is not set. In that case, any stack guard violation is handled by the host kernel and thus results

Re: [PATCH v3 00/11] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/5/20 12:22 PM, Philippe Mathieu-Daudé wrote: > Patches 2 & 3 fix CVE-2020-13253. Ping for the CVE fix?... > The rest are (accumulated) cleanups. > > Supersedes: <20200604182502.24228-1-f4...@amsat.org> > > Philippe Mathieu-Daudé (11): > MAINTAINERS: Cc qemu-block mailing list > hw/sd/s

Re: [PATCH] hw/scsi/megasas: Fix possible out-of-bounds array access in tracepoints

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 9:26 AM, Thomas Huth wrote: > Some tracepoints in megasas.c use a guest-controlled value as an index > into the mfi_frame_desc[] array. Thus a malicious guest could cause an > out-of-bounds error here. Fortunately, the impact is very low since this > can only happen when the correspondin

Re: [PATCH 1/4] migration/savevm: respect qemu_fclose() error code in save_snapshot()

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 20:11, Denis V. Lunev wrote: qemu_fclose() could return error, f.e. if bdrv_co_flush() will return the error. This validation will become more important once we will start waiting of asynchronous IO operations, started from bdrv_write_vmstate(), which are coming soon. Signed-off-by:

[Bug 1883414] Re: Cannot build qemu-5.0.0 from tarball

2020-06-15 Thread Thomas Huth
Where did you download the tarball from? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883414 Title: Cannot build qemu-5.0.0 from tarball Sta

Re: [PATCH v2] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 9:31 AM, Thomas Huth wrote: > On 15/06/2020 08.57, Philippe Mathieu-Daudé wrote: >> The git-submodule.sh script is called by make and initialize the >> submodules listed in the GIT_SUBMODULES variable generated by >> ./configure. >> >> Add SLOF when we build the ppc64-softmmu target for

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

2020-06-15 Thread Thomas Huth
On 15/06/2020 09.13, Paolo Bonzini wrote: > On 15/06/20 07:17, Thomas Huth wrote: >> That depends ... Marc-André, Paolo, what's the status of the meson patch >> series? Do you think it will be merged for the next release already? If >> so, it does not make much sense to respin my distclean patch. O

Re: [PATCH v2] hmp: Make json format optional for qom-set

2020-06-15 Thread David Hildenbrand
On 15.06.20 08:17, Markus Armbruster wrote: > David Hildenbrand writes: > >> Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json >> parser, making it possible to specify complex types. However, with this >> change it is no longer possible to specify proper sizes (e.g., 2G, 128M), >

Re: [PATCH 2/4] block/aio_task: allow start/wait task from any coroutine

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 20:11, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes clearer, interface more obvious. Signed-off-by: Vladimi

[PATCH v3] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Philippe Mathieu-Daudé
The git-submodule.sh script is called by make and initialize the submodules listed in the GIT_SUBMODULES variable generated by ./configure. SLOF is required for building the s390-ccw firmware on s390x, since it is using the libnet code from SLOF for network booting. Add it to the GIT_SUBMODULES w

Re: [PATCH 3/4] block, migration: add bdrv_flush_vmstate helper

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 20:11, Denis V. Lunev wrote: Right now bdrv_fclose() is just calling bdrv_flush(). The problem is that migration code is working inefficently from black layer terms and are frequently called for very small pieces of not properly aligned data. Block layer is capable to work this way, b

Re: [PATCH v2 1/2] qemu-options.hx: Mark all hmat-cache attributes required

2020-06-15 Thread Markus Armbruster
Cc: the people involved in commit c412a48d4d "numa: Extend CLI to provide memory side cache information". Michal Privoznik writes: > The documentation to `-numa hmat-cache` says that @node-id, @size > and @level are the only required attributes. The rest > (@associativity, @policy and @line) is

Re: [PATCH v2 2/2] qemu-options.hx: Document hmat-lb and hmat-cache order

2020-06-15 Thread Markus Armbruster
Michal Privoznik writes: > To simplify internal implementation the hmat-cache parsing code > expects hmat-lb to be already parsed. This means, that hmat-lb > arguments must come before hmat-cache. Document this restriction > so that management applications can follow it. > > Signed-off-by: Michal

Re: [PATCH v3] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Thomas Huth
On 15/06/2020 09.49, Philippe Mathieu-Daudé wrote: > The git-submodule.sh script is called by make and initialize the > submodules listed in the GIT_SUBMODULES variable generated by > ./configure. > > SLOF is required for building the s390-ccw firmware on s390x, since > it is using the libnet code

Re: [PATCH v3] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 10:13 AM, Thomas Huth wrote: > On 15/06/2020 09.49, Philippe Mathieu-Daudé wrote: >> The git-submodule.sh script is called by make and initialize the >> submodules listed in the GIT_SUBMODULES variable generated by >> ./configure. >> >> SLOF is required for building the s390-ccw firmware

[Bug 1883414] Re: Cannot build qemu-5.0.0 from tarball

2020-06-15 Thread Uri Simchoni
I just tried it again it didn't reproduce - all files were there. I don't have the original tarball that caused me to open this bug, as I just moved to git clone and continued with that. Appologies and please close this bug. ** Changed in: qemu Status: Incomplete => Invalid -- You receiv

Re: [PATCH v8 0/4] vhost-user block device backend implementation

2020-06-15 Thread Stefano Garzarella
On Mon, Jun 15, 2020 at 02:46:40AM +0800, Coiby Xu wrote: > Hi Stefano Garzarella, > > On Thu, Jun 11, 2020 at 02:37:03PM +0200, Stefano Garzarella wrote: > > Hi Coiby Xu, > > > > On Fri, Jun 05, 2020 at 07:35:34AM +0800, Coiby Xu wrote: > > > v8 > > > - re-try connecting to socket server to fix

RE: [PATCH 1/2] migration/colo: fix typo in the COLO Framework module

2020-06-15 Thread Zhanghailiang
Reviewed-by: zhanghailiang > -Original Message- > From: Like Xu [mailto:like...@linux.intel.com] > Sent: Sunday, June 14, 2020 4:45 PM > To: qemu-devel@nongnu.org > Cc: Like Xu ; Zhanghailiang > > Subject: [PATCH 1/2] migration/colo: fix typo in the COLO Framework > module > > Cc: Hail

Re: [PATCH for-5.1 V4 1/4] hw/mips: Implement the kvm_type() hook in MachineClass

2020-06-15 Thread Thomas Huth
On 15/06/2020 02.52, Huacai Chen wrote: > Hi, Aleksandar, > > On Sun, Jun 14, 2020 at 4:07 PM Aleksandar Markovic > wrote: >> >> >> >> уто, 2. јун 2020. у 04:38 Huacai Chen је написао/ла: >>> >>> MIPS has two types of KVM: TE & VZ, and TE is the default type. Now we >>> can't create a VZ guest i

Re: [PATCH 0/6] Add several Power ISA 3.1 32/64-bit vector instructions

2020-06-15 Thread David Gibson
On Fri, Jun 12, 2020 at 09:47:58PM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200613042029.22321-1-...@linux.ibm.com/ I will need you to fix these stype errors and repost. > > > > Hi, > > This series seems to have some coding style problems. See output belo

Re: [PATCH] target/mips: Fix PageMask with variable page size

2020-06-15 Thread Peter Maydell
On Sun, 14 Jun 2020 at 22:52, Aleksandar Markovic wrote: > When you change machine.c the way you did it, you need to bump the version. > Please see git log on machine.c for details. >> --- a/target/mips/cpu.h >> +++ b/target/mips/cpu.h >> @@ -617,7 +617,8 @@ struct CPUMIPSState { >> /* >> * C

Re: [PATCH] target/mips: Fix PageMask with variable page size

2020-06-15 Thread Jiaxun Yang
在 2020/6/15 17:13, Peter Maydell 写道: On Sun, 14 Jun 2020 at 22:52, Aleksandar Markovic wrote: When you change machine.c the way you did it, you need to bump the version. Please see git log on machine.c for details. --- a/target/mips/cpu.h +++ b/target/mips/cpu.h @@ -617,7 +617,8 @@ struc

Re: [PATCH v3] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Daniel P . Berrangé
On Mon, Jun 15, 2020 at 09:49:19AM +0200, Philippe Mathieu-Daudé wrote: > The git-submodule.sh script is called by make and initialize the > submodules listed in the GIT_SUBMODULES variable generated by > ./configure. > > SLOF is required for building the s390-ccw firmware on s390x, since > it is

Re: [PATCH v3 4/4] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-06-15 Thread Greg Kurz
On Sat, 13 Jun 2020 17:18:04 +1000 David Gibson wrote: > On Thu, Jun 11, 2020 at 03:40:33PM +0200, Greg Kurz wrote: > > Nested KVM-HV only works on POWER9. > > > > Signed-off-by: Greg Kurz > > Reviewed-by: Laurent Vivier > > Hrm. I have mixed feelings about this. It does bring forward an >

Re: [PATCH] target/mips: Fix PageMask with variable page size

2020-06-15 Thread Peter Maydell
On Mon, 15 Jun 2020 at 10:17, Jiaxun Yang wrote: > > > > 在 2020/6/15 17:13, Peter Maydell 写道: > > On Sun, 14 Jun 2020 at 22:52, Aleksandar Markovic > > wrote: > >> When you change machine.c the way you did it, you need to bump the > >> version. Please see git log on machine.c for details. > > >

Re: [PATCH 4/4] block/io: improve savevm performance

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 20:11, Denis V. Lunev wrote: This patch does 2 standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to block driver, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. Thus bdrv_vmstate_write() is

Re: [PATCH 1/2] linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS

2020-06-15 Thread Laurent Vivier
Le 12/06/2020 à 18:40, Filip Bozuta a écrit : > From: Filip Bozuta > > Socket ioctls SIOCGSTAMP and SIOCGSTAMPNS, used for timestamping the socket > connection, are defined in file "ioctls.h" differently from other ioctls. > The reason for this difference is explained in the comments above their

KVM call for 2016-06-16

2020-06-15 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. There is already a topic from last call: Last minute suggestion after recent IRC chat with Alex Bennée and Thomas Huth: "Move some of the build/CI infrastructure to GitLab." Pro/Con? - GitLab does not offer s390x/ppc64el => keep

Re: [PATCH 2/4] block/aio_task: allow start/wait task from any coroutine

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
15.06.2020 10:47, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 20:11, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes c

Re: [PATCH v2] hmp: Make json format optional for qom-set

2020-06-15 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > David Hildenbrand writes: > > > Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json > > parser, making it possible to specify complex types. However, with this > > change it is no longer possible to specify proper sizes (e.g., 2G, 12

Re: [PATCH v7 0/9] iotests: Dump QCOW2 dirty bitmaps metadata

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
12.06.2020 03:04, Andrey Shinkevich wrote: Note: based on the Vladimir's series [v5 00/13] iotests: Dump QCOW2 dirty bitmaps metadata It's merged to master, so, based on master. (except for 01, which is not needed, thanks to Eric) Add dirty bitmap information to QCOW2 metadata dump i

Re: [PATCH v7 1/9] iotests: Fix for magic hexadecimal output in 291

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
12.06.2020 03:04, Andrey Shinkevich wrote: This issue was introduced in the earlier patch: "qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct". Signed-off-by: Andrey Shinkevich This change was squashed to original commit --- tests/qemu-iotests/291.out | 10 +-

Re: [PATCH v3] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Thomas Huth
On 15/06/2020 11.19, Daniel P. Berrangé wrote: > On Mon, Jun 15, 2020 at 09:49:19AM +0200, Philippe Mathieu-Daudé wrote: >> The git-submodule.sh script is called by make and initialize the >> submodules listed in the GIT_SUBMODULES variable generated by >> ./configure. >> >> SLOF is required for bu

Re: KVM call for 2016-06-16

2020-06-15 Thread Philippe Mathieu-Daudé
Hi Juan, On 6/15/20 11:34 AM, Juan Quintela wrote: > > Hi > > Please, send any topic that you are interested in covering. > There is already a topic from last call: This topic was already discussed in the last call :) > > Last minute suggestion after recent IRC chat with Alex Bennée and > Tho

Re: [PATCH v7 2/9] qcow2: Fix capitalization of header extension constant.

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
12.06.2020 03:04, Andrey Shinkevich wrote: Make the capitalization of the hexadecimal numbers consistent for the QCOW2 header extension constants in docs/interop/qcow2.txt. Suggested-by: Eric Blake Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, V

Re: [PATCH v7 3/9] qcow2_format.py: make printable data an extension class member

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
12.06.2020 03:04, Andrey Shinkevich wrote: Let us differ binary data type from string one for the extension data variable and keep the string as the QcowHeaderExtension class member. Keep my r-b, but I just want to note, that I missed, what is the actual aim of this change.. Signed-off-by:

Re: [PATCH v3] configure: Let SLOF be initialized by ./scripts/git-submodule.sh

2020-06-15 Thread Thomas Huth
On 15/06/2020 10.28, Philippe Mathieu-Daudé wrote: > On 6/15/20 10:13 AM, Thomas Huth wrote: >> On 15/06/2020 09.49, Philippe Mathieu-Daudé wrote: >>> The git-submodule.sh script is called by make and initialize the >>> submodules listed in the GIT_SUBMODULES variable generated by >>> ./configure.

[RFC PATCH] docs/devel: convert and update MTTCG design document

2020-06-15 Thread Alex Bennée
Do a light conversion to .rst and clean-up some of the language at the start now MTTCG has been merged for a while. Signed-off-by: Alex Bennée --- docs/devel/index.rst | 1 + ...ti-thread-tcg.txt => multi-thread-tcg.rst} | 52 --- 2 files changed, 34 ins

[PATCH v1 1/2] semihosting: defer connect_chardevs a little more to use serialx

2020-06-15 Thread konrad
From: KONRAD Frederic With that we can just use chardev=serial0. Signed-off-by: KONRAD Frederic --- softmmu/vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index f669c06..9b8b48a 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -4123,8 +

[PATCH v1 2/2] semihosting: don't send the trailing '\0'

2020-06-15 Thread konrad
From: KONRAD Frederic Don't send the trailing 0 from the string. Signed-off-by: KONRAD Frederic --- hw/semihosting/console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 22e7827..9b4fee9 100644 --- a/hw/semihos

Re: [PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test

2020-06-15 Thread Philippe Mathieu-Daudé
On Fri, Jun 12, 2020 at 5:00 PM Michael S. Tsirkin wrote: > > From: Eric Auger > > Test tables specific to the TPM-TIS instantiation. > The TPM2 is added in the framework. Also the DSDT > is updated with the TPM. The new function should be > be usable for CRB as well, later one. > > Signed-off-by

Re: [PATCH v1 2/2] semihosting: don't send the trailing '\0'

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 12:00 PM, kon...@adacore.com wrote: > From: KONRAD Frederic > > Don't send the trailing 0 from the string. > Fixes: a331c6d7741 Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: KONRAD Frederic > --- > hw/semihosting/console.c | 4 +++- > 1 file changed, 3 insertions(+), 1 del

Re: [PULL 082/116] target/i386: correct fix for pcmpxstrx substring search

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/12/20 6:07 PM, Paolo Bonzini wrote: > From: Joseph Myers > > This corrects a bug introduced in my previous fix for SSE4.2 pcmpestri > / pcmpestrm / pcmpistri / pcmpistrm substring search, commit > ae35eea7e4a9f21dd147406dfbcd0c4c6aaf2a60. > > That commit fixed a bug that showed up in four G

RE: [PATCH RFC 00/22] Support of Virtual CPU Hotplug for ARMv8 Arch

2020-06-15 Thread Salil Mehta
Hi Marc, Thanks for the review. > From: Marc Zyngier [mailto:m...@kernel.org] > Sent: Sunday, June 14, 2020 12:55 PM > > Hi Salil, > > On 2020-06-13 22:36, Salil Mehta wrote: > > This patch-set introduces the virtual cpu hotplug support for ARMv8 > > architecture in QEMU. Idea is to be able to h

Re: [PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test

2020-06-15 Thread Thomas Huth
On 15/06/2020 12.02, Philippe Mathieu-Daudé wrote: > On Fri, Jun 12, 2020 at 5:00 PM Michael S. Tsirkin wrote: >> >> From: Eric Auger >> >> Test tables specific to the TPM-TIS instantiation. >> The TPM2 is added in the framework. Also the DSDT >> is updated with the TPM. The new function should b

Re: KVM call for 2016-06-16

2020-06-15 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Hi Juan, > > On 6/15/20 11:34 AM, Juan Quintela wrote: >> >> Hi >> >> Please, send any topic that you are interested in covering. >> There is already a topic from last call: > > This topic was already discussed in the last call :) Sorry. My understanding from la

Re: [PATCH v8 00/14] target/mips: MSA, FPU and other cleanups and improvements

2020-06-15 Thread Aleksandar Rikalo
This series contains some patches that split heprers in msa_helper.c. It will make easier for debugging tools to display involved source code, and also introduces some modest performance improvements gains for all involved MSA instructions. v7->v8: - added six new demacroing patches v6->v

Re: [PATCH v7 4/9] qcow2_format.py: Dump bitmap directory information

2020-06-15 Thread Vladimir Sementsov-Ogievskiy
12.06.2020 03:04, Andrey Shinkevich wrote: Read and dump entries from the bitmap directory of QCOW2 image. It extends the output in the test case #291. Header extension: magic 0x23852875 (Bitmaps) ... Bitmap name bitmap-1 flag auto table siz

[PATCH v9 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface

2020-06-15 Thread Philippe Mathieu-Daudé
The FW_CFG_DATA_GENERATOR allows any object to produce blob of data consumable by the fw_cfg device. Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- docs/specs/fw_cfg.txt | 9 ++- include/hw/nvram/fw_cfg.h | 52 +++ hw/nvram/fw_cf

[PATCH v9 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

2020-06-15 Thread Philippe Mathieu-Daudé
Hi, This series has two parts: - First we add the ability to QOM objects to produce data consumable by the fw_cfg device, - Then we add the tls-cipher-suites object, and let it implement the FW_CFG_DATA_GENERATOR interface. This is required by EDK2 'HTTPS Boot' feature [*] to tell the guest

[PATCH v9 4/5] crypto: Add tls-cipher-suites object

2020-06-15 Thread Philippe Mathieu-Daudé
On the host OS, various aspects of TLS operation are configurable. In particular it is possible for the sysadmin to control the TLS cipher/protocol algorithms that applications are permitted to use. * Any given crypto library has a built-in default priority list defined by the distro maintainer

[PULL 1/5] crypto: add "none" random provider

2020-06-15 Thread Daniel P . Berrangé
From: Marek Marczykowski-Górecki In case of not using random-number needing feature, it makes sense to skip RNG init too. This is especially helpful when QEMU is sandboxed in Stubdomain under Xen, where there is very little entropy so initial getrandom() call delays the startup several seconds. I

[PATCH v9 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-06-15 Thread Philippe Mathieu-Daudé
Since our format is consumable by the fw_cfg device, we can implement the FW_CFG_DATA_GENERATOR interface. Acked-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- v9: Fixed typos in qemu-options.hx (lersek) --- crypto/tls-cipher-suites.c | 19 +++ qemu-options.hx

[PATCH v9 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-15 Thread Philippe Mathieu-Daudé
The 'gen_id' argument refers to a QOM object able to produce data consumable by the fw_cfg device. The producer object must implement the FW_CFG_DATA_GENERATOR interface. Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- softmmu/vl.c | 25 + 1 file chan

[PATCH v9 3/5] softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace

2020-06-15 Thread Philippe Mathieu-Daudé
Names of user-provided fw_cfg items are supposed to start with "opt/". However FW_CFG_DATA_GENERATOR items are generated by QEMU, so allow the "etc/" namespace in this specific case. Reviewed-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daudé --- docs/specs/fw_cfg.txt | 4 softmmu/vl.c

[PULL v2 0/5] Qcrypto next patches

2020-06-15 Thread Daniel P . Berrangé
The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into stagi= ng (2020-06-12 23:06:22 +0100) are available in the Git repository at: https://github.com/berrange/qemu tags/qcrypto-next-pull-request fo

[PULL 5/5] crypto: Remove use of GCRYPT_VERSION macro.

2020-06-15 Thread Daniel P . Berrangé
From: "Richard W.M. Jones" According to the gcrypt documentation it's intended that gcry_check_version() is called with the minimum version of gcrypt needed by the program, not the version from the header file that happened to be installed when qemu was compiled. Indeed the gcrypt.h header says

[PULL 4/5] test-crypto-secret: add 'secret_keyring' object tests.

2020-06-15 Thread Daniel P . Berrangé
From: Alexey Krasikov Add tests: test_secret_keyring_good; test_secret_keyring_revoked_key; test_secret_keyring_expired_key; test_secret_keyring_bad_serial_key; test_secret_keyring_bad_key_access_right; Added tests require libkeyutils. The absence of this library is not critical, becau

[PULL 2/5] crypto/secret: move main logic from 'secret' to 'secret_common'.

2020-06-15 Thread Daniel P . Berrangé
From: Alexey Krasikov Create base class 'common secret'. Move common data and logic from 'secret' to 'common_secret' class. This allowed adding abstraction layer for easier adding new 'secret' objects in future. Convert 'secret' class to child from basic 'secret_common' with 'data' and 'file' pro

[PULL 3/5] crypto/linux_keyring: add 'secret_keyring' secret object.

2020-06-15 Thread Daniel P . Berrangé
From: Alexey Krasikov Add the ability for the secret object to obtain secret data from the Linux in-kernel key managment and retention facility, as an extra option to the existing ones: reading from a file or passing directly as a string. The secret is identified by the key serial number. The up

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-06-15 Thread Stefan Hajnoczi
On Tue, Jun 09, 2020 at 11:25:41PM -0700, John G Johnson wrote: > > On Jun 2, 2020, at 8:06 AM, Alex Williamson > > wrote: > > > > On Wed, 20 May 2020 17:45:13 -0700 > > John G Johnson wrote: > > > >>> I'm confused by VFIO_USER_ADD_MEMORY_REGION vs VFIO_USER_IOMMU_MAP_DMA. > >>> The former see

Re: [RFC PATCH v2 1/5] hw/misc: Add a LED device

2020-06-15 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > A LED device can be connected to a GPIO output. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/misc/led.h | 30 > hw/misc/led.c | 84 +++ > MAINTAINERS |

Re: [PULL 082/116] target/i386: correct fix for pcmpxstrx substring search

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 12:18 PM, Philippe Mathieu-Daudé wrote: > On 6/12/20 6:07 PM, Paolo Bonzini wrote: >> From: Joseph Myers >> >> This corrects a bug introduced in my previous fix for SSE4.2 pcmpestri >> / pcmpestrm / pcmpistri / pcmpistrm substring search, commit >> ae35eea7e4a9f21dd147406dfbcd0c4c6aaf2a

Re: [PATCH] hw/timer/a9gtimer: Clear pending interrupt, after the clear of Event flag

2020-06-15 Thread Peter Maydell
On Wed, 10 Jun 2020 at 09:47, Vaclav Vanc wrote: > > A9 Global Timer is used with Edge triggered interrupts (This is true > at least for Zynq and i.MX6 processors). > When Event Flag is cleared in Interrupt Status Register and new interrupt > was supposed to be scheduled, interrupt request is neve

Re: [PATCH v2] hw/misc/imx6ul_ccm: Implement non writable bits in CCM registers

2020-06-15 Thread Peter Maydell
On Mon, 8 Jun 2020 at 14:35, Jean-Christophe Dubois wrote: > > Some bits of the CCM registers are non writable. > > This was left undone in the initial commit (all bits of registers were > writable). > > This patch adds the required code to protect the non writable bits. > > Signed-off-by: Jean-C

Re: [RFC PATCH v2 1/5] hw/misc: Add a LED device

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 12:55 PM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: >> A LED device can be connected to a GPIO output. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/misc/led.h | 30 >> hw/misc/led.c | 84

Re: [PATCH v2] Implement configurable descriptor size in ftgmac100

2020-06-15 Thread Peter Maydell
On Sat, 6 Jun 2020 at 10:03, Erik Smit wrote: > > The hardware supports configurable descriptor sizes, configured in the DBLAC > register. > > Most drivers use the default 4 word descriptor, which is currently hardcoded, > but Aspeed SDK configures 8 words to store extra data. Hi; I've applied th

Re: [PATCH v3 1/6] linux-user: Extend strace support to enable argument printing after syscall execution

2020-06-15 Thread Laurent Vivier
Le 11/06/2020 à 17:51, Filip Bozuta a écrit : > From: Filip Bozuta > > Structure "struct syscallname" in file "strace.c" is used for "-strace" > to print arguments and return values of syscalls. The last field of > this structure "result" represents the calling function that prints th

Re: [PATCH v7 07/13] hw/386: Add EPYC mode topology decoding functions

2020-06-15 Thread Dr. David Alan Gilbert
* Babu Moger (babu.mo...@amd.com) wrote: > > > > -Original Message- > > From: Eduardo Habkost > > Sent: Wednesday, June 3, 2020 10:46 AM > > To: Moger, Babu > > Cc: marcel.apfelb...@gmail.com; pbonz...@redhat.com; r...@twiddle.net; > > m...@redhat.com; imamm...@redhat.com; qemu-devel@no

Re: [RFC PATCH v2 1/5] hw/misc: Add a LED device

2020-06-15 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > On 6/15/20 12:55 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > >> A LED device can be connected to a GPIO output. > >> > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >> include/hw/misc/le

[Bug 1882784] Re: Legacy IGD passthrough in QEMU 5 disabled

2020-06-15 Thread Thomas Huth
Patch has been included: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=643a4eacef87a318c ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

RE: [PATCH] migration: Count new_dirty instead of real_dirty

2020-06-15 Thread Zhoujian (jay)
Hi Keqian, > -Original Message- > From: zhukeqian > Sent: Monday, June 15, 2020 11:19 AM > To: qemu-devel@nongnu.org; qemu-...@nongnu.org; Paolo Bonzini > ; Zhoujian (jay) > Cc: Juan Quintela ; Chao Fan ; > Wanghaibin (D) > Subject: Re: [PATCH] migration: Count new_dirty instead of real_

Re: [PATCH v3 3/6] linux-user: Add strace support for printing argument of syscalls used for extended attributes

2020-06-15 Thread Laurent Vivier
Le 11/06/2020 à 17:51, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements strace argument printing functionality for following > syscalls: > > *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value > > ssize_t getxattr(const char *path, const char

Re: [PATCH v3 6/6] linux-user: Add strace support for printing arguments of fallocate()

2020-06-15 Thread Laurent Vivier
Le 11/06/2020 à 17:51, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements strace argument printing functionality for following > syscall: > > *fallocate - manipulate file space > > int fallocate(int fd, int mode, off_t offset, off_t len) > man page: https

Re: [PATCH 1/4] migration/savevm: respect qemu_fclose() error code in save_snapshot()

2020-06-15 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > qemu_fclose() could return error, f.e. if bdrv_co_flush() will return > the error. > > This validation will become more important once we will start waiting of > asynchronous IO operations, started from bdrv_write_vmstate(), which are > coming soon. > >

Re: [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy

2020-06-15 Thread Thomas Huth
On 18/05/2020 20.01, Thomas Huth wrote: > Since commit b4983c570c7a ("net: Remove deprecated [hub_id name] tuple of > 'hostfwd_add' / 'hostfwd_remove'"), the "name" parameter is not used > internally anymore. And it's been marked as deprecated since QEMU v3.1, > so it is time to remove the "name" p

[PATCH] kvm: i386: allow TSC to differ by NTP correction bounds without TSC scaling

2020-06-15 Thread Marcelo Tosatti
The Linux TSC calibration procedure is subject to small variations (its common to see +-1 kHz difference between reboots on a given CPU, for example). So migrating a guest between two hosts with identical processor can fail, in case of a small variation in calibrated TSC between them. Allow

Re: [PATCH v3] target/arm/cpu: adjust virtual time for arm cpu

2020-06-15 Thread Peter Maydell
On Mon, 8 Jun 2020 at 13:12, Ying Fang wrote: > > From: fangying > > Virtual time adjustment was implemented for virt-5.0 machine type, > but the cpu property was enabled only for host-passthrough and > max cpu model. Let's add it for arm cpu which has the generic timer > feature enabled. > > Sug

Re: [PATCH v3 0/4] block: seriously improve savevm performance

2020-06-15 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > This series do standard basic things: > - it creates intermediate buffer for all writes from QEMU migration code > to QCOW2 image, > - this buffer is sent to disk asynchronously, allowing several writes to > run in parallel. > > In general, migration

Re: [PATCH v5 2/3] hw/net/imx_fec: Allow phy not to be the first device on the mii bus.

2020-06-15 Thread Peter Maydell
On Thu, 4 Jun 2020 at 13:39, Jean-Christophe Dubois wrote: > > Up to now we were allowing only one PHY device and it had to be the > first device on the bus. > > The i.MX6UL has 2 Ethernet devices and can therefore have several > PHY devices on the bus (and not necessarilly as device 0). > > This

Re: [PATCH 2/2] linux-user: Add strace support for printing arguments of ioctl()

2020-06-15 Thread Laurent Vivier
Le 12/06/2020 à 18:40, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements functionality for strace argument printing for ioctls. > When running ioctls through qemu with "-strace", they get printed in format: > > "ioctl(fd_num,0x*,0x*) = ret_value" > > where the request co

Re: [PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test

2020-06-15 Thread Auger Eric
Hi Philippe, Thomas, On 6/15/20 12:22 PM, Thomas Huth wrote: > On 15/06/2020 12.02, Philippe Mathieu-Daudé wrote: >> On Fri, Jun 12, 2020 at 5:00 PM Michael S. Tsirkin wrote: >>> >>> From: Eric Auger >>> >>> Test tables specific to the TPM-TIS instantiation. >>> The TPM2 is added in the framewor

[PATCH 3/3] acpi: Enable TPM IRQ

2020-06-15 Thread Stefan Berger
From: Stefan Berger Move the TPM TIS IRQ to unused IRQ 13, which is also accepted by Windows. Query for the TPM's irq number and enable the TPM IRQ if not zero. Signed-off-by: Stefan Berger CC: Michael S. Tsirkin --- hw/i386/acpi-build.c | 11 +-- include/hw/acpi/tpm.h | 2 +- 2 fil

[PATCH 1/3] tpm_tis: Allow lowering of IRQ also when locality is not active

2020-06-15 Thread Stefan Berger
From: Stefan Berger This patch fixes a bug that occurs when using interrupts. It allows to lower the IRQ also when a locality is not active. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis_common.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_

Re: [PATCH v3 0/4] block: seriously improve savevm performance

2020-06-15 Thread Denis V. Lunev
On 6/15/20 3:17 PM, Dr. David Alan Gilbert wrote: > * Denis V. Lunev (d...@openvz.org) wrote: >> This series do standard basic things: >> - it creates intermediate buffer for all writes from QEMU migration code >> to QCOW2 image, >> - this buffer is sent to disk asynchronously, allowing several w

[PATCH 0/3] tpm: Enable usage of TPM TIS with interrupts

2020-06-15 Thread Stefan Berger
This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is also accepted by Windows. Stefan Stefan Berger (3): tpm_tis: Allow lowering of IRQ also when locality is not active tpm: Extend TPMIfClass with get_irqnum() function acpi: Enable

[PATCH 2/3] tpm: Extend TPMIfClass with get_irqnum() function

2020-06-15 Thread Stefan Berger
From: Stefan Berger Implement get_ireqnum() as part of the TPMIfClass to be get the assigned IRQ number. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis_isa.c| 9 + hw/tpm/tpm_tis_sysbus.c | 9 + include/sysemu/tpm.h| 10 ++ 3 files changed, 28 insertions(+)

Re: [PATCH v3] target/arm/cpu: adjust virtual time for arm cpu

2020-06-15 Thread Ying Fang
On 6/10/2020 3:40 PM, Andrew Jones wrote: On Wed, Jun 10, 2020 at 09:32:06AM +0800, Ying Fang wrote: On 6/8/2020 8:49 PM, Andrew Jones wrote: On Mon, Jun 08, 2020 at 08:12:43PM +0800, Ying Fang wrote: From: fangying Virtual time adjustment was implemented for virt-5.0 machine type, but

Re: [PATCH] hw/xen_pt: Don't grant opregion permissions

2020-06-15 Thread Roger Pau Monné
On Sun, Jun 14, 2020 at 11:21:09PM +, Grzegorz Uriasz wrote: > With the upstreaming of linux based stubdomains to xen, qemu can't > assume it runs inside dom0 - permission assignment must be moved to > libxl running in dom0. This xen patch: > https://lists.xenproject.org/archives/html/xen-devel

Re: [PATCH v3 0/4] block: seriously improve savevm performance

2020-06-15 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > On 6/15/20 3:17 PM, Dr. David Alan Gilbert wrote: > > * Denis V. Lunev (d...@openvz.org) wrote: > >> This series do standard basic things: > >> - it creates intermediate buffer for all writes from QEMU migration code > >> to QCOW2 image, > >> - this buf

[PATCH] tests/qtest/bios-tables: Only run the TPM test with CONFIG_TPM enabled

2020-06-15 Thread Thomas Huth
"make check-qtest" currently fails if configure has been run with "--disable-tpm" - the TPM-related tests can only work if the TPM is enabled in the build. So let's use the CONFIG_TPM switch to disable the test if TPM is not available. Signed-off-by: Thomas Huth --- tests/qtest/bios-tables-test.

Re: [PATCH v3 6/6] linux-user: Add strace support for printing arguments of fallocate()

2020-06-15 Thread Filip Bozuta
On 15.6.20. 13:58, Laurent Vivier wrote: > Le 11/06/2020 à 17:51, Filip Bozuta a écrit : >> From: Filip Bozuta >> >> This patch implements strace argument printing functionality for following >> syscall: >> >> *fallocate - manipulate file space >> >> int fallocate(int fd, int mode,

Re: [PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test

2020-06-15 Thread Thomas Huth
On 15/06/2020 14.35, Auger Eric wrote: > Hi Philippe, Thomas, > > On 6/15/20 12:22 PM, Thomas Huth wrote: >> On 15/06/2020 12.02, Philippe Mathieu-Daudé wrote: >>> On Fri, Jun 12, 2020 at 5:00 PM Michael S. Tsirkin wrote: From: Eric Auger Test tables specific to the TPM-TIS i

Re: [PATCH v2 0/4] Add support for SafeStack

2020-06-15 Thread Daniele Buono
Ping? On 5/29/2020 4:51 PM, Daniele Buono wrote: LLVM supports SafeStack instrumentation to protect against stack buffer overflows, since version 3.7 From https://clang.llvm.org/docs/SafeStack.html: "It works by separating the program stack into two distinct regions: the safe stack and the un

Re: [PATCH 3/3] acpi: Enable TPM IRQ

2020-06-15 Thread Stefan Berger
On 6/15/20 8:37 AM, Stefan Berger wrote: From: Stefan Berger Move the TPM TIS IRQ to unused IRQ 13, which is also accepted by Windows. Query for the TPM's irq number and enable the TPM IRQ if not zero. Signed-off-by: Stefan Berger CC: Michael S. Tsirkin This patch is missing the reference

  1   2   3   4   5   >