Re: [PATCH 1/2] hmp: Implement qom-get HMP command

2020-05-29 Thread Markus Armbruster
Markus Armbruster writes: > "Dr. David Alan Gilbert (git)" writes: > >> From: "Dr. David Alan Gilbert" >> >> This started off as Andreas Färber's implementation from >> March 2015, but after feedback from Paolo and Markus it morphed into >> using the json output which handles structs reasonably

Re: [PATCH v2 0/4] microvm: memory config tweaks

2020-05-29 Thread Igor Mammedov
On Thu, 28 May 2020 13:58:35 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200528134035.32025-1-kra...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you

[PATCH v3 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse

2020-05-29 Thread Pavel Dovgalyuk
This patch splits code in BootLinuxConsole class into two different classes to allow reusing it by record/replay tests. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée --- 0 files changed diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py inde

[PATCH v3 01/11] tests/acceptance: allow console interaction with specific VMs

2020-05-29 Thread Pavel Dovgalyuk
Console interaction in avocado scripts was possible only with single default VM. This patch modifies the function parameters to allow passing a specific VM as a parameter to interact with it. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Willian Rampazzo Reviewed-by: Alex Bennée --- 0 files chan

[PATCH v3 00/11] Record/replay acceptance tests

2020-05-29 Thread Pavel Dovgalyuk
The following series adds record/replay tests to the acceptance group. Test pass successfully with the latest submitted record/replay fixes: - replay: notify the main loop when there are no instructions - replay: synchronize on every virtual timer callback The provided tests perform kernel boot

[PATCH v3 03/11] tests/acceptance: add base class record/replay kernel tests

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a base for testing kernel boot recording and replaying. Each test has the phase of recording and phase of replaying. Virtual machines just boot the kernel and do not interact with the network. Structure and image links for the tests are borrowed from boot_linux_console.py Testing co

[PATCH v3 05/11] tests/acceptance: add record/replay test for aarch64

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for aarch64 platform. Signed-off-by: Pavel Dovgalyuk -- v3: - added cpu tag for the test (suggested by Philippe Mathieu-Daudé) --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kerne

[PATCH v3 04/11] tests/acceptance: add kernel record/replay test for x86_64

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a test for record/replay an execution of x86_64 machine. Execution scenario includes simple kernel boot, which allows testing basic hardware interaction in RR mode. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/accepta

[PATCH v3 09/11] tests/acceptance: record/replay tests with advcal images

2020-05-29 Thread Pavel Dovgalyuk
This patch adds more record/replay tests with kernel images. Signed-off-by: Pavel Dovgalyuk -- v2: - make download path fixed to allow pre-test downloading (suggested by Willian Rampazzo) --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py

Re: [PATCH 2/5] vhost: involve device backends in feature negotiation

2020-05-29 Thread Jason Wang
On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: Many vhost devices in QEMU currently do not involve the device backend in feature negotiation. This seems fine at first glance for device types without their own feature bits (virtio-net has many but other device types have none). This overlooks the

[PATCH v3 06/11] tests/acceptance: add record/replay test for arm

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for two different arm platforms. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index 616d2dfc33..382f1248e0 100644 --- a/tests/acceptance/re

[PATCH v3 07/11] tests/acceptance: add record/replay test for ppc64

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for ppc64 platform. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index 382f1248e0..738367849f 100644 --- a/tests/acceptance/replay_kernel.p

[PATCH v3 10/11] tests/acceptance: refactor boot_linux to allow code reuse

2020-05-29 Thread Pavel Dovgalyuk
This patch moves image downloading functions to the separate class to allow reusing them from record/replay tests. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py index 075a386300..3aa57e88b0 100644 --- a/tests/acce

[PATCH v3 08/11] tests/acceptance: add record/replay test for m68k

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel image boot for m68k platform. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py index 738367849f..c1ec002db6 100644 --- a/tests/acceptance/replay_kernel.py

[PATCH v3 11/11] tests/acceptance: Linux boot test for record/replay

2020-05-29 Thread Pavel Dovgalyuk
This patch adds a test for record/replay, which boots Linux image from the disk and interacts with the network. The idea and code of this test is borrowed from boot_linux.py However, currently record/replay works only for x86_64, therefore other tests were excluded. Each test consists of the follo

[Bug 1881231] [NEW] colo: Can not recover colo after svm failover twice

2020-05-29 Thread ye.zou
-- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1881231 Title: colo: Can not recover colo after svm failover twice Status in QEMU: New Bug description: Hi Expert, x-blockdev-change met some e

Re: [PATCH 5/5] virtio: enable VIRTIO_F_RING_PACKED for all devices

2020-05-29 Thread Jason Wang
On 2020/5/23 上午1:17, Stefan Hajnoczi wrote: The packed virtqueue layout was introduced in VIRTIO 1.1. It is a single ring instead of a split avail/used ring design. There are CPU cache advantages to this layout and it is also suited better to hardware implementation. The vhost-net backend has

Re: [RFC PATCH] hw/net/e1000e: Do not abort() on invalid PSRCTL register value

2020-05-29 Thread Philippe Mathieu-Daudé
Le ven. 29 mai 2020 08:36, Jason Wang a écrit : > > On 2020/5/25 下午8:23, Philippe Mathieu-Daudé wrote: > > libFuzzer found using 'qemu-system-i386 -M q35': > > > > qemu: hardware error: e1000e: PSRCTL.BSIZE0 cannot be zero > > CPU #0: > > EAX= EBX= ECX= EDX=0663 > > ES

Re: [PATCH 1/1] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-29 Thread Jason Wang
On 2020/5/13 下午7:31, and...@daynix.com wrote: From: Andrew Melnychenko Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441 Added ICR clearing if there is IMS bit - according to the note by section 13.3.27 of the 8257X developers manual. Signed-off-by: Andrew Melnychenko --- hw/ne

[PATCH v2 2/5] target/tricore: Move translate feature check to ctx

2020-05-29 Thread Bastian Koppelmann
this allows us to remove the references to env from ctx. This also fixes a segfault that was due to the unititalized ctx->env ptr. Reported-by: Andreas Konopik Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 60 +- 1 file changed, 33 insert

[PATCH v2 1/5] target/tricore: Don't save pc in generate_qemu_excp

2020-05-29 Thread Bastian Koppelmann
EXCP_DEBUG is the only user. If we encounter a jump in tricore-gdb it's target was overwritten by generate_qemu_excp() and we would never leave. Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/tricore/translate.c b/target

[PATCH v2 0/5] TriCore fixes and gdbstub

2020-05-29 Thread Bastian Koppelmann
Hi, this series fixes a few TriCore problems: - Segfault due to non initialized ctx->env ptr (see https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03527.html) I fixed this by properly detangling any reference of the env pointer in the translate functions. (as suggested by Peter Mayd

[PATCH v2 4/5] target/tricore: Implement tricore_cpu_get_phys_page_debug

2020-05-29 Thread Bastian Koppelmann
this also removes tricore_cpu_get_phys_page_attrs_debug() as it was a temporary fix from b190f477e29c7cd03a8fee49c96d27f160e3f5b0. Signed-off-by: Bastian Koppelmann --- target/tricore/cpu.c| 10 +- target/tricore/helper.c | 13 + 2 files changed, 14 insertions(+), 9 delet

[PATCH v2] fcntl: Add 32bit filesystem mode

2020-05-29 Thread Linus Walleij
It was brought to my attention that this bug from 2018 was still unresolved: 32 bit emulators like QEMU were given 64 bit hashes when running 32 bit emulation on 64 bit systems. This adds a flag to the fcntl() F_GETFD and F_SETFD operations to set the underlying filesystem into 32bit mode even if

[PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep

2020-05-29 Thread Bastian Koppelmann
this is needed for remote gdb connections. Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 608f72d384..7752630ac1 100644 --- a/tar

[PATCH] usb-host: workaround libusb bug

2020-05-29 Thread Gerd Hoffmann
libusb seems to no allways call the completion callback for requests canceled (which it is supposed to do according to the docs). So add a limit to avoid qemu waiting forever. Tested-by: BALATON Zoltan Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 14 ++ 1 file changed, 1

[PATCH v2 5/5] target/tricore: Implement gdbstub

2020-05-29 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- v1 -> v2: - tricore_cpu_gdb_read_registers uses a GByteArray pointer for the mem_buf argument target/tricore/Makefile.objs | 2 +- target/tricore/cpu.c | 10 +++ target/tricore/cpu.h | 2 + target/tricore/gdbstub.c | 139 ++

Re: [RFC PATCH] hw/net/e1000e: Do not abort() on invalid PSRCTL register value

2020-05-29 Thread Jason Wang
On 2020/5/29 下午3:17, Philippe Mathieu-Daudé wrote: Le ven. 29 mai 2020 08:36, Jason Wang > a écrit : On 2020/5/25 下午8:23, Philippe Mathieu-Daudé wrote: > libFuzzer found using 'qemu-system-i386 -M q35': > > qemu: hardware error: e1000e: PSRCTL.BSIZE

Re:RE: GDB get wrong debug infos on TI DSP architecture extension

2020-05-29 Thread casmac
Hi,     Thanks for the hints!! I put "-d trace:gdbstub_io_command,trace:gdbstub_io_reply" to command line, get the following from QEMU at the beginning when gdb starts, is there anything went wrong? 6792@1590734139.390330:gdbstub_io_command Received: qSupported:xmlRegisters=tivc33;QNonStop;qR

Re: [PATCH v2] hw/vfio/common: Trace in which mode an IOMMU is opened

2020-05-29 Thread Auger Eric
Hi Philippe, On 5/27/20 5:55 PM, Philippe Mathieu-Daudé wrote: > One might want to check which IOMMU version the host kernel > provide. Add a trace event to see in which mode we opened > our container. > > Reviewed-by: Cornelia Huck > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auge

Re: [PATCH 1/1] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-29 Thread Jason Wang
On 2020/5/29 下午3:18, Jason Wang wrote: On 2020/5/13 下午7:31, and...@daynix.com wrote: From: Andrew Melnychenko Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441 Added ICR clearing if there is IMS bit - according to the note by section 13.3.27 of the 8257X developers manual. Signe

[PATCH v3 4/4] microvm: move virtio base to 0xfeb00000

2020-05-29 Thread Gerd Hoffmann
Place virtio-mmio devices near the other mmio regions, next ioapic is at @ 0xfec0. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index ba68d1f22bb3..fd34b78e

[PATCH v3 0/4] microvm: memory config tweaks

2020-05-29 Thread Gerd Hoffmann
With more microvm memory config tweaks split this into its owns series, the microvm acpi patch series is already big enough ... v2: - use 3G split. - add patch to move virtio-mmio region. - pick up acks & reviews. v3: - fix xen build. - pick up acks & reviews. take care, Gerd Gerd Hoffman

[PATCH v3 1/4] microvm: use 3G split unconditionally

2020-05-29 Thread Gerd Hoffmann
Looks like the logic was copied over from q35. q35 does this for backward compatibility, there is no reason to do this on microvm though. Also microvm doesn't need much mmio space, 1G is more than enough. Using an mmio window smaller than 1G is bad for gigabyte alignment and hugepages though. S

[PATCH v3 2/4] microvm: drop max-ram-below-4g support

2020-05-29 Thread Gerd Hoffmann
Not useful for microvm and allows users to shoot themself into the foot (make ram + mmio overlap). Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/microvm.c | 19 --- 1 file changed, 19 deletions(-

[PATCH v3 3/4] x86: move max-ram-below-4g to pc

2020-05-29 Thread Gerd Hoffmann
Move from X86MachineClass to PCMachineClass so it disappears from microvm machine type property list. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini --- include/hw/i386/pc.h | 2 ++ include/hw/i386/x86.h | 4 hw/i386/pc.c | 46

[Qemu-devel PATCH] target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES

2020-05-29 Thread Like Xu
The Perfmon and Debug Capability MSR named IA32_PERF_CAPABILITIES is a feature-enumerating MSR, which only enumerates the feature full-width write (via bit 13) by now which indicates the processor supports IA32_A_PMCx interface for updating bits 32 and above of IA32_PMCx. The existence of MSR IA32

RE: [PATCH v3 3/4] x86: move max-ram-below-4g to pc

2020-05-29 Thread Paul Durrant
> -Original Message- > From: Gerd Hoffmann > Sent: 29 May 2020 08:40 > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Eduardo Habkost > ; Sergio Lopez > ; phi...@redhat.com; Marcel Apfelbaum > ; Stefano Stabellini > ; Paul Durrant ; > xen-de...@lists.xenproject.org; Michael S. > Tsirki

Re: [RFC] some semihosting interrogation

2020-05-29 Thread Fred Konrad
Le 5/28/20 à 2:00 PM, Philippe Mathieu-Daudé a écrit : Hi Fred, On 5/28/20 11:44 AM, Fred Konrad wrote: Hi all, Just wonderring if there is any reason not to be able to defer qemu_semihosting_connect_chardevs a little more to be able to specify chardev=serial0? Like: diff --git a/softmmu/

Re: [PATCH 1/7] block/nvme: poll queues without q->lock

2020-05-29 Thread Sergio Lopez
On Thu, May 28, 2020 at 04:23:50PM +0100, Stefan Hajnoczi wrote: > On Mon, May 25, 2020 at 10:07:13AM +0200, Sergio Lopez wrote: > > On Tue, May 19, 2020 at 06:11:32PM +0100, Stefan Hajnoczi wrote: > > > A lot of CPU time is spent simply locking/unlocking q->lock during > > > polling. Check for com

[Bug 1881249] [NEW] CPU fetch from unpopulated ROM on reset

2020-05-29 Thread Philippe Mathieu-Daudé
Public bug reported: Some architectures fetch the $PC/$SP register as vectors in memory, usually ROM. The CPU reset() handler is called before the ROM code is populated, resulting in fetching incorrect PC/SP. Architectures affected: - M68K - RX - ARM M-profile ** Affects: qemu Importance:

Re: [RFC v2 17/18] spapr: Added PEF based guest memory protection

2020-05-29 Thread Ram Pai
On Thu, May 21, 2020 at 01:43:03PM +1000, David Gibson wrote: > Some upcoming POWER machines have a system called PEF (Protected > Execution Framework) which uses a small ultravisor to allow guests to Framework -> Facility > run in a way that they can't be eavesdropped by the hypervisor. The > e

[Bug 1881249] Re: CPU fetch from unpopulated ROM on reset

2020-05-29 Thread Philippe Mathieu-Daudé
Different comments from Peter Maydell regarding this issue: - https://www.mail-archive.com/qemu-devel@nongnu.org/msg683768.html "We should be able to do this with the new 3-phase reset API : the rom loader reset should happen in phase 2, and the Arm CPU should only load the new PC and SP in phase

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-29 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.2-3ubuntu8 --- qemu (1:4.2-3ubuntu8) groovy; urgency=medium * d/p/ubuntu/lp-1805256*: Fixes for QEMU on aarch64 ARM hosts - async: use explicit memory barriers (LP: #1805256) - aio-wait: delegate polling of main AioContext if BQL

Re: [PATCH] hw/arm/virt: Fix PL061 node name and properties

2020-05-29 Thread Geert Uytterhoeven
Hi Peter, CC Rob, who made these properties mandatory in the pl061 DT bindings. On Fri, May 22, 2020 at 11:30 AM Peter Maydell wrote: > On Fri, 22 May 2020 at 09:29, Geert Uytterhoeven wrote: > > On Thu, May 21, 2020 at 6:59 PM Peter Maydell > > wrote: > > > On Tue, 19 May 2020 at 09:49, Geer

[Bug 1881249] Re: CPU fetch from unpopulated ROM on reset

2020-05-29 Thread Philippe Mathieu-Daudé
Related (invalidated thus rejected) series: - https://www.mail-archive.com/qemu-devel@nongnu.org/msg683763.html "Support device reset handler priority configuration" This series adds support for configuring device reset handler priority, and uses it to ensure that the ARMv7-M CPU reset handler

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-29 Thread Christian Ehrhardt 
Migrated right now, sponsoring the related SRU portions into B/E/F ... for consideration by the SRU Team. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on rcu_call_rea

Re: [PATCH v2 5/5] target/tricore: Implement gdbstub

2020-05-29 Thread Alex Bennée
Bastian Koppelmann writes: > Signed-off-by: Bastian Koppelmann Acked-by: Alex Bennée -- Alex Bennée

Re: QMP qom-get feels useless for child properties

2020-05-29 Thread Paolo Bonzini
On 29/05/20 08:57, Markus Armbruster wrote: > QMP qom-get for a link property returns the canonical path of the link's > target: > > $ socat "READLINE,history=$HOME/.qmp_history,prompt=QMP> " > UNIX-CONNECT:$HOME/work/images/test-qmp > [...] > QMP> {"execute": "qom-get", "arguments":

Re: [PATCH 0/2] linux-user: Load a vdso for x86_64

2020-05-29 Thread Laurent Vivier
Le 28/05/2020 à 23:42, Richard Henderson a écrit : > On 5/28/20 3:32 AM, Laurent Vivier wrote: >> Le 28/05/2020 à 12:08, Peter Maydell a écrit : >>> On Tue, 19 May 2020 at 20:45, Richard Henderson >>> wrote: Makefile | 4 +- linux-user/elfload.c | 203 +++

Re: [PATCH 0/2] linux-user: Load a vdso for x86_64

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/29/20 10:50 AM, Laurent Vivier wrote: > Le 28/05/2020 à 23:42, Richard Henderson a écrit : >> On 5/28/20 3:32 AM, Laurent Vivier wrote: >>> Le 28/05/2020 à 12:08, Peter Maydell a écrit : On Tue, 19 May 2020 at 20:45, Richard Henderson wrote: > Makefile | 4 +-

Re: [RFC v2 01/18] target/i386: sev: Remove unused QSevGuestInfoClass

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:42 AM, David Gibson wrote: > This structure is nothing but an empty wrapper around the parent class, > which by QOM conventions means we don't need it at all. > > Signed-off-by: David Gibson > --- > target/i386/sev.c | 1 - > target/i386/sev_i386.h | 5 - > 2 files changed,

Re: [RFC v2 02/18] target/i386: sev: Move local structure definitions into .c file

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:42 AM, David Gibson wrote: > Neither QSevGuestInfo nor SEVState (not to be confused with SevState) is > used anywhere outside target/i386/sev.c, so they might as well live in > there rather than in a (somewhat) exposed header. > > Signed-off-by: David Gibson > --- > target/i386/sev.

Re: [RFC v2 03/18] target/i386: sev: Rename QSevGuestInfo

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:42 AM, David Gibson wrote: > At the moment this is a purely passive object which is just a container for > information used elsewhere, hence the name. I'm going to change that > though, so as a preliminary rename it to SevGuestState. > > That name risks confusion with both SEVState a

Re: [PATCH 2/2] hmp: Simplify qom_set

2020-05-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > >> >> On 5/20/20 5:11 PM, Dr. David Alan Gilbert (git

Re: [PATCH v7 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface

2020-05-29 Thread Laszlo Ersek
On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > The FW_CFG_DATA_GENERATOR allows any object to produce > blob of data consumable by the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v7: addressed Laszlo's comments > - fixed typos in description > - return size_t instead of s

Re: [RFC v2 04/18] target/i386: sev: Embed SEVState in SevGuestState

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:42 AM, David Gibson wrote: > Currently SevGuestState contains only configuration information. For > runtime state another non-QOM struct SEVState is allocated separately. > > Simplify things by instead embedding the SEVState structure in > SevGuestState. > > Signed-off-by: David Gib

Re: [RFC v2 06/18] target/i386: sev: Remove redundant cbitpos and reduced_phys_bits fields

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:42 AM, David Gibson wrote: > The SEVState structure has cbitpos and reduced_phys_bits fields which are > simply copied from the SevGuestState structure and never changed. Now that > SEVState is embedded in SevGuestState we can just access the original copy > directly. > > Signed-off-

Re: [PATCH 1/1] hw/net: Added basic IPv6 fragmentation. Fixed IPv6 payload length. Fixed CSO for IPv6.

2020-05-29 Thread Jason Wang
On 2020/5/8 上午3:25, and...@daynix.com wrote: From: Andrew Melnychenko Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065 Overall, there was an issue that big frames of IPv6 doesn't sent. With network backend with 'virtual header' - there was an issue in 'plen' field. Overall, during

Re: [RFC v2 09/18] target/i386: sev: Unify SEVState and SevGuestState

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:42 AM, David Gibson wrote: > SEVState is contained with SevGuestState. We've now fixed redundancies > and name conflicts, so there's no real point to the nested structure. Just > move all the fields of SEVState into SevGuestState. > > This eliminates the SEVState structure, which as

Re: [RFC v2 16/18] guest memory protection: Add Error ** to GuestMemoryProtection::kvm_init

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/21/20 5:43 AM, David Gibson wrote: > This allows failures to be reported richly and idiomatically. > > Signed-off-by: David Gibson > --- > accel/kvm/kvm-all.c| 4 +++- > include/exec/guest-memory-protection.h | 2 +- > target/i386/sev.c | 31 ++

Re: [PATCH v7 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/29/20 11:09 AM, Laszlo Ersek wrote: > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: >> The FW_CFG_DATA_GENERATOR allows any object to produce >> blob of data consumable by the fw_cfg device. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v7: addressed Laszlo's comments >> - fixed ty

Re: [PATCH] python: remove more instances of sys.version_info

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/14/20 5:52 AM, John Snow wrote: > We guarantee 3.5+ everywhere; remove more dead checks. In general, try > to avoid using version checks and instead prefer to attempt behavior > when possible. > > Signed-off-by: John Snow > --- > scripts/analyze-migration.py | 5 - > script

Re: [PATCH 1/8] decodetree: Remove python 3.4 check

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/18/20 6:40 PM, Richard Henderson wrote: > We are now guaranteed python 3.5 or later. FYI this has been addressed by John Snow: https://www.mail-archive.com/qemu-block@nongnu.org/msg66830.html > > Signed-off-by: Richard Henderson > --- > scripts/decodetree.py | 25 +

Re: [PATCH v4 0/6] scripts: More Python fixes

2020-05-29 Thread Philippe Mathieu-Daudé
On 5/12/20 12:32 PM, Philippe Mathieu-Daudé wrote: > Trivial Python3 fixes, again... > > Since v3: > - Fixed missing scripts/qemugdb/timers.py (kwolf) > - Cover more scripts > - Check for __main__ in few scripts > > Since v2: > - Remove patch updating MAINTAINERS > > Since v1: > - Added Alex Ben

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-05-29 Thread Laszlo Ersek
Gerd, Corey: there's a question for you near the end, please. On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > The 'gen_id' argument refers to a QOM object able to produce > data consumable by the fw_cfg device. The producer object must > implement the FW_CFG_DATA_GENERATOR interface. > > Signed

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-05-29 Thread Markus Armbruster
Roman Kagan writes: > Several block device properties related to blocksize configuration must > be in certain relationship WRT each other: physical block must be no > smaller than logical block; min_io_size, opt_io_size, and > discard_granularity must be a multiple of a logical block. > > To ensu

Re: [PATCH v4 2/4] hw/riscv: spike: Allow creating multiple NUMA sockets

2020-05-29 Thread Anup Patel
On Thu, May 28, 2020 at 8:35 PM Igor Mammedov wrote: > > On Thu, 28 May 2020 18:59:57 +0530 > Anup Patel wrote: > > > We extend RISC-V spike machine to allow creating a multi-socket machine. > > Each RISC-V spike machine socket is a NUMA node having a set of HARTs, > > a memory instance, and a CL

[Bug 1881231] Re: colo: Can not recover colo after svm failover twice

2020-05-29 Thread ye.zou
primary vm command: ./qemu-system-x86_64 -L /usr/share/qemu-kvm/ -enable-kvm -cpu qemu64,+kvmclock -m 2048 -smp 2 -qmp stdio -vnc :0 -device piix3-usb-uhci -device usb-tablet -name primary -netdev tap,id=hn0,vhost=off,br=br_bond1,helper=/usr/libexec/qemu-bridge-helper -device rtl8139,id=e0,netd

[Bug 1881231] Re: colo: Can not recover colo after svm failover twice

2020-05-29 Thread ye.zou
In step 3 I used following commands: on primary vm console: {"execute": "drive-mirror", "arguments":{ "device": "colo-disk0", "job-id": "resync", "target": "nbd://169.254.66.10:/parent0", "mode": "existing","format":"raw","sync":"full"} } // till the job ready { "execute": "query-block-jobs"

Re: [PATCH v7 00/14] LUKS: encryption slot management using amend interface

2020-05-29 Thread Daniel P . Berrangé
On Mon, May 18, 2020 at 03:20:27PM +0300, Maxim Levitsky wrote: > Hi! > Here is the updated series of my patches, incorporating all the feedback I > received. > > This implements the API interface that we agreed upon except that I merged the > LUKSKeyslotActive/LUKSKeyslotInactive union into a st

[Bug 1881249] Re: CPU fetch from unpopulated ROM on reset

2020-05-29 Thread Peter Maydell
I had an initial look at fixing this for arm via 3-phase reset, but ran into the problem that currently CPU reset is triggered via a qemu_register_reset() hook, and qemu_register_reset() itself does not have a 3-phase reset API, so the reset hook for resetting the CPUs will end up doing all 3 phase

Re: [PATCH v2 18/22] python/qemu/machine: add kill() method

2020-05-29 Thread Philippe Mathieu-Daudé
On 2/17/20 4:02 PM, Vladimir Sementsov-Ogievskiy wrote: > Add method to hard-kill vm, without any quit commands. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > python/qemu/machine.py | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Thanks, applied to my python-next

Re: [RFC PATCH v7 3/5] softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace

2020-05-29 Thread Laszlo Ersek
On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > User-generated fw_cfg keys should be prefixed with "opt/". (1) Please formulate this as follows: 'Names of user-provided fw_cfg items are supposed to start with "opt/".' (Because we're really not "prefixing keys".) > However FW_CFG_DATA_GENERAT

[RFC v4 0/4] QEMU cpus.c refactoring

2020-05-29 Thread Claudio Fontana
Motivation and higher level steps: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html v3 -> v4: * overall: added copyright headers to all files that were missing them (used copyright and license of the module the stuff was extracted from). For the new interface files, added

[RFC v4 1/4] softmmu: move softmmu only files from root

2020-05-29 Thread Claudio Fontana
move arch_init, balloon, cpus, ioport, memory, memory_mapping, qtest. They are all specific to CONFIG_SOFTMMU. Signed-off-by: Claudio Fontana --- MAINTAINERS | 12 ++-- Makefile.target | 7 ++- softmmu/Makefile.objs

[RFC v4 3/4] cpu-timers, icount: new modules

2020-05-29 Thread Claudio Fontana
refactoring of cpus.c continues with cpu timer state extraction. cpu-timers: responsible for the cpu timers state, and for access to cpu clocks and ticks. icount: counts the TCG instructions executed. As such it is specific to the TCG accelerator. Therefore, it is built only under CONFIG_TCG. On

[RFC v4 4/4] cpus: extract out accel-specific code to each accel

2020-05-29 Thread Claudio Fontana
each accelerator registers a new "CpusAccel" interface implementation on initialization, providing functions for starting a vcpu, kicking a vcpu, and sychronizing state. This way the code in cpus.c is now all general softmmu code, nothing accelerator-specific anymore. There is still some ifdeffer

[RFC v4 2/4] cpu-throttle: new module, extracted from cpus.c

2020-05-29 Thread Claudio Fontana
move the vcpu throttling functionality into its own module. This functionality is not specific to any accelerator, and it is used currently by migration to slow down guests to try to have migrations converge, and by the cocoa MacOS UI to throttle speed. cpu-throttle contains the controls to adjus

Re: [Qemu-devel PATCH] target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES

2020-05-29 Thread Paolo Bonzini
On 29/05/20 09:43, Like Xu wrote: > +if (!cpu->enable_pmu) { > +*ecx &= ~CPUID_EXT_PDCM; > +} > break; > case 2: > /* cache info: needed for Pentium Pro compatibility */ > @@ -6505,6 +6528,12 @@ static void x86_cpu_realizefn(DeviceState *dev, Error

Re: [PULL 00/21] Vga 20200528 patches

2020-05-29 Thread Peter Maydell
On Thu, 28 May 2020 at 13:36, Gerd Hoffmann wrote: > > The following changes since commit 06539ebc76b8625587aa78d646a9d8d5fddf84f3: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/mips-hw-next-20200526' into staging (2020-05-26 > 20:25:06 +0100) > > are available in the Git repo

Re: [PATCH v3 1/2] PCI: vmd: Filter resource type bits from shadow register

2020-05-29 Thread Lorenzo Pieralisi
On Wed, May 27, 2020 at 11:02:39PM -0400, Jon Derrick wrote: > Versions of VMD with the Host Physical Address shadow register use this > register to calculate the bus address offset needed to do guest > passthrough of the domain. This register shadows the Host Physical > Address registers including

[PULL 0/5] Qcrypto next patches

2020-05-29 Thread Daniel P . Berrangé
The following changes since commit b8bee16e94df0fcd03bdad9969c30894418b0e6e: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200528-pull-request= ' into staging (2020-05-28 18:13:20 +0100) are available in the Git repository at: https://github.com/berrange/qemu tags/qcrypto-next-pull

[PULL 2/5] crypto/secret: move main logic from 'secret' to 'secret_common'.

2020-05-29 Thread Daniel P . Berrangé
From: Alexey Krasikov Create base class 'common secret'. Move common data and logic from 'secret' to 'common_secret' class. This allowed adding abstraction layer for easier adding new 'secret' objects in future. Convert 'secret' class to child from basic 'secret_common' with 'data' and 'file' pro

[PULL 1/5] crypto: add "none" random provider

2020-05-29 Thread Daniel P . Berrangé
From: Marek Marczykowski-Górecki In case of not using random-number needing feature, it makes sense to skip RNG init too. This is especially helpful when QEMU is sandboxed in Stubdomain under Xen, where there is very little entropy so initial getrandom() call delays the startup several seconds. I

[PULL 3/5] crypto/linux_keyring: add 'secret_keyring' secret object.

2020-05-29 Thread Daniel P . Berrangé
From: Alexey Krasikov Add the ability for the secret object to obtain secret data from the Linux in-kernel key managment and retention facility, as an extra option to the existing ones: reading from a file or passing directly as a string. The secret is identified by the key serial number. The up

[PULL 4/5] test-crypto-secret: add 'secret_keyring' object tests.

2020-05-29 Thread Daniel P . Berrangé
From: Alexey Krasikov Add tests: test_secret_keyring_good; test_secret_keyring_revoked_key; test_secret_keyring_expired_key; test_secret_keyring_bad_serial_key; test_secret_keyring_bad_key_access_right; Added tests require libkeyutils. The absence of this library is not critical, becau

[PULL 5/5] crypto: Remove use of GCRYPT_VERSION macro.

2020-05-29 Thread Daniel P . Berrangé
From: "Richard W.M. Jones" According to the gcrypt documentation it's intended that gcry_check_version() is called with the minimum version of gcrypt needed by the program, not the version from the header file that happened to be installed when qemu was compiled. Indeed the gcrypt.h header says

Re: [PULL v3 00/11] bitmaps patches for 2020-05-26

2020-05-29 Thread Peter Maydell
On Fri, 29 May 2020 at 06:53, Vladimir Sementsov-Ogievskiy wrote: > > Hi! > > Strange thing with your pull requests: I receive only small part of them.. I > thought it's my problem of receiving part, but now I've checked that in > mailing list archive there are same only two emails: 00/11 and 08

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-05-29 Thread Roman Kagan
On Fri, May 29, 2020 at 11:53:26AM +0200, Markus Armbruster wrote: > Roman Kagan writes: > > > Several block device properties related to blocksize configuration must > > be in certain relationship WRT each other: physical block must be no > > smaller than logical block; min_io_size, opt_io_size,

Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Laszlo Ersek
On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > Example of use to dump: > > $ qemu-system-x86_64 -S \ > -object tls-cipher-suites,id=mysuite,priority=@SYSTEM \ > -trace qcrypto\* > 159066.197123:qcrypto_tls_cipher_suite_priority priority: @SYSTEM > 159066.197219:qcrypto_tls

Re: [PATCH Kernel v22 0/8] Add UAPIs to support migration for VFIO devices

2020-05-29 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Thu, 28 May 2020 04:01:02 -0400 > Yan Zhao wrote: > > > > > > This is my understanding of the protocol as well, when the device is > > > > > running, pending_bytes might drop to zero if no internal state has > > > > > changed and may be n

Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Laszlo Ersek
On 05/29/20 13:09, Laszlo Ersek wrote: > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: >> Example of use to dump: >> >> $ qemu-system-x86_64 -S \ >> -object tls-cipher-suites,id=mysuite,priority=@SYSTEM \ >> -trace qcrypto\* >> 159066.197123:qcrypto_tls_cipher_suite_priority prio

Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Daniel P . Berrangé
On Fri, May 29, 2020 at 01:09:22PM +0200, Laszlo Ersek wrote: > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > (2) We need an actual commit message for this patch. How about the > following -- I have liberally stolen and edited comments that Daniel > made earlier in the Red Hat Bugzilla: > > -

[PATCH v5 0/2] target/arm: kvm: Support for KVM DABT with no valid ISS

2020-05-29 Thread Beata Michalska
Some of the ARMv7 & ARMv8 load/store instructions might trigger a data abort exception with no valid ISS info to be decoded. The lack of decode info makes it at least tricky to emulate the instruction which is one of the (many) reasons why KVM will not even try to do so. So far, if a guest made an

[PATCH v5 1/2] target/arm: kvm: Handle DABT with no valid ISS

2020-05-29 Thread Beata Michalska
On ARMv7 & ARMv8 some load/store instructions might trigger a data abort exception with no valid ISS info to be decoded. The lack of decode info makes it at least tricky to emulate those instruction which is one of the (many) reasons why KVM will not even try to do so. Add support for handling tho

[PATCH v5 2/2] target/arm: kvm: Handle misconfigured dabt injection

2020-05-29 Thread Beata Michalska
Injecting external data abort through KVM might trigger an issue on kernels that do not get updated to include the KVM fix. For those and aarch32 guests, the injected abort gets misconfigured to be an implementation defined exception. This leads to the guest repeatedly re-running the faulting instr

Re: [PATCH] usb-host: workaround libusb bug

2020-05-29 Thread BALATON Zoltan
On Fri, 29 May 2020, Gerd Hoffmann wrote: libusb seems to no allways call the completion callback for requests Typo: not always call. Regards, BALATON Zoltan canceled (which it is supposed to do according to the docs). So add a limit to avoid qemu waiting forever. Tested-by: BALATON Zoltan

[Bug 1872790] Re: empty qcow2

2020-05-29 Thread a
WDM claims it to be a MBR Linux 5.6.14 QEMU 5.0.0-6 `nobody 19023 109 21.1 7151512 3462300 ? Sl 13:18 0:32 /usr/bin/qemu-system-x86_64 -name guest=win10machine,debug-threads=on -S -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain-4-win10machine /master-key.ae

[PATCH v5 0/5] RISC-V multi-socket support

2020-05-29 Thread Anup Patel
This series adds multi-socket support for RISC-V virt machine and RISC-V spike machine. The multi-socket support will help us improve various RISC-V operating systems, firmwares, and bootloader to support RISC-V NUMA systems. These patch can be found in riscv_multi_socket_v5 branch at: https://git

  1   2   3   4   >