On Mon, May 18, 2020 at 03:20:27PM +0300, Maxim Levitsky wrote: > Hi! > Here is the updated series of my patches, incorporating all the feedback I > received. > > This implements the API interface that we agreed upon except that I merged the > LUKSKeyslotActive/LUKSKeyslotInactive union into a struct because otherwise > I need nested unions which are not supported currently by QAPI parser. > This didn't change the API and thus once support for nested unions is there, > it can always be implemented in backward compatible way. > > I hope that this series will finally be considered for merging, since I am > somewhat running > out of time to finish this task. > > Patches are strictly divided by topic to 3 groups, and each group depends on > former groups. > > * Patches 1,2 implement qcrypto generic amend interface, including definition > of structs used in crypto.json and implement this in luks crypto driver > Nothing is exposed to the user at this stage > > * Patches 3-9 use the code from patches 1,2 to implement qemu-img amend based > encryption slot management > for luks and for qcow2, and add a bunch of iotests to cover that. > > * Patches 10-13 add x-blockdev-amend (I'll drop the -x prefix if you like), > and wire it > to luks and qcow2 driver to implement qmp based encryption slot management > also using > the code from patches 1,2, and also add a bunch of iotests to cover this. > > Tested with -raw,-qcow2,-nbd and -luks iotests and 'make check' > > Changes from V4: > * Addresed feedback on patch 2 from Daniel (thanks!) > * Gave real numbers to the tests > * Updated the copyright in amend.c to RedHat > * Rebased and adjusted the python iotests to latest changes in iotest > infrastructure > > Changes from V5: > * Updated all QMP docs to state that all added QMP features are since 5.1 > * Rebased to latest master > > Changes from V6: > * Addressed most of the review feedback from Max Reitz > * Rebased on latest qemu master
It needs another rebase as there's some conflicts now. In any case, all the patches have my R-B already, and I don't have any further comments to add. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
