Re: [PATCH v2 1/3] qom/object: Move Object typedef to 'qemu/typedefs.h'

2020-05-15 Thread Philippe Mathieu-Daudé
On Fri, May 15, 2020 at 8:07 AM Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > We use the Object type all over the place. > > Forward declare it in "qemu/typedefs.h". > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > include/qemu/typedefs.h | 1 + > > include/qom/ob

[PATCH] trace/simple: Fix unauthorized enable

2020-05-15 Thread Markus Armbruster
st_set_trace_file() accidentally enables tracing. It's called unconditionally during startup, which is why QEMU built with the simple trace backend always writes a trace file "trace-$PID". This has been broken for quite a while. I didn't track down the exact commit. Fix st_set_trace_file() to r

Re: [PATCH 0/5] target/i386: fxtract, fscale fixes

2020-05-15 Thread Philippe Mathieu-Daudé
Cc'ing FPU emulation maintainers too. On 5/7/20 2:42 AM, Joseph Myers wrote: Among the various bugs in the x87 floating-point emulation that show up through a combination of glibc testing and code inspection, there are several in the implementations of the fxtract and fscale instructions. This

Re: [PATCH 1/3] docs/s390x: document the virtual css

2020-05-15 Thread Thomas Huth
On 05/05/2020 15.50, Cornelia Huck wrote: > Add some hints about "devno" rules. Thanks a lot for doing this, some documentation in this area is extremely useful! > Signed-off-by: Cornelia Huck > --- > docs/system/s390x/css.rst| 64 > docs/system/target-s

Onboard audio devices and -audiodev none

2020-05-15 Thread Markus Armbruster
Watch this: $ aarch64-softmmu/qemu-system-aarch64 -S -nodefaults -accel qtest -display none -M vexpress-a15 -audiodev none,id=foo audio: Device lm4549: audiodev default parameter is deprecated, please specify audiodev=foo I did, didn't I? Also: use warn_report()?

Re: About migration/colo issue

2020-05-15 Thread Lukas Straub
On Fri, 15 May 2020 03:16:18 + "Zhang, Chen" wrote: > Hi Hailiang/Dave. > > I found a urgent problem in current upstream code, COLO will stuck on > secondary checkpoint and later. > The guest will stuck by this issue. > I have bisect upstream code, this issue caused by Hailiang's optimize p

Re: [PULL 00/21] QOM patches for 2020-05-15

2020-05-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200515060424.18993-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515060424.18993-1-arm...@redhat.com Subject: [PULL 00/21] QOM patches for 2020-05-15 Type: series =

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/14/20 10:21 PM, John Snow wrote: On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: Handlers don't need to modify the IDEDMA structure. Make it const. Signed-off-by: Philippe Mathieu-Daudé I'll trust your judgment. As long as it still compiles and passes qtests, I'm happy if you're hap

Re: [PATCH v2 5/9] hw/char: Initial commit of Ibex UART

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/14/20 11:59 PM, Alistair Francis wrote: On Thu, May 14, 2020 at 11:00 AM Philippe Mathieu-Daudé wrote: Hi Alistair, On 5/7/20 9:13 PM, Alistair Francis wrote: This is the initial commit of the Ibex UART device. Serial TX is working, while RX has been implemeneted but untested. This is

Re: [PATCH v2 5/9] hw/char: Initial commit of Ibex UART

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/7/20 9:13 PM, Alistair Francis wrote: This is the initial commit of the Ibex UART device. Serial TX is working, while RX has been implemeneted but untested. This is based on the documentation from: https://docs.opentitan.org/hw/ip/uart/doc/ Signed-off-by: Alistair Francis --- MAINTAINER

Re: [PATCH 2/3] docs/s390x: document 3270

2020-05-15 Thread Thomas Huth
On 05/05/2020 15.50, Cornelia Huck wrote: > Add some basic info how to use 3270 devices. > > Signed-off-by: Cornelia Huck > --- > docs/system/s390x/3270.rst | 32 > docs/system/target-s390x.rst | 1 + > 2 files changed, 33 insertions(+) > create mode 100644 d

Please disable IRC notification on HighW4y2H3ll/qemu-fuzz fork

2020-05-15 Thread Philippe Mathieu-Daudé
Hello, your private qemu-fuzz project [1] based on old QEMU code does not contains the commit cb4c2536d56c [2] which disable IRC build notification on forks. Do you mind cherry-picking it, to avoid reporting your build failures on the mainstream QEMU IRC channel? Thanks, Phil. [1] https://

Re: [PATCH v4 0/2] Makefile: libfdt: build only the strict necessary

2020-05-15 Thread Philippe Mathieu-Daudé
Hi Claudio, On 5/14/20 9:38 PM, Claudio Fontana wrote: v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet) * changed the approach to leverage new upstream dtc Makefile, needs dtc submodule update to include upstream dtc commit 85e5d839847af54efab170f2b1331b2a6421e647.

Re: [PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments

2020-05-15 Thread Markus Armbruster
Aleksandar Markovic writes: > The checkpatch complain about "#ifdef 0". Convert corresponding > dead code to comments. In future, these cases could be converted > to some no-nonsense logging/tracing. > > Signed-off-by: Aleksandar Markovic > CC: Philippe Mathieu-Daudé > --- > hw/mips/mips_malta

Re: [PATCH 3/3] docs/s390x: document vfio-ccw

2020-05-15 Thread Thomas Huth
On 05/05/2020 15.50, Cornelia Huck wrote: > Add a basic example for passing a dasd via vfio-ccw. > > Signed-off-by: Cornelia Huck > --- > docs/system/s390x/vfio-ccw.rst | 58 ++ > docs/system/target-s390x.rst | 1 + > 2 files changed, 59 insertions(+) > create

Re: [PATCH 5/5] docs/system: Document Musca boards

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/7/20 5:18 PM, Peter Maydell wrote: Provide a minimal documentation of the Musca boards. Signed-off-by: Peter Maydell --- docs/system/arm/musca.rst | 31 +++ docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 33 insertion

Re: [PATCH v4 0/2] Makefile: libfdt: build only the strict necessary

2020-05-15 Thread Claudio Fontana
On 5/15/20 9:50 AM, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 5/14/20 9:38 PM, Claudio Fontana wrote: >> v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet) >> >> * changed the approach to leverage new upstream dtc Makefile, >>needs dtc submodule update to include

Re: [PATCH 0/5] docs/system: Document some arm board models

2020-05-15 Thread Philippe Mathieu-Daudé
Hi Peter, +Markus On 5/14/20 3:28 PM, Peter Maydell wrote: Ping for review? For the series: Reviewed-by: Philippe Mathieu-Daudé However I'd rather see the board documentation in the source code, and extract it when building. It'd be harder to miss updating the documentation when modifying

RE: About migration/colo issue

2020-05-15 Thread Zhanghailiang
Hi, I can't reproduce this issue with the qemu upstream either, It works well. Did you use an old version ? Thanks, Hailiang > -Original Message- > From: Lukas Straub [mailto:lukasstra...@web.de] > Sent: Friday, May 15, 2020 3:12 PM > To: Zhang, Chen > Cc: Zhanghailiang ; Dr . David A

Re: [PATCH v5 2/7] dwc-hsotg (dwc2) USB host controller register definitions

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/12/20 8:48 AM, Paul Zimmerman wrote: Import the dwc-hsotg (dwc2) register definitions file from the Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the mainline Linux kernel, the only changes being two instances of 'u32' changed to 'uint32_t' to allow it to compile. Checkpatch th

Re: [PATCH v4 2/3] tests/util-sockets: add abstract unix socket cases

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 12:32:34PM +0800, xiaoqiang zhao wrote: > add cases to test tight and non-tight for abstract address type > > Signed-off-by: xiaoqiang zhao > --- > tests/test-util-sockets.c | 91 +++ > 1 file changed, 91 insertions(+) > > diff --git a

Re: [PATCH v5 1/7] raspi: add BCM2835 SOC MPHI emulation

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/12/20 8:48 AM, Paul Zimmerman wrote: Add BCM2835 SOC MPHI (Message-based Parallel Host Interface) emulation. It is very basic, only providing the FIQ interrupt needed to allow the dwc-otg USB host controller driver in the Raspbian kernel to function. Signed-off-by: Paul Zimmerman Acked-b

[PULL 0/2] Ui 20200515 patches

2020-05-15 Thread Gerd Hoffmann
The following changes since commit d5c75ec500d96f1d93447f990cd5a4ef5ba27fae: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2020-05-08-1' into staging (2020-05-12 17:00:10 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-202

[PULL 2/2] ui/sdl2: fix segment fault caused by null pointer dereference

2020-05-15 Thread Gerd Hoffmann
From: Changbin Du I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via ssh forwarding even the window has been crated already. I am not sure whether this is a bug of SDL, but we'd better check it carefully. Signed-off-by: Changbin Du Message-id: 20200427132412.17909-1-chang

[PULL 1/2] ui: improve -show-cursor deprecation message

2020-05-15 Thread Gerd Hoffmann
Specifically explain what users should do in case they don't use -display yet and depend on the qemu picking the ui for them. Signed-off-by: Gerd Hoffmann Message-id: 20200407093617.10058-1-kra...@redhat.com --- softmmu/vl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v4 0/2] Makefile: libfdt: build only the strict necessary

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/15/20 9:56 AM, Claudio Fontana wrote: On 5/15/20 9:50 AM, Philippe Mathieu-Daudé wrote: Hi Claudio, On 5/14/20 9:38 PM, Claudio Fontana wrote: v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet) * changed the approach to leverage new upstream dtc Makefile, needs d

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2020-05-15 Thread Christophe Lyon
OK I wasn't aware that static linking was not supported by system emulators, thanks for the heads-up. I've updated our build scripts not to use static link, so you can close this PR unless you want to keep track that configure needs improvements. Thanks. -- You received this bug notification bec

[PATCH 0/2] tests: Remove unused bison/flex packages

2020-05-15 Thread Philippe Mathieu-Daudé
I was misguided by libdtc warnings, and thought bison/flex were required to build QEMU, so installed them in docker (and they also ended in the VM scripts). Claudio's series "libfdt: build only the strict necessary" even silents the warnings. Based-on: <20200514193811.6798-1-cfont...@suse.de> Ph

[PATCH 2/2] tests/vm: Remove flex/bison packages

2020-05-15 Thread Philippe Mathieu-Daudé
QEMU does use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/fedora | 1 - tests/vm/freebsd | 1 - tests/vm/netbsd | 1 - tests/vm/ubuntu.i386 | 2 +- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/vm/fedora b/tests/vm/fedora index bd9c

[PATCH 1/2] tests/docker: Remove flex/bison packages

2020-05-15 Thread Philippe Mathieu-Daudé
QEMU does use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/centos7.docker | 2 -- tests/docker/dockerfiles/centos8.docker | 2 -- tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 -- tests/docker/dockerfiles/debian10.docke

Re: Onboard audio devices and -audiodev none

2020-05-15 Thread Gerd Hoffmann
On Fri, May 15, 2020 at 09:06:20AM +0200, Markus Armbruster wrote: > Watch this: > > $ aarch64-softmmu/qemu-system-aarch64 -S -nodefaults -accel qtest > -display none -M vexpress-a15 -audiodev none,id=foo > audio: Device lm4549: audiodev default parameter is deprecated, please > specify

Re: [PATCH v5 2/7] dwc-hsotg (dwc2) USB host controller register definitions

2020-05-15 Thread Gerd Hoffmann
On Fri, May 15, 2020 at 10:07:41AM +0200, Philippe Mathieu-Daudé wrote: > On 5/12/20 8:48 AM, Paul Zimmerman wrote: > > Import the dwc-hsotg (dwc2) register definitions file from the > > Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the > > mainline Linux kernel, the only changes bein

[PATCH] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

2020-05-15 Thread Philippe Mathieu-Daudé
The Fuloong machine never had to use "audio/audio.h", remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_fulong2e.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c index ef02d54b33..05b9efa516 100644 --- a/hw/mips/mips_fulong2e.

Re: [PATCH 5/5] docs/system: Document Musca boards

2020-05-15 Thread Peter Maydell
On Fri, 15 May 2020 at 08:56, Philippe Mathieu-Daudé wrote: > > On 5/7/20 5:18 PM, Peter Maydell wrote: > > Provide a minimal documentation of the Musca boards. > > > > Signed-off-by: Peter Maydell > > --- /dev/null > > +++ b/docs/system/arm/musca.rst > > @@ -0,0 +1,31 @@ > > +Arm Musca boards (

Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 22:21 hat John Snow geschrieben: > > > On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote: > > Handlers don't need to modify the IDEDMA structure. > > Make it const. > > > > Signed-off-by: Philippe Mathieu-Daudé > > I'll trust your judgment. As long as it still compiles and pa

Re: [PATCH 1/3] docs/s390x: document the virtual css

2020-05-15 Thread Cornelia Huck
On Fri, 15 May 2020 09:04:13 +0200 Thomas Huth wrote: > On 05/05/2020 15.50, Cornelia Huck wrote: > > +Examples > > + > > + > > +* a virtio-net device, cssid/ssid/devno automatically assigned:: > > + > > +-device virtio-net-ccw > > + > > + In a Linux guest (without default devices a

Re: [PATCH 0/5] docs/system: Document some arm board models

2020-05-15 Thread Peter Maydell
On Fri, 15 May 2020 at 09:03, Philippe Mathieu-Daudé wrote: > However I'd rather see the board documentation in the source code, and > extract it when building. It'd be harder to miss updating the > documentation when modifying the code. I definitely agree in principle; but for the moment at leas

Re: [PATCH v2] bitmaps: Update maintainer

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 20:00 hat Eric Blake geschrieben: > Dirty bitmaps are important to incremental backups, including exposure > over NBD where I'm already maintainer. Also, I'm aware that lately I > have been doing as much code/review on bitmaps as John Snow who is > trying to scale back in order to

Re: [PULL 00/21] QOM patches for 2020-05-15

2020-05-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200515060424.18993-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515060424.18993-1-arm...@redhat.com Subject: [PULL 00/21] QOM patches for 2020-05-15 Type: series =

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-15 Thread Jon Doron
On 13/05/2020, Igor Mammedov wrote: Do you guys know perhaps which module is reading the ACPI configuration for VMBus? vmbus.sys / vmbkmcl.sys / winhv.sys? is it the kernel or HAL? I dont have any real HyperV Windows to play with... Roman, do you remember when is this information being used?

Re: [PATCH 1/3] docs/s390x: document the virtual css

2020-05-15 Thread Thomas Huth
On 15/05/2020 10.51, Cornelia Huck wrote: > On Fri, 15 May 2020 09:04:13 +0200 > Thomas Huth wrote: > >> On 05/05/2020 15.50, Cornelia Huck wrote: [...] >>> + >>> + This would not show up in a standard Linux guest. >> >> Ok ... and what happens if you use devno=0.0.1234 ? Will that then show >

Re: [PATCH 1/5] target/i386: implement special cases for fxtract

2020-05-15 Thread Alex Bennée
Joseph Myers writes: > The implementation of the fxtract instruction treats all nonzero > operands as normal numbers, so yielding incorrect results for invalid > formats, infinities, NaNs and subnormal and pseudo-denormal operands. > Implement appropriate handling of all those cases. > > Signed

Re: [PATCH 1/5] docs/system: Add 'Arm' to the Integrator/CP document title

2020-05-15 Thread Alex Bennée
Peter Maydell writes: > Add 'Arm' to the Integrator/CP document title, for consistency with > the titling of the other documentation of Arm devboard models > (versatile, realview). > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > docs/system/arm/integratorcp.rst | 4 ++-- >

Re: [PATCH 2/3] docs/s390x: document 3270

2020-05-15 Thread Cornelia Huck
On Fri, 15 May 2020 09:29:42 +0200 Thomas Huth wrote: > On 05/05/2020 15.50, Cornelia Huck wrote: > > Add some basic info how to use 3270 devices. > > > > Signed-off-by: Cornelia Huck > > --- > > docs/system/s390x/3270.rst | 32 > > docs/system/target-s390x.r

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2020-05-15 Thread Philippe Mathieu-Daudé
For the record, previous attempt to fix: https://www.mail-archive.com/qemu-devel@nongnu.org/msg624142.html and identical conclusion: https://www.mail-archive.com/qemu-devel@nongnu.org/msg624164.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [PATCH 1/2] tests/docker: Remove flex/bison packages

2020-05-15 Thread Claudio Fontana
On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > QEMU does use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé Hi Philippe, "does" or "does not"? Ciao, Claudio > --- > tests/docker/dockerfiles/centos7.docker | 2 -- > tests/docker/dockerfiles/centos8.docker

Re: [PATCH v10 14/14] iotests: use python logging for iotests.log()

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 21:54 hat John Snow geschrieben: > > > On 5/14/20 6:06 AM, Kevin Wolf wrote: > > Am 14.05.2020 um 08:24 hat John Snow geschrieben: > >> On 3/31/20 9:44 AM, Kevin Wolf wrote: > >>> Am 31.03.2020 um 02:00 hat John Snow geschrieben: > We can turn logging on/off globally instead

Re: [PATCH 0/5] docs/system: Document some arm board models

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/15/20 10:51 AM, Peter Maydell wrote: On Fri, 15 May 2020 at 09:03, Philippe Mathieu-Daudé wrote: However I'd rather see the board documentation in the source code, and extract it when building. It'd be harder to miss updating the documentation when modifying the code. I definitely agree

[PATCH v5 3/3] qemu-options: updates for abstract unix sockets

2020-05-15 Thread xiaoqiang zhao
add options documents changes for -chardev Signed-off-by: xiaoqiang zhao Reviewed-by: Daniel P. Berrangé --- qemu-options.hx | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e2dca8a4e9..e63cc1b4b4 100644 --- a/qemu-options.hx +

Re: proposal: deprecate -readconfig/-writeconfig

2020-05-15 Thread Gerd Hoffmann
Hi, > Sometimes I feel like a broken and impartial solution is really worse > than having none. If we don't truly support the read/write config > options, we shouldn't pretend that we do. > > Funneling users back to using the CLI is likely the better thing, even > with no replacement. > > I re

Re: [PATCH 5/5] docs/system: Document Musca boards

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/15/20 10:48 AM, Peter Maydell wrote: On Fri, 15 May 2020 at 08:56, Philippe Mathieu-Daudé wrote: On 5/7/20 5:18 PM, Peter Maydell wrote: Provide a minimal documentation of the Musca boards. Signed-off-by: Peter Maydell --- /dev/null +++ b/docs/system/arm/musca.rst @@ -0,0 +1,31 @@ +

[PATCH v5 2/3] tests/util-sockets: add abstract unix socket cases

2020-05-15 Thread xiaoqiang zhao
add cases to test tight and non-tight for abstract address type Signed-off-by: xiaoqiang zhao --- tests/test-util-sockets.c | 92 +++ 1 file changed, 92 insertions(+) diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c index 5fd947c7bf..2ca1e99

[PATCH v5 0/3] qemu-sockets: add abstract UNIX domain socket support

2020-05-15 Thread xiaoqiang zhao
qemu does not support abstract UNIX domain socket address. Add this ability to make qemu handy when abstract address is needed. Changes since v4: * fix typo and coding style problems v3 -> v4: * rebase on master * refine qapi document statement * use random names to avoid name clash in unit test

[PATCH v5 1/3] qemu-sockets: add abstract UNIX domain socket support

2020-05-15 Thread xiaoqiang zhao
unix_listen/connect_saddr now support abstract address types two aditional BOOL switches are introduced: tight: whether to set @addrlen to the minimal string length, or the maximum sun_path length. default is TRUE abstract: whether we use abstract address. default is FALSE cli example: -mo

Re: [PATCH v5 2/3] tests/util-sockets: add abstract unix socket cases

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 05:06:07PM +0800, xiaoqiang zhao wrote: > add cases to test tight and non-tight for abstract address type > > Signed-off-by: xiaoqiang zhao > --- > tests/test-util-sockets.c | 92 +++ > 1 file changed, 92 insertions(+) Reviewed-by: Dan

RE: [PATCH v4 0/6] colo-compare bugfixes

2020-05-15 Thread Zhang, Chen
Please update this series, I will queue it to COLO branch. Thanks Zhang Chen > -Original Message- > From: Lukas Straub > Sent: Monday, May 4, 2020 6:28 PM > To: qemu-devel > Cc: Zhang, Chen ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: [PATCH v4 0/6] c

Re: [PATCH 2/3] docs/s390x: document 3270

2020-05-15 Thread Thomas Huth
On 15/05/2020 11.00, Cornelia Huck wrote: > On Fri, 15 May 2020 09:29:42 +0200 > Thomas Huth wrote: > >> On 05/05/2020 15.50, Cornelia Huck wrote: >>> Add some basic info how to use 3270 devices. >>> >>> Signed-off-by: Cornelia Huck >>> --- >>> docs/system/s390x/3270.rst | 32

Re: [PATCH 3/3] docs/s390x: document vfio-ccw

2020-05-15 Thread Cornelia Huck
On Fri, 15 May 2020 09:54:44 +0200 Thomas Huth wrote: > On 05/05/2020 15.50, Cornelia Huck wrote: > > Add a basic example for passing a dasd via vfio-ccw. > > > > Signed-off-by: Cornelia Huck > > --- > > docs/system/s390x/vfio-ccw.rst | 58 ++ > > docs/system/ta

Re: [PATCH v5 1/7] raspi: add BCM2835 SOC MPHI emulation

2020-05-15 Thread Paul Zimmerman
On Fri, May 15, 2020 at 1:10 AM Philippe Mathieu-Daudé wrote: > On 5/12/20 8:48 AM, Paul Zimmerman wrote: > > Add BCM2835 SOC MPHI (Message-based Parallel Host Interface) > > emulation. It is very basic, only providing the FIQ interrupt > > needed to allow the dwc-otg USB host controller driver i

[PATCH v2 1/5] qemu/osdep: Document qemu_memalign() and friends

2020-05-15 Thread Philippe Mathieu-Daudé
Document allocator functions that require a specific de-allocator call. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- include/block/block.h | 4 include/qemu/osdep.h | 3 +++ include/sysemu/block-backend.h | 2 ++ 3 files changed, 9 insertions(+)

[PATCH v2 2/5] qemu/bitmap: Document bitmap_new() returned pointer

2020-05-15 Thread Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bitmap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 82a1d2f41f..0b390ff576 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/bitmap.h @@ -90,12 +

[PATCH v2 3/5] block/block: Document BlockSizes fields

2020-05-15 Thread Philippe Mathieu-Daudé
As it is not obvious for a block neophyte what means the 'log' value, document it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- include/block/block.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/block.h b/include/block/block.h i

[PATCH v2 0/5] block: Documentation improvment

2020-05-15 Thread Philippe Mathieu-Daudé
These patches contain documentation I wrote down while looking at the code. Supersedes: <20200504094641.4963-1-phi...@redhat.com> Philippe Mathieu-Daudé (5): qemu/osdep: Document qemu_memalign() and friends qemu/bitmap: Document bitmap_new() returned pointer block/block: Document BlockSizes

Re: [PATCH 1/2] tests/docker: Remove flex/bison packages

2020-05-15 Thread Philippe Mathieu-Daudé
On Fri, May 15, 2020 at 11:02 AM Claudio Fontana wrote: > > On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > > QEMU does use flex/bison packages. > > > > Signed-off-by: Philippe Mathieu-Daudé > > Hi Philippe, "does" or "does not"? Err... does NOT :/ > > Ciao, > > Claudio > > > --- > > test

[PATCH v2 4/5] sysemu/block-backend: Document blk_read()/blk_pwrite()

2020-05-15 Thread Philippe Mathieu-Daudé
The blk_read()/blk_pwrite() return value is not obvious, document it. Signed-off-by: Philippe Mathieu-Daudé --- v2: 's/ - /: /' (stefanha) --- include/sysemu/block-backend.h | 24 1 file changed, 24 insertions(+) diff --git a/include/sysemu/block-backend.h b/include/sys

Re: [PATCH 2/2] tests/vm: Remove flex/bison packages

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: QEMU does use flex/bison packages. "... does not use ..." (Thanks Claudio). Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/fedora | 1 - tests/vm/freebsd | 1 - tests/vm/netbsd | 1 - tests/vm/ubuntu.i386 | 2 +- 4 f

[PATCH v2 5/5] sysemu/block-backend: Document blk_get_max_iov() returned value

2020-05-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/block-backend.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index b693dfb8f0..7b12563c65 100644 --- a/include/sysemu/block-backend.h +++ b/include/sysemu/block-backend.

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2020-05-15 Thread Christophe Lyon
Maybe --static should be ignored for system emulators and accepted for user-mode emulators? That would enable to have a single build, otherwise if we want both, we'd need to configure & build QEMU twice. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH 0/1] virtio-9pfs: don't truncate response

2020-05-15 Thread Greg Kurz
On Thu, 14 May 2020 20:38:02 +0200 Christian Schoenebeck wrote: > The following patch reverts > SHA-1 16724a173049ac29c7b5ade741da93a0f46edff for the virtio backend. > > Greg, it is intended as a quick fix for > https://bugs.launchpad.net/bugs/1877688 at least for virtio, for the > case the appr

Re: [PATCH 1/3] docs/s390x: document the virtual css

2020-05-15 Thread Cornelia Huck
On Fri, 15 May 2020 10:57:26 +0200 Thomas Huth wrote: > On 15/05/2020 10.51, Cornelia Huck wrote: > > On Fri, 15 May 2020 09:04:13 +0200 > > Thomas Huth wrote: > > > >> On 05/05/2020 15.50, Cornelia Huck wrote: > [...] > >>> + > >>> + This would not show up in a standard Linux guest. >

Re: [PATCH 2/5] docs/system: Sort Arm board index into alphabetical order

2020-05-15 Thread Alex Bennée
Peter Maydell writes: > Sort the board index into alphabetical order. (Note that we need to > sort alphabetically by the title text of each file, which isn't the > same ordering as sorting by the filename.) Is it possible to leave an inline comment in the rst to this effect so no one mis-sort

Re: [PATCH 2/2] tests/vm: Remove flex/bison packages

2020-05-15 Thread Claudio Fontana
On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: > QEMU does use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/vm/fedora | 1 - > tests/vm/freebsd | 1 - > tests/vm/netbsd | 1 - > tests/vm/ubuntu.i386 | 2 +- > 4 files changed, 1 insertion(+), 4 de

Re: [PATCH 2/3] docs/s390x: document 3270

2020-05-15 Thread Cornelia Huck
On Fri, 15 May 2020 11:14:40 +0200 Thomas Huth wrote: > On 15/05/2020 11.00, Cornelia Huck wrote: > > On Fri, 15 May 2020 09:29:42 +0200 > > Thomas Huth wrote: > > > >> On 05/05/2020 15.50, Cornelia Huck wrote: > >>> Add some basic info how to use 3270 devices. > >>> > >>> Signed-off-by: Co

Re: [PATCH v4 3/3] iotests: modify test 040 to use JobRunner

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 21:37 hat John Snow geschrieben: > > > On 5/14/20 11:53 AM, Kevin Wolf wrote: > > Am 14.05.2020 um 04:25 hat John Snow geschrieben: > >> Instead of having somewhat reproduced it for itself. > >> > >> Signed-off-by: John Snow > > > > I think you should pass auto_dismiss=True to

Re: [PATCH 0/6] tests/fuzz: Review notes

2020-05-15 Thread Stefan Hajnoczi
On Thu, May 14, 2020 at 04:34:27PM +0200, Philippe Mathieu-Daudé wrote: > I took some code notes while testing Alex's toy. > Sending them as patches. > > Alex, I had theses issues while building following > docs/devel/fuzzing.txt: > > CC nbd/server.o > nbd/server.c:1937:1: error: unuse

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Lukas Straub
On Tue, 12 May 2020 09:54:58 +0100 Daniel P. Berrangé wrote: > On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > > On Mon, 11 May 2020 17:19:09 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Lukas Straub (lukasstra...@web.de) wrote: > > > > Add yank option, pass it to t

Re: [PATCH 3/5] docs/system: Document Arm Versatile Express boards

2020-05-15 Thread Alex Bennée
Peter Maydell writes: > Provide a minimal documentation of the Versatile Express boards > (vexpress-a9, vexpress-a15). > > Signed-off-by: Peter Maydell > --- > docs/system/arm/vexpress.rst | 60 > docs/system/target-arm.rst | 1 + > MAINTAINERS

Re: [PATCH v1 01/17] exec: Introduce ram_block_discard_set_(unreliable|required)()

2020-05-15 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > We want to replace qemu_balloon_inhibit() by something more generic. > Especially, we want to make sure that technologies that really rely on > RAM block discards to work reliably to run mutual exclusive with > technologies that break it. > > E.g., v

Re: [PATCH 4/5] docs/system: Document the various MPS2 models

2020-05-15 Thread Alex Bennée
Peter Maydell writes: > Add basic documentation of the MPS2 board models. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 2/2] tests/vm: Remove flex/bison packages

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/15/20 11:41 AM, Claudio Fontana wrote: On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote: QEMU does use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/fedora | 1 - tests/vm/freebsd | 1 - tests/vm/netbsd | 1 - tests/vm/ubuntu.i386 | 2 +- 4 f

Re: [PATCH 5/5] docs/system: Document Musca boards

2020-05-15 Thread Alex Bennée
Peter Maydell writes: > Provide a minimal documentation of the Musca boards. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 0/3] iotests: enable logging prior to notrun() invocation

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 22:16 hat John Snow geschrieben: > Hi, you can take just patch 1. Thanks, I'm doing that now. > patches 2-3 admittedly don't do a whole heck of a lot, because I > didn't realize that ./check discards *all* output from either stdout > or stderr. It doesn't discard it, but it comp

Re: [PATCH] trace/simple: Fix unauthorized enable

2020-05-15 Thread Stefan Hajnoczi
On Fri, May 15, 2020 at 09:00:21AM +0200, Markus Armbruster wrote: > diff --git a/trace/simple.c b/trace/simple.c > index fc7106ec49..906391538f 100644 > --- a/trace/simple.c > +++ b/trace/simple.c > @@ -302,10 +302,10 @@ static int st_write_event_mapping(void) > return 0; > } > > -void st_

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > On Tue, 12 May 2020 09:54:58 +0100 > Daniel P. Berrangé wrote: > > > On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > > > On Mon, 11 May 2020 17:19:09 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Luk

Re: [PATCH 2/3] docs/s390x: document 3270

2020-05-15 Thread Thomas Huth
On 15/05/2020 11.45, Cornelia Huck wrote: > On Fri, 15 May 2020 11:14:40 +0200 > Thomas Huth wrote: > >> On 15/05/2020 11.00, Cornelia Huck wrote: >>> On Fri, 15 May 2020 09:29:42 +0200 >>> Thomas Huth wrote: >>> On 05/05/2020 15.50, Cornelia Huck wrote: > Add some basic info how t

Re: [PATCH] hw/ide/ahci: Log lost IRQs

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 22:20 hat John Snow geschrieben: > > > On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote: > > One might find interesting to look at AHCI IRQs. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > hw/ide/ahci.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

[PATCH] Add a new PIIX option to control global PCI hot-plugging

2020-05-15 Thread Ani Sinha
A new option "acpi-pci-hotplug" is introduced for PIIX which will globally disable hot-plugging of both hot plugged and cold plugged PCI devices. This will prevent hot-plugging and hot un-plugging of devices from within Windows based guests using system tray. The patch has been tested on Windows 2

Re: [PATCH] Add a new PIIX option to control global PCI hot-plugging

2020-05-15 Thread Ani Sinha
Igor, here’s my attempt in cooking up a patch which disabled global ACPI hot plug. You said something about SHPC also adding AMLs when enabled but I could not figure out where that is being done. Please provide suggestions. > On May 15, 2020, at 3:36 PM, Ani Sinha wrote: > > A new option "acp

Re: QEMU 5.1: Can we require each new device/machine to provided a test?

2020-05-15 Thread Thomas Huth
On 07/04/2020 12.59, Philippe Mathieu-Daudé wrote: > Hello, > > Following Markus thread on deprecating unmaintained (untested) code > (machines) [1] and the effort done to gather the information shared in > the replies [2], and the various acceptance tests added, is it > feasible to require for th

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Lukas Straub
On Fri, 15 May 2020 11:04:13 +0100 Daniel P. Berrangé wrote: > On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > > On Tue, 12 May 2020 09:54:58 +0100 > > Daniel P. Berrangé wrote: > > > > > On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > > > > On Mon, 11 May 20

Re: [PULL 00/21] QOM patches for 2020-05-15

2020-05-15 Thread Peter Maydell
On Fri, 15 May 2020 at 07:07, Markus Armbruster wrote: > > The following changes since commit 013a18edbbc59cdad019100c7d03c0494642b74c: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200514' into staging (2020-05-14 > 16:17:55 +0100) > > are available in the Git re

Re: proposal: deprecate -readconfig/-writeconfig

2020-05-15 Thread Paolo Bonzini
On 15/05/20 07:54, Markus Armbruster wrote: >> I don't see QemuOpts going away anytime soon, but I do see more QMP/QAPI >> and less command line in the future as far as management tools are >> concerned. QemuOpts and HMP will remain for direct usage, for the >> foreseeable future. > > I'd prefer

Re: [PATCH Kernel v20 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

2020-05-15 Thread Yan Zhao
On Fri, May 15, 2020 at 02:07:44AM +0530, Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy conte

Re: QEMU 5.1: Can we require each new device/machine to provided a test?

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 12:11:17PM +0200, Thomas Huth wrote: > On 07/04/2020 12.59, Philippe Mathieu-Daudé wrote: > > Hello, > > > > Following Markus thread on deprecating unmaintained (untested) code > > (machines) [1] and the effort done to gather the information shared in > > the replies [2], a

Re: [PATCH 0/5] docs/system: Document some arm board models

2020-05-15 Thread Peter Maydell
On Fri, 15 May 2020 at 10:05, Philippe Mathieu-Daudé wrote: > Sphinx consumes docs/system/$arch/$machine.rst files committed to the > repository, and we don't need to build various qemu-system-arch to > generate the documentation. > > If you work on a particular board, you might end up only buildi

Re: [PATCH Kernel v20 0/8] Add UAPIs to support migration for VFIO devices

2020-05-15 Thread Yan Zhao
On Thu, May 14, 2020 at 09:32:06PM -0600, Alex Williamson wrote: > Hi Yan & Intel folks, > > I'm starting to run out of comments on this series, where are you with > porting GVT-g migration to this API? Are there remaining blocking > issues? Are we satisfied that the API is sufficient to support

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 12:14:47PM +0200, Lukas Straub wrote: > On Fri, 15 May 2020 11:04:13 +0100 > Daniel P. Berrangé wrote: > > > On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > > > On Tue, 12 May 2020 09:54:58 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Mon, May

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2020-05-15 Thread Peter Maydell
Some people want the system emulation to be statically linked, which is why we don't refuse to do it entirely; and static vs not changes a bunch of stuff like CFLAGS which we assume to be common across the whole build. So if you want some statically linked binaries and some not statically linked, t

Re: [PATCH v2 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

2020-05-15 Thread Kevin Wolf
Am 14.05.2020 um 15:08 hat Kevin Wolf geschrieben: > Am 29.04.2020 um 16:11 hat Max Reitz geschrieben: > > v1: https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg01245.html > > > > Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v2 > > Branch: https://git.xanclic.moe/XanCl

Re: QEMU 5.1: Can we require each new device/machine to provided a test?

2020-05-15 Thread Gerd Hoffmann
On Fri, May 15, 2020 at 12:11:17PM +0200, Thomas Huth wrote: > On 07/04/2020 12.59, Philippe Mathieu-Daudé wrote: > > Hello, > > > > Following Markus thread on deprecating unmaintained (untested) code > > (machines) [1] and the effort done to gather the information shared in > > the replies [2],

  1   2   3   4   5   >