Re: [PATCH v5 00/18] nvme: refactoring and cleanups

2020-05-11 Thread Philippe Mathieu-Daudé
Hi Klaus, On 5/11/20 8:25 AM, Klaus Jensen wrote: On May 5 07:48, Klaus Jensen wrote: From: Klaus Jensen Changes since v5 No functional changes, just updated Reviewed-by tags. Also, I screwed up the CC list when sending v4. Philippe and Keith, please add a Reviewed-by to

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

2020-05-11 Thread Philippe Mathieu-Daudé
On 4/14/20 12:00 PM, KONRAD Frederic wrote: Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit : [Cc'ing Peter] On 4/13/20 12:12 PM, KONRAD Frederic wrote: Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit : On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (7):

[PATCH] block/replication.c: Avoid cancelling the job twice

2020-05-11 Thread Lukas Straub
If qemu in colo secondary mode is stopped, it crashes because s->backup_job is canceled twice: First with job_cancel_sync_all() in qemu_cleanup() and then in replication_stop(). Fix this by assigning NULL to s->backup_job when the job completes so replication_stop() and replication_do_checkpoint()

Re: [PATCH v5 00/18] nvme: refactoring and cleanups

2020-05-11 Thread Klaus Jensen
On May 11 09:00, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > On 5/11/20 8:25 AM, Klaus Jensen wrote: > > On May 5 07:48, Klaus Jensen wrote: > > > From: Klaus Jensen > > > > > > Changes since v5 > > > > > > No functional changes, just updated Reviewed-by tags. Also, I screwed

Re: Abort in mch_update_pciexbar

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/11/20 8:19 AM, Philippe Mathieu-Daudé wrote: On 5/11/20 6:59 AM, Alexander Bulekov wrote: Hello, While fuzzing, I found an input that triggers an assertion failure in mch_update_pciexbar: #6 0x7f38d387c55a in abort /build/glibc-GwnBeO/glibc-2.30/stdlib/abort.c:79:7 #7 0x55c27e94ffd0 in m

Re: [PATCH 0/2] hw/block/nvme: fixes for interrupt behavior

2020-05-11 Thread Philippe Mathieu-Daudé
+ Michael & Marcel for MSIX, and ping to Keith :) On 5/5/20 10:36 PM, Klaus Jensen wrote: From: Klaus Jensen Klaus Jensen (2): hw/block/nvme: fix pin-based interrupt behavior hw/block/nvme: allow use of any valid msix vector hw/block/nvme.c | 14 +- hw/block/nvme.h | 2 +

Re: [PATCH 11/12] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32

2020-05-11 Thread Aleksandar Markovic
пон, 11. мај 2020. у 08:30 Philippe Mathieu-Daudé је написао/ла: > > On 5/11/20 8:17 AM, Aleksandar Markovic wrote: > > нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> Describe some Config registers fields with the registerfields > >> API. Use the FIELD_DP32() macro

Re: Abort in mch_update_pciexbar

2020-05-11 Thread Michael S. Tsirkin
On Mon, May 11, 2020 at 09:10:48AM +0200, Philippe Mathieu-Daudé wrote: > On 5/11/20 8:19 AM, Philippe Mathieu-Daudé wrote: > > On 5/11/20 6:59 AM, Alexander Bulekov wrote: > > > Hello, > > > While fuzzing, I found an input that triggers an assertion failure in > > > mch_update_pciexbar: > > > >

Re: Abort in mch_update_pciexbar

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/11/20 9:39 AM, Michael S. Tsirkin wrote: On Mon, May 11, 2020 at 09:10:48AM +0200, Philippe Mathieu-Daudé wrote: On 5/11/20 8:19 AM, Philippe Mathieu-Daudé wrote: On 5/11/20 6:59 AM, Alexander Bulekov wrote: Hello, While fuzzing, I found an input that triggers an assertion failure i

Re: Patches for ui/gtk and ui/sdl

2020-05-11 Thread Howard Spoelstra
On Sun, May 10, 2020 at 8:42 PM Volker Rümelin wrote: > It's rather difficult to test qemu patches in guests on Windows with > important keys missing. These patches mainly fix the guest keyboard on > Windows. > > With best regards, > Volker > Hi Volker, Excellent patch! I tested this on Windows

Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name

2020-05-11 Thread Aleksandar Markovic
пон, 11. мај 2020. у 08:52 chen huacai је написао/ла: > > Hi, Philippe and Alexandar, > > On Mon, May 11, 2020 at 2:38 PM Philippe Mathieu-Daudé > wrote: > > > > On 5/11/20 8:21 AM, Aleksandar Markovic wrote: > > > пон, 11. мај 2020. у 03:11 chen huacai је > > > написао/ла: > > >> > > >> Hi, P

Re: [PATCH] xen: fix build without pci passthrough

2020-05-11 Thread Roger Pau Monné
Ping? On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > has_igd_gfx_passthru is only available when QEMU is built with > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common > code without checking if it's available. > > Fixes: 46472d82322d0 ('xen: convert "-machine

[PATCH v2 1/4] memory: Simplify memory_region_do_writeback()

2020-05-11 Thread Philippe Mathieu-Daudé
mr->dirty_log_mask tells if dirty tracking has been enabled, not if the page is dirty. It would always be true during live migration and when running on TCG, but otherwise it would always be false. As the value of mr->dirty_log_mask does not matter, remove the check. Cc: Beata Michalska Suggested

[PATCH v2 0/4] memory: Add memory_region_sync() & make NVMe emulated device generic

2020-05-11 Thread Philippe Mathieu-Daudé
Remove the pointless dirty_log_mask check before msync'ing, let the NVMe emulated device be target-agnostic. Supersedes: <20200508062456.23344-1-phi...@redhat.com> Philippe Mathieu-Daudé (4): memory: Simplify memory_region_do_writeback() memory: Rename memory_region_do_writeback() -> memory_r

[PATCH v2 3/4] hw/block: Let the NVMe emulated device be target-agnostic

2020-05-11 Thread Philippe Mathieu-Daudé
Now than the non-target specific memory_region_sync() function is available, use it to make this device target-agnostic. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.c| 6 ++ hw/block/Makefile.objs | 2 +- 2 files changed, 3 insertions(+), 5

[PATCH v2 2/4] memory: Rename memory_region_do_writeback() -> memory_region_sync()

2020-05-11 Thread Philippe Mathieu-Daudé
We usually use '_do_' for internal functions. Rename memory_region_do_writeback() as memory_region_sync() to better reflect what it does. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 13 +++-- memory.c | 2 +- target/arm/

[PATCH v2 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync()

2020-05-11 Thread Philippe Mathieu-Daudé
Rename qemu_ram_writeback() as qemu_ram_msync() to better match what it does. Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 4 ++-- exec.c | 2 +- memory.c| 3 +-- 3 files changed, 4 insertions(+), 5 deletions(

Re: [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name

2020-05-11 Thread Aleksandar Markovic
пон, 11. мај 2020. у 10:12 Aleksandar Markovic је написао/ла: > > пон, 11. мај 2020. у 08:52 chen huacai је написао/ла: > > > > Hi, Philippe and Alexandar, > > > > On Mon, May 11, 2020 at 2:38 PM Philippe Mathieu-Daudé > > wrote: > > > > > > On 5/11/20 8:21 AM, Aleksandar Markovic wrote: > > >

[PATCH] scripts/tracetool: Update maintainer email address

2020-05-11 Thread Philippe Mathieu-Daudé
There is an effort in progress to generate a QEMU Python package. As I'm not sure this old email is still valid, update it to not produce package with broken maintainer email. Patch created mechanically by running: $ sed -i 's,\(__email__ *= "\)stefa...@linux.vnet.ibm.com",\1stefa...@redhat.com

RE: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-05-11 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 8, 2020 3:56 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in > compare_chr_send > > On Fri, 8 May

RE: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-11 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 8, 2020 12:09 AM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in > complete and finalize > > On T

RE: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Auger Eric > Sent: Monday, May 11, 2020 12:26 PM > To: Bharat Bhushan ; eric.auger@gmail.com; > qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-phili...@linaro.org; pet...@redhat.com; > arm...@redhat.c

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-11 Thread zkrx
** Summary changed: - Win10 guest unsuable after a few minutes + Win10 guest unusable after a few minutes -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877716 Title: Win10 guest unusable after a

[Bug 1860742] Re: xv6 Bootloop

2020-05-11 Thread Manavjeet Singh
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** No longer affects: qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860742 Title: xv6 Bootloop Status in

Re: [PATCH 2/4] device-core: use RCU for list of childs of a bus

2020-05-11 Thread Maxim Levitsky
On Mon, 2020-05-04 at 11:41 +0100, Stefan Hajnoczi wrote: > On Thu, Apr 16, 2020 at 11:36:22PM +0300, Maxim Levitsky wrote: > > @@ -90,9 +92,13 @@ static void bus_reset_child_foreach(Object *obj, > > ResettableChildCallback cb, > > BusState *bus = BUS(obj); > > BusChild *kid; > > > > -

Re: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Auger Eric
Hi Bharat, On 5/11/20 10:42 AM, Bharat Bhushan wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric >> Sent: Monday, May 11, 2020 12:26 PM >> To: Bharat Bhushan ; eric.auger@gmail.com; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; >> m...@redhat.co

RE: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-11 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Saturday, May 9, 2020 8:21 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > ; Dr . David Alan Gilbert > Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that >

Re: [PATCH 0/3] tcg/s390: Support host vector operations

2020-05-11 Thread David Hildenbrand
On 08.05.20 17:57, Richard Henderson wrote: > I've had this floating around on a branch for a while now > It is able to run arm sve tests under qemu, but I have not > been able to test it against real hardware. You can run qemu-system-arm under qemu-system-s390 with vx=on ;) I'll try to give this

Re: [PATCH v2 2/5] vhost: introduce wrappers to set guest notifiers for virtio device

2020-05-11 Thread Dima Stepanov
On Mon, May 11, 2020 at 11:03:01AM +0800, Jason Wang wrote: > > On 2020/4/30 下午9:36, Dima Stepanov wrote: > >Introduce new wrappers to set/reset guest notifiers for the virtio > >device in the vhost device module: > > vhost_dev_assign_guest_notifiers > > ->set_guest_notifiers(..., ..., true)

[PATCH] ppc/pnv: Add definitions for interrupts occurring in power-saving mode

2020-05-11 Thread Cédric Le Goater
If an interrupt occurred when the thread was in power-saving mode, bits [42:45] of SRR1 indicate the exception that caused exit from power-saving mode. bits [46:47] of SRR1 indicate the power-saving mode in which the thread was when the interrupt occured. Signed-off-by: Cédric Le Goater --- tar

Re: [PATCH v3 2/9] qemu-img: Fix stale comments on doc location

2020-05-11 Thread Max Reitz
On 08.05.20 20:03, Eric Blake wrote: > Missed in commit e13c59fa. > > Signed-off-by: Eric Blake > --- > qemu-img.c | 2 +- > qemu-img-cmds.hx | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-11 Thread Cédric Le Goater
On 5/7/20 7:26 PM, Greg Kurz wrote: > It is the job of the ppc_radix64_get_fully_qualified_addr() function > which is called at the beginning of ppc_radix64_xlate() to set both > lpid *and* pid. It doesn't buy us anything to initialize them first. > > Worse, a bug in ppc_radix64_get_fully_qualifie

Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

2020-05-11 Thread Peter Maydell
On Sat, 9 May 2020 at 14:18, Lukas Straub wrote: > Hi, > Why not simply add slow tag to the test. Like: > :avocado: tags=slow > > The slow tests can then be skipped with > $ make check-acceptance AVOCADO_TAGS='-t -slow' Is it possible to have the default be "do the fast stuff" and only do the slo

Re: [PATCH v2 4/5] vhost: check vring address before calling unmap

2020-05-11 Thread Dima Stepanov
On Mon, May 11, 2020 at 11:05:58AM +0800, Jason Wang wrote: > > On 2020/4/30 下午9:36, Dima Stepanov wrote: > >Since disconnect can happen at any time during initialization not all > >vring buffers (for instance used vring) can be intialized successfully. > >If the buffer was not initialized then vh

Re: [Bug 1877716] [NEW] Win10 guest unsuable after a few minutes

2020-05-11 Thread Stefan Hajnoczi
On Sat, May 9, 2020 at 9:16 AM Xavier <1877...@bugs.launchpad.net> wrote: > > Public bug reported: > > On Arch Linux, the recent qemu package update seems to misbehave on some > systems. In my case, my Windows 10 guest runs fine for around 5 minutes > and then start to get really sluggish, even unr

Re: [PATCH v4 04/10] tests/vm: add --boot-console switch

2020-05-11 Thread Alex Bennée
Robert Foley writes: > Added ability to view console during boot via > --boot-console switch to basevm.py. This helps debug issues that occur > during the boot sequence. > Also added a new special variable to vm-build: > BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Hmm

Re: is there any way to make qemu stop at the very first instruction of the emulation process and wait for gdb connect?

2020-05-11 Thread Peter Maydell
On Sun, 10 May 2020 at 10:18, tugouxp <13824125...@163.com> wrote: > > is there any way to make qemu stop at the very first instruction of the > emulation process and wait for gdb connect? Yes: use the '-S' option (as well as the usual option to set up a gdbstub connection). See the documentatio

Re: [PATCH v4 06/10] tests/vm: allow wait_ssh() to specify command

2020-05-11 Thread Alex Bennée
Robert Foley writes: > This allows for waiting for completion of arbitrary commands. > > Signed-off-by: Robert Foley Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 00/10] tests/vm: Add support for aarch64 VMs

2020-05-11 Thread Alex Bennée
Robert Foley writes: > This is version 4 of the patch series to > add support for aarch64 VMs in the vm-build infrastructure. > - Ubuntu 18.04 aarch64 VM > - CentOS 8 aarch64 VM > > V3: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg02805.html > > Changes in V4. > - Removed the ta

Re: [PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps

2020-05-11 Thread Max Reitz
On 08.05.20 20:03, Eric Blake wrote: > Upcoming patches will enhance bitmap support in qemu-img, but in doing > so, it turns out to be nice to suppress output when bitmaps make no > sense (such as on a qcow2 v2 image). Add a hook to make this easier > to query. > > In the future, when we improve

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-11 Thread Dima Stepanov
On Mon, May 11, 2020 at 11:15:53AM +0800, Jason Wang wrote: > > On 2020/4/30 下午9:36, Dima Stepanov wrote: > >If vhost-user daemon is used as a backend for the vhost device, then we > >should consider a possibility of disconnect at any moment. If such > >disconnect happened in the vhost_migration_l

Re: [PATCH 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub

2020-05-11 Thread Greg Kurz
On Mon, 11 May 2020 11:43:48 +1000 David Gibson wrote: > On Thu, May 07, 2020 at 07:27:15PM +0200, Greg Kurz wrote: > > gdbstub shouldn't silently change guest visible state when doing address > > translation. While here drop a not very useful comment. > > > > This was found while reading the co

Re: [PATCH 1/2] migration/rdma: fix potential nullptr access in rdma_start_incoming_migration

2020-05-11 Thread Peter Maydell
On Fri, 8 May 2020 at 08:53, Juan Quintela wrote: > > Pan Nengyuan wrote: > > 'rdma' is NULL when taking the first error branch in > > rdma_start_incoming_migration. > > And it will cause a null pointer access in label 'err'. Fix that. > > > > Fixes: 59c59c67ee6b0327ae932deb303caa47919aeb1e > >

Re: [PATCH v4 08/10] hw/core/resettable: add support for warm reset

2020-05-11 Thread Damien Hedde
Hi Philippe, On 5/10/20 10:17 PM, Philippe Mathieu-Daudé wrote: > Hi Damien, > > On 8/21/19 6:33 PM, Damien Hedde wrote: >> Add the RESET_TYPE_WARM reset type. >> Expand the actual implementation to support several types. >> >>     /** >>    * ResetType: >> - * Types of reset. >> + * Types of r

Re: [PATCH v2] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-11 Thread Andrew Melnichenko
Yo, > So I think we should implement the 82574l behavior? Well, as I understand it - its already implemented. I've added ICR clearance if ICR & IMS(also need to add ICR_ASSERTED check, my bad, I'll prepare new patch). At first, I had hacks to clear 'msi_causes_pending' at 'e1000e_core_set_link_

Re: [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot

2020-05-11 Thread Aleksandar Markovic
нед, 10. мај 2020. у 23:01 Philippe Mathieu-Daudé је написао/ла: > > The PMON firmware behave differently regarding it is run > after a cold/warm reset. A simple bit flip fix the issue, > however we need to know the type of reset to set it. > Currently QEMU only supports COLD reset. > > This serie

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-11 Thread Dima Stepanov
On Sun, May 10, 2020 at 08:03:39PM -0400, Raphael Norwitz wrote: > On Thu, May 7, 2020 at 11:35 AM Dima Stepanov wrote: > > > > What do you think? > > > > Apologies - I tripped over the if (dev->started && r < 0) check. > Never-mind my point with race conditions and failing migrations. > > Rathe

Re: [PATCH 07/11] target/s390x/helper: Clean ifdef'ry

2020-05-11 Thread David Hildenbrand
On 09.05.20 15:09, Philippe Mathieu-Daudé wrote: > All this code is guarded checking CONFIG_USER_ONLY definition. > Drop the duplicated checks. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Suspicious ifdef'ry in s390_handle_wait() from commit 83f7f32901c. Reviewed-by: David Hildenbrand --

Re: [Bug 1877716] [NEW] Win10 guest unsuable after a few minutes

2020-05-11 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 10:12 AM Stefan Hajnoczi wrote: > On Sat, May 9, 2020 at 9:16 AM Xavier <1877...@bugs.launchpad.net> wrote: > > > > Public bug reported: > > > > On Arch Linux, the recent qemu package update seems to misbehave on some > > systems. In my case, my Windows 10 guest runs fine f

Re: [PATCH 03/11] sysemu/tcg: Only declare tcg_allowed when TCG is available

2020-05-11 Thread Edgar E. Iglesias
On Sat, May 09, 2020 at 03:09:02PM +0200, Philippe Mathieu-Daudé wrote: > When TCG is not available, the tcg_allowed variable does not exist. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/tcg.h | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH 04/11] sysemu/hvf: Only declare hvf_allowed when HVF is available

2020-05-11 Thread Edgar E. Iglesias
On Sat, May 09, 2020 at 03:09:03PM +0200, Philippe Mathieu-Daudé wrote: > When HVF is not available, the tcg_allowed variable does not exist. Typo in commit message tcg_allowed -> hvf_allowed. With that fixed: Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v3 09/10] target/s390x: Use tcg_gen_gvec_rotl{i,s,v}

2020-05-11 Thread David Hildenbrand
On 08.05.20 17:10, Richard Henderson wrote: > Merge VERLL and VERLLV into op_vesv and op_ves, alongside > all of the other vector shift operations. > > Cc: David Hildenbrand > Signed-off-by: Richard Henderson RHEL8 boots just fine and this survives my (still not upstream yet) tests/tcg: ta

Re: [PATCH v3 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-11 Thread Max Reitz
On 08.05.20 20:03, Eric Blake wrote: > The next patch will split blockdev.c, which will require accessing > some previously-static functions from more than one .c file. But part > of promoting a function to public is picking a naming scheme that does > not reek of exposing too many internals (two

Re: [PATCH v3] aspeed: Add boot stub for smp booting

2020-05-11 Thread Peter Maydell
On Fri, 8 May 2020 at 15:27, Cédric Le Goater wrote: > Indeed, with OpenBMC kernel v5.4.32-260-g7dc9442bbe7d and wfi (patch v3), > > [0.045214] smp: Bringing up secondary CPUs ... > [1.178127] CPU1: failed to come online > [1.187309] smp: Brought up 1 node, 1 CPU > [

Re: [PATCH v2 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync()

2020-05-11 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 10:17:19AM +0200, Philippe Mathieu-Daudé wrote: > Rename qemu_ram_writeback() as qemu_ram_msync() to better > match what it does. Based on Juan's comment in the other email thread I think this commit description could be expanded. Let's explain the rationale for this change

Re: [PATCH 0/3] tcg/s390: Support host vector operations

2020-05-11 Thread David Hildenbrand
On 11.05.20 10:50, David Hildenbrand wrote: > On 08.05.20 17:57, Richard Henderson wrote: >> I've had this floating around on a branch for a while now >> It is able to run arm sve tests under qemu, but I have not >> been able to test it against real hardware. > > You can run qemu-system-arm under

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

2020-05-11 Thread Kirti Wankhede
On 5/5/2020 10:07 AM, Alex Williamson wrote: On Tue, 5 May 2020 04:48:14 +0530 Kirti Wankhede wrote: On 3/26/2020 3:33 AM, Alex Williamson wrote: On Wed, 25 Mar 2020 02:39:07 +0530 Kirti Wankhede wrote: Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy func

Re: [PATCH 02/11] sysemu/accel: Restrict machine methods to system-mode

2020-05-11 Thread Edgar E. Iglesias
On Sat, May 09, 2020 at 03:09:01PM +0200, Philippe Mathieu-Daudé wrote: > Restrict init_machine(), setup_post() and has_memory() > to system-mode. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/accel.h | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH 1/3] tcg/s390: Change FACILITY representation

2020-05-11 Thread David Hildenbrand
On 08.05.20 17:57, Richard Henderson wrote: > We will shortly need to be able to check facilities > beyond the first 64. Instead of explicitly masking > against s390_facilities, create a FACILITY macro > that indexes an array. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.h

Re: [PATCH 2/3] tcg/s390: Merge TCG_AREG0 and TCG_REG_CALL_STACK into TCGReg

2020-05-11 Thread David Hildenbrand
On 08.05.20 17:57, Richard Henderson wrote: > They are rightly values in the same enumeration. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.h | 28 +++- > 1 file changed, 7 insertions(+), 21 deletions(-) > > diff --git a/tcg/s390/tcg-target.h b/tcg/s3

Re: [PATCH 0/2] hw/block/nvme: fixes for interrupt behavior

2020-05-11 Thread Klaus Jensen
On May 11 09:09, Philippe Mathieu-Daudé wrote: > + Michael & Marcel for MSIX, > and ping to Keith :) > I'll await some feedback here before moving these fixes into my "nvme: refactoring and cleanups" series. Not sure if this should go directly to master or block-next.

Re: [PATCH v3 0/1] target/arm: Remove access_el3_aa32ns_aa64any()

2020-05-11 Thread Peter Maydell
On Tue, 5 May 2020 at 15:17, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Hi, > > Laurent reported hitting the assert in access_el3_aa32ns() > when accessing 32-bit versions of some of the virtualization > regs when EL3 is 64-bit. > > I think we got this wrong back then and it seems

Re: [PATCH] aspeed: Support AST2600A1 silicon revision

2020-05-11 Thread Peter Maydell
On Mon, 4 May 2020 at 10:37, Joel Stanley wrote: > > There are minimal differences from Qemu's point of view between the A0 > and A1 silicon revisions. > > As the A1 exercises different code paths in u-boot it is desirable to > emulate that instead. > > Signed-off-by: Joel Stanley Applied to t

Re: [PATCH] aspeed: sdmc: Implement AST2600 locking behaviour

2020-05-11 Thread Peter Maydell
On Tue, 5 May 2020 at 10:01, Joel Stanley wrote: > > The AST2600 handles this differently with the extra 'hardlock' state, so > move the testing to the soc specific class' write callback. > > Signed-off-by: Joel Stanley > --- Applied to target-arm.next, thanks. -- PMM

Re: [PATCH v3 1/2] io/channel: fix crash when qio_channel_readv_all return 0

2020-05-11 Thread Daniel P . Berrangé
On Fri, May 08, 2020 at 08:42:22PM +0800, Li Feng wrote: > Marc-André Lureau 于2020年5月8日周五 下午8:32写道: > > > > Hi > > > > On Fri, May 8, 2020 at 7:14 AM Li Feng wrote: > > > > > > Root cause: > > > From `man recvmsg`, the RETURN VALUE says: > > > These calls return the number of bytes received, or

Re: [PULL v2 0/1] Merge tpm 2020/05/08 v2

2020-05-11 Thread Peter Maydell
On Fri, 8 May 2020 at 21:47, Stefan Berger wrote: > > This PR submits a fix that changes improperly used 'FALSE' to 'false'. > > The following changes since commit c88f1ffc19e38008a1c33ae039482a860aa7418c: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2020-0

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-11 Thread post-factum
Stefan, Arch explicitly disabled io_uring for qemu after discovering this bug. That's why you don't see it enabled in the recent version. 5.0.0-6 doesn't have io_uring enabled. 5.0.0-5 does have it, and you can grab it here: [1]. [1] https://archive.archlinux.org/packages/q/qemu/qemu-5.0.0-5-x86

Re: [PATCH 1/2] When del child, next_child_index need to subtract 1. Otherwise, the index will get bigger and bigger.

2020-05-11 Thread Alberto Garcia
On Mon 11 May 2020 12:00:30 PM CEST, quwei...@huayun.com wrote: > diff --git a/block/quorum.c b/block/quorum.c > index 6d7a56b..a8272fe 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -1096,6 +1096,7 @@ static void quorum_del_child(BlockDriverState *bs, > BdrvChild *child, > memmove

Re: [PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-11 Thread Greg Kurz
On Mon, 11 May 2020 11:07:06 +0200 Cédric Le Goater wrote: > On 5/7/20 7:26 PM, Greg Kurz wrote: > > It is the job of the ppc_radix64_get_fully_qualified_addr() function > > which is called at the beginning of ppc_radix64_xlate() to set both > > lpid *and* pid. It doesn't buy us anything to initi

Re: [PATCH v3 5/9] blockdev: Split off basic bitmap operations for qemu-img

2020-05-11 Thread Max Reitz
On 08.05.20 20:03, Eric Blake wrote: > Upcoming patches want to add some basic bitmap manipulation abilities > to qemu-img. But blockdev.o is too heavyweight to link into qemu-img > (among other things, it would drag in block jobs and transaction > support - qemu-img does offline manipulation, whe

Re: [PATCH v6 4/8] gpiolib: Add support for GPIO lookup by line name

2020-05-11 Thread Geert Uytterhoeven
Hi Linus, On Thu, Mar 26, 2020 at 10:18 PM Linus Walleij wrote: > On Tue, Mar 24, 2020 at 2:57 PM Geert Uytterhoeven > wrote: > > Currently a GPIO lookup table can only refer to a specific GPIO by a > > tuple, consisting of a GPIO controller label and a GPIO offset inside > > the controller. > >

Re: [PATCH 02/11] sysemu/accel: Restrict machine methods to system-mode

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:01 +0200 Philippe Mathieu-Daudé wrote: > Restrict init_machine(), setup_post() and has_memory() > to system-mode. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/accel.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Cornelia Huck

Re: device hotplug & file handles

2020-05-11 Thread Michal Privoznik
On 5/7/20 4:49 PM, Gerd Hoffmann wrote: Hi, For usb device pass-through (aka -device usb-host) it would be very useful to pass file handles from libvirt to qemu. The workflow would change from ... (1) libvirt enables access to /dev/usb/$bus/$dev (2) libvirt passes $bus + $dev (using h

Re: [PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_range

2020-05-11 Thread Peter Maydell
On Fri, 8 May 2020 at 17:57, Richard Henderson wrote: > On 5/8/20 9:13 AM, Peter Maydell wrote: > > We've gone round this multiple times now so I feel like > > I must be missing something here. > > While probe_access() has a size parameter, probe_access_flags() does not. > > For probe_access_inter

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

2020-05-11 Thread Kirti Wankhede
On 5/9/2020 11:01 AM, Yan Zhao wrote: On Wed, Mar 25, 2020 at 05:09:07AM +0800, Kirti Wankhede wrote: Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-copy

Re: [PATCH v8 03/74] cpu: introduce cpu_mutex_lock/unlock

2020-05-11 Thread Alex Bennée
Robert Foley writes: > From: "Emilio G. Cota" > > The few direct users of &cpu->lock will be converted soon. > > The per-thread bitmap introduced here might seem unnecessary, > since a bool could just do. However, once we complete the > conversion to per-vCPU locks, we will need to cover the u

Re: [PATCH 03/11] sysemu/tcg: Only declare tcg_allowed when TCG is available

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:02 +0200 Philippe Mathieu-Daudé wrote: > When TCG is not available, the tcg_allowed variable does not exist. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/tcg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck

Re: [PATCH 04/11] sysemu/hvf: Only declare hvf_allowed when HVF is available

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:03 +0200 Philippe Mathieu-Daudé wrote: > When HVF is not available, the tcg_allowed variable does not exist. s/tcg_allowed/hvf_allowed/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/hvf.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(

Re: [PATCH v8 17/74] hw/semihosting: convert to cpu_halted_set

2020-05-11 Thread Alex Bennée
Robert Foley writes: > Signed-off-by: Robert Foley Reviewed-by: Alex Bennée > --- > hw/semihosting/console.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c > index 6346bd7f50..f70085f3c1 100644 > --- a/hw/sem

Re: [PATCH v5 00/19] target/arm: sve load/store improvements

2020-05-11 Thread Peter Maydell
On Fri, 8 May 2020 at 16:44, Richard Henderson wrote: > > Version 5 splits patch 4, as requested during review. > The patches remaining unreviewed are: > > 0004-accel-tcg-Adjust-probe_access-call-to-page_check_.patch > 0005-accel-tcg-Add-probe_access_flags.patch Applied to target-arm.next, thanks

Re: QEMU + HVF Fails to start OVMF.fd (hang before displaying logo)

2020-05-11 Thread Philippe Mathieu-Daudé
Hi Olivier, Cc'ing the HVF maintainers. On 5/11/20 12:26 PM, LAHAYE Olivier wrote: Hi, I’m facing a similar problem to this one, but I’m unable to find any solution via google. https://www.mail-archive.com/qemu-discuss@nongnu.org/msg04372.html I’m trying to run an EFI BIOS using qemu. *

Re: [PATCH 06/11] target/s390x: Only compile decode_basedisp() on system-mode

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:05 +0200 Philippe Mathieu-Daudé wrote: > The decode_basedisp*() methods are only used in ioinst.c, > which is only build in system-mode emulation. I/O instructions are privileged, and other S instructions are decoded elsewhere. > > Signed-off-by: Philippe Mathieu-Daud

Re: [PATCH v8 25/74] riscv: convert to cpu_halted

2020-05-11 Thread Alex Bennée
Robert Foley writes: > From: "Emilio G. Cota" > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Alistair Francis > Reviewed-by: Palmer Dabbelt You can drop Cc: lines fron patches once you have an a-b or r-b tag from the person in question. They are basically a

Re: [PATCH 07/11] target/s390x/helper: Clean ifdef'ry

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:06 +0200 Philippe Mathieu-Daudé wrote: > All this code is guarded checking CONFIG_USER_ONLY definition. > Drop the duplicated checks. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Suspicious ifdef'ry in s390_handle_wait() from commit 83f7f32901c. > --- > target/s3

Re: [PATCH 0/4] hw/arm/nrf51: Extend tracing

2020-05-11 Thread Peter Maydell
On Mon, 4 May 2020 at 08:28, Philippe Mathieu-Daudé wrote: > > Few patches while playing with the Zephyr Project. > > - better display of unimplemented peripheral accesses, > - better display of timers use. > > Philippe Mathieu-Daudé (4): > hw/arm/nrf51: Add NRF51_PERIPHERAL_SIZE definition >

Re: [PATCH v3 0/5] target/arm: Restrict TCG cpus to TCG accel

2020-05-11 Thread Peter Maydell
On Mon, 4 May 2020 at 18:24, Philippe Mathieu-Daudé wrote: > > These are the uncontroversial patches from "Support disabling > TCG on ARM (part 2)" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg689168.html > > The other patches are blocked by the "accel: Allow targets to > use Kconfig" s

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: > As these declarations are restricted to !CONFIG_USER_ONLY in > helper.c, only declare them when system-mode emulation is used. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/s390x/internal.h | 11 ++- > 1 file

Re: [RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally

2020-05-11 Thread Peter Maydell
On Tue, 5 May 2020 at 10:59, Philippe Mathieu-Daudé wrote: > > I can't find proper documentation or datasheet, but it is likely > a MMIO mapped serial device mapped in the 0x8000..0x8000 > range belongs to the SoC address space, thus is always mapped in > the memory bus. > Map the devices

Re: [PATCH v3] aspeed: Add support for the sonorapass-bmc board

2020-05-11 Thread Peter Maydell
On Wed, 6 May 2020 at 19:32, Patrick Williams wrote: > > Sonora Pass is a 2 socket x86 motherboard designed by Facebook > and supported by OpenBMC. Strapping configuration was obtained > from hardware and i2c configuration is based on dts found at: > > https://github.com/facebook/openbmc-linux/bl

Re: [PATCH 3/4] device-core: use atomic_set on .realized property

2020-05-11 Thread Maxim Levitsky
On Mon, 2020-05-04 at 13:22 +0200, Paolo Bonzini wrote: > On 04/05/20 12:45, Stefan Hajnoczi wrote: > > > @@ -983,7 +983,7 @@ static void device_set_realized(Object *obj, bool > > > value, Error **errp) > > > } > > > > > > assert(local_err == NULL); > > > -dev->realized = value; >

Re: [PATCH v2 0/4] target/arm: Misc cleanups

2020-05-11 Thread Peter Maydell
On Thu, 7 May 2020 at 18:23, Richard Henderson wrote: > > Version 2 adds a fix to a just merged patch. > > > r~ > > > Richard Henderson (4): > target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA > target/arm: Use tcg_gen_gvec_mov for clear_vec_high > target/arm: Use clear_vec_high more eff

Re: [virtio-dev] Re: Fwd: Qemu Support for Virtio Video V4L2 driver

2020-05-11 Thread Saket Sinha
Hi Keiichi, I do not support the approach of QEMU implementation forwarding requests to the host's vicodec module since this can limit the scope of the virtio-video device only for testing, which instead can be used with multiple use cases such as - 1. VM gets access to paravirtualized camera

Re: [PATCH v3 6/9] qemu-img: Add bitmap sub-command

2020-05-11 Thread Max Reitz
On 08.05.20 20:03, Eric Blake wrote: > Include actions for --add, --remove, --clear, --enable, --disable, and > --merge (note that --clear is a bit of fluff, because the same can be > accomplished by removing a bitmap and then adding a new one in its > place, but it matches what QMP commands exist)

[PATCH 0/6] colo: migration related bugfixes

2020-05-11 Thread Lukas Straub
Hello Everyone, Here are fixes for bugs that I found in my tests. Regards, Lukas Straub Lukas Straub (6): migration/colo.c: Use event instead of semaphore migration/colo.c: Use cpu_synchronize_all_states() migration/colo.c: Flush ram cache only after receiving device state migration/colo.

Re: [PATCH 3/4] device-core: use atomic_set on .realized property

2020-05-11 Thread Paolo Bonzini
On 11/05/20 13:00, Maxim Levitsky wrote: > On second thought, I think both cases matter, after I examined the device > removal case. > In device removal case, the device is first un-realized and then removed from > the bus, > so just like in device hotplug case, the scsi_device_find can give you

[PATCH 1/6] migration/colo.c: Use event instead of semaphore

2020-05-11 Thread Lukas Straub
If multiple packets miscompare in a short timeframe, the semaphore value will be increased multiple times. This causes multiple checkpoints even if one would be sufficient. Fix this by using a event instead of a semaphore for triggering checkpoints. Now, checkpoint requests will be ignored until t

Re: [PATCH v1 0/7] various tcg and linux-user updates

2020-05-11 Thread Alex Bennée
Alex Bennée writes: > Hi, > > Cleaning up my queues into more focused trees these are all tweaks to > TCG related stuff. The guest_base changes where posted before but > where a little radical for 5.0 but I think are worth getting in early > as it enables the sanitizer builds for a range of lin

[PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-11 Thread Lukas Straub
Hello Everyone, In many cases, if qemu has a network connection (qmp, migration, chardev, etc.) to some other server and that server dies or hangs, qemu hangs too. These patches introduce the new 'yank' out-of-band qmp command to recover from these kinds of hangs. The different subsystems register

[PATCH 1/5] Introduce yank feature

2020-05-11 Thread Lukas Straub
The yank feature allows to recover from hanging qemu by "yanking" at various parts. Other qemu systems can register yank functions which will be called by the 'yank' out-of-band qmp command. Signed-off-by: Lukas Straub --- qapi/misc.json | 15 ++ softmmu/vl.c | 2 ++ yank.c |

[PATCH 2/6] migration/colo.c: Use cpu_synchronize_all_states()

2020-05-11 Thread Lukas Straub
cpu_synchronize_all_pre_loadvm() marks all vcpus as dirty, so the registers are loaded from CPUState before we continue running the vm. However if we failover during checkpoint, CPUState is not initialized and the registers are loaded with garbage. This causes guest hangs and crashes. Fix this by

  1   2   3   4   5   >