Robert Foley <robert.fo...@linaro.org> writes:
> From: "Emilio G. Cota" <c...@braap.org> > > Cc: Palmer Dabbelt <pal...@dabbelt.com> > Cc: Sagar Karandikar <sag...@eecs.berkeley.edu> > Cc: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> > Cc: Alistair Francis <alistai...@gmail.com> > Reviewed-by: Palmer Dabbelt <pal...@dabbelt.com> You can drop Cc: lines fron patches once you have an a-b or r-b tag from the person in question. They are basically a formalised way of saying "I have tried to contact the maintainer/relevant party" and memorialising it in the patches. The effect of Cc, r-b and a-b tags in the patch is all pretty much the same in that people get Cc'ed anyway - on top of what get_maintainers.pl will add as well! > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > Signed-off-by: Emilio G. Cota <c...@braap.org> > Signed-off-by: Robert Foley <robert.fo...@linaro.org> > --- > target/riscv/op_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c > index c6412f680c..91f8833c2e 100644 > --- a/target/riscv/op_helper.c > +++ b/target/riscv/op_helper.c > @@ -182,7 +182,7 @@ void helper_wfi(CPURISCVState *env) > riscv_cpu_virt_enabled(env)) { > riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC()); > } else { > - cs->halted = 1; > + cpu_halted_set(cs, 1); > cs->exception_index = EXCP_HLT; > cpu_loop_exit(cs); > } -- Alex Bennée