[PULL 00/14] testing and gdbstub updates

2020-05-06 Thread Alex Bennée
The following changes since commit f19d118bed77bb95681b07f4e76dbb700c16918d: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-05-04' into staging (2020-05-05 15:47:44 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-and-gdbst

[PULL 03/14] .cirrus.yml: bump FreeBSD to the current stable release

2020-05-06 Thread Alex Bennée
Hopefully this will un-stick the test which has been broken for a long time. Signed-off-by: Alex Bennée Reviewed-by: Li-Wen Hsu Tested-by: Li-Wen Hsu Message-Id: <2020050505.4225-4-alex.ben...@linaro.org> diff --git a/.cirrus.yml b/.cirrus.yml index 90645fede6b..f06f5af2b93 100644 --- a/.c

[PULL 08/14] tests/tcg: better trap gdb failures

2020-05-06 Thread Alex Bennée
It seems older and non-multiarach aware GDBs might not fail gracefully when faced with something they don't know. For example when faced with a target XML for s390x the Ubuntu 18.04 gdb will generate an internal fault and prompt for a core dump. Work around this by invoking GDB in a more batch ori

Re: [PATCH v1 1/2] hw/riscv: spike: Remove deprecated ISA specific machines

2020-05-06 Thread Philippe Mathieu-Daudé
On 5/6/20 3:12 AM, Alistair Francis wrote: The ISA specific Spike machines have been deprecated in QEMU since 4.1, let's finally remove them. Signed-off-by: Alistair Francis --- hw/riscv/spike.c | 217 --- include/hw/riscv/spike.h | 6 +- 2 fil

[PULL 06/14] configure: favour gdb-multiarch if we have it

2020-05-06 Thread Alex Bennée
As gdb will generally be talking to "foreign" guests lets use that if we can. Otherwise the chances of gdb barfing are considerably higher. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200430190122.4592-2-alex.ben...@linaro.org> diff --git a/configure b/configur

[PULL 07/14] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers

2020-05-06 Thread Alex Bennée
From: Philippe Mathieu-Daudé When converted to use GByteArray in commits 462474d760c and a010bdbe719, the call to stfq_p() was removed. This call serialize a float. Since we now use a GByteArray, we can not use stfq_p() directly. Introduce the gdb_get_float64() helper to load a float64 register.

[PULL 09/14] tests/tcg: drop inferior.was_attached() test

2020-05-06 Thread Alex Bennée
This test seems flaky and reports attachment even when we failed to negotiate the architecture. However the fetching of the guest architecture will fail tripping up the gdb AttributeError which will trigger our early no error status exit from the test Signed-off-by: Alex Bennée Message-Id: <20200

[PULL 10/14] gdbstub: eliminate gdbserver_fd global

2020-05-06 Thread Alex Bennée
We don't really need to track this fd beyond the initial creation of the socket. We already know if the system has been initialised by virtue of the gdbserver_state so lets remove it. This makes the later re-factoring easier. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewe

[PULL 12/14] tests/guest-debug: use the unix socket for linux-user tests

2020-05-06 Thread Alex Bennée
Now we have support for debugging over a unix socket for linux-user lets use it in our test harness. Signed-off-by: Alex Bennée Message-Id: <20200430190122.4592-8-alex.ben...@linaro.org> diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py index 2bbb8fbaa38..d9af9573b9e 100

[PULL 01/14] .travis.yml: show free disk space at end of run

2020-05-06 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <2020050505.4225-2-alex.ben...@linaro.org> diff --git a/.travis.yml b/.travis.yml index 2fd63eceaac..a4c3c6c8058 100644 --- a/.travis.yml +++ b/.travis.yml @@ -113,6 +113,7 @@ script: $(exit $BUILD_RC);

[PULL 04/14] .cirrus.yml: bootstrap pkg unconditionally

2020-05-06 Thread Alex Bennée
From: Li-Wen Hsu This ensures compatibility with pkg repo so a change in upstream doesn't break setup. See: https://lists.freebsd.org/pipermail/freebsd-cloud/2020-April/000234.html Message-Id: Signed-off-by: Li-Wen Hsu [AJB: applied from Li-Wen's github, applied sob, tweaked commit message]

[PULL 14/14] target/m68k: fix gdb for m68xxx

2020-05-06 Thread Alex Bennée
From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a coldfire FPU instead of the default m68881 FPU. This is not OK because the m68881 floats registers are 96 bits wide s

Re: [PATCH v5 13/31] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

2020-05-06 Thread Alberto Garcia
On Tue 05 May 2020 10:04:32 PM CEST, Eric Blake wrote: > What happens for an image whose size is not cluster-aligned? Must the > bits corresponding to subclusters not present in the final cluster > always be zero, or are they instead ignored regardless of value? Attempting to read or write beyond

[PULL 05/14] .travis.yml: reduce the load on [ppc64] GCC check-tcg

2020-05-06 Thread Alex Bennée
This seems to be timing out quite often and occasionally running out of disk space. Relegate it to light duties. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <2020050505.4225-5-alex.ben...@linaro.org> diff --git a/.travis.yml b/.travis.yml index 49267b73b36..fe70879

Re: [PATCH v1 2/2] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-06 Thread Philippe Mathieu-Daudé
Hi Alistair, On 5/6/20 3:12 AM, Alistair Francis wrote: The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since 4.1. It's not commonly used so let's remove support for it. Signed-off-by: Alistair Francis --- target/riscv/cpu.c| 30 --- target/ris

[PULL 11/14] gdbstub/linux-user: support debugging over a unix socket

2020-05-06 Thread Alex Bennée
While debugging over TCP is fairly straightforward now we have test cases that want to orchestrate via make and currently a parallel build fails as two processes can't use the same listening port. While system emulation offers a wide cornucopia of connection methods thanks to the chardev abstractio

[PULL 13/14] tests/tcg: add a multiarch linux-user gdb test

2020-05-06 Thread Alex Bennée
When the gdbstub code was converted to the new API we missed a few snafus in the various guests. Add a simple gdb test script which can be used on all our linux-user guests to check for obvious failures. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200430190122.4592-9

Re: [PATCH v1 15/17] pc: Support for virtio-mem-pci

2020-05-06 Thread Pankaj Gupta
> Let's wire it up similar to virtio-pmem. Also disallow unplug, so it's > harder for users to shoot themselves into the foot. > > Cc: "Michael S. Tsirkin" > Cc: Marcel Apfelbaum > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Eric Blake > Cc: Markus Armbruster > Sign

Re: [PATCH v4 03/13] acpi: rtc: use a single crs range

2020-05-06 Thread Igor Mammedov
On Wed, 6 May 2020 10:39:02 +0200 Gerd Hoffmann wrote: > Hi, > > > > crs = aml_resource_template(); > > > aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > > > - 0x10, 0x02)); > > > + 0x10, 0x08)); > > > aml_ap

Re: [PATCH v2 08/13] acpi: generic event device for x86

2020-05-06 Thread Igor Mammedov
On Wed, 6 May 2020 12:31:06 +0200 Gerd Hoffmann wrote: > On Tue, May 05, 2020 at 05:03:16PM +0200, Igor Mammedov wrote: > > On Tue, 5 May 2020 15:43:00 +0200 > > Gerd Hoffmann wrote: > > > > > Uses TYPE_ACPI_GED as QOM parent for code reuse. > > > Add registers for sleep states and reset. >

Re: [PATCH v3 12/33] block: Unify bdrv_child_cb_detach()

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > Make bdrv_child_cb_detach() call bdrv_backing_detach() for children with > a COW role (and drop the reverse call from bdrv_backing_detach()), so it > can be used for any child (with a proper role set). > > Because so far no child has a proper rol

Re: [PATCH v2 5/9] hw/core: stream: Add an end-of-packet flag

2020-05-06 Thread Edgar E. Iglesias
On Wed, May 06, 2020 at 01:53:33PM +0200, Philippe Mathieu-Daudé wrote: > Hi Edgar, Hi Philippe, > > On 5/6/20 10:25 AM, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Some stream clients stream an endless stream of data while > > other clients stream data in packets. Stream

[Bug 1877052] Re: KVM Win 10 guest pauses after kernel upgrade

2020-05-06 Thread Christian Ehrhardt 
Note: might be related (or not) to bug 1866870 Let's analyze as independent and dup if it turns out to be a dup. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877052 Title: KVM Win 10 guest pauses

Parameter 'driver' expects pluggable device type

2020-05-06 Thread Priyamvad Acharya
Hello developer community, I want to allow a *sysbus *type device to boot with kernel image(arm architecture) via Qemu command line . When I run qemu arm system executable with *-device *option via qemu command line,I get following error message > qemu-system-arm: -device pl061: Parameter 'driver

Re: [PATCH v3 13/33] block: Add child_of_bds

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > Any current user of child_file, child_format, and child_backing can and > should use this generic BdrvChildClass instead, as it can handle all of > these cases. However, to be able to do so, the users must pass the > appropriate BdrvChildRole whe

Re: [PATCH 0/9] More truncate improvements

2020-05-06 Thread Eric Blake
On 4/28/20 3:28 PM, Eric Blake wrote: Based-on: <20200424125448.63318-1-kw...@redhat.com> [PATCH v7 00/10] block: Fix resize (extending) of short overlays After reviewing Kevin's work, I questioned if we had a redundancy with bdrv_has_zero_init_truncate. It turns out we do, and this is the resu

Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop

2020-05-06 Thread Christian Schoenebeck
On Donnerstag, 30. April 2020 17:53:34 CEST Greg Kurz wrote: > Locking was introduced to address the deprecation of readdir_r(3) > in glibc 2.24. It turns out that the frontend code is the worst > place to handle a critical section with a pthread mutex: the code > runs in a coroutine on behalf of t

Re: [PULL 00/24] Block patches

2020-05-06 Thread Peter Maydell
On Tue, 5 May 2020 at 13:58, Max Reitz wrote: > > The following changes since commit 5375af3cd7b8adcc10c18d8083b7be63976c9645: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-05-04 15:51:09 +0100) > > are available in the Git repository at: > > https://gi

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-06 Thread Kevin Wolf
Am 06.05.2020 um 12:37 hat Kevin Wolf geschrieben: > Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > > After the series this patch belongs to, we want to have a common > > BdrvChildClass that encompasses all of child_file, child_format, and > > child_backing. Such a single class needs a single

Re: tst-arm-mte bug: PSTATE.TCO is cleared on exceptions

2020-05-06 Thread Szabolcs Nagy
The 04/24/2020 12:47, Richard Henderson wrote: > On 4/21/20 9:39 PM, Richard Henderson wrote: > > Yep. I failed to update aarch64_pstate_valid_mask for TCO. > > Will fix. Thanks, > > Fixed on the branch. > > I still need to work out how best to plumb the arm,armv8.5-memtag property so > the dev

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-06 Thread Rafael David Tinoco
** Changed in: qemu (Ubuntu) Assignee: Rafael David Tinoco (rafaeldtinoco) => (unassigned) ** Changed in: qemu Status: In Progress => Fix Released ** Changed in: qemu (Ubuntu Focal) Status: Incomplete => In Progress ** Changed in: qemu (Ubuntu Eoan) Status: Incomplete =

Re: [PATCH v3 15/33] block: Pull out bdrv_default_perms_for_backing()

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > Right now, bdrv_format_default_perms() is used by format parents > (generally). We want to switch to a model where most parents use a > single BdrvChildClass, which then decides the permissions based on the > child role. To do so, we have to split

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-06 Thread Rafael David Tinoco
** Description changed: + [Impact] + + * QEMU locking primitives might face a race condition in QEMU Async I/O + bottom halves scheduling. This leads to a dead lock making either QEMU + or one of its tools to hang indefinitely. + + [Test Case] + + * qemu-img convert -f qcow2 -O qcow2 ./disk01.q

Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop

2020-05-06 Thread Christian Schoenebeck
On Mittwoch, 6. Mai 2020 15:05:23 CEST Christian Schoenebeck wrote: > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > > index 9e046f7acb51..ac84ae804496 100644 > > --- a/hw/9pfs/9p.c > > +++ b/hw/9pfs/9p.c > > @@ -2170,7 +2170,7 @@ static int coroutine_fn > > v9fs_do_readdir_with_stat(V9fsPDU *pdu, in

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-06 Thread Maciej S. Szmigiero
On 05.05.2020 17:38, Jon Doron wrote: > On 05/05/2020, Igor Mammedov wrote: > > I dont know what were the original intentions of the original patch authors > (at this point I simply rebased it, and to be honest I did not need this > patch to get where I was going to, but it was part of the origi

Re: [PATCH v3 18/33] block: Add bdrv_default_perms()

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > This callback can be used by BDSs that use child_of_bds with the > appropriate BdrvChildRole for their children. > > Also, make bdrv_format_default_perms() use it for child_of_bds children > (just a temporary solution until we can drop bdrv_forma

Re: [PATCH] aspeed: sdmc: Implement AST2600 locking behaviour

2020-05-06 Thread Cédric Le Goater
On 5/5/20 11:01 AM, Joel Stanley wrote: > The AST2600 handles this differently with the extra 'hardlock' state, so > move the testing to the soc specific class' write callback. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater > --- > hw/misc/aspeed_sdmc.c | 55 +++

[PATCH] crypto: extend hash benchmark to cover more algorithms

2020-05-06 Thread Daniel P . Berrangé
Extend the hash benchmark so that it can validate all algorithms supported by QEMU instead of being limited to sha256. Signed-off-by: Daniel P. Berrangé --- tests/benchmark-crypto-hash.c | 73 --- 1 file changed, 59 insertions(+), 14 deletions(-) diff --git a/tes

Re: [PATCH 1/8] block/vdi: return ZERO block-status when appropriate

2020-05-06 Thread Eric Blake
On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. This part makes sense outright, since vdi does not allow backing files, so all reads of a VDI disk result in data rather t

[PATCH 2/2] linux-user: add do_setsockopt CAN_RAW_FD_FRAMES support

2020-05-06 Thread Tomas Krcka
Signed-off-by: Tomas Krcka --- linux-user/syscall.c | 13 + 1 file changed, 13 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 88d4c85b70..f751ed8b37 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2141,6 +2141,19 @@ static abi_long do_se

[PATCH 1/2] linux-user: add do_setsockopt SOL_CAN_RAW CAN_RAW_FILTER support

2020-05-06 Thread Tomas Krcka
Signed-off-by: Tomas Krcka --- linux-user/syscall.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 05f03919ff..88d4c85b70 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -56,6 +56,7 @@ #inc

Re: [PATCH v2 09/13] microvm: add minimal acpi support

2020-05-06 Thread Igor Mammedov
On Wed, 6 May 2020 12:35:49 +0200 Gerd Hoffmann wrote: > > > +/* FIXME: copy & paste */ > > > +static void acpi_dsdt_add_power_button(Aml *scope) > > > +{ > > > +Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > > +aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > > +

Re: [PATCH v2 01/10] nvdimm: Plug memory leak in uuid property setter

2020-05-06 Thread Shivaprasad G Bhat
On 05/05/2020 03:48 PM, Markus Armbruster wrote: nvdimm_set_uuid() leaks memory on qemu_uuid_parse() failure. Fix that. Fixes: 6c5627bb24dcd68c997857a8b671617333b1289f Cc: Xiao Guangrong Cc: Shivaprasad G Bhat Signed-off-by: Markus Armbruster Thanks for finding and fixing this Markus. Tes

[PULL v1 2/3] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off

2020-05-06 Thread Stefan Berger
From: Eric Auger Now that the tpm-tis-device device PPI property is off by default, we can remove the compat used for the same goal. Signed-off-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by: Stefan Berger Reviewed-by: Peter Maydell Signed-off-by: Stefan Berger Message-id: 2020042714

[PULL v1 0/3] Merge tpm 2020/05/06 v1

2020-05-06 Thread Stefan Berger
Hello! This PR provides PPI changes for TPM support on ARM and compat machines for QEMU 5.1 Regards, Stefan The following changes since commit ea1329bb3a8d5cd25b70e3dbf73e7ded4d5ad756: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-05-05' into staging (2020-05-05 1

[PULL v1 1/3] tpm: tpm-tis-device: set PPI to false by default

2020-05-06 Thread Stefan Berger
From: Eric Auger The tpm-tis-device device does not support PPI. Let's change the default value for the corresponding property instead of tricking this latter in the mach-virt machine. Signed-off-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by: Stefan Berger Reviewed-by: Peter Maydell

[PULL v1 3/3] hw: add compat machines for 5.1

2020-05-06 Thread Stefan Berger
From: Cornelia Huck Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. Acked-by: David Gibson Reviewed-by: Michael S. Tsirkin Signed-off-by: Cornelia Huck Message-id: 20200429144605.7262-1-coh...@redhat.com --- hw/arm/virt.c | 8 +++- hw/core/machine.c | 3 +++

Re: [PATCH] crypto: extend hash benchmark to cover more algorithms

2020-05-06 Thread Eric Blake
On 5/6/20 8:51 AM, Daniel P. Berrangé wrote: Extend the hash benchmark so that it can validate all algorithms supported by QEMU instead of being limited to sha256. Signed-off-by: Daniel P. Berrangé --- tests/benchmark-crypto-hash.c | 73 --- 1 file changed, 59

Re: [PULL 00/14] testing and gdbstub updates

2020-05-06 Thread Peter Maydell
On Wed, 6 May 2020 at 13:05, Alex Bennée wrote: > > The following changes since commit f19d118bed77bb95681b07f4e76dbb700c16918d: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-05-04' into > staging (2020-05-05 15:47:44 +0100) > > are available in the Git repository at: > >

Re: [PATCH 1/8] block/vdi: return ZERO block-status when appropriate

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2020 16:57, Eric Blake wrote: On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. This part makes sense outright, since vdi does not allow backing files, so all reads

Re: [PATCH 7/8] qemu-img: convert: don't use unallocated_blocks_are_zero

2020-05-06 Thread Eric Blake
On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: qemu-img convert wants to distinguish ZERO which comes from short backing files. unallocated_blocks_are_zero field of bdi is unrelated: space after EOF is always considered to be zero anyway. So, just make post_backing_zero true in case of sh

Re: [PATCH RFC 2/4] migration: Introduce migrate_is_precopy()

2020-05-06 Thread Peter Xu
On Wed, May 06, 2020 at 11:05:49AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Export a helper globally to check whether we're during a precopy. > > > > Signed-off-by: Peter Xu > > Can you change this to 'migration_in_precopy' to match the existing > 'migrati

Re: [PATCH 7/8] qemu-img: convert: don't use unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2020 17:49, Eric Blake wrote: On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: qemu-img convert wants to distinguish ZERO which comes from short backing files. unallocated_blocks_are_zero field of bdi is unrelated: space after EOF is always considered to be zero anyway. So, just make

Re: [PATCH v5 07/31] qcow2: Document the Extended L2 Entries feature

2020-05-06 Thread Alberto Garcia
On Tue 05 May 2020 09:35:06 PM CEST, Eric Blake wrote: > On 5/5/20 12:38 PM, Alberto Garcia wrote: >> Subcluster allocation in qcow2 is implemented by extending the >> existing L2 table entries and adding additional information to >> indicate the allocation status of each subcluster. >> >> This pa

Re: [PATCH 8/8] block: drop unallocated_blocks_are_zero

2020-05-06 Thread Eric Blake
On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: Currently this field only set by qed and qcow2. Well, only after patches 1-6 (prior to then, it was also set in protocol drivers). I think you might be able to hoist part of this patch earlier in the series, to make the changes to the pr

Re: [PATCH v5 07/31] qcow2: Document the Extended L2 Entries feature

2020-05-06 Thread Alberto Garcia
On Wed 06 May 2020 05:02:52 PM CEST, Alberto Garcia wrote: >>> -With version 2, this is always 0. >>> +With version 2 or with extended L2 entries (see the >>> next >>> +section), this is always 0. >> >> In your cover letter, you said you

[Bug 1877136] [NEW] Qemu GDB Arm core registers XML description not valid for M-profile

2020-05-06 Thread Matthew
Public bug reported: When trying to debug an armv7-m binary running on Qemu, GDB makes some mistakes due to mistakenly believing the target is not M-profile. One observable is that backtraces over signal handlers are not handled correctly -- since the special M-profile EXC_RETURN value is not rec

Re: [PATCH 8/8] block: drop unallocated_blocks_are_zero

2020-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2020 18:14, Eric Blake wrote: On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: Currently this field only set by qed and qcow2. Well, only after patches 1-6 (prior to then, it was also set in protocol drivers).  I think you might be able to hoist part of this patch earlier in the

[Bug 1877137] [NEW] 32-bit Arm emulation spins at 100% during emacs build

2020-05-06 Thread Edward Vielmetti
Public bug reported: This test case exposes a QEMU bug when crossbuilding to arm32. The bug is only exposed on amd64 architecture or aarch64 hosts that can *only* execute 64 bit applications. Usage: ./setup.sh # installs docker and tweaks sysctl ./qemu.sh # register qemu so you are able to run c

Re: [PATCH RFC 3/4] vl: Sync dirty bits for system resets during precopy

2020-05-06 Thread Peter Xu
On Wed, May 06, 2020 at 11:53:40AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > System resets will also reset system memory layout. Although the memory > > layout > > after the reset should probably the same as before the reset, we still need > > to > > do fre

[Bug 1877137] Re: 32-bit Arm emulation spins at 100% during emacs build

2020-05-06 Thread Philippe Vaucher
Additional bug reports at https://bugs.launchpad.net/qemu/+bug/1861161 and https://bugs.launchpad.net/qemu/+bug/1805913 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877137 Title: 32-bit Arm emula

Re: [PATCH 8/8] block: drop unallocated_blocks_are_zero

2020-05-06 Thread Eric Blake
On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote: Currently this field only set by qed and qcow2. But in fact, all backing-supporting formats (parallels, qcow, qcow2, qed, vmdk) share this semantics: on unallocated blocks, if there is no backing file they just memset the buffer with zeroes.

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-06 Thread Ike Panhc
** Changed in: kunpeng920/ubuntu-18.04 Status: New => Triaged ** Changed in: kunpeng920/ubuntu-18.04 Assignee: (unassigned) => Ike Panhc (ikepanhc) ** Changed in: kunpeng920/ubuntu-18.04-hwe Status: New => Triaged ** Changed in: kunpeng920/ubuntu-18.04-hwe Assignee: (unas

Re: [PATCH v4 3/6] vfio-ccw: Add support for the schib region

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 14:57:54 +0200 Eric Farman wrote: > From: Farhan Ali > > The schib region can be used to obtain the latest SCHIB from the host > passthrough subchannel. Since the guest SCHIB is virtualized, > we currently only update the path related information so that the > guest is aware

Re: [PATCH v4 5/6] s390x/css: Refactor the css_queue_crw() routine

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 14:57:56 +0200 Eric Farman wrote: > We have a use case (vfio-ccw) where a CRW is already built and > ready to use. Rather than teasing out the components just to > reassemble it later, let's rework this code so we can queue a > fully-qualified CRW directly. > > Signed-off-by

Re: [PATCH v4 6/6] vfio-ccw: Add support for the CRW region and IRQ

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 14:57:57 +0200 Eric Farman wrote: > From: Farhan Ali > > The crw region can be used to obtain information about > Channel Report Words (CRW) from vfio-ccw driver. > > Currently only channel-path related CRWs are passed to > QEMU from vfio-ccw driver. > > Signed-off-by: Far

Re: [PATCH v4 0/6] s390x/vfio-ccw: Channel Path Handling [QEMU]

2020-05-06 Thread Cornelia Huck
On Tue, 5 May 2020 14:57:51 +0200 Eric Farman wrote: > Here is a new pass at the channel-path handling code for vfio-ccw, > to take advantage of the corresponding kernel patches posted here: > > https://lore.kernel.org/kvm/20200505122745.53208-1-far...@linux.ibm.com/ > > I have all the main co

Re: [PATCH v1 10/17] virtio-mem: Paravirtualized memory hot(un)plug

2020-05-06 Thread Eric Blake
On 5/6/20 4:49 AM, David Hildenbrand wrote: This is the very basic/initial version of virtio-mem. An introduction to virtio-mem can be found in the Linux kernel driver [1]. While it can be used in the current state for hotplug of a smaller amount of memory, it will heavily benefit from resizeable

Re: [PATCH v1 10/17] virtio-mem: Paravirtualized memory hot(un)plug

2020-05-06 Thread David Hildenbrand
>> +## >> +{ 'struct': 'VirtioMEMDeviceInfo', >> + 'data': { '*id': 'str', >> +'memaddr': 'size', >> +'requested-size': 'size', >> +'size': 'size', >> +'max-size': 'size', >> +'block-size': 'size', >> +'node': 'int', >> +

[Bug 1865160] Re: Unpredictable behaviour resulting in User process faults

2020-05-06 Thread A. Farrell
Recreate with 20.04 LTS (GNU/Linux 5.4.0-26-generic s390x) May 6 16:14:47 qemu2004 kernel: [86269.521861] User process fault: interruption code 0038 ilc:1 May 6 16:14:47 qemu2004 kernel: [86269.521943] Failing address: 6563746de40b6000 TEID: 6563746de40b6800 May 6 16:14:47 qemu2004 kernel:

[Bug 1877137] Re: 32-bit Arm emulation spins at 100% during emacs build

2020-05-06 Thread Alex Bennée
** Tags added: arm tcg ** Tags added: testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877137 Title: 32-bit Arm emulation spins at 100% during emacs build Status in QEMU: New Bug descri

Re: [PATCH v3 22/33] block: Make backing files child_of_bds children

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > Make all parents of backing files pass the appropriate BdrvChildRole. > By doing so, we can switch their BdrvChildClass over to the generic > child_of_bds, which will do the right thing when given a correct > BdrvChildRole. > > Signed-off-by: Max

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-06 Thread dann frazier
** Description changed: [Impact] * QEMU locking primitives might face a race condition in QEMU Async I/O bottom halves scheduling. This leads to a dead lock making either QEMU or one of its tools to hang indefinitely. [Test Case] * qemu-img convert -f qcow2 -O qcow2 ./disk01.q

Re: [PATCH v16 QEMU 08/16] vfio: Register SaveVMHandlers for VFIO device

2020-05-06 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Wed, 6 May 2020 02:38:46 -0400 > Yan Zhao wrote: > > > On Tue, May 05, 2020 at 12:37:26PM +0800, Alex Williamson wrote: > > > It's been a long time, but that doesn't seem like what I was asking. > > > The sysfs version checking is used to select a t

Re: [PATCH v3 26/33] block: Use child_of_bds in remaining places

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > Replace child_file by child_of_bds in all remaining places (excluding > tests). > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > diff --git a/block/blkreplay.c b/block/blkreplay.c > index f97493f45a..71628f4d56 100644 > --- a/block/blk

Re: [PATCH v3 32/33] block: Pass BdrvChildRole in remaining cases

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > These calls have no real use for the child role yet, but it will not > harm to give one. > > Notably, the bdrv_root_attach_child() call in blockjob.c is left > unmodified because there is not much the generic BlockJob object wants > from its chil

Re: [PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta()

2020-05-06 Thread Alberto Garcia
On Tue 05 May 2020 11:59:18 PM CEST, Eric Blake wrote: >> +for (i = first_sc; i <= last_sc; i++) { >> +unsigned c = i / s->subclusters_per_cluster; >> +unsigned sc = i % s->subclusters_per_cluster; >> +l2_entry = get_l2_entry(s, l2_slice, l2_index + c); >

[PATCH v2] aspeed: Add support for the sonorapass-bmc board

2020-05-06 Thread Patrick Williams
Sonora Pass is a 2 socket x86 motherboard designed by Facebook and supported by OpenBMC. Strapping configuration was obtained from hardware and i2c configuration is based on dts found at: https://github.com/facebook/openbmc-linux/blob/1633c87b8ba7c162095787c988979b748ba65dc8/arch/arm/boot/dts/asp

Re: [PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta()

2020-05-06 Thread Eric Blake
On 5/6/20 12:14 PM, Alberto Garcia wrote: Note that you are only skipping until the first normal subcluster, even if other zero/unallocated clusters occur between the first normal cluster and the start of the action. That's correct. Or visually, suppose we have: --0-NN-0___N

Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop

2020-05-06 Thread Greg Kurz
On Wed, 06 May 2020 15:05:23 +0200 Christian Schoenebeck wrote: > On Donnerstag, 30. April 2020 17:53:34 CEST Greg Kurz wrote: > > Locking was introduced to address the deprecation of readdir_r(3) > > in glibc 2.24. It turns out that the frontend code is the worst > > place to handle a critical s

Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop

2020-05-06 Thread Greg Kurz
On Wed, 06 May 2020 15:36:16 +0200 Christian Schoenebeck wrote: > On Mittwoch, 6. Mai 2020 15:05:23 CEST Christian Schoenebeck wrote: > > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > > > index 9e046f7acb51..ac84ae804496 100644 > > > --- a/hw/9pfs/9p.c > > > +++ b/hw/9pfs/9p.c > > > @@ -2170,7 +21

Re: [PATCH v5 20/31] qcow2: Add subcluster support to qcow2_get_host_offset()

2020-05-06 Thread Eric Blake
On 5/5/20 12:38 PM, Alberto Garcia wrote: The logic of this function remains pretty much the same, except that it uses count_contiguous_subclusters(), which combines the logic of count_contiguous_clusters() / count_contiguous_clusters_unallocated() and checks individual subclusters. Maybe ment

Re: [PATCH v5 23/31] qcow2: Add subcluster support to check_refcounts_l2()

2020-05-06 Thread Eric Blake
On 5/5/20 12:38 PM, Alberto Garcia wrote: Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an image has subclusters. Instead, the individual 'all zeroes' bits must be used. Should we s/is forbidden/is ignored/ based on your spec changes? But the patch itself is right. Reviewed-b

Re: [PATCH v2] aspeed: Add support for the sonorapass-bmc board

2020-05-06 Thread Amithash Prasad via
>> +    mc->desc   = "OpenPOWER SonoraPass BMC (ARM1176)"; Open Compute Project?

Re: [PATCH v5 28/31] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-05-06 Thread Eric Blake
On 5/5/20 12:38 PM, Alberto Garcia wrote: Now that the implementation of subclusters is complete we can finally add the necessary options to create and read images with this feature, which we call "extended L2 entries". Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- What you have l

Re: [PATCH v5 29/31] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters

2020-05-06 Thread Eric Blake
On 5/5/20 12:38 PM, Alberto Garcia wrote: This function is only used by qcow2_expand_zero_clusters() to downgrade a qcow2 image to a previous version. It is however not possible to downgrade an image with extended L2 entries because older versions of qcow2 do not have this feature. Signed-off-by

Re: [PATCH v5 30/31] qcow2: Add subcluster support to qcow2_measure()

2020-05-06 Thread Eric Blake
On 5/5/20 12:38 PM, Alberto Garcia wrote: Extended L2 entries are bigger than normal L2 entries so this has an impact on the amount of metadata needed for a qcow2 file. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/qcow2.c | 19 --- 1 file changed, 12 insert

Re: [PATCH v2] aspeed: Add support for the sonorapass-bmc board

2020-05-06 Thread Patrick Williams
On Wed, May 06, 2020 at 06:06:34PM +, Amithash Prasad wrote: > >> +    mc->desc   = "OpenPOWER SonoraPass BMC (ARM1176)"; > Open Compute Project? Oops. Yeah, this is not an OpenPOWER machine. Will send a v3. -- Patrick Williams signature.asc Description: PGP signature

[PULL 02/10] target/s390x: Use tcg_gen_gvec_dup_imm

2020-05-06 Thread Richard Henderson
The gen_gvec_dupi switch is unnecessary with the new function. Replace it with a local gen_gvec_dup_imm that takes care of the register to offset conversion and length arguments. Drop zero_vec and use use gen_gvec_dup_imm with 0. Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée Signed-of

[PULL 06/10] tcg: Remove tcg_gen_gvec_dup{8,16,32,64}i

2020-05-06 Thread Richard Henderson
These interfaces are now unused. Reviewed-by: LIU Zhiwei Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec.h | 5 - tcg/tcg-op-gvec.c | 28 2 files changed, 33 deletions(-) diff --git

[PULL 04/10] target/arm: Use tcg_gen_gvec_dup_imm

2020-05-06 Thread Richard Henderson
In a few cases, we're able to remove some manual replication. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 10 +- target/arm/translate-sve.c | 12 +--- target/arm/translate.c | 9 ++--- 3 files changed, 16 insertions(+), 15

[PULL 00/10] tcg patch queue

2020-05-06 Thread Richard Henderson
tags/pull-tcg-20200506 for you to fetch changes up to 07dada0336a83002dfa8673a9220a88e13d9a45c: tcg: Fix integral argument type to tcg_gen_rot[rl]i_i{32,64} (2020-05-06 09:25:10 -0700) Add tcg_gen_gvec_dup_imm Misc t

[PULL 05/10] tcg: Use tcg_gen_gvec_dup_imm in logical simplifications

2020-05-06 Thread Richard Henderson
Replace the outgoing interface. Reviewed-by: LIU Zhiwei Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 593bb4542e..de16c027b3 100644 --- a/tc

[PULL 09/10] tcg: Add load_dest parameter to GVecGen2

2020-05-06 Thread Richard Henderson
We have this same parameter for GVecGen2i, GVecGen3, and GVecGen3i. This will make some SVE2 insns easier to parameterize. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec.h | 2 ++ tcg/tcg-op-gvec.c | 45 --- 2

[PULL 03/10] target/ppc: Use tcg_gen_gvec_dup_imm

2020-05-06 Thread Richard Henderson
We can now unify the implementation of the 3 VSPLTI instructions. Acked-by: David Gibson Signed-off-by: Richard Henderson --- target/ppc/translate/vmx-impl.inc.c | 32 - target/ppc/translate/vsx-impl.inc.c | 2 +- 2 files changed, 19 insertions(+), 15 deletions(-)

[PULL 10/10] tcg: Fix integral argument type to tcg_gen_rot[rl]i_i{32, 64}

2020-05-06 Thread Richard Henderson
For the benefit of compatibility of function pointer types, we have standardized on int32_t and int64_t as the integral argument to tcg expanders. We converted most of them in 474b2e8f0f7, but missed the rotates. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richar

[PULL 08/10] tcg: Improve vector tail clearing

2020-05-06 Thread Richard Henderson
Better handling of non-power-of-2 tails as seen with Arm 8-byte vector operations. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.c | 82 --- 1 file changed, 63 insertions(+), 19 deletions(-) diff --git a/tcg/tcg-op-gve

[PULL 07/10] tcg: Add tcg_gen_gvec_dup_tl

2020-05-06 Thread Richard Henderson
For use when a target needs to pass a configure-specific target_ulong value to duplicate. Reviewed-by: LIU Zhiwei Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-op-gvec.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/in

[PULL 01/10] tcg: Add tcg_gen_gvec_dup_imm

2020-05-06 Thread Richard Henderson
Add a version of tcg_gen_dup_* that takes both immediate and a vector element size operand. This will replace the set of tcg_gen_gvec_dup{8,16,32,64}i functions that encode the element size within the function name. Reviewed-by: LIU Zhiwei Reviewed-by: David Hildenbrand Reviewed-by: Alex Bennée

[PATCH v3] aspeed: Add support for the sonorapass-bmc board

2020-05-06 Thread Patrick Williams
Sonora Pass is a 2 socket x86 motherboard designed by Facebook and supported by OpenBMC. Strapping configuration was obtained from hardware and i2c configuration is based on dts found at: https://github.com/facebook/openbmc-linux/blob/1633c87b8ba7c162095787c988979b748ba65dc8/arch/arm/boot/dts/asp

<    1   2   3   >