Re: [PATCH v2 01/10] nvdimm: Plug memory leak in uuid property setter

[Shivaprasad G Bhat]

On 05/05/2020 03:48 PM, Markus Armbruster wrote:

nvdimm_set_uuid() leaks memory on qemu_uuid_parse() failure.  Fix
that.

Fixes: 6c5627bb24dcd68c997857a8b671617333b1289f
Cc: Xiao Guangrong <xiaoguangrong.e...@gmail.com>
Cc: Shivaprasad G Bhat <sb...@linux.ibm.com>
Signed-off-by: Markus Armbruster <arm...@redhat.com>

Thanks for finding and fixing this Markus.

Tested-by: Shivaprasad G Bhat <sb...@linux.ibm.com>

Reviewed-by: Shivaprasad G Bhat <sb...@linux.ibm.com>

Regards,
Shivaprasad

---
  hw/mem/nvdimm.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index 8e426d24bb..d5752f7bf6 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -97,7 +97,6 @@ static void nvdimm_set_uuid(Object *obj, Visitor *v, const 
char *name,
      if (qemu_uuid_parse(value, &nvdimm->uuid) != 0) {
          error_setg(errp, "Property '%s.%s' has invalid value",
                     object_get_typename(obj), name);
-        goto out;
      }
      g_free(value);