[Bug 1876678] Re: Ubuntu 20.04 KVM / QEMU Failure with nested FreeBSD bhyve

2020-05-05 Thread John Hartley
** Summary changed: - Ubuntu 20.04 QEMU Failure with nested FreeBSD bhyve + Ubuntu 20.04 KVM / QEMU Failure with nested FreeBSD bhyve -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1876678 Title:

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-05 Thread Ike Panhc
Thanks. I will test it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images Status in kunpeng920: Incomp

RE: [PULL 04/20] crypto: Redundant type conversion for AES_KEY pointer

2020-05-05 Thread Chenqun (kuhn)
>-Original Message- >From: Daniel P. Berrangé [mailto:berra...@redhat.com] >Sent: Monday, May 4, 2020 8:58 PM >To: Chenqun (kuhn) >Cc: qemu-devel@nongnu.org; Michael Tokarev ; qemu- >triv...@nongnu.org; Laurent Vivier ; Euler Robot > >Subject: Re: [PULL 04/20] crypto: Redundant type conver

[PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Huacai Chen
The description of "make check" is out-of-date, so fix it by adding block and softfloat. Signed-off-by: Huacai Chen --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 03a74b6..5d32239 100644 --- a/t

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

2020-05-05 Thread chen huacai
Hi, Aleksandar, On Sun, May 3, 2020 at 6:50 PM Aleksandar Markovic wrote: > > нед, 3. мај 2020. у 12:21 Huacai Chen је написао/ла: > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > > Loongson

Re: [PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > qcow has no space in the metadata to store a backing format, and there > are existing qcow images backed both by raw or by other formats > (usually qcow) images, reliant on probing to tell the difference. > While we don't recommend the creation o

Re: [PATCH v5 4/7] qcow2: Deprecate use of qemu-img amend to change backing file

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > The use of 'qemu-img amend' to change qcow2 backing files is not > tested very well. In particular, our implementation has a bug where > if a new backing file is provided without a format, then the prior > format is blindly reused, even if this

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Claudio Fontana
On 5/5/20 9:29 AM, Huacai Chen wrote: > The description of "make check" is out-of-date, so fix it by adding > block and softfloat. > > Signed-off-by: Huacai Chen > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/test

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

2020-05-05 Thread Laurent Vivier
On 04/05/2020 11:46, Philippe Mathieu-Daudé wrote: > In nvme_create_queue_pair() we create a page list using > qemu_blockalign(), then map it with qemu_vfio_dma_map(): > > q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE); > r = qemu_vfio_dma_map(s->vfio, q->prp_list_pag

Re: [PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > Creating an image that requires format probing of the backing image is > inherently unsafe (we've had several CVEs over the years based on > probes leaking information to the guest on a subsequent boot, although > these days tools like libvirt ar

Re: [PATCH v2] Fix iotest 153

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504131959.9533-1-mlevi...@redhat.com Subject: [PATCH v2] Fix iotest 153 Type: series === TEST SCRI

Re: [PATCH v2] Fix iotest 153

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH v5] audio/jack: add JACK client audiodev

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504132300.1ae883c1...@aeryn.lan.ktmba/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit th

Re: [PULL 00/39] target-arm queue

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504123309.3808-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PULL 00/39] target-arm queue

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504123309.3808-1-peter.mayd...@linaro.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commi

Re: [PATCH v2] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504142308.10446-1-be...@igalia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504142308.10446-1-be...@igalia.com Subject: [PATCH v2] qcow2: Avoid integer wraparound in qcow2_co_tr

Re: [PATCH v2 0/1] target/arm: Remove access_el3_aa32ns()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504142125.31180-1-edgar.igles...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

2020-05-05 Thread Laurent Vivier
On 05/05/2020 10:00, Laurent Vivier wrote: > On 04/05/2020 11:46, Philippe Mathieu-Daudé wrote: >> In nvme_create_queue_pair() we create a page list using >> qemu_blockalign(), then map it with qemu_vfio_dma_map(): >> >> q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE); >>

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/87tv0vzrwj@dusky.pond.sub.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/87tv0vzrwj@dusky.pond.sub.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/b

Re: [PATCH v2] tests/qht-bench: Fix Clang 'int-conversion' warning

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504144125.22435-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v3] tests/qht-bench: Fix Clang 'implicit-int-float-conversion' warning

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504144352.23021-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit t

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ex

Re: [PATCH v2 00/10] Cadence GEM Fixes

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1588601168-27576-1-git-send-email-sai.pavan.bo...@xilinx.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1588601168-27576-1-git-send-email-sai.pavan.bo...@xilinx.com Subject: [PATCH v2 00/1

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504155217.10325-1-be...@igalia.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that h

Re: [PATCH v3 00/12] user-mode: Prune build dependencies (part 1)

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504152922.21365-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v3 00/12] user-mode: Prune build dependencies (part 1)

2020-05-05 Thread Laurent Vivier
Le 04/05/2020 à 17:29, Philippe Mathieu-Daudé a écrit : > This is the first part of a series reducing user-mode > dependencies. By stripping out unused code, the build > and testing time is reduced (as is space used by objects). > > Part 1 (generic): > - reduce user-mode object list > - remove som

Re: [PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

2020-05-05 Thread Peter Krempa
On Tue, May 05, 2020 at 10:11:03 +0200, Kevin Wolf wrote: > Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > > Creating an image that requires format probing of the backing image is > > inherently unsafe (we've had several CVEs over the years based on > > probes leaking information to the guest

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Kevin Wolf
Am 04.05.2020 um 19:07 hat Alberto Garcia geschrieben: > On Mon 04 May 2020 06:01:19 PM CEST, Eric Blake wrote: > >> +_supported_fmt qcow2 > >> +_supported_proto file > > > > Do we have to limit it to qcow2 and file? Yes, it's testing a bugfix > > for qcow2, but are there other formats that it doe

[PATCH v2] crypto: Redundant type conversion for AES_KEY pointer

2020-05-05 Thread Chen Qun
We can delete the redundant type conversion if we set the the AES_KEY parameter with 'const' in qcrypto_cipher_aes_ecb_(en|de)crypt() function. Reported-by: Euler Robot Signed-off-by: Chen Qun --- v1->v2: Cc: "Daniel P. Berrangé" Modify the AES_KEY parameter with 'const' in qcrypto_cipher_aes_

[PATCH] aspeed: sdmc: Implement AST2600 locking behaviour

2020-05-05 Thread Joel Stanley
The AST2600 handles this differently with the extra 'hardlock' state, so move the testing to the soc specific class' write callback. Signed-off-by: Joel Stanley --- hw/misc/aspeed_sdmc.c | 55 +++ 1 file changed, 45 insertions(+), 10 deletions(-) diff --g

Re: [PATCH v9 8/9] virtio-iommu: Implement probe request

2020-05-05 Thread Bharat Bhushan
On Fri, Apr 24, 2020 at 7:22 PM Auger Eric wrote: > > Hi Bharat, > On 4/23/20 6:09 PM, Jean-Philippe Brucker wrote: > > Hi Bharat, > > > > A few more things found while rebasing > > > > On Mon, Mar 23, 2020 at 02:16:16PM +0530, Bharat Bhushan wrote: > >> This patch implements the PROBE request. Cu

Re: [PATCH] aspeed: sdmc: Implement AST2600 locking behaviour

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200505090136.341426-1-j...@jms.id.au/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export A

Re: [PATCH v2] crypto: Redundant type conversion for AES_KEY pointer

2020-05-05 Thread Daniel P . Berrangé
On Tue, May 05, 2020 at 04:59:40PM +0800, Chen Qun wrote: > We can delete the redundant type conversion if > we set the the AES_KEY parameter with 'const' in > qcrypto_cipher_aes_ecb_(en|de)crypt() function. > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > v1->v2: > Cc: "Daniel P.

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Kevin Wolf
Am 05.05.2020 um 10:54 hat Kevin Wolf geschrieben: > Am 04.05.2020 um 19:07 hat Alberto Garcia geschrieben: > > On Mon 04 May 2020 06:01:19 PM CEST, Eric Blake wrote: > > >> +_supported_fmt qcow2 > > >> +_supported_proto file > > > > > > Do we have to limit it to qcow2 and file? Yes, it's testing

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Alberto Garcia
On Tue 05 May 2020 10:54:12 AM CEST, Kevin Wolf wrote: > But I think there is a more important problem with the test: It seems > to pass even with old binaries that don't have the fix. Is this only > on my system or do you get the same? With old binaries when qcow2_cluster_zeroize() is called it r

Re: [PATCH v2] Fix iotest 153

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash expor

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Kevin Wolf
Am 05.05.2020 um 11:16 hat Alberto Garcia geschrieben: > On Tue 05 May 2020 10:54:12 AM CEST, Kevin Wolf wrote: > > But I think there is a more important problem with the test: It seems > > to pass even with old binaries that don't have the fix. Is this only > > on my system or do you get the same?

Re: [PATCH v2 0/1] target/arm: Remove access_el3_aa32ns()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504142125.31180-1-edgar.igles...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504142125.31180-1-edgar.igles...@gmail.com Subject: [PATCH v2 0/1] target/arm: Remove access

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Bharat Bhushan
Hi Eric, On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: > > Hi Bharat, > > On 4/2/20 11:01 AM, Bharat Bhushan wrote: > > Hi Eric/Alex, > > > >> -Original Message- > >> From: Alex Williamson > >> Sent: Thursday, March 26, 2020 11:23 PM > >> To: Auger Eric > >> Cc: Bharat Bhushan ; pet

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Auger Eric
Hi Bharat, On 5/5/20 11:25 AM, Bharat Bhushan wrote: > Hi Eric, > > On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: >> >> Hi Bharat, >> >> On 4/2/20 11:01 AM, Bharat Bhushan wrote: >>> Hi Eric/Alex, >>> -Original Message- From: Alex Williamson Sent: Thursday, March 26,

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 9:29 AM, Huacai Chen wrote: The description of "make check" is out-of-date, so fix it by adding block and softfloat. Signed-off-by: Huacai Chen --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.inc

Re: [PATCH v5 00/18] nvme: refactoring and cleanups

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 7:48 AM, Klaus Jensen wrote: From: Klaus Jensen Changes since v5 No functional changes, just updated Reviewed-by tags. Also, I screwed up the CC list when sending v4. Philippe and Keith, please add a Reviewed-by to * "nvme: factor out pmr setup" and * "do cmb/

Re: [PATCH v18 QEMU 05/18] vfio: Add migration region initialization and finalize function

2020-05-05 Thread Cornelia Huck
On Tue, 5 May 2020 04:14:40 +0530 Kirti Wankhede wrote: > - Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this > patch series. I would drop this sentence; people looking at this patch in the future are unlikely to care. > - VFIO device supports migration or not is dec

Re: [PATCH 0/6] vmdk: Fix zero cluster handling

2020-05-05 Thread Kevin Wolf
Am 30.04.2020 um 15:30 hat Kevin Wolf geschrieben: > What I was really investigating is why 055 was so slow. I couldn't solve > that, but instead I found out that our VMDK code for zero clusters and > write_zeroes was completely broken. Apart from segfaults when zero > clusters were actually enable

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Bharat Bhushan
hi Eric, On Tue, May 5, 2020 at 3:00 PM Auger Eric wrote: > > Hi Bharat, > > On 5/5/20 11:25 AM, Bharat Bhushan wrote: > > Hi Eric, > > > > On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: > >> > >> Hi Bharat, > >> > >> On 4/2/20 11:01 AM, Bharat Bhushan wrote: > >>> Hi Eric/Alex, > >>> >

Re: [PATCH v4 00/18] target/arm: sve load/store improvements

2020-05-05 Thread Peter Maydell
On Mon, 4 May 2020 at 17:03, Richard Henderson wrote: > > On 5/4/20 2:43 AM, Peter Maydell wrote: > > I've reviewed patch 13, but I still don't understand why you've > > made the size-related changes in patch 4, so I've continued > > our conversation in the thread on the v3 version of that patch.

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 10:23 AM, Laurent Vivier wrote: On 05/05/2020 10:00, Laurent Vivier wrote: On 04/05/2020 11:46, Philippe Mathieu-Daudé wrote: In nvme_create_queue_pair() we create a page list using qemu_blockalign(), then map it with qemu_vfio_dma_map(): q->prp_list_pages = qemu_blockalign0(bs, s

[RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally

2020-05-05 Thread Philippe Mathieu-Daudé
I can't find proper documentation or datasheet, but it is likely a MMIO mapped serial device mapped in the 0x8000..0x8000 range belongs to the SoC address space, thus is always mapped in the memory bus. Map the devices on the bus regardless a chardev is attached to it. Signed-off-by: Phili

Re: [PATCH v2 3/4] backup: Make sure that source and target size match

2020-05-05 Thread Kevin Wolf
Am 30.04.2020 um 20:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > 30.04.2020 17:27, Kevin Wolf wrote: > > Since the introduction of a backup filter node in commit 00e30f05d, the > > backup block job crashes when the target image is smaller than the > > source image because it will try to write

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread chen huacai
Hi, Philippe, On Tue, May 5, 2020 at 5:33 PM Philippe Mathieu-Daudé wrote: > > On 5/5/20 9:29 AM, Huacai Chen wrote: > > The description of "make check" is out-of-date, so fix it by adding > > block and softfloat. > > > > Signed-off-by: Huacai Chen > > --- > > tests/Makefile.include | 2 +- > >

[PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Philippe Mathieu-Daudé
Use the generic AUDIO_HOST_ENDIANNESS definition instead of a custom one. Signed-off-by: Philippe Mathieu-Daudé --- Who/what machine is using this device anyway? --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index eb

Re: [PATCH v2 0/4] backup: Make sure that source and target size match

2020-05-05 Thread Kevin Wolf
Am 30.04.2020 um 16:27 hat Kevin Wolf geschrieben: > v2: > - Fixed iotest 283 > - Corrected commit message for patch 3 [Vladimir] > - Fixed permissions for the source node, too > - Refactored the test case to avoid some duplication [Vladimir] Thanks for the review, applied to the block branch. Ke

Re: [RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally

2020-05-05 Thread Jan Kiszka
On 05.05.20 11:59, Philippe Mathieu-Daudé wrote: I can't find proper documentation or datasheet, but it is likely a MMIO mapped serial device mapped in the 0x8000..0x8000 range belongs to the SoC address space, thus is always mapped in the memory bus. Map the devices on the bus regardless

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Paolo Bonzini
On 05/05/20 12:07, Philippe Mathieu-Daudé wrote: > Use the generic AUDIO_HOST_ENDIANNESS definition instead > of a custom one. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Who/what machine is using this device anyway? PC, like all old ISA audio cards. Paolo

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., chen huacai је написао/ла: > Hi, Aleksandar, > > On Sun, May 3, 2020 at 6:50 PM Aleksandar Markovic > wrote: > > > > нед, 3. мај 2020. у 12:21 Huacai Chen је > написао/ла: > > > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > > R1/R2. Loong

Re: [RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally

2020-05-05 Thread Peter Maydell
On Tue, 5 May 2020 at 11:09, Jan Kiszka wrote: > > On 05.05.20 11:59, Philippe Mathieu-Daudé wrote: > I don't recall details anymore either (more than 10 year ago now...), > but this looks reasonable. My guess is that it dates back to when the serial code would crash if passed a NULL pointer for

Re: [PATCH v18 QEMU 06/18] vfio: Add VM state change handler to know state of VM

2020-05-05 Thread Cornelia Huck
On Tue, 5 May 2020 04:14:41 +0530 Kirti Wankhede wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/migration.c | 87 > +++

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Bharat Bhushan
Hi Eric, On Tue, May 5, 2020 at 3:16 PM Bharat Bhushan wrote: > > hi Eric, > > On Tue, May 5, 2020 at 3:00 PM Auger Eric wrote: > > > > Hi Bharat, > > > > On 5/5/20 11:25 AM, Bharat Bhushan wrote: > > > Hi Eric, > > > > > > On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: > > >> > > >> Hi Bhar

[PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init()

2020-05-05 Thread Markus Armbruster
Fixes: df1d8a1f29f567567b9d20be685a4241282e7005 Cc: Paul Burton Cc: Aleksandar Rikalo Signed-off-by: Markus Armbruster --- hw/mips/boston.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index 2832dfa6ae..a896056be1 100644 --- a/hw/mi

[PATCH v2 00/10] More miscellaneous error handling fixes

2020-05-05 Thread Markus Armbruster
v2: * PATCH 2: missing return [Paul] * PATCH 3: commit message typo [David] * PATCH 5: error message tidied up [Eric, Philippe] * PATCH 7: commit message pasto * Old PATCH 4 dropped [Matthew] Cc: Paul Durrant Cc: David Hildenbrand Cc: Eric Blake Cc: Philippe Mathieu-Daudé Markus Armbruster (1

[PATCH v2 10/10] i386: Fix x86_cpu_load_model() error API violation

2020-05-05 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. x86_cpu_load_model()

[PATCH v2 04/10] tests/migration: Tighten error checking

2020-05-05 Thread Markus Armbruster
migrate_get_socket_address() neglects to check visit_type_SocketAddressList() failure. This smells like a leak, but it actually will crash dereferencing @addrs. Pass &error_abort to remove the code smell. Signed-off-by: Markus Armbruster --- tests/qtest/migration-test.c | 4 ++-- 1 file change

[PATCH v2 05/10] error: Use error_reportf_err() where appropriate

2020-05-05 Thread Markus Armbruster
Replace error_report("...: %s", ..., error_get_pretty(err)); by error_reportf_err(err, "...: ", ...); One of the replaced messages lacked a colon. Add it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- chardev/char-socket.c | 5 +++

[PATCH v2 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init()

2020-05-05 Thread Markus Armbruster
Cc: Peter Maydell Cc: Jean-Christophe Dubois Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/sabrelite.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/arm/sabrelite.c b/hw/arm/sabrelite.c index e31694bb92..04f4b96591 100644 --- a/h

[PATCH v2 07/10] mips/boston: Fix boston_mach_init() error handling

2020-05-05 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. boston_mach_init() is

[PATCH v2 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-05-05 Thread Markus Armbruster
Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API violations" neglected to change visit_check_struct()'s Error ** argument along with the others. If visit_check_struct() failed, we'd take the success path. Fortunately, it can't fail here: qobject_input_check_struct() checks we

[PATCH v2 06/10] mips/malta: Fix create_cps() error handling

2020-05-05 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second create_cps() is wrong that

Re: [PATCH v25 02/10] hw/arm/virt: Introduce a RAS machine option

2020-05-05 Thread Igor Mammedov
On Fri, 10 Apr 2020 19:46:31 +0800 Dongjiu Geng wrote: > RAS Virtualization feature is not supported now, so > add a RAS machine option and disable it by default. > > Reviewed-by: Peter Maydell > Signed-off-by: Dongjiu Geng > Signed-off-by: Xiang Zheng > Reviewed-by: Jonathan Cameron Review

[PATCH v2 01/10] nvdimm: Plug memory leak in uuid property setter

2020-05-05 Thread Markus Armbruster
nvdimm_set_uuid() leaks memory on qemu_uuid_parse() failure. Fix that. Fixes: 6c5627bb24dcd68c997857a8b671617333b1289f Cc: Xiao Guangrong Cc: Shivaprasad G Bhat Signed-off-by: Markus Armbruster --- hw/mem/nvdimm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvd

[PATCH V2] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Huacai Chen
The description of "make check" is out-of-date, so fix it by adding block and softfloat. Reviewed-by: Claudio Fontana Signed-off-by: Huacai Chen --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 0

[PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors

2020-05-05 Thread Markus Armbruster
usbback_portid_add() leaks the error when qdev_device_add() fails. Fix that. While there, use the error to improve the error message. The qemu_opts_from_qdict() similarly leaks on failure. But any failure there is a programming error. Pass &error_abort. Fixes: 816ac92ef769f9ffc534e49a1bb6177bd

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., Huacai Chen је написао/ла: > The description of "make check" is out-of-date, so fix it by adding > block and softfloat. > > Signed-off-by: Huacai Chen > --- Reviewed-by: Aleksandar Markovic > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v25 05/10] ACPI: Build Hardware Error Source Table

2020-05-05 Thread Igor Mammedov
On Fri, 10 Apr 2020 19:46:34 +0800 Dongjiu Geng wrote: > This patch builds Hardware Error Source Table(HEST) via fw_cfg blobs. > Now it only supports ARMv8 SEA, a type of Generic Hardware Error > Source version 2(GHESv2) error source. Afterwards, we can extend > the supported types if needed. For

Re: [PATCH v23 0/4] implement zstd cluster compression method

2020-05-05 Thread Max Reitz
On 30.04.20 12:19, Denis Plotnikov wrote: > v23: >Undecided: whether to add zstd(zlib) compression > details to the qcow2 spec >03: tighten assertion on zstd decompression [Eric] >04: use _rm_test_img appropriately [Max] Thanks, applied to my block branch: https://git.xa

Re: [PATCH v25 06/10] ACPI: Record the Generic Error Status Block address

2020-05-05 Thread Igor Mammedov
On Fri, 10 Apr 2020 19:46:35 +0800 Dongjiu Geng wrote: > Record the GHEB address via fw_cfg file, when recording > a error to CPER, it will use this address to find out > Generic Error Data Entries and write the error. > > In order to avoid migration failure, make hardware > error table address

Re: [PATCH V2] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 12:24 PM, Huacai Chen wrote: The description of "make check" is out-of-date, so fix it by adding block and softfloat. Reviewed-by: Claudio Fontana Signed-off-by: Huacai Chen --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefi

Re: [PATCH v2 00/15] target/arm: partial vector cleanup

2020-05-05 Thread Peter Maydell
On Sat, 2 May 2020 at 23:45, Richard Henderson wrote: > > This is not complete, but shows the direction I'd like to go. > > It may well help what Peter is doing with the neon decodetree > conversion. It may be helpful to apply before the conversion > in order to reduce the number of special cases

Re: [PATCH v2 04/10] tests/migration: Tighten error checking

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 12:19 PM, Markus Armbruster wrote: migrate_get_socket_address() neglects to check visit_type_SocketAddressList() failure. This smells like a leak, but it actually will crash dereferencing @addrs. Pass &error_abort to remove the code smell. Signed-off-by: Markus Armbruster --- test

Re: [PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init()

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., Markus Armbruster је написао/ла: > Fixes: df1d8a1f29f567567b9d20be685a4241282e7005 > Cc: Paul Burton > Cc: Aleksandar Rikalo > Signed-off-by: Markus Armbruster > --- > hw/mips/boston.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Thank you, Markus, fo

Re: [PATCH v2 07/10] mips/boston: Fix boston_mach_init() error handling

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., Markus Armbruster је написао/ла: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no

Re: [PATCH v2 06/10] mips/malta: Fix create_cps() error handling

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., Markus Armbruster је написао/ла: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no

Re: [PATCH v25 08/10] ACPI: Record Generic Error Status Block(GESB) table

2020-05-05 Thread Igor Mammedov
On Fri, 10 Apr 2020 19:46:37 +0800 Dongjiu Geng wrote: > kvm_arch_on_sigbus_vcpu() error injection uses source_id as > index in etc/hardware_errors to find out Error Status Data > Block entry corresponding to error source. So supported source_id > values should be assigned here and not be changed

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 12:10 PM, Paolo Bonzini wrote: On 05/05/20 12:07, Philippe Mathieu-Daudé wrote: Use the generic AUDIO_HOST_ENDIANNESS definition instead of a custom one. Signed-off-by: Philippe Mathieu-Daudé --- Who/what machine is using this device anyway? PC, like all old ISA audio cards. I im

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Paolo Bonzini
On 05/05/20 12:45, Philippe Mathieu-Daudé wrote: > On 5/5/20 12:10 PM, Paolo Bonzini wrote: >> On 05/05/20 12:07, Philippe Mathieu-Daudé wrote: >>> Use the generic AUDIO_HOST_ENDIANNESS definition instead >>> of a custom one. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> Who/what machi

Re: [PATCH v18 QEMU 07/18] vfio: Add migration state change notifier

2020-05-05 Thread Cornelia Huck
On Tue, 5 May 2020 04:14:42 +0530 Kirti Wankhede wrote: > Added migration state change notifier to get notification on migration state > change. These states are translated to VFIO device state and conveyed to > vendor > driver. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- >

Re: [PATCH V2] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., Huacai Chen је написао/ла: > The description of "make check" is out-of-date, so fix it by adding > block and softfloat. > > Reviewed-by: Claudio Fontana > Signed-off-by: Huacai Chen > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 12:49 PM, Paolo Bonzini wrote: On 05/05/20 12:45, Philippe Mathieu-Daudé wrote: On 5/5/20 12:10 PM, Paolo Bonzini wrote: On 05/05/20 12:07, Philippe Mathieu-Daudé wrote: Use the generic AUDIO_HOST_ENDIANNESS definition instead of a custom one. Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v4 0/5] block-copy: use aio-task-pool

2020-05-05 Thread Max Reitz
On 29.04.20 15:08, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > v4 > 01: add Max's r-b > 04: move variable definition to the top of the block, add Max's r-b > 05: - change error-codes in block_copy_task_run(), document them > and be more accurate about error code in block_copy_dirty_clu

Today KVM external call canceled

2020-05-05 Thread Juan Quintela
Hi As there are no topics, we cancel that call. Happy hacking.

KVM call for agenda for 2020-05-19

2020-05-05 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: B

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Max Reitz
On 05.05.20 12:55, Philippe Mathieu-Daudé wrote: > On 5/5/20 12:49 PM, Paolo Bonzini wrote: >> On 05/05/20 12:45, Philippe Mathieu-Daudé wrote: >>> On 5/5/20 12:10 PM, Paolo Bonzini wrote: On 05/05/20 12:07, Philippe Mathieu-Daudé wrote: > Use the generic AUDIO_HOST_ENDIANNESS definition i

Re: [PATCH v3 03/33] block: Add BdrvChildRole and BdrvChildRoleBits

2020-05-05 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > This mask will supplement BdrvChildClass when it comes to what role (or > combination of roles) a child takes for its parent. It consists of > BdrvChildRoleBits values (which is an enum). > > Because empty enums are not allowed, let us just star

Re: [PATCH v25 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2020-05-05 Thread Igor Mammedov
On Fri, 10 Apr 2020 19:46:38 +0800 Dongjiu Geng wrote: > Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA delivered by host to guest PA, then fills this PA > to guest APEI GHES memory, then notifies guest according to the SIGBUS > type. > > When g

[PATCH v4 00/13] acpi: i386 tweaks

2020-05-05 Thread Gerd Hoffmann
First batch of microvm patches, some generic acpi stuff. Split the acpi-build.c monster, specifically split the pc and q35 and pci bits into a separate file which we can skip building at some point in the future. v2 changes: leave acpi-build.c largely as-is, move useful bits to other places to all

[PATCH v4 02/13] acpi: move aml builder code for rtc device

2020-05-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-build.c | 17 - hw/rtc/mc146818rtc.c | 22 ++ 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 2e15f6848e7e..0bfa2dd23fcc 100644 --- a/hw/i386/acpi-b

[PATCH v4 11/13] acpi: simplify build_isa_devices_aml()

2020-05-05 Thread Gerd Hoffmann
x86 machines can have a single ISA bus only. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-build.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index cb3913d2ee76..1922868f3401 100644 --- a/hw/i386/acpi-build.c +

  1   2   3   4   >