>-----Original Message----- >From: Daniel P. Berrangé [mailto:berra...@redhat.com] >Sent: Monday, May 4, 2020 8:58 PM >To: Chenqun (kuhn) <kuhn.chen...@huawei.com> >Cc: qemu-devel@nongnu.org; Michael Tokarev <m...@tls.msk.ru>; qemu- >triv...@nongnu.org; Laurent Vivier <laur...@vivier.eu>; Euler Robot ><euler.ro...@huawei.com> >Subject: Re: [PULL 04/20] crypto: Redundant type conversion for AES_KEY >pointer > >Hi Chen, > >This patch triggered a build failure in QEMU about discarding the "const" >qualifier. > >IOW, the type conversion is not redundant after all - it is required in order >to >explicitly discard "const". > Yes, you are right! Thank you for pointing it out ! It is my carelessness, this patch is not complete.
>I believe we can probably fix this by changing >qcrypto_cipher_aes_ecb_(en|de)crypt() methods so that they also have a "const" >qualifier on the AES_KEY parameter. > It's a good point. I will update the patch later. Thanks.
