Re: [PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

2020-04-29 Thread Philippe Mathieu-Daudé
On 4/29/20 10:27 AM, Huacai Chen wrote: Hi, Philippe, The major differences of R3 and R4 are: 1, R4 has complete MIPS VZ ASE (while R3 is incomplete), so very usable for KVM host; So you need to set CP0C3_VZ. 2, R4 has MSA ASE while R3 hasn't; So you need to set CP0C5_MSAEn. 3, R4 has cp

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 08:14:01AM +, Ani Sinha wrote: > > > > On Apr 29, 2020, at 1:39 PM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 29, 2020 at 07:43:04AM +, Ani Sinha wrote: > >> > >> > >>> On Apr 29, 2020, at 1:08 PM, Michael S. Tsirkin wrote: > >>> > >>> On Wed, Apr 29, 202

Re: [PATCH 2/2] target/m68k: fix gdb for m68xxx

2020-04-29 Thread Laurent Vivier
Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : > Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is > it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects > a coldfire FPU instead of the default m68881 FPU. > > This is not OK because the m68881

[Bug 1875819] Re: [Feature request] prebuilt testing docker images

2020-04-29 Thread Daniel Berrange
GitLab has ability to host container images per project and also can build them during CI runs. So I'd suggest that we create GitLab CI jobs that build & publish each of the images under tests/docker on the master branch. -- You received this bug notification because you are a member of qemu- dev

Re: [PATCH 6/9] ssh: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-29 Thread Richard W.M. Jones
On Tue, Apr 28, 2020 at 03:29:02PM -0500, Eric Blake wrote: > Our .bdrv_has_zero_init_truncate can detect when the remote side > always zero fills; we can reuse that same knowledge to implement > BDRV_REQ_ZERO_WRITE by ignoring it when the server gives it to us for > free. > > Signed-off-by: Eric

Re: [PATCH 9/9] block: Drop unused .bdrv_has_zero_init_truncate

2020-04-29 Thread Richard W.M. Jones
On Tue, Apr 28, 2020 at 03:29:05PM -0500, Eric Blake wrote: > Now that there are no clients of bdrv_has_zero_init_truncate, none of > the drivers need to worry about providing it. > > What's more, this eliminates a source of some confusion: a literal > reading of the documentation as written in ce

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Ani Sinha
> On Apr 29, 2020, at 2:26 PM, Michael S. Tsirkin wrote: > > Even if it seems to work for guests now, if we don't stick to emulating > capabilities that hardware interfaces provide we can never be sure it > will keep working. OS es use ACPI for PCI bridges: https://github.com/qemu/qemu/blob/m

Re: backing chain & block status & filters

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
28.04.2020 22:44, Vladimir Sementsov-Ogievskiy wrote: 28.04.2020 19:46, Vladimir Sementsov-Ogievskiy wrote: 28.04.2020 19:18, Eric Blake wrote: On 4/28/20 10:13 AM, Vladimir Sementsov-Ogievskiy wrote: Hm.  I could imagine that there are formats that have non-zero holes (e.g. 0xff or just garb

Re: [PATCH for-5.1 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

2020-04-29 Thread Philippe Mathieu-Daudé
On 4/29/20 3:52 AM, Huacai Chen wrote: Hi, Philippe and Aleksandar, I'm not refusing to change my patch, but I have two questions: 1, Why we should identify Loongson-3 to deliver IP3? It seems that deliver all IPs (IP2~IP7) unconditionally is harmless as well. 2, How to identify Loongson-3 by Co

Re: [PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

2020-04-29 Thread Huacai Chen
Hi, Philippe, I think that this CPU definition is for Guest, not for Host (Maybe I'm wrong?). On Wed, Apr 29, 2020 at 4:58 PM Philippe Mathieu-Daudé wrote: > > On 4/29/20 10:27 AM, Huacai Chen wrote: > > Hi, Philippe, > > > > The major differences of R3 and R4 are: > > 1, R4 has complete MIPS VZ

[PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Roman Kagan
Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, physical_block_size, and min_io_size. However, the properties in BlockConf are defined as uint16_t limiting the values to 32768. This appears unnecessary tight, and we've seen bigger block sizes ha

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Ani Sinha
> On Apr 29, 2020, at 2:44 PM, Anirban Sinha wrote: > > > Note that “these control methods are optional” line. If the OS adheres to the > spec, it should not expect them to exist all the time Linux for example, detects it here: https://elixir.bootlin.com/linux/latest/source/drivers/acpi/uti

Re: [PULL 12/32] block/file-posix: Fix check_cache_dropped() error handling

2020-04-29 Thread Stefan Hajnoczi
On Wed, Apr 29, 2020 at 09:20:28AM +0200, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an err

Re: [Virtio-fs] [PATCH] virtiofsd: Show submounts

2020-04-29 Thread Miklos Szeredi
On Wed, Apr 29, 2020 at 9:59 AM Miklos Szeredi wrote: > > On Tue, Apr 28, 2020 at 9:15 PM Dr. David Alan Gilbert > wrote: > > > So our current sequence is: > > > >(new namespace) > > 1)if (mount(NULL, "/", NULL, MS_REC | MS_SLAVE, NULL) < 0) { > > 2) if (mount("proc", "/proc", "proc",

Re: [PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-04-29 Thread Alex Bennée
Laurent Vivier writes: > Le 28/04/2020 à 20:43, Alex Bennée a écrit : >> >> KONRAD Frederic writes: >> >>> The MC68881 say about infinities (3.2.4): >>> >>> "*For the extended precision format, the most significant bit of the >>> mantissa (the integer bit) is a don't care." >>> >>> https://w

Re: [PATCH 2/2] target/m68k: fix gdb for m68xxx

2020-04-29 Thread Alex Bennée
Laurent Vivier writes: > Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : >> Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is >> it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects >> a coldfire FPU instead of the default m68881 FPU. >> >>

Re: [PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

2020-04-29 Thread Philippe Mathieu-Daudé
On 4/29/20 11:25 AM, Huacai Chen wrote: Hi, Philippe, I think that this CPU definition is for Guest, not for Host (Maybe I'm wrong?). OK, it was not obvious to me (I haven't received the cover letter of this series). The code you modified is used by both host emulation and guest virtualizati

Re: [Virtio-fs] [PATCH] virtiofsd: Show submounts

2020-04-29 Thread Max Reitz
On 29.04.20 10:52, Miklos Szeredi wrote: > On Wed, Apr 29, 2020 at 10:31 AM Max Reitz wrote: >> >> On 28.04.20 21:15, Dr. David Alan Gilbert wrote: > >>> So are you saying we need a: >>>if (mount(NULL, "/", NULL, MS_REC | MS_SHARED, NULL) < 0) { >>> >>> and can this go straight after (1

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-04-29 Thread Stefan Hajnoczi
On Tue, Apr 28, 2020 at 01:47:24PM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2020 at 06:29:20PM +0100, Stefan Hajnoczi wrote: > > On Wed, Apr 22, 2020 at 09:13:35PM -0700, elena.ufimts...@oracle.com wrote: > > > We will post separate patchsets for the following improvements for > > > the e

Re: [PATCH 2/2] target/m68k: fix gdb for m68xxx

2020-04-29 Thread Laurent Vivier
Le 29/04/2020 à 11:28, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : >>> Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is >>> it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then >>> expects >>

Re: [PATCH RESEND v6 08/36] multi-process: Add stub functions to facilitate build of multi-process

2020-04-29 Thread Stefan Hajnoczi
On Tue, Apr 28, 2020 at 02:58:21PM -0400, Jag Raman wrote: > > On Apr 28, 2020, at 12:29 PM, Stefan Hajnoczi wrote: > > On Fri, Apr 24, 2020 at 09:47:56AM -0400, Jag Raman wrote: > >>> On Apr 24, 2020, at 9:12 AM, Stefan Hajnoczi wrote: > >>> On Wed, Apr 22, 2020 at 09:13:43PM -0700, elena.ufimts

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Philippe Mathieu-Daudé
Cc'ing virtio-blk and scsi maintainers. On 4/29/20 11:18 AM, Roman Kagan wrote: Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, physical_block_size, and min_io_size. However, the properties in BlockConf are defined as uint16_t limiting the val

Re: [PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-04-29 Thread Laurent Vivier
Le 29/04/2020 à 11:26, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 28/04/2020 à 20:43, Alex Bennée a écrit : >>> >>> KONRAD Frederic writes: >>> The MC68881 say about infinities (3.2.4): "*For the extended precision format, the most significant bit of the mantis

Re: [PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

2020-04-29 Thread Huacai Chen
Hi, Philippe, On Wed, Apr 29, 2020 at 5:30 PM Philippe Mathieu-Daudé wrote: > > On 4/29/20 11:25 AM, Huacai Chen wrote: > > Hi, Philippe, > > > > I think that this CPU definition is for Guest, not for Host (Maybe I'm > > wrong?). > > OK, it was not obvious to me (I haven't received the cover let

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-29 Thread Yan Zhao
On Wed, Apr 29, 2020 at 04:22:01PM +0800, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > On Tue, Apr 28, 2020 at 10:14:37PM +0800, Dr. David Alan Gilbert wrote: > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > On Mon, Apr 27, 2020 at 11:37:43PM +0800, Dr. David A

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-29 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > On Wed, Apr 29, 2020 at 04:22:01PM +0800, Dr. David Alan Gilbert wrote: > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > On Tue, Apr 28, 2020 at 10:14:37PM +0800, Dr. David Alan Gilbert wrote: > > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > > On

Re: [PATCH v2] audio/jack: add JACK client audiodev

2020-04-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200429072435.f13e23c0...@aeryn.lan.ktmba/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200429072435.f13e23c0...@aeryn.lan.ktmba Subject: [PATCH v2] audio/jack: add JACK client audiodev Ty

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 10:30:30AM +0100, Stefan Hajnoczi wrote: > > > I suggest dropping the remote device program from this patch series (and > > > maybe never bringing it back). Instead, use the softmmu target for the > > > remote device. ... > > > > Building QEMU twices just to get the remo

Re: [PATCH for-5.1 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

2020-04-29 Thread Huacai Chen
Hi, Philippe, On Wed, Apr 29, 2020 at 5:18 PM Philippe Mathieu-Daudé wrote: > > On 4/29/20 3:52 AM, Huacai Chen wrote: > > Hi, Philippe and Aleksandar, > > > > I'm not refusing to change my patch, but I have two questions: > > 1, Why we should identify Loongson-3 to deliver IP3? It seems that > >

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 09:14:26AM +, Ani Sinha wrote: > > > > On Apr 29, 2020, at 2:26 PM, Michael S. Tsirkin wrote: > > > > Even if it seems to work for guests now, if we don't stick to emulating > > capabilities that hardware interfaces provide we can never be sure it > > will keep worki

R: About hardfloat in ppc

2020-04-29 Thread Dino Papararo
Hello, about handling of PPC fpu exceptions and Hard Floats support we could consider a different approach for different instructions. i.e. not all fpu instructions take care about inexact or exceptions bits: if I take a simple fadd f0,f1,f2 I'll copy value derived from adding f1+f2 into f1 regi

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Ani Sinha
> On Apr 29, 2020, at 3:45 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 29, 2020 at 09:14:26AM +, Ani Sinha wrote: >> >> >>> On Apr 29, 2020, at 2:26 PM, Michael S. Tsirkin wrote: >>> >>> Even if it seems to work for guests now, if we don't stick to emulating >>> capabilities that hard

Re: [PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-04-29 Thread Alex Bennée
Laurent Vivier writes: > Le 29/04/2020 à 11:26, Alex Bennée a écrit : >> >> Laurent Vivier writes: >> >>> Le 28/04/2020 à 20:43, Alex Bennée a écrit : KONRAD Frederic writes: > The MC68881 say about infinities (3.2.4): > > "*For the extended precision format, the

Re: [PATCH v22 3/4] qcow2: add zstd cluster compression

2020-04-29 Thread Max Reitz
On 28.04.20 22:00, Denis Plotnikov wrote: > zstd significantly reduces cluster compression time. > It provides better compression performance maintaining > the same level of the compression ratio in comparison with > zlib, which, at the moment, is the only compression > method available. > > The p

Re: [PATCH v22 4/4] iotests: 287: add qcow2 compression type test

2020-04-29 Thread Max Reitz
On 28.04.20 22:00, Denis Plotnikov wrote: > The test checks fulfilling qcow2 requirements for the compression > type feature and zstd compression type operability. > > Signed-off-by: Denis Plotnikov > Reviewed-by: Vladimir Sementsov-Ogievskiy > Tested-by: Vladimir Sementsov-Ogievskiy > --- > t

R: About hardfloat in ppc

2020-04-29 Thread Dino Papararo
Typo correction 😊 " if I take a simple fadd f0,f1,f2 I'll copy value derived from adding f1+f2 into f0 register" -Messaggio originale- Da: Qemu-ppc Per conto di Dino Papararo Inviato: mercoledì 29 aprile 2020 12:18 A: Alex Bennée ; luoyongg...@gmail.com; BALATON Zoltan ; Mark Cave-Ay

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 10:20:31AM +, Ani Sinha wrote: > > > > On Apr 29, 2020, at 3:45 PM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 29, 2020 at 09:14:26AM +, Ani Sinha wrote: > >> > >> > >>> On Apr 29, 2020, at 2:26 PM, Michael S. Tsirkin wrote: > >>> > >>> Even if it seems to

Re: [PATCH v22 3/4] qcow2: add zstd cluster compression

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 13:24, Max Reitz wrote: On 28.04.20 22:00, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-29 Thread Ani Sinha
>>> >>> Yes. So if there's no _EJx then it's reasonable to assume you can't >>> isolate the slot, and so no hot-plug will happen either. >> >> Where are you getting that? > > It's well known. For example, the pci hot-plug specification, version > 1.1, states: > > 1.6 Asssumptions > > ... > >

Re: [PATCH v22 3/4] qcow2: add zstd cluster compression

2020-04-29 Thread Denis Plotnikov
On 29.04.2020 13:24, Max Reitz wrote: On 28.04.20 22:00, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compre

Re: [PATCH v22 4/4] iotests: 287: add qcow2 compression type test

2020-04-29 Thread Denis Plotnikov
On 29.04.2020 13:26, Max Reitz wrote: On 28.04.20 22:00, Denis Plotnikov wrote: The test checks fulfilling qcow2 requirements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir

Re: [PATCH] block: Comment cleanups

2020-04-29 Thread Max Reitz
On 28.04.20 23:38, Eric Blake wrote: > It's been a while since we got rid of the sector-based bdrv_read and > bdrv_write (commit 2e11d756); let's finish the job on a few remaining > comments. > > Signed-off-by: Eric Blake > --- > > Hmm - I started this in Nov 2018, and just barely noticed that i

Re: backing chain & block status & filters

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
Full summary What drivers returns? Filters and raw are just broken together with their BDRV_BLOCK_RAW. Format drivers behaves as follows (except for backing-not-supporting, which should be fixed): 0 - go to backing (not-backing supporting will never return it, backing-supporting will return

Re: [PATCH v3 1/5] block/block-copy: rename in-flight requests to tasks

2020-04-29 Thread Max Reitz
On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: > We are going to use aio-task-pool API and extend in-flight request > structure to be a successor of AioTask, so rename things appropriately. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/block-copy.c | 98 ++

Re: [PATCH v2] migration/xbzrle: add encoding rate

2020-04-29 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > On 04/28/2020 10:51 PM, Dr. David Alan Gilbert wrote: > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > Users may need to check the xbzrle encoding rate to know if the guest > > > memory is xbzrle encoding-friendly, and dynamically turn off the > > > enco

[PATCH 00/12] audio: deprecate -soundhw

2020-04-29 Thread Gerd Hoffmann
Gerd Hoffmann (12): stubs: add isa_create_simple stubs: add pci_create_simple audio: add deprecated_register_soundhw audio: deprecate -soundhw ac97 audio: deprecate -soundhw es1370 audio: deprecate -soundhw adlib audio: deprecate -soundhw cs4231a audio: deprecate -soundhw gus a

[PATCH 04/12] audio: deprecate -soundhw ac97

2020-04-29 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both ac97 and AC97 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/ac97.c | 9 ++--- qdev-monitor.c | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/

[PATCH 05/12] audio: deprecate -soundhw es1370

2020-04-29 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both es1370 and ES1370 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/es1370.c | 9 ++--- qdev-monitor.c| 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --g

[PATCH 07/12] audio: deprecate -soundhw cs4231a

2020-04-29 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231a.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index ffdbb58d6a11..59705a8d4701 100644 --- a/hw/

[PATCH 02/12] stubs: add pci_create_simple

2020-04-29 Thread Gerd Hoffmann
Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann --- stubs/pci-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/pci-bus.c diff --git a/stubs/pci-bus.c b/stubs/pci-bus.c new file mode 100644 index ..e833947f1f41 ---

[PATCH 12/12] [RFC] audio: try use onboard audiodev for pcspk

2020-04-29 Thread Gerd Hoffmann
New naming convention: Use "onboard" audiodev for onboard audio devices. This patchs implements it for pcspk. If we want go this route we should do the same for other onboard audio devices too (arm boards, ...). Signed-off-by: Gerd Hoffmann --- hw/audio/pcspk.c | 3 +++ 1 file changed, 3 inse

[PATCH 03/12] audio: add deprecated_register_soundhw

2020-04-29 Thread Gerd Hoffmann
Add helper function for -soundhw deprecation. It can replace the simple init functions which just call {isa,pci}_create_simple() with a hardcoded type. It also prints a deprecation message. Signed-off-by: Gerd Hoffmann --- include/hw/audio/soundhw.h | 2 ++ hw/audio/soundhw.c | 24 +++

[PATCH 01/12] stubs: add isa_create_simple

2020-04-29 Thread Gerd Hoffmann
Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann --- stubs/isa-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/isa-bus.c diff --git a/stubs/isa-bus.c b/stubs/isa-bus.c new file mode 100644 index ..cbebaed4ad04 ---

[PATCH 06/12] audio: deprecate -soundhw adlib

2020-04-29 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index d6c1fb0586c6..f62fbd413169 100644 --- a/hw/audio/

Re: [PATCH 00/12] audio: deprecate -soundhw

2020-04-29 Thread Daniel P . Berrangé
On Wed, Apr 29, 2020 at 01:02:02PM +0200, Gerd Hoffmann wrote: > include/hw/audio/soundhw.h | 2 ++ > hw/audio/ac97.c| 9 ++--- > hw/audio/adlib.c | 8 +--- > hw/audio/cs4231a.c | 8 +--- > hw/audio/es1370.c | 9 ++--- > hw/audio/gus.c

[PATCH 08/12] audio: deprecate -soundhw gus

2020-04-29 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index eb4a803fb53b..61d16fad9ffb 100644 --- a/hw/audio/gus.c

[PATCH 09/12] audio: deprecate -soundhw sb16

2020-04-29 Thread Gerd Hoffmann
Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/sb16.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index df6f755a37f8..2d9e50f99b5d 100644 --- a/hw/audio/s

[PATCH 10/12] audio: deprecate -soundhw hda

2020-04-29 Thread Gerd Hoffmann
Add deprecation message to the audio init function. Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index e8d18b7c5887..df4f13157d44 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda

[PATCH 11/12] audio: deprecate -soundhw pcspk

2020-04-29 Thread Gerd Hoffmann
Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting audiodev via -global is enough to properly initialize pcspk. Signed-off-by: Gerd Hoffmann --- hw/audio/pcspk.c | 24 +--- 1 file cha

[PATCH 2/3] backup: Make sure that source and target size match

2020-04-29 Thread Kevin Wolf
Since the introduction of a backup filter node, the backup block job crashes when the target image is smaller than the source image because it will try to write after the end of the target node without having BLK_PERM_RESIZE. (Previously, the BlockBackend layer would have caught this and errored ou

[PATCH 0/3] backup: Make sure that source and target size match

2020-04-29 Thread Kevin Wolf
Kevin Wolf (3): backup: Improve error for bdrv_getlength() failure backup: Make sure that source and target size match iotests: Backup with different source/target size block/backup-top.c | 12 +--- block/backup.c | 18 ++-- tests/qemu-iotests/055 | 60 ++

[PATCH 3/3] iotests: Backup with different source/target size

2020-04-29 Thread Kevin Wolf
This tests that the backup jobs catches situations where the target node has a different size than the source node. It must also forbid resize operations when the job is already running. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/055 | 60 -- tests/q

[PATCH 1/3] backup: Improve error for bdrv_getlength() failure

2020-04-29 Thread Kevin Wolf
bdrv_get_device_name() will be an empty string with modern management tools that don't use -drive. Use bdrv_get_device_or_node_name() instead so that the node name is used if the BlockBackend is anonymous. While at it, start with upper case to make the message consistent with the rest of the funct

Re: [PATCH 1/3] backup: Improve error for bdrv_getlength() failure

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 14:15, Kevin Wolf wrote: bdrv_get_device_name() will be an empty string with modern management tools that don't use -drive. Use bdrv_get_device_or_node_name() instead so that the node name is used if the BlockBackend is anonymous. While at it, start with upper case to make the message

Re: [PATCH v3 4/5] block/block-copy: refactor task creation

2020-04-29 Thread Max Reitz
On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: > Instead of just relying on the comment "Called only on full-dirty > region" in block_copy_task_create() let's move initial dirty area > search directly to block_copy_task_create(). Let's also use effective > bdrv_dirty_bitmap_next_dirty_area

Re: [PATCH RESEND v3 1/2] Makefile: libfdt: build only the strict necessary

2020-04-29 Thread Claudio Fontana
just a gentle ping on this one, now that 5.0 is out, is proceeding with this ok? Ciao, Claudio On 4/11/20 11:31 AM, Claudio Fontana wrote: > when building dtc/libfdt, we were previously using dtc/Makefile, > which tries to build some artifacts that are not needed, > and can complain on stderr a

Re: [RFC][PATCH v2 0/3] IVSHMEM version 2 device for QEMU

2020-04-29 Thread Jan Kiszka
On 29.04.20 06:15, Liang Yan wrote: Hi, All, Did a test for these patches, all looked fine. Test environment: Host: opensuse tumbleweed + latest upstream qemu + these three patches Guest: opensuse tumbleweed root fs + custom kernel(5.5) + related uio-ivshmem driver + ivshmem-console/ivshmem-bl

[PATCH v2 0/6] ramfb: a bunch of reverts and fixes

2020-04-29 Thread Gerd Hoffmann
Even though these are bugfixes this is probably 5.1 material at this point ... v2: reorder patches, add patch #6, pick up acks & reviews. Gerd Hoffmann (6): Revert "hw/display/ramfb: initialize fw-config space with xres/ yres" Revert "hw/display/ramfb: lock guest resolution after it's set"

[PATCH v2 2/6] Revert "hw/display/ramfb: lock guest resolution after it's set"

2020-04-29 Thread Gerd Hoffmann
This reverts commit a9e0cb67b7f4c485755659f9b764c38b5f970de4. This breaks OVMF. Reproducer: Just hit 'ESC' at early boot to enter firmware setup. OVMF wants switch from (default) 800x600 to 640x480 for that, and this patch blocks it. Cc: Hou Qiming Signed-off-by: Gerd Hoffmann Reviewed-by: La

[PATCH v2 3/6] ramfb: drop leftover debug message

2020-04-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laszlo Ersek --- hw/display/ramfb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index 9d41c2ad2868..228defee5683 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.

[PATCH v2 4/6] ramfb: don't update RAMFBState on errors

2020-04-29 Thread Gerd Hoffmann
Store width & height & surface in local variables. Update RAMFBState with the new values only in case the ramfb_create_display_surface() call succeeds. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laszlo Ersek --- hw/display/ramfb.c | 25 --

[PATCH v2 1/6] Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"

2020-04-29 Thread Gerd Hoffmann
This reverts commit f79081b4b71b72640bedd40a7cd76f864c8287f1. Patch has broken byteorder handling: RAMFBCfg fields are in bigendian byteorder, the reset function doesn't care so native byteorder is used instead. Given this went unnoticed so far the feature is obviously unused, so just revert the

Re: [PATCH v3 4/5] block/block-copy: refactor task creation

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 14:38, Max Reitz wrote: On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: Instead of just relying on the comment "Called only on full-dirty region" in block_copy_task_create() let's move initial dirty area search directly to block_copy_task_create(). Let's also use effective bdrv

[PATCH v2 5/6] ramfb: add sanity checks to ramfb_create_display_surface

2020-04-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/ramfb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index eb8b4bc49a2f..be884c9ea837 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c @@ -15,6 +15,7 @@ #include "qapi/error.h" #include "hw/

Re: [PATCH v3 5/5] block/block-copy: use aio-task-pool API

2020-04-29 Thread Max Reitz
On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: > Run block_copy iterations in parallel in aio tasks. > > Changes: > - BlockCopyTask becomes aio task structure. Add zeroes field to pass > it to block_copy_do_copy > - add call state - it's a state of one call of block_copy(), shared

[PATCH v2 6/6] ramfb: fix size calculation

2020-04-29 Thread Gerd Hoffmann
size calculation isn't correct with guest-supplied stride, the last display line isn't accounted for correctly. For the typical case of stride > linesize (add padding) we error on the safe side (calculated size is larger than actual size). With stride < linesize (scanlines overlap) the calculated

Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default

2020-04-29 Thread Stefan Berger
On 4/29/20 2:11 AM, Cornelia Huck wrote: On Tue, 28 Apr 2020 16:13:05 -0400 Stefan Berger wrote: On 4/28/20 6:38 AM, Cornelia Huck wrote: On Mon, 27 Apr 2020 16:31:43 +0200 Eric Auger wrote: Instead of using a compat in the mach-virt machine to force PPI off for all virt machines (PPI no

Re: R: About hardfloat in ppc

2020-04-29 Thread Alex Bennée
Dino Papararo writes: > Hello, > about handling of PPC fpu exceptions and Hard Floats support we could > consider a different approach for different instructions. > i.e. not all fpu instructions take care about inexact or exceptions bits: if > I take a simple fadd f0,f1,f2 I'll copy value der

Re: [PATCH v3 4/5] block/block-copy: refactor task creation

2020-04-29 Thread Max Reitz
On 29.04.20 13:54, Vladimir Sementsov-Ogievskiy wrote: > 29.04.2020 14:38, Max Reitz wrote: >> On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: >>> Instead of just relying on the comment "Called only on full-dirty >>> region" in block_copy_task_create() let's move initial dirty area >>> searc

Re: [PATCH 2/3] backup: Make sure that source and target size match

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 14:15, Kevin Wolf wrote: Since the introduction of a backup filter node, the backup block job crashes when the target image is smaller than the source image because it will try to write after the end of the target node without having BLK_PERM_RESIZE. (Previously, the BlockBackend layer

Re: [PATCH v3 4/5] block/block-copy: refactor task creation

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 14:56, Max Reitz wrote: On 29.04.20 13:54, Vladimir Sementsov-Ogievskiy wrote: 29.04.2020 14:38, Max Reitz wrote: On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: Instead of just relying on the comment "Called only on full-dirty region" in block_copy_task_create() let's move i

Re: [PATCH v3 5/5] block/block-copy: use aio-task-pool API

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 14:55, Max Reitz wrote: On 29.04.20 08:10, Vladimir Sementsov-Ogievskiy wrote: Run block_copy iterations in parallel in aio tasks. Changes: - BlockCopyTask becomes aio task structure. Add zeroes field to pass it to block_copy_do_copy - add call state - it's a state of one

Re: [PATCH 0/8] pc-bios: s390x: Cleanup part 1

2020-04-29 Thread Janosch Frank
On 3/24/20 4:08 PM, Janosch Frank wrote: > The bios is in dire need for a cleanup as there are still a lot of > magic constants being used throughout as well as duplicated code. > > In the first part of this series we consolidate constants and > functions, as well as doing some minor cleanups and

Re: [PATCH v22 3/4] qcow2: add zstd cluster compression

2020-04-29 Thread Max Reitz
On 29.04.20 12:37, Vladimir Sementsov-Ogievskiy wrote: > 29.04.2020 13:24, Max Reitz wrote: >> On 28.04.20 22:00, Denis Plotnikov wrote: >>> zstd significantly reduces cluster compression time. >>> It provides better compression performance maintaining >>> the same level of the compression ratio in

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Roman Kagan
On Wed, Apr 29, 2020 at 11:41:04AM +0200, Philippe Mathieu-Daudé wrote: > Cc'ing virtio-blk and scsi maintainers. > > On 4/29/20 11:18 AM, Roman Kagan wrote: > > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > > 32-bit for logical_block_size, physical_block_size, and min_io

Re: [PATCH v22 3/4] qcow2: add zstd cluster compression

2020-04-29 Thread Max Reitz
On 29.04.20 12:38, Denis Plotnikov wrote: > > > On 29.04.2020 13:24, Max Reitz wrote: >> On 28.04.20 22:00, Denis Plotnikov wrote: >>> zstd significantly reduces cluster compression time. >>> It provides better compression performance maintaining >>> the same level of the compression ratio in com

Re: [PATCH 2/2] target/m68k: fix gdb for m68xxx

2020-04-29 Thread KONRAD Frederic
Le 4/29/20 à 11:38 AM, Laurent Vivier a écrit : Le 29/04/2020 à 11:28, Alex Bennée a écrit : Laurent Vivier writes: Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" featur

Re: [PATCH 3/3] iotests: Backup with different source/target size

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 14:15, Kevin Wolf wrote: This tests that the backup jobs catches situations where the target node has a different size than the source node. It must also forbid resize operations when the job is already running. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/055 | 60

Re: [PATCH 1/3] backup: Improve error for bdrv_getlength() failure

2020-04-29 Thread Alberto Garcia
On Wed 29 Apr 2020 01:15:37 PM CEST, Kevin Wolf wrote: > bdrv_get_device_name() will be an empty string with modern management > tools that don't use -drive. Use bdrv_get_device_or_node_name() instead > so that the node name is used if the BlockBackend is anonymous. > > While at it, start with uppe

Re: [PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-04-29 Thread KONRAD Frederic
Le 4/29/20 à 10:42 AM, Laurent Vivier a écrit : Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : The MC68881 say about infinities (3.2.4): "*For the extended precision format, the most significant bit of the mantissa (the integer bit) is a don't care." https://www.nxp.com/docs/en/reference-

Re: [Virtio-fs] [PATCH] virtiofsd: Show submounts

2020-04-29 Thread Vivek Goyal
On Wed, Apr 29, 2020 at 11:26:49AM +0200, Miklos Szeredi wrote: > On Wed, Apr 29, 2020 at 9:59 AM Miklos Szeredi wrote: > > > > On Tue, Apr 28, 2020 at 9:15 PM Dr. David Alan Gilbert > > wrote: > > > > > So our current sequence is: > > > > > >(new namespace) > > > 1)if (mount(NULL, "/",

Re: R: About hardfloat in ppc

2020-04-29 Thread Yonggang Luo
On Wed, Apr 29, 2020 at 7:57 PM Alex Bennée wrote: > > Dino Papararo writes: > > > Hello, > > about handling of PPC fpu exceptions and Hard Floats support we could > consider a different approach for different instructions. > > i.e. not all fpu instructions take care about inexact or exceptions

Re: [Virtio-fs] [PATCH] virtiofsd: Show submounts

2020-04-29 Thread Vivek Goyal
On Wed, Apr 29, 2020 at 08:34:24AM -0400, Vivek Goyal wrote: > On Wed, Apr 29, 2020 at 11:26:49AM +0200, Miklos Szeredi wrote: > > On Wed, Apr 29, 2020 at 9:59 AM Miklos Szeredi wrote: > > > > > > On Tue, Apr 28, 2020 at 9:15 PM Dr. David Alan Gilbert > > > wrote: > > > > > > > So our current seq

[PATCH] virtiofsd: jail lo->proc_self_fd

2020-04-29 Thread Miklos Szeredi
While it's not possible to escape the proc filesystem through lo->proc_self_fd, it is possible to escape to the root of the proc filesystem itself through "../..". Use a temporary mount for opening lo->proc_self_fd, that has it's root at /proc/self/fd/, preventing access to the ancestor directorie

Re: [PATCH v2 01/17] block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes

2020-04-29 Thread Eric Blake
On 4/29/20 12:05 AM, Vladimir Sementsov-Ogievskiy wrote: 29.04.2020 1:09, Eric Blake wrote: On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote: The function is called from 64bit io handlers, and bytes is just passed to throttle_account() which is 64bit too (unsigned though). So, let's conve

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

2020-04-29 Thread Philippe Mathieu-Daudé
On 4/29/20 2:19 PM, Roman Kagan wrote: On Wed, Apr 29, 2020 at 11:41:04AM +0200, Philippe Mathieu-Daudé wrote: Cc'ing virtio-blk and scsi maintainers. On 4/29/20 11:18 AM, Roman Kagan wrote: Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, ph

Re: [PATCH v3] audio/jack: add JACK client audiodev

2020-04-29 Thread Eric Blake
On 4/29/20 12:53 AM, Geoffrey McRae wrote: This commit adds a new audiodev backend to allow QEMU to use JACK as both an audio sink and source. Signed-off-by: Geoffrey McRae --- audio/Makefile.objs| 5 + audio/audio.c | 1 + audio/audio_template.h | 2 + audio/jackaudio.c

Re: [PATCH v22 3/4] qcow2: add zstd cluster compression

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 15:17, Max Reitz wrote: On 29.04.20 12:37, Vladimir Sementsov-Ogievskiy wrote: 29.04.2020 13:24, Max Reitz wrote: On 28.04.20 22:00, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of t

[PATCH v4 0/5] block-copy: use aio-task-pool

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
Hi all! v4 01: add Max's r-b 04: move variable definition to the top of the block, add Max's r-b 05: - change error-codes in block_copy_task_run(), document them and be more accurate about error code in block_copy_dirty_clusters(). - s/g_free(aio)/aio_task_pool_free(aio)/ == This is th

[PATCH v4 1/5] block/block-copy: rename in-flight requests to tasks

2020-04-29 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API and extend in-flight request structure to be a successor of AioTask, so rename things appropriately. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/block-copy.c | 98 +++--- 1 file change

<    1   2   3   4   >