On 3/24/20 4:08 PM, Janosch Frank wrote: > The bios is in dire need for a cleanup as there are still a lot of > magic constants being used throughout as well as duplicated code. > > In the first part of this series we consolidate constants and > functions, as well as doing some minor cleanups and fixes. > > The patches are based on my protvirt branch and are available here: > https://github.com/frankjaa/qemu/pull/new/cleanup_bios
Ping It's not urgent, but I don't want it to get buried and forgotten. > > Janosch Frank (8): > pc-bios: s390x: Consolidate timing functions into time.h > pc-bios: s390x: Get rid of magic offsets into the lowcore > pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant > pc-bios: s390x: Use PSW masks where possible > pc-bios: s390x: Move panic() into header and add infinite loop > pc-bios: s390x: Use ebcdic2ascii table > pc-bios: s390x: Replace 0x00 with 0x0 or 0 > pc-bios: s390x: Make u32 ptr check explicit > > pc-bios/s390-ccw/bootmap.c | 4 +--- > pc-bios/s390-ccw/cio.h | 17 +++++++++------ > pc-bios/s390-ccw/dasd-ipl.c | 17 +++++++-------- > pc-bios/s390-ccw/helper.h | 2 +- > pc-bios/s390-ccw/jump2ipl.c | 10 ++++----- > pc-bios/s390-ccw/main.c | 15 +++---------- > pc-bios/s390-ccw/menu.c | 1 + > pc-bios/s390-ccw/netmain.c | 23 +++----------------- > pc-bios/s390-ccw/s390-arch.h | 4 +++- > pc-bios/s390-ccw/s390-ccw.h | 25 ++++++---------------- > pc-bios/s390-ccw/start.S | 5 +++-- > pc-bios/s390-ccw/time.h | 39 ++++++++++++++++++++++++++++++++++ > pc-bios/s390-ccw/virtio-net.c | 1 + > pc-bios/s390-ccw/virtio-scsi.c | 1 + > pc-bios/s390-ccw/virtio.c | 18 +++------------- > 15 files changed, 88 insertions(+), 94 deletions(-) > create mode 100644 pc-bios/s390-ccw/time.h >
signature.asc
Description: OpenPGP digital signature
