Re: [PATCH v1 1/2] migration/xbzrle: replace transferred xbzrle bytes with encoded bytes

2020-04-27 Thread Wei Wang
On 04/24/2020 06:47 PM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: On 04/22/2020 03:21 AM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: Like compressed_size which indicates how many bytes are compressed, we need encoded_size to understand h

Re: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-27 Thread Lukas Straub
On Mon, 27 Apr 2020 03:36:57 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Monday, April 27, 2020 5:19 AM > > To: qemu-devel > > Cc: Zhang, Chen ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: [PATCH v3 3/6] n

RE: [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors

2020-04-27 Thread Paul Durrant
> -Original Message- > From: Markus Armbruster > Sent: 24 April 2020 20:20 > To: qemu-devel@nongnu.org > Cc: Stefano Stabellini ; Anthony Perard > ; Paul > Durrant ; Gerd Hoffmann ; > xen-de...@lists.xenproject.org > Subject: [PATCH 02/11] xen: Fix and improve handling of device_add usb-

VIRTIO_NET_HDR_F_RSC_INFO in virtio-net vs headers update

2020-04-27 Thread Cornelia Huck
Hi, I'm currently trying to prepare a linux-headers update to 5.7-rc3, which adds the definition of VIRTIO_NET_HDR_F_RSC_INFO. Unfortunately, this breaks the build of virtio-net, because now virtio_net_rsc_ext_num_{packets,dupacks} are undefined (they are guarded by existence of VIRTIO_NET_HDR_F_

Re: [PATCH] hw: add compat machines for 5.1

2020-04-27 Thread Auger Eric
Hi Connie, On 4/24/20 11:03 AM, Cornelia Huck wrote: > Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > > Still keeping the default cpu model version on x86 at v1. > > I'll queue this to my s390-next branch, as I'm planning to send a pull > req as

Re: [PATCH v4 24/30] qcow2: Clear the L2 bitmap when allocating a compressed cluster

2020-04-27 Thread Max Reitz
On 24.04.20 20:47, Eric Blake wrote: > On 4/24/20 1:37 PM, Alberto Garcia wrote: >> On Fri 24 Apr 2020 08:25:45 PM CEST, Vladimir Sementsov-Ogievskiy >> wrote: > Reading the entire cluster will be interesting - you'll have to > decompress the entire memory, then overwrite the zeroed portio

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

2020-04-27 Thread Laurent Vivier
Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : > From: KONRAD Frederic > > Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is > it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects > a coldfire FPU instead of the default m68881 FPU.

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-04-27 Thread David Hildenbrand
On 24.04.20 21:20, Markus Armbruster wrote: > Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API > violations" neglected to change visit_end_struct()'s Error ** argument > along with the others. If visit_end_struct() failed, we'd take the s/visit_end_struct/visit_check_struct/ ?

[PATCH v3 0/3] RISC-V Spike machine improvements

2020-04-27 Thread Anup Patel
This series improves QEMU Spike machine to: 1. Allow loading OpenBI firmware using -bios option 2. Allow more than one CPUs Changes since v2: - Rebased on QEMU v5.0-rc4 Changes since v1: - Rebased on QEMU master (commit 2ac031d171ccd18c973014d9978b4a63f0ad5fb0) Anup Patel (3): hw/riscv: Add

[PATCH v3 2/3] hw/riscv/spike: Allow loading firmware separately using -bios option

2020-04-27 Thread Anup Patel
This patch extends Spike machine support to allow loading OpenSBI firmware (fw_jump.elf) separately using -bios option. Signed-off-by: Anup Patel --- hw/riscv/spike.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c

[PATCH v3 3/3] hw/riscv/spike: Allow more than one CPUs

2020-04-27 Thread Anup Patel
Currently, the upstream Spike ISA simulator allows more than one CPUs so we update QEMU Spike machine on similar lines to allow more than one CPUs. The maximum number of CPUs for QEMU Spike machine is kept same as QEMU Virt machine. Signed-off-by: Anup Patel --- hw/riscv/spike.c | 2 +- 1 file

[PATCH v3 1/3] hw/riscv: Add optional symbol callback ptr to riscv_load_firmware()

2020-04-27 Thread Anup Patel
This patch adds an optional function pointer, "sym_cb", to riscv_load_firmware() which provides the possibility to access the symbol table during kernel loading. The pointer is ignored, if supplied with flat (non-elf) firmware image. The Spike board requires it locate the HTIF symbols from firmwa

Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread David Hildenbrand
On 24.04.20 18:50, Alexander Duyck wrote: > From: Alexander Duyck > > In an upcoming patch a feature named Free Page Reporting is about to be > added. In order to avoid any confusion we should drop the use of the word > 'report' when referring to Free Page Hinting. So what this patch does is go >

Re: [PATCH v22 QEMU 4/5] virtio-balloon: Implement support for page poison reporting feature

2020-04-27 Thread David Hildenbrand
On 24.04.20 18:50, Alexander Duyck wrote: > From: Alexander Duyck > > We need to make certain to advertise support for page poison reporting if > we want to actually get data on if the guest will be poisoning pages. > > Add a value for reporting the poison value being used if page poisoning is >

Re: [PATCH v22 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting

2020-04-27 Thread David Hildenbrand
On 24.04.20 18:50, Alexander Duyck wrote: > From: Alexander Duyck > > Add support for free page reporting. The idea is to function very similar > to how the balloon works in that we basically end up madvising the page as > not being used. However we don't really need to bother with any deflate >

Re: [PATCH v22 QEMU 0/5] virtio-balloon: add support for page poison reporting and free page reporting

2020-04-27 Thread David Hildenbrand
On 24.04.20 18:50, Alexander Duyck wrote: > This series provides an asynchronous means of reporting free guest pages > to QEMU through virtio-balloon so that the memory associated with those > pages can be discarded and reused by other processes and/or guests on the > host. Using this it is possibl

Re: [RFC patch v1 2/3] qemu-file: add buffered mode

2020-04-27 Thread Denis Plotnikov
On 25.04.2020 00:25, Eric Blake wrote: On 4/13/20 6:12 AM, Denis Plotnikov wrote: The patch adds ability to qemu-file to write the data asynchronously to improve the performance on writing. Before, only synchronous writing was supported. Enabling of the asyncronous mode is managed by new a

[PATCH v2 01/17] block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
The function is called from 64bit io handlers, and bytes is just passed to throttle_account() which is 64bit too (unsigned though). So, let's convert intermediate argument to 64bit too. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/throttle-groups.h | 2 +- block/throttle-groups.

[PATCH v2 00/17] 64bit block-layer

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
Hi all! v1 was "[RFC 0/3] 64bit block-layer part I", please refer to initial cover-letter https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg08723.html for motivation. v2: patch 02 is unchanged, add Stefan's r-b. Everything other is changed a lot. What's new: - conversion of block/io.c i

[PATCH v2 06/17] block/io: support int64_t bytes in bdrv_aligned_pwritev()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Prepare bdrv_aligned_pwritev() now (and convert the dependencies: bdrv_co_write_req_prepare() and bdrv_co_write_req_finish() to signed type bytes) Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c |

[PATCH v2 05/17] block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Prepare bdrv_co_do_pwrite_zeroes() now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/io.c b/block/io.c index 4796

[PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- include/block/block_int.h | 4 ++-- block/io.c| 11 ++- 2 files changed, 8

[PATCH v2 03/17] block/io: use int64_t bytes parameter in bdrv_check_byte_request()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert bdrv_check_byte_request() now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/io.c b/block/io.c index 7cbb8

[PATCH v2 13/17] block: use int64_t instead of uint64_t in driver read handlers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert driver read handlers parameters which are already 64bit to signed type. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 6 +++--- block/backup-top.c| 2 +- block

[PATCH v2 07/17] block/io: support int64_t bytes in bdrv_co_do_copy_on_readv()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Prepare bdrv_co_do_copy_on_readv() now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 6 +++--- block/trace-events | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Prepare bdrv_aligned_preadv() now. Make byte variable in bdrv_padding_rmw_read() int64_t, as it defined only to be passed to bdrv_aligned_preadv(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c

[PATCH v2 09/17] block/io: support int64_t bytes in bdrv_co_p{read, write}v_part()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Prepare bdrv_co_preadv_part() and bdrv_co_pwritev_part() and their remaining dependencies now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 4 ++-- block/io.c|

[PATCH v2 11/17] block/io: use int64_t bytes in copy_range

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert copy_range parameters which are already 64bit to signed type. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 6 +++--- include/block/block_int.h | 12 ++-- block

[PATCH v2 04/17] block/io: use int64_t bytes in driver wrappers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert driver wrappers parameters which are already 64bit to signed type. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 10/17] block/io: support int64_t bytes in read/write wrappers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
Now, when bdrv_co_preadv_part() and bdrv_co_pwritev_part() updated, update all their wrappers. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 10 +- include/block/block_int.h | 4 ++-- block/blkverify.c | 2 +- block/io.c| 17 +++

[PATCH v2 15/17] block: use int64_t instead of uint64_t in copy_range driver handlers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert driver copy_range handlers parameters which are already 64bit to signed type. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 12 ++-- block/file-posix.c|

[PATCH v2 17/17] block: use int64_t instead of int in driver discard handlers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert driver discard handlers bytes parameter to int64_t. This patch just converts handlers where it is obvious that bytes parameter is passed further to 64bit interfaces, and add simple wrappers where it is

[PATCH v2 16/17] block: use int64_t instead of int in driver write_zeroes handlers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert driver write_zeroes handlers bytes parameter to int64_t. This patch just converts handlers where it is obvious that bytes parameter is passed further to 64bit interfaces, and add simple wrappers where

[PATCH v2 12/17] block/block-backend: convert blk io path to use int64_t parameters

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Now bdrv layer is converted, convert blk layer too. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 26 +++ block/block-backend.c | 60 ++

[PATCH v2 14/17] block: use int64_t instead of uint64_t in driver write handlers

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert driver write handlers parameters which are already 64bit to signed type. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 10 +- block/backup-top.c| 3 +--

Re: [RFC patch v1 2/3] qemu-file: add buffered mode

2020-04-27 Thread Denis Plotnikov
On 25.04.2020 12:10, Vladimir Sementsov-Ogievskiy wrote: 13.04.2020 14:12, Denis Plotnikov wrote: The patch adds ability to qemu-file to write the data asynchronously to improve the performance on writing. Before, only synchronous writing was supported. Enabling of the asyncronous mode is ma

Re: VIRTIO_NET_HDR_F_RSC_INFO in virtio-net vs headers update

2020-04-27 Thread Jason Wang
On 2020/4/27 下午3:33, Cornelia Huck wrote: Hi, I'm currently trying to prepare a linux-headers update to 5.7-rc3, which adds the definition of VIRTIO_NET_HDR_F_RSC_INFO. Unfortunately, this breaks the build of virtio-net, because now virtio_net_rsc_ext_num_{packets,dupacks} are undefined (they

Re: [PATCH v2 06/15] qapi: Assert incomplete object occurs only in dealloc visitor

2020-04-27 Thread Markus Armbruster
Eric Blake writes: > On 4/24/20 3:43 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> Signed-off-by: Markus Armbruster > > Double S-o-b is odd. Accident, will tidy up. Thanks!

Re: [PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-27 Thread Markus Armbruster
Eric Blake writes: > On 4/24/20 2:20 PM, Markus Armbruster wrote: >> Replace >> >> error_report("...: %s", ..., error_get_pretty(err)); >> >> by >> >> error_reportf_err(err, "...: ", ...); > > Reviewed-by: Eric Blake > >> >> Signed-off-by: Markus Armbruster >> --- >> chardev/char-so

Re: [PATCH 0/5] QEMU Gating CI

2020-04-27 Thread Andrea Bolognani
On Mon, 2020-04-27 at 01:24 -0400, Cleber Rosa wrote: > On Fri, 24 Apr 2020 08:57:46 +0200 > Erik Skultety wrote: > > On Thu, Apr 23, 2020 at 11:28:21PM +0200, Philippe Mathieu-Daudé > > wrote: > > > Thanks to insist with that point Daniel. I'd rather see every > > > configuration reproducible, so

[PATCH v2] migration/xbzrle: add encoding rate

2020-04-27 Thread Wei Wang
Users may need to check the xbzrle encoding rate to know if the guest memory is xbzrle encoding-friendly, and dynamically turn off the encoding if the encoding rate is low. Signed-off-by: Yi Sun Signed-off-by: Wei Wang --- migration/migration.c | 1 + migration/ram.c | 38 +++

Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-27 Thread Ani Sinha
> On Apr 25, 2020, at 12:14 AM, Eduardo Habkost wrote: > > On Fri, Apr 24, 2020 at 03:23:56PM +, Ani Sinha wrote: >> >> >>> On Apr 22, 2020, at 4:15 PM, Ani Sinha wrote: >>> >>> >>> On Apr 21, 2020, at 8:32 PM, Daniel P. Berrangé wrote: On Tue, Apr 21, 2020 at 0

Re: [PATCH] hw: add compat machines for 5.1

2020-04-27 Thread Cornelia Huck
On Mon, 27 Apr 2020 09:43:33 +0200 Auger Eric wrote: > Hi Connie, > > On 4/24/20 11:03 AM, Cornelia Huck wrote: > > Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. > > > > Signed-off-by: Cornelia Huck > > --- > > > > Still keeping the default cpu model version on x86 at v1. > > > > I'l

Re: VIRTIO_NET_HDR_F_RSC_INFO in virtio-net vs headers update

2020-04-27 Thread Cornelia Huck
On Mon, 27 Apr 2020 16:41:30 +0800 Jason Wang wrote: > > On 2020/4/27 下午3:33, Cornelia Huck wrote: > > Hi, > > > > I'm currently trying to prepare a linux-headers update to 5.7-rc3, > > which adds the definition of VIRTIO_NET_HDR_F_RSC_INFO. > > > > Unfortunately, this breaks the build of virtio

[Bug 1875139] Re: Domain fails to start when 'readonly' device not writable

2020-04-27 Thread Daniel Berrange
Can you provide the full guest XML for this - "/etc/libvirt/qemu/$GUESTNAME.xml", and also the full QEMU command line - "/var/log/libvirt/qemu/$GUESTNAME.xml". We need to see whether the disk is considered read-only from libvirt's POV. -- You received this bug notification because you are a me

Re: [PATCH 10/11] arm/sabrelite: Consistently use &error_fatal in sabrelite_init()

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/24/20 9:20 PM, Markus Armbruster wrote: > Cc: Peter Maydell > Cc: Jean-Christophe Dubois > Signed-off-by: Markus Armbruster > --- > hw/arm/sabrelite.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/arm/sabrelite.c b/hw/arm/sabrelite.c > index e31694bb92.

Re: VIRTIO_NET_HDR_F_RSC_INFO in virtio-net vs headers update

2020-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2020 at 11:10:29AM +0200, Cornelia Huck wrote: > On Mon, 27 Apr 2020 16:41:30 +0800 > Jason Wang wrote: > > > > > On 2020/4/27 下午3:33, Cornelia Huck wrote: > > > Hi, > > > > > > I'm currently trying to prepare a linux-headers update to 5.7-rc3, > > > which adds the definition of

Re: [PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/24/20 9:20 PM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer point

Re: [PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

2020-04-27 Thread Yan Zhao
On Sun, Apr 26, 2020 at 09:04:31AM +0800, Yan Zhao wrote: > On Sat, Apr 25, 2020 at 06:55:33PM +0800, Paolo Bonzini wrote: > > On 17/04/20 09:44, Yan Zhao wrote: > > > for ram device regions, drop guest writes if the regions is read-only. > > > > > > Cc: Philippe Mathieu-Daudé > > > Signed-off-by

Re: [PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 10:53 AM, Markus Armbruster wrote: Eric Blake writes: On 4/24/20 2:20 PM, Markus Armbruster wrote: Replace error_report("...: %s", ..., error_get_pretty(err)); by error_reportf_err(err, "...: ", ...); Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --

Re: [PATCH v3 01/18] exec: Add block comments for watchpoint routines

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > include/hw/core/cpu.h | 23 +++ Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 02/18] exec: Fix cpu_watchpoint_address_matches address length

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > The only caller of cpu_watchpoint_address_matches passes > TARGET_PAGE_SIZE, so the bug is not currently visible. > > Signed-off-by: Richard Henderson > --- > exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: P

Re: [PATCH v2 00/17] 64bit block-layer

2020-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200427082325.10414-1-vsement...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bas

Re: [PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 11:15 AM, Yan Zhao wrote: On Sun, Apr 26, 2020 at 09:04:31AM +0800, Yan Zhao wrote: On Sat, Apr 25, 2020 at 06:55:33PM +0800, Paolo Bonzini wrote: On 17/04/20 09:44, Yan Zhao wrote: for ram device regions, drop guest writes if the regions is read-only. Cc: Philippe Mathieu-Daudé S

[PATCH for-5.1 1/7] configure: Add KVM target support for MIPS64

2020-04-27 Thread Huacai Chen
Preparing for Loongson-3 virtualization, add KVM target support for MIPS64 in configure script. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 23b5e93..7581e65 100755 --- a/con

[PATCH for-5.1 2/7] hw/mips: Implement the kvm_type() hook in MachineClass

2020-04-27 Thread Huacai Chen
MIPS has two types of KVM: TE & VZ, and TE is the default type. Now we can't create a VZ guest in QEMU because it lacks the kvm_type() hook in MachineClass. Besides, libvirt uses a null-machine to detect the kvm capability, so by default it will return "KVM not supported" on a VZ platform. Thus, nu

[PATCH for-5.1 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

2020-04-27 Thread Huacai Chen
Currently, KVM/MIPS only deliver I/O interrupt via IP2, this patch add IP2 delivery as well, because Loongson-3 based machine use both IRQ2 (CPU's IP2) and IRQ3 (CPU's IP3). Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- hw/mips/mips_int.c | 6 ++ 1 file changed, 2 insertions(+

[PATCH for-5.1 4/7] target/mips: Add Loongson-3 CPU definition

2020-04-27 Thread Huacai Chen
Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, we just define a "Loongson-3A" CPU which is corresponding to Loongson-3A R4. Loongson-3A has CONFIG6 and CONFIG7, so add

[PATCH for-5.1 5/7] target/mips: Add more CP0 register for save/restore

2020-04-27 Thread Huacai Chen
Add more CP0 register for save/restore, including: EBase, XContext, PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- target/mips/kvm.c | 212 ++ target/mips/ma

[PATCH for-5.1 6/7] hw/mips: Add Loongson-3 machine support (with KVM)

2020-04-27 Thread Huacai Chen
Add Loongson-3 based machine support, it use i8259 as the interrupt controler and use GPEX as the pci controller. Currently it can only work with KVM, but we will add TCG support in future. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- default-configs/mips64el-softmmu.mak | 1 +

[PATCH for-5.1 7/7] MAINTAINERS: Add myself as Loongson-3 maintainer

2020-04-27 Thread Huacai Chen
Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa9a057..efe840b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1080,6 +1080,12 @@ F: hw/isa/vt82c686.c F: hw/pci-host/bonito.c F: i

Re: [RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted

2020-04-27 Thread Dima Stepanov
On Sun, Apr 26, 2020 at 03:26:58PM +0800, Li Feng wrote: > This patch is trying to fix the same issue with me. > However, our fix is different. > > I think that check the s->reconnect_timer is better. I also thought about your solution: - if (s->reconnect_time) { + if (s->reconnect_time && !s

Re: About hardfloat in ppc

2020-04-27 Thread Alex Bennée
罗勇刚(Yonggang Luo) writes: > Because ppc fpu-helper are always clearing float_flag_inexact, > So is that possible to optimize the performance when float_flag_inexact > are cleared? There was some discussion about this in the last thread about enabling hardfloat for PPC. See the thread: Subj

[Bug 1875139] Re: Domain fails to start when 'readonly' device not writable

2020-04-27 Thread Daniel Berrange
> This issue is introduced in QEMU 4.2.0 (4.1.0 is working fine) That's not neccessarily the case - with QEMU 4.2.0, libvirt switched over to using the new -blockdev command line syntax. When you were testing with 4.1.0, it would have been using the legacy -drive syntax. So the change in behaviour

Re: [PATCH v3 05/18] accel/tcg: Add endian-specific cpu_{ld, st}* operations

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > We currently have target-endian versions of these operations, > but no easy way to force a specific endianness. This can be > helpful if the target has endian-specific operations, or a mode > that swaps endianness. > > Signed-off-by: Rich

Re: VIRTIO_NET_HDR_F_RSC_INFO in virtio-net vs headers update

2020-04-27 Thread Yuri Benditovich
I'd suggest to do the single change in virtio-net.c with RSC definitions from updated linux headers. I can send respective patch if you want On Mon, Apr 27, 2020 at 12:18 PM Michael S. Tsirkin wrote: > On Mon, Apr 27, 2020 at 11:10:29AM +0200, Cornelia Huck wrote: > > On Mon, 27 Apr 2020 16:41:3

Re: [PATCH for-5.1 3/7] hw/mips: Add CPU IRQ3 delivery for KVM

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 11:33 AM, Huacai Chen wrote: > Currently, KVM/MIPS only deliver I/O interrupt via IP2, this patch add > IP2 delivery as well, because Loongson-3 based machine use both IRQ2 > (CPU's IP2) and IRQ3 (CPU's IP3). > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > hw/mi

Re: [PATCH] hw: add compat machines for 5.1

2020-04-27 Thread Auger Eric
Hi Connie, On 4/27/20 11:06 AM, Cornelia Huck wrote: > On Mon, 27 Apr 2020 09:43:33 +0200 > Auger Eric wrote: > >> Hi Connie, >> >> On 4/24/20 11:03 AM, Cornelia Huck wrote: >>> Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. >>> >>> Signed-off-by: Cornelia Huck >>> --- >>> >>> Still keep

Re: [PATCH v3 1/3] block: Add blk_new_with_bs() helper

2020-04-27 Thread Max Reitz
On 24.04.20 21:09, Eric Blake wrote: > There are several callers that need to create a new block backend from > an existing BDS; make the task slightly easier with a common helper > routine. > > Suggested-by: Max Reitz > Signed-off-by: Eric Blake > --- > include/sysemu/block-backend.h | 2 ++ >

Re: [PATCH v2 01/17] block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: The function is called from 64bit io handlers, and bytes is just passed to throttle_account() which is 64bit too (unsigned though). So, let's convert intermediate argument to 64bit too. What is the meaning of negative bytes in this functi

Re: [PATCH v2 00/17] 64bit block-layer

2020-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200427082325.10414-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [PATCH v2 00/17] 64bit block-layer

2020-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200427082325.10414-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH] hw: add compat machines for 5.1

2020-04-27 Thread Cornelia Huck
On Mon, 27 Apr 2020 11:58:28 +0200 Auger Eric wrote: > Hi Connie, > > On 4/27/20 11:06 AM, Cornelia Huck wrote: > > On Mon, 27 Apr 2020 09:43:33 +0200 > > Auger Eric wrote: > > > >> Hi Connie, > >> > >> On 4/24/20 11:03 AM, Cornelia Huck wrote: > >>> Add 5.1 machine types for arm/i440fx/q3

Re: [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. This doesn't seem a strong justification... If I understand correctly this patch, it is safer to use positive signed t

Re: [PATCH] chardev: Add macOS to list of OSes that support -chardev serial

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/26/20 11:09 PM, Mikhail Gusarov wrote: > macOS API for dealing with serial ports/ttys is identical to BSDs. > > Signed-off-by: Mikhail Gusarov > --- > > Note that the same file has a line >> #endif /* linux || sun */ > that is severely out of date. > > chardev/char-serial.c | 2 +- > incl

Re: [PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

2020-04-27 Thread Yan Zhao
On Mon, Apr 27, 2020 at 05:31:48PM +0800, Philippe Mathieu-Daudé wrote: > On 4/27/20 11:15 AM, Yan Zhao wrote: > > On Sun, Apr 26, 2020 at 09:04:31AM +0800, Yan Zhao wrote: > >> On Sat, Apr 25, 2020 at 06:55:33PM +0800, Paolo Bonzini wrote: > >>> On 17/04/20 09:44, Yan Zhao wrote: > for ram de

[PATCH 0/3] headers update and virtio-net fixup

2020-04-27 Thread Cornelia Huck
This updates the headers to Linux 5.7-rc3. Doing so exposes a problem in virtio-net (the #define for compat covers too much), fix it. Note 1: I'd like this to go through s390-next so that I can go ahead with protected virtualization, which needs a headers update. Note 2: Why has t

[PATCH 1/3] virtio-net: fix rsc_ext compat handling

2020-04-27 Thread Cornelia Huck
virtio_net_rsc_ext_num_{packets,dupacks} needs to be available independently of the presence of VIRTIO_NET_HDR_F_RSC_INFO. Fixes: 2974e916df87 ("virtio-net: support RSC v4/v6 tcp traffic for Windows HCK") Signed-off-by: Cornelia Huck --- hw/net/virtio-net.c | 4 ++-- 1 file changed, 2 insertion

[PATCH 2/3] linux-headers: update against Linux 5.7-rc3

2020-04-27 Thread Cornelia Huck
commit 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c Signed-off-by: Cornelia Huck --- include/standard-headers/linux/ethtool.h | 10 +- .../linux/input-event-codes.h | 5 +- include/standard-headers/linux/pci_regs.h | 2 + include/standard-headers/linux/vhost_types.h |

[PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

2020-04-27 Thread Cornelia Huck
VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now. Signed-off-by: Cornelia Huck --- hw/net/virtio-net.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e85d902588b3..7449570c7123 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virt

Re: colo: qemu 4.2.0 vs. qemu 5.0.0-rc2 performance regression

2020-04-27 Thread Dr. David Alan Gilbert
* Lukas Straub (lukasstra...@web.de) wrote: > On Sat, 11 Apr 2020 19:16:54 +0200 > Lukas Straub wrote: > > > Hello Everyone, > > I did some Benchmarking with iperf3 and memtester (to dirty some guest > > memory) > > of colo performance in qemu 4.2.0 and in qemu 5.0.0-rc2 > > with my bugfixes on

Re: About hardfloat in ppc

2020-04-27 Thread BALATON Zoltan
On Mon, 27 Apr 2020, Alex Bennée wrote: 罗勇刚(Yonggang Luo) writes: Because ppc fpu-helper are always clearing float_flag_inexact, So is that possible to optimize the performance when float_flag_inexact are cleared? There was some discussion about this in the last thread about enabling hardflo

Re: VIRTIO_NET_HDR_F_RSC_INFO in virtio-net vs headers update

2020-04-27 Thread Cornelia Huck
On Mon, 27 Apr 2020 12:52:26 +0300 Yuri Benditovich wrote: > I'd suggest to do the single change in virtio-net.c with RSC definitions > from updated linux headers. > I can send respective patch if you want Hm, I already sent something out before I saw your mail... can you please look at that one

Re: [PATCH v3 04/18] accel/tcg: Add probe_access_flags

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > This new interface will allow targets to probe for a page > and then handle watchpoints themselves. This will be most > useful for vector predicated memory operations, where one > page lookup can be used for many operations, and one test

Re: [PATCH v3 06/18] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > Use the "normal" memory access functions, rather than the > softmmu internal helper functions directly. > > Since fb901c905dc3, cpu_mem_index is now a simple extract > from env->hflags and not a large computation. Which means > that it's

Re: [PATCH 0/5] QEMU Gating CI

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 7:12 AM, Cleber Rosa wrote: On Thu, 23 Apr 2020 23:28:21 +0200 Philippe Mathieu-Daudé wrote: [...] In some cases custom runners are acceptable. These runners won't be "gating" but can post informative log and status. Well, I have the feeling that some people maintaining those run

Re: colo: qemu 4.2.0 vs. qemu 5.0.0-rc2 performance regression

2020-04-27 Thread Lukas Straub
On Mon, 27 Apr 2020 11:34:32 +0100 "Dr. David Alan Gilbert" wrote: > * Lukas Straub (lukasstra...@web.de) wrote: > > On Sat, 11 Apr 2020 19:16:54 +0200 > > Lukas Straub wrote: > > > > > Hello Everyone, > > > I did some Benchmarking with iperf3 and memtester (to dirty some guest > > > memory)

Re: [PATCH v3 08/18] target/arm: Add sve infrastructure for page lookup

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > For contiguous predicated memory operations, we want to > minimize the number of tlb lookups performed. We have > open-coded this for sve_ld1_r, but for correctness with > MTE we will need this for all of the memory operations. > > Create

RE: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-04-27 Thread Thanos Makatos
> > I've just shared with you the Google doc we've working on with John > where we've > > been drafting the protocol specification, we think it's time for some first > > comments. Please feel free to comment/edit and suggest more people to > be on the > > reviewers list. > > > > You can also find t

Re: [PATCH v3 13/18] target/arm: Update contiguous first-fault and no-fault loads

2020-04-27 Thread Peter Maydell
On Wed, 22 Apr 2020 at 05:33, Richard Henderson wrote: > > With sve_cont_ldst_pages, the differences between first-fault and no-fault > are minimal, so unify the routines. With cpu_probe_watchpoint, we are able > to make progress through pages with TLB_WATCHPOINT set when the watchpoint > does no

Re: [RFC patch v1 2/3] qemu-file: add buffered mode

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 11:19, Denis Plotnikov wrote: On 25.04.2020 12:10, Vladimir Sementsov-Ogievskiy wrote: 13.04.2020 14:12, Denis Plotnikov wrote: The patch adds ability to qemu-file to write the data asynchronously to improve the performance on writing. Before, only synchronous writing was supported

Re: About hardfloat in ppc

2020-04-27 Thread Alex Bennée
BALATON Zoltan writes: > On Mon, 27 Apr 2020, Alex Bennée wrote: >> 罗勇刚(Yonggang Luo) writes: >>> Because ppc fpu-helper are always clearing float_flag_inexact, >>> So is that possible to optimize the performance when float_flag_inexact >>> are cleared? >> >> There was some discussion about t

Re: [PATCH 4/5] ramfb: add sanity checks to ramfb_create_display_surface

2020-04-27 Thread Gerd Hoffmann
> > -size = (hwaddr)linesize * height; > > -data = cpu_physical_memory_map(addr, &size, false); > > -if (size != (hwaddr)linesize * height) { > > -cpu_physical_memory_unmap(data, size, 0, 0); > > +mapsize = size = stride * (height - 1) + linesize; > > +data = cpu_physica

Re: [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 13:11, Philippe Mathieu-Daudé wrote: On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. This doesn't seem a strong justification... If I understand correctly

Re: [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 11:23, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- include/block/block_int.h | 4 ++-- bloc

Re: [PATCH 0/3] headers update and virtio-net fixup

2020-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2020 at 12:24:12PM +0200, Cornelia Huck wrote: > This updates the headers to Linux 5.7-rc3. Doing so exposes > a problem in virtio-net (the #define for compat covers too much), > fix it. > > Note 1: I'd like this to go through s390-next so that I can go > ahead with protect

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

2020-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2020 at 12:24:15PM +0200, Cornelia Huck wrote: > VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now. > > Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/hw/net/virt

Re: [PATCH 2/3] linux-headers: update against Linux 5.7-rc3

2020-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2020 at 12:24:14PM +0200, Cornelia Huck wrote: > commit 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c > > Signed-off-by: Cornelia Huck virtio and vhost parts: Reviewed-by: Michael S. Tsirkin > --- > include/standard-headers/linux/ethtool.h | 10 +- > .../linux/input-event-c

Re: [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 1:26 PM, Vladimir Sementsov-Ogievskiy wrote: 27.04.2020 13:11, Philippe Mathieu-Daudé wrote: On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. This doesn't

Re: [PATCH v4 25/30] qcow2: Add subcluster support to handle_alloc_space()

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
17.03.2020 21:16, Alberto Garcia wrote: The bdrv_co_pwrite_zeroes() call here fills complete clusters with zeroes, but it can happen that some subclusters are not part of the write request or the copy-on-write. This patch makes sure that only the affected subclusters are overwritten. A potential

  1   2   3   >