On 4/27/20 10:53 AM, Markus Armbruster wrote:
Eric Blake <ebl...@redhat.com> writes:
On 4/24/20 2:20 PM, Markus Armbruster wrote:
Replace
error_report("...: %s", ..., error_get_pretty(err));
by
error_reportf_err(err, "...: ", ...);
Reviewed-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
chardev/char-socket.c | 5 +++--
hw/sd/pxa2xx_mmci.c | 4 ++--
hw/sd/sd.c | 4 ++--
hw/usb/dev-mtp.c | 9 +++++----
qemu-nbd.c | 7 +++----
scsi/qemu-pr-helper.c | 4 ++--
6 files changed, 17 insertions(+), 16 deletions(-)
Although it touches NBD, I'm happy for this to go through your tree
with the larger series.
+++ b/qemu-nbd.c
@@ -856,8 +856,7 @@ int main(int argc, char **argv)
}
tlscreds = nbd_get_tls_creds(tlscredsid, list, &local_err);
if (local_err) {
- error_report("Failed to get TLS creds %s",
- error_get_pretty(local_err));
+ error_reportf_err(local_err, "Failed to get TLS creds ");
Odd one out for not using ':' in the message, but that's independent
of this patch.
The patch is short enough to deviate from "purely mechanical" and stick
in ':' here. Your choice.
Let's deviate, else we might forget about it.
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
