Need BT support in qemu for Zephyr

There was a note about BT support being deprecated. Having it makes developing/testing Zephyr bluetooth vastly easier. I hope it will be retained. Thanks, Dan

Re: [PATCH v2 1/2] virtio-vga: fix virtio-vga bar ordering

On Thu, Apr 23, 2020 at 08:52:58AM -0400, Michael S. Tsirkin wrote: > On Wed, Apr 22, 2020 at 11:54:54PM +0200, Anthoine Bourgeois wrote: > > With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility > > with stdvga. By default, bar #2 is used by virtio modern io bar. > > This bar is

Re: [PATCH 3/3] net/colo-compare.c: Fix deadlock

On Wed, 22 Apr 2020 08:40:40 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Thursday, April 9, 2020 2:34 AM > > To: qemu-devel > > Cc: Zhang, Chen ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: [PATCH 3/3] net

Re: Need BT support in qemu for Zephyr

On Thu, Apr 23, 2020 at 07:33:37AM -0600, Dan Christian wrote: > There was a note about BT support being deprecated. > > Having it makes developing/testing Zephyr > bluetooth vastly easier. > > I hope it will be retained. Unfortunately it has alread

Re: [PATCH RESEND v6 02/36] multi-process: Refactor machine_init and exit notifiers

On 4/23/20 6:13 AM, elena.ufimts...@oracle.com wrote: From: Elena Ufimtseva Relocate machine_int and exit notifiers into common code Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- MAINTAINERS | 1 + Makefile.objs

Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands

Why 'destaticize HMP commands'? On 4/23/20 6:13 AM, elena.ufimts...@oracle.com wrote: From: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Dr. David Alan Gilbert --- hmp-commands.hx| 4 +- monitor

Re: [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice()

On Wed 22 Apr 2020 08:09:53 PM CEST, Vladimir Sementsov-Ogievskiy wrote: >> There's currently an inconsistency now that I think of it: if an image >> has subclusters and QCOW_OFLAG_ZERO set then qcow2_get_cluster_type() >> returns QCOW2_CLUSTER_ZERO_* but qcow2_get_subcluster_type() returns >> QCOW

Re: [PATCH] qcow2: Allow resize of images with internal snapshots

On 4/23/20 8:55 AM, Max Reitz wrote: On 22.04.20 22:53, Eric Blake wrote: We originally refused to allow resize of images with internal snapshots because the v2 image format did not require the tracking of snapshot size, making it impossible to safely revert to a snapshot with a different size t

Re: Need BT support in qemu for Zephyr

I'm new to trying to use qemu+bt (via btproxy) and haven't managed to get anything working. btproxy is launched first, then Zephyr launches qemu via it's west tool. The commands look like: sudo tools/btproxy -u -i 0 -d # in a separate window x86_64-pokysdk-linux/usr/bin/qemu-system-aarch64 -cpu co

Re: Need BT support in qemu for Zephyr

On Thu, Apr 23, 2020 at 08:40:32AM -0600, Dan Christian wrote: > I'm new to trying to use qemu+bt (via btproxy) and haven't managed to get > anything working. > > btproxy is launched first, then Zephyr launches qemu via it's west tool. > The commands look like: > sudo tools/btproxy -u -i 0 -d # in

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

On Thu, Apr 23, 2020 at 1:11 AM David Hildenbrand wrote: > > On 22.04.20 20:21, Alexander Duyck wrote: > > From: Alexander Duyck > > > > We need to make certain to advertise support for page poison tracking if > > we want to actually get data on if the guest will be poisoning pages. > > > > Add a

Re: Need BT support in qemu for Zephyr

On Thu, 23 Apr 2020 at 15:41, Dan Christian wrote: > I'm new to trying to use qemu+bt (via btproxy) and haven't managed to get > anything working. As Dan notes, your command line isn't trying to use any of QEMU's bluetooth support code. More generally, from the point of view of the deprecation-a

[PATCH v6 02/10] block: Add flags to bdrv(_co)_truncate()

Now that block drivers can support flags for .bdrv_co_truncate, expose the parameter in the node level interfaces bdrv_co_truncate() and bdrv_truncate(). Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz --- include/block/bl

[PATCH v6 05/10] raw-format: Support BDRV_REQ_ZERO_WRITE for truncate

The raw format driver can simply forward the flag and let its bs->file child take care of actually providing the zeros. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- block/raw-format.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/r

[PATCH v6 03/10] block-backend: Add flags to blk_truncate()

Now that node level interface bdrv_truncate() supports passing request flags to the block driver, expose this on the BlockBackend level, too. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz --- include/sysemu/block-backend

[PATCH v6 00/10] block: Fix resize (extending) of short overlays

v6: - qcow2: Don't round up end offset [Eric] - qcow2: Use different error messages for different error paths - Request BDRV_REQ_ZERO_WRITE only if the backing file actually covers (part of) the new area (fix regression from v3) [Max] - New patch: Forward ZERO_WRITE flag for full preallocation [M

[PATCH v6 01/10] block: Add flags to BlockDriver.bdrv_co_truncate()

This adds a new BdrvRequestFlags parameter to the .bdrv_co_truncate() driver callbacks, and a supported_truncate_flags field in BlockDriverState that allows drivers to advertise support for request flags in the context of truncate. For now, we always pass 0 and no drivers declare support for any f

[PATCH v6 06/10] file-posix: Support BDRV_REQ_ZERO_WRITE for truncate

For regular files, we always get BDRV_REQ_ZERO_WRITE behaviour from the OS, so we can advertise the flag and just ignore it. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz --- block/file-posix.c | 4 1 file changed,

[PATCH v6 04/10] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't undo any previous preallocation, but just adds the zero flag to all relevant L2 entries. If an external data file is in use, a write_zeroes request to the data

[PATCH v6 09/10] iotests: Test committing to short backing file

Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/274 | 157 ++ tests/qemu-iotests/274.out | 260 + tests/qemu-iotests/group | 1 + 3 files changed, 418 insertions(+) create mode 100755 tests/qemu-iotests/274

[PATCH v6 07/10] block: truncate: Don't make backing file data visible

When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is shorter than its backing file: base.q

[PATCH v6 08/10] iotests: Filter testfiles out in filter_img_info()

We want to keep TEST_IMG for the full path of the main test image, but filter_testfiles() must be called for other test images before replacing other things like the image format because the test directory path could contain the format as a substring. Insert a filter_testfiles() call between both.

[PATCH v6 10/10] qcow2: Forward ZERO_WRITE flag for full preallocation

The BDRV_REQ_ZERO_WRITE is currently implemented in a way that first the image is possibly preallocated and then the zero flag is added to all clusters. This means that a copy-on-write operation may be needed when writing to these clusters, despite having used preallocation, negating one of the maj

Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands

> On Apr 23, 2020, at 10:14 AM, Philippe Mathieu-Daudé > wrote: > > Why 'destaticize HMP commands’? Hi Philippe, Both QEMU & the remote process links the QMP code. QEMU uses all of the QMP commands, whereas, the remote process only uses a subset of this. Therefore, the ‘static’ functions wh

Re: [PATCH RESEND v6 36/36] multi-process: add configure and usage information

> On Apr 23, 2020, at 9:54 AM, 罗勇刚(Yonggang Luo) wrote: > > Does multi-process support on Windows? > I found it use mmap and unix socket for inter-process communication, that may > not support under Windows. Hi Yonggang, We have only tested this on Linux till now. Are you using QEMU with Wi

Re: [PATCH 0/1] KVM support for VMD devices

On Wed, 2020-04-22 at 23:16 -0700, Christoph Hellwig wrote: > On Wed, Apr 22, 2020 at 01:14:44PM -0400, Jon Derrick wrote: > > The two patches (Linux & QEMU) add support for passthrough VMD devices > > in QEMU/KVM. VMD device 28C0 already supports passthrough natively by > > providing the Host Phys

Re: [PATCH v6 04/10] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

On 4/23/20 10:01 AM, Kevin Wolf wrote: If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't undo any previous preallocation, but just adds the zero flag to all relevant L2 entries. If an external data file is in

Re: [PATCH v6 07/10] block: truncate: Don't make backing file data visible

On 4/23/20 10:01 AM, Kevin Wolf wrote: When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is s

Re: [PATCH 1/3] block: use int64_t as bytes type in tracked requests

Am 30.03.2020 um 16:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > We are generally moving to int64_t for both offset and bytes paramaters > on all io paths. Convert tracked requests now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block_int.h | 4 ++-- > block/io.

Re: [PATCH v6 10/10] qcow2: Forward ZERO_WRITE flag for full preallocation

On 4/23/20 10:01 AM, Kevin Wolf wrote: The BDRV_REQ_ZERO_WRITE is currently implemented in a way that first the image is possibly preallocated and then the zero flag is added to all clusters. This means that a copy-on-write operation may be needed when writing to these clusters, despite having us

Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands

On 4/23/20 5:07 PM, Jag Raman wrote: On Apr 23, 2020, at 10:14 AM, Philippe Mathieu-Daudé wrote: Why 'destaticize HMP commands’? Hi Philippe, Both QEMU & the remote process links the QMP code. QEMU uses all of the QMP commands, whereas, the remote process only uses a subset of this. Therefor

[PATCH 10/13] qapi: Clean up visitor's recovery from input with invalid type

An alternate type's visit_type_FOO() fails when it runs into an invalid ->type. If it's an input visit, we then need to free the the object we got from visit_start_alternate(). We do that with qapi_free_FOO(), which uses the dealloc visitor. Trouble is that object is in a bad state: its ->type i

[PATCH 08/13] qapi: Assert output visitors see only valid enum values

output_type_enum() fails when *obj is not a valid value of the enum type. Should not happen. Drop the check, along with its unit tests. qapi_enum_lookup()'s assertion still guards. Signed-off-by: Markus Armbruster --- qapi/qapi-visit-core.c | 9 --- tests/test-qobject-output-

[PATCH 11/13] qapi: Assert non-input visitors see only valid alternate tags

An alternate type's visit_type_FOO() fails when it runs into an invalid ->type. This is appropriate with an input visitor: visit_start_alternate() sets ->type according to the input, and bad input can lead to bad ->type. It should never happen with an output, clone or dealloc visitor: if it did,

[PATCH 06/13] qapi: Assert incomplete object occurs only in dealloc visitor

Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 5 + qapi/qapi-visit-core.c | 5 + scripts/qapi/visit.py | 4 3 files changed, 14 insertions(+) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index a425ea514c..2d40d2fe0f 100644 --- a/include/qapi/visitor.

[PATCH 01/13] qapi: Belatedly update visitor.h's big comment for QAPI modules

Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index c5b23851a1..f8a0fc1ea9 100644 --- a/include/qapi/visitor.h +++ b/include/qapi/visitor.h @@ -58,7 +58,7 @

[PATCH 12/13] qapi: Only input visitors can actually fail

The previous few commits have made this more obvious, and removed the one exception. Time to clarify the documentation, and drop dead error checking. Signed-off-by: Markus Armbruster --- include/qapi/visitor-impl.h | 4 include/qapi/visitor.h | 40 ++--

[PATCH 03/13] qapi: Fix typo in visit_start_list()'s contract

Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index 7f63e4c381..c5d0ce9184 100644 --- a/include/qapi/visitor.h +++ b/include/qapi/visitor.h @@ -345,9 +345,9 @@ voi

[PATCH 05/13] qapi: Polish prose in visitor.h

Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 104 + 1 file changed, 54 insertions(+), 50 deletions(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index 09df7099c6..a425ea514c 100644 --- a/include/qapi/visitor.h +++ b/inclu

[PATCH 09/13] qapi: Assert non-input visitors see only valid narrow integers

visit_type_intN() and visit_type_uintN() fail when the value is out of bounds. This is appropriate with an input visitor: the value comes from input, and input may be bad. It should never happen with the other visitors: the value comes from the caller, and callers must keep it within bounds. Ass

[PATCH 02/13] qapi: Fix the virtual walk example in visitor.h's big comment

Call visit_check_list(). Missed in commit a4a1c70dc7 "qapi: Make input visitors detect unvisited list tails". Drop an irrelevant error_propagate() while there. Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/inc

[PATCH 13/13] qom: Simplify object_property_get_enum()

Signed-off-by: Markus Armbruster --- qom/object.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index 1812f79224..be700e831f 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1550,11 +1550,9 @@ int object_property_get_enum(Object *obj, const cha

[PATCH 04/13] qapi: Document @errp usage more thoroughly in visitor.h

Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index c5d0ce9184..09df7099c6 100644 --- a/include/qapi/visitor.h +++ b/include/qa

Re: [PATCH v6 10/10] qcow2: Forward ZERO_WRITE flag for full preallocation

Am 23.04.2020 um 17:36 hat Eric Blake geschrieben: > On 4/23/20 10:01 AM, Kevin Wolf wrote: > > The BDRV_REQ_ZERO_WRITE is currently implemented in a way that first the > > image is possibly preallocated and then the zero flag is added to all > > clusters. This means that a copy-on-write operation

[PATCH 07/13] qapi: Fix Visitor contract for start_alternate()

The contract demands v->start_alternate() for input and dealloc visitors, but visit_start_alternate() actually requires it for input and clone visitors. Fix the contract, and delete superfluous qapi_dealloc_start_alternate(). Signed-off-by: Markus Armbruster --- include/qapi/visitor-impl.h | 5

Re: [PATCH v9 8/9] virtio-iommu: Implement probe request

Hi Bharat, A few more things found while rebasing On Mon, Mar 23, 2020 at 02:16:16PM +0530, Bharat Bhushan wrote: > This patch implements the PROBE request. Currently supported > page size mask per endpoint is returned. Also append a NONE > property in the end. > > Signed-off-by: Bharat Bhushan

[PATCH 00/13] qapi: Spring cleaning

Markus Armbruster (13): qapi: Belatedly update visitor.h's big comment for QAPI modules qapi: Fix the virtual walk example in visitor.h's big comment qapi: Fix typo in visit_start_list()'s contract qapi: Document @errp usage more thoroughly in visitor.h qapi: Polish prose in visitor.h q

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

On 23.04.20 16:46, Alexander Duyck wrote: > On Thu, Apr 23, 2020 at 1:11 AM David Hildenbrand wrote: >> >> On 22.04.20 20:21, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> We need to make certain to advertise support for page poison tracking if >>> we want to actually get data on if th

Re: [PATCH v6 10/10] qcow2: Forward ZERO_WRITE flag for full preallocation

On 4/23/20 11:04 AM, Kevin Wolf wrote: Hmm. When we get block status, it is very easy to tell that something reads as zero when the qcow2 file has the zero bit set, but when the qcow2 file does not have the zero bit set, we have to then query the format layer whether it reads as zeros (which is

Warnings with GCC 9.3

Hello, I keep seeing these warnings on the latest master with GCC 9.3: /home/pranith/qemu/hw/block/pflash_cfi01.c: In function ‘pflash_mem_read_with_attrs’: /home/pranith/qemu/hw/block/pflash_cfi01.c:667:20: note: parameter passing for argument of type ‘MemTxAttrs’ {aka ‘struct MemTxAttrs’} chan

Re: [PATCH v2 09/36] tcg: Consolidate 3 bits into enum TCGTempKind

On 4/23/20 2:00 AM, Philippe Mathieu-Daudé wrote: >>> @@ -1885,12 +1896,17 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, >>> char *buf, int buf_size, >>> { >>> int idx = temp_idx(ts); >>> >>> -if (ts->temp_global) { >>> +switch (ts->kind) { >>> +case TEMP_FIXED: >>> +cas

Re: [PATCH v6 04/10] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

Am 23.04.2020 um 17:18 hat Eric Blake geschrieben: > On 4/23/20 10:01 AM, Kevin Wolf wrote: > > If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling > > qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't > > undo any previous preallocation, but just adds the zero

Re: Warnings with GCC 9.3

On Thu, 23 Apr 2020 at 17:19, Pranith Kumar wrote: > > Hello, > > I keep seeing these warnings on the latest master with GCC 9.3: > > /home/pranith/qemu/hw/block/pflash_cfi01.c: In function > ‘pflash_mem_read_with_attrs’: > /home/pranith/qemu/hw/block/pflash_cfi01.c:667:20: note: parameter passin

[Bug 1874486] [NEW] Bug in qemu-img when converting to streamOptimized vmdk images

Public bug reported: I reviewed #1006655, and I think I'm already on a newer version, so this is either a regression or a new bug. I have been recently attempting to convert images from raw and qcow2 formats to vmdk. It appears that the option "subformat=streamOptimized" produces a broken or corr

[PATCH RFC] target/arm: Implement SVE2 TBL, TBX

Signed-off-by: Stephen Long These insns don't show up under any SVE2 categories in the manual. But if you lookup each insn, you'll find they have SVE2 variants. --- target/arm/helper-sve.h| 10 +++ target/arm/sve.decode | 5 target/arm/sve_helper.c| 53

Re: [PATCH 0/5] QEMU Gating CI

- Original Message - > From: "Peter Maydell" > To: "Markus Armbruster" > Cc: "Fam Zheng" , "Thomas Huth" , "Beraldo > Leal" , "Erik > Skultety" , "Alex Bennée" , > "Wainer Moschetta" , > "QEMU Developers" , "Wainer dos Santos Moschetta" > , "Willian Rampazzo" > , "Cleber Rosa" , "Ph

[PATCH v1 01/14] linux-user: completely re-write init_guest_space

First we ensure all guest space initialisation logic comes through probe_guest_base once we understand the nature of the binary we are loading. The convoluted init_guest_space routine is removed and replaced with a number of pgb_* helpers which are called depending on what requirements we have when

[PATCH v1 02/14] exec/cpu-all: Use bool for have_guest_base

From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- include/exec/cpu-all.h | 2 +- bsd-user/main.c| 4 ++-- linux-user/main.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/e

[PATCH v1 07/14] tests/tcg: better trap gdb failures

It seems older and non-multiarach aware GDBs might not fail gracefully when faced with something they don't know. For example when faced with a target XML for s390x the Ubuntu 18.04 gdb will generate an internal fault and prompt for a core dump. Work around this by invoking GDB in a more batch ori

[PATCH v1 03/14] accel/tcg: Relax va restrictions on 64-bit guests

From: Richard Henderson We cannot at present limit a 64-bit guest to a virtual address space smaller than the host. It will mostly work to ignore this limitation, except if the guest uses high bits of the address space for tags. But it will certainly work better, as presently we can wind up fai

[PATCH v1 04/14] .gitignore: include common build sub-directories

As out-of-tree builds become more common (or rather building in a subdir) we can add a lot of load to "git ls-files" as it hunts down sub-directories that are irrelevant to the source tree. This is especially annoying if you have a prompt that attempts to summarise the current git status on command

[PATCH v1 06/14] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers

From: Philippe Mathieu-Daudé When converted to use GByteArray in commits 462474d760c and a010bdbe719, the call to stfq_p() was removed. This call serialize a float. Since we now use a GByteArray, we can not use stfq_p() directly. Introduce the gdb_get_float64() helper to load a float64 register.

[PATCH v1 05/14] configure: favour gdb-multiarch if we have it

As gdb will generally be talking to "foreign" guests lets use that if we can. Otherwise the chances of gdb barfing are considerably higher. Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 23b5e93752..c587871

[PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis

Hi, This is the current state of my random collection of fixes that didn't make it into 5.0. The gdbstub related fixes will probably get queued up separately (and possibly submitted for stable?) once the tree gets re-opened. We have: - The linux-user guest_base rework (which enable more sanitis

[PATCH v1 08/14] tests/tcg: drop inferior.was_attached() test

This test seems flaky and reports attachment even when we failed to negotiate the architecture. However the fetching of the guest architecture will fail tripping up the gdb AttributeError which will trigger our early no error status exit from the test Signed-off-by: Alex Bennée --- tests/tcg/aar

[PATCH v1 09/14] gdbstub: eliminate gdbserver_fd global

We don't really need to track this fd beyond the initial creation of the socket. We already know if the system has been initialised by virtue of the gdbserver_state so lets remove it. This makes the later re-factoring easier. Signed-off-by: Alex Bennée --- gdbstub.c | 23 ++-

[PATCH v1 11/14] tests/guest-debug: use the unix socket for linux-user tests

Now we have support for debugging over a unix socket for linux-user lets use it in our test harness. Signed-off-by: Alex Bennée --- tests/guest-debug/run-test.py | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/ru

[PATCH v1 14/14] .travis.yml: drop MacOSX

This keeps breaking on Travis so lets just fall back to the Cirrus CI builds which seem to be better maintained. Fix up the comments while we are doing this as we never had a windows build. Signed-off-by: Alex Bennée --- .travis.yml | 28 +--- 1 file changed, 1 insertion(

[PATCH v1 13/14] .travis.yml: show free disk space at end of run

Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 2fd63eceaa..a4c3c6c805 100644 --- a/.travis.yml +++ b/.travis.yml @@ -113,6 +113,7 @@ script: $(exit $BUILD_RC); fi after_script: + - df -h - if comman

[PATCH v1 12/14] tests/tcg: add a multiarch linux-user gdb test

When the gdbstub code was converted to the new API we missed a few snafus in the various guests. Add a simple gdb test script which can be used on all our linux-user guests to check for obvious failures. Signed-off-by: Alex Bennée --- v2 - use EXTRA_RUNS to queue the tests so as not to break p

[PATCH v1 10/14] gdbstub/linux-user: support debugging over a unix socket

While debugging over TCP is fairly straightforward now we have test cases that want to orchestrate via make and currently a parallel build fails as two processes can't use the same listening port. While system emulation offers a wide cornucopia of connection methods thanks to the chardev abstractio

Re: [PATCH 0/5] QEMU Gating CI

On Thu, Apr 23, 2020 at 01:04:13PM -0400, Cleber Rosa wrote: > > > - Original Message - > > From: "Peter Maydell" > > To: "Markus Armbruster" > > Cc: "Fam Zheng" , "Thomas Huth" , > > "Beraldo Leal" , "Erik > > Skultety" , "Alex Bennée" , > > "Wainer Moschetta" , > > "QEMU Developers"

Re: [RFC 0/3] 64bit block-layer part I

Am 30.03.2020 um 16:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > There is an idea to make NBD protocol extension to support 64bit > write-zero/discard/block-status commands (commands, which doesn't > transfer user data). It's needed to increase performance of zeroing > large rang

Re: ARM SVE issues with non "standard" vector lengths

On Thu, Apr 23, 2020 at 5:19 PM Richard Henderson wrote: > > On 4/23/20 6:59 AM, Laurent Desnogues wrote: > > 2. sve_zip_p > > > > This generates extraneous data in the higher part of the result. > > > > I hit this when I got a wrong result on an instruction that ends up > > using sve_cntp which c

Re: [PATCH] qcow2: Allow resize of images with internal snapshots

On 23.04.20 16:35, Eric Blake wrote: > On 4/23/20 8:55 AM, Max Reitz wrote: >> On 22.04.20 22:53, Eric Blake wrote: >>> We originally refused to allow resize of images with internal >>> snapshots because the v2 image format did not require the tracking of >>> snapshot size, making it impossible to

Re: [PATCH v4 21/30] qcow2: Add subcluster support to check_refcounts_l2()

On Wed 22 Apr 2020 02:06:56 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an >> image has subclusters. Instead, the individual 'all zeroes' bits must >> be used. >> >> Signed-off-by: Alberto

Re: [PATCH v2 09/36] tcg: Consolidate 3 bits into enum TCGTempKind

On Thu, Apr 23, 2020 at 08:40:10AM -0700, Richard Henderson wrote: > On 4/23/20 2:00 AM, Philippe Mathieu-Daudé wrote: > >>> @@ -1885,12 +1896,17 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, > >>> char *buf, int buf_size, > >>> { > >>> int idx = temp_idx(ts); > >>> > >>> -if (ts->t

Re: [PATCH 01/13] qapi: Belatedly update visitor.h's big comment for QAPI modules

On 4/23/20 11:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualiza

Re: [PATCH v4 22/30] qcow2: Fix offset calculation in handle_dependencies()

On Wed 22 Apr 2020 02:38:54 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> l2meta_cow_start() and l2meta_cow_end() are not necessarily >> cluster-aligned if the image has subclusters, so update the >> calculation of old_start and old_end to guarantee that

Re: [PATCH 03/13] qapi: Fix typo in visit_start_list()'s contract

On 4/23/20 11:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Too much copy-and-paste in the original ;) Reviewed-by: Eric Blake diff --git a/include/qapi/visitor.h b/include/qapi/visi

Re: [PATCH 02/13] qapi: Fix the virtual walk example in visitor.h's big comment

On 4/23/20 11:00 AM, Markus Armbruster wrote: Call visit_check_list(). Missed in commit a4a1c70dc7 "qapi: Make input visitors detect unvisited list tails". Drop an irrelevant error_propagate() while there. Aha - you found this because of your error cleanup work ;) Signed-off-by: Markus Arm

Re: [PATCH 04/13] qapi: Document @errp usage more thoroughly in visitor.h

On 4/23/20 11:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH 0/5] QEMU Gating CI

- Original Message - > From: "Daniel P. Berrangé" > To: "Cleber Rosa" > Cc: "Peter Maydell" , "Fam Zheng" > , "Thomas Huth" , > "Beraldo Leal" , "Erik Skultety" , > "Philippe Mathieu-Daudé" > , "Wainer Moschetta" , "Markus > Armbruster" , "Wainer dos > Santos Moschetta" , "QEMU Deve

Re: [PATCH] qcow2: Allow resize of images with internal snapshots

On 4/23/20 12:21 PM, Max Reitz wrote: The previous comment was incorrect as well, but actually qcow2_truncate_bitmaps_check() doesn’t return an error when there is any bitmap, but only if there are non-active bitmaps, or active bitmaps that cannot be modified.  So for non-disabled bitmaps, we ge

Re: [PATCH 0/5] QEMU Gating CI

On Thu, 23 Apr 2020 at 18:37, Cleber Rosa wrote: > We're already using the shared x86 runners, but with a different goal. The > goal of the "Gating CI" is indeed to expand on non-x86 environments. We're > in a "chicken and egg" kind of situation, because we'd like to prove that > GitLab CI will

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

On Thu, Apr 23, 2020 at 9:02 AM David Hildenbrand wrote: > > On 23.04.20 16:46, Alexander Duyck wrote: > > On Thu, Apr 23, 2020 at 1:11 AM David Hildenbrand wrote: > >> > >> On 22.04.20 20:21, Alexander Duyck wrote: > >>> From: Alexander Duyck > >>> > >>> We need to make certain to advertise sup

Re: [PATCH 05/13] qapi: Polish prose in visitor.h

On 4/23/20 11:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 104 + 1 file changed, 54 insertions(+), 50 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH 06/13] qapi: Assert incomplete object occurs only in dealloc visitor

On 4/23/20 11:00 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 5 + qapi/qapi-visit-core.c | 5 + scripts/qapi/visit.py | 4 3 files changed, 14 insertions(+) Nice enforcement of the contract. Reviewed-by: Eric Blake -- Eric Bl

Re: [PATCH 07/13] qapi: Fix Visitor contract for start_alternate()

On 4/23/20 11:00 AM, Markus Armbruster wrote: The contract demands v->start_alternate() for input and dealloc visitors, but visit_start_alternate() actually requires it for input and clone visitors. Fix the contract, and delete superfluous qapi_dealloc_start_alternate(). Signed-off-by: Markus A

[Bug 1874504] [NEW] VFIO passthrough spits out thousands of messages

Public bug reported: started qemu as: sudo qemu-system-sparc64 -device vfio-pci,host=0b:05.0,x-no-mmap=on,bus=pciB messages received thousands of times: qemu-system-sparc64: -device vfio-pci,host=0b:05.0,x-no-mmap=on,bus=pciB: iommu has granularity incompatible with target AS qemu-system-sparc6

Re: [PATCH 08/13] qapi: Assert output visitors see only valid enum values

On 4/23/20 11:00 AM, Markus Armbruster wrote: output_type_enum() fails when *obj is not a valid value of the enum type. Should not happen. Drop the check, along with its unit tests. qapi_enum_lookup()'s assertion still guards. Signed-off-by: Markus Armbruster --- qapi/qapi-visit-core.c

Re: [PATCH 09/13] qapi: Assert non-input visitors see only valid narrow integers

On 4/23/20 11:00 AM, Markus Armbruster wrote: visit_type_intN() and visit_type_uintN() fail when the value is out of bounds. This is appropriate with an input visitor: the value comes from input, and input may be bad. It should never happen with the other visitors: the value comes from the call

[PATCH RFC] target/arm: Implement SVE2 SPLICE, EXT

Signed-off-by: Stephen Long I'm not sure I can just use the SVE helper functions for the SVE2 variants of EXT and SPLICE. --- target/arm/sve.decode | 8 target/arm/translate-sve.c | 39 +- 2 files changed, 42 insertions(+), 5 deletions(-) diff

Re: [PATCH v6 10/10] qcow2: Forward ZERO_WRITE flag for full preallocation

On 23.04.20 17:01, Kevin Wolf wrote: > The BDRV_REQ_ZERO_WRITE is currently implemented in a way that first the > image is possibly preallocated and then the zero flag is added to all > clusters. This means that a copy-on-write operation may be needed when > writing to these clusters, despite havin

Re: [PATCH v6 07/10] block: truncate: Don't make backing file data visible

On 23.04.20 17:01, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > Consider the following scenario where the overla

Re: [PATCH 10/13] qapi: Clean up visitor's recovery from input with invalid type

On 4/23/20 11:00 AM, Markus Armbruster wrote: An alternate type's visit_type_FOO() fails when it runs into an invalid ->type. If it's an input visit, we then need to free the the object we got from visit_start_alternate(). We do that with qapi_free_FOO(), which uses the dealloc visitor. Troubl

Re: [PATCH 11/13] qapi: Assert non-input visitors see only valid alternate tags

On 4/23/20 11:00 AM, Markus Armbruster wrote: An alternate type's visit_type_FOO() fails when it runs into an invalid ->type. This is appropriate with an input visitor: visit_start_alternate() sets ->type according to the input, and bad input can lead to bad ->type. It should never happen with

Re: [PATCH v3 2/9] blockdev: Remove dead assignment

On 22.04.20 15:31, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC blockdev.o > blockdev.c:2744:5: warning: Value stored to 'ret' is never read > ret = blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); > ^ ~~~

Re: [PATCH v3 1/9] block: Avoid dead assignment

On 22.04.20 15:31, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > block.c:3167:5: warning: Value stored to 'ret' is never read > ret = bdrv_fill_options(&options, filename, &flags, &local_err); > ^ ~

Re: [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis

Patchew URL: https://patchew.org/QEMU/20200423170557.31106-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis Message-id: 20200423170557.31106-1-alex.ben...

<    1   2   3   >