> On Apr 23, 2020, at 10:14 AM, Philippe Mathieu-Daudé <phi...@redhat.com>
> wrote:
>
> Why 'destaticize HMP commands’?
Hi Philippe,
Both QEMU & the remote process links the QMP code. QEMU uses
all of the QMP commands, whereas, the remote process only uses a
subset of this. Therefore, the ‘static’ functions which don’t have a
reference cause build errors (like defined but not used). Therefore,
we decided to destaticize the ones that are causing the build failure.
On a different note, Dave had previously suggested destacizing only the
HMP functions used by the remote process. However, we found out that this is
not possible because without all these functions, the build error still
reproduces.
We did confirm that all the functions we have destaticized are necessary to
help with build of the remote process.
Thank you very much!
--
Jag
>
> On 4/23/20 6:13 AM, elena.ufimts...@oracle.com wrote:
>> From: Jagannathan Raman <jag.ra...@oracle.com>
>> Signed-off-by: Elena Ufimtseva <elena.ufimts...@oracle.com>
>> Signed-off-by: John G Johnson <john.g.john...@oracle.com>
>> Signed-off-by: Jagannathan Raman <jag.ra...@oracle.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
>> ---
>> hmp-commands.hx | 4 +-
>> monitor/misc.c | 76 +++++++++++++++++++-------------------
>> monitor/monitor-internal.h | 38 +++++++++++++++++++
>> 3 files changed, 78 insertions(+), 40 deletions(-)
>
