Re: [PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 3:48 PM, Markus Armbruster wrote: Improve $ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096 qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB DIMM/bank supported qemu-system-ppc: Possible valid RAM size: 2048 to qemu-system-ppc: at most 1 bank

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Michael S. Tsirkin
On Wed, Apr 22, 2020 at 12:49:41PM +0200, Gerd Hoffmann wrote: > On Wed, Apr 22, 2020 at 02:04:36AM -0400, Michael S. Tsirkin wrote: > > On Tue, Apr 21, 2020 at 11:48:53PM +0200, Anthoine Bourgeois wrote: > > > With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility > > > with stdv

Re: [PATCH v2 08/14] virtio-net: Fix duplex=... and speed=... error handling

2020-04-22 Thread Michael S. Tsirkin
On Wed, Apr 22, 2020 at 03:07:13PM +0200, Markus Armbruster wrote: > virtio_net_device_realize() rejects invalid duplex and speed values. > The error handling is broken: > > $ ../qemu/bld-sani/x86_64-softmmu/qemu-system-x86_64 -S -display none > -monitor stdio > QEMU 4.2.93 monitor - type

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread BALATON Zoltan
On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to

Re: [RFC 0/3] 64bit block-layer part I

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
Any thoughts here? I need to resend to update some more functions as patchew said. Is it OK in general? Or should we instead convert everything to uint64_t ? 30.03.2020 17:18, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is an idea to make NBD protocol extension to support 64bit write-ze

Re: [PATCH v2 0/6] block-copy: use aio-task-pool

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
ping :) 25.03.2020 16:46, Vladimir Sementsov-Ogievskiy wrote: Hi all! This is the next step of improving block-copy: use aio task pool. Async copying loop has better performance than linear, which is shown in original series (was "[RFC 00/24] backup performance: block_status + async", so this

Re: [PATCH v2 1/4] sam460ex: Suppress useless warning on -m 32 and -m 64

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 3:48 PM, Markus Armbruster wrote: Requesting 32 or 64 MiB of RAM with the sam460ex machine type produces a useless warning: qemu-system-ppc: warning: Memory size is too small for SDRAM type, adjusting type This is because sam460ex_init() asks spd_data_generate() for DDR2, which

Re: [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff

2020-04-22 Thread Eric Blake
On 4/22/20 8:35 AM, Philippe Mathieu-Daudé wrote: Hi Markus, On 4/22/20 3:07 PM, Markus Armbruster wrote: Fixes: 58e19e6e7914354242a67442d0006f9e31684d1a Signed-off-by: Markus Armbruster ---   tests/test-logging.c | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/t

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.  Passing an argument of the latter kind twice without clearing it in between is wrong: if the first

Re: [RFC 0/3] 64bit block-layer part I

2020-04-22 Thread Eric Blake
On 4/22/20 9:29 AM, Vladimir Sementsov-Ogievskiy wrote: Any thoughts here? I need to resend to update some more functions as patchew said. Is it OK in general? Or should we instead convert everything to uint64_t ? I definitely prefer int64_t as our base (off_t is signed as well, making 63 bi

Re: [PATCH v2 14/14] qga: Fix qmp_guest_suspend_{disk, ram}() error handling

2020-04-22 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/22/20 3:07 PM, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> first

Re: [PATCH v2 11/36] tcg: Introduce TYPE_CONST temporaries

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > These will hold a single constant for the duration of the TB. > They are hashed, so that each value has one temp across the TB. > > Not used yet, this is all infrastructure. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h | 27 ++- > tcg/opt

Re: [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff

2020-04-22 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > > On 4/22/20 3:07 PM, Markus Armbruster wrote: >> Fixes: 58e19e6e7914354242a67442d0006f9e31684d1a >> Signed-off-by: Markus Armbruster >> --- >> tests/test-logging.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/te

[PATCH v5 2/9] block: Add flags to bdrv(_co)_truncate()

2020-04-22 Thread Kevin Wolf
Now that block drivers can support flags for .bdrv_co_truncate, expose the parameter in the node level interfaces bdrv_co_truncate() and bdrv_truncate(). Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- include/block/block.h | 5 +++--

[PATCH v5 1/9] block: Add flags to BlockDriver.bdrv_co_truncate()

2020-04-22 Thread Kevin Wolf
This adds a new BdrvRequestFlags parameter to the .bdrv_co_truncate() driver callbacks, and a supported_truncate_flags field in BlockDriverState that allows drivers to advertise support for request flags in the context of truncate. For now, we always pass 0 and no drivers declare support for any f

[PATCH v5 0/9] block: Fix resize (extending) of short overlays

2020-04-22 Thread Kevin Wolf
v5: - Fixed file-win32 [Patchew] - Fixed zeroing in qcow2 for unaligned requests + tests [Vladimir] - Made raw-format code more consistent [Eric] - Leave output for existing iotests cases unchanged [Vladimir] v4: - Rewrote the series to move the actual zeroing to the block drivers so that error

[PATCH v5 6/9] file-posix: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Kevin Wolf
For regular files, we always get BDRV_REQ_ZERO_WRITE behaviour from the OS, so we can advertise the flag and just ignore it. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/file-posix.c | 4 1 file changed, 4 insertions(+) diff --

[PATCH v5 3/9] block-backend: Add flags to blk_truncate()

2020-04-22 Thread Kevin Wolf
Now that node level interface bdrv_truncate() supports passing request flags to the block driver, expose this on the BlockBackend level, too. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- include/sysemu/block-backend.h | 2 +- block.c

[PATCH v5 4/9] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Kevin Wolf
If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't undo any previous preallocation, but just adds the zero flag to all relevant L2 entries. If an external data file is in use, a write_zeroes request to the data

[PATCH v5 5/9] raw-format: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Kevin Wolf
The raw format driver can simply forward the flag and let its bs->file child take care of actually providing the zeros. Signed-off-by: Kevin Wolf --- block/raw-format.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/raw-format.c b/block/raw-format.c index 3465c9a865

[PATCH v5 9/9] iotests: Test committing to short backing file

2020-04-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/274 | 157 ++ tests/qemu-iotests/274.out | 260 + tests/qemu-iotests/group | 1 + 3 files changed, 418 insertions(+) create mode 100755 tests/qemu-iotests/274 create mode 100644 test

[PATCH v5 8/9] iotests: Filter testfiles out in filter_img_info()

2020-04-22 Thread Kevin Wolf
We want to keep TEST_IMG for the full path of the main test image, but filter_testfiles() must be called for other test images before replacing other things like the image format because the test directory path could contain the format as a substring. Insert a filter_testfiles() call between both.

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-04-22 Thread Stefan Hajnoczi
On Mon, Apr 20, 2020 at 11:05:25AM +, Thanos Makatos wrote: > > In order to interoperate we'll need to maintain a protocol > > specification. Mayb You and JJ could put that together and CC the vfio, > > rust-vmm, and QEMU communities for discussion? > > > > It should cover the UNIX domain soc

[PATCH v5 7/9] block: truncate: Don't make backing file data visible

2020-04-22 Thread Kevin Wolf
When extending the size of an image that has a backing file larger than its old size, make sure that the backing file data doesn't become visible in the guest, but the added area is properly zeroed out. Consider the following scenario where the overlay is shorter than its backing file: base.q

Re: [RFC PATCH v2 1/5] crypto/secret: rename to secret_interface.

2020-04-22 Thread Daniel P . Berrangé
On Thu, Apr 16, 2020 at 01:25:21AM +0300, Alexey Krasikov wrote: > * Rename for future division into subclasses. Most part of the interface > will remain in basic common class. You don't need to put bullet points in the commit message, just have the text. > > Signed-off-by: Alexey Krasikov >

Re: [PATCH v5 4/9] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Eric Blake
On 4/22/20 10:21 AM, Kevin Wolf wrote: If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't undo any previous preallocation, but just adds the zero flag to all relevant L2 entries. If an external data file is in

[PATCH RFC] target/arm: Implement SVE2 gather load insns

2020-04-22 Thread Stephen Long
Add decoding logic for SVE2 64-bit/32-bit gather non-temporal load insns. 64-bit * LDNT1SB * LDNT1B (vector plus scalar) * LDNT1SH * LDNT1H (vector plus scalar) * LDNT1SW * LDNT1W (vector plus scalar) * LDNT1D (vector plus scalar) 32-bit * LDNT1SB * LDNT1B (vector plus scalar) * LDNT1SH * LDNT1H

Re: [PATCH v5 5/9] raw-format: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Eric Blake
On 4/22/20 10:21 AM, Kevin Wolf wrote: The raw format driver can simply forward the flag and let its bs->file child take care of actually providing the zeros. Signed-off-by: Kevin Wolf --- block/raw-format.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake

Re: [PATCH 1/3] block: use int64_t as bytes type in tracked requests

2020-04-22 Thread Stefan Hajnoczi
On Mon, Mar 30, 2020 at 05:18:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes paramaters > on all io paths. Convert tracked requests now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block_int.h | 4 ++-- >

Re: [PATCH v2 12/36] tcg: Use tcg_constant_i32 with icount expander

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > We must do this before we adjust how tcg_out_movi_i32, > lest the under-the-hood poking that we do be broken. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/exec/gen-icount.h | 25 + > 1 file changed, 13 ins

Re: [RFC PATCH v2 4/5] crypto/linux_keyring: add 'syskey' secret object.

2020-04-22 Thread Daniel P . Berrangé
On Thu, Apr 16, 2020 at 01:25:24AM +0300, Alexey Krasikov wrote: > * Add the ability for the secret object to obtain secret data from the > Linux in-kernel key managment and retention facility, as an extra option > to the existing ones: reading from a file or passing directly as a > string. >

Re: [RFC PATCH v2 5/5] test-crypto-secret: add 'syskey' object tests.

2020-04-22 Thread Daniel P . Berrangé
On Thu, Apr 16, 2020 at 01:25:25AM +0300, Alexey Krasikov wrote: > * test_secret_seckey_bad_key_access_right() is not working yet. > We don't know yet if this due a bag in the Linux kernel or > whether it's normal syscall behavior. > We've requested information from kernel maintainer. > > Si

Re: [PATCH 2/2] crypto/secret: fix return logic of crypto_secret_prop_get_loaded()

2020-04-22 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 11:13:36PM +0300, Alexey Krasikov wrote: > * Get function returned value of properties 'data' insteed of returning > value of raw data internal field. This error did not affect anyone, > because no one called the get function. > > Signed-off-by: Alexey Krasikov > --- >

Re: [PATCH 2/3] block/io: convert generic io path to use int64_t parameters

2020-04-22 Thread Stefan Hajnoczi
On Mon, Mar 30, 2020 at 05:18:17PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -875,9 +875,9 @@ static bool coroutine_fn > bdrv_wait_serialising_requests(BdrvTrackedRequest *self > } > > static int bdrv_check_byte_request(BlockDriverState *bs, int64_t offset, > -

Re: [PATCH 1/2] crypto/secret: fix inconsequential errors.

2020-04-22 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 11:13:35PM +0300, Alexey Krasikov wrote: > * change condition from QCRYPTO_SECRET_FORMAT_RAW > to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because > this is potencial error if you add another format value. I'll drop the bullet point. > > Signed-off-by: Alexey Kras

Re: [RFC 0/3] 64bit block-layer part I

2020-04-22 Thread Stefan Hajnoczi
On Mon, Mar 30, 2020 at 05:18:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is an idea to make NBD protocol extension to support 64bit > write-zero/discard/block-status commands (commands, which doesn't > transfer user data). It's needed to increase performance of zeroing > l

Re: [PATCH v5 4/9] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Kevin Wolf
Am 22.04.2020 um 17:33 hat Eric Blake geschrieben: > On 4/22/20 10:21 AM, Kevin Wolf wrote: > > If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling > > qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't > > undo any previous preallocation, but just adds the zero

Re: FYI GitHub pull request / issue tracker lockdown bot

2020-04-22 Thread Stefan Hajnoczi
On Fri, Apr 03, 2020 at 03:22:13PM +0100, Daniel P. Berrangé wrote: > QEMU, like libvirt, has a github.com project which contains automated > read-only mirrors of QEMU repositories. > > https://github.com/qemu/ > > An unfortunate side effect of this is that some users will try to open > pull re

Re: [PATCH 1/2] crypto/secret: fix inconsequential errors.

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/15/20 10:13 PM, Alexey Krasikov wrote: * change condition from QCRYPTO_SECRET_FORMAT_RAW to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because this is potencial error if you add another format value. Signed-off-by: Alexey Krasikov --- crypto/secret.c | 2 +- 1 file changed, 1 in

Re: [PATCH v2 14/14] qga: Fix qmp_guest_suspend_{disk, ram}() error handling

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 5:17 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 4/22/20 3:07 PM, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing i

Re: [edk2-discuss] Load Option passing. Either bugs or my confusion.

2020-04-22 Thread Laszlo Ersek
On 04/22/20 09:42, Hou Qiming wrote: > A little off topic thing: isn't the default resolution supposed to be > 1024x768? No. > This is the Microsoft regulation which all my physical devices > seem to follow: > > https://docs.microsoft.com/en-us/windows-hardware/test/hlk/testref/6afc8979-df62-4d8

Re: [PATCH 5/9] block/io: expand in_flight inc/dec section: simple cases

2020-04-22 Thread Stefan Hajnoczi
On Wed, Apr 22, 2020 at 04:47:07PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 20.04.2020 19:22, Stefan Hajnoczi wrote: > > On Wed, Apr 08, 2020 at 12:30:47PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > It's safer to expand in_flight request to start before enter to > > > > Please expla

Re: [PATCH v5 4/9] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

2020-04-22 Thread Eric Blake
On 4/22/20 10:58 AM, Kevin Wolf wrote: @@ -4214,6 +4215,35 @@ static int coroutine_fn qcow2_co_truncate(BlockDriverState *bs, int64_t offset, g_assert_not_reached(); } +if ((flags & BDRV_REQ_ZERO_WRITE) && offset > old_length) { +uint64_t zero_start = QEMU_ALIGN_UP

Re: [PATCH 1/5] Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"

2020-04-22 Thread Laszlo Ersek
On 04/22/20 12:02, Gerd Hoffmann wrote: > This reverts commit f79081b4b71b72640bedd40a7cd76f864c8287f1. > > Patch has broken byteorder handling: RAMFBCfg fields are in bigendian > byteorder, the reset function doesn't care so native byteorder is used > instead. Given this went unnoticed so far th

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > include/tcg/tcg-op.h | 13 +-- > tcg/tcg-op.c | 216 --- > 2 files changed, 100 insertions(+), 129 deletions(-) > > diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h >

Re: Integration of qemu-img

2020-04-22 Thread Stefan Hajnoczi
On Thu, Apr 16, 2020 at 09:50:48AM +0200, Markus Armbruster wrote: > Cc: qemu-block > > writes: > > > Dear Sir or Madam, > > > > > > > > I am a PhD student at the Friedrich-Alexander-University Erlangen-Nürnberg > > in Bavaria Germany and I am currently working on an open-source forensic > > a

Re: qemu 4.2.0 audiodev soundhw

2020-04-22 Thread Philippe Mathieu-Daudé
Hi Jakob, On 4/21/20 12:06 AM, Jakob Bohm wrote: [...] In fact, over the years, I have found it excruciatingly difficult to find valid qemu documentation, as each feature effort tends to leave behind half-updated pages and a bunch of uncoordinated messages about what may or may not have been im

Re: AF_UNIX Monitor Device

2020-04-22 Thread Stefan Hajnoczi
On Tue, Apr 14, 2020 at 09:46:00PM -0400, Joshua Abraham wrote: > Hello Stefan, > > This blog post [0] talks about the AF_VSOCK monitoring device > (vsockmon) Stefan upstreamed into Linux a few years ago. It seems to > me the same rationale for enabling packet captures for AF_VSOCK > traffic appli

Re: [PATCH 2/5] Revert "hw/display/ramfb: lock guest resolution after it's set"

2020-04-22 Thread Laszlo Ersek
On 04/22/20 12:02, Gerd Hoffmann wrote: > This reverts commit a9e0cb67b7f4c485755659f9b764c38b5f970de4. > > This breaks OVMF. Reproducer: Just hit 'ESC' at early boot to enter > firmware setup. OVMF wants switch from (default) 800x600 to 640x480 for > that, and this patch blocks it. > > Cc: Hou

Re: [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 4:49 PM, Eric Blake wrote: On 4/22/20 8:35 AM, Philippe Mathieu-Daudé wrote: Hi Markus, On 4/22/20 3:07 PM, Markus Armbruster wrote: Fixes: 58e19e6e7914354242a67442d0006f9e31684d1a Signed-off-by: Markus Armbruster ---   tests/test-logging.c | 4 ++--   1 file changed, 2 insertions(+

Re: [PATCH 3/5] ramfb: don't update RAMFBState on errors

2020-04-22 Thread Laszlo Ersek
On 04/22/20 12:02, Gerd Hoffmann wrote: > Store width & height & surface in local variables. Update RAMFBState > with the new values only in case the ramfb_create_display_surface() call > succeeds. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/ramfb.c | 25 - > 1 f

Re: [PATCH v2 12/14] tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 5:19 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Markus, On 4/22/20 3:07 PM, Markus Armbruster wrote: Fixes: 58e19e6e7914354242a67442d0006f9e31684d1a Signed-off-by: Markus Armbruster --- tests/test-logging.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [PATCH] fuzz: select fuzz target using executable name

2020-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2020 at 02:22:30PM -0400, Alexander Bulekov wrote: > The fuzzers are built into a binary (e.g. qemu-fuzz-i386). To select the > device to fuzz/fuzz target, we usually use the --fuzz-target= argument. > This commit allows the fuzz-target to be specified using the name of the > execut

Re: [PATCH v2] target/arm: Implement SVE2 FMMLA

2020-04-22 Thread Richard Henderson
On 4/22/20 7:15 AM, Stephen Long wrote: > Signed-off-by: Stephen Long > > I'm guessing endianness doesn't matter because we are writing to the > corresponding 32-bit/64-bit in the destination register. > --- > target/arm/cpu.h | 10 + > target/arm/helper-sve.h| 3 +++ > ta

Re: [PATCH] MAINTAINERS: Update Keith Busch's email address

2020-04-22 Thread Keith Busch
On Tue, Apr 21, 2020 at 02:22:36PM +0200, Philippe Mathieu-Daudé wrote: > keith.bu...@intel.com address is being rejected. > Replace by the email address Keith is actively using. > > Signed-off-by: Philippe Mathieu-Daudé Thank you for sending the correction. Acked-by: Keith Busch

Re: [PATCH 4/5] ramfb: add sanity checks to ramfb_create_display_surface

2020-04-22 Thread Laszlo Ersek
On 04/22/20 12:02, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/display/ramfb.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c > index fbe959147dc9..d1b1cb9bb294 100644 > --- a/hw/display/ramfb.c > +++ b/hw/display/ramfb.c

Re: [PATCH 5/5] ramfb: drop leftover debug message

2020-04-22 Thread Laszlo Ersek
On 04/22/20 12:02, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/display/ramfb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c > index d1b1cb9bb294..be884c9ea837 100644 > --- a/hw/display/ramfb.c > +++ b/hw/display/ramfb.c > @@

[PATCH v3] target/arm: Implement SVE2 FMMLA

2020-04-22 Thread Stephen Long
Signed-off-by: Stephen Long Fixed the errors Richard pointed out. --- target/arm/cpu.h | 10 + target/arm/helper-sve.h| 3 +++ target/arm/sve.decode | 4 target/arm/sve_helper.c| 42 ++ target/arm/translate-sve.c | 29

Re: [PATCH v2 11/36] tcg: Introduce TYPE_CONST temporaries

2020-04-22 Thread Richard Henderson
On 4/22/20 8:17 AM, Alex Bennée wrote: >> static inline bool temp_readonly(TCGTemp *ts) >> { >> -return ts->kind == TEMP_FIXED; >> +return ts->kind >= TEMP_FIXED; > > I should have clarified in the previous patch - TEMP_FIXED is a fixed > value, e.g. env or other internal pointer which w

Re: [PATCH v2 14/36] tcg: Use tcg_constant_{i32,vec} with tcg vec expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/tcg-op-vec.c | 63 ++-- > 1 file changed, 34 insertions(+), 29 deletions(-) > > diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c > index f3927089a7.

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Richard Henderson
On 4/22/20 9:18 AM, Alex Bennée wrote: >> void tcg_gen_brcondi_i64(TCGCond cond, TCGv_i64 arg1, int64_t arg2, >> TCGLabel *l) >> { >> -if (cond == TCG_COND_ALWAYS) { >> +if (TCG_TARGET_REG_BITS == 64) { >> +tcg_gen_brcond_i64(cond, arg1, tcg_constant_i64(arg2), l); >> +} else

Re: [PATCH v2 15/36] tcg: Use tcg_constant_{i32, i64} with tcg plugins

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > accel/tcg/plugin-gen.c | 49 +++--- > 1 file changed, 22 insertions(+), 27 deletions(-) > > diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c > index

Re: [PATCH v2 16/36] tcg: Rename struct tcg_temp_info to TempOptInfo

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Fix this name vs our coding style. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/optimize.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --g

[PATCH 2/8] docker.py/build: support binary files in --extra-files

2020-04-22 Thread Paolo Bonzini
Read the --extra-files in binary mode to avoid encoding errors. Signed-off-by: Paolo Bonzini --- tests/docker/docker.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index ad61747bae..85e1dda10f 100755 --- a/tests/dock

[PATCH 1/8] docker.py/build: support -t and -f arguments

2020-04-22 Thread Paolo Bonzini
The docker.py command line is subtly different from docker and podman's, in that the tag and Dockerfile are passed via positional arguments. Remove this gratuitous difference and just parse -f and -t. -f was previously used by --extra-files, only keep the long option. Signed-off-by: Paolo Bonzini

[PATCH 8/8] run-coverity-scan: support --update-tools-only --docker

2020-04-22 Thread Paolo Bonzini
Just build the container when run-coverity-scan is invoked with --update-tools-only --docker. This requires moving the "docker build" logic into the update_coverity_tools function. The only snag is that --update-tools-only --docker requires access to the dockerfile. For now just report an error

[PATCH 7/8] run-coverity-scan: download tools outside the container

2020-04-22 Thread Paolo Bonzini
This lets us look at coverity_tool.md5 across executions of run-coverity-scan and skip the download. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/coverity-scan.docker | 3 +- scripts/coverity-scan/run-coverity-scan| 42 +++--- 2 files changed, 24 insertions(+), 21

[PATCH 4/8] run-coverity-scan: use docker.py

2020-04-22 Thread Paolo Bonzini
Our trusted docker wrapper allows run-coverity-scan to run with both docker and podman. For the "run" phase this is transparent; for the "build" phase however scripts are replaced with a bind mount (-v). This is not an issue because the secret option is meant for secrets stored globally in the sy

[PATCH 0/8] run-coverity-scan: misc improvements, especially for docker mode

2020-04-22 Thread Paolo Bonzini
These include: 1) podman support through tests/docker/docker.py 2) avoiding repeated downloading of the tools in the container, by sharing the cache with the host 3) support for --update-tools-only --docker (though unlike regular --update-tools-only it must be run from within a QEMU source

[PATCH 6/8] run-coverity-scan: use --no-update-tools in docker run

2020-04-22 Thread Paolo Bonzini
Tools are already updated via the docker build. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/run-coverity-scan | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/scripts/coverity-scan/run-coverity-scan b/scripts/coverity-scan/run-coverity-scan index 940342

[PATCH 3/8] run-coverity-scan: get Coverity token and email from special git config section

2020-04-22 Thread Paolo Bonzini
Support a [coverity] section in .git/config. It can be used to retrieve the token and also, if it is different from user.email, the username of the submitter. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/run-coverity-scan | 20 +--- 1 file changed, 13 insertions(+), 7

[PATCH 5/8] run-coverity-scan: add --no-update-tools option

2020-04-22 Thread Paolo Bonzini
Provide a quick way to skip building the container while we figure out how to get caching right. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/run-coverity-scan | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/scripts/coverity-scan/run-cove

Re: FYI GitHub pull request / issue tracker lockdown bot

2020-04-22 Thread Paolo Bonzini
On 22/04/20 18:01, Stefan Hajnoczi wrote: > On Fri, Apr 03, 2020 at 03:22:13PM +0100, Daniel P. Berrangé wrote: >> QEMU, like libvirt, has a github.com project which contains automated >> read-only mirrors of QEMU repositories. >> >> https://github.com/qemu/ >> >> An unfortunate side effect of th

Re: [PATCH 2/8] docker.py/build: support binary files in --extra-files

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 7:23 PM, Paolo Bonzini wrote: Read the --extra-files in binary mode to avoid encoding errors. Signed-off-by: Paolo Bonzini --- tests/docker/docker.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index a

Re: [PATCH 1/8] docker.py/build: support -t and -f arguments

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 7:23 PM, Paolo Bonzini wrote: The docker.py command line is subtly different from docker and podman's, in that the tag and Dockerfile are passed via positional arguments. Remove this gratuitous difference and just parse -f and -t. -f was previously used by --extra-files, only keep the

Re: [PATCH for-5.0?] target/arm: Fix ID_MMFR4 value on AArch64 'max' CPU

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 2:45 PM, Peter Maydell wrote: In commit 41a4bf1feab098da4cd the added code to set the CNP field in ID_MMFR4 for the AArch64 'max' CPU had a typo where it used the wrong variable name, resulting in ID_MMFR4 fields AC2, XNX and LSM being wrong. Fix the typo. Fixes: 41a4bf1feab098da4cd R

Re: [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice()

2020-04-22 Thread Alberto Garcia
On Wed 22 Apr 2020 01:35:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> Two changes are needed in this function: >> >> 1) A full discard deallocates a cluster so we can skip the operation if >> it is already unallocated. With extended L2 entries ho

Re: [PATCH for-5.0?] target/arm: Fix ID_MMFR4 value on AArch64 'max' CPU

2020-04-22 Thread Philippe Mathieu-Daudé
On Wed, Apr 22, 2020 at 7:41 PM Philippe Mathieu-Daudé wrote: > > On 4/22/20 2:45 PM, Peter Maydell wrote: > > In commit 41a4bf1feab098da4cd the added code to set the CNP > > field in ID_MMFR4 for the AArch64 'max' CPU had a typo > > where it used the wrong variable name, resulting in ID_MMFR4 > >

Re: [PATCH] roms: opensbi: Upgrade from v0.6 to v0.7

2020-04-22 Thread Alistair Francis
On Mon, Apr 20, 2020 at 6:34 PM Bin Meng wrote: > > Hi Alistair, > > On Tue, Apr 21, 2020 at 2:41 AM Alistair Francis wrote: > > > > On Mon, Apr 20, 2020 at 6:25 AM Bin Meng wrote: > > > > > > Upgrade OpenSBI from v0.6 to v0.7 and the pre-built bios images. > > > > > > The v0.7 release includes

Re: [PATCH] roms: opensbi: Upgrade from v0.6 to v0.7

2020-04-22 Thread Alistair Francis
On Tue, Apr 21, 2020 at 6:30 PM Bin Meng wrote: > > Hi Alistair, > > On Tue, Apr 21, 2020 at 9:34 AM Bin Meng wrote: > > > > Hi Alistair, > > > > On Tue, Apr 21, 2020 at 2:41 AM Alistair Francis > > wrote: > > > > > > On Mon, Apr 20, 2020 at 6:25 AM Bin Meng wrote: > > > > > > > > Upgrade Open

[PATCH 1/1] pci: vmd: Use Shadow MEMBAR registers for QEMU/KVM guests

2020-04-22 Thread Jon Derrick
VMD device 28C0 provides native guest passthrough of the VMD endpoint through the use of shadow registers that provide Host Physical Addresses to correctly assign bridge windows. A quirk has been added to QEMU's VFIO quirks to emulate the shadow registers for VMD devices which don't support this mo

Re: [PATCH 2/3] block/io: convert generic io path to use int64_t parameters

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
22.04.2020 18:50, Stefan Hajnoczi wrote: On Mon, Mar 30, 2020 at 05:18:17PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -875,9 +875,9 @@ static bool coroutine_fn bdrv_wait_serialising_requests(BdrvTrackedRequest *self } static int bdrv_check_byte_request(BlockDriverState *bs, int64_t o

[PATCH 0/1] KVM support for VMD devices

2020-04-22 Thread Jon Derrick
The two patches (Linux & QEMU) add support for passthrough VMD devices in QEMU/KVM. VMD device 28C0 already supports passthrough natively by providing the Host Physical Address in a shadow register to the guest for correct bridge programming. The QEMU patch emulates the 28C0 mode by creating a sha

[PATCH for QEMU] hw/vfio: Add VMD Passthrough Quirk

2020-04-22 Thread Jon Derrick
The VMD endpoint provides a real PCIe domain to the guest, including bridges and endpoints. The IOMMU performs Host Physical Address to Guest Physical Address translation when assigning downstream endpoint BARs and when translating MMIO addresses. This translation is not desired when assigning bri

Re: [PATCH v2 17/36] tcg/optimize: Adjust TempOptInfo allocation

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Do not allocate a large block for indexing. Instead, allocate > for each temporary as they are seen. > > In general, this will use less memory, if we consider that most > TBs do not touch every target register. This also allows us to > allocate TempOptInfo for new

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > On 4/22/20 9:18 AM, Alex Bennée wrote: >>> void tcg_gen_brcondi_i64(TCGCond cond, TCGv_i64 arg1, int64_t arg2, >>> TCGLabel *l) >>> { >>> -if (cond == TCG_COND_ALWAYS) { >>> +if (TCG_TARGET_REG_BITS == 64) { >>> +tcg_gen_brcond_i64(cond, arg1, tcg_

Re: [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice()

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
22.04.2020 20:42, Alberto Garcia wrote: On Wed 22 Apr 2020 01:35:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: 17.03.2020 21:16, Alberto Garcia wrote: Two changes are needed in this function: 1) A full discard deallocates a cluster so we can skip the operation if it is already unallocat

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Alistair Francis
On Tue, Apr 21, 2020 at 9:10 PM Richard Henderson wrote: > > On 4/21/20 7:34 PM, LIU Zhiwei wrote: > > Ping. > > > > When I port RISU, I find this bug. I can't get the correct registers from > > the > > struct ucontext_t parameter in the signal handler. > > The RISC-V Linux ABI will need to be ex

[PATCH v21 QEMU 0/5] virtio-balloon: add support for free page reporting

2020-04-22 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly impro

[PATCH v21 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with 'h

[PATCH v21 QEMU 1/5] linux-headers: Update to allow renaming of free_page_report_cmd_id

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck Sync to the latest upstream changes for free page hinting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/incl

[PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. Add a value for tracking the poison value being used if page poisoning is enabled. With this we can determine if we will need to sk

[PATCH v21 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into th

[PATCH v21 QEMU 2/5] linux-headers: update to contain virito-balloon free page reporting

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck Sync the latest upstream changes for free page reporting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/standard-headers/linux/v

Re: [RFC 0/3] 64bit block-layer part I

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
30.03.2020 17:18, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is an idea to make NBD protocol extension to support 64bit write-zero/discard/block-status commands (commands, which doesn't transfer user data). It's needed to increase performance of zeroing large ranges (up to the whole image

Re: [PATCH v2 0/4] smbus: SPD fixes

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200422134815.1584-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 0/4] smbus: SPD fixes Message-id: 20200422134815.1584-1-arm...@redhat.com Type: series === TEST SC

Re: [PATCH v2 18/36] tcg/optimize: Use tcg_constant_internal with constant folding

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 17/36] tcg/optimize: Adjust TempOptInfo allocation

2020-04-22 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> Do not allocate a large block for indexing. Instead, allocate >> for each temporary as they are seen. >> >> In general, this will use less memory, if we consider that most >> TBs do not touch every target register. This also allows us to >

Re: [PATCH v2 19/36] tcg/tci: Add special tci_movi_{i32,i64} opcodes

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > The normal movi opcodes are going away. We need something > for TCI to use internally. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/tcg/tcg-opc.h| 8 > tcg/tci.c| 4 ++-- > tcg/tci/tcg-target.inc.c |

Re: [PATCH v2 20/36] tcg: Remove movi and dupi opcodes

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > These are now completely covered by mov from a > TYPE_CONST temporary. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/tcg/tcg-opc.h| 3 --- > tcg/aarch64/tcg-target.inc.c | 3 --- > tcg/arm/tcg-target.inc.c | 1 - >

  1   2   3   >