Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/03/20 16:06, Markus Armbruster wrote: >>> - object initialization should cause no side effects outside the subtree >>> of the object >> >> object_initialize_child() and its users like sysbus_init_child_obj() >> violate this rule: they add a child property to the sub

[PATCH 02/13] acpi: factor out acpi_dsdt_add_fw_cfg()

2020-03-19 Thread Gerd Hoffmann
Add helper function to add fw_cfg device. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-build.c | 50 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 1b0684c433e3..9c98b07116cc 100644 -

[PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
I know that not supporting ACPI in microvm is intentional. If you still don't want ACPI this is perfectly fine, you can use the usual -no-acpi switch to toggle ACPI support. These are the advantages you are going to loose then: (1) virtio-mmio device discovery without command line hacks (tweak

[PATCH 01/13] acpi: make build_madt() more generic.

2020-03-19 Thread Gerd Hoffmann
Remove PCMachineState dependency from build_madt(). Pass AcpiDeviceIf as separate argument instead of depending on PCMachineState->acpi_dev. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-build.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/acpi-build

[PATCH 03/13] microvm: add isa-acpi device

2020-03-19 Thread Gerd Hoffmann
Minimal ACPI device for PCI-less machines like microvm. Signed-off-by: Gerd Hoffmann --- hw/acpi/isa-acpi.c| 114 ++ hw/acpi/Makefile.objs | 1 + 2 files changed, 115 insertions(+) create mode 100644 hw/acpi/isa-acpi.c diff --git a/hw/acpi/isa-acpi

[PATCH 11/13] microvm/acpi: add serial

2020-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-build.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 928e0ee2deeb..b765c31c80b0 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.

[PATCH 04/13] microvm: add minimal acpi support.

2020-03-19 Thread Gerd Hoffmann
$subject says all. Can be disabled using the usual -no-acpi switch. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 3 + hw/i386/acpi-build.c | 124 +++--- hw/i386/microvm.c | 14 + 3 files changed, 133 insertions(+), 8 deletions(

[PATCH 08/13] [testing] seabios: update config & build rules

2020-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile | 5 - roms/config.seabios-128k| 2 ++ roms/config.seabios-microvm | 25 + 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 roms/config.seabios-microvm diff --git a/roms/Makefile b/

[PATCH 12/13] microvm: make virtio irq base runtime configurable

2020-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- hw/i386/acpi-build.c | 6 +++--- hw/i386/microvm.c | 11 +++ 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index 53b2457db752..87828325

[Bug 1868055] [NEW] cannot run golang app with docker, version 17.09.1-ce, disabling core 0 and qemu-arm, version 2.7.

2020-03-19 Thread Dongwhan Kim
Public bug reported: Hello! I figure out that sometimes simple go application is not working. I am using docker + qemu-arm + go( for armv7l). These are version info below. root@VDBS1535:~# docker -v Docker version 17.09.1-ce, build 19e2cf6 bash-3.2# qemu-arm --version qemu-arm version 2.7.0, Co

[PATCH 10/13] microvm/acpi: add rtc

2020-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 3 +++ hw/i386/acpi-build.c | 3 +++ hw/i386/microvm.c | 5 ++--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index da2852a70195..53b2457db752 100644

[PATCH 13/13] microvm/acpi: use GSI 16-23 for virtio

2020-03-19 Thread Gerd Hoffmann
With ACPI enabled and IO-APIC being properly declared in the ACPI tables we can use interrupt lines 16-23 for virtio and avoid shared interrupts. With acpi disabled we continue to use lines 8-15. Signed-off-by: Gerd Hoffmann --- hw/i386/microvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH 06/13] microvm: disable virtio-mmio cmdline hack

2020-03-19 Thread Gerd Hoffmann
... in case we are using ACPI. Signed-off-by: Gerd Hoffmann --- hw/i386/microvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 362d513f38e1..fd753764fc10 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -361,7 +361,7 @@

[PATCH 07/13] [testing] seabios: update submodule to experimental microvm branch

2020-03-19 Thread Gerd Hoffmann
https://git.kraxel.org/cgit/seabios/log/?h=microvm Signed-off-by: Gerd Hoffmann --- roms/seabios | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/seabios b/roms/seabios index f21b5a4aeb02..81a6f4b87318 16 --- a/roms/seabios +++ b/roms/seabios @@ -1 +1 @@ -Subproject c

[PATCH 05/13] microvm: add acpi_dsdt_add_virtio() for x86

2020-03-19 Thread Gerd Hoffmann
Makes x86 linux kernel find virtio-mmio devices automatically. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-build.c | 51 1 file changed, 51 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0e45a646af56..80844db24d6b 1006

aio-context question

2020-03-19 Thread Dietmar Maurer
I just saw commit 30dd65f307b647eef8156c4a33bd007823ef85cb, and noticed that a similar pattern in drive_backup_prepare() and blockdev_backup_prepare(). The calls to bdrv_try_set_aio_context() seems useless, because we already do that later in backup_job_create/brdv_attach. But I am not 100%& sur

Re: [PATCH v10 10/16] s390x: protvirt: Set guest IPL PSW

2020-03-19 Thread Janosch Frank
On 3/18/20 7:00 PM, Cornelia Huck wrote: > On Wed, 18 Mar 2020 10:30:41 -0400 > Janosch Frank wrote: > >> Handling of CPU reset and setting of the IPL psw from guest storage at >> offset 0 is done by a Ultravisor call. Let's only fetch it if >> necessary. >> >> Signed-off-by: Janosch Frank >> Re

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319080117.7725-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319080117.7725-1-kra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319080117.7725-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[Bug 1868055] Re: cannot run golang app with docker, version 17.09.1-ce, disabling core 0 and qemu-arm, version 2.7.

2020-03-19 Thread Laurent Vivier
Could you retest with latest version (4.2.0) of QEMU? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1868055 Title: cannot run golang app with docker, version 17.09.1-ce, disabling core 0 and qemu

[Bug 1868055] Re: cannot run golang app with docker, version 17.09.1-ce, disabling core 0 and qemu-arm, version 2.7.

2020-03-19 Thread Peter Maydell
This is a known and fixed bug in QEMU. Please try a more recent version than 2.7 (eg 4.2, which is the most recent release). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1868055 Title: cannot run

[Bug 1868055] Re: cannot run golang app with docker, version 17.09.1-ce, disabling core 0 and qemu-arm, version 2.7.

2020-03-19 Thread Peter Maydell
LP:1696773 is the old bug that I think is probably the cause here, though 2.7 is old enough it has a bunch of other linux-user race condition bugs that we've since fixed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [PULL v2 00/37] Linux user for 5.0 patches

2020-03-19 Thread Laurent Vivier
Le 18/03/2020 à 21:42, Richard Henderson a écrit : > On 3/18/20 1:23 PM, Laurent Vivier wrote: >> Le 18/03/2020 à 21:17, Richard Henderson a écrit : >>> On 3/18/20 12:58 PM, Laurent Vivier wrote: > However, from the error message above, it's clear that cpu_loop.o has not > been > rebui

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-19 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 14.03.2020 0:54, Markus Armbruster wrote: [...] >> // Match functions with propagation of local error to errp. >> // We want to refer these functions in several following rules, but I >> // don't know a proper way to inherit a function, not just its name >>

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-19 Thread Paolo Bonzini
On 19/03/20 08:01, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 18/03/20 16:06, Markus Armbruster wrote: - object initialization should cause no side effects outside the subtree of the object >>> >>> object_initialize_child() and its users like sysbus_init_child_obj() >>> vi

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Paolo Bonzini
On 19/03/20 09:01, Gerd Hoffmann wrote: > I know that not supporting ACPI in microvm is intentional. If you still > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > switch to toggle ACPI support. Could we change -no-acpi into a "-machine acpi=..." property? Then it can ha

Re: [PATCH v10 15/16] docs: system: Add protvirt docs

2020-03-19 Thread Janosch Frank
On 3/18/20 3:53 PM, Cornelia Huck wrote: > On Wed, 18 Mar 2020 10:30:46 -0400 > Janosch Frank wrote: > >> Let's add some documentation for the Protected VM functionality. >> >> Signed-off-by: Janosch Frank >> Acked-by: David Hildenbrand >> Reviewed-by: Claudio Imbrenda >> --- >> docs/system/s

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-19 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/380874 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867519 Title: qemu 4.2 segfaults on VF d

[Bug 1867519] Re: qemu 4.2 segfaults on VF detach

2020-03-19 Thread Christian Ehrhardt 
I regularly before a release pull in fixes that were posted for qemu-stable. This is one of them, I'll again do such a build and retest this issue with it. I identified and backported (only one needed modification) 33 patches. But as usual there might be some context needed on top - I have build t

[PULL v3 06/16] linux-user: Add AT_EXECFN auxval

2020-03-19 Thread Laurent Vivier
From: Lirong Yuan This change adds the support for AT_EXECFN auxval. Signed-off-by: Lirong Yuan Reviewed-by: Laurent Vivier Message-Id: <20200302193153.66415-1-yua...@google.com> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[PULL v3 03/16] linux-user/i386: Emulate x86_64 vsyscalls

2020-03-19 Thread Laurent Vivier
From: Richard Henderson Notice the magic page during translate, much like we already do for the arm32 commpage. At runtime, raise an exception to return cpu_loop for emulation. Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson Message-Id: <20200213032223.14643-4-richard.hender...@li

[PULL v3 04/16] linux-user: Add x86_64 vsyscall page to /proc/self/maps

2020-03-19 Thread Laurent Vivier
From: Richard Henderson The page isn't (necessarily) present in the host /proc/self/maps, and even if it might be it isn't present in page_flags, and even if it was it might not have the same set of page permissions. The easiest thing to do, particularly when it comes to the "[vsyscall]" note at

[PULL v3 08/16] linux-user: fix socket() strace

2020-03-19 Thread Laurent Vivier
print_socket_type() doesn't manage flags and the correct type cannot be displayed Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200312165530.53450-1-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- linux-user/strace.c | 8 +++- 1 file changed, 7 inser

[PULL v3 07/16] linux-user: do prlimit selectively

2020-03-19 Thread Laurent Vivier
From: Tobias Koch Analogous to what commit 5dfa88f7 did for setrlimit, this commit selectively ignores limits for memory-related resources in prlimit64 calls. This is to prevent too restrictive limits from causing QEMU itself to malfunction. Signed-off-by: Tobias Koch Reviewed-by: Laurent Vivie

[PULL v3 05/16] linux-user: Flush out implementation of gettimeofday

2020-03-19 Thread Laurent Vivier
From: Richard Henderson The first argument, timeval, is allowed to be NULL. The second argument, timezone, was missing. While its use is deprecated, it is still present in the syscall. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id:

[PULL v3 16/16] linux-user, openrisc: sync syscall numbers with kernel v5.5

2020-03-19 Thread Laurent Vivier
Use helper script scripts/gensyscalls.sh to generate the file. Add TARGET_NR_or1k_atomic Remove useless comments and blank lines. Define diretly the __NR_XXX64 syscalls rather than using the intermediate __NR3264 definition. Remove wrong cut'n'paste (like "#ifdef __ARCH_WANT_SYNC_FILE_RANGE2") A

[PULL v3 00/16] Linux user for 5.0 patches

2020-03-19 Thread Laurent Vivier
The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request for you to fetch changes up to c91518

[PULL v3 09/16] linux-user: Update TASK_UNMAPPED_BASE for aarch64

2020-03-19 Thread Laurent Vivier
From: Lirong Yuan This change updates TASK_UNMAPPED_BASE (the base address for guest programs) for aarch64. It is needed to allow qemu to work with Thread Sanitizer (TSan), which has specific boundary definitions for memory mappings on different platforms: https://github.com/llvm/llvm-project/

[PULL v3 11/16] linux-user/syscall: Add support for clock_gettime64/clock_settime64

2020-03-19 Thread Laurent Vivier
From: Alistair Francis Add support for the clock_gettime64/clock_settime64 syscalls. If your host is 64-bit or is 32-bit with the *_time64 syscall then the timespec will correctly be a 64-bit time_t. Otherwise the host will return a 32-bit time_t which will be rounded to 64-bits. This will be in

[PULL v3 01/16] target/i386: Renumber EXCP_SYSCALL

2020-03-19 Thread Laurent Vivier
From: Richard Henderson We are not short of numbers for EXCP_*. There is no need to confuse things by having EXCP_VMEXIT and EXCP_SYSCALL overlap, even though the former is only used for system mode and the latter is only used for user mode. Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée

[PULL v3 10/16] linux-user: Protect more syscalls

2020-03-19 Thread Laurent Vivier
From: Alistair Francis New y2038 safe 32-bit architectures (like RISC-V) don't support old syscalls with a 32-bit time_t. The kernel defines new *_time64 versions of these syscalls. Add some more #ifdefs to syscall.c in linux-user to allow us to compile without these old syscalls. Signed-off-by:

[PULL v3 13/16] scripts: add a script to generate syscall_nr.h

2020-03-19 Thread Laurent Vivier
This script is needed for targets based on asm-generic syscall numbers generation Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis Reviewed-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <20200316085620.309769-2-laur...@vivier.eu> [lv: added file in MAINTAINERS] ---

[PULL v3 15/16] linux-user, nios2: sync syscall numbers with kernel v5.5

2020-03-19 Thread Laurent Vivier
Use helper script scripts/gensyscalls.sh to generate the file. This adds TARGET_NR_llseek that was missing and remove syscalls 1024 to 1079. Add new syscalls from 288 (pkey_mprotect) to 434 (pidfd_open) Signed-off-by: Laurent Vivier Reviewed-by: Alistair Francis Message-Id: <20200316085620.309

[PULL v3 02/16] linux-user/i386: Split out gen_signal

2020-03-19 Thread Laurent Vivier
From: Richard Henderson This is a bit tidier than open-coding the 5 lines necessary to initialize the target_siginfo_t. In addition, this zeros the remaining bytes of the target_siginfo_t, rather than passing in garbage. Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philipp

[PULL v3 12/16] linux-user/riscv: Update the syscall_nr's to the 5.5 kernel

2020-03-19 Thread Laurent Vivier
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Laurent Vivier Message-Id: <8e512fa2dc885aafc4d9c4013ee033442827a4a0.1584051142.git.alistair.fran...@wdc.com> [lv: guard sys_futex with TARGET_NR_exit] Signed-off-by: Laurent Vivier --- linux-user/riscv/syscall32_nr.h | 295

[PULL v3 14/16] linux-user, aarch64: sync syscall numbers with kernel v5.5

2020-03-19 Thread Laurent Vivier
Use helper script scripts/gensyscalls.sh to generate the file. This change TARGET_NR_fstatat64 by TARGET_NR_newfstatat that is correct because definitions from linux are: arch/arm64/include/uapi/asm/unistd.h #define __ARCH_WANT_NEW_STAT include/uapi/asm-generic/unistd.h #if defined(__ARCH_

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
On Thu, Mar 19, 2020 at 09:49:55AM +0100, Paolo Bonzini wrote: > On 19/03/20 09:01, Gerd Hoffmann wrote: > > I know that not supporting ACPI in microvm is intentional. If you still > > don't want ACPI this is perfectly fine, you can use the usual -no-acpi > > switch to toggle ACPI support. > > Co

Re: [PATCH 01/13] acpi: make build_madt() more generic.

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 9:01 AM, Gerd Hoffmann wrote: Remove PCMachineState dependency from build_madt(). Pass AcpiDeviceIf as separate argument instead of depending on PCMachineState->acpi_dev. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 14 +++

Re: [PATCH 02/13] acpi: factor out acpi_dsdt_add_fw_cfg()

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 9:01 AM, Gerd Hoffmann wrote: Add helper function to add fw_cfg device. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 50 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-19 Thread Paolo Bonzini
On 18/03/20 23:15, Philippe Mathieu-Daudé wrote: > The I/O ranges registered by the piix4_acpi_system_hot_add_init() > function are not documented in the PIIX4 datasheet. > This appears to be a PC-only feature added in commit 5e3cb5347e > ("initialize hot add system / acpi gpe") which was then move

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 10:36 AM, Paolo Bonzini wrote: On 18/03/20 23:15, Philippe Mathieu-Daudé wrote: The I/O ranges registered by the piix4_acpi_system_hot_add_init() function are not documented in the PIIX4 datasheet. This appears to be a PC-only feature added in commit 5e3cb5347e ("initialize hot add sy

Re: [PATCH v3] block/nvme: introduce PMR support from NVMe 1.4 spec

2020-03-19 Thread Klaus Birkelund Jensen
On Mar 18 13:03, Andrzej Jakowski wrote: > This patch introduces support for PMR that has been defined as part of NVMe > 1.4 > spec. User can now specify a pmrdev option that should point to > HostMemoryBackend. > pmrdev memory region will subsequently be exposed as PCI BAR 2 in emulated > NVMe

[PATCH v4 0/3] net: tulip: add checks to avoid OOB access

2020-03-19 Thread P J P
From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in tulip_xmit_list_update(), wrt Tulip kernel driver -> https://git.kernel.org/pub/sc

[PATCH v4 3/3] net: tulip: flush queued packets post receive

2020-03-19 Thread P J P
From: Prasad J Pandit Call qemu_flush_queued_packets to flush queued packets once they are read in tulip_receive(). Suggested-by: Jason Wang Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 2 ++ 1 file changed, 2 insertions(+) Update v4: call qemu_flush_queued_packets() -> https://list

[PATCH v4 1/3] net: tulip: check frame size and r/w data length

2020-03-19 Thread P J P
From: Prasad J Pandit Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer access. Add check to avoid it. Limit iterations over descriptors to avoid potential infinite loop issue in tulip_xmit_list_update. Reported-by: L

[PATCH v4 2/3] net: tulip: add .can_recieve routine

2020-03-19 Thread P J P
From: Prasad J Pandit Define .can_receive routine to do sanity checks before receiving packet data. Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Update v3: define .can_receive routine -> https://lists.gnu.org/archive

Re: [PATCH v3 2/2] net: tulip: add .can_recieve routine

2020-03-19 Thread P J P
Hello Jason, +-- On Wed, 18 Mar 2020, Jason Wang wrote --+ | Right, so need to make sure qemu_flush_ququed_packets() was called when | rx_frame_len is zero. Sent patch v4, with this call. Please see when you've time. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 8685 545E B5

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Paolo Bonzini
On 19/03/20 10:33, Gerd Hoffmann wrote: > On Thu, Mar 19, 2020 at 09:49:55AM +0100, Paolo Bonzini wrote: >> On 19/03/20 09:01, Gerd Hoffmann wrote: >>> I know that not supporting ACPI in microvm is intentional. If you still >>> don't want ACPI this is perfectly fine, you can use the usual -no-acpi

Re: [PATCH v10 15/16] docs: system: Add protvirt docs

2020-03-19 Thread Cornelia Huck
On Thu, 19 Mar 2020 10:04:38 +0100 Janosch Frank wrote: > On 3/18/20 3:53 PM, Cornelia Huck wrote: > > On Wed, 18 Mar 2020 10:30:46 -0400 > > Janosch Frank wrote: > > > >> Let's add some documentation for the Protected VM functionality. > >> > >> Signed-off-by: Janosch Frank > >> Acked-by: D

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-19 Thread Paolo Bonzini
On 19/03/20 10:42, Philippe Mathieu-Daudé wrote: > On 3/19/20 10:36 AM, Paolo Bonzini wrote: >> On 18/03/20 23:15, Philippe Mathieu-Daudé wrote: >>> The I/O ranges registered by the piix4_acpi_system_hot_add_init() >>> function are not documented in the PIIX4 datasheet. >>> This appears to be a PC-

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Christian Ehrhardt 
With that confirmed I checked if I can just point to a bios to break it, and indeed adding -bios /root/seabios_1.12.0-1/usr/share/seabios/bios.bin -bios /root/seabios_1.13.0-1/usr/share/seabios/bios.bin respectively is a make or break change. As a next step I reproduced the error with seabi

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Christian Ehrhardt 
I wanted to make sure why different qemu configs make it trigger or not, and after finding seabios to be related the candidates were obvious. Default config gets us: BIOS directory/usr/local/share/qemu The long conf had: --firmwarepath=/usr/share/qemu:/usr/share/seabios:/usr/lib/ipxe/qemu Ad

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Christian Ehrhardt 
Turns out 1.12 is a fairly old build and the working version in Ubuntu was from in Disco, therefore about a year ago. => https://launchpad.net/ubuntu/+source/seabios/1.12.0-1/+build/16284605 Therefore I built it in Eoan and even Disco. As an overview: Disco: gcc 4:8.3.0-1ubuntu3 binutils 2.32-7

Re: [PULL 0/5] tcg patch queue

2020-03-19 Thread Peter Maydell
On Tue, 17 Mar 2020 at 19:00, Richard Henderson wrote: > > The following changes since commit 40c67636f67c2a89745f2e698522fe917326a952: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200317-pull-request' into staging (2020-03-17 > 14:00:56 +) > > are available in the Git rep

Re: [PATCH v4 2/3] net: tulip: add .can_recieve routine

2020-03-19 Thread Philippe Mathieu-Daudé
Typo "can_recieve" -> "can_receive" in subject. On 3/19/20 10:52 AM, P J P wrote: From: Prasad J Pandit Define .can_receive routine to do sanity checks before receiving packet data. Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 15 ++- 1 file changed, 14 insertions(+), 1

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Dr. David Alan Gilbert
That's getting more fun :-) You could look at whether seabios's config works out hte same in the two environments, or whether something makes use of new build flags - try looking at the gcc lines that are invoked in the good/bad cases and see if they're passing any options that the other doesn't

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-19 Thread Igor Mammedov
On Wed, 18 Mar 2020 23:15:30 +0100 Philippe Mathieu-Daudé wrote: > The I/O ranges registered by the piix4_acpi_system_hot_add_init() > function are not documented in the PIIX4 datasheet. > This appears to be a PC-only feature added in commit 5e3cb5347e > ("initialize hot add system / acpi gpe") w

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-19 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 17.03.2020 13:39, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 16.03.2020 11:21, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > On 14.03.2020 00:54, Markus Armbruster wrote: >> Vladimir Sementso

Re: [PULL 00/30] QAPI patches for 2020-03-17

2020-03-19 Thread Peter Maydell
On Tue, 17 Mar 2020 at 21:06, Markus Armbruster wrote: > > The following changes since commit 40c67636f67c2a89745f2e698522fe917326a952: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200317-pull-request' into staging (2020-03-17 > 14:00:56 +) > > are available in the Git rep

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 11:44 AM, Igor Mammedov wrote: On Wed, 18 Mar 2020 23:15:30 +0100 Philippe Mathieu-Daudé wrote: The I/O ranges registered by the piix4_acpi_system_hot_add_init() function are not documented in the PIIX4 datasheet. This appears to be a PC-only feature added in commit 5e3cb5347e ("ini

Re: [PATCH v10 03/16] s390x: protvirt: Support unpack facility

2020-03-19 Thread Cornelia Huck
On Wed, 18 Mar 2020 10:30:34 -0400 Janosch Frank wrote: > The unpack facility provides the means to setup a protected guest. A > protected guest cannot be introspected by the hypervisor or any > user/administrator of the machine it is running on. > > Protected guests are encrypted at rest and ne

Re: [PATCH v2 01/12] Makefile: Only build virtiofsd if system-mode is enabled

2020-03-19 Thread Philippe Mathieu-Daudé
This patch is reviewed, can it get in 5.0 as build fix? On 3/16/20 12:57 AM, Philippe Mathieu-Daudé wrote: Do not build the virtiofsd helper when configured with --disable-system. Signed-off-by: Philippe Mathieu-Daudé --- v2: Use single line with ifeq='' (lvivier, rth) --- Makefile | 2 +

Re: [PATCH v2 03/12] tests/Makefile: Only display TCG-related tests when TCG is available

2020-03-19 Thread Philippe Mathieu-Daudé
This patch might be worth for 5.0 too. On 3/16/20 12:57 AM, Philippe Mathieu-Daudé wrote: Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.inclu

Use the new lock guard macros for safe locking

2020-03-19 Thread Stefan Hajnoczi
Below is a wiki page I just created explaining the lock guard macros that make locking code simpler and safer. I wanted to make everyone aware of these new macros. Please consider using them! Thanks, Stefan --- >From https://wiki.qemu.org/ToDo/LockGuards: Lock guards are a safe alternative to m

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Christian Ehrhardt 
Starting from the Disco build env that I had I changed the packages Step #1 binutils: Unpacking binutils-x86-64-linux-gnu (2.33-2ubuntu1.2) over (2.32-7ubuntu4) ... Unpacking libbinutils:amd64 (2.33-2ubuntu1.2) over (2.32-7ubuntu4) ... Unpacking binutils (2.33-2ubuntu1.2) over (2.32-7ubuntu4) ...

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Gerd Hoffmann
Hi, > The main reason for not having ACPI was the time that it took to start; Yep, ACPI needs additional boot time. Shouldn't be a big difference though, microvm acpi only declares some devices and has small tables. Also no acpi methods, so no interpreter work. Maybe it is mostly the addition

[PULL 1/1] slirp: update submodule to v4.2.0 + mingw-fix

2020-03-19 Thread Marc-André Lureau
git shortlog 126c04acbabd7ad32c2b018fe10dfac2a3bc1210..7012a2c62e5b54eab88c119383022ec7ce86e9b2 5eraph (1): Use specific outbound IP address Akihiro Suda (8): remove confusing comment that exists from ancient slirp add slirp_new(SlirpConfig *, SlirpCb *, void *) allow cust

[PULL 0/1] Slirp patches

2020-03-19 Thread Marc-André Lureau
The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' into staging (2020-03-19 10:18:07 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/slirp-pull-request

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Christian Ehrhardt 
** Changed in: qemu Status: New => Invalid ** Changed in: qemu (Ubuntu) Status: Incomplete => Invalid ** Also affects: seabios (Ubuntu) Importance: Undecided Status: New ** Changed in: seabios (Ubuntu) Status: New => Triaged -- You received this bug notification

Re: [PATCH v4 1/2] hw/smbios: add options for type 4 max-speed and current-speed

2020-03-19 Thread Igor Mammedov
On Wed, 18 Mar 2020 14:48:19 +0800 Heyi Guo wrote: > Common VM users sometimes care about CPU speed, so we add two new > options to allow VM vendors to present CPU speed to their users. > Normally these information can be fetched from host smbios. > > Strictly speaking, the "max speed" and "curr

Re: [PATCH-for-5.0] block: Assert BlockDriver::format_name is not NULL

2020-03-19 Thread Alberto Garcia
On Wed 18 Mar 2020 11:22:35 PM CET, Philippe Mathieu-Daudé wrote: > bdrv_do_find_format() calls strcmp() using BlockDriver::format_name > as argument, which must not be NULL. Assert this field is not null > when we register a block driver in bdrv_register(). > > Reported-by: Mansour Ahmadi > Signe

Re: [PATCH v10 03/16] s390x: protvirt: Support unpack facility

2020-03-19 Thread Janosch Frank
On 3/19/20 12:08 PM, Cornelia Huck wrote: > On Wed, 18 Mar 2020 10:30:34 -0400 > Janosch Frank wrote: > >> The unpack facility provides the means to setup a protected guest. A >> protected guest cannot be introspected by the hypervisor or any >> user/administrator of the machine it is running on.

Re: [PATCH] hw/isa/superio: Correct the license text

2020-03-19 Thread Paolo Bonzini
On 12/03/20 22:37, Philippe Mathieu-Daudé wrote: > The license is the 'GNU General Public License v2.0 or later', > not 'and': > > This program is free software; you can redistribute it and/ori > modify it under the terms of the GNU General Public License as > published by the Free Software

Re: [PATCH v10 03/16] s390x: protvirt: Support unpack facility

2020-03-19 Thread Christian Borntraeger
On 19.03.20 12:55, Janosch Frank wrote: > On 3/19/20 12:08 PM, Cornelia Huck wrote: >> On Wed, 18 Mar 2020 10:30:34 -0400 >> Janosch Frank wrote: >> >>> The unpack facility provides the means to setup a protected guest. A >>> protected guest cannot be introspected by the hypervisor or any >>> u

Re: [PATCH v10 03/16] s390x: protvirt: Support unpack facility

2020-03-19 Thread Janosch Frank
On 3/19/20 12:57 PM, Christian Borntraeger wrote: > > > On 19.03.20 12:55, Janosch Frank wrote: >> On 3/19/20 12:08 PM, Cornelia Huck wrote: >>> On Wed, 18 Mar 2020 10:30:34 -0400 >>> Janosch Frank wrote: >>> The unpack facility provides the means to setup a protected guest. A protecte

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Dr. David Alan Gilbert
I *think* it's the cf-protection that's adding the endbr32 instructions that I spotted as being the failing instruction each time; but I don't understand why they would be CPU type specific. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH v10 09/16] s390x: protvirt: SCLP interpretation

2020-03-19 Thread Cornelia Huck
On Wed, 18 Mar 2020 10:30:40 -0400 Janosch Frank wrote: > SCLP for a protected guest is done over the SIDAD, so we need to use > the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest > memory when reading/writing SCBs. > > To not confuse the sclp emulation, we set 0x4000 as the SC

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-19 Thread Vladimir Sementsov-Ogievskiy
19.03.2020 13:45, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 17.03.2020 13:39, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 16.03.2020 11:21, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 14.03.2020 00:54, Markus Armbruster wrote:

Re: [PATCH v10 11/16] s390x: protvirt: Move diag 308 data over SIDA

2020-03-19 Thread Cornelia Huck
On Wed, 18 Mar 2020 10:30:42 -0400 Janosch Frank wrote: > For protected guests the IPIB is written/read to/from the SIDA, so we > need those accesses to go through s390_cpu_pv_mem_read/write(). > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > Reviewed-by: Christian Borntraeg

Re: [PATCH 02/13] acpi: factor out acpi_dsdt_add_fw_cfg()

2020-03-19 Thread Igor Mammedov
On Thu, 19 Mar 2020 09:01:06 +0100 Gerd Hoffmann wrote: > Add helper function to add fw_cfg device. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-build.c | 50 > 1 file changed, 27 insertions(+), 23 deletions(-) > > diff --git a/hw/i386/acp

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/seabios/+git/seabios/+merge/380881 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Title: KVM Guest pauses aft

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-19 Thread Christian Ehrhardt 
Sent to seabios for their consideration: => https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/thread/IXAWMA2HWW75LSR3NBBYQKWT3TI5WVVP/ I deleted the experimental PPAs that we had and created a new one with a new seabios: => https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/

Re: [PATCH v10 13/16] s390x: protvirt: Move IO control structures over SIDA

2020-03-19 Thread Cornelia Huck
On Wed, 18 Mar 2020 10:30:44 -0400 Janosch Frank wrote: > For protected guests, we need to put the IO emulation results into the > SIDA, so SIE will write them into the guest at the next entry. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > target/s390x/ioinst.c | 6

Re: [PULL 00/20] Ide patches

2020-03-19 Thread Peter Maydell
On Tue, 17 Mar 2020 at 23:23, John Snow wrote: > > The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: > > qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pul

Re: [PATCH v10 09/16] s390x: protvirt: SCLP interpretation

2020-03-19 Thread Janosch Frank
On 3/19/20 1:09 PM, Cornelia Huck wrote: > On Wed, 18 Mar 2020 10:30:40 -0400 > Janosch Frank wrote: > >> SCLP for a protected guest is done over the SIDAD, so we need to use >> the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest >> memory when reading/writing SCBs. >> >> To not

Re: [PATCH v10 13/16] s390x: protvirt: Move IO control structures over SIDA

2020-03-19 Thread Janosch Frank
On 3/19/20 1:23 PM, Cornelia Huck wrote: > On Wed, 18 Mar 2020 10:30:44 -0400 > Janosch Frank wrote: > >> For protected guests, we need to put the IO emulation results into the >> SIDA, so SIE will write them into the guest at the next entry. >> >> Signed-off-by: Janosch Frank >> Reviewed-by: Da

Re: [PATCH v10 09/16] s390x: protvirt: SCLP interpretation

2020-03-19 Thread Cornelia Huck
On Thu, 19 Mar 2020 13:46:46 +0100 Janosch Frank wrote: > On 3/19/20 1:09 PM, Cornelia Huck wrote: > > On Wed, 18 Mar 2020 10:30:40 -0400 > > Janosch Frank wrote: > > > >> SCLP for a protected guest is done over the SIDAD, so we need to use > >> the s390_cpu_pv_mem_* functions to access the S

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 02:15:34 -0400 Yan Zhao wrote: > On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: > > On Thu, 19 Mar 2020 00:15:33 -0400 > > Yan Zhao wrote: > > > > > On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: > > > > On Wed, 18 Mar 2020 23:06:39 -0

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 01:05:54 -0400 Yan Zhao wrote: > On Thu, Mar 19, 2020 at 11:49:26AM +0800, Alex Williamson wrote: > > On Wed, 18 Mar 2020 21:17:03 -0400 > > Yan Zhao wrote: > > > > > On Thu, Mar 19, 2020 at 03:41:08AM +0800, Kirti Wankhede wrote: > > > > - Defined MIGRATION region type

  1   2   3   >