[PATCH v6 2/5] virtio-iommu: Add iommu notifier for map/unmap

2020-03-13 Thread Bharat Bhushan
This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request to notify registered iommu-notifier. Which will call vfio notifier to map/unmap region in iommu. Signed-off-by: Bharat Bhushan Signed-off-by: Eric Auger --- hw/virtio/trace-events | 2 + hw/virtio/virtio-iommu.c | 66 +++

[PATCH v7 1/5] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-03-13 Thread Bharat Bhushan
On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- hw/vfio/common.c | 2

[PATCH v6 5/5] virtio-iommu: add iommu notifier memory-region

2020-03-13 Thread Bharat Bhushan
Finally add notify_flag_changed() to for memory-region access flag iommu flag change notifier Finally add the memory notifier Signed-off-by: Bharat Bhushan --- hw/virtio/trace-events | 2 ++ hw/virtio/virtio-iommu.c | 32 2 files changed, 34 insertions(+) di

[PATCH v6 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-13 Thread Bharat Bhushan
iommu-notifier are called when a device is attached or detached to as address-space. This is needed for VFIO. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 47 1 file changed, 47 insertions(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/vir

[PATCH v6 4/5] virtio-iommu: add iommu replay

2020-03-13 Thread Bharat Bhushan
Default replay does not work with virtio-iommu, so this patch provide virtio-iommu replay functionality. Signed-off-by: Bharat Bhushan --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 44 2 files changed, 45 insertions(+) diff --git a/hw/v

[PATCH v6 1/5] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-03-13 Thread Bharat Bhushan
On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- hw/vfio/common.c | 2

[PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-13 Thread Bharat Bhushan
iommu-notifier are called when a device is attached or detached to as address-space. This is needed for VFIO. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 47 1 file changed, 47 insertions(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/vir

[PATCH V6 0/5] virtio-iommu: VFIO integration

2020-03-13 Thread Bharat Bhushan
This patch series integrates VFIO with virtio-iommu. This is only applicable for PCI pass-through with virtio-iommu. This series is available at: https://github.com/bharat-bhushan-devel/qemu.git virtio-iommu-vfio-integration-v6 This is tested with assigning more than one pci devices to Virtual M

[PATCH v7 0/5] virtio-iommu: VFIO integration

2020-03-13 Thread Bharat Bhushan
This patch series integrates VFIO with virtio-iommu. This is only applicable for PCI pass-through with virtio-iommu. This series is available at: https://github.com/bharat-bhushan-devel/qemu.git virtio-iommu-vfio-integration-v7 This is tested with assigning more than one pci devices to Virtual M

[PATCH v7 2/5] virtio-iommu: Add iommu notifier for map/unmap

2020-03-13 Thread Bharat Bhushan
This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request to notify registered iommu-notifier. Which will call vfio notifier to map/unmap region in iommu. Signed-off-by: Bharat Bhushan Signed-off-by: Eric Auger --- hw/virtio/trace-events | 2 + hw/virtio/virtio-iommu.c | 66 +++

[PATCH v7 5/5] virtio-iommu: add iommu notifier memory-region

2020-03-13 Thread Bharat Bhushan
Finally add notify_flag_changed() to for memory-region access flag iommu flag change notifier Finally add the memory notifier Signed-off-by: Bharat Bhushan --- hw/virtio/trace-events | 2 ++ hw/virtio/virtio-iommu.c | 32 2 files changed, 34 insertions(+) di

[PATCH v7 4/5] virtio-iommu: add iommu replay

2020-03-13 Thread Bharat Bhushan
Default replay does not work with virtio-iommu, so this patch provide virtio-iommu replay functionality. Signed-off-by: Bharat Bhushan --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 44 2 files changed, 45 insertions(+) diff --git a/hw/v

Re: [PATCH 1/2] riscv: sifive_e: Support changing CPU type

2020-03-13 Thread Bin Meng
On Fri, Mar 13, 2020 at 8:57 AM Corey Wharton wrote: > > Allows the CPU to be changed from the default via the -cpu command > line option. > > Signed-off-by: Corey Wharton > --- > hw/riscv/sifive_e.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2020-03-13 Thread carlosedp
Tried applying the -cpu parameter into Qemu 4.1.1 but I got: qemu-system-riscv64: unable to find CPU model 'qemu' My command is: qemu-system-riscv64 \ -machine virt \ -cpu qemu,vx=off \ -nographic \ -smp 4 \ -m 4G \ -bios fw_payload.bin \ -device virtio-blk-device,dri

Re: [PATCH 2/2] target/riscv: Add a sifive-e34 cpu type

2020-03-13 Thread Bin Meng
On Fri, Mar 13, 2020 at 9:00 AM Corey Wharton wrote: > > The sifive-e34 cpu type is the same as the sifive-e31 with the > single precision floating-point extension enabled. > > Signed-off-by: Corey Wharton > --- > target/riscv/cpu.c | 10 ++ > target/riscv/cpu.h | 1 + > 2 files changed

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-13 Thread Auger Eric
Hi Bharat On 3/13/20 8:48 AM, Bharat Bhushan wrote: > iommu-notifier are called when a device is attached IOMMU notifiers > or detached to as address-space. > This is needed for VFIO. and vhost for detach > > Signed-off-by: Bharat Bhushan > --- > hw/virtio/virtio-iommu.c | 47 ++

Re: [PATCH v9] fixup! Fix subcode/pbt

2020-03-13 Thread Janosch Frank
On 3/13/20 3:30 PM, Christian Borntraeger wrote: > > > On 13.03.20 10:52, Janosch Frank wrote: >> Signed-off-by: Janosch Frank > > looks sane. You will merge this? Yes, just did. > >> --- >> hw/s390x/ipl.h | 11 +++ >> target/s390x/diag.c | 2 +- >> 2 files changed, 8 insertio

[PATCH v2 2/3] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Liran Alon
Microsoft introduced this ACPI table to avoid Windows guests performing various workarounds for device erratas. As the virtual device emulated by VMM may not have the errata. Currently, WAET allows hypervisor to inform guest about two specific behaviors: One for RTC and the other for ACPI PM timer

[PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Liran Alon
Hi, This patch-series aims to expose WAET ACPI table to guest. Which improves performance of Windows guests (since Vista) and ignored by other guests. This ACPI table is exposed by default by other common hypervisors such as VMware, Xen (HVM), GCP and AWS. Regards, -Liran v1->v2: - Update bios-t

[PATCH v2 3/3] acpi: unit-test: Update WAET ACPI Table expected binaries

2020-03-13 Thread Liran Alon
This is done according to step (6) in the process described at tests/qtest/bios-tables-test.c. Expected WAET.dsl: [000h 4]Signature : "WAET"[Windows ACPI Emulated Devices Table] [004h 0004 4] Table Length : 0028 [008h 0008 1]

Re: [PULL 0/5] migration queue

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 10:32, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit d4f7d56759f7c75270c13d5f3f5f736a9558929c: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200312' into staging (2020-03-12 >

[PATCH v2 1/3] acpi: unit-test: Ignore diff in WAET ACPI table

2020-03-13 Thread Liran Alon
This is done as a preparation for the following patch to expose WAET ACPI table to guest. This patch performs steps 1-3 as describes in tests/qtest/bios-tables-test.c. Signed-off-by: Liran Alon --- tests/data/acpi/pc/WAET | 0 tests/data/acpi/q35/WAET| 0

Re: [PATCH 2/5] target/arm: MTE user mode disassembly

2020-03-13 Thread Richard Henderson
On 3/13/20 7:00 AM, Rémi Denis-Courmont wrote: > +/* Extract an Allocation Tag from an address */ > +static void gen_extract_tag(TCGv_i64 dest, TCGv_i64 source) > +{ > +TCGv_i64 sign = tcg_temp_new_i64(); > + > +/* See ARMv8.5-A AllocationTagFromAddress pseudocode */ > +tcg_gen_extract_

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
I tried this script on the whole tree. Observations: * $ git-diff --shortstat \*.[ch] 333 files changed, 3480 insertions(+), 4586 deletions(-) * Twelve functions have "several definitions of Error * local variable". Eight declare such a variable within a loop. Reported because Coccinell

Re: [PATCH 0/5] QEMU Gating CI

2020-03-13 Thread Cleber Rosa
On Fri, Mar 13, 2020 at 01:55:49PM +, Peter Maydell wrote: > On Thu, 12 Mar 2020 at 22:16, Cleber Rosa wrote: > > > > On Thu, Mar 12, 2020 at 10:00:42PM +, Peter Maydell wrote: > > > OK, so my question here is: > > > * what are the instructions that I have to follow to be > > > able to sa

Re: [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile

2020-03-13 Thread Cleber Rosa
On Fri, Mar 13, 2020 at 09:46:55AM +0100, Erik Skultety wrote: > On Thu, Mar 12, 2020 at 03:36:12PM -0400, Cleber Rosa wrote: > > Which is currenly missing, and will be referenced later in the > > contributed CI playbooks. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/docker/dockerfiles/c

Re: [PATCH 4/5] GitLab Gating CI: introduce pipeline-status contrib script

2020-03-13 Thread Cleber Rosa
On Fri, Mar 13, 2020 at 01:56:51PM +, Peter Maydell wrote: > > All new files, and particularly new scripts and source > files, should have the usual copyright-and-license > comment at the top, please. > > thanks > -- PMM > My bad. I'll wait for further comments and included that in a v2.

Re: QMP netdev_add multiple dnssearch values

2020-03-13 Thread Markus Armbruster
Eric Blake writes: > On 11/27/19 9:49 AM, Eric Blake wrote: >> On 11/27/19 7:30 AM, Markus Armbruster wrote: >> >>> "Good enough" was true back then.  It wasn't true when we reused it for >>> netdev_add: hostfwd and guestfwd are list-valued. >>> >>> We did define a QAPI schema a few months later

Re: [RFC] [PATCH 0/5] ARMv8.5-MemTag disassembly

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 15:17, Rémi Denis-Courmont wrote: > It does not. I don't know about that seriers. The patches are part of the > patchset that lead to my PAuth fixes a year ago. At that time, only beta spec > was available, including obvious bugs (sysregs with duplicate opcodes), > suspiciou

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2020 17:58, Markus Armbruster wrote: I tried this script on the whole tree. Observations: * $ git-diff --shortstat \*.[ch] 333 files changed, 3480 insertions(+), 4586 deletions(-) * Twelve functions have "several definitions of Error * local variable". Eight declare such a variab

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-13 Thread Liran Alon
On 13/03/2020 2:04, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 06:54:25PM +0200, Liran Alon wrote: This command is used by guest to gettimeofday() from host. See usage example in open-vm-tools TimeSyncReadHost() function. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- h

Re: [PATCH v3 11/16] hw/i386/vmport: Add support for CMD_GETTIMEFULL

2020-03-13 Thread Liran Alon
On 13/03/2020 2:06, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 06:54:26PM +0200, Liran Alon wrote: Similar to CMD_GETTIME but lacks the 136-year overflow issue, by returning full 64-bit of host uSeconds. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 10:36:56AM +0100, Igor Mammedov wrote: > On Thu, 12 Mar 2020 13:09:51 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > > On Wed, 11 Mar 2020 19:08:26 +0200 > > > Liran Alon wrote: > > > > > > > From: Elad Gaba

Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 01:44:46PM +0100, Halil Pasic wrote: > [..] > > > > > > CCing Tom. @Tom does vhost-vsock work for you with SEV and current qemu? > > > > > > Also, one can specify iommu_platform=on on a device that ain't a part of > > > a secure-capable VM, just for the fun of it. And that

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-13 Thread Christian Ehrhardt 
Andreas was so kind to try kenels 4.4, 4.15 and 5.6 all fail (with qemu 4.2) He then tried Eoan (qemu 4.0) and Focal (qemu 4.2). 4.0 worked and 4.2 failed. We will set up a bisect run on Monday and hopefully find the offending change. @David - I agree that the messages might be a red-herring, but

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 13.03.2020 10:50, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >> [...] >>> +// Warn several Error * definitions. >>> +@check1 disable optional_qualifier exists@ >>> +identifier fn = rule1.fn, local_err, local_err2; >>> +@@ >>> + >>>

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 12.03.2020 19:36, Markus Armbruster wrote: >> I may have a second look tomorrow with fresher eyes, but let's get this >> out now as is. >> >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 13 Mar 2020 at 13:57, Dr. David Alan Gilbert > wrote: > > Ah yes, I think you're right, so something like: > > > > if (runstate_check(RUN_STATE_INMIGRATE) && rom->data && rom->isrom) { > > I think you would see the difference here for

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote: > > > @@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque, > > > uint32_t addr) > > > return ram_size; > > > } > > > +static uint32_t vmport_cmd_time(void *opaque, uint32_t addr) > > > +{ > > > +X86CPU *cpu =

Re: [RFC] [PATCH 0/5] ARMv8.5-MemTag disassembly

2020-03-13 Thread Richard Henderson
On 3/13/20 6:59 AM, Rémi Denis-Courmont wrote: > For proper storage and checking of memory tags, MTE == 2 would be > necessary. I have some code (on top of this RFC but not included) to add the > tag allocation logic. But I have no clue how to actually store the tags in > QEMU > system mode at thi

Re: [PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200313145009.144820-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET) Message-id: 20200313145009.144820-

[PATCH v2] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit 355477f8c73e9 skips rom reset when we're an incoming migration so as not to overwrite shared ram in the ignore-shared migration optimisation. However, it's got an unexpected side effect that because it skips freeing the ROM data, when rom_reset gets called la

[PATCH] hw/arm/pxa2xx: Do not wire up OHCI for PXA255

2020-03-13 Thread Guenter Roeck
PXA255 does not support a USB OHCI controller, so don't wire it up. Signed-off-by: Guenter Roeck --- hw/arm/pxa2xx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index 56a36202d7..336c9bad4a 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -2290,9

Re: [PATCH v2] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 15:59, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > Commit 355477f8c73e9 skips rom reset when we're an incoming migration > so as not to overwrite shared ram in the ignore-shared migration > optimisation. > However, it's got an unexpected side

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now as is. Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invo

[PATCH] hw/arm/fsl-imx7: Instantiate apbh_dma and ocotp as unimplemented devices

2020-03-13 Thread Guenter Roeck
Instantiating apbh_dma and ocotp as unimplemented devices prevents crashes when booting Linux. apbh_dma: [ 14.046518] Unhandled fault: external abort on non-linefetch (0x808) at 0xd0852008 [ 14.047287] pgd = (ptrval) [ 14.047607] [d0852008] *pgd=8b028811, *pte=33000653, *ppte=33000453 [

Re: [PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Liran Alon
On 13/03/2020 17:58, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200313145009.144820-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!MCIj6t775fgVLQyuc_7yakcjRzbRpb0QfWeBkZaMwb72--7RvXHTCgm_18diSyk$ Hi, This series seems to have some coding styl

Re: [PATCH v3 10/16] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-13 Thread Liran Alon
On 13/03/2020 17:47, Michael S. Tsirkin wrote: On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote: @@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque, uint32_t addr) return ram_size; } +static uint32_t vmport_cmd_time(void *opaque, uint32_t addr) +{ +X

Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-13 Thread Peter Xu
On Fri, Mar 13, 2020 at 11:29:59AM -0400, Michael S. Tsirkin wrote: > On Fri, Mar 13, 2020 at 01:44:46PM +0100, Halil Pasic wrote: > > [..] > > > > > > > > CCing Tom. @Tom does vhost-vsock work for you with SEV and current qemu? > > > > > > > > Also, one can specify iommu_platform=on on a device

Re: [EXTERNAL][PATCH 0/7] via-ide: fixes and improvements

2020-03-13 Thread Aleksandar Markovic
> From: Mark Cave-Ayland > This patchset effectively updates the VIA IDE PCI device to follow the > behaviour in the datasheet in two ways: fixing some PCI configuration > space register defaults and behaviours, and always using legacy IRQ 14/15 > routing, and once applied allows all our known te

Re: [PATCH 2/3] MAINTAINERS: Adjust maintainer's email

2020-03-13 Thread Philippe Mathieu-Daudé
On 3/13/20 2:00 AM, Aleksandar Markovic wrote: From: Aleksandar Markovic For some longish time I've been using multiple email addresses for mailing list communication, and would like to consolidate it into a single email address that is the most convenient to me. My other emails, from rt-rk.com

[PATCH] docs/conf.py: Raise ConfigError for bad Sphinx Python version

2020-03-13 Thread Peter Maydell
Raise ConfigError rather than VersionRequirementError when we detect that the Python being used by Sphinx is too old. Currently the way we flag the Python version problem up to the user causes Sphinx to print an unnecessary Python stack trace as well as the information about the problem; in most v

Re: [PATCH 3/3] MAINTAINERS: Add a file to the main MIPS section

2020-03-13 Thread Philippe Mathieu-Daudé
On 3/13/20 2:00 AM, Aleksandar Markovic wrote: From: Aleksandar Markovic A recently added acceptance test is important not only for Malta machine, but for overall MIPS target, since it tests smp feature. CC: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 1 +

[PATCH 3/3] xen-block: Use one Error * variable instead of two

2020-03-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/block/xen-block.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 3885464513..7b3b6dee97 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -998,14 +998,13 @@ static void

[PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two

2020-03-13 Thread Markus Armbruster
Commit fe44dc9180 "migration: disallow migrate_add_blocker during migration" accidentally added a second Error * variable. Use the first one instead. Signed-off-by: Markus Armbruster --- hw/misc/ivshmem.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem

[PATCH 0/3] Minor error handling cleanups

2020-03-13 Thread Markus Armbruster
Markus Armbruster (3): Use &error_abort instead of separate assert() hw/misc/ivshmem: Use one Error * variable instead of two xen-block: Use one Error * variable instead of two block/monitor/block-hmp-cmds.c | 4 +--- hw/block/xen-block.c | 5 + hw/misc/ivshmem.c

[PATCH 1/3] Use &error_abort instead of separate assert()

2020-03-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block/monitor/block-hmp-cmds.c | 4 +--- target/arm/monitor.c | 8 ++-- tests/qtest/fuzz/qos_fuzz.c| 6 ++ 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c ind

Re: [EXTERNAL][PATCH 0/7] via-ide: fixes and improvements

2020-03-13 Thread BALATON Zoltan
Hello, On Fri, 13 Mar 2020, Aleksandar Markovic wrote: Hi, Mark, could you just enumerate those test images, download locations, etc. and whatever else is needed to reproduce the boot processes in question - it would be useful not only for this patch set, but for possible future work, wouldn't i

[PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default machine'

2020-03-13 Thread Peter Maydell
Currently if you try to ask for the list of CPUs for a target architecture which does not specify a default machine type you just get an error: $ qemu-system-arm -cpu help qemu-system-arm: No machine specified, and there is no default Use -machine help to list supported machines Since the l

Re: [PATCH 0/3] Minor error handling cleanups

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 17:06, Markus Armbruster wrote: > > Markus Armbruster (3): > Use &error_abort instead of separate assert() > hw/misc/ivshmem: Use one Error * variable instead of two > xen-block: Use one Error * variable instead of two > > block/monitor/block-hmp-cmds.c | 4 +--- > hw

Re: [PATCH 1/3] Use &error_abort instead of separate assert()

2020-03-13 Thread Alexander Bulekov
On 200313 1805, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > index 1a99277d60..aa9eee6ebf 100644 > --- a/tests/qtest/fuzz/qos_fuzz.c > +++ b/tests/qtest/fuzz/qos_fuzz.c > @@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void) > QList *lst; > Error *err

Re: [PATCH 0/7] via-ide: fixes and improvements

2020-03-13 Thread John Snow
On 3/13/20 4:24 AM, Mark Cave-Ayland wrote: > Following on from the earlier thread "Implement "non 100% native mode" > in via-ide", here is an updated patchset based upon the test cases > sent to me off-list. > > The VIA IDE controller is similar to early versions of the PIIX > controller in th

Re: [PATCH 1/3] Use &error_abort instead of separate assert()

2020-03-13 Thread Eric Blake
On 3/13/20 12:37 PM, Alexander Bulekov wrote: On 200313 1805, Markus Armbruster wrote: Signed-off-by: Markus Armbruster index 1a99277d60..aa9eee6ebf 100644 --- a/tests/qtest/fuzz/qos_fuzz.c +++ b/tests/qtest/fuzz/qos_fuzz.c @@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(vo

Re: [PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two

2020-03-13 Thread Eric Blake
On 3/13/20 12:05 PM, Markus Armbruster wrote: Commit fe44dc9180 "migration: disallow migrate_add_blocker during migration" accidentally added a second Error * variable. Use the first one instead. Signed-off-by: Markus Armbruster --- hw/misc/ivshmem.c | 7 +++ 1 file changed, 3 insertion

Re: [PATCH 3/3] xen-block: Use one Error * variable instead of two

2020-03-13 Thread Eric Blake
On 3/13/20 12:05 PM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- hw/block/xen-block.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qem

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-13 Thread Dr. David Alan Gilbert
I think the one I was thinking of is 0723cc8a5558c94388db75ae1f4991314914edd3 which is in a 4.2.0 rc and there was 2605188240f939fa9ae9353f53a0985620b34769 - but that's a different crash to what you have. So hmm. -- You received this bug notification because you are a member of qemu- devel-m

Re: [PATCH v13 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-03-13 Thread Alex Williamson
On Thu, 12 Mar 2020 23:23:24 +0530 Kirti Wankhede wrote: Subject: s/to // > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start pinned and unpinned pages tracking while migration is active > - Stop pinned and unpinned dirty pages tracking. This is also used to > stop dirty pages

Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F

2020-03-13 Thread Eric Blake
On 3/9/20 10:31 AM, Kashyap Chamarthy wrote: On Fri, Mar 06, 2020 at 04:51:21PM -0600, Eric Blake wrote: Creating an image that requires format probing of the backing image is inherently unsafe (we've had several CVEs over the years based on +qemu-img backing file without format (since 5.0.0

Re: [PATCH v4 7/7] qemu-img: Deprecate use of -b without -F

2020-03-13 Thread Eric Blake
On 3/12/20 2:28 PM, Eric Blake wrote: Creating an image that requires format probing of the backing image is inherently unsafe (we've had several CVEs over the years based on probes leaking information to the guest on a subsequent boot, although these days tools like libvirt are aware of the issu

Re: [PATCH 1/2] riscv: sifive_e: Support changing CPU type

2020-03-13 Thread Alistair Francis
On Thu, Mar 12, 2020 at 5:58 PM Corey Wharton wrote: > > Allows the CPU to be changed from the default via the -cpu command > line option. > > Signed-off-by: Corey Wharton Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/sifive_e.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

[PATCH 00/14] user-mode: Prune build dependencies (part 1)

2020-03-13 Thread Philippe Mathieu-Daudé
This is the first part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Part 1: - reduce user-mode object list - remove some migration code from user-mode - remove cpu_get_crash_info() Philippe Mathieu-

[PATCH 01/14] Makefile: Only build virtiofsd if system-mode is enabled

2020-03-13 Thread Philippe Mathieu-Daudé
Do not build the virtiofsd helper when configured with --disable-system. Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 7df22fcc5d..ed77b6e50b 100644 --- a/Makefile +++ b/Makefile @@ -346,8 +346

[PATCH 09/14] exec: Drop redundant #ifdeffery

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- exec.c | 4 1 file changed, 4 deletions(-) diff --git a/exec.c b/exec.c index 7bc9828c5b..f258502966 100644 --- a/exec.c +++ b/exec.c @@ -185,10 +185,6 @@ struct DirtyBitmapSnapshot { unsigned long dirty[]; }; -#endif - -#if !defined(CONFIG_

[PATCH 02/14] configure: Avoid building TCG when not needed

2020-03-13 Thread Philippe Mathieu-Daudé
Avoid building TCG when building only tools: ./configure --enable-tools --disable-system --disable-user This saves us from running the soft-float tests enabled since commit 76170102508. Signed-off-by: Philippe Mathieu-Daudé --- configure | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 07/14] target/riscv/cpu: Restrict CPU migration to system-mode

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c0b7023100..b59e09209e 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -475,10 +475,12 @@ static void ri

[PATCH 03/14] tests/Makefile: Only display TCG-related tests when TCG is available

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 67e8fcddda..99db5eb3e0 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -12,8 +12,10 @@ check-help:

[PATCH 08/14] exec: Assert CPU migration is not used on user-only build

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- exec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 0cc500d53a..7bc9828c5b 100644 --- a/exec.c +++ b/exec.c @@ -946,7 +946,9 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp) qemu_plugin_vcpu_in

[PATCH 05/14] stubs/Makefile: Reduce the user-mode object list

2020-03-13 Thread Philippe Mathieu-Daudé
These stubs are not required when configured with --disable-system. Signed-off-by: Philippe Mathieu-Daudé --- stubs/Makefile.objs | 52 ++--- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs index 45

[PATCH 04/14] tests/Makefile: Restrict some softmmu-only tests

2020-03-13 Thread Philippe Mathieu-Daudé
These tests fails when configured with --disable-system. Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 99db5eb3e0..bf11f765c3 100644 --- a

[PATCH 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-13 Thread Philippe Mathieu-Daudé
Move out x86-specific structures from generic machine code. Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine-target.json | 45 ++ qapi/machine.json | 42 --- target/i386/cpu.c | 2 +- target/i386/machi

[PATCH 10/14] arch_init: Remove unused 'qapi-commands-misc.h' include

2020-03-13 Thread Philippe Mathieu-Daudé
Commit ffaee83bcb2 moved qmp_query_target but forgot to remove this include. Signed-off-by: Philippe Mathieu-Daudé --- arch_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 705d0b94ad..074fa621b6 100644 --- a/arch_init.c +++ b/arch_init.c @@ -27,7 +27,6 @

[PATCH 06/14] util/Makefile: Reduce the user-mode object list

2020-03-13 Thread Philippe Mathieu-Daudé
These stubs are not required when configured with --disable-system. Signed-off-by: Philippe Mathieu-Daudé --- util/Makefile.objs | 59 +- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/util/Makefile.objs b/util/Makefile.objs index 6718

[PATCH 5/9] qapi/misc: Move query-uuid command with block code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/block-core.json | 30 ++ qapi/misc.json | 30 -- block/iscsi.c| 2 +- stubs/uuid.c | 2 +- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/qapi/block-cor

Re: [PATCH v13 Kernel 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-03-13 Thread Alex Williamson
On Thu, 12 Mar 2020 23:23:25 +0530 Kirti Wankhede wrote: > Pages, pinned by external interface for requested IO virtual address > range, might get unpinned and unmapped while migration is active and "DMA mapped pages, including those pinned by mdev vendor drivers, might get..." > device is st

[PATCH 12/14] target/i386: Restrict CpuClass::get_crash_info() to system-mode

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 92fafa2659..a84553e50c 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6778,6 +6778,7 @@ static void x86_cpu_

[PATCH 9/9] qapi: Restrict code generated for user-mode

2020-03-13 Thread Philippe Mathieu-Daudé
A lot of QAPI generated code is never used by user-mode. Rewrite the QAPI_COMMON_MODULES variable one entry per line, and split it in 3 groups: - always used - use by system-mode or tools - only used by system-mode Signed-off-by: Philippe Mathieu-Daudé --- qapi/Makefile.objs | 37 ++

[PATCH 11/14] target: Restrict write_elfXX_note() handlers to system-mode

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h| 10 +- target/i386/cpu.h | 18 +- target/ppc/cpu.h| 2 -- target/s390x/internal.h | 3 ++- target/ppc/translate_init.inc.c | 2 -- 5 files changed, 16 inser

[PATCH 2/9] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()

2020-03-13 Thread Philippe Mathieu-Daudé
Replace strtoul() by qemu_strtoul() so checkpatch.pl won't complain if we move this code later. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-properties.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/

[PATCH 14/14] hw/core: Restrict CpuClass::get_crash_info() to system-mode

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 7 ++- hw/core/cpu.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 73e9a869a4..48ab5ec3ed 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/c

[PATCH 13/14] target/s390x: Restrict CpuClass::get_crash_info() to system-mode

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index 3dd396e870..3b1377c20a 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -237,6 +237,7 @@ out:

[PATCH 0/9] user-mode: Prune build dependencies (part 2)

2020-03-13 Thread Philippe Mathieu-Daudé
This is the second part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Part 2: - Extract code not related to user-mode from qapi/misc.json Based-on: <20200313183652.10258-1-phi...@redhat.com> Philipp

[PATCH 3/9] qapi/misc: Restrict LostTickPolicy enum to machine code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json| 32 qapi/misc.json | 32 include/hw/rtc/mc146818rtc.h | 2 +- hw/core/qdev-properties.c| 1 + hw/i386/kvm/i8254.c | 2 +- 5 file

[PATCH 4/9] hw/core/qdev-properties: Export enum-related functions

2020-03-13 Thread Philippe Mathieu-Daudé
We are going to split this file and reuse these static functions. Add the local "qdev-prop-internal.h" header declaring them. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-prop-internal.h | 19 hw/core/qdev-properties.c| 58 +++- 2 files

[PATCH 1/9] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler

2020-03-13 Thread Philippe Mathieu-Daudé
Replace strtol() by qemu_strtol() so checkpatch.pl won't complain if we move this code later. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-properties.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c

[PATCH 2/9] qapi/misc: Move add_client command with chardev code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/char.json | 32 qapi/misc.json | 32 monitor/qmp-cmds.c | 1 + 3 files changed, 33 insertions(+), 32 deletions(-) diff --git a/qapi/char.json b/qapi/char.json index 6907b2bfd

[PATCH 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 83 ++ qapi/misc.json | 83 -- include/sysemu/balloon.h | 2 +- balloon.c | 2 +- hw/virtio/virtio-balloon.c | 2 +- mon

[PATCH 5/9] hw/core/qdev-properties: Export qdev_prop_enum

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-properties.h | 1 + hw/core/qdev-properties.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h index f161604fb6..134753d595 100644 --- a/include/hw/qdev-properties.h

[PATCH 9/9] qapi/misc: Restrict device memory commands to machine code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 131 +++ qapi/misc.json | 132 include/hw/mem/memory-device.h | 1 + include/hw/virtio/virtio-pmem.h | 2 +- 4 files changed, 133 insertio

[PATCH 8/9] qapi/misc: Restrict PCI commands to machine code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 304 ++ qapi/misc.json| 304 -- hw/pci/pci-stub.c | 2 +- hw/pci/pci.c | 2 +- 4 files changed, 306 insertions(+), 306 deletions(-) d

[PATCH 7/9] qapi/misc: Restrict ACPI commands to machine code

2020-03-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json| 154 +++ qapi/misc.json | 154 --- include/hw/acpi/acpi_dev_interface.h | 2 +- hw/acpi/core.c | 2 +- hw/acpi/cpu.c

<    1   2   3   4   >