RE: [PATCH RFC 0/9] Add riscv64 kvm accel support

2020-03-13 Thread Jiangyifei
> -Original Message- > From: Anup Patel [mailto:a...@brainfault.org] > Sent: Friday, March 13, 2020 2:00 PM > To: Jiangyifei > Cc: QEMU Developers ; open list:RISC-V ri...@nongnu.org>; Anup Patel ; Zhanghailiang > ; Sagar Karandikar > ; Bastian Koppelmann paderborn.de>; Zhangxiaofeng (F

[PATCH] configure: Fix configure error.

2020-03-13 Thread Zhang Chen
From: Zhang Chen When run the ./configure will always get this error: Unknown option --exist It caused by this patch: commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d Author: Juan Quintela Date: Tue Dec 17 21:15:24 2019 +0100 configure: Enable test and libs for zstd Add it to several

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Paolo Bonzini
On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: >> diff --git a/cpus.c b/cpus.c >> index b4f8b84b61..1eb7533a91 100644 >> --- a/cpus.c >> +++ b/cpus.c >> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void) >> { >> CPUState *cpu; >> >> +if (!runstate_is

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-13 Thread Christian Ehrhardt 
Yeah @Boris - it really seems to be an issue bound to the Merom/Penryn processor generation. I asked Andreas to check through some kernels and qemu versions so that we maybe eventually can consider bisecting something. But that will take a bit of time. Of course everyone able to spend some time c

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-13 Thread Michael Tokarev
10.03.2020 12:39, Stefan Hajnoczi wrote: > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: >> On upgrades the old .so files usually are replaced. But on the other >> hand since a qemu process represents a guest instance it is usually kept >> around. >> >> That makes late additio

Re: [PATCH v9 11/15] s390x: protvirt: Disable address checks for PV guest IO emulation

2020-03-13 Thread Christian Borntraeger
On 12.03.20 17:17, Janosch Frank wrote: > On 3/12/20 5:10 PM, Christian Borntraeger wrote: >> >> >> On 12.03.20 17:07, Janosch Frank wrote: >>> On 3/12/20 4:41 PM, Christian Borntraeger wrote: On 11.03.20 14:21, Janosch Frank wrote: > IO instruction data is routed through SIDAD for prot

Re: [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly

2020-03-13 Thread Christian Borntraeger
On 12.03.20 17:13, Janosch Frank wrote: > On 3/12/20 4:51 PM, Christian Borntraeger wrote: >> On 11.03.20 14:21, Janosch Frank wrote: >>> For protected VMs status storing is not done by QEMU anymore. >>> >>> Signed-off-by: Janosch Frank >>> Reviewed-by: Thomas Huth >>> Reviewed-by: David Hilde

Re: [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly

2020-03-13 Thread Christian Borntraeger
On 12.03.20 17:13, Janosch Frank wrote: > On 3/12/20 4:51 PM, Christian Borntraeger wrote: >> On 11.03.20 14:21, Janosch Frank wrote: >>> For protected VMs status storing is not done by QEMU anymore. >>> >>> Signed-off-by: Janosch Frank >>> Reviewed-by: Thomas Huth >>> Reviewed-by: David Hilde

[PATCH] qom-qmp-cmds: remove unnecessary alloc in qmp_object_add to fix memleak

2020-03-13 Thread Pan Nengyuan
In qmp_object_add(), user_creatable_add_type() may set errp with some error message and return NULL. In this case, qmp_object_add() still alloc memory to *ret_data which return to the caller and causes a memory leak. This patch do this alloc() action only if obj is not NULL to fix it. And initi

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-13 Thread Paolo Bonzini
On 13/03/20 08:34, Michael Tokarev wrote: >> The use of /var/run makes me a little uneasy. I guess it's related to >> wanting to uninstall the old package so the .so in their original >> location cannot be used (even if they had a versioned path)? > > BTW, this is /run nowadays, not /var/run, as

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: [...] > +// Warn several Error * definitions. > +@check1 disable optional_qualifier exists@ > +identifier fn = rule1.fn, local_err, local_err2; > +@@ > + > + fn(..., Error ** , ...) > + { > + ... > + Error *local_err = NULL; > + ... when any >

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2020 10:50, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] +// Warn several Error * definitions. +@check1 disable optional_qualifier exists@ +identifier fn = rule1.fn, local_err, local_err2; +@@ + + fn(..., Error ** , ...) + { + ... + Error *local_err = N

Re: [PATCH v7 3/4] linux-user: Support futex_time64

2020-03-13 Thread Laurent Vivier
Le 12/03/2020 à 23:13, Alistair Francis a écrit : > Add support for host and target futex_time64. If futex_time64 exists on > the host we try that first before falling back to the standard futux > syscall. > > Signed-off-by: Alistair Francis > --- > linux-user/syscall.c | 144 +++

Re: [PATCH] configure: Fix configure error.

2020-03-13 Thread Laurent Vivier
Le 13/03/2020 à 07:55, Zhang Chen a écrit : > From: Zhang Chen > > When run the ./configure will always get this error: > Unknown option --exist > > It caused by this patch: > commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d > Author: Juan Quintela > Date: Tue Dec 17 21:15:24 2019 +0100 > >

Re: [kvm-unit-tests PATCH v6 10/13] arm/arm64: ITS: INT functional tests

2020-03-13 Thread Auger Eric
Hi Zenghui, On 3/13/20 3:06 AM, Zenghui Yu wrote: > On 2020/3/11 21:51, Eric Auger wrote: >> +static void test_its_trigger(void) >> +{ >> +    struct its_collection *col3, *col2; >> +    struct its_device *dev2, *dev7; >> + >> +    if (its_prerequisites(4)) >> +    return; >> + >> +    dev2 = i

Re: [PATCH v9] s390x: protvirt: Fence huge pages

2020-03-13 Thread Christian Borntraeger
On 12.03.20 17:25, Janosch Frank wrote: > Let's bail out of the protected transition if we detect that huge > pages might be in use. > > Signed-off-by: Janosch Frank > --- > > I'd like to squash this into the unpack patch to give a proper error > message if we try to transition into the prote

[PATCH 0/7] via-ide: fixes and improvements

2020-03-13 Thread Mark Cave-Ayland
Following on from the earlier thread "Implement "non 100% native mode" in via-ide", here is an updated patchset based upon the test cases sent to me off-list. The VIA IDE controller is similar to early versions of the PIIX controller in that the primary and secondary IDE channels are hardwired to

[PATCH 1/7] via-ide: move registration of VMStateDescription to DeviceClass

2020-03-13 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/ide/via.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 096de8dba0..84f0efff94 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -190,8 +190,6 @@ static void via_ide_realize(PCIDevice *dev, Error **errp

[PATCH 4/7] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default value

2020-03-13 Thread Mark Cave-Ayland
Some firmwares accidentally write to PCI_INTERRUPT_LINE on startup which has no effect on real hardware since it is hard-wired to its default value, but causes the guest OS to become confused trying to initialise IDE devices when running under QEMU. Signed-off-by: Mark Cave-Ayland --- hw/ide/via

[PATCH 5/7] via-ide: initialise IDE controller in legacy mode

2020-03-13 Thread Mark Cave-Ayland
According to both the VT82C686B and VT8231 datasheets the VIA Southbridge IDE controller is initialised in legacy mode. This allows Linux to correctly determine that legacy rather than PCI IRQ routing should be used since the boot console text in the fulong2e test image changes from: scsi0 : pat

[PATCH 7/7] via-ide: always use legacy IRQ 14/15 routing

2020-03-13 Thread Mark Cave-Ayland
The existing code uses fixed PCI IRQ routing on IRQ 14 rather than legacy IRQ 14/15 routing as documented in the datasheet. With the changes in this patchset guest OSs now correctly detect and configure the VIA controller in legacy IRQ routing mode, allowing the incorrect fixed PCI IRQ routing to

[PATCH 2/7] ide/via: Get rid of via_ide_init()

2020-03-13 Thread Mark Cave-Ayland
From: BALATON Zoltan Follow example of CMD646 and remove via_ide_init function and do it directly in board code instead. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland --- hw/ide/via.c| 8 hw/mips/mips_fulong2e.c | 5 - include/hw/ide.h| 1 - 3 fi

[PATCH 3/7] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-13 Thread Mark Cave-Ayland
From: BALATON Zoltan The pci_do_device_reset() function (called from pci_device_reset) clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did this without taking wmask into account. We'll have a device model now that needs to set a constant value for this reg and this patch allows

[PATCH 6/7] via-ide: allow guests to write to PCI_CLASS_PROG

2020-03-13 Thread Mark Cave-Ayland
MorphOS writes to PCI_CLASS_PROG during IDE initialisation to place the controller in native mode, but thinks the initialisation has failed because the native mode bits aren't set when reading the register back. Signed-off-by: Mark Cave-Ayland --- hw/ide/via.c | 1 + 1 file changed, 1 insertion(

[PATCH 0/3] iotests: Fix intermittent 030 hang

2020-03-13 Thread Kevin Wolf
Peter ran into a 030 hang while testing a pull request. This turned out to be two bugs in the test suite at once: First was the test failing because a timeout was apparently too short, second was that the timeout would actually cause the test to hang instead of failing. This series should fix both.

[PATCH 1/3] iotests.py: Enable faulthandler

2020-03-13 Thread Kevin Wolf
With this, you can send SIGABRT to a hanging test case and you'll get a Python stack trace so you know where it was hanging. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotes

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
On 2020/3/13 15:09, Paolo Bonzini wrote: > On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product > Dept.) wrote: >>> diff --git a/cpus.c b/cpus.c >>> index b4f8b84b61..1eb7533a91 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void) >>>

[PATCH 2/3] python/qemu: Kill QEMU process if 'quit' doesn't work

2020-03-13 Thread Kevin Wolf
With a QEMU bug, it can happen that the QEMU process doesn't react to a 'quit' QMP command. If we got an exception during previous QMP communication (e.g. iotests Timeout expiring), we could also be in an inconsistent state where after sending 'quit' we immediately read an old response and close th

[PATCH 3/3] iotests: Increase pause_wait() timeout

2020-03-13 Thread Kevin Wolf
Waiting for only 1 second proved to be too short on a loaded system, resulting in false positives when testing pull requests. Increase the timeout a bit to make this less likely. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile

2020-03-13 Thread Erik Skultety
On Thu, Mar 12, 2020 at 03:36:12PM -0400, Cleber Rosa wrote: > Which is currenly missing, and will be referenced later in the > contributed CI playbooks. > > Signed-off-by: Cleber Rosa > --- > tests/docker/dockerfiles/centos8.docker | 32 + > 1 file changed, 32 insertions

Re: [PATCH RFCv2 2/4] intc/s390_flic_kvm.c: Use kvm_device_ioctl() instead of ioctl()

2020-03-13 Thread Christian Borntraeger
On 12.03.20 17:12, David Hildenbrand wrote: > Let's use the official variant, which will e.g., trace the call. > kvm_device_ioctl() will do the rc -> -errno conversion automatically, so > we can drop that code. > > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: qemu-s3

RE: [PATCH] configure: Fix configure error.

2020-03-13 Thread Zhang, Chen
> -Original Message- > From: Laurent Vivier > Sent: Friday, March 13, 2020 4:18 PM > To: Zhang, Chen ; qemu-dev de...@nongnu.org> > Cc: Zhang Chen ; Dr . David Alan Gilbert > ; Juan Quintela > Subject: Re: [PATCH] configure: Fix configure error. > > Le 13/03/2020 à 07:55, Zhang Chen a

Re: [PATCH 3/4] spapr: Rename DT functions to newer naming convention

2020-03-13 Thread Cédric Le Goater
On 3/13/20 5:05 AM, David Gibson wrote: > In the spapr code we've been gradually moving towards a convention that > functions which create pieces of the device tree are called spapr_dt_*(). > This patch speeds that along by renaming most of the things that don't yet > match that so that they do. >

Re: [PATCH] configure: Fix configure error.

2020-03-13 Thread Dr. David Alan Gilbert
* Zhang, Chen (chen.zh...@intel.com) wrote: > > > > -Original Message- > > From: Laurent Vivier > > Sent: Friday, March 13, 2020 4:18 PM > > To: Zhang, Chen ; qemu-dev > de...@nongnu.org> > > Cc: Zhang Chen ; Dr . David Alan Gilbert > > ; Juan Quintela > > Subject: Re: [PATCH] configur

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Paolo Bonzini
On 13/03/20 09:36, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: >> You're right, do_vm_stop sets the runstate after pause_all_vcpus. We >> can move that before and it should fix your case too. >> > Uh, it seems to work. So can I send a patch based on your suggestion ? Or feel

Re: [PATCH 4/4] spapr: Fold spapr_node0_size() into its only caller

2020-03-13 Thread Greg Kurz
On Fri, 13 Mar 2020 15:05:39 +1100 David Gibson wrote: > The Real Mode Area (RMA) needs to fit within the NUMA node owning memory > at address 0. That's usually node 0, but can be a later one if there are > some nodes which have no memory (only CPUs). > > This is currently handled by the spapr_

Re: [PATCH v9 02/15] s390x: protvirt: Support unpack facility

2020-03-13 Thread Janosch Frank
On 3/12/20 9:33 AM, Christian Borntraeger wrote: > > > On 11.03.20 14:21, Janosch Frank wrote: > [...] >> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c >> index b81942e1e6f9002e..98df89e62c25f583 100644 >> --- a/hw/s390x/ipl.c >> +++ b/hw/s390x/ipl.c >> @@ -27,6 +27,7 @@ >> #include "hw/s390x/vfi

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Igor Mammedov
On Thu, 12 Mar 2020 20:48:48 +0200 Liran Alon wrote: > On 12/03/2020 18:35, Igor Mammedov wrote: > > On Thu, 12 Mar 2020 14:55:50 +0200 > > Liran Alon wrote: > > > >> On 12/03/2020 14:19, Michael S. Tsirkin wrote: > >>> On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote: > On

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Igor Mammedov
On Thu, 12 Mar 2020 13:09:51 -0400 "Michael S. Tsirkin" wrote: > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > On Wed, 11 Mar 2020 19:08:26 +0200 > > Liran Alon wrote: > > > > > From: Elad Gabay > > > > > > Microsoft introduced this ACPI table to avoid Windows guests pe

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
On 2020/3/13 17:22, Paolo Bonzini wrote: > On 13/03/20 09:36, Longpeng (Mike, Cloud Infrastructure Service Product > Dept.) wrote: >>> You're right, do_vm_stop sets the runstate after pause_all_vcpus. We >>> can move that before and it should fix your case too. >>> >> Uh, it seems to work. So c

[PATCH v9] fixup! Fix subcode/pbt

2020-03-13 Thread Janosch Frank
Signed-off-by: Janosch Frank --- hw/s390x/ipl.h | 11 +++ target/s390x/diag.c | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h index 95e3183c9cccf8b6..f799f7cfcf4763b1 100644 --- a/hw/s390x/ipl.h +++ b/hw/s390x/ipl.h @@ -261,15 +

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Igor Mammedov
On Thu, 12 Mar 2020 19:28:31 +0200 Liran Alon wrote: > On 12/03/2020 18:27, Igor Mammedov wrote: > > On Wed, 11 Mar 2020 19:08:26 +0200 > > Liran Alon wrote: > >> + [...] > > we typically do not version ACPI table changes (there might be exceptions > > but it should be a justified one). > > AC

[PULL 0/5] migration queue

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit d4f7d56759f7c75270c13d5f3f5f736a9558929c: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200312' into staging (2020-03-12 17:34:34 +) are available in the Git repository at: git://github.com/dagrh

[PULL 1/5] configure: Improve zstd test

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela There were one error on the test (missing an s for --exists). But we really need a recent zstd (1.4.0). Thanks to Michal Privoznik to provide the right vension. Signed-off-by: Juan Quintela Reported-by: Richard Henderson Message-Id: <20200310111431.173151-1-quint...@redhat.

[PULL 2/5] migration/throttle: Add throttle-trig-thres migration parameter

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: Keqian Zhu Currently, if the bytes_dirty_period is more than the 50% of bytes_xfer_period, we start or increase throttling. If we make this percentage higher, then we can tolerate higher dirty rate during migration, which means less impact on guest. The side effect of higher percentage is

[PULL 3/5] COLO: Optimize memory back-up process

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang This patch will reduce the downtime of VM for the initial process, Previously, we copied all these memory in preparing stage of COLO while we need to stop VM, which is a time-consuming process. Here we optimize it by a trick, back-up every page while in migration process while

[PULL 4/5] ram/colo: only record bitmap of dirty pages in COLO stage

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang It is only need to record bitmap of dirty pages while goes into COLO stage. Signed-off-by: zhanghailiang Message-Id: <20200224065414.36524-6-zhang.zhanghaili...@huawei.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 9 +

[PULL 5/5] migration: recognize COLO as part of activating process

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang We will migrate parts of dirty pages backgroud lively during the gap time of two checkpoints, without this modification, it will not work because ram_save_iterate() will check it before send RAM_SAVE_FLAG_EOS at the end of it. Signed-off-by: zhanghailiang Message-Id: <202002

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-13 Thread Daniel P . Berrangé
On Fri, Mar 13, 2020 at 08:45:21AM +0100, Paolo Bonzini wrote: > On 13/03/20 08:34, Michael Tokarev wrote: > >> The use of /var/run makes me a little uneasy. I guess it's related to > >> wanting to uninstall the old package so the .so in their original > >> location cannot be used (even if they ha

Re: [PATCH] hw/net/i82596: Correct command bitmask (CID 1419392)

2020-03-13 Thread Peter Maydell
On Fri, 14 Feb 2020 at 00:48, Philippe Mathieu-Daudé wrote: > > The command is 32-bit, but we are loading the 16 upper bits with > the 'get_uint16(s->scb + 2)' call. > > Once shifted by 16, the command bits match the status bits: > > - Command > Bit 31 ACK-CX Acknowledges that the CU completed

Re: [PATCH v3 0/5] Wire up USB controllers in i.MX6 emulations

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 01:45, Guenter Roeck wrote: > > This patch series wires up the USB controllers on fsl-imx6 and fsl-imx6ul > emulations. > > The first patch provides a basic implementation of the USB PHY controller > used in i.MX28 and later chips. Only reset bit handling in the control > re

Re: [PATCH 1/4] spapr: Move creation of ibm, dynamic-reconfiguration-memory dt node

2020-03-13 Thread Greg Kurz
On Fri, 13 Mar 2020 15:05:36 +1100 David Gibson wrote: > Currently this node with information about hotpluggable memory is created > from spapr_dt_cas_updates(). But that's just a hangover from when we > created it only as a diff to the device tree at CAS time. Now that we > fully rebuild the D

Re: [PATCH v3] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 03:23, Chen Qun wrote: > > The current code causes clang static code analyzer generate warning: > hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read > value = value & 0x000f; > ^ ~~ > hw/net/imx_fec.c:864:9: warni

Re: [PATCH 2/4] spapr: Move creation of ibm,architecture-vec-5 property

2020-03-13 Thread Greg Kurz
On Fri, 13 Mar 2020 15:05:37 +1100 David Gibson wrote: > This is currently called from spapr_dt_cas_updates() which is a hang over > from when we created this only as a diff to the DT at CAS time. Now that > we fully rebuild the DT at CAS time, just create it alon with the rest s/alon/along >

Re: [PATCH 3/4] spapr: Rename DT functions to newer naming convention

2020-03-13 Thread Greg Kurz
On Fri, 13 Mar 2020 15:05:38 +1100 David Gibson wrote: > In the spapr code we've been gradually moving towards a convention that > functions which create pieces of the device tree are called spapr_dt_*(). > This patch speeds that along by renaming most of the things that don't yet > match that so

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2020-03-13 Thread John Boero
Also affects RISC-V apparently. https://github.com/moby/moby/issues/40240 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847232 Title: qemu TCG in s390x mode issue with calculating HASH Status in

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2020-03-13 Thread John Boero
Thank you so much! I've been hitting the same issue with s390x. Maybe an endian issue with hardware vx? ** Bug watch added: github.com/moby/moby/issues #40240 https://github.com/moby/moby/issues/40240 -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH 0/7] via-ide: fixes and improvements

2020-03-13 Thread BALATON Zoltan
On Fri, 13 Mar 2020, Mark Cave-Ayland wrote: Following on from the earlier thread "Implement "non 100% native mode" in via-ide", here is an updated patchset based upon the test cases sent to me off-list. The VIA IDE controller is similar to early versions of the PIIX controller in that the prima

RE: [PATCH v3] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-13 Thread Chenqun (kuhn)
>-Original Message- >From: Peter Maydell [mailto:peter.mayd...@linaro.org] >Sent: Friday, March 13, 2020 7:31 PM >To: Chenqun (kuhn) >Cc: QEMU Developers ; QEMU Trivial triv...@nongnu.org>; Zhanghailiang ; >Euler Robot ; Jason Wang >; Peter Chubb >Subject: Re: [PATCH v3] hw/net/imx_fec: w

[PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit 355477f8c73e9 skips rom reset when we're an incoming migration so as not to overwrite shared ram in the ignore-shared migration optimisation. However, it's got an unexpected side effect that because it skips freeing the ROM data, when rom_reset gets called la

[PATCH v4] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-13 Thread Chen Qun
The current code causes clang static code analyzer generate warning: hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read value = value & 0x000f; ^ ~~ hw/net/imx_fec.c:864:9: warning: Value stored to 'value' is never read value = v

Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-13 Thread Halil Pasic
[..] > > > > CCing Tom. @Tom does vhost-vsock work for you with SEV and current qemu? > > > > Also, one can specify iommu_platform=on on a device that ain't a part of > > a secure-capable VM, just for the fun of it. And that breaks > > vhost-vsock. Or is setting iommu_platform=on only valid if >

Re: [PATCH v9 08/15] s390x: protvirt: SCLP interpretation

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:44 -0400 Janosch Frank wrote: > SCLP for a protected guest is done over the SIDAD, so we need to use > the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest > memory when reading/writing SCBs. > > To not confuse the sclp emulation, we set 0x4000 as the SC

Re: [PATCH v9 11/15] s390x: protvirt: Disable address checks for PV guest IO emulation

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:47 -0400 Janosch Frank wrote: > IO instruction data is routed through SIDAD for protected guests, so > adresses do not need to be checked, as this is kernel memory. > > Signed-off-by: Janosch Frank > Reviewed-by: Thomas Huth > Reviewed-by: David Hildenbrand > --- >

Re: [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:43 -0400 Janosch Frank wrote: > For protected guests, we need to put the STSI emulation results into > the SIDA, so SIE will write them into the guest at the next entry. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > target/s390x/kvm.c | 11

Re: [PATCH v9 02/15] s390x: protvirt: Support unpack facility

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:38 -0400 Janosch Frank wrote: > The unpack facility provides the means to setup a protected guest. A > protected guest cannot be introspected by the hypervisor or any > user/administrator of the machine it is running on. > > Protected guests are encrypted at rest and ne

Re: [PATCH v9 10/15] s390x: protvirt: Move diag 308 data over SIDA

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:46 -0400 Janosch Frank wrote: > For protected guests the IPIB is written/read to/from the SIDA, so we > need those accesses to go through s390_cpu_pv_mem_read/write(). > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > target/s390x/diag.c | 27

Re: [PATCH v9 14/15] docs: Add protvirt docs

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:50 -0400 Janosch Frank wrote: > Lets add some documentation for the Protected VM functionality. > > Signed-off-by: Janosch Frank > --- > docs/system/index.rst| 1 + > docs/system/protvirt.rst | 56 > 2 files changed, 57 > i

Re: [PATCH v9 06/15] s390x: Add SIDA memory ops

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:42 -0400 Janosch Frank wrote: > Protected guests save the instruction control blocks in the SIDA > instead of QEMU/KVM directly accessing the guest's memory. > > Let's introduce new functions to access the SIDA. > > Also the new memops are available with KVM_CAP_S390_P

Re: [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:49 -0400 Janosch Frank wrote: > For protected VMs status storing is not done by QEMU anymore. > > Signed-off-by: Janosch Frank > Reviewed-by: Thomas Huth > Reviewed-by: David Hildenbrand > --- > target/s390x/helper.c | 6 ++ > 1 file changed, 6 insertions(+) >

Re: [PATCH v9 12/15] s390x: protvirt: Move IO control structures over SIDA

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:48 -0400 Janosch Frank wrote: > For protected guests, we need to put the IO emulation results into the > SIDA, so SIE will write them into the guest at the next entry. > > Signed-off-by: Janosch Frank > --- > target/s390x/ioinst.c | 87 > ++

Re: [PATCH v9 05/15] s390x: protvirt: KVM intercept changes

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:41 -0400 Janosch Frank wrote: > Protected VMs no longer intercept with code 4 for an instruction > interception. Instead they have codes 104 and 108 for protected > instruction interception and protected instruction notification > respectively. > > The 104 mirrors the 4

Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:45 -0400 Janosch Frank wrote: > Handling of CPU reset and setting of the IPL psw from guest storage at > offset 0 is done by a Ultravisor call. Let's only fetch it if > necessary. > > Signed-off-by: Janosch Frank > Reviewed-by: Thomas Huth > Reviewed-by: David Hildenb

Re: [PATCH v9 03/15] s390x: protvirt: Add migration blocker

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:39 -0400 Janosch Frank wrote: > Migration is not yet supported. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/hw/s390x/s390-virtio-ccw

Re: [PATCH v9 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:40 -0400 Janosch Frank wrote: > Ballooning in protected VMs can only be done when the guest shares the > pages it gives to the host. If pages are not shared, the integrity > checks will fail once those pages have been altered and are given back > to the guest. > > As we

Re: [PATCH v9 15/15] s390x: Add unpack facility feature to GA1

2020-03-13 Thread Claudio Imbrenda
On Wed, 11 Mar 2020 09:21:51 -0400 Janosch Frank wrote: > From: Christian Borntraeger > > The unpack facility is an indication that diagnose 308 subcodes 8-10 > are available to the guest. That means, that the guest can put itself > into protected mode. > > Once it is in protected mode, the ha

Re: [PATCH v9 08/15] s390x: protvirt: SCLP interpretation

2020-03-13 Thread Christian Borntraeger
On 11.03.20 14:21, Janosch Frank wrote: > SCLP for a protected guest is done over the SIDAD, so we need to use > the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest > memory when reading/writing SCBs. > > To not confuse the sclp emulation, we set 0x4000 as the SCCB address, > s

Re: [PATCH v9 12/15] s390x: protvirt: Move IO control structures over SIDA

2020-03-13 Thread Janosch Frank
On 3/13/20 1:57 PM, Claudio Imbrenda wrote: > On Wed, 11 Mar 2020 09:21:48 -0400 > Janosch Frank wrote: > >> For protected guests, we need to put the IO emulation results into the >> SIDA, so SIE will write them into the guest at the next entry. >> >> Signed-off-by: Janosch Frank >> --- >> targ

Re: [PATCH v9 14/15] docs: Add protvirt docs

2020-03-13 Thread Janosch Frank
On 3/13/20 2:00 PM, Claudio Imbrenda wrote: > On Wed, 11 Mar 2020 09:21:50 -0400 > Janosch Frank wrote: > >> Lets add some documentation for the Protected VM functionality. >> >> Signed-off-by: Janosch Frank >> --- >> docs/system/index.rst| 1 + >> docs/system/protvirt.rst | 56 >>

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 12:31, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > Commit 355477f8c73e9 skips rom reset when we're an incoming migration > so as not to overwrite shared ram in the ignore-shared migration > optimisation. > However, it's got an unexpected side

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 13:21, Peter Maydell wrote: > > On Fri, 13 Mar 2020 at 12:31, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > Commit 355477f8c73e9 skips rom reset when we're an incoming migration > > so as not to overwrite shared ram in the ignore-shar

Re: [PATCH v9 14/15] docs: Add protvirt docs

2020-03-13 Thread Peter Maydell
On Wed, 11 Mar 2020 at 13:31, Janosch Frank wrote: > > Lets add some documentation for the Protected VM functionality. > > Signed-off-by: Janosch Frank > --- > docs/system/index.rst| 1 + > docs/system/protvirt.rst | 56 > 2 files changed, 57 inserti

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-13 Thread Dr. David Alan Gilbert
The vmx things make me wonder about a fix Paolo did a while ago for enabling inidivudal vmx features rather than vmx as a whole; but I can't remember if that was a kernel or qemu fix. One thing I notice, that may be a red-herring, all of the machine code in the errors are 'f3 0f 1e fb' which is t

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 13 Mar 2020 at 13:21, Peter Maydell wrote: > > > > On Fri, 13 Mar 2020 at 12:31, Dr. David Alan Gilbert (git) > > wrote: > > > > > > From: "Dr. David Alan Gilbert" > > > > > > Commit 355477f8c73e9 skips rom reset when we're an incoming

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 13:34, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Fri, 13 Mar 2020 at 13:21, Peter Maydell > > wrote: > > > > > > On Fri, 13 Mar 2020 at 12:31, Dr. David Alan Gilbert (git) > > > wrote: > > > > > > > > From: "Dr. David Alan

Re: [PATCH 0/5] QEMU Gating CI

2020-03-13 Thread Peter Maydell
On Thu, 12 Mar 2020 at 22:16, Cleber Rosa wrote: > > On Thu, Mar 12, 2020 at 10:00:42PM +, Peter Maydell wrote: > > OK, so my question here is: > > * what are the instructions that I have to follow to be > > able to say "ok, here's my branch, run it through these tests, > > please" ? > > The

Re: [PATCH 4/5] GitLab Gating CI: introduce pipeline-status contrib script

2020-03-13 Thread Peter Maydell
On Thu, 12 Mar 2020 at 19:37, Cleber Rosa wrote: > > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or with the `--w

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 13 Mar 2020 at 13:34, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Fri, 13 Mar 2020 at 13:21, Peter Maydell > > > wrote: > > > > > > > > On Fri, 13 Mar 2020 at 12:31, Dr. David Alan

Re: [RFC] [PATCH 0/5] ARMv8.5-MemTag disassembly

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 13:59, Rémi Denis-Courmont wrote: > > Hello, > > The following changes since commit d4f7d56759f7c75270c13d5f3f5f736a9558929c: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200312' into staging (2020-03-12 > 17:34:34 +) > > adds s

Re: [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile

2020-03-13 Thread Alex Bennée
Erik Skultety writes: > On Thu, Mar 12, 2020 at 03:36:12PM -0400, Cleber Rosa wrote: >> Which is currenly missing, and will be referenced later in the >> contributed CI playbooks. >> >> Signed-off-by: Cleber Rosa >> --- >> tests/docker/dockerfiles/centos8.docker | 32

Re: [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile

2020-03-13 Thread Alex Bennée
Cleber Rosa writes: > Which is currenly missing, and will be referenced later in the > contributed CI playbooks. > > Signed-off-by: Cleber Rosa Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/centos8.docker | 32 + > 1 file changed, 32 insertions(+) > cre

Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW

2020-03-13 Thread Christian Borntraeger
On 13.03.20 15:21, Janosch Frank wrote: [..] >>> +} else { >>> +s390_cpu_set_state(S390_CPU_STATE_LOAD, cpu); >>> +} >>> s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu); >>> } >>> #endif >> >> I don't understand why you set the state to S390_CPU_STATE_LOAD and >> then im

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Liran Alon
On 13/03/2020 12:05, Igor Mammedov wrote: On Thu, 12 Mar 2020 19:28:31 +0200 Liran Alon wrote: On 12/03/2020 18:27, Igor Mammedov wrote: On Wed, 11 Mar 2020 19:08:26 +0200 Liran Alon wrote: + [...] we typically do not version ACPI table changes (there might be exceptions but it should b

Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 13:57, Dr. David Alan Gilbert wrote: > Ah yes, I think you're right, so something like: > > if (runstate_check(RUN_STATE_INMIGRATE) && rom->data && rom->isrom) { I think you would see the difference here for images loaded into RAM, rather than ROM -- they need to be reins

Re: [PATCH v7 2/5] virtio-iommu: Add iommu notifier for map/unmap

2020-03-13 Thread Auger Eric
Hi Bharat, On 3/13/20 8:48 AM, Bharat Bhushan wrote: > This patch extends VIRTIO_IOMMU_T_MAP/UNMAP request to > notify registered iommu-notifier. Which will call vfio s/iommu-notifier/iommu-notifiers > notifier to map/unmap region in iommu. can be any notifier (vhost/vfio). > > Signed-off-by: Bhar

Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW

2020-03-13 Thread Janosch Frank
On 3/13/20 1:57 PM, Claudio Imbrenda wrote: > On Wed, 11 Mar 2020 09:21:45 -0400 > Janosch Frank wrote: > >> Handling of CPU reset and setting of the IPL psw from guest storage at >> offset 0 is done by a Ultravisor call. Let's only fetch it if >> necessary. >> >> Signed-off-by: Janosch Frank >>

Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW

2020-03-13 Thread Claudio Imbrenda
On Fri, 13 Mar 2020 15:21:07 +0100 Janosch Frank wrote: > On 3/13/20 1:57 PM, Claudio Imbrenda wrote: > > On Wed, 11 Mar 2020 09:21:45 -0400 > > Janosch Frank wrote: > > > >> Handling of CPU reset and setting of the IPL psw from guest > >> storage at offset 0 is done by a Ultravisor call. Let

Re: [PATCH v4] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 12:33, Chen Qun wrote: > > The current code causes clang static code analyzer generate warning: > hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read > value = value & 0x000f; > ^ ~~ > hw/net/imx_fec.c:864:9: warni

Re: [PATCH v9] fixup! Fix subcode/pbt

2020-03-13 Thread Christian Borntraeger
On 13.03.20 10:52, Janosch Frank wrote: > Signed-off-by: Janosch Frank looks sane. You will merge this? > --- > hw/s390x/ipl.h | 11 +++ > target/s390x/diag.c | 2 +- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h > index 95

Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW

2020-03-13 Thread Claudio Imbrenda
On Fri, 13 Mar 2020 15:21:07 +0100 Janosch Frank wrote: > On 3/13/20 1:57 PM, Claudio Imbrenda wrote: > > On Wed, 11 Mar 2020 09:21:45 -0400 > > Janosch Frank wrote: > > > >> Handling of CPU reset and setting of the IPL psw from guest > >> storage at offset 0 is done by a Ultravisor call. Let

  1   2   3   4   >