Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is
> never read
> is_dirty = false;
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> ---
> Cc: Igor Mitsyanko
Signed-off-by: LIU Zhiwei
---
target/riscv/helper.h | 33 ++
target/riscv/insn32.decode | 10 ++
target/riscv/insn_trans/trans_rvv.inc.c | 108 ++
target/riscv/vector_helper.c| 140
4 files changed, 291 inse
Signed-off-by: LIU Zhiwei
---
target/riscv/helper.h | 49 +
target/riscv/insn32.decode | 16 ++
target/riscv/insn_trans/trans_rvv.inc.c | 18 ++
target/riscv/vector_helper.c| 228
4 files changed, 311 insertions(+)
diff -
Peter Maydell writes:
> On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote:
>> On 3/9/2020 5:21 PM, Peter Maydell wrote:
>> > Could you explain more? My thought is that we should be using
>> > sysbus_init_child_obj() and we should be doing it in the init method.
>> > Why does that break the tests ?
Fix a bug reported by Youry few months ago:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg625606.html
Since v1:
- addressed Daniel review (always define STRUCT_IOVEC_DEFINED)
The Fedora docker image already uses the libsasl since commit
8ea5962f286. Add the similar package to the Debian (
Signed-off-by: LIU Zhiwei
---
target/riscv/helper.h | 5 +
target/riscv/insn32.decode | 2 ++
target/riscv/insn_trans/trans_rvv.inc.c | 4
target/riscv/vector_helper.c| 22 ++
4 files changed, 33 insertions(+)
diff --git
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> The "again" assignment is meaningless before g_assert_not_reached.
> In addition, the break statements no longer needs to be after
> g_assert_not_reached.
>
> Clang static code analyzer show warning:
> hw/usb/hcd-ehci.c:2108:13: warning: Value stored to
The Simple Authentication and Security Layer (SASL) library
re-defines the struct iovec on Win32 [*]. QEMU also re-defines
it in "qemu/osdep.h". The two definitions then clash on a MinGW
build.
We can avoid the SASL definition by defining STRUCT_IOVEC_DEFINED.
Since QEMU already defines 'struct iov
On Mon, Mar 09, 2020 at 01:24:53PM +0100, Philippe Mathieu-Daudé wrote:
> The Simple Authentication and Security Layer (SASL) library
> re-defines the struct iovec on Win32 [*]. QEMU also re-defines
> it in "qemu/osdep.h". The two definitions then clash on a MinGW
> build.
> We can avoid the SASL d
Install the SASL library to build the VNC SASL auth protocol code.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-amd64.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/debian-amd64.docker
b/tests/doc
From: Philippe Mathieu-Daudé
The string returned by g_win32_error_message() has to be
deallocated with g_free().
Reviewed-by: Marc-André Lureau
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200228100726.8414-5-phi...@redhat.com>
Signed-off-by: Markus Armbruster
---
qga/channel-win32.c
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
> dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
> ^ ~
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read
> buflen = req->cmd.xfer;
> ^~
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> ---
> Cc: Paolo Bonz
On 3/9/20 1:30 PM, Daniel P. Berrangé wrote:
On Mon, Mar 09, 2020 at 01:24:53PM +0100, Philippe Mathieu-Daudé wrote:
The Simple Authentication and Security Layer (SASL) library
re-defines the struct iovec on Win32 [*]. QEMU also re-defines
it in "qemu/osdep.h". The two definitions then clash on
From: Philippe Mathieu-Daudé
Use error_setg_win32() which adds a hint similar to strerror(errno)).
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200228100726.8414-4-phi...@redhat.com>
Reviewed-by: Marc-André Lureau
Signed-off-by: Markus Armbruster
---
qga/channel-win32.c | 3 ++-
qga
From: Philippe Mathieu-Daudé
Use error_setg_win32() which adds a hint similar to strerror(errno)).
Reviewed-by: Marc-André Lureau
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200228100726.8414-3-phi...@redhat.com>
Signed-off-by: Markus Armbruster
---
util/osdep.c | 4 ++--
1 file cha
The following changes since commit 67f17e23baca5dd545fe98b01169cc351a70fe35:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2020-03-06 17:15:36 +)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-error-2020-03-09
for you t
From: Philippe Mathieu-Daudé
Use error_setg_win32() which adds a hint similar to strerror(errno)).
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Marc-André Lureau
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200228100726.8414-2-phi...@redhat.com>
Signed-off-by: Markus Armbruster
---
On 3/9/2020 8:34 PM, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote:
>>> On 3/9/2020 5:21 PM, Peter Maydell wrote:
Could you explain more? My thought is that we should be using
sysbus_init_child_obj() and we should be doing it i
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
> set = true;
> ^
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> Reviewed-by: Philipp
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read
> buflen = req->cmd.xfer;
> ^~
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> ---
> Cc: Paolo Bonz
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read
> format = 0;
> ^~
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> ---
> Cc: Andrzej Zaborowski
>-Original Message-
>From: Laurent Vivier [mailto:laur...@vivier.eu]
>Sent: Monday, March 9, 2020 8:43 PM
>To: Chenqun (kuhn) ; qemu-
>de...@nongnu.org; qemu-triv...@nongnu.org
>Cc: peter.mayd...@linaro.org; Zhanghailiang
>; Gerd Hoffmann ;
>Euler Robot ; Philippe Mathieu-Daudé
>
>Subject:
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is
> never read
> is_dirty = false;
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> ---
> Cc: Igor Mitsyanko
Le 09/03/2020 à 13:52, Chenqun (kuhn) a écrit :
>
>> -Original Message-
>> From: Laurent Vivier [mailto:laur...@vivier.eu]
>> Sent: Monday, March 9, 2020 8:43 PM
>> To: Chenqun (kuhn) ; qemu-
>> de...@nongnu.org; qemu-triv...@nongnu.org
>> Cc: peter.mayd...@linaro.org; Zhanghailiang
>> ; G
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
> set = true;
> ^
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
> Reviewed-by: Philipp
Le 09/03/2020 à 13:11, Philippe Mathieu-Daudé a écrit :
> cpu_reset() might modify architecture-specific fields allocated
> by qemu_init_vcpu(). To avoid bugs similar to the one fixed in
> commit 00d0f7cb66 when introducing new architectures, move the
> cpu_reset() calls after qemu_init_vcpu().
>
On Mon, 9 Mar 2020 at 12:11, Philippe Mathieu-Daudé wrote:
>
> cpu_reset() might modify architecture-specific fields allocated
> by qemu_init_vcpu(). To avoid bugs similar to the one fixed in
> commit 00d0f7cb66 when introducing new architectures, move the
> cpu_reset() calls after qemu_init_vcpu(
On Mon, 9 Mar 2020 at 12:11, Philippe Mathieu-Daudé wrote:
>
> cpu_reset() might modify architecture-specific fields allocated
> by qemu_init_vcpu(). To avoid bugs similar to the one fixed in
> commit 00d0f7cb66 when introducing new architectures, assert a
> vCPU is created before resetting it.
>
Le 09/03/2020 à 14:09, Peter Maydell a écrit :
> On Mon, 9 Mar 2020 at 12:11, Philippe Mathieu-Daudé wrote:
>>
>> cpu_reset() might modify architecture-specific fields allocated
>> by qemu_init_vcpu(). To avoid bugs similar to the one fixed in
>> commit 00d0f7cb66 when introducing new architecture
On Mon, 9 Mar 2020 at 13:13, Laurent Vivier wrote:
>
> Le 09/03/2020 à 14:09, Peter Maydell a écrit :
> > On Mon, 9 Mar 2020 at 12:11, Philippe Mathieu-Daudé
> > wrote:
> >>
> >> cpu_reset() might modify architecture-specific fields allocated
> >> by qemu_init_vcpu(). To avoid bugs similar to th
On Mon, 9 Mar 2020 11:16:10 +
bauerchen(陈蒙蒙) wrote:
> Thanks, in fact,do_touch_pages is called just when vm starts up, but using
> init flag and Gonce maybe more elegant !
> if needed,I can submit a new patch !
> thanks very much!
it's called from os_mem_prealloc() -> touch_all_pages() wh
On 3/6/2020 12:40 AM, Peter Maydell wrote:
On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote:
On a Thursday in 2020, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always not defined in this file.
This fixes that "config-host.h" header file is not included
for getting macros.
Signed-off-by: Jingqi L
On Mon, 2 Mar 2020 at 10:55, Eric Auger wrote:
>
> Restructure the finalize_gic_version with switch cases and, in
> KVM mode, explictly check whether the chosen version is supported
> by the host.
>
> if the end-user explicitly sets v2/v3 and this is not supported by
> the host, then the user gets
Le 09/03/2020 à 14:18, Peter Maydell a écrit :
> On Mon, 9 Mar 2020 at 13:13, Laurent Vivier wrote:
>>
>> Le 09/03/2020 à 14:09, Peter Maydell a écrit :
>>> On Mon, 9 Mar 2020 at 12:11, Philippe Mathieu-Daudé
>>> wrote:
cpu_reset() might modify architecture-specific fields allocated
>>
We expose loadparm as a r/w machine property, but if loadparm is set by
the guest via DIAG 308, we don't update the property. Having a
disconnect between the guest view and the QEMU property is not nice in
itself, but things get even worse for SCSI, where under certain
circumstances (see 789b5a401b
On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote:
>
> On 3/6/2020 12:40 AM, Peter Maydell wrote:
> > On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote:
> >> On a Thursday in 2020, Jingqi Liu wrote:
> >>> The CONFIG_LINUX symbol is always not defined in this file.
> >>> This fixes that "config-host.h" he
On Mon, 09 Mar 2020 19:54:20 +0900,
Philippe Mathieu-Daudé wrote:
>
> On 3/9/20 7:30 AM, Yoshinori Sato wrote:
> > On Mon, 09 Mar 2020 01:20:05 +0900,
> > Philippe Mathieu-Daudé wrote:
> >>
> >> On 2/24/20 3:19 PM, Yoshinori Sato wrote:
> >>> From: Philippe Mathieu-Daudé
> >>>
> >>> Add two tes
On 09.03.20 12:21, Janosch Frank wrote:
> The unpack facility provides the means to setup a protected guest. A
> protected guest can not be introspected by the hypervisor or any
> user/administrator of the machine it is running on.
>
> Protected guests are encrypted at rest and need a special boot
On 09.03.20 12:21, Janosch Frank wrote:
> Migration is not yet supported.
>
> Signed-off-by: Janosch Frank
> ---
> hw/s390x/s390-virtio-ccw.c | 26 --
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-cc
On 09.03.20 12:21, Janosch Frank wrote:
> Ballooning in protected VMs can only be done when the guest shares the
> pages it gives to the host. If pages are not shared, the integrity
> checks will fail once those pages have been altered and are given back
> to the guest.
>
> Hence, until we have a
On 09.03.20 14:32, Halil Pasic wrote:
> We expose loadparm as a r/w machine property, but if loadparm is set by
> the guest via DIAG 308, we don't update the property. Having a
> disconnect between the guest view and the QEMU property is not nice in
> itself, but things get even worse for SCSI, whe
On Sun, 8 Mar 2020 at 13:31, Michael S. Tsirkin wrote:
>
> The following changes since commit 67f17e23baca5dd545fe98b01169cc351a70fe35:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2020-03-06 17:15:36 +)
>
> are available in the Git repository at:
>
>
On 3/9/20 2:41 PM, David Hildenbrand wrote:
> On 09.03.20 12:21, Janosch Frank wrote:
>> Migration is not yet supported.
>>
>> Signed-off-by: Janosch Frank
>> ---
>> hw/s390x/s390-virtio-ccw.c | 26 --
>> 1 file changed, 24 insertions(+), 2 deletions(-)
>>
>> diff --git a/
On 3/9/20 2:42 PM, David Hildenbrand wrote:
> On 09.03.20 12:21, Janosch Frank wrote:
>> Ballooning in protected VMs can only be done when the guest shares the
>> pages it gives to the host. If pages are not shared, the integrity
>> checks will fail once those pages have been altered and are given
Hi Peter,
On 3/9/20 2:28 PM, Peter Maydell wrote:
> On Mon, 2 Mar 2020 at 10:55, Eric Auger wrote:
>>
>> Restructure the finalize_gic_version with switch cases and, in
>> KVM mode, explictly check whether the chosen version is supported
>> by the host.
>>
>> if the end-user explicitly sets v2/v3
On Dienstag, 21. Januar 2020 01:30:10 CET Christian Schoenebeck wrote:
> Make top half really top half and bottom half really bottom half:
>
> Each T_readdir request handling is hopping between threads (main
> I/O thread and background I/O driver threads) several times for
> every individual direc
On Tue, 03 Mar 2020 13:57:05 -0600
Babu Moger wrote:
> This is an effort to re-arrange few data structure for better readability.
>
> 1. Add X86CPUTopoInfo which will have all the topology informations
>required to build the cpu topology. There is no functional changes.
> 2. Introduce init_t
Pan Nengyuan writes:
> On 3/9/2020 8:34 PM, Markus Armbruster wrote:
>> Peter Maydell writes:
>>
>>> On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote:
On 3/9/2020 5:21 PM, Peter Maydell wrote:
> Could you explain more? My thought is that we should be using
> sysbus_init_child_obj()
On 09.03.20 14:51, Janosch Frank wrote:
> On 3/9/20 2:41 PM, David Hildenbrand wrote:
>> On 09.03.20 12:21, Janosch Frank wrote:
>>> Migration is not yet supported.
>>>
>>> Signed-off-by: Janosch Frank
>>> ---
>>> hw/s390x/s390-virtio-ccw.c | 26 --
>>> 1 file changed, 24
On Tue, 03 Mar 2020 13:57:18 -0600
Babu Moger wrote:
> Store the smp sockets in CpuTopology. The socket information required to
> build the apic id in EPYC mode. Right now socket information is not passed
> to down when decoding the apic id. Add the socket information here.
>
> Signed-off-by: B
On Tue, 03 Mar 2020 13:57:24 -0600
Babu Moger wrote:
> The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
> So, remove the initialization here.
>
> Suggested-by: Igor Mammedov
> Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
> ---
> hw/i386/x86.c |4
>
On Tue, 03 Mar 2020 13:57:30 -0600
Babu Moger wrote:
> Update structures X86CPUTopoIDs and CPUX86State to hold the number of
> nodes per package. This is required to build EPYC mode topology.
>
> Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
> ---
> hw/i386/pc.c |1
An ALTERNATIVE's value can only be a type name. Arrays are not
supported, yet. The text gets it right: "The form STRING is shorthand
for { 'type': STRING }." The grammar doesn't. Fix it.
Fixes: b6c37ebaaf074cac8fe8a4781dc3e79db23e914e
Reported-by: John Snow
Signed-off-by: Markus Armbruster
-
On Mon, 9 Mar 2020 14:44:20 +0100
David Hildenbrand wrote:
> On 09.03.20 14:32, Halil Pasic wrote:
> > We expose loadparm as a r/w machine property, but if loadparm is set by
> > the guest via DIAG 308, we don't update the property. Having a
> > disconnect between the guest view and the QEMU prop
On 3/9/20 12:21 PM, Janosch Frank wrote:
The unpack facility provides the means to setup a protected guest. A
protected guest can not be introspected by the hypervisor or any
user/administrator of the machine it is running on.
Protected guests are encrypted at rest and need a special boot
mec
On Tue, 03 Mar 2020 13:57:56 -0600
Babu Moger wrote:
> Introduce model specific apicid functions inside X86MachineState.
> These functions will be loaded from X86CPUDefinition.
>
> Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
> ---
> hw/i386/x86.c |5 +
> include/hw/
On 09.03.20 14:37, David Hildenbrand wrote:
>>
>> +#if !defined(CONFIG_USER_ONLY)
>> +static bool machine_is_pv(MachineState *ms)
>> +{
>> +Object *obj;
>> +
>> +/* we have to bail out for the "none" machine */
>> +obj = object_dynamic_cast(OBJECT(ms), TYPE_S390_CCW_MACHINE);
>> +
On 09.03.20 15:40, Christian Borntraeger wrote:
>
>
> On 09.03.20 14:37, David Hildenbrand wrote:
>
>>>
>>> +#if !defined(CONFIG_USER_ONLY)
>>> +static bool machine_is_pv(MachineState *ms)
>>> +{
>>> +Object *obj;
>>> +
>>> +/* we have to bail out for the "none" machine */
>>> +obj
This series fixes a bug where an user can load ROMs bigger
than the expected size. The bug is delayed after a reset where
rom_reset() can overflow the underlying memory regions.
Philippe Mathieu-Daudé (5):
hw/sparc64/niagara: Pass available memory region size to
add_rom_or_fail
hw/core/loa
We must not write more data than the memory region size.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/loader.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index d1b78f60cd..c67c483936 100644
--- a/hw/core/loader.c
+++ b/hw/core
In few commits we'll let rom_add_file_fixed() take a 'size'
argument holding the maximum file length that can be loaded
as ROM. In preparation, modify the Niagara machine, so the
generic change will be easier to review.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc64/niagara.c | 17
On 3/9/20 10:26 AM, Markus Armbruster wrote:
> An ALTERNATIVE's value can only be a type name. Arrays are not
> supported, yet. The text gets it right: "The form STRING is shorthand
> for { 'type': STRING }." The grammar doesn't. Fix it.
>
> Fixes: b6c37ebaaf074cac8fe8a4781dc3e79db23e914e
>
Use the ''max_size' argument recently added to rom_add_file() to
not load ROMs bigger than the underlying memory region.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/loader.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/loader.h b/include/hw/loader.h
ind
On 3/9/20 3:28 PM, Viktor Mihajlovski wrote:
>
>
> On 3/9/20 12:21 PM, Janosch Frank wrote:
>> The unpack facility provides the means to setup a protected guest. A
>> protected guest can not be introspected by the hypervisor or any
>> user/administrator of the machine it is running on.
>>
>> Prot
On 09.03.20 15:27, Halil Pasic wrote:
> On Mon, 9 Mar 2020 14:44:20 +0100
> David Hildenbrand wrote:
>
>> On 09.03.20 14:32, Halil Pasic wrote:
>>> We expose loadparm as a r/w machine property, but if loadparm is set by
>>> the guest via DIAG 308, we don't update the property. Having a
>>> discon
In commit d60fa42e8b we cared about loading ROMs smaller than
the underlying memory region (by zeroing the missing area) but
we forgot the case where a ROM file is bigger than the underlying
region.
Provide rom_add_file() a 'max_size' argument, and refuse loading
ROM files bigger than it.
Signed-o
On Tue, 03 Mar 2020 13:58:03 -0600
Babu Moger wrote:
> Load the model specific handlers if available or else default handlers
> will be loaded. Add the model specific handlers if apicid decoding
> differs from the standard sequential numbering.
>
this is still the old version of the patch and h
On Mon, 9 Mar 2020 at 14:45, Philippe Mathieu-Daudé wrote:
>
> We must not write more data than the memory region size.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/core/loader.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/loader.c b/hw/core/loade
Let rom_add_file_fixed() call rom_add_file() with a 'max_size'
argument, to avoid writing more than the available space for
the ROMs.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/loader.h | 4 ++--
hw/i386/x86.c| 2 +-
hw/ppc/sam460ex.c| 2 +-
hw/sparc64/niagara.c | 5 +++--
Changbin Du writes:
> hello, is this patch ready to merge now? Thanks!
>
> On Fri, Feb 21, 2020 at 08:25:59AM +0800, Changbin Du wrote:
>> Recently when debugging an arm32 system on qemu, I found sometimes the
>> single-step command (stepi) is not working. This can be reproduced by
>> below ste
Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
ram_size matches size of machine.memory-backend")
Signed-off-by: Marc-André Lureau
---
softmmu/vl.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 5549f4b619..38e9c404f2 100644
--- a/so
Patchew URL: https://patchew.org/QEMU/20200309142638.19988-1-arm...@redhat.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!
On Mon, 9 Mar 2020 15:49:22 +0100
Igor Mammedov wrote:
> On Tue, 03 Mar 2020 13:58:03 -0600
> Babu Moger wrote:
>
> > Load the model specific handlers if available or else default handlers
> > will be loaded. Add the model specific handlers if apicid decoding
> > differs from the standard seque
On Sun, Mar 8, 2020 at 3:33 PM Volker Rümelin wrote:
> The review for patch ed2a4a7941 "audio: proper support for
> float samples in mixeng" suggested this would be a good idea.
>
> Acked-by: Markus Armbruster
> Signed-off-by: Volker Rümelin
> ---
>
>
> Your patch applied cleanly to the late
On 3/7/20 11:22 AM, Unai Martinez-Corral wrote:
Spaces are added before '; then', for consistency.
For consistency with what? This is not our prevailing style; as
evidenced by this pre-patch search:
$ git grep 'if \[.*\];' | wc
2742186 18170
$ git grep 'if \[.*\] ;' | wc
25
On Tue, 03 Mar 2020 13:58:10 -0600
Babu Moger wrote:
> Check and Load the apicid handlers from X86CPUDefinition if available.
> Update the calling convention for the apicid handlers.
>
> Signed-off-by: Babu Moger
> ---
> hw/i386/pc.c |6 +++---
> hw/i386/x86.c | 11 +++
> 2 fi
On Tue, 03 Mar 2020 13:58:16 -0600
Babu Moger wrote:
> Add the new EPYC model specific handlers to fix the apicid decoding.
>
> The APIC ID is decoded based on the sequence sockets->dies->cores->threads.
> This works fine for most standard AMD and other vendors' configurations,
> but this decodi
On 3/8/20 8:06 AM, Yoshinori Sato wrote:
Add rx-virt target specificaion document.
specification
Signed-off-by: Yoshinori Sato
---
docs/system/target-rx.rst | 35 +++
docs/system/targets.rst | 1 +
2 files changed, 36 insertions(+)
create mode 100644
From: Philippe Mathieu-Daudé
Currently the print-variable rule can only be used in the
root directory:
$ make print-vhost-user-json-y
vhost-user-json-y= contrib/vhost-user-gpu/50-qemu-gpu.json
tools/virtiofsd/50-qemu-virtiofsd.json
$ make -C i386-softmmu print-obj-y
make: Entering dire
From: Philippe Mathieu-Daudé
vl.c calls machine_usb() declared in "hw/boards.h". Include it.
This fixes (when modifying unrelated headers):
vl.c:1283:10: error: implicit declaration of function 'machine_usb' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (!machine_usb(c
From: Philippe Mathieu-Daudé
Express the macreg[] arrays using typedefs.
No logical changes introduced here.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Paolo Bonzini
Reviewed-by: Dmitry Fleytman
Reviewed-by: Stefano Garzarella
Message-Id: <20200305010446.17029-2-phi...@redhat.com>
Signe
From: Philippe Mathieu-Daudé
Each array consumes 256KiB of .data. As we do not reassign entries,
we can move it to the .rodata section, and save a total of 1MiB of
.data (size reported on x86_64 host).
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Paolo Bonzini
Reviewed-by: Dmitry Fleytman
From: Philippe Mathieu-Daudé
alpha_sys.h does not use anything from the "hw/ide.h" header.
Remove it.
Acked-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200228114649.12818-8-phi...@redhat.com>
Signed-off-by: Laurent Vivier
---
hw/alpha/al
From: Philippe Mathieu-Daudé
intel_iommu.h does not use any of these includes, remove them.
Acked-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200228114649.12818-7-phi...@redhat.com>
Signed-off-by: Laurent Vivier
---
include/hw/i386/intel
From: Philippe Mathieu-Daudé
hw/pci-host/piix.c calls various functions from the Range API.
Include "qemu/range.h" which declares them.
This fixes (when modifying unrelated headers):
hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka
'struct Range')
Range pci_hol
The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2020-03-09 10:32:53 +)
are available in the Git repository at:
git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
for y
From: Eric Blake
We are converting more doc files to *.rst rather than *.texi. Most
doc files are already listed early in diffs due to our catchall
docs/*, but a few top-level files get missed by that glob.
Signed-off-by: Eric Blake
Reviewed-by: Stefano Garzarella
Message-Id: <20200220162214.
From: Philippe Mathieu-Daudé
The ICH9 chipset is not X86/PC specific.
These files don't use anything declared by the "hw/i386/pc.h"
or "hw/i386/ioapic.h" headers. Remove them.
Reviewed-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200228114
From: Philippe Mathieu-Daudé
Reviewed-by: Laurent Vivier
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefano Garzarella
Message-Id: <20200305124525.14555-2-phi...@redhat.com>
Signed-off-by: Laurent Vivier
---
hw/audio/fmopl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Philippe Mathieu-Daudé
hw/alpha/dp264.c uses NICInfo variables which are declared in
"net/net.h". Include it.
This fixes (when modifying unrelated headers):
hw/alpha/dp264.c:89:21: error: use of undeclared identifier 'nb_nics'
for (i = 0; i < nb_nics; i++) {
From: Philippe Mathieu-Daudé
Various headers are not required by hw/i386/pc.h:
- "qemu/range.h"
- "qemu/bitmap.h"
- "qemu/module.h"
- "exec/memory.h"
- "hw/pci/pci.h"
- "hw/mem/pc-dimm.h"
- "hw/mem/nvdimm.h"
- "net/net.h"
Remove them.
Add 3 headers that were missing:
- "hw/hotplug.h"
From: Philippe Mathieu-Daudé
The timer models don't need anything from "ui/console.h".
Remove it.
Acked-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200228114649.12818-5-phi...@redhat.com>
Signed-off-by: Laurent Vivier
---
hw/rtc/twl92230
From: Philippe Mathieu-Daudé
hw/i2c/smbus_ich9.c calls range_covers_byte(). Include "qemu/range.h"
which declares it.
This fixes (when modifying unrelated headers):
hw/i2c/smbus_ich9.c:66:9: error: implicit declaration of function
'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-fun
From: Philippe Mathieu-Daudé
hw/acpi/cpu_hotplug.c calls pci_address_space_io(). Include
"hw/pci/pci.h" which declares it.
This fixes (when modifying unrelated headers):
hw/acpi/cpu_hotplug.c:103:28: error: implicit declaration of function
'pci_address_space_io' is invalid in C99
[-Werror,-
From: Philippe Mathieu-Daudé
Only q35.c requires declarations from "hw/i386/pc.h", move it there.
Remove all the includes not used by "q35.h".
Acked-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200228114649.12818-18-phi...@redhat.com>
Signe
From: Philippe Mathieu-Daudé
The USB models related to storage don't need anything from
"ui/console.h". Remove it.
Acked-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Gerd Hoffmann
Reviewed-by: Richard Henderson
Message-Id: <20200228114649.12818-6-phi...@redhat.com>
Signed-of
From: Philippe Mathieu-Daudé
Reduce a bit the memory footprint by making the helper_opts[]
array const.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Greg Kurz
Acked-by: Paolo Bonzini
Reviewed-by: Stefano Garzarella
Message-Id: <20200305010446.17029-4-phi...@redhat.com>
Signed-off-by: Laur
From: Philippe Mathieu-Daudé
Both ich9.c and piix4.c use methods/definitions declared in the
NVDIMM device header. Include it.
This fixes (when modifying unrelated headers):
hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), T
From: Philippe Mathieu-Daudé
The MCHPCIState structure uses the Range type which is declared in
"qemu/range.h". Include it.
This fixes (when modifying unrelated headers):
In file included from hw/pci-host/q35.c:32:
include/hw/pci-host/q35.h:57:11: error: field has incomplete type 'Range'
(
201 - 300 of 548 matches
Mail list logo
