Re: qemu-system-x86_64: warning: Unknown X11 keycode mapping ''.

2020-03-02 Thread Thorsten Glaser
On Mon, 2 Mar 2020, Daniel P. Berrangé wrote: > "x11vnc" suggests you had a regular X11 desktop session, and are > exporting it via VNC ? No, x11vnc is a standalone VNC server. > Can you tell me a bit more detail about how you launch this all. Sure: $ vncserver -geometry 1000x768 -name nowm :2

[PATCH] icount: make dma reads deterministic

2020-03-02 Thread Pavel Dovgalyuk
Windows guest sometimes makes DMA requests with overlapping target addresses. This leads to the following structure of iov for the block driver: addr size1 addr size2 addr size3 It means that three adjacent disk blocks should be read into the same memory buffer. Windows does not expects anything

Re: [PULL 0/8] tcg patch queue

2020-03-02 Thread Peter Maydell
On Sat, 29 Feb 2020 at 02:43, Richard Henderson wrote: > > The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 > 16:39:27 +) > > are available in the Git re

Re: [PATCH v2 2/4] qcow2: rework the cluster compression routine

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
02.03.2020 11:21, Denis Plotnikov wrote: The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 77 +++---

Re: qemu-system-x86_64: warning: Unknown X11 keycode mapping ''.

2020-03-02 Thread Daniel P . Berrangé
On Mon, Mar 02, 2020 at 01:43:12PM +0100, Thorsten Glaser wrote: > On Mon, 2 Mar 2020, Daniel P. Berrangé wrote: > > > "x11vnc" suggests you had a regular X11 desktop session, and are > > exporting it via VNC ? > > No, x11vnc is a standalone VNC server. > > > Can you tell me a bit more detail ab

[PATCH v3 11/12] usb/hcd-ehci: Remove redundant statements

2020-03-02 Thread Chen Qun
The "again" assignment is meaningless before g_assert_not_reached. In addition, the break statements no longer needs to be after g_assert_not_reached. Clang static code analyzer show warning: hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read again = -1;

[PATCH v3 00/12] redundant code: Fix warnings reported by Clang static code analyzer

2020-03-02 Thread Chen Qun
v1->v2: - Patch1: Add John Snow review comment. - Patch9: Move the 'dst_type' declaration to while() statement. - Patch12: Add Philippe Mathieu-Daudé review comment. - Patch13: Move the 'set' declaration to the for() statement. v2->v3: - Patch1: Add Kevin Wolf review comment. - Patch2: Keep the 'f

[PATCH v3 05/12] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen = req->cmd.xfer; ^~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/scsi-disk.c | 1 - 1 file c

[PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: block/file-posix.c:891:9: warning: Value stored to 'op' is never read op = RAW_PL_ABORT; ^ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Kevin Wolf --- Cc: Kevin Wolf Cc: Max Reitz --- block/file-posix

[PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_open()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read flags &= ~BDRV_O_RDWR; ^ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Kevin Wo

[PATCH v3 01/12] block/stream: Remove redundant statement in stream_run()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: block/stream.c:186:9: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: John Snow Reviewed-by: Kevin Wolf --- Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz v1->v

[PATCH v3 10/12] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' i

[PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size = 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc:Fam Zheng --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-)

[PATCH v3 08/12] display/blizzard: Remove redundant statement in blizzard_draw_line16_32()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>= 5; ^~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell --- hw/display/blizzard.c | 1 - 1 file cha

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Philippe Mathieu-Daudé
On 3/2/20 1:30 PM, Laurent Vivier wrote: On 02/03/2020 12:19, Laurent Vivier wrote: On 02/03/2020 11:53, Michael S. Tsirkin wrote: On Mon, Mar 02, 2020 at 10:50:16AM +0100, Laurent Vivier wrote: On 01/03/2020 13:12, Michael S. Tsirkin wrote: On Fri, Feb 07, 2020 at 10:54:11AM +0100, Laurent V

[PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read format = 0; ^~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell --- hw/display/pxa2xx_lcd.c | 1 - 1 fil

[PATCH v3 00/12] redundant code: Fix warnings reported by Clang static code analyzer

2020-03-02 Thread Chen Qun
v1->v2: - Patch1: Add John Snow review comment. - Patch9: Move the 'dst_type' declaration to while() statement. - Patch12: Add Philippe Mathieu-Daudé review comment. - Patch13: Move the 'set' declaration to the for() statement. v2->v3: - Patch1: Add Kevin Wolf review comment. - Patch2: Keep the 'f

[PATCH v3 07/12] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is never read is_dirty = false; Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/display/exynos4210_fimd.c | 1 -

[PATCH v3 09/12] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3, ^ ~~~ Reported-by: Euler Rob

[PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()

2020-03-02 Thread Chen Qun
Clang static code analyzer show warning: monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read set = true; ^ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daudé --- Cc: "Dr. David Alan Gilbert" Cc: Phi

Re: [PATCH v3 0/6] delay timer_new from init to realize to fix memleaks.

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 02:35, Pan Nengyuan wrote: > > This series delay timer_new from init into realize to avoid memleaks when we > call 'device_list_properties'. > And do timer_free only in s390x_cpu_finalize because it's hotplugable. > However, It's not valid in mos6522 > if we move timer_new

Re: [PATCH v3 5/6] hw/misc/mos6522: move timer_new from init() into realize() to avoid memleaks

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 02:35, Pan Nengyuan wrote: > > There are some memleaks when we call 'device_list_properties'. This patch > move timer_new from init into realize to fix it. > Meanwhile, add calls to mos6522_realize() in mac_via_realize to make this > move to be valid. > > Reported-by: Eule

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Laurent Vivier
On 02/03/2020 14:12, Philippe Mathieu-Daudé wrote: > On 3/2/20 1:30 PM, Laurent Vivier wrote: >> On 02/03/2020 12:19, Laurent Vivier wrote: >>> On 02/03/2020 11:53, Michael S. Tsirkin wrote: On Mon, Mar 02, 2020 at 10:50:16AM +0100, Laurent Vivier wrote: > On 01/03/2020 13:12, Michael S. T

RE: RFC: Split EPT huge pages in advance of dirty logging

2020-03-02 Thread Zhoujian (jay)
> -Original Message- > From: Peter Feiner [mailto:pfei...@google.com] > Sent: Saturday, February 22, 2020 8:19 AM > To: Junaid Shahid > Cc: Ben Gardon ; Zhoujian (jay) > ; Peter Xu ; > k...@vger.kernel.org; qemu-devel@nongnu.org; pbonz...@redhat.com; > dgilb...@redhat.com; quint...@redha

Re: [PATCH v2 1/2] dp264: use pci_create() to initialise the cmd646 device

2020-03-02 Thread Philippe Mathieu-Daudé
On 3/1/20 10:34 PM, BALATON Zoltan wrote: On Sun, 1 Mar 2020, Mark Cave-Ayland wrote: Remove the call to pci_cmd646_ide_init() since global device init functions are deprecated in preference of using qdev directly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- hw/alpha/d

Re: [PATCH v0 0/2] allow to set 'drive' property on a realized block device

2020-03-02 Thread Kevin Wolf
Am 10.11.2019 um 20:03 hat Denis Plotnikov geschrieben: > This allows to replace the file on a block device and is useful > to workaround the cases (migration) when the VM image is placed on > some shared storage with exclusive file opening model but the image > should be open form more than one ap

Re: [PATCH v2] hw/smbios: add options for type 4 max-speed and current-speed

2020-03-02 Thread Igor Mammedov
On Mon, 2 Mar 2020 17:29:10 +0800 Heyi Guo wrote: > Common VM users sometimes care about CPU speed, so we add two new > options to allow VM vendors to present CPU speed to their users. > Normally these information can be fetched from host smbios. > > Strictly speaking, the "max speed" and "curre

Re: [PATCH v0 0/2] allow to set 'drive' property on a realized block device

2020-03-02 Thread Denis Plotnikov
On 02.03.2020 16:38, Kevin Wolf wrote: Am 10.11.2019 um 20:03 hat Denis Plotnikov geschrieben: This allows to replace the file on a block device and is useful to workaround the cases (migration) when the VM image is placed on some shared storage with exclusive file opening model but the image

Re: [PULL 00/23] Net patches

2020-03-02 Thread Peter Maydell
On Mon, 2 Mar 2020 at 07:40, Jason Wang wrote: > > The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 > 16:39:27 +) > > are available in the git repository

Re: [PATCH v3 05/33] qemu-doc: split qemu-doc.texi in multiple files

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > On Mon, 2 Mar 2020 at 11:22, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > From: Paolo Bonzini >> > >> > In order to facilitate the reorganization of qemu-doc.texi content, >> > as well as the conversion to rST/Sphinx, split it in multiple .texi >> > files

Re: [PATCH v3 09/12] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()

2020-03-02 Thread Edgar E. Iglesias
On Mon, 2 Mar. 2020, 07:09 Chen Qun, wrote: > Clang static code analyzer show warning: > hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never > read > dst_type = FIELD_EX32(s->dsc_dst.words[3], > ZDMA_CH_DST_DSCR_WORD3, > Reviewed-by: Edgar E. Iglesias

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster wrote: >> >> Kevin Wolf writes: >> >> > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: >> >> >> > void qmp_screendump(const char *filename, bool has_device, const >> >> >> > char *device, >> >> >>

Re: USB passthrough using qemu commandline method in libvirt

2020-03-02 Thread clement andrew
Updated Mail: Forgot to put in system information Hi I'm trying to do usb passthrough using qemu commandline method in libvirt as below by making changes , but VM failed to create the usb passthrough. While using just normal qemu command, it was passing just fine. sudo qemu-system-x86_64

Re: [Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration

2020-03-02 Thread Bharat Bhushan
Hi Eric, On Fri, Feb 28, 2020 at 3:06 PM Auger Eric wrote: > Hi Bharat, > > On 11/27/18 7:52 AM, Bharat Bhushan wrote: > > This patch series integrates VFIO with virtio-iommu. This is > > tested with assigning 2 pci devices to Virtual Machine. > > > > This version is mainly about rebasing on v9

USB passthrough using qemu commandline method in libvirt

2020-03-02 Thread clement andrew
Hi I'm trying to do usb passthrough using qemu commandline method in libvirt as below by making changes , but VM failed to create the usb passthrough. While using just normal qemu command, it was passing just fine. sudo qemu-system-x86_64 -enable-kvm -m 2G -cpu host -smp 2 -vga qxl -drive

Re: [PATCH v3 1/6] s390x: fix memleaks in cpu_finalize

2020-03-02 Thread Stefan Hajnoczi
On Thu, Feb 27, 2020 at 2:42 AM Pan Nengyuan wrote: > > This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The > leak stack is as follow: > > Direct leak of 48 byte(s) in 1 object(s) allocated from: > #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970

Re: [PATCH] linux-user: Add AT_EXECFN and AT_EXECFD auxval

2020-03-02 Thread Laurent Vivier
Le 21/02/2020 à 21:28, Lirong Yuan a écrit : > This change adds the support for AT_EXECFN and AT_EXECFD auxval. Why do we need AT_EXECFD? AT_EXECFD is normally only used with binfmt_misc so I don't see any use cases for it with QEMU. For AT_EXECFN, according to kernel commit 651910874633 exec

Re: [PULL 0/2] Vga 20200302 patches

2020-03-02 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20200302-pull-request > > for you to fetch changes up to 44b5c1ebfa5db337714180e9d4a8d525da5595d6: > > qxl: map rom r/o (2020-03-02 08:24:36 +0100) > > --

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode

2020-03-02 Thread Laurent Vivier
Le 29/02/2020 à 01:43, Lirong Yuan a écrit : > On Fri, Feb 21, 2020 at 5:09 PM Lirong Yuan wrote: >> >> This change allows us to set custom base address for guest programs. It is >> needed to allow qemu to work with Thread Sanitizer (TSan), which has >> specific boundary definitions for memory m

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-03-02 Thread David Hildenbrand
On 28.02.20 22:01, Peter Xu wrote: > On Fri, Feb 28, 2020 at 09:16:28PM +0100, David Hildenbrand wrote: >> > > [...] > @@ -631,7 +658,7 @@ int qemu_vfio_dma_map(QEMUVFIOState *s, void *host, size_t size, qemu_vfio_remove_mapping(s, mapping); go

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-02 Thread Auger Eric
Hi Peter, On 2/28/20 5:15 PM, Peter Xu wrote: > This is majorly only for X86 because that's the only one that supports > split irqchip for now. > > When the irqchip is split, we face a dilemma that KVM irqfd will be > enabled, however the slow irqchip is still running in the userspace. > It means

[PATCH] block/qcow2-threads: fix qcow2_decompress

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
On success path we return what inflate() returns instead of 0. And it most probably works for Z_STREAM_END as it is positive, but is definitely broken for Z_BUF_ERROR. While being here, switch to errno return code, to be closer to qcow2_compress API (and usual expectations). Revert condition in i

Re: [PATCH v2 0/5] vfio/pci: Fix up breakage against split irqchip and INTx

2020-03-02 Thread Auger Eric
Hi Peter, On 2/28/20 5:14 PM, Peter Xu wrote: > v2: > - pick tags > - don't register resamplefd with KVM kernel when the userspace > resamplefd path is enabled (should enable fast path on new kernels) > - fix resamplefd mem leak > - fix commit message of patch 4 [Eric] > - let kvm_resample_fd_no

Re: [PATCH v2 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip"

2020-03-02 Thread Auger Eric
Hi Peter, On 2/28/20 5:15 PM, Peter Xu wrote: > With the resamplefd list introduced, we can savely enable VFIO INTx > fast path again with split irqchip so it can still be faster than the > complete slow path. > > Signed-off-by: Peter Xu Reviewed-by: Eric Auger Thanks Eric > --- > hw/vfio/pc

Re: [PATCH v5 00/12] target/arm: Honor more HCR_EL2 traps

2020-03-02 Thread Peter Maydell
On Sat, 29 Feb 2020 at 01:28, Richard Henderson wrote: > > Changes for v5: > * Patch 1 was broken for aa32. Not just the masking vs the "other" > 32-bit register that Peter noticed, but more explicitly in that > "ri" was dereferenced as NULL -- hcr_write{high,low} did not pass > alo

Re: [PATCH v3 15/15] exec: Ram blocks with resizeable anonymous allocations under POSIX

2020-03-02 Thread David Hildenbrand
On 28.02.20 21:21, Peter Xu wrote: > On Thu, Feb 27, 2020 at 11:12:05AM +0100, David Hildenbrand wrote: > > [...] > >> +static void ram_block_alloc_ram(RAMBlock *rb) >> +{ >> +const bool shared = qemu_ram_is_shared(rb); >> + >> +/* >> + * If we can, try to allocate actually resizeable

Re: [RFC] QEMU Gating CI

2020-03-02 Thread Peter Maydell
On Sat, 8 Feb 2020 at 13:08, Peter Maydell wrote: > On Fri, 7 Feb 2020 at 20:39, Cleber Rosa wrote: > > On Fri, Feb 07, 2020 at 04:42:10PM +, Peter Maydell wrote: > > > This all sounds like the right thing and great progress. So yes, > > > I agree that the next step would be to get to a point

Re: [PATCH v5 00/50] Initial support for multi-process qemu

2020-03-02 Thread Jag Raman
On 3/1/2020 6:57 AM, Alex Bennée wrote: Jagannathan Raman writes: Hello Started with the presentation in October 2017 made by Marc-Andre (Red Hat) and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018, the multi-process project is now available and presented in th

Re: [PATCH v1 1/4] hw/arm/cubieboard: use ARM Cortex-A8 as the default CPU in machine definition

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank wrote: > > The Cubieboard is a singleboard computer with an Allwinner A10 System-on-Chip > [1]. > As documented in the Allwinner A10 User Manual V1.5 [2], the SoC has an ARM > Cortex-A8 processor. Currently the Cubieboard machine definition specifies

Re: [PATCH v1 2/4] hw/arm/cubieboard: restrict allowed CPU type to ARM Cortex-A8

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank wrote: > > The Cubieboard has an ARM Cortex-A8. Prevent changing the CPU > to a different type which could break user programs. > > Signed-off-by: Niek Linnenbank > --- > hw/arm/cubieboard.c | 10 +- > 1 file changed, 9 insertions(+), 1 delet

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-02 Thread Kevin Wolf
Am 02.03.2020 um 15:22 hat Markus Armbruster geschrieben: > Marc-André Lureau writes: > > > Hi > > > > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster wrote: > >> > >> Kevin Wolf writes: > >> > >> > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: > >> >> >> > void qmp_screendump(co

Re: [PATCH] scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]

2020-03-02 Thread Paolo Bonzini
On 28/02/20 16:00, Christophe de Dinechin wrote: > Compile error reported by gcc 10.0.1: > > scsi/qemu-pr-helper.c: In function ‘multipath_pr_out’: > scsi/qemu-pr-helper.c:523:32: error: array subscript is outside > array bounds of ‘struct transportid *[0]’ [-Werror=array-bounds] > 523 |

Re: [PATCH v0 0/2] allow to set 'drive' property on a realized block device

2020-03-02 Thread Kevin Wolf
Am 02.03.2020 um 14:55 hat Denis Plotnikov geschrieben: > > > On 02.03.2020 16:38, Kevin Wolf wrote: > > Am 10.11.2019 um 20:03 hat Denis Plotnikov geschrieben: > > > This allows to replace the file on a block device and is useful > > > to workaround the cases (migration) when the VM image is pla

Re: [PULL 012/136] arm/cubieboard: use memdev for RAM

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 11:59, Paolo Bonzini wrote: > > From: Igor Mammedov > > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing >

Re: [PATCH v1 3/4] hw/arm/cubieboard: restrict allowed RAM size to 512MiB and 1GiB

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 22:02, Niek Linnenbank wrote: > > The Cubieboard contains either 512MiB or 1GiB of onboard RAM [1]. > Prevent changing RAM to a different size which could break user programs. > > [1] http://linux-sunxi.org/Cubieboard > > Signed-off-by: Niek Linnenbank Reviewed-by: Peter

Re: [PATCH v1 4/4] hw/arm/cubieboard: report error when using unsupported -bios argument

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 22:02, Niek Linnenbank wrote: > > The Cubieboard machine does not support the -bios argument. > Report an error when -bios is used and exit immediately. > > Signed-off-by: Niek Linnenbank > --- > hw/arm/cubieboard.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff -

[PATCH v3 1/3] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Laurent Vivier
vhost-user-bridge is not a test. Move it to contrib/. It will be built with: make vhost-user-bridge Suggested-by: Dr. David Alan Gilbert Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Reviewed-by: Stefan Hajnoczi --- Notes: v3: don't add

[PATCH v3 3/3] travis: enable tools build on OS X

2020-03-02 Thread Laurent Vivier
As we can build tools on OS X we should check we don't break build when we submit new codes. Signed-off-by: Laurent Vivier --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 9867272177d4..70a24bf2fc8b 100644 --- a/.travis.yml +++ b/.travis.yml @@

[PATCH v3 2/3] virtiofsd: add it to the tools list

2020-03-02 Thread Laurent Vivier
it will be built only when tools are enabled (always enabled by default) Signed-off-by: Laurent Vivier Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Reviewed-by: Stefan Hajnoczi --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Ma

Re: [PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank wrote: > > These patches change the Cubieboard machine definition to use the > correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9. > > Additionally, add some sanity checks for the machine input > arguments in the initialization function.

Re: [PATCH] icount: make dma reads deterministic

2020-03-02 Thread Kevin Wolf
Am 02.03.2020 um 13:59 hat Pavel Dovgalyuk geschrieben: > Windows guest sometimes makes DMA requests with overlapping > target addresses. This leads to the following structure of iov for > the block driver: > > addr size1 > addr size2 > addr size3 > > It means that three adjacent disk blocks shou

Re: [PATCH 2/8] target/arm: Optimize cpu_mmu_index

2020-03-02 Thread Richard Henderson
On 3/2/20 4:03 AM, Peter Maydell wrote: > On Tue, 25 Feb 2020 at 03:14, Richard Henderson > wrote: >> >> We now cache the core mmu_idx in env->hflags. Rather than recompute >> from scratch, extract the field. All of the uses of cpu_mmu_index >> within target/arm are within helpers where env->hfl

Re: RFC: Split EPT huge pages in advance of dirty logging

2020-03-02 Thread Peter Feiner
On Mon, Mar 2, 2020, 5:38 AM Zhoujian (jay) wrote: > > > > -Original Message- > > From: Peter Feiner [mailto:pfei...@google.com] > > Sent: Saturday, February 22, 2020 8:19 AM > > To: Junaid Shahid > > Cc: Ben Gardon ; Zhoujian (jay) > > ; Peter Xu ; > > k...@vger.kernel.org; qemu-devel@n

Re: [PATCH v5 00/50] Initial support for multi-process qemu

2020-03-02 Thread Alex Bennée
Jag Raman writes: > On 3/1/2020 6:57 AM, Alex Bennée wrote: >> Jagannathan Raman writes: >> >>> Hello >>>Started with the presentation in October 2017 made by Marc-Andre >>> (Red Hat) >>> and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018, >>> the multi-process pro

Re: [PATCH] memory: Fix start offset for bitmap log_clear hook

2020-03-02 Thread Paolo Bonzini
On 25/02/20 21:46, Matt Borgerson wrote: > [ ping ] > > Hi Paolo, would you mind taking a quick look at this patch for > memory.c to consider > it for merge? This resolves an issue with dirty bits not being cleared > as expected. > > Here's the Patchwork link: http://patchwork.ozlabs.org/patch/12

Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

2020-03-02 Thread Alex Bennée
Robert Foley writes: > This is version 2 of the patch series to > add support for aarch64 VMs. > - Ubuntu 18.04 aarch64 VM > - CentOS 8 aarch64 VM > > V1: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg01180.html > > Changes in version 2 > - Most changes relate to the patch: "Add

Re: [PATCH v5 00/50] Initial support for multi-process qemu

2020-03-02 Thread Jag Raman
On 3/2/2020 11:29 AM, Alex Bennée wrote: Jag Raman writes: On 3/1/2020 6:57 AM, Alex Bennée wrote: Jagannathan Raman writes: Hello Started with the presentation in October 2017 made by Marc-Andre (Red Hat) and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018,

Re: [PULL 012/136] arm/cubieboard: use memdev for RAM

2020-03-02 Thread Igor Mammedov
On Mon, 2 Mar 2020 15:41:13 + Peter Maydell wrote: > On Tue, 25 Feb 2020 at 11:59, Paolo Bonzini wrote: > > > > From: Igor Mammedov > > > > memory_region_allocate_system_memory() API is going away, so > > replace it with memdev allocated MemoryRegion. The later is > > initialized by generic

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-03-02 Thread Richard Henderson
On 3/2/20 3:42 AM, BALATON Zoltan wrote: >> The "hardfloat" option works (with other targets) only with ieee745 >> accumulative exceptions, when the most common of those exceptions, inexact, >> has >> already been raised.  And thus need not be raised a second time. > > Why exactly it's done that

Re: [PATCH v3 2/6] hw/arm/virt: Introduce VirtGICType enum type

2020-03-02 Thread Richard Henderson
On 3/2/20 2:55 AM, Eric Auger wrote: > We plan to introduce yet another value for the gic version (nosel). > As we already use exotic values such as 0 and -1, let's introduce > a dedicated enum type and let vms->gic_version take this > type. > > Signed-off-by: Eric Auger > > --- > > v2 -> v3: >

Re: [PATCH v4 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2020-03-02 Thread Kamil Rytarowski
Ping? On 24.02.2020 16:17, Kamil Rytarowski wrote: > Ping? > > On 17.02.2020 10:07, Kamil Rytarowski wrote: >> Ping? >> >> On 06.02.2020 22:32, Kamil Rytarowski wrote: >>> Hello QEMU Community! >>> >>> Over the past year the NetBSD team has been working hard on a new user-mode >>> API >>> for our

Re: [PATCH] block/qcow2-threads: fix qcow2_decompress

2020-03-02 Thread Alberto Garcia
On Mon 02 Mar 2020 04:09:30 PM CET, Vladimir Sementsov-Ogievskiy wrote: > On success path we return what inflate() returns instead of 0. And it > most probably works for Z_STREAM_END as it is positive, but is > definitely broken for Z_BUF_ERROR. > > While being here, switch to errno return code, to

Re: [PATCH v4 09/16] target/i386: Cleanup and use the EPYC mode topology functions

2020-03-02 Thread Babu Moger
On 2/25/20 1:49 AM, Igor Mammedov wrote: > On Mon, 24 Feb 2020 11:29:37 -0600 > Babu Moger wrote: > >> On 2/24/20 2:52 AM, Igor Mammedov wrote: >>> On Thu, 13 Feb 2020 12:17:25 -0600 >>> Babu Moger wrote: >>> Use the new functions from topology.h and delete the unused code. Given the

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-03-02 Thread Alex Bennée
BALATON Zoltan writes: > On Sun, 1 Mar 2020, Richard Henderson wrote: >> On 3/1/20 4:13 PM, Programmingkid wrote: >>> Ok, I was just looking at Intel's x87 chip documentation. It >>> supports IEEE 754 floating point operations and exception flags. >>> This leads me to this question. Would simpl

Re: [PATCH v4 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2020-03-02 Thread Eduardo Habkost
Hi Kamil, Maxime, I haven't managed to reserve time to review this, sorry for that. I hope others can chime in before I do. Would any of you be willing to be included as maintainer of the new code on MAINTAINERS? On Mon, Mar 02, 2020 at 06:02:18PM +0100, Kamil Rytarowski wrote: > Ping? > > On

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

2020-03-02 Thread Paolo Bonzini
On 03/02/20 12:41, Philippe Mathieu-Daudé wrote: > > Maybe you can add something like: > > if test "$targetos" = "NetBSD"; then >     nvmm="check" > fi You could do just nvmm="" and, below, if test "$nvmm" != "no" && test "$targetos" = "NetBSD" But maybe even testing NetBSD is not needed since

Re: [PATCH v4 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2020-03-02 Thread Kamil Rytarowski
On 02.03.2020 18:10, Eduardo Habkost wrote: > Hi Kamil, Maxime, > > I haven't managed to reserve time to review this, sorry for that. > I hope others can chime in before I do. > > Would any of you be willing to be included as maintainer of the > new code on MAINTAINERS? > I'm already mentioned as

Re: [PULL 012/136] arm/cubieboard: use memdev for RAM

2020-03-02 Thread Peter Maydell
On Mon, 2 Mar 2020 at 16:55, Igor Mammedov wrote: > > On Mon, 2 Mar 2020 15:41:13 + > Peter Maydell wrote: > > Hi Igor, I just noticed this, and I don't think it's the > > right thing. The board model should have its own state > > structure which contains any objects it creates. Just > > beca

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

2020-03-02 Thread Paolo Bonzini
On 03/02/20 12:56, Kamil Rytarowski wrote: > On 03.02.2020 12:41, Philippe Mathieu-Daudé wrote: >>> @@ -1768,6 +1785,7 @@ disabled with --disable-FEATURE, default is >>> enabled if available: >>>     hax HAX acceleration support >>>     hvf Hypervisor.framework acceleration

Re: [PATCH v3 2/4] target/i386: Remove monitor from some CPU models

2020-03-02 Thread Eduardo Habkost
On Mon, Mar 02, 2020 at 07:47:28PM +0800, Tao Xu wrote: > On 2/29/2020 5:39 AM, Eduardo Habkost wrote: > > On Wed, Feb 12, 2020 at 04:13:26PM +0800, Tao Xu wrote: > > > Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana > > > CPU model to uremove MONITOR/MWAIT featre. > > > > >

Re: [PATCH v3 3/3] travis: enable tools build on OS X

2020-03-02 Thread Alex Bennée
Laurent Vivier writes: > As we can build tools on OS X we should check we don't break build > when we submit new codes. I agree, snarfed this patch into testing/next, thanks. > > Signed-off-by: Laurent Vivier > --- > .travis.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.trav

CPU reset vs DeviceState reset

2020-03-02 Thread Peter Maydell
Hi; I've just noticed that although TYPE_CPU is a subclass of TYPE_DEVICE, it seems to implement its own reset method ('reset' field in CPUClass struct) rather than just using the DeviceClass's 'reset'. Is there a reason for doing this, or is it just historical legacy from TYPE_CPU originally not

Re: [PATCH v4 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2020-03-02 Thread Eduardo Habkost
On Mon, Mar 02, 2020 at 06:10:50PM +0100, Kamil Rytarowski wrote: > On 02.03.2020 18:10, Eduardo Habkost wrote: > > Hi Kamil, Maxime, > > > > I haven't managed to reserve time to review this, sorry for that. > > I hope others can chime in before I do. > > > > Would any of you be willing to be inclu

Re: CPU reset vs DeviceState reset

2020-03-02 Thread Peter Maydell
Doh, I meant to cc Eduardo and Marcel but forgot... On Mon, 2 Mar 2020 at 17:20, Peter Maydell wrote: > > Hi; I've just noticed that although TYPE_CPU is a subclass of > TYPE_DEVICE, it seems to implement its own reset method > ('reset' field in CPUClass struct) rather than just using the > Devic

Re: New Hardware model emulation

2020-03-02 Thread Stefan Hajnoczi
On Mon, Feb 24, 2020 at 05:27:44PM +0530, Priyamvad Acharya wrote: > I have created a virtual device in Qemu. > Now I want to run Qemu with the virtual device,so how to do it ? Hi, It's unclear what you mean. Please provide a bit more background on what you are trying to accomplish. For example,

Re: [PATCH v5 14/50] mutli-process: build remote command line args

2020-03-02 Thread Philippe Mathieu-Daudé
typo "multi" in patch subject. On 2/24/20 9:55 PM, Jagannathan Raman wrote: From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- v4 -> v5: - Added "exec" suboption to get the executable's name - Addressed feedback ab

Re: CPU reset vs DeviceState reset

2020-03-02 Thread Eduardo Habkost
My impression is that this is just historical legacy, but I'm not sure how much work a conversion to the new system would require. I see lots of cpu_reset() calls scattered around the code. To make it worse, TYPE_CPU do have a DeviceClass::reset method implemented, but cpu_reset() won't call it be

Re: [PATCH v5 14/50] mutli-process: build remote command line args

2020-03-02 Thread Daniel P . Berrangé
On Mon, Mar 02, 2020 at 06:36:13PM +0100, Philippe Mathieu-Daudé wrote: > typo "multi" in patch subject. > > On 2/24/20 9:55 PM, Jagannathan Raman wrote: > > From: Elena Ufimtseva > > > > Signed-off-by: Elena Ufimtseva > > Signed-off-by: Jagannathan Raman > > Signed-off-by: John G Johnson > >

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode

2020-03-02 Thread Lirong Yuan
On Mon, Mar 2, 2020 at 6:56 AM Laurent Vivier wrote: > > Le 29/02/2020 à 01:43, Lirong Yuan a écrit : > > On Fri, Feb 21, 2020 at 5:09 PM Lirong Yuan wrote: > >> > >> This change allows us to set custom base address for guest programs. It is > >> needed to allow qemu to work with Thread Sanitize

Re: [PATCH v1 1/4] hw/arm/cubieboard: use ARM Cortex-A8 as the default CPU in machine definition

2020-03-02 Thread Philippe Mathieu-Daudé
On 3/2/20 4:32 PM, Peter Maydell wrote: On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank wrote: The Cubieboard is a singleboard computer with an Allwinner A10 System-on-Chip [1]. As documented in the Allwinner A10 User Manual V1.5 [2], the SoC has an ARM Cortex-A8 processor. Currently the Cubieb

[PATCH v2 4/9] target/arm: Apply TBI to ESR_ELx in helper_exception_return

2020-03-02 Thread Richard Henderson
We missed this case within AArch64.ExceptionReturn. Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c index 509ae93069..123ce50e7a 100644 --- a

[PATCH v2 0/9] target/arm: Misc cleanups surrounding TBI

2020-03-02 Thread Richard Henderson
Changes for v2: * Improve commit message in "Optimize cpu_mmu_index". * Add "Introduce core_to_aa64_mmu_idx". * Use it in "Apply TBI to ESR_ELx in helper_exception_return". Blurb for v1: We have a bug at present wherein we do not supply the memory tag to the memory system, so that on fault

[PATCH v2 6/9] target/arm: Use DEF_HELPER_FLAGS for helper_dc_zva

2020-03-02 Thread Richard Henderson
The function does not write registers, and only reads them by implication via the exception path. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper-a64.h b/target/arm/help

[PATCH v2 5/9] target/arm: Move helper_dc_zva to helper-a64.c

2020-03-02 Thread Richard Henderson
This is an aarch64-only function. Move it out of the shared file. This patch is code movement only. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h | 1 + target/arm/helper.h | 1 - target/arm/helper-a64.c | 91 +

[PATCH v2 9/9] target/arm: Disable clean_data_tbi for system mode

2020-03-02 Thread Richard Henderson
We must include the tag in the FAR_ELx register when raising an addressing exception. Which means that we should not clear out the tag during translation. We cannot at present comply with this for user mode, so we retain the clean_data_tbi function for the moment, though it no longer does what it

[PATCH v2 1/9] target/arm: Replicate TBI/TBID bits for single range regimes

2020-03-02 Thread Richard Henderson
Replicate the single TBI bit from TCR_EL2 and TCR_EL3 so that we can unconditionally use pointer bit 55 to index into our composite TBI1:TBI0 field. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d

[PATCH v2 8/9] target/arm: Check addresses for disabled regimes

2020-03-02 Thread Richard Henderson
We fail to validate the upper bits of a virtual address on a translation disabled regime, as per AArch64.TranslateAddressS1Off. Signed-off-by: Richard Henderson --- target/arm/helper.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/target/ar

[PATCH v2 2/9] target/arm: Optimize cpu_mmu_index

2020-03-02 Thread Richard Henderson
We now cache the core mmu_idx in env->hflags. Rather than recompute from scratch, extract the field. All of the uses of cpu_mmu_index within target/arm are within helpers, and env->hflags is always stable within a translation block from whence helpers are called. Signed-off-by: Richard Henderson

[PATCH v2 3/9] target/arm: Introduce core_to_aa64_mmu_idx

2020-03-02 Thread Richard Henderson
If by context we know that we're in AArch64 mode, we need not test for M-profile when reconstructing the full ARMMMUIdx. Signed-off-by: Richard Henderson --- target/arm/internals.h | 6 ++ target/arm/translate-a64.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ta

[PATCH v2 7/9] target/arm: Clean address for DC ZVA

2020-03-02 Thread Richard Henderson
This data access was forgotten when we added support for cleaning addresses of TBI information. Fixes: 3a471103ac1823ba Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/trans

<    1   2   3   4   >