On 3/2/20 4:03 AM, Peter Maydell wrote: > On Tue, 25 Feb 2020 at 03:14, Richard Henderson > <richard.hender...@linaro.org> wrote: >> >> We now cache the core mmu_idx in env->hflags. Rather than recompute >> from scratch, extract the field. All of the uses of cpu_mmu_index >> within target/arm are within helpers where env->hflags is stable. > > Do you mean "within helpers, and env->hflags is always stable in > a helper", or "within helpers, and env->hflags is stable for the > particular set of helpers where we use cpu_mmu_index, though it might > not be in other helpers" ?
The former. With the caveat that it's pretty clear when a helper is doing things that make it the exception to that rule. E.g. helper_exception_return, which itself invokes rebuild_hflags. r~
