Re: [PULL 06/15] configure: Enable test and libs for zstd

2020-03-02 Thread Juan Quintela
Richard Henderson wrote: >> +## >> +# zstd check >> + >> +if test "$zstd" != "no" ; then >> +if $pkg_config --exist libzstd ; then > > The option is spelled --exists. This is generating an error during configure. Ooops, you are right. Sending a patch.

Re: [PATCH v3] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-02 Thread Paolo Bonzini
On 02/03/20 02:58, Julio Faracco wrote: > Sorry my ignorance, Paolo. > But why should I remove MAX_{VM,VCPU}_ID? > > Did you mean that check? > if (vm_id > MAX_VM_ID || vcpu_id > MAX_VCPU_ID) { > fprintf(stderr, "Too big vm id %x or vcpu id %x\n", vm_id, vcpu_id); > return NULL

Re: [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy IRQ routing

2020-03-02 Thread Markus Armbruster
BALATON Zoltan writes: > On Sun, 1 Mar 2020, Mark Cave-Ayland wrote: >> On 29/02/2020 23:02, BALATON Zoltan wrote: >>> We'll need a flag for implementing some device specific behaviour in >>> via-ide but we already have a currently CMD646 specific field that can >>> be repurposed for this and lea

Re: [PATCH] hw/smbios: add options for type 4 max_speed and current_speed

2020-03-02 Thread Igor Mammedov
On Sat, 29 Feb 2020 08:17:48 +0800 Heyi Guo wrote: > Hi Igor, > > On 2020/2/28 17:39, Igor Mammedov wrote: > > On Thu, 27 Feb 2020 17:12:21 +0800 > > Heyi Guo wrote: > > > >> On 2020/2/25 17:24, Philippe Mathieu-Daudé wrote: > >>> On 2/25/20 8:50 AM, Heyi Guo wrote: > Common VM users

[PATCH v2 3/4] qcow2: add zstd cluster compression

2020-03-02 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

[PATCH v2 0/4] qcow2: Implement zstd cluster compression method

2020-03-02 Thread Denis Plotnikov
v2: * rework compression type setting [Vladimir] * squash iotest changes to the compression type introduction patch [Vladimir, Eric] * fix zstd availability checking in zstd iotest [Vladimir] * remove unnecessry casting [Eric] * remove rudundant checks [Eric] * fix compressed cluster l

[PATCH v2 2/4] qcow2: rework the cluster compression routine

2020-03-02 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 77 +++ 1 file changed, 63 insertions(+), 14 dele

[PATCH v2 4/4] iotests: 287: add qcow2 compression type test

2020-03-02 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov --- tests/qemu-iotests/287 | 127 + tests/qemu-iotests/287.out | 43 + tests/qemu-iotests/gro

[PATCH v2 1/4] qcow2: introduce compression type feature

2020-03-02 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c

Re: [PULL 06/15] configure: Enable test and libs for zstd

2020-03-02 Thread Alex Bennée
Juan Quintela writes: > Richard Henderson wrote: >>> +## >>> +# zstd check >>> + >>> +if test "$zstd" != "no" ; then >>> +if $pkg_config --exist libzstd ; then >> >> The option is spelled --exists. This is generating an error during >> configure. >

Re: [PATCH] hw/smbios: add options for type 4 max_speed and current_speed

2020-03-02 Thread Heyi Guo
On 2020/3/2 16:20, Igor Mammedov wrote: On Sat, 29 Feb 2020 08:17:48 +0800 Heyi Guo wrote: Hi Igor, On 2020/2/28 17:39, Igor Mammedov wrote: On Thu, 27 Feb 2020 17:12:21 +0800 Heyi Guo wrote: On 2020/2/25 17:24, Philippe Mathieu-Daudé wrote: On 2/25/20 8:50 AM, Heyi Guo wrote: Commo

Re: [PATCH v2 0/4] qcow2: Implement zstd cluster compression method

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
Doesn't apply to master, as zstd already exists in ./configure :) (for migration) 02.03.2020 11:21, Denis Plotnikov wrote: v2: * rework compression type setting [Vladimir] * squash iotest changes to the compression type introduction patch [Vladimir, Eric] * fix zstd availability chec

Re: [PATCH v2 0/4] qcow2: Implement zstd cluster compression method

2020-03-02 Thread Denis Plotnikov
On 02.03.2020 11:51, Vladimir Sementsov-Ogievskiy wrote: Doesn't apply to master, as zstd already exists in ./configure :) (for migration) M, will rebase it. Any other comments? 02.03.2020 11:21, Denis Plotnikov wrote: v2:    * rework compression type setting [Vladimir]    * squash io

[PULL 0/2] Vga 20200302 patches

2020-03-02 Thread Gerd Hoffmann
The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 16:39:27 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-202

[PULL 1/2] Arithmetic error in EDID generation fixed

2020-03-02 Thread Gerd Hoffmann
From: "Anton V. Boyarshinov" To calculate screen size in centimeters we should calculate: pixels/dpi*2.54 but not pixels*dpi/2540 Using wrong formula we actually get 65 DPI and very small fonts. Signed-off-by: Anton V. Boyarshinov Message-id: 20200226122054.366b9cda@table.localdomain Signed-of

[PULL 2/2] qxl: map rom r/o

2020-03-02 Thread Gerd Hoffmann
Map qxl rom read-only into the guest, so the guest can't tamper with the content. qxl has a shadow copy of the rom to deal with that, but the shadow doesn't cover the mode list. A privilidged user in the guest can manipulate the mode list and that to trick qemu into oob reads, leading to a DoS vi

[PATCH v2] hw/smbios: add options for type 4 max-speed and current-speed

2020-03-02 Thread Heyi Guo
Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors to present CPU speed to their users. Normally these information can be fetched from host smbios. Strictly speaking, the "max speed" and "current speed" in type 4 are not really for the max speed and curre

[PATCH 1/3] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-03-02 Thread Sai Pavan Boddu
This patch starts making the hcd-xhci.c pci free, as part of this restructuring dma read/writes are handled without passing pci object. Signed-off-by: Sai Pavan Boddu --- hw/usb/hcd-xhci.c | 23 ++- hw/usb/hcd-xhci.h | 3 +++ 2 files changed, 13 insertions(+), 13 deletions(-

[PATCH 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-03-02 Thread Sai Pavan Boddu
This patch sets the base to use xhci as sysbus model, for which pci specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment msi/msix interrupts handling is moved under XHCIPCIState. Made required changes for qemu-xhci-nec. Signed-off-by: Sai Pavan Boddu --- hw/usb/Kconfig

[PATCH 0/3] Make hcd-xhci independent of pci hooks

2020-03-02 Thread Sai Pavan Boddu
Hi, This patch series attempts to make 'hcd-xhci' an independent model so it can be used by both pci and system-bus interface. Regards, Sai Pavan Sai Pavan Boddu (3): usb/hcd-xhci: Make dma read/writes hooks pci free usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c usb/hcd-xhci: Split

[PATCH 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

2020-03-02 Thread Sai Pavan Boddu
Move pci specific devices to new file. This set the environment to move all pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. Signed-off-by: Sai Pavan Boddu --- hw/usb/hcd-xhci-pci.c | 64 +++ hw/usb/hcd-xhci.c | 40 ++

Re: [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display

2020-03-02 Thread Philippe Mathieu-Daudé
On 2/29/20 10:31 AM, Sven Schnelle wrote: On Tue, Feb 18, 2020 at 11:39:24AM -0800, Richard Henderson wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200214001303.12873-5-f4...@amsat.org> Signed-off-by: Richard Henderson --- hw/display/artist.c | 3

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Laurent Vivier
On 01/03/2020 13:12, Michael S. Tsirkin wrote: > On Fri, Feb 07, 2020 at 10:54:11AM +0100, Laurent Vivier wrote: >> vhost-user-bridge is not a test. Move it to contrib/ and >> add it to the tools list. >> >> It will be built only if tools (--enable-tools) and >> vhost-user (--enable-vhost-user) are

[PATCH 5/5] block/io: auto-no-fallback for write-zeroes

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
NBD driver may has max_pwrite_zeroes but doesn't has max_pwrite_zeroes_no_fallback limit. This means, that (when BDRV_REQ_NO_FALLBACK is supported) it is beneficial to try send request with BDRV_REQ_NO_FALLBACK instead of splitting the request accordingly to max_pwrite_zeroes. If failed, fallback

[PATCH 2/5] block/nbd-client: drop max_block restriction from discard

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
NBD spec is updated, so that max_block doesn't relate to NBD_CMD_TRIM. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/nbd.c b/block/nbd.c index 2a58d6b91c..a62761ea5a 100644 --- a/block/nbd.c +++ b/bl

[PATCH 3/5] block: add max_pwrite_zeroes_no_fallback to BlockLimits

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
NBD spec is updated, so that max_block doesn't relate to NBD_CMD_WRITE_ZEROES with NBD_CMD_FLAG_FAST_ZERO (which mirrors Qemu flag BDRV_REQ_NO_FALLBACK). To drop the restriction we need new max_pwrite_zeroes_no_fallback. Default value of new max_pwrite_zeroes_no_fallback is zero and it means no-re

[PATCH 1/5] block/nbd-client: drop max_block restriction from block_status

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
NBD spec is updated, so that max_block doesn't relate to NBD_CMD_BLOCK_STATUS. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 976be76647..2a58d6b91c 10064

[PATCH 0/5] nbd: reduce max_block restrictions

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
Recent changes in NBD protocol allowed to use some commands without max_block restriction. Let's drop restrictions. NBD change is here: https://github.com/NetworkBlockDevice/nbd/commit/9f30fedb8699f151e7ef4ccc07e624330be3316b#diff-762fb7c670348da69cc9050ef58fe3ae Vladimir Sementsov-Ogievskiy (5):

[PATCH 4/5] block/io: fix bdrv_co_do_pwrite_zeroes head calculation

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
It's wrong to update head using num in this place, as num may be reduced during the iteration, and we'll have wrong head value on next iteration. Instead update head at iteration end. Cc: qemu-sta...@nongnu.org Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 4 +++- 1 file changed,

Re: [PATCH v3 0/4] misc: Improve error reporting on Windows

2020-03-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Few patches to improve bug reports on Windows. > (i.e. https://bugs.launchpad.net/qemu/+bug/1657841) Queued, thanks!

Re: qemu-system-x86_64: warning: Unknown X11 keycode mapping ''.

2020-03-02 Thread Daniel P . Berrangé
On Mon, Mar 02, 2020 at 12:04:46AM +0100, Thorsten Glaser wrote: > I got this while running qemu under VNC, and was told to report it. > > including the following information: > > - Operating system > Debian GNU/Linux sid/x32 > - X11 Server > x11vnc 0.9.16-3 Can you tell me a bi

Re: [PATCH] vhost-vsock: fix error message output

2020-03-02 Thread Ján Tomko
On a Sunday in 2020, Nick Erdmann wrote: error_setg_errno takes a positive error number, so we should not invert errno's sign. Signed-off-by: Nick Erdmann --- hw/virtio/vhost-vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Descriptio

Re: [PULL 0/4] Machine queue, 2020-02-28

2020-03-02 Thread Peter Maydell
On Fri, 28 Feb 2020 at 21:04, Eduardo Habkost wrote: > > The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 > 16:39:27 +) > > are available in the Git repo

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2020 at 10:50:16AM +0100, Laurent Vivier wrote: > On 01/03/2020 13:12, Michael S. Tsirkin wrote: > > On Fri, Feb 07, 2020 at 10:54:11AM +0100, Laurent Vivier wrote: > >> vhost-user-bridge is not a test. Move it to contrib/ and > >> add it to the tools list. > >> > >> It will be buil

[PATCH v3 2/6] hw/arm/virt: Introduce VirtGICType enum type

2020-03-02 Thread Eric Auger
We plan to introduce yet another value for the gic version (nosel). As we already use exotic values such as 0 and -1, let's introduce a dedicated enum type and let vms->gic_version take this type. Signed-off-by: Eric Auger --- v2 -> v3: - replaced defines by enum VirtGICType - use that new type

[PATCH v3 0/6] hw/arm/virt: kvm: allow gicv3 by default if v2 cannot work

2020-03-02 Thread Eric Auger
At the moment if the end-user does not specify the gic-version along with KVM acceleration, v2 is set by default. However most of the systems now have GICv3 and sometimes they do not support GICv2 compatibility. In that case we now end up with the following error: "qemu-system-aarch64: Initializat

Re: [PATCH] block: make BlockConf.*_size properties 32-bit

2020-03-02 Thread Roman Kagan
On Thu, Feb 13, 2020 at 04:55:44PM +0300, Roman Kagan wrote: > On Thu, Feb 13, 2020 at 06:47:10AM -0600, Eric Blake wrote: > > On 2/13/20 2:01 AM, Roman Kagan wrote: > > > On Wed, Feb 12, 2020 at 03:44:19PM -0600, Eric Blake wrote: > > > > On 2/11/20 5:54 AM, Roman Kagan wrote: > > > > > Devices (v

[PATCH v3 1/6] hw/arm/virt: Document 'max' value in gic-version property description

2020-03-02 Thread Eric Auger
Mention 'max' value in the gic-version property description. Signed-off-by: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Andrew Jones --- hw/arm/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 856808599d..c093f0ab85 100

[PATCH v3 3/6] hw/arm/virt: Introduce finalize_gic_version()

2020-03-02 Thread Eric Auger
Let's move the code which freezes which gic-version to be applied in a dedicated function. We also now set by default the VIRT_GIC_VERSION_NO_SET. This eventually turns into the legacy v2 choice in the finalize() function. Signed-off-by: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: And

[PATCH v3 4/6] target/arm/kvm: Let kvm_arm_vgic_probe() return a bitmap

2020-03-02 Thread Eric Auger
Convert kvm_arm_vgic_probe() so that it returns a bitmap of supported in-kernel emulation VGIC versions instead of the max version: at the moment values can be v2 and v3. This allows to expose the case where the host GICv3 also supports GICv2 emulation. This will be useful to choose the default ver

[PATCH v3 5/6] hw/arm/virt: kvm: Check the chosen gic version is supported by the host

2020-03-02 Thread Eric Auger
Restructure the finalize_gic_version with switch cases and, in KVM mode, explictly check whether the chosen version is supported by the host. if the end-user explicitly sets v2/v3 and this is not supported by the host, then the user gets an explicit error message. Signed-off-by: Eric Auger Revie

[PATCH v3 6/6] hw/arm/virt: kvm: allow gicv3 by default if v2 cannot work

2020-03-02 Thread Eric Auger
At the moment if the end-user does not specify the gic-version along with KVM acceleration, v2 is set by default. However most of the systems now have GICv3 and sometimes they do not support GICv2 compatibility. This patch keeps the default v2 selection in all cases except in the KVM accelerated m

Re: [PATCH] hw/arm/smmu-common: a fix to smmu_find_smmu_pcibus

2020-03-02 Thread Peter Maydell
On Wed, 26 Feb 2020 at 17:37, Philippe Mathieu-Daudé wrote: > > Hi Eric, > Patch is easy to review but code not. By inverting the if() statement I > find the code easier to review. > SMMUPciBus *smmu_find_smmu_pcibus(SMMUState *s, uint8_t bus_num) > { > SMMUPciBus *smmu_pci_bus = s->smmu_

Re: [PATCH v3 02/33] qemu-doc: remove target OS documentation

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > This section covers OSes up to Windows 2000, and as such it is mostly > obsolete. Zap it. > > Reviewed-by: Peter Maydell > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-3-pbonz...@redhat.com > Signed-off-by: Peter Maydell Re

Re: [PATCH v3 01/33] qemu-doc: convert user-mode emulation to a separate Sphinx manual

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > The final addition to the set of QEMU manuals is the user-mode emulation > manual, which right now is included in qemu-doc.texi. Extract it and > convert it to rST, so that qemu-doc.texi covers only full system emulation. > > Signed-off-by: Paol

Re: [PATCH v1 2/2] hw/arm: versal: Generate xlnx-versal-virt zdma FDT nodes

2020-03-02 Thread Luc Michel
On 2/27/20 4:44 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Generate xlnx-versal-virt zdma FDT nodes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > hw/arm/xlnx-versal-virt.c | 28 > 1 file changed, 28 insertions(+) > > di

Re: [PATCH v1 1/2] hw/arm: versal: Add support for the LPD ADMAs

2020-03-02 Thread Luc Michel
On 2/27/20 4:44 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add support for the Versal LPD ADMAs. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > hw/arm/xlnx-versal.c | 24 > include/hw/arm/xlnx-versal.h | 6 ++ > 2

Re: [PATCH v3 03/33] texi2pod: parse @include directives outside "@c man" blocks

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > This enables splitting the huge qemu-doc.texi file and keeping parallel > Texinfo and rST versions of the documentation. texi2pod is not going to > live much longer and hardly anyone cares about its upstream status, > so the temporary fork shoul

Re: [PATCH v3 04/33] qemu-doc: split CPU models doc between MIPS and x86 parts

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > The MIPS CPU models end up in the middle of the PC documentation. Move > them to a separate file so that they can be placed in the right section. > > The man page still includes both x86 and MIPS content. We really need to flesh that out one da

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Laurent Vivier
On 02/03/2020 11:53, Michael S. Tsirkin wrote: > On Mon, Mar 02, 2020 at 10:50:16AM +0100, Laurent Vivier wrote: >> On 01/03/2020 13:12, Michael S. Tsirkin wrote: >>> On Fri, Feb 07, 2020 at 10:54:11AM +0100, Laurent Vivier wrote: vhost-user-bridge is not a test. Move it to contrib/ and a

Re: [PATCH v3 2/6] hw/arm/virt: Introduce VirtGICType enum type

2020-03-02 Thread Philippe Mathieu-Daudé
On 3/2/20 11:55 AM, Eric Auger wrote: We plan to introduce yet another value for the gic version (nosel). As we already use exotic values such as 0 and -1, let's introduce a dedicated enum type and let vms->gic_version take this type. Signed-off-by: Eric Auger --- v2 -> v3: - replaced defines

Re: [PATCH v3 05/33] qemu-doc: split qemu-doc.texi in multiple files

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > In order to facilitate the reorganization of qemu-doc.texi content, > as well as the conversion to rST/Sphinx, split it in multiple .texi > files that are included from docs/system. > > The "other devices" section is renamed to ivshmem and placed

Re: [PATCH v1 1/2] hw/arm: versal: Add support for the LPD ADMAs

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 03:17, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add support for the Versal LPD ADMAs. > > Signed-off-by: Edgar E. Iglesias > --- > hw/arm/xlnx-versal.c | 24 > include/hw/arm/xlnx-versal.h | 6 ++ > 2 files changed,

Re: [PATCH v2 1/4] qcow2: introduce compression type feature

2020-03-02 Thread Vladimir Sementsov-Ogievskiy
02.03.2020 11:21, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be cha

Re: [PATCH v3 06/33] qemu-doc: extract common system emulator documentation from the PC section

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > Move the section on PC peripherals together with other targets. > While some x86-specific information remains in the main system > emulation chapter, it can be tackled more easily a section at a > time. > > Signed-off-by: Paolo Bonzini > Message

Re: [PATCH v3 08/33] qemu-doc: split target sections to separate files

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-9-pbonz...@redhat.com > Reviewed-by: Peter Maydell > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > docs/system/target-arm.texi | 264 ++ > docs/syst

Re: [PATCH v2 1/4] qcow2: introduce compression type feature

2020-03-02 Thread Denis Plotnikov
On 02.03.2020 14:24, Vladimir Sementsov-Ogievskiy wrote: 02.03.2020 11:21, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the

Re: [PATCH v3 11/33] qemu-doc: move included files to docs/system

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > Since qemu-doc.texi is mostly including files from docs/system, > move the existing include files there for consistency. > > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-12-pbonz...@redhat.com > [PMM: update MAINTAINERS line fo

Re: [PATCH v3 10/33] qemu-doc: move qemu-tech.texi into main section

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > The only remaining content in qemu-tech.texi is a few paragraphs > about managed start up options. Move them in the main section > about full system emulation. > > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-11-pbonz...@redha

Re: [PATCH v3 09/33] qemu-doc: Remove the "CPU emulation" part of the "Implementation notes"

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > The "CPU emulation" part of the "Implementation notes" in > qemu-tech.texi looks like it is documenting what features of various > CPUs we do or don't emulate. However: > * it covers only six of our 21 guest architectures > * the last time anybody updated it for actua

Re: [PATCH v3 12/33] qemu-doc: remove indices other than findex

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > These indices are not well-maintained, and pandoc also chokes on the > directives. Just nuke them. > > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-13-pbonz...@redhat.com > Reviewed-by: Peter Maydell > Signed-off-by: Peter Ma

Re: [PATCH v3 13/33] docs/system: put qemu-block-drivers body in an included file

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Paolo Bonzini > > This removes the "only" directives, and lets us use the conventional > "DESCRIPTION" section in the manpage. > > This temporarily drops the qemu-block-drivers documentation > from the system manual, but it will be put back (in the > right place i

Re: [PATCH] hw/arm/smmu-common: a fix to smmu_find_smmu_pcibus

2020-03-02 Thread Peter Maydell
On Mon, 2 Mar 2020 at 11:02, Peter Maydell wrote: > Would one of you like to submit a patch that does it that way > round, please? Aha, I see you already did: https://patchew.org/QEMU/20200227164728.11635-1-phi...@redhat.com/ (I process my to-review queue mostly oldest-first). thanks -- PMM

Re: [PATCH v3 0/2] hw/arm/smmu-common: Avoid smmu_find_smmu_pcibus return dangling pointer

2020-03-02 Thread Peter Maydell
On Thu, 27 Feb 2020 at 16:47, Philippe Mathieu-Daudé wrote: > > This series include the previous patch from Eric, then a > code refactor to avoid similar mistakes in the future. > > Eric Auger (1): > hw/arm/smmu-common: a fix to smmu_find_smmu_pcibus > > Philippe Mathieu-Daudé (1): > hw/arm/sm

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-03-02 Thread BALATON Zoltan
On Sun, 1 Mar 2020, Richard Henderson wrote: On 3/1/20 4:13 PM, Programmingkid wrote: Ok, I was just looking at Intel's x87 chip documentation. It supports IEEE 754 floating point operations and exception flags. This leads me to this question. Would simply taking the host exception flags and u

Re: [PATCH 0/5] hw/arm: Remove big-endian checks on machine code

2020-03-02 Thread Peter Maydell
On Fri, 28 Feb 2020 at 12:53, Philippe Mathieu-Daudé wrote: > > We only build the little-endian softmmu configurations. > Checking for big endian is pointless, remove the unused code. > > Philippe Mathieu-Daudé (5): > hw/arm/gumstix: Simplify since the machines are little-endian only > hw/arm/

Re: [PATCH v3 2/4] target/i386: Remove monitor from some CPU models

2020-03-02 Thread Tao Xu
On 2/29/2020 5:39 AM, Eduardo Habkost wrote: On Wed, Feb 12, 2020 at 04:13:26PM +0800, Tao Xu wrote: Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana CPU model to uremove MONITOR/MWAIT featre. After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT (commit id 6f1

Re: [PATCH 0/8] target/arm: Misc cleanups surrounding TBI

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 03:12, Richard Henderson wrote: > > We have a bug at present wherein we do not supply the memory tag to > the memory system, so that on fault FAR_ELx does not contain the > correct value. > > For system mode, we already handle ignoring TBI in get_phys_addr_lpae, > as long as

Re: [PATCH 1/8] target/arm: Replicate TBI/TBID bits for single range regimes

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 03:12, Richard Henderson wrote: > > Replicate the single TBI bit from TCR_EL2 and TCR_EL3 so that > we can unconditionally use pointer bit 55 to index into our > composite TBI1:TBI0 field. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 6 -- > 1 fil

Re: [PATCH v3 4/4] target/i386: Add notes for versioned CPU models

2020-03-02 Thread Tao Xu
On 2/29/2020 5:52 AM, Eduardo Habkost wrote: On Wed, Feb 12, 2020 at 04:13:28PM +0800, Tao Xu wrote: Add which features are added or removed in this version. Remove the changed model-id in versioned CPU models, to keep the model name unchanged at /proc/cpuinfo inside the VM. Signed-off-by: Tao

Re: [PATCH 2/8] target/arm: Optimize cpu_mmu_index

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 03:14, Richard Henderson wrote: > > We now cache the core mmu_idx in env->hflags. Rather than recompute > from scratch, extract the field. All of the uses of cpu_mmu_index > within target/arm are within helpers where env->hflags is stable. Do you mean "within helpers, and

Re: [PATCH 3/8] target/arm: Apply TBI to ESR_ELx in helper_exception_return

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 03:14, Richard Henderson wrote: > > We missed this case within AArch64.ExceptionReturn. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-a64.c | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/target/arm/helper-a

Re: [PATCH v3 15/33] docs/system: Convert qemu-cpu-models.texi to rST

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > From: Kashyap Chamarthy > > This doc was originally written by Daniel P. Berrangé > , introduced via commit[1]: 2544e9e4aa (docs: add > guidance on configuring CPU models for x86, 2018-06-27). > > In this patch: > > - 1-1 conversion of Texinfo to rST, besides a couple

Re: [PATCH 4/8] target/arm: Move helper_dc_zva to helper-a64.c

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 03:14, Richard Henderson wrote: > > This is an aarch64-only function. Move it out of the shared file. > This patch is code movement only. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 16/33] docs/system: Convert security.texi to rST format

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > security.texi is included from qemu-doc.texi but is not used > in the qemu.1 manpage. So we can do a straightforward conversion > of the contents, which go into the system manual. > > Signed-off-by: Peter Maydell > Signed-off-by: Paolo Bonzini > Message-id: 20200226113

Re: [PATCH 5/8] target/arm: Use DEF_HELPER_FLAGS for helper_dc_zva

2020-03-02 Thread Peter Maydell
On Tue, 25 Feb 2020 at 03:14, Richard Henderson wrote: > > The function does not write registers, and only reads them by > implication via the exception path. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-a64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [PATCH v3 17/33] docs/system: convert managed startup to rST.

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Fix one typo in the process and format more option and > command names as literal text, but make no significant > changes to the content. > > Signed-off-by: Peter Maydell > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-17-pbonz...@redhat.com Reviewed-

Re: [PATCH v3 18/33] docs/system: convert the documentation of deprecated features to rST.

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > We put the whole of this document into the system manual, though > technically a few parts of it apply to qemu-img or qemu-nbd which are > otherwise documented in tools/. > > We only make formatting fixes, except for one use of 'appendix' which > we change to 'section' b

Re: [PATCH v3 19/33] docs/system: convert Texinfo documentation to rST

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > > Signed-off-by: Paolo Bonzini > Message-id: 20200226113034.6741-19-pbonz...@redhat.com > [PMM: Fixed target-arm.rst use of :math:; remove out of date > note about images.rst from commit message; fixed expansion > of |qemu_system_x86|; use parsed-literal in invocatio

Re: [PATCH v3 2/6] hw/arm/virt: Introduce VirtGICType enum type

2020-03-02 Thread Andrew Jones
On Mon, Mar 02, 2020 at 11:55:12AM +0100, Eric Auger wrote: > We plan to introduce yet another value for the gic version (nosel). > As we already use exotic values such as 0 and -1, let's introduce > a dedicated enum type and let vms->gic_version take this > type. > > Signed-off-by: Eric Auger >

Re: [PATCH v3 20/33] hmp-commands.hx: Add rST documentation fragments

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Add the rST versions of the documentation fragments. Once we've > converted fully from Texinfo to rST we can remove the ETEXI > fragments; for the moment we need both. > > Since the only consumer of the hmp-commands hxtool documentation > is the HTML manual, all we need

Re: [PATCH v3 21/33] hmp-commands-info.hx: Add rST documentation fragments

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Add the rST versions of the documentation fragments. Once we've > converted fully from Texinfo to rST we can remove the ETEXI > fragments; for the moment we need both. > > Note that most of the SRST fragments are 2-space indented so that the > 'info foo' documentation e

Re: [PATCH v3 05/33] qemu-doc: split qemu-doc.texi in multiple files

2020-03-02 Thread Peter Maydell
On Mon, 2 Mar 2020 at 11:22, Alex Bennée wrote: > > > Peter Maydell writes: > > > From: Paolo Bonzini > > > > In order to facilitate the reorganization of qemu-doc.texi content, > > as well as the conversion to rST/Sphinx, split it in multiple .texi > > files that are included from docs/system.

Re: [PATCH v3 22/33] doc/scripts/hxtool.py: Strip trailing ':' from DEFHEADING/ARCHHEADING

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > In hxtool files, section headings defined with the DEFHEADING > and ARCHHEADING macros have a trailing ':' > DEFHEADING(Standard options:) > > This is for the benefit of the --help output. For consistency > with the rest of the rST documentation, strip any trailing ':'

Re: [PATCH v3 24/33] docs: Roll -prom-env and -g target-specific info into qemu-options.hx

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > The SPARC and PPC targets currently have a fragment of target-specific > information about the -g and -prom options which would be better placed > as part of the general documentation of those options in qemu-options.hx. > Move the relevant information to those locations

Re: [PATCH v3 23/33] docs: Roll semihosting option information into qemu-options.hx

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Currently the per-target documentation for those targets that > implement semihosting includes a bit of text that goes into both the > manual and the manpage about options specific to the target. This > text is redundant with the earlier generic option description of th

Re: [PATCH v3 2/6] hw/arm/virt: Introduce VirtGICType enum type

2020-03-02 Thread Auger Eric
Hi Philippe, On 3/2/20 12:18 PM, Philippe Mathieu-Daudé wrote: > On 3/2/20 11:55 AM, Eric Auger wrote: >> We plan to introduce yet another value for the gic version (nosel). >> As we already use exotic values such as 0 and -1, let's introduce >> a dedicated enum type and let vms->gic_version take

Re: [PATCH v3 25/33] scripts/hxtool-conv: Archive script used in qemu-options.hx conversion

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > This commit archives the perl script used to do conversion of the > STEXI/ETEXI blocks in qemu-options.hx. (The other .hx files were > manually converted, but qemu-options.hx is complicated enough that > I felt I needed some scripting.) > > Signed-off-by: Peter Maydell

Re: [PATCH v3 28/33] docs: Split out sections for the manpage into .rst.inc files

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Sphinx doesn't have very good facilities for marking chunks > of documentation as "put this in the manpage only". So instead > we move the parts we want to put into both the HTML manuals > and the manpage into their own .rst.inc files, which we can > include from both th

Re: [PATCH v3 27/33] qemu-options.hx: Fix up the autogenerated rST

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > This commit contains hand-written fixes for some issues with the > autogenerated rST fragments in qemu-options.hx: > > * Sphinx complains about the UTF-8 art table in the documentation of >the -drive option. Replace it with a proper rST format table. > > * rST doe

Re: [PATCH v3 29/33] docs: Generate qemu.1 manpage with Sphinx

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Generate the qemu.1 manpage using Sphinx; we do this with a new > top-level rst source file which is just the skeleton of the manpage > and which includes .rst.inc fragments where it needs to incorporate > sections from the larger HTML manuals. > > Signed-off-by: Peter M

Re: [PATCH v3 30/33] ui/cocoa.m: Update documentation file and pathname

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > We want to stop generating the old qemu-doc.html; first we > must update places that refer to it so they instead go to > our top level index.html documentation landing page. > The Cocoa UI has a menu option to bring up the documentation; > make it point to the new top le

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-03-02 Thread Laurent Vivier
On 02/03/2020 12:19, Laurent Vivier wrote: > On 02/03/2020 11:53, Michael S. Tsirkin wrote: >> On Mon, Mar 02, 2020 at 10:50:16AM +0100, Laurent Vivier wrote: >>> On 01/03/2020 13:12, Michael S. Tsirkin wrote: On Fri, Feb 07, 2020 at 10:54:11AM +0100, Laurent Vivier wrote: > vhost-user-bri

Re: [PATCH v3 31/33] docs: Stop building qemu-doc

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Stop building the old texinfo qemu-doc; all its contents are > now available in the Sphinx-generated manuals and manpages. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée -- Alex Bennée

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-03-02 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > The interesting question is, what happens when you power down the VM on > the destination host (= post migration), and launch it again there, from > zero. In that case, the firmware executable file comes from the > *destination host* (it was never persis

Re: [PATCH v3 32/33] docs: Remove old texinfo sources

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > We can now delete the old .texi files, which we have been keeping in > the tree as a parallel set of documentation to the new rST sources. > The only remaining use of Texinfo is the autogenerated manuals > and HTML documents created from the QAPI JSON doc comments. > > S

Re: [PATCH v3 33/33] *.hx: Remove all the STEXI/ETEXI blocks

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > We no longer generate texinfo from the hxtool input files, > so delete all the STEXI/ETEXI blocks. > > This commit was created using the following Perl one-liner: > perl -i -n -e '$suppress = 1,next if /^STEXI/;$suppress=0,next if /^ETEXI/; > print if !$suppress;' *.h

Re: [PATCH v3 14/33] docs: Create defs.rst.inc as a place to define substitutions

2020-03-02 Thread Kashyap Chamarthy
On Fri, Feb 28, 2020 at 03:36:00PM +, Peter Maydell wrote: > Rather than accumulating generally useful rST substitution > definitions in individual rST files, create a defs.rst.inc where we > can define these. To start with it has the |qemu_system| definition > from qemu-block-drivers.rst. >

Re: [PATCH v3 00/33] Convert qemu-doc to rST

2020-03-02 Thread Alex Bennée
Peter Maydell writes: > Hi; this series does a complete conversion of qemu-doc from > Texinfo to rST, including the hxtool-generated parts and > creation of the qemu.1 manpage from rST. > > It's marked v3 because it's a development of the v2 that > Paolo sent out earlier this week. I should m

Re: [PATCH v3 32/33] docs: Remove old texinfo sources

2020-03-02 Thread Kashyap Chamarthy
On Fri, Feb 28, 2020 at 03:36:18PM +, Peter Maydell wrote: > We can now delete the old .texi files, which we have been keeping in > the tree as a parallel set of documentation to the new rST sources. > The only remaining use of Texinfo is the autogenerated manuals > and HTML documents created f

  1   2   3   4   >