[PATCH v6 74/79] exec: drop bogus mem_path from qemu_ram_alloc_from_fd()

2020-02-19 Thread Igor Mammedov
Function will report error that will mention global mem_path, which was valid the only if legacy -mem-path was used and only in case of main RAM. However it doesn't work with hostmem backends (for example: " qemu: -object memory-backend-file,id=ram0,size=128M,mem-path=foo: backing store (nul

[PATCH 0/3] Migration mechanism with FD

2020-02-19 Thread Oksana Vohchana
To test migration through the file descriptor we should build and provide a path to socket_scm_helper file. This way is inconvenient for acceptance testing. This series provides new functions to receive and send messages over a UNIX socket. And adds a new migration test. Oksana Vohchana (3): Add

[PATCH v6 68/79] ppc/virtex_ml507: use memdev for RAM

2020-02-19 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v2 05/14] tests/vm: Added gen_cloud_init_iso() to basevm.py

2020-02-19 Thread Robert Foley
This method was located in both centos and ubuntu.i386. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 40 tests/vm/centos | 33 + tests/vm/ubuntu.i386 | 37 +

[PATCH v6 62/79] ppc/pnv: use memdev for RAM

2020-02-19 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v1 08/13] migrate/ram: Simplify host page handling in ram_load_postcopy()

2020-02-19 Thread David Hildenbrand
Add two new helper functions. This will in come handy once we want to handle ram block resizes while postcopy is active. Cc: "Dr. David Alan Gilbert" Cc: Juan Quintela Cc: Peter Xu Signed-off-by: David Hildenbrand --- migration/ram.c | 52 - 1 f

[PATCH v6 79/79] tests:numa-test: use explicit memdev to specify node RAM

2020-02-19 Thread Igor Mammedov
Considering that legacy "mem" option is deprecated, use memdev in tests and add an additional test for legacy "mem" option on old machine type, to make sure it won't regress in the future. Signed-off-by: Igor Mammedov Acked-by: Thomas Huth --- v6: * ammend commit message to no mention 'follow

[PATCH v1 10/13] migrate/ram: Handle RAM block resizes during postcopy

2020-02-19 Thread David Hildenbrand
Resizing while migrating is dangerous and does not work as expected. The whole migration code works on the usable_length of ram blocks and does not expect this to change at random points in time. In the case of postcopy, relying on used_length is racy as soon as the guest is running. Also, when us

[PATCH v6 69/79] sparc/leon3: use memdev for RAM

2020-02-19 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v2 07/14] tests/vm: Add configuration to basevm.py

2020-02-19 Thread Robert Foley
Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration which we might want t

[PATCH v2 10/14] tests/vm: Add ability to select QEMU from current build.

2020-02-19 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 29 - 2 files changed, 28 insertions(+), 5 deletions(-) dif

[PATCH v6 71/79] sparc/niagara: use memdev for RAM

2020-02-19 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v1 12/13] migrate/ram: Use offset_in_ramblock() in range checks

2020-02-19 Thread David Hildenbrand
We never read or write beyond the used_length of memory blocks when migrating. Make this clearer by using offset_in_ramblock() consistently. Cc: "Dr. David Alan Gilbert" Cc: Juan Quintela Cc: Peter Xu Signed-off-by: David Hildenbrand --- migration/ram.c | 10 +- 1 file changed, 5 inse

[PATCH v1 00/13] migrate/ram: Fix resizing RAM blocks while migrating

2020-02-19 Thread David Hildenbrand
This is the follow up of "[PATCH RFC] memory: Don't allow to resize RAM while migrating" [1] This series contains some (slightly modified) patches also contained in: "[PATCH v2 fixed 00/16] Ram blocks with resizable anonymous allocations under POSIX" [2] That series will be based on t

[PATCH v1 01/13] util: vfio-helpers: Factor out and fix processing of existing ram blocks

2020-02-19 Thread David Hildenbrand
Factor it out into common code when a new notifier is registered, just as done with the memory region notifier. This allows us to have the logic about how to process existing ram blocks at a central place (which will be extended soon). Just like when adding a new ram block, we have to register the

[PATCH v2 12/14] tests/vm: Added a new script for ubuntu.aarch64.

2020-02-19 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 3 +- tests/vm/aarch64vm.py

[PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy()

2020-02-19 Thread David Hildenbrand
It's always the same value. Cc: "Dr. David Alan Gilbert" Cc: Juan Quintela Cc: Peter Xu Signed-off-by: David Hildenbrand --- migration/ram.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cbd54947fb..75014717f6 100644 --- a/

[PATCH 3/3] Acceptance test: FD migration

2020-02-19 Thread Oksana Vohchana
Adds a new migration test through the file descriptor. Signed-off-by: Oksana Vohchana --- tests/acceptance/migration.py | 20 1 file changed, 20 insertions(+) diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index a8367ca023..b96a897f3b 100644 ---

[PATCH v2 14/14] tests/vm: change scripts to use self._config

2020-02-19 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley -

[PATCH v1 03/13] numa: Teach ram block notifiers about resizeable ram blocks

2020-02-19 Thread David Hildenbrand
Ram block notifiers are currently not aware of resizes. Especially to handle resizes during migration, but also to implement actually resizeable ram blocks (make everything between used_length and max_length inaccessible), we want to teach ram block notifiers about resizeable ram. Introduce the ba

[PATCH v1 09/13] migrate/ram: Consolidate variable reset after placement in ram_load_postcopy()

2020-02-19 Thread David Hildenbrand
Let's consolidate resetting the variables. Cc: "Dr. David Alan Gilbert" Cc: Juan Quintela Cc: Peter Xu Signed-off-by: David Hildenbrand --- migration/ram.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 80a4e4a9ea..ab1f55

Re: [PATCH v2 21/22] qemu-iotests/199: add early shutdown case to bitmaps postcopy

2020-02-19 Thread Andrey Shinkevich
On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Previous patches fixed two crashes which may occur on shutdown prior to bitmaps postcopy finished. Check that it works now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/199 | 18 ++ tests/qe

[PATCH v2 02/14] tests/vm: Debug mode shows ssh output.

2020-02-19 Thread Robert Foley
Add changes to tests/vm/basevm.py so that during debug mode we show ssh output. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py

[PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-19 Thread David Hildenbrand
Resizing while migrating is dangerous and does not work as expected. The whole migration code works on the usable_length of ram blocks and does not expect this to change at random points in time. In the case of precopy, the ram block size must not change on the source, after syncing the RAM block

[PATCH v1 13/13] migrate/ram: Tolerate partially changed mappings in postcopy code

2020-02-19 Thread David Hildenbrand
When we partially change mappings (e.g., mmap over parts of an existing mmap) where we have a userfaultfd handler registered, the handler will implicitly be unregistered from the parts that changed. This is e.g., the case when doing a qemu_ram_remap(), but is also a preparation for RAM blocks with

[PATCH v1 11/13] migrate/multifd: Print used_length of memory block

2020-02-19 Thread David Hildenbrand
We actually want to print the used_length, against which we check. Cc: "Dr. David Alan Gilbert" Cc: Juan Quintela Cc: Peter Xu Signed-off-by: David Hildenbrand --- migration/multifd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c

[PATCH v2 09/14] tests/vm: add --boot-console switch

2020-02-19 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley --- tests/

[PATCH 1/3] Adding functions _send_fds and _recv_fds

2020-02-19 Thread Oksana Vohchana
It provides new possibilities to send or receive data through the Unix domain socket file descriptor. This is useful for obtaining a socket that belongs to a different network namespace. Signed-off-by: Oksana Vohchana --- python/qemu/machine.py | 18 ++ 1 file changed, 18 inserti

Re: [PATCH v6 00/79] refactor main RAM allocation to use hostmem backend

2020-02-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200219160953.13771-1-imamm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v6 00/79] refactor main RAM allocation to use hostmem backend Message-id: 20200219160953.13771-1-i

[PATCH v2 01/14] tests/vm: use $(PYTHON) consistently

2020-02-19 Thread Robert Foley
Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/

[PATCH 2/3] Updates send_fd_scm function

2020-02-19 Thread Oksana Vohchana
A qemu-iotest uses for FD-migration test a helper program "socket_scm_helper". And it makes some problems if you didn't build it with a QEMU. And now we can use new methods for the socket that allow us to send a file/socket descriptor (with access and permissions) from one process to another. Sign

Re: [PATCH v2 18/22] python/qemu/machine: add kill() method

2020-02-19 Thread Andrey Shinkevich
On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Add method to hard-kill vm, without any quit commands. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/machine.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/python/qemu/machine.py b/pyt

[PATCH v2 03/14] tests/vm: increased max timeout for vm boot.

2020-02-19 Thread Robert Foley
Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

2020-02-19 Thread Robert Foley
This is version 2 of the patch series to add support for aarch64 VMs. - Ubuntu 18.04 aarch64 VM - CentOS 8 aarch64 VM V1: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg01180.html Changes in version 2 - Most changes relate to the patch: "Add workaround to consume console".    - We

[PATCH v2 04/14] tests/vm: give wait_ssh() option to wait for root

2020-02-19 Thread Robert Foley
Allow wait_ssh to wait for root user to be ready. This solves the issue where we perform a wait_ssh() successfully, but the root user is not yet ready to be logged in. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 7 +-- 1 file chang

[PATCH v2 13/14] tests/vm: Added a new script for centos.aarch64.

2020-02-19 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 224 ++

Re: [PATCH v2 1/2] docs: Convert qemu-cpu-models.texi to rST

2020-02-19 Thread Kashyap Chamarthy
On Wed, Feb 19, 2020 at 01:16:11PM +, Peter Maydell wrote: [...] > 3) we create a qemu-cpu-models.7 manpage, so the parts > of Makefile that currently handle creating it from the > texi need to be changed to do it from the rST instead. > You can look at how we handle qemu-block-drivers.7 > fo

[PATCH v2 06/14] tests/vm: Add workaround to consume console

2020-02-19 Thread Robert Foley
The ConsoleSocket object provides a socket interface which will consume all arriving characters on the socket, but will provide those chars via recv() as would a regular socket. This is a workaround we found was needed since there is a known issue where QEMU will hang waiting for console characters

[PATCH v2 08/14] tests/vm: Added configuration file support

2020-02-19 Thread Robert Foley
Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example conf_example_aarch64.yml and conf_example_x86.ym

[PATCH v2 11/14] tests/vm: allow wait_ssh() to specify command

2020-02-19 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index a30a641a4a..792e4a3fb2 100644 --- a/tests/vm/basevm.py

Re: [PATCH v2 21/22] qemu-iotests/199: add early shutdown case to bitmaps postcopy

2020-02-19 Thread Andrey Shinkevich
On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Previous patches fixed two crashes which may occur on shutdown prior to bitmaps postcopy finished. Check that it works now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/199 | 18 ++ tests/qe

Re: [PATCH v2 22/22] qemu-iotests/199: add source-killed case to bitmaps postcopy

2020-02-19 Thread Andrey Shinkevich
On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Previous patches fixes behavior of bitmaps migration, so that errors are handled by just removing unfinished bitmaps, and not fail or try to recover postcopy migration. Add corresponding test. Signed-off-by: Vladimir Sementsov-Ogievskiy -

Re: RFC: Split EPT huge pages in advance of dirty logging

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 01:19:08PM +, Zhoujian (jay) wrote: > Hi Peter, > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Wednesday, February 19, 2020 1:43 AM > > To: Zhoujian (jay) > > Cc: k...@vger.kernel.org; qemu-devel@nongnu.org; pbonz...@redhat.com

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

2020-02-19 Thread Andrey Shinkevich
On 19/02/2020 17:58, Eric Blake wrote: On 2/19/20 7:52 AM, Andrey Shinkevich wrote: +od: unrecognized option '--endian=big' +Try 'od --help' for more information. +od: invalid -N argument '--endian=big' Yay, same problem for both tests.  Fix common.rc once, and both tests should start wor

Re: [PATCH v2] pcie_root_port: Add enable_hotplug option

2020-02-19 Thread Igor Mammedov
On Wed, 19 Feb 2020 15:55:40 +0100 Julia Suvorova wrote: > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt > manage it and restrict unplug for the whole machine. This is going to > prevent user-initiated unplug in guests (Windows mostly). > Hotplug is enabled by default. > U

Re: [PATCH v2 07/13] hw/arm/bcm2836: QOM'ify more by adding class_init() to each SoC type

2020-02-19 Thread Igor Mammedov
On Tue, 18 Feb 2020 18:39:49 +0100 Philippe Mathieu-Daudé wrote: > On 2/18/20 6:04 PM, Igor Mammedov wrote: > > On Mon, 17 Feb 2020 12:45:27 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> Remove usage of TypeInfo::class_data. Instead fill the fields in > >> the corresponding class_init(). >

Re: [PATCH v2 fixed 01/16] util: vfio-helpers: Factor out and fix processing of existing ram blocks

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 09:43:02AM +0100, David Hildenbrand wrote: > On 18.02.20 23:00, Peter Xu wrote: > > On Wed, Feb 12, 2020 at 02:42:39PM +0100, David Hildenbrand wrote: > >> Factor it out into common code when a new notifier is registered, just > >> as done with the memory region notifier. Th

Re: [PATCH v2 1/2] docs: Convert qemu-cpu-models.texi to rST

2020-02-19 Thread Peter Maydell
On Wed, 19 Feb 2020 at 16:40, Kashyap Chamarthy wrote: > Peter, how are you able to generate those *.7 `nroff` man pages? When I > do 'make sphinxbuild' from my build dir ($HOME/buld/qemu), I only see: Just run 'make'. As with the existing texinfo manpages, there is no specific makefile target f

Re: [PATCH] util/async: make bh_aio_poll() O(1)

2020-02-19 Thread Stefan Hajnoczi
On Wed, Feb 19, 2020 at 12:09:48PM +0100, Paolo Bonzini wrote: > Really a great idea, though I have some remarks on the implementation below. > > On 19/02/20 11:00, Stefan Hajnoczi wrote: > > + * Each aio_bh_poll() call carves off a slice of the BH list. This way > > newly > > + * scheduled BHs

Re: [PATCH v3] virtio: increase virtqueue size for virtio-scsi and virtio-blk

2020-02-19 Thread Stefan Hajnoczi
On Fri, Feb 14, 2020 at 10:46:48AM +0300, Denis Plotnikov wrote: > The goal is to reduce the amount of requests issued by a guest on > 1M reads/writes. This rises the performance up to 4% on that kind of > disk access pattern. > > The maximum chunk size to be used for the guest disk accessing is >

Re: [PATCH v4 1/5] extend libvhost to support IOThread and coroutine

2020-02-19 Thread Stefan Hajnoczi
On Tue, Feb 18, 2020 at 01:07:07PM +0800, Coiby Xu wrote: > +static bool vu_message_read(VuDev *dev, int conn_fd, VhostUserMsg *vmsg) > +{ > +vu_read_msg_cb read_msg; > +if (dev->co_iface) { > +read_msg = dev->co_iface->read_msg; > +} else { > +read_msg = vu_message_read

Re: [PATCH] memory: batch allocate ioeventfds[] in address_space_update_ioeventfds()

2020-02-19 Thread Stefan Hajnoczi
On Wed, Feb 19, 2020 at 12:36:04PM +0100, Paolo Bonzini wrote: > On 18/02/20 19:22, Stefan Hajnoczi wrote: > > + * It is likely that the number of ioeventfds hasn't changed much, so > > use > > + * the previous size as the starting value. > > + */ > > +ioeventfd_max = as->ioeventfd

[PATCH v2] util/async: make bh_aio_poll() O(1)

2020-02-19 Thread Stefan Hajnoczi
The ctx->first_bh list contains all created BHs, including those that are not scheduled. The list is iterated by the event loop and therefore has O(n) time complexity with respected to the number of created BHs. Rewrite BHs so that only scheduled or deleted BHs are enqueued. Only BHs that actuall

Re: [PATCH v4 0/5] vhost-user block device backend implementation

2020-02-19 Thread Stefan Hajnoczi
On Tue, Feb 18, 2020 at 01:07:06PM +0800, Coiby Xu wrote: > v4: > * add object properties in class_init > * relocate vhost-user-blk-test > * other changes including using SocketAddress, coding style, etc. Thanks! I think the vhost-user server code can be simplified if libvhost-user uses the ev

Re: [PATCH 0/3] Migration mechanism with FD

2020-02-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200219163344.27651-1-ovosh...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/3] Migration mechanism with FD Message-id: 20200219163344.27651-1-ovosh...@redhat.com Type: seri

Re: [PATCH 1/3] migration/colo: wrap incoming checkpoint process into new helper

2020-02-19 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > Split checkpoint incoming process into a helper. > > Signed-off-by: Hailiang Zhang Reviewed-by: Dr. David Alan Gilbert > --- > migration/colo.c | 260 --- > 1 file changed, 133 insertions(+)

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-02-19 Thread Howard Spoelstra
Hi, I tested with the current ppc-for-5.0 branch and with v1 of the hardfloat patches applied on top of that. There is a noticeable speed improvement in Linux and OSX hosts. Windows 10 host doesn't seem to be impressed at all. I saw no obvious glitches so far. The fpu performance on OSX hosts seem

Re: [PATCH 2/3] COLO: Migrate dirty pages during the gap of checkpointing

2020-02-19 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > We can migrate some dirty pages during the gap of checkpointing, > by this way, we can reduce the amount of ram migrated during checkpointing. > > Signed-off-by: Hailiang Zhang > --- > migration/colo.c | 69

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-19 Thread BALATON Zoltan
On Wed, 19 Feb 2020, jasper.low...@bt.com wrote: When configuring devices, Solaris 10 uses the SET_FEATURE command on the CMD646 to set the transfer mode to MDMA mode. From what I can tell, this is successful and the emulated IDE controller raises an interrupt acknowledging that the command was

Re: [PATCH 21/22] linux-user,mips: move content of mips_syscall_args

2020-02-19 Thread Aleksandar Markovic
On Tuesday, February 18, 2020, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Monday, February 17, 2020, Laurent Vivier wrote: > >> Move content of mips_syscall_args to mips-syscall-args-o32.c.inc to >> ease automatic update. No functionnal change >> >> Signed-off-by: Laurent

Re: [PATCH v2 1/6] tests/boot_linux_console: add microvm acceptance test

2020-02-19 Thread Wainer dos Santos Moschetta
Liam, Sorry for the long time to reply it... comments below. On 2/6/20 1:05 PM, Liam Merwick wrote: On 06/02/2020 14:09, Philippe Mathieu-Daudé wrote: Hi Liam, On 2/6/20 2:57 PM, Philippe Mathieu-Daudé wrote: On 2/5/20 3:56 PM, Liam Merwick wrote: Refactor test_x86_64_pc() to test_x86_64_ma

Re: [PATCH] util/async: make bh_aio_poll() O(1)

2020-02-19 Thread Paolo Bonzini
Il mer 19 feb 2020, 18:58 Stefan Hajnoczi ha scritto: > On Wed, Feb 19, 2020 at 12:09:48PM +0100, Paolo Bonzini wrote: > > Really a great idea, though I have some remarks on the implementation > below. > > > > On 19/02/20 11:00, Stefan Hajnoczi wrote: > > > + * Each aio_bh_poll() call carves off

Re: [PATCH 8/9] virStorageFileGetMetadataRecurse: Allow format probing under special circumstances

2020-02-19 Thread Eric Blake
[adding qemu] On 2/19/20 12:57 PM, Peter Krempa wrote: Namely a user creates an overlay on top of single raw/qcow2 image and expects it to work. And it's not just random users, libguestfs and openstack also neglected to set the backing format. Yes, and they are getting patched. Belatedly, b

Re: [PATCH v2 2/6] tests/boot_linux_console: add BIOS acceptance test

2020-02-19 Thread Wainer dos Santos Moschetta
On 2/6/20 12:12 PM, Philippe Mathieu-Daudé wrote: On 2/5/20 3:56 PM, Liam Merwick wrote: Add a test to use qboot with the 'pc' machine class and SeaBIOS with the 'microvm' machine class (since microvm uses qboot by default) by adding the '-bios' option via self.vm.add_args() before calling do_

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-02-19 Thread BALATON Zoltan
On Wed, 19 Feb 2020, Howard Spoelstra wrote: I tested with the current ppc-for-5.0 branch and with v1 of the hardfloat patches applied on top of that. There is a noticeable speed improvement in Linux and OSX hosts. Windows 10 host doesn't seem to be impressed at all. I saw no obvious glitches so

Re: [PATCH 21/22] linux-user,mips: move content of mips_syscall_args

2020-02-19 Thread Laurent Vivier
Le 19/02/2020 à 19:58, Aleksandar Markovic a écrit : > > > On Tuesday, February 18, 2020, Aleksandar Markovic > mailto:aleksandar.m.m...@gmail.com>> wrote: > > > > On Monday, February 17, 2020, Laurent Vivier > wrote: > > Move content of mips_syscall

Re: [PATCH 21/22] linux-user,mips: move content of mips_syscall_args

2020-02-19 Thread Aleksandar Markovic
On Wednesday, February 19, 2020, Laurent Vivier wrote: > Le 19/02/2020 à 19:58, Aleksandar Markovic a écrit : > > > > > > On Tuesday, February 18, 2020, Aleksandar Markovic > > mailto:aleksandar.m.m...@gmail.com>> > wrote: > > > > > > > > On Monday, February 17, 2020, Laurent Vivier >

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-19 Thread BALATON Zoltan
On Wed, 19 Feb 2020, BALATON Zoltan wrote: faster or doing something differently? Does someone know what interrupts are generated on real hardware in DMA mode so we can compare that to what we see with QEMU? The document Programming Interface for Bus Master IDE Controller, Revision 1.0 (5/16/

Re: [PATCH v1] block/nvme: introduce PMR support from NVMe 1.4 spec

2020-02-19 Thread Andrzej Jakowski
On 2/18/20 6:07 PM, no-re...@patchew.org wrote: > === TEST SCRIPT BEGIN === > #! /bin/bash > export ARCH=x86_64 > make docker-image-fedora V=1 NETWORK=1 > time make docker-test-mingw@fedora J=14 NETWORK=1 > === TEST SCRIPT END === > > CC hw/display/sii9022.o > CC hw/display/ssd0303.o

Re: [PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy()

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 05:17:19PM +0100, David Hildenbrand wrote: > It's always the same value. I guess not, because... > > Cc: "Dr. David Alan Gilbert" > Cc: Juan Quintela > Cc: Peter Xu > Signed-off-by: David Hildenbrand > --- > migration/ram.c | 8 +++- > 1 file changed, 3 insertion

Re: [PATCH v1 01/13] util: vfio-helpers: Factor out and fix processing of existing ram blocks

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 05:17:13PM +0100, David Hildenbrand wrote: > Factor it out into common code when a new notifier is registered, just > as done with the memory region notifier. This allows us to have the > logic about how to process existing ram blocks at a central place (which > will be exte

Re: [PATCH v1 02/13] stubs/ram-block: Remove stubs that are no longer needed

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 05:17:14PM +0100, David Hildenbrand wrote: > Current code no longer needs these stubs to compile. Let's just remove > them. > > Cc: Richard Henderson > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Peter Xu > Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu --

Re: [PATCH v1 04/13] numa: Make all callbacks of ram block notifiers optional

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 05:17:16PM +0100, David Hildenbrand wrote: > Let's make add/remove optional. We want to introduce a RAM block > notifier for RAM migration, that's only interested in resizes. > > Cc: Richard Henderson > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Cc

Re: [PATCH v1 03/13] numa: Teach ram block notifiers about resizeable ram blocks

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 05:17:15PM +0100, David Hildenbrand wrote: > Ram block notifiers are currently not aware of resizes. Especially to > handle resizes during migration, but also to implement actually resizeable > ram blocks (make everything between used_length and max_length > inaccessible), w

Re: [PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy()

2020-02-19 Thread Peter Xu
On Wed, Feb 19, 2020 at 03:47:30PM -0500, Peter Xu wrote: > On Wed, Feb 19, 2020 at 05:17:19PM +0100, David Hildenbrand wrote: > > It's always the same value. > > I guess not, because... > > > > > Cc: "Dr. David Alan Gilbert" > > Cc: Juan Quintela > > Cc: Peter Xu > > Signed-off-by: David Hil

[PATCH v2 10/20] linux-user, s390x: remove syscall definitions for !TARGET_S390X

2020-02-19 Thread Laurent Vivier
We don't support other 32bit architecture. Update file to comply with coding style (TAB). Signed-off-by: Laurent Vivier --- linux-user/s390x/syscall_nr.h | 313 +- 1 file changed, 123 insertions(+), 190 deletions(-) diff --git a/linux-user/s390x/syscall_nr.h b/li

[PATCH v2 01/20] linux-user: introduce parameters to generate syscall_nr.h

2020-02-19 Thread Laurent Vivier
This will be used when we'll import syscall.tbl from the kernel Add a script to remove all the dependencies to syscall_nr.h that point to source directory and not to the build directory. The list of arch will be update while the generated files are added. Signed-off-by: Laurent Vivier --- Notes

[PATCH v2 11/20] linux-user, s390x: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl from linux/arch/s390x/kernel/syscalls v5.5 Copy syscallhdr.sh from m68k. Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source directory configure |

[PATCH v2 05/20] linux-user, xtensa: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/xtensa/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source direct

[PATCH v2 03/20] linux-user, hppa: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/parisc/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source direct

[PATCH v2 00/20] linux-user: generate syscall_nr.sh

2020-02-19 Thread Laurent Vivier
This series copies the files syscall.tbl from linux v5.5 and generates the file syscall_nr.h from them. This is done for all the QEMU targets that have a syscall.tbl in the linux source tree: mips, mips64, i386, x86_64, sparc, s390x, ppc, arm, microblaze, sh4, xtensa, m68k, hppa and alpha. tilegx

[PATCH v2 08/20] linux-user, arm: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/arm/tools/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Update syscall.c to manage TARGET_NR_arm_sync_file_range as it has replaced TARGET_NR_sync_file_range2 Move existing stuff from linux-user/Makefile.objs to linux-user/arm/

[PATCH v2 04/20] linux-user, m68k: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/m68k/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source director

[PATCH v2 02/20] linux-user, alpha: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/alpha/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source directo

[PATCH v2 06/20] linux-user, sh4: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/sh/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source directory

[PATCH v2 09/20] linux-user, ppc: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/ppc/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h and to not generate the entry if entry point is sys_ni_syscall. Fix ppc/signal.c to define do_sigreturn() for TARGET_ABI32. Signed-off-by: Laurent Vivier --- Notes:

[PATCH v2 07/20] linux-user, microblaze: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/microblaze/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source d

[PATCH v2 12/20] linux-user, sparc, sparc64: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/sparc/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source directo

[PATCH v2 15/20] linux-user, mips: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/mips/kernel/syscalls/syscall_o32.tbl v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Move the offset (4000) from the file to the Makefile.objs to be passed to syscallhdr.sh Rename on the fly fadvise64 to fadvise64_64. Signed-off-by: Laure

[PATCH v2 16/20] linux-user, mips64: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall_n32.tbl, syscall_n64.tbl and syscallhdr.sh from linux/arch/parisc/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Move the offsets (6000 for n32 and 5000 for n64) from the file to the Makefile.objs to be passed to syscallhdr.sh Signed-off-by: Laurent Vivier -

[PATCH v2 17/20] linux-user, scripts: add a script to update syscall.tbl

2020-02-19 Thread Laurent Vivier
scripts/update-syscalltbl.sh has the list of syscall.tbl to update and can copy them from the linux source directory Signed-off-by: Laurent Vivier --- MAINTAINERS | 1 + scripts/update-syscalltbl.sh | 49 2 files changed, 50 insertions(+) c

[PATCH v2 18/20] linux-user: update syscall.tbl from linux 0bf999f9c5e7

2020-02-19 Thread Laurent Vivier
Run scripts/update-syscalltbl.sh with linux commit 0bf999f9c5e7 Signed-off-by: Laurent Vivier --- linux-user/arm/syscall.tbl| 2 ++ linux-user/hppa/syscall.tbl | 2 ++ linux-user/i386/syscall_32.tbl| 2 ++ linux-user/m68k/syscall.tbl | 4 +++- linux-user/microblaze/syscal

[PATCH v2 20/20] linux-user,mips: update syscall-args-o32.c.inc

2020-02-19 Thread Laurent Vivier
Add a script to update the file from strace github and run it Signed-off-by: Laurent Vivier --- linux-user/mips/syscall-args-o32.c.inc | 874 - scripts/update-mips-syscall-args.sh| 57 ++ 2 files changed, 493 insertions(+), 438 deletions(-) create mode 100755 script

[PATCH v2 13/20] linux-user, i386: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall_32.tbl and syscallhdr.sh from linux/arch/x86/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Disable arch_prctl in syscall_32.tbl because linux-user/syscall.c only defines do_arch_prctl() with TARGET_ABI32, and TARGET_ABI32 is never defined for TARGET_I386 (Thi

[PATCH v2 19/20] linux-user,mips: move content of mips_syscall_args

2020-02-19 Thread Laurent Vivier
Move content of mips_syscall_args to mips-syscall-args-o32.c.inc to ease automatic update. No functionnal change Signed-off-by: Laurent Vivier --- linux-user/mips/cpu_loop.c | 440 + linux-user/mips/syscall-args-o32.c.inc | 438 2 file

[PATCH v2 14/20] linux-user, x86_64: add syscall table generation support

2020-02-19 Thread Laurent Vivier
Copy syscall_64.tbl and syscallhdr.sh from linux/arch/x86/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier --- Notes: v2: fix a typo (double comma) in $(call quiet-command) remove dependencies to syscall_nr.h in source direct

Re: [PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize()

2020-02-19 Thread Peter Xu
On Wed, Feb 12, 2020 at 02:42:46PM +0100, David Hildenbrand wrote: > Factor it out and add a comment. > > Reviewed-by: Igor Kotrasinski > Acked-by: Murilo Opsfelder Araujo > Reviewed-by: Richard Henderson > Cc: "Michael S. Tsirkin" > Cc: Murilo Opsfelder Araujo > Cc: Greg Kurz > Cc: Eduardo

Re: [PATCH v2 fixed 09/16] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve()

2020-02-19 Thread Peter Xu
On Wed, Feb 12, 2020 at 02:42:47PM +0100, David Hildenbrand wrote: > We want to reserve a memory region without actually populating memory. > Let's factor that out. > > Reviewed-by: Igor Kotrasinski > Acked-by: Murilo Opsfelder Araujo > Reviewed-by: Richard Henderson > Cc: "Michael S. Tsirkin"

Re: [PATCH v2 fixed 10/16] util/mmap-alloc: Factor out populating of memory to mmap_populate()

2020-02-19 Thread Peter Xu
On Wed, Feb 12, 2020 at 02:42:48PM +0100, David Hildenbrand wrote: > We want to populate memory within a reserved memory region. Let's factor > that out. > > Reviewed-by: Richard Henderson > Acked-by: Murilo Opsfelder Araujo > Cc: Igor Kotrasinski > Cc: "Michael S. Tsirkin" > Cc: Greg Kurz >

Re: [PATCH v2 fixed 11/16] util/mmap-alloc: Prepare for resizable mmaps

2020-02-19 Thread Peter Xu
On Wed, Feb 12, 2020 at 02:42:49PM +0100, David Hildenbrand wrote: > @@ -178,13 +183,15 @@ void *qemu_ram_mmap(int fd, > size_t offset, total; > void *ptr, *guardptr; > > +g_assert(QEMU_IS_ALIGNED(size, pagesize)); (NOTE: assertion is fine, but as I mentioned in previous patch, I

<    1   2   3   4   >