On Tue, 18 Feb 2020 07:55:14 +0100
Philippe Mathieu-Daudé wrote:
> On 2/17/20 6:33 PM, Igor Mammedov wrote:
> > memory_region_allocate_system_memory() API is going away, so
> > replace it with memdev allocated MemoryRegion. The later is
> > initialized by generic code, so board only needs to opt
On 2/17/20 11:34 AM, Philippe Mathieu-Daudé wrote:
> This test runs Trusted Firmware-A on the Raspberry Pi 3.
> We deliberately stop the boot process when the EDK2 UEFI version
> is displayed.
>
> The binary is build on AppVeyor CI using Pete Batard repository [1].
> ATF v2.1 binary are used (see
Hi Phil,
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> As we only support a reduced set of the REV_CODE_PROCESSOR id
> encoded in the board revision, define the PROCESSOR_ID values
> as an enum. We can simplify the board_soc_type and cores_count
> methods.
>
> Signed-off-by: Philippe Mathi
Cc'ing Eduardo/Markus.
On 1/25/20 12:20 AM, Richard Henderson wrote:
From: Sven Schnelle
Signed-off-by: Sven Schnelle
Message-Id: <20191220211512.3289-5-sv...@stackframe.org>
Signed-off-by: Richard Henderson
---
include/hw/input/lasips2.h | 16 ++
include/hw/input/ps2.h | 1 +
hw/
Any way to get old behavior back when using `virsh attach` command?
Devices are not attached on boot. I am stuck with qemu 4.0 because of
this.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1846451
T
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> We expected the 'version' ID to match the board processor ID,
> but this is not always true (for example boards with revision
> id 0xa02042/0xa22042 are Raspberry Pi 2 with a BCM2837 SoC).
> This was not important because we were not modelling
Le 18/02/2020 à 07:13, Philippe Mathieu-Daudé a écrit :
> On 2/17/20 11:35 PM, Laurent Vivier wrote:
>> This series copies the files syscall.tbl from linux v5.5 and generates
>> the file syscall_nr.h from them.
>>
> [...]
>> Laurent Vivier (22):
>> linux-user: introduce parameters to generate sy
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> $ qemu-system-arm -M raspi1b -serial stdio \
> -kernel raspberrypi/firmware/boot/kernel.img \
> -dtb raspberrypi/firmware/boot/bcm2708-rpi-b.dtb \
> -append 'printk.time=0 earlycon=pl011,0x20201000 console=ttyAMA0'
> [0.
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> Add a Raspberry Pi Zero machine.
>
> $ qemu-system-arm -M raspi0w -serial stdio \
> -kernel raspberrypi/firmware/boot/kernel.img \
> -dtb raspberrypi/firmware/boot/bcm2708-rpi-zero-w.dtb \
> -append 'printk.time=0 earlycon=pl
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> No code out of bcm2836.c uses (or requires) this declarations.
> Move it locally to the C source file.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> include/hw/arm/bcm2836.h | 12
> hw/arm/bcm2836.c
On Mon, 17 Feb 2020 11:11:29 -0800
Richard Henderson wrote:
> On 2/17/20 9:33 AM, Igor Mammedov wrote:
> > memory_region_allocate_system_memory() API is going away, so
> > replace it with memdev allocated MemoryRegion. The later is
> > initialized by generic code, so board only needs to opt in
>
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> The BCM2835 has only one core. Introduce the core_count field to
> be able to use values different than BCM283X_NCPUS (4).
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/bcm2836.c | 7 +--
> 1 file chan
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> It makes no sense to set enabled-cpus=0 on single core SoCs.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/bcm2836.c | 15 +++
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> The realize() function is clearly composed of two parts,
> each described by a comment:
>
> void realize()
> {
> /* common peripherals from bcm2835 */
> ...
> /* bcm2836 interrupt controller (and mailboxes, etc.) */
> ...
This patch adds tests for following 14 implemented alsa timer ioctls:
* SNDRV_TIMER_IOCTL_PVERSION* SNDRV_TIMER_IOCTL_INFO
* SNDRV_TIMER_IOCTL_NEXT_DEVICE * SNDRV_TIMER_IOCTL_PARAMS
* SNDRV_TIMER_IOCTL_TREAD * SNDRV_TIMER_IOCTL_STATUS
* SNDRV_TIMER_IOCTL_GINFO * SND
This patch adds tests for following 22 implemented rtc ioctls:
* RTC_AIE_ON * RTC_ALM_SET * RTC_WKALM_SET
* RTC_AIE_OFF* RTC_ALM_READ * RTC_WKALM_RD
* RTC_UIE_ON * RTC_RD_TIME * RTC_PLL_GET
* RTC_UIE_OFF* RTC_SET_TIME * RTC_PLL_SET
* RTC_PIE_ON * RTC_IRQP_READ
This series covers tests for implemented rtc and alsa timer ioctls. The names
of ioctls that are covered by these tests can be found in patch descriptions.
The functionalities of each ioctl that is tested can be found in patches that
implement them.
Some of the features that are accessible through
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> include/hw/arm/bcm2836.h | 1 +
> hw/arm/bcm2836.c | 40
> hw/arm/raspi.c | 2 ++
> 3 files changed, 43 insert
On 18/02/2020 18:12, Cédric Le Goater wrote:
> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>
>>
>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
The following changes since commit
05943fb4ca41f626078014c0327781815c6584c5:
>>
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> Now that we can instantiate different machines based on their
> board_rev register value, we can have various raspi2 and raspi3.
>
> In commit fc78a990ec103 we corrected the machine description.
> Correct the machine names too. For backward comp
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> Commit 1c3db49d39 added the raspi3, which uses the same peripherals
> than the raspi2 (but with different ARM cores). The raspi3 was
> introduced without the ignore_memory_transaction_failures flag.
> Almost 2 years later, the machine is usable r
On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>
>
> On 18/02/2020 18:12, Cédric Le Goater wrote:
>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> The following changes since
From: Chen Qun
The device tree blob returned by load_device_tree is malloced.
We should free it after cpu_physical_memory_write().
Reported-by: Euler Robot
Signed-off-by: Chen Qun
---
hw/nios2/boot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c
index 4
From: Chen Qun
The device tree blob returned by load_device_tree is malloced.
We should free it after cpu_physical_memory_write().
Reported-by: Euler Robot
Signed-off-by: Chen Qun
---
hw/ppc/virtex_ml507.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virt
From: Chen Qun
The device tree blob returned by load_device_tree is malloced.
We should free it after cpu_physical_memory_write().Otherwise,
if we repeatedly call 'system_reset',it will repeatedly load fdt,
so there are many memleaks.
Paolo Bonzini :
https://lists.gnu.org/archive/html/qemu-devel
From: Chen Qun
The device tree blob returned by load_device_tree is malloced.
We should free it after cpu_physical_memory_write().
Reported-by: Euler Robot
Signed-off-by: Chen Qun
---
hw/xtensa/xtfpga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.
Hi Hailiang,
Thanks for your help. If we have any problems we will contact you for your
favor.
Hi Zhang,
" If colo-compare got a primary packet without related secondary packet in
a certain time , it will automatically trigger checkpoint. "
As you said, the colo-compare will trigger checkpoint,
Peter Maydell writes:
> On Mon, 17 Feb 2020 at 16:15, Philippe Mathieu-Daudé
> wrote:
>> Per this comment in qdev.c, unrealize() is the expected default:
>>
>> /* by default all devices were considered as hotpluggable,
>> * so with intent to check it in generic qdev_unplug() /
>>
Peter Maydell writes:
> On Mon, 17 Feb 2020 at 17:20, Philippe Mathieu-Daudé
> wrote:
>> Quick check with TYPE_BITBAND which is a SysBus device, we have:
>>
>> static void bitband_realize(DeviceState *dev, Error **errp)
>> {
>> BitBandState *s = BITBAND(dev);
>>
>> if (!s->source_memo
Display error when a commit contains superfluous semicolon:
$ git show 6663a0a3376 | scripts/checkpatch.pl -q -
ERROR: superfluous trailing semicolon
#276: FILE: block/io_uring.c:186:
+ret = -ENOSPC;;
total: 1 errors, 1 warnings, 485 lines checked
Reported-by: Luc Michel
Luc noticed a superfluous trailing semicolon:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
Prevent that by modifying checkpatch.pl and clean the codebase.
Philippe Mathieu-Daudé (13):
scripts/checkpatch.pl: Detect superfluous semicolon in C code
audio/alsaaudio: Remove
Cc'ing Eduardo/Igor.
On 2/18/20 9:48 AM, Luc Michel wrote:
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
$ qemu-system-arm -M raspi1b -serial stdio \
-kernel raspberrypi/firmware/boot/kernel.img \
-dtb raspberrypi/firmware/boot/bcm2708-rpi-b.dtb \
-append 'printk.ti
Luc noticed a superfluous trailing semicolon:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
Prevent that by modifying checkpatch.pl and clean the codebase.
Philippe Mathieu-Daudé (13):
scripts/checkpatch.pl: Detect superfluous semicolon in C code
audio/alsaaudio: Remove
Display error when a commit contains superfluous semicolon:
$ git show 6663a0a3376 | scripts/checkpatch.pl -q -
ERROR: superfluous trailing semicolon
#276: FILE: block/io_uring.c:186:
+ret = -ENOSPC;;
total: 1 errors, 1 warnings, 485 lines checked
Reported-by: Luc Michel
On 2/18/20 10:32 AM, Philippe Mathieu-Daudé wrote:
Luc noticed a superfluous trailing semicolon:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
Prevent that by modifying checkpatch.pl and clean the codebase.
Philippe Mathieu-Daudé (13):
scripts/checkpatch.pl: Detect supe
On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>
>
> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>
>>
>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
On 17/02/2020 20:48, Cédric Le Goater wrote:
> On 2/17/20 3:12 AM, A
On 2/18/20 10:37 AM, Philippe Mathieu-Daudé wrote:
Luc noticed a superfluous trailing semicolon:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
Prevent that by modifying checkpatch.pl and clean the codebase.
Philippe Mathieu-Daudé (13):
scripts/checkpatch.pl: Detect supe
Display error when a commit contains superfluous semicolon:
$ git show 6663a0a3376 | scripts/checkpatch.pl -q -
ERROR: superfluous trailing semicolon
#276: FILE: block/io_uring.c:186:
+ret = -ENOSPC;;
total: 1 errors, 1 warnings, 485 lines checked
Reported-by: Luc Michel
On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote:
No reason to use _locked version of bdrv_enable_dirty_bitmap, as we
don't lock this mutex before. Moreover, the adjacent
bdrv_dirty_bitmap_enable_successor do lock the mutex.
Fixes: 58f72b965e9e1q
Cc: qemu-sta...@nongnu.org # v3.0
Signed-o
Luc noticed a superfluous trailing semicolon:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
Prevent that by modifying checkpatch.pl and clean the codebase.
Philippe Mathieu-Daudé (13):
scripts/checkpatch.pl: Detect superfluous semicolon in C code
audio/alsaaudio: Remove
Fixes: 286a5d201e4
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: "Kővágó, Zoltán"
---
audio/alsaaudio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index a23a5a0b60..a8e62542f9 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.
Fixes: 6663a0a3376
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Stefano Garzarella
---
block/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/io_uring.c b/block/io_uring.c
index 56892fd1ab..a3142ca989 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -1
Fixes: 74d71ea16bc
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Dr. David Alan Gilbert
Cc: Mark Cave-Ayland
Cc: Laurent Vivier
Cc: Paolo Bonzini
---
hw/scsi/esp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index f8fc30cccb..405f8b7cbc 10
Fixes: 6105683da35
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Laurent Vivier
---
ui/input-barrier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/input-barrier.c b/ui/input-barrier.c
index fe35049b83..527c75e130 100644
--- a/ui/input-barrier.c
+++ b/ui/input-barrier.c
Fixes: 132ada80c4a
Signed-off-by: Philippe Mathieu-Daudé
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 9c810534d6..9db0b973fe 100644
--- a/block.c
+++ b/block.c
@@ -2435,13 +2435,13 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 286a5d201e4
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> Cc: "Kővágó, Zoltán"
> ---
> audio/alsaaudio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/audio/alsaa
Fixes: d32ca5ad798
Signed-off-by: Philippe Mathieu-Daudé
---
migration/multifd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index b3e8ae9bcc..cfaba1369e 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -305,7 +305,7 @
Fixes: 956a78118bf
Signed-off-by: Philippe Mathieu-Daudé
---
hw/m68k/next-cube.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index e5343348d0..350c6fec78 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -734,7 +734,7 @
Fixes: 8b818e059bf
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Gerd Hoffmann
---
hw/vfio/display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/display.c b/hw/vfio/display.c
index a5a608c5b2..f4977c66e1 100644
--- a/hw/vfio/display.c
+++ b/hw/vfio/display.c
@@ -2
Fixes: 6f16da53ffe
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/xlnx-versal-virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
index 462493c467..0d2e3bdda1 100644
--- a/hw/arm/xlnx-versal-virt.c
+++ b/hw/arm/xlnx-ve
>-Original Message-
>From: Chenqun (kuhn)
>Sent: Tuesday, February 18, 2020 5:12 PM
>To: qemu-devel@nongnu.org; qemu-...@nongnu.org; jcmvb...@gmail.com;
>crwu...@gmail.com; ma...@denx.de; edgar.igles...@gmail.com;
>da...@gibson.dropbear.id.au
>Cc: Zhanghailiang ; qemu-
>triv...@nongnu.org
Fixes: 812d49f2a3e
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Justin Terry (VM)
---
target/i386/whpx-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index 3ed2aa1892..35601b8176 100644
--- a/target/i386/whpx-all.c
+++ b
Fixes: fc281c80202
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Emanuele Giuseppe Esposito
---
tests/qtest/libqos/qgraph.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/libqos/qgraph.c b/tests/qtest/libqos/qgraph.c
index 7a7ae2a19e..ca01de0743 100644
--- a/
On Tue, Feb 18, 2020 at 10:43:53AM +0100, Philippe Mathieu-Daudé wrote:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Stefano Garzarella
> ---
> block/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
Thanks,
Stefano
Fixes: a5d2f6f8773
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Shamir Rabinovitch
---
contrib/rdmacm-mux/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c
index de53048f06..bd82abbad3 100644
--- a/contrib/rdmacm-mux
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 956a78118bf
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> hw/m68k/next-cube.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
>
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Display error when a commit contains superfluous semicolon:
>
> $ git show 6663a0a3376 | scripts/checkpatch.pl -q -
> ERROR: superfluous trailing semicolon
> #276: FILE: block/io_uring.c:186:
> +ret = -ENOSPC;;
> total
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> On 2/17/20 9:06 PM, Dr. David Alan Gilbert wrote:
> > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> > > Fix warning reported by Clang static code analyzer:
> > >
> > > CC tools/virtiofsd/fuse_lowlevel.o
> > >tools/virtiofs
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Stefano Garzarella
Reviewed-by: Dr. David Alan Gilbert
> ---
> block/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/io_uring
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 132ada80c4a
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> block.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block.c b/block.c
> index 9c810534d6..9db0b973fe 10
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 8b818e059bf
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> Cc: Gerd Hoffmann
> ---
> hw/vfio/display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/display.c
Am 18.02.2020 um 10:43 hat Philippe Mathieu-Daudé geschrieben:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé
Thanks, applied patches 3 and 4 to the block branch.
Kevin
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 6f16da53ffe
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> hw/arm/xlnx-versal-virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xl
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: d32ca5ad798
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/multifd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/multifd.c b/migration/multifd.c
>
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 812d49f2a3e
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> Cc: Justin Terry (VM)
> ---
> target/i386/whpx-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i3
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 74d71ea16bc
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> Cc: Dr. David Alan Gilbert
> Cc: Mark Cave-Ayland
> Cc: Laurent Vivier
> Cc: Paolo Bonzini
> ---
> hw/scsi/esp.c | 2 +-
> 1 file cha
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: 6105683da35
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Laurent Vivier
Reviewed-by: Dr. David Alan Gilbert
> ---
> ui/input-barrier.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/input-barrier
On Tue, 18 Feb 2020 at 06:46, Philippe Mathieu-Daudé wrote:
> IIRC from the specs, cards are block devices and the only alignment
> required is the size of a block (512KiB for your 4GiB card).
Isn't there something related to erase blocks too, which impose
a larger granularity than just a single
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: fc281c80202
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> Cc: Emanuele Giuseppe Esposito
> ---
> tests/qtest/libqos/qgraph.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Fixes: a5d2f6f8773
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
> ---
> Cc: Shamir Rabinovitch
> ---
> contrib/rdmacm-mux/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contr
picking up on John's in-progress patch series from last summer, this is
a stab at rebasing and adding test cases for the low-hanging fruits:
- bitmap mirror mode with always/on-success/never bitmap sync mode
- incremental mirror mode as sugar for bitmap + on-success
Fabian Grünbichler (4):
mirr
and assert the passing conditions in block/mirror.c. while incremental
mode was never available for drive-mirror, it makes the interface more
uniform w.r.t. backup block jobs.
Signed-off-by: Fabian Grünbichler
---
block/mirror.c | 28 +++
blockdev.c | 29 +
as one without the other does not make much sense with the current set
of modes.
Signed-off-by: Fabian Grünbichler
---
blockdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 8f7b7ba5eb..23df9f76ba 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3868,6 +3868,
heavily based on/practically forked off iotest 257 for bitmap backups,
but:
- no writes to filter node 'mirror-top' between completion and
finalization, as those seem to deadlock?
- no inclusion of not-yet-available full/top sync modes in combination
with bitmaps
- extra set of reference/test mirr
since sync_bitmap is busy at the point of merging, and we checked access
beforehand.
Signed-off-by: Fabian Grünbichler
---
block/mirror.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 40d174a625..d6aca2874e 100644
--- a/block/mi
From: John Snow
Teach mirror two new tricks for using bitmaps:
Always: no matter what, we synchronize the copy_bitmap back to the
sync_bitmap. In effect, this allows us resume a failed mirror at a later
date.
Conditional: On success only, we sync the bitmap. This is akin to
incremental backup m
From: John Snow
This patch adds support for the "BITMAP" sync mode to drive-mirror and
blockdev-mirror. It adds support only for the BitmapSyncMode "never,"
because it's the simplest mode.
This mode simply uses a user-provided bitmap as an initial copy
manifest, and then does not clear any bits
Philippe Mathieu-Daudé wrote:
> Display error when a commit contains superfluous semicolon:
>
> $ git show 6663a0a3376 | scripts/checkpatch.pl -q -
> ERROR: superfluous trailing semicolon
> #276: FILE: block/io_uring.c:186:
> +ret = -ENOSPC;;
> total: 1 errors, 1 warnings
Philippe Mathieu-Daudé wrote:
> Fixes: 286a5d201e4
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: d32ca5ad798
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: a5d2f6f8773
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 132ada80c4a
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 6f16da53ffe
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 956a78118bf
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 74d71ea16bc
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 8b818e059bf
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Fixes: 812d49f2a3e
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
There is no good reason why we would allow external snapshots only on
the first non-filter node in a chain. Parent BDSs should not care
whether their child is replaced by a snapshot. (If they do care, they
should announce that via freezing the chain, which is checked in
bdrv_append() through bdrv
Using -drive with default options means that a virtio-blk drive will be
created that has write access to the to-be quorum children. Quorum
should have exclusive write access to them, so we should use -blockdev
instead.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
test
Philippe Mathieu-Daudé wrote:
> Fixes: d32ca5ad798
> Signed-off-by: Philippe Mathieu-Daudé
I forgot, queued on migration branch.
Branch: https://github.com/XanClic/qemu.git fix-can-replace-v4
Branch: https://git.xanclic.moe/XanClic/qemu.git fix-can-replace-v4
v1: https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01027.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2019-11/msg00370.html
v3: https://lists
Block nodes that do not allow resizing should not share BLK_PERM_RESIZE.
It does not matter whether they are the first non-filter in their chain
or not.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/bloc
After a couple of follow-up patches, this function will replace
bdrv_recurse_is_first_non_filter() in check_to_replace_node().
bdrv_recurse_is_first_non_filter() is both not sufficiently specific for
check_to_replace_node() (it allows cases that should not be allowed,
like replacing child nodes of
Philippe Mathieu-Daudé wrote:
> Fixes: 6105683da35
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/blkverify.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/block/blkverify.c b/block/blkverify.c
index 304b0a1368..0add3ab483 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -282,6 +282,2
Signed-off-by: Max Reitz
---
block/quorum.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index 17b439056f..3ece6e4382 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -813,6 +813,59 @@ static bool
quoru
Philippe Mathieu-Daudé wrote:
> Fixes: fc281c80202
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
All tearDowns in 041 shutdown the VM. Thus, test cases do not need to
do it themselves (unless they need the VM to be down for some
post-operation check).
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/041 | 11 ---
1 file changed, 11 deletion
It no longer has any users.
Signed-off-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c | 33 -
block/blkverify.c | 15 ---
block/copy-on-read.c | 9 -
block/filter-compress.c | 9 -
1 - 100 of 498 matches
Mail list logo
