Re: [RFC PATCH] hw/arm/virt: Support NMI injection

On Tue, 4 Feb 2020 14:51:39 +1100 Gavin Shan wrote: [...] > The mechanism I figured out is to inject SError to guest, as below snippet > shows. It > helps to get a panic and guest rebooting, which looks similar to what x86/p > pc have. I think being able to inject a SError is a reasonable thin

[PATCH] memory: Use QEMU_ALWAYS_INLINE to silence compile-time warning

Our robot reported the following compile-time warning while compiling Qemu with -fno-inline cflags: In function 'load_memop', inlined from 'load_helper' at /qemu/accel/tcg/cputlb.c:1578:20, inlined from 'full_ldub_mmu' at /qemu/accel/tcg/cputlb.c:1624:12: /qemu/accel/tcg/cputlb.c:1502:9: e

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

Daniel, Kevin, any comments or objections to the QAPI schema design sketch developed below? For your convenience, here's the result again: { 'enum': 'LUKSKeyslotState', 'data': [ 'active', 'inactive' ] } { 'struct': 'LUKSKeyslotActive', 'data': { 'secret': 'str',

Re: [PATCH 10/17] block: Add new BDRV_ZERO_OPEN flag

04.02.2020 20:50, Eric Blake wrote: On 2/4/20 11:34 AM, Max Reitz wrote: +++ b/include/block/block.h @@ -105,6 +105,16 @@ typedef enum {    * for drivers that set .bdrv_co_truncate.    */   BDRV_ZERO_TRUNCATE  = 0x2, + +    /* + * bdrv_known_zeroes() should include this bit

Re: [PATCH 00/17] Improve qcow2 all-zero detection

31.01.2020 20:44, Eric Blake wrote: Based-on: <20200124103458.1525982-2-david.edmond...@oracle.com> ([PATCH v2 1/2] qemu-img: Add --target-is-zero to convert) I'm working on adding an NBD extension that reports whether an image is already all zero when the client first connects. I initially tho

Re: [PATCH 00/17] Improve qcow2 all-zero detection

05.02.2020 12:04, Vladimir Sementsov-Ogievskiy wrote: 31.01.2020 20:44, Eric Blake wrote: Based-on: <20200124103458.1525982-2-david.edmond...@oracle.com> ([PATCH v2 1/2] qemu-img: Add --target-is-zero to convert) I'm working on adding an NBD extension that reports whether an image is already al

Re: VW ELF loader

On Wed, 5 Feb 2020 17:06:34 +1100 David Gibson wrote: > On Tue, Feb 04, 2020 at 12:26:32AM +0100, Paolo Bonzini wrote: > > You can generalize and reuse the s390 code. All you have to write is the > > PCI scan and virtio-pci setup. > > If we assume virtio only. In any case it sounds like the

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

Am 05.02.2020 um 09:24 hat Markus Armbruster geschrieben: > Daniel, Kevin, any comments or objections to the QAPI schema design > sketch developed below? > > For your convenience, here's the result again: > > { 'enum': 'LUKSKeyslotState', > 'data': [ 'active', 'inactive' ] } > { 'st

[RFC PATCH v2 3/9] memory: Hack - use shared memory when possible

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- hw/core/numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 0d1b4be..02fd7f5 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -785,8 +785,8 @@ static void allocate_syst

[RFC PATCH v2 0/9] Add an interVM memory sharing device

From: Igor Kotrasinski This patchset adds a "memory exposing" device that allows two QEMU instances to share arbitrary memory regions. Unlike ivshmem, it does not create a new region of memory that's shared between VMs, but instead allows one VM to access any memory region of the other VM we choo

[RFC PATCH v2 6/9] hw/misc/memexpose: Add memexpose pci device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 1 + hw/misc/memexpose/Makefile.objs | 1 + hw/misc/memexpose/memexpose-pci.c | 218 ++ 3 files changed, 220 insertions(+) create mode 100644 hw/misc/memexpo

Re: Need help understanding assertion fail.

On 2/3/20 4:37 PM, Wayne Li wrote: > Anyway that's the background.  The specific problem I'm having right now is I > get the following assertion error during some of the setup stuff our OS does > post boot-up (the OS is also custom-made): > > qemu_programs/qemu/tcg/ppc/tcg-target.inc.c:224: reloc_

[RFC PATCH v2 7/9] hw/misc/memexpose: Add memexpose memory region device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 2 + hw/misc/memexpose/Makefile.objs | 1 + hw/misc/memexpose/memexpose-memregion.c | 142 hw/misc/memexpose/memexpose-memregion.h | 41 + 4

[RFC PATCH v2 1/9] memory: Add function for finding flat memory ranges

From: Igor Kotrasinski Given an address this lets us find the largest contiguous memory range at that address. Signed-off-by: Igor Kotrasinski --- include/exec/memory.h | 19 + memory.c | 79 ++- 2 files changed, 97 inser

[RFC PATCH v2 2/9] memory: Support mmap offset for fd-backed memory regions

From: Igor Kotrasinski The memexpose device will receive shared memory from another VM and map parts of it as memory regions. For that, we need to be able to mmap the region at an offset from shared memory's start. Signed-off-by: Igor Kotrasinski --- backends/hostmem-memfd.c | 2 +- exec.c

[RFC PATCH v2 4/9] hw/misc/memexpose: Add documentation

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 5 ++ docs/specs/memexpose-spec.txt | 168 ++ 2 files changed, 173 insertions(+) create mode 100644 docs/specs/memexpose-spec.txt diff --git a/MAINTAINERS b/MAI

[RFC PATCH v2 9/9] hw/arm/virt: Hack in support for memexpose device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- hw/arm/virt.c | 110 +- include/hw/arm/virt.h | 5 +++ 2 files changed, 114 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f788fe2..ba35b21 100644

[RFC PATCH v2 8/9] hw/misc/memexpose: Add simple tests

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 1 + tests/qtest/Makefile.include | 2 + tests/qtest/memexpose-test.c | 364 +++ 3 files changed, 367 insertions(+) create mode 100644 tests/qtest/memexpose-tes

Re: [PATCH v3 00/18] APIC ID fixes for AMD EPYC CPU models

On Tue, 4 Feb 2020 13:08:58 -0600 Babu Moger wrote: > On 2/4/20 2:02 AM, Igor Mammedov wrote: > > On Mon, 3 Feb 2020 13:31:29 -0600 > > Babu Moger wrote: > > > >> On 2/3/20 8:59 AM, Igor Mammedov wrote: > >>> On Tue, 03 Dec 2019 18:36:54 -0600 > >>> Babu Moger wrote: > >>> > This

[RFC PATCH v2 5/9] hw/misc/memexpose: Add core memexpose files

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- Kconfig.host | 3 + MAINTAINERS| 4 + Makefile | 1 + configure | 8 + hw/mem/Kconfig | 3 + hw/misc/Makefile

Re: [PATCH] fence: introduce a file-based self-fence mechanism

Hey, sorry for the delay on following up on this. I picked it up again. Hopefully we can finalise quickly. > On Dec 5, 2019, at 2:22 PM, Felipe Franciosi wrote: > > Heya, > >> On Nov 26, 2019, at 12:18 PM, Marc-André Lureau >> wrote: >> >> On Mon, Nov 25, 2019 at 8:14 PM Felipe Franciosi wr

Re: [RFC PATCH v2 0/9] Add an interVM memory sharing device

Patchew URL: https://patchew.org/QEMU/1580895185-24341-1-git-send-email-i.kotrasi...@partner.samsung.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. =

[PATCH v2] fence: introduce a file-based self-fence mechanism

This introduces a self-fence mechanism to Qemu, causing it to die if a heartbeat condition is not met. Currently, a file-based heartbeat is available and can be configured as follows: -object file-fence,id=ff0,file=/foo,qtimeout=20,ktimeout=25,signal=kill Qemu will watch 'file' for attribute chan

Re: [PATCH] memory: Use QEMU_ALWAYS_INLINE to silence compile-time warning

On 2/5/20 8:17 AM, Zenghui Yu wrote: > Our robot reported the following compile-time warning while compiling > Qemu with -fno-inline cflags: Why are you doing this? > > In function 'load_memop', > inlined from 'load_helper' at /qemu/accel/tcg/cputlb.c:1578:20, > inlined from 'full_ldub_m

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

Kevin Wolf writes: > Am 05.02.2020 um 09:24 hat Markus Armbruster geschrieben: >> Daniel, Kevin, any comments or objections to the QAPI schema design >> sketch developed below? >> >> For your convenience, here's the result again: >> >> { 'enum': 'LUKSKeyslotState', >> 'data': [ 'activ

Re: [PATCH 1/3] m25p80: Convert to support tracing

On 2/3/20 7:09 PM, Guenter Roeck wrote: > While at it, add some trace messages to help debug problems > seen when running the latest Linux kernel. In case you resend, It would be nice to printout a flash id in the tracing else I have a patch for it on top of yours. It helped me track a squashfs co

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

On 2/4/20 3:28 PM, Guenter Roeck wrote: > On 2/4/20 12:53 AM, Cédric Le Goater wrote: >> On 2/3/20 7:09 PM, Guenter Roeck wrote: >>> Always report 6 bytes of JEDEC data. Fill remaining data with 0. >>> >>> For unsupported commands, keep sending a value of 0 until the chip >>> is deselected. >>> >>>

Re: [PATCH v2] fence: introduce a file-based self-fence mechanism

Patchew URL: https://patchew.org/QEMU/20200205095737.20153-1-fel...@nutanix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2] fence: introduce a file-based self-fence mechanism Message-id: 20200205095737.20153-1-fel...@nut

Re: [PATCH v2] fence: introduce a file-based self-fence mechanism

Patchew URL: https://patchew.org/QEMU/20200205095737.20153-1-fel...@nutanix.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test

On 2/4/20 9:45 PM, Alex Bennée wrote: >> Also, ZCR_EL1 it itself not correct if the >> hardware does not support all vector sizes. >> >> See some of Andrew Jones' qemu command-line work. Try -cpu max,sve512=on and >> then use the ioctl to set vq to 3 (sve384). The result will be an effective >>

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

On Wed, Feb 05, 2020 at 10:30:11AM +0100, Kevin Wolf wrote: > Am 05.02.2020 um 09:24 hat Markus Armbruster geschrieben: > > Daniel, Kevin, any comments or objections to the QAPI schema design > > sketch developed below? > > > > For your convenience, here's the result again: > > > > { 'enum':

Re: [PATCH v2] fence: introduce a file-based self-fence mechanism

Hi On Wed, Feb 5, 2020 at 10:57 AM Felipe Franciosi wrote: > > This introduces a self-fence mechanism to Qemu, causing it to die if a > heartbeat condition is not met. Currently, a file-based heartbeat is > available and can be configured as follows: > > -object file-fence,id=ff0,file=/foo,qtimeo

Re: [qemu-web PATCH] documentation: update links to readthedocs

On Mon, Feb 03, 2020 at 11:46:43AM +, Peter Maydell wrote: > On Wed, 15 Jan 2020 at 11:11, Stefan Hajnoczi wrote: > > The qemu.git/master docs are built nightly here (index.html is now > > visible!): > > https://www.qemu.org/docs/master/ > > > > qemu.org's docs are more useful at the moment si

Re: [PATCH] memory: Use QEMU_ALWAYS_INLINE to silence compile-time warning

On 2/5/20 10:01 AM, Richard Henderson wrote: > On 2/5/20 8:17 AM, Zenghui Yu wrote: >> Our robot reported the following compile-time warning while compiling >> Qemu with -fno-inline cflags: > > Why are you doing this? > >> >> In function 'load_memop', >> inlined from 'load_helper' at /qemu/ac

Re: [PATCH v2] fence: introduce a file-based self-fence mechanism

Patchew URL: https://patchew.org/QEMU/20200205095737.20153-1-fel...@nutanix.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [GSoC/Outreachy QEMU project proposal] Measure and Analyze QEMU Performance

On Tue, Feb 04, 2020 at 05:52:09PM +0100, Aleksandar Markovic wrote: > > > > Please go ahead and add this project idea to the wiki: > > https://wiki.qemu.org/Google_Summer_of_Code_2020#How_to_add_a_project_idea > > > > Hi, Stefan, > > I set up the proposal wiki page: > > https://wiki.qemu.org/Go

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

On Fri, Jan 31, 2020 at 09:37:04AM +0100, Laurent Vivier wrote: > Le 30/01/2020 à 12:52, Peter Maydell a écrit : > > On Thu, 30 Jan 2020 at 11:20, Laurent Vivier wrote: > >> > >> Le 30/01/2020 à 12:09, Aleksandar Markovic a écrit : > >>> Laurent, all this seems to be dependant on whether you are r

Re: [PATCH v2] fence: introduce a file-based self-fence mechanism

Heya, > On Feb 5, 2020, at 10:24 AM, Marc-André Lureau > wrote: > > Hi > > On Wed, Feb 5, 2020 at 10:57 AM Felipe Franciosi wrote: >> >> This introduces a self-fence mechanism to Qemu, causing it to die if a >> heartbeat condition is not met. Currently, a file-based heartbeat is >> available

Re: [PATCH RFC 0/2] docs: rstfy some s390 docs

On Tue, 28 Jan 2020 19:01:40 +0100 Cornelia Huck wrote: > https://qemu.readthedocs.io/en/latest/index.html collects various > documents from the QEMU docs/ subdirectory; however, none of the > s390 files are currently included. Therefore, I set out to convert > the existing files to rst and hook

Re: [PATCH 1/2] exec: flush CPU TB cache in breakpoint_invalidate

On 11/27/19 10:06 PM, Max Filippov wrote: > When a breakpoint is inserted at location for which there's currently no > virtual to physical translation no action is taken on CPU TB cache. If a > TB for that virtual address already exists but is not visible ATM the > breakpoint won't be hit next time

Re: [PATCH RFC 1/2] docs: rstfy s390 dasd ipl documentation

On 28/01/2020 19.01, Cornelia Huck wrote: > While at it, also fix the numbering in 'What QEMU does'. > > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 2 +- > docs/devel/index.rst | 1 + > .../{s390-dasd-ipl.txt => s390-dasd-ipl.r

[PATCH v4 1/1] qemu-img: Add --target-is-zero to convert

In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (reads as zero). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero, allowing the user to indicate that an exi

Re: [PATCH] tcg: gdbstub: Fix missing breakpoint issue

On 1/24/20 2:17 AM, Changbin Du wrote: > When inserting breakpoints, we need to invalidate related TBs to apply > helper call. This is done by breakpoint_invalidate(). But many users > found the BPs sometimes never hit. > > In system mode emulation, the BPs are global in guest but not particular >

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

Am 05.02.2020 um 11:03 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 05.02.2020 um 09:24 hat Markus Armbruster geschrieben: > >> Daniel, Kevin, any comments or objections to the QAPI schema design > >> sketch developed below? > >> > >> For your convenience, here's the result a

[PATCH 3/5] ui/sdl: implement show-cursor option

Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9030f1c42efb..e18555b10a42 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -161,9 +161,15 @@ static void sdl_update_caption(struct sdl

[PATCH 1/5] ui: add show-cursor option

When enabled forces showing a the mouse cursor, i.e. do nowallow the guest to hide it. Defaults to off. Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index e04525d8b44b..7c516a455631 100644 --- a/qapi/ui.json +++

[PATCH v4 0/1] qemu-img: Add --target-is-zero to indicate that a target is blank

qemu-img: Add --target-is-zero to indicate that a target is blank v4: - Wording in the doc and error message. v3: - Merge with the rST docs. - No more need to fix @var -> @code. v2: - Remove target_is_zero, preferring to set has_zero_init directly (Mark Kanda). - Disallow --target-is-zero in

[PATCH 0/5] ui: rework -show-cursor option

Gerd Hoffmann (5): ui: add show-cursor option ui/gtk: implement show-cursor option ui/sdl: implement show-cursor option ui: wire up legacy -show-cursor option ui: deprecate legacy -show-cursor option include/sysemu/sysemu.h | 1 - ui/gtk.c| 8 +++- ui/sdl2.c

[PATCH 2/5] ui/gtk: implement show-cursor option

Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index d18892d1de61..78b197ade4c1 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -247,6 +247,7 @@ static void gd_update_cursor(VirtualConsole *vc) { GtkDisplaySta

Re: [PATCH RFC 2/2] docs: rstfy vfio-ap documentation

On 28/01/2020 19.01, Cornelia Huck wrote: > Move to system/, as this is mostly about configuring vfio-ap. > > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 2 +- > docs/system/index.rst| 1 + > docs/{vfio-ap.txt => system/vfio-ap.rst} | 7

[PATCH 4/5] ui: wire up legacy -show-cursor option

Signed-off-by: Gerd Hoffmann --- include/sysemu/sysemu.h | 1 - vl.c| 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 80c57fdc4e64..da2f87c3e63a 100644 --- a/include/sysemu/sysemu.h +++ b/include/sy

[PATCH 5/5] ui: deprecate legacy -show-cursor option

Signed-off-by: Gerd Hoffmann --- vl.c | 2 ++ qemu-deprecated.texi | 5 + 2 files changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 0db0aa0fa040..71d040257b34 100644 --- a/vl.c +++ b/vl.c @@ -3552,6 +3552,8 @@ int main(int argc, char **argv, char **envp)

[RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

This allows to inject SError interrupt, which will be used on receiving QMP/HMP "nmi" command in next patch. Signed-off-by: Gavin Shan --- target/arm/cpu.c| 11 +++ target/arm/cpu.h| 12 +--- target/arm/helper.c | 4 3 files changed, 24 insertions(+), 3 deletions(-)

[RESEND RFC PATCH v2 0/2] Support NMI Injection

This intends to support HMP/QMP "nmi" command. When it's issued, the SError interrupt is injected to the guest. The guest is expected to crash with it. The behavior is similar to x86: NMI is injected to guest as error indication. The guest possiblly crashes and reboots with the injected NMI. Note t

[RESEND RFC PATCH v2 2/2] target/arm: Support NMI injection

This supports QMP/HMP "nmi" command by injecting SError interrupt to guest, which is expected to crash with that. Currently, It's supported on two CPU models: "host" and "max". Signed-off-by: Gavin Shan --- hw/arm/virt.c | 18 target/arm/cpu-qom.h | 1 + target/arm/c

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

On Tue, Jan 28, 2020 at 09:48:33PM +0100, Aleksandar Markovic wrote: > How about this: Thank you! I have posted the idea here: https://wiki.qemu.org/Google_Summer_of_Code_2020#Extend_linux-user_syscalls_and_ioctls Stefan signature.asc Description: PGP signature

Re: [PATCH 5/5] ui: deprecate legacy -show-cursor option

On Wed, Feb 05, 2020 at 12:03:56PM +0100, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- vl.c | 2 ++ qemu-deprecated.texi | 5 + 2 files changed, 7 insertions(+) libvirt does not use -show-cursor Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote: > > > On 30.01.2020 17:58, Stefan Hajnoczi wrote: > > On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote: > > > The goal is to reduce the amount of requests issued by a guest on > > > 1M reads/writes. This rises the per

[PATCH v4 05/10] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t

We are going to introduce bdrv_dirty_bitmap_next_dirty so that same variable may be used to store its return value and to be its parameter, so it would int64_t. Similarly, we are going to refactor hbitmap_next_dirty_area to use hbitmap_next_dirty together with hbitmap_next_zero, therefore we want

[PATCH v4 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c

The function is definitely internal (it's not used by third party and it has complicated interface). Move it to .c file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/qemu/hbitmap.h | 30 -- util/hbitmap.c | 29 +++

[PATCH v4 10/10] block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty

store_bitmap_data() loop does bdrv_set_dirty_iter() on each iteration, which means that we actually don't need iterator itself and we can use simpler bitmap API. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 15 +-- 1 file changed, 5 i

[PATCH v4 01/10] hbitmap: assert that we don't create bitmap larger than INT64_MAX

We have APIs which returns signed int64_t, to be able to return error. Therefore we can't handle bitmaps with absolute size larger than (INT64_MAX+1). Still, keep maximum to be INT64_MAX which is a bit safer. Note, that bitmaps are used to represent disk images, which can't exceed INT64_MAX anyway

[PATCH v4 00/10] Further bitmaps improvements

Hi! The main feature here is improvement of _next_dirty_area API, which I'm going to use then for backup / block-copy. Somehow, I thought that it was merged, but seems I even forgot to send v4. v4: 01-04: add Max's r-b 05: switch test_hbitmap_next_zero_check_range args to int64_t too 06: fix s/U

[PATCH v4 08/10] nbd/server: introduce NBDExtentArray

Introduce NBDExtentArray class, to handle extents list creation in more controlled way and with fewer OUT parameters in functions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 210 +-- 1 file changed, 118 insertions(+), 92 deletio

[PATCH v4 03/10] hbitmap: unpublish hbitmap_iter_skip_words

Function is internal and even commented as internal. Drop its definition from .h file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/qemu/hbitmap.h | 7 --- util/hbitmap.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/include/

[PATCH v4 04/10] hbitmap: drop meta bitmaps as they are unused

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/qemu/hbitmap.h | 21 tests/test-hbitmap.c | 115 - util/hbitmap.c | 16 -- 3 files changed, 152 deletions(-) diff --git a/include/qemu/hbitmap.h b/incl

[PATCH v4 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area

Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface, we'll never exceed requested region with last chunk. So, we don't need dont_fragment, and bitmap_to_extents() interface becomes clean enough to not require any com

Re: [PATCH v4 1/1] qemu-img: Add --target-is-zero to convert

05.02.2020 14:02, David Edmondson wrote: In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (reads as zero). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero

[PATCH v4 06/10] block/dirty-bitmap: add _next_dirty API

We have bdrv_dirty_bitmap_next_zero, let's add corresponding bdrv_dirty_bitmap_next_dirty, which is more comfortable to use than bitmap iterators in some cases. For test modify test_hbitmap_next_zero_check_range to check both next_zero and next_dirty and add some new checks. Signed-off-by: Vladim

[PATCH v4 07/10] block/dirty-bitmap: improve _next_dirty_area API

Firstly, _next_dirty_area is for scenarios when we may contiguously search for next dirty area inside some limited region, so it is more comfortable to specify "end" which should not be recalculated on each iteration. Secondly, let's add a possibility to limit resulting area size, not limiting sea

Re: [PATCH v8 03/21] fuzz: add FUZZ_TARGET module type

On Wed, Jan 29, 2020 at 05:34:13AM +, Bulekov, Alexander wrote: Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi Reviewed-by: Darren Kenny --- include/qemu/module.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qemu/module.h b/include/qemu/m

Re: [PATCH v8 05/21] libqtest: add a layer of abstraction to send/recv

On Wed, Jan 29, 2020 at 05:34:15AM +, Bulekov, Alexander wrote: This makes it simple to swap the transport functions for qtest commands to and from the qtest client. For example, now it is possible to directly pass qtest commands to a server handler that exists within the same process, withou

Re: [PATCH v8 04/21] qtest: add qtest_server_send abstraction

On Wed, Jan 29, 2020 at 05:34:14AM +, Bulekov, Alexander wrote: qtest_server_send is a function pointer specifying the handler used to transmit data to the qtest client. In the standard configuration, this calls the CharBackend handler, but now it is possible for other types of handlers, e.g

Re: [PATCH v2 4/7] block/block-copy: refactor interfaces to use bytes instead of end

29.01.2020 20:12, Andrey Shinkevich wrote: On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: We have a lot of "chunk_end - start" invocations, let's switch to bytes/cur_bytes scheme instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 4 +-- bloc

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

On Tue, Feb 04, 2020 at 11:35:37AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 04, 2020 at 05:13:54PM +0100, Julia Suvorova wrote: > > On Tue, Feb 4, 2020 at 11:26 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > > > > 3) qemu could add a "

Re: [PATCH v8 07/21] qtest: add in-process incoming command handler

On Wed, Jan 29, 2020 at 05:34:17AM +, Bulekov, Alexander wrote: The handler allows a qtest client to send commands to the server by directly calling a function, rather than using a file/CharBackend Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi Reviewed-by: Darren Kenny

Re: [PATCH v8 06/21] libqtest: make bufwrite rely on the TransportOps

On Wed, Jan 29, 2020 at 05:34:16AM +, Bulekov, Alexander wrote: When using qtest "in-process" communication, qtest_sendf directly calls a function in the server (qtest.c). Previously, bufwrite used socket_send, which bypasses the TransportOps enabling the call into qtest.c. This change replac

Re: [PATCH v8 08/21] libqos: rename i2c_send and i2c_recv

On Wed, Jan 29, 2020 at 05:34:18AM +, Bulekov, Alexander wrote: The names i2c_send and i2c_recv collide with functions defined in hw/i2c/core.c. This causes an error when linking against libqos and softmmu simultaneously (for example when using qtest inproc). Rename the libqos functions to av

Re: [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test

On Wed, Feb 05, 2020 at 10:19:08AM +, Richard Henderson wrote: > On 2/4/20 9:45 PM, Alex Bennée wrote: > >> Also, ZCR_EL1 it itself not correct if the > >> hardware does not support all vector sizes. > >> > >> See some of Andrew Jones' qemu command-line work. Try -cpu max,sve512=on > >> and >

Re: [PATCH v8 11/21] fuzz: add fuzzer skeleton

Hi Alex, On Wed, Jan 29, 2020 at 05:34:20AM +, Bulekov, Alexander wrote: tests/fuzz/fuzz.c serves as the entry point for the virtual-device fuzzer. Namely, libfuzzer invokes the LLVMFuzzerInitialize and LLVMFuzzerTestOneInput functions, both of which are defined in this file. This change add

Re: [PATCH v8 12/21] exec: keep ram block across fork when using qtest

On Wed, Jan 29, 2020 at 05:34:21AM +, Bulekov, Alexander wrote: Ram blocks were marked MADV_DONTFORK breaking fuzzing-tests which execute each test-input in a forked process. Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi Reviewed-by: Darren Kenny --- exec.c | 12 ++

Re: Making QEMU easier for management tools and applications

Am 28.01.2020 um 11:59 hat Kevin Wolf geschrieben: > > > The other part that it needs to solve is how to be available by default > > > without specifying anything on the command line. Basically, if I press > > > Ctrl-Alt-2, I want to get to a monitor shell. If that shell is > > > implemented intern

Re: [PATCH 3/3] stellaris: delay timer_new to avoid memleaks

On 2/5/20 8:06 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = stellaris-gptm. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

On Wed, Feb 05, 2020 at 11:36:37AM +, Daniel P. Berrangé wrote: > On Tue, Feb 04, 2020 at 11:35:37AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 04, 2020 at 05:13:54PM +0100, Julia Suvorova wrote: > > > On Tue, Feb 4, 2020 at 11:26 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mo

Re: [PATCH 0/3] delay timer_new to avoid memleaks

On 2/5/20 8:06 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan This series delay timer_new into realize() to fix some memleaks when we call 'device-list-properties'. Pan Nengyuan (3): armv7m_systick: delay timer_new to avoid memleaks stm32f2xx_timer: delay timer_new to avoid memlea

Re: [RFC v2 00/14] Add SDEI support for arm64

Hi Heyi, On 2020-02-04 08:26, Heyi Guo wrote: Update Marc's email address. +cc Gavin as he is posting a RFC for ARM NMI. Hi Marc, Really sorry for missing to update your email address, for the initial topic was raised long time ago and I forgot to update the Cc list in the commit message of t

Re: [PATCH 2/3] stm32f2xx_timer: delay timer_new to avoid memleaks

On 2/5/20 8:06 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = stm32f2xx_timer. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments":

Re: [PATCH v8 15/21] fuzz: add support for qos-assisted fuzz targets

On Wed, Jan 29, 2020 at 05:34:24AM +, Bulekov, Alexander wrote: Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- tests/qtest/fuzz/Makefile.include | 2 + tests/qtest/fuzz/qos_fuzz.c | 229 ++ tests/qtest/fuzz/qos_fuzz.h | 33 + 3

Re: [PATCH v8 17/21] fuzz: add configure flag --enable-fuzzing

On Wed, Jan 29, 2020 at 05:34:25AM +, Bulekov, Alexander wrote: Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Darren Kenny --- configure | 39 +++ 1 file changed, 39 insertions(+) diff

Re: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend

On 2/4/20 11:05 PM, Paolo Bonzini wrote: Sure! I probably won't send a pull request for a week or so though. Eh I need to rush to get my raspi series fixed/reviewed/merged before that :( Paolo Il mar 4 feb 2020, 16:39 Igor Mammedov > ha scritto: On Tue, 4

Re: [PULL 19/35] ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge

On 03/02/2020 07:11, David Gibson wrote: > From: Benjamin Herrenschmidt > > These changes introduces models for the PCIe Host Bridge (PHB4) of the > POWER9 processor. It includes the PowerBus logic interface (PBCQ), > IOMMU support, a single PCIe Gen.4 Root Complex, and support for MSI > and LSI

Re: [PATCH v8 18/21] fuzz: add i440fx fuzz targets

On Wed, Jan 29, 2020 at 05:34:26AM +, Bulekov, Alexander wrote: These three targets should simply fuzz reads/writes to a couple ioports, but they mostly serve as examples of different ways to write targets. They demonstrate using qtest and qos for fuzzing, as well as using rebooting and forki

[RFC PATCH v3 9/9] hw/arm/virt: Hack in support for memexpose device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- hw/arm/virt.c | 110 +- include/hw/arm/virt.h | 5 +++ 2 files changed, 114 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f788fe2..ba35b21 100644

[RFC PATCH v3 3/9] memory: Hack - use shared memory when possible

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- hw/core/numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 0d1b4be..02fd7f5 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -785,8 +785,8 @@ static void allocate_syst

[RFC PATCH v3 6/9] hw/misc/memexpose: Add memexpose pci device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 1 + hw/misc/memexpose/Makefile.objs | 1 + hw/misc/memexpose/memexpose-pci.c | 218 ++ 3 files changed, 220 insertions(+) create mode 100644 hw/misc/memexpo

[RFC PATCH v3 0/9] Add an interVM memory sharing device

From: Igor Kotrasinski This patchset adds a "memory exposing" device that allows two QEMU instances to share arbitrary memory regions. Unlike ivshmem, it does not create a new region of memory that's shared between VMs, but instead allows one VM to access any memory region of the other VM we choo

[RFC PATCH v3 2/9] memory: Support mmap offset for fd-backed memory regions

From: Igor Kotrasinski The memexpose device will receive shared memory from another VM and map parts of it as memory regions. For that, we need to be able to mmap the region at an offset from shared memory's start. Signed-off-by: Igor Kotrasinski --- backends/hostmem-memfd.c | 2 +- exec.c

[RFC PATCH v3 8/9] hw/misc/memexpose: Add simple tests

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 1 + tests/qtest/Makefile.include | 2 + tests/qtest/memexpose-test.c | 364 +++ 3 files changed, 367 insertions(+) create mode 100644 tests/qtest/memexpose-tes

[RFC PATCH v3 7/9] hw/misc/memexpose: Add memexpose memory region device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 2 + hw/misc/memexpose/Makefile.objs | 1 + hw/misc/memexpose/memexpose-memregion.c | 142 hw/misc/memexpose/memexpose-memregion.h | 41 + 4

[RFC PATCH v3 1/9] memory: Add function for finding flat memory ranges

From: Igor Kotrasinski Given an address this lets us find the largest contiguous memory range at that address. Signed-off-by: Igor Kotrasinski --- include/exec/memory.h | 19 + memory.c | 79 ++- 2 files changed, 97 inser

  1   2   3   4   >