[PULL v2 2/3] target/mips: Separate CP0-related helpers into their own file

From: Aleksandar Markovic For clarity and easier maintenence, create target/mips/cp0_helper.c, and move all CP0-related content form target/mips/op_helper.c to that file. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1580745443-24650-2-git-send-email-aleksandar

[PULL v2 1/3] target/mips: Fix handling of LL/SC instructions after 7dd547e5ab

From: Alex Richardson After 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f the env->llval value is loaded as an unsigned value (instead of sign-extended as before). Therefore, the CMPXCHG in gen_st_cond() in translate.c fails if the sign bit is set in the loaded value. Fix this by sign-extending the l

[PULL v2 0/3] MIPS queue for February 4th, 2020

From: Aleksandar Markovic The following changes since commit f31160c7d1b89cfb4dd4001a23575b42141cb0ec: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20200203' into staging (2020-02-03 11:14:24 +) are available in the git repository at: https://github.com/AMarkovic/qemu

Re: [PATCH v3 00/18] APIC ID fixes for AMD EPYC CPU models

On Mon, 3 Feb 2020 13:31:29 -0600 Babu Moger wrote: > On 2/3/20 8:59 AM, Igor Mammedov wrote: > > On Tue, 03 Dec 2019 18:36:54 -0600 > > Babu Moger wrote: > > > >> This series fixes APIC ID encoding problems on AMD EPYC CPUs. > >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2

Re: [PULL 3/3] target/mips: Separate FPU-related helpers into their own file

> > > > For clarity and easier maintenence, create target/mips/fpu_helper.c, and > > move all FPU-related content form target/mips/op_helper.c to that file. > > > > Signed-off-by: Aleksandar Markovic > > Reviewed-by: Aleksandar Rikalo > > Message-Id: > > <1580745443-24650-3-git-send-email-aleks

Re: [PULL v2 0/3] MIPS queue for February 4th, 2020

Patchew URL: https://patchew.org/QEMU/1580803317-4422-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL v2 0/3] MIPS queue for February 4th, 2020 Message-id: 1580803317-4422-1-git-sen

Re: [PULL 0/3] MIPS queue for February 4th, 2020

On Tue, Feb 4, 2020 at 7:43 AM Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit f31160c7d1b89cfb4dd4001a23575b42141cb0ec: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20200203' > into staging (2020-02-03 11:14:24 +) > > ar

Re: Does Libvirt's json parser support single quoted string in qmp json string?

Eric Blake writes: > [adding Markus] > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: >>> On 1/31/20 4:38 AM, Peter Luo wrote: >>> error: internal error: cannot parse json {"execute": "block-commit", "arguments": { "device"

Re: [PATCH v4 00/11] RFC: [for 5.0]: HMP monitor handlers refactoring

On Mon, 2020-02-03 at 19:57 +, Dr. David Alan Gilbert wrote: > * Maxim Levitsky (mlevi...@redhat.com) wrote: > > This patch series is bunch of cleanups to the hmp monitor code. > > It mostly moves the blockdev related hmp handlers to its own file, > > and does some minor refactoring. > > > > N

Re: [RFC v2 00/14] Add SDEI support for arm64

Update Marc's email address. +cc Gavin as he is posting a RFC for ARM NMI. Hi Marc, Really sorry for missing to update your email address, for the initial topic was raised long time ago and I forgot to update the Cc list in the commit message of the patches. Thanks Gavin for forwarding curr

Re: [PULL 3/3] target/mips: Separate FPU-related helpers into their own file

On 2/4/20 9:06 AM, Aleksandar Markovic wrote: > > For clarity and easier maintenence, create target/mips/fpu_helper.c, and > > move all FPU-related content form target/mips/op_helper.c to that file. > > > > Signed-off-by: Aleksandar Markovic > > Reviewed-by: Aleksandar Rikalo > > Message

Re: Improving QOM documentation [Was: Re: Making QEMU easier for management tools and applications]

Paolo Bonzini writes: > On 03/02/20 10:54, Markus Armbruster wrote: >>> Types are documented as above; however types other than link<> and >>> child<>, which are QAPI types, can be user-defined types (structs, >>> enums) and this is not included in (1). >> Specifically, three of four kinds of t

[PULL v2 00/14] qtests, kconfig and misc patches

Hi Peter, the following changes since commit f31160c7d1b89cfb4dd4001a23575b42141cb0ec: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20200203' into staging (2020-02-03 11:14:24 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reques

Re: [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands

On 2/3/20 7:09 PM, Guenter Roeck wrote: > Always report 6 bytes of JEDEC data. Fill remaining data with 0. > > For unsupported commands, keep sending a value of 0 until the chip > is deselected. > > Both changes avoid attempts to decode random commands. Up to now this > happened if the reported J

[PULL v2 14/14] configure: Fix typo of the have_afalg variable

The variable is called 'have_afalg' and not 'hava_afalg'. Fixes: f0d92b56d88 ('introduce some common functions for af_alg backend') Message-Id: <20200203160046.23194-1-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Longpeng(Mike) Signed-off-by

[PULL v2 11/14] Makefile: Do not use wildcard hw/*/Kconfig as input for minikconf

The hw/*/Kconfig files should be sourced from hw/Kconfig, so there is no need to pass them along as input files to minikconfig. We should use the hw/*/Kconfig wildcard only for build dependencies in the Makefile. With this change, there are now no duplicate entries in the generated *-softmmu/confi

Re: [PATCH] migration: Optimization about wait-unplug migration state

Keqian Zhu wrote: > qemu_savevm_nr_failover_devices() is originally designed to > get the number of failover devices, but it actually returns > the number of "unplug-pending" failover devices now. Moreover, > what drives migration state to wait-unplug should be the number > of "unplug-pending" fai

Restrictions of libnet (was: Re: VW ELF loader)

On 04/02/2020 09.54, Cornelia Huck wrote: > On Tue, 4 Feb 2020 07:16:46 +0100 > Thomas Huth wrote: > >> On 04/02/2020 00.26, Paolo Bonzini wrote: >>> >>> >>> Il mar 4 feb 2020, 00:20 Alexey Kardashevskiy >> > ha scritto: >>> >>> Speaking seriously, what would I put into

[Bug 1861404] Re: AVX instruction VMOVDQU implementation error for YMM registers

Thanks for your answers. I thought the fact that there was not any warning/exception meant that VMOVDQU was supported, but if it's mistakenly interpreted as MOVDQU then I understand. I read the mailing list messages on the AVX GSoC you point out, but couldn't find any branch where this work is lo

Re: Does Libvirt's json parser support single quoted string in qmp json string?

On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > [adding Markus] > > > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: > >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > >>> On 1/31/20 4:38 AM, Peter Luo wrote: > >>> > error: intern

Re: Does Libvirt's json parser support single quoted string in qmp json string?

On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > [adding Markus] > > > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: > >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > >>> On 1/31/20 4:38 AM, Peter Luo wrote: > >>> > error: intern

Re: Restrictions of libnet (was: Re: VW ELF loader)

On 04/02/2020 10.20, Thomas Huth wrote: [...] > So IMHO the s390x world should move towards grub2, too. We could e.g. > link it initially into the s390-ccw bios bios ... and if that works out > well, later also use it as normal bootloader instead of zipl I meant to say "use it as normal bootloader

Re: [PATCH v3 09/21] quorum: Add QuorumChild.to_be_replaced

31.01.2020 0:44, Max Reitz wrote: We will need this to verify that Quorum can let one of its children be replaced without breaking anything else. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: Restrictions of libnet (was: Re: VW ELF loader)

Hello, On Tue, Feb 04, 2020 at 10:20:14AM +0100, Thomas Huth wrote: > > So IMHO the s390x world should move towards grub2, too. We could e.g. > link it initially into the s390-ccw bios bios ... and if that works out > well, later also use it as normal bootloader instead of zipl (not sure > if th

Re: [PATCH v3 10/21] quorum: Implement .bdrv_recurse_can_replace()

31.01.2020 0:44, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: VW ELF loader

On 01.02.20 20:04, Paolo Bonzini wrote: > On 01/02/20 14:39, Alexey Kardashevskiy wrote: >> QEMU needs to load GRUB from the disk. The current workaround is to read >> it from qcow2, save in a file and then call load_elf(). Not nice. >> >> 2 problems with that. >> >> 1. when load_elf calls addre

Re: [PATCH v3 12/21] block: Remove bdrv_recurse_is_first_non_filter()

31.01.2020 0:44, Max Reitz wrote: It no longer has any users. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH v5 03/26] nvme: move device parameters to separate struct

Move device configuration parameters to separate struct to make it explicit what is configurable and what is set internally. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 44 ++-- hw/block/nvme.h | 16 +--- 2 files changed, 35 insertions(+)

[PATCH v5 06/26] nvme: refactor nvme_addr_read

Pull the controller memory buffer check to its own function. The check will be used on its own in later patches. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 9abf74d

[PATCH v5 04/26] nvme: add missing fields in the identify data structures

Not used by the device model but added for completeness. See NVM Express 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Figure 93. Signed-off-by: Klaus Jensen --- include/block/nvme.h | 48 1 file changed, 40 insertions(+), 8 deletions(-) di

[PATCH v5 02/26] nvme: remove superfluous breaks

These break statements was left over when commit 3036a626e9ef ("nvme: add Get/Set Feature Timestamp support") was merged. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index dd548d9b6605..c9ad6aaa5f95 1006

[PATCH v5 05/26] nvme: populate the mandatory subnqn and ver fields

Required for compliance with NVMe revision 1.2.1 or later. See NVM Express 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Section 7.9 ("NVMe Qualified Names"). This also bumps the supported version to 1.2.1. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 13 ++--- 1 file cha

[PATCH v5 13/26] nvme: additional tracing

Add a trace call for nvme_enqueue_req_completion. Also, streamline nvme_identify_ns and nvme_identify_ns_list. They do not need to repeat the command, it is already in the trace name. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 8 +--- hw/block/trace-events | 5 +++-- 2 files ch

[PATCH v5 19/26] pci: pass along the return value of dma_memory_rw

The nvme device needs to know the return value of dma_memory_rw to pass block/011 from blktests. So pass it along instead of ignoring it. There are no existing users of the return value, so this patch should be safe. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: M

[PATCH v5 07/26] nvme: add support for the abort command

Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.1 ("Abort command"). The Abort command is a best effort command; for now, the device always fails to abort the given command. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 28 1 f

[PATCH v5 14/26] nvme: make sure ncqr and nsqr is valid

0x is not an allowed value for NCQR and NSQR in Set Features on Number of Queues. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 30c5b3e7a67d..900732bb2f38 100644 --- a/hw/block/nvme.c +++ b/hw/b

[PATCH v5 08/26] nvme: refactor device realization

This patch splits up nvme_realize into multiple individual functions, each initializing a different subset of the device. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 175 +++- hw/block/nvme.h | 21 ++ 2 files changed, 133 insertions(+), 63 d

[PATCH v5 16/26] nvme: refactor prp mapping

Refactor nvme_map_prp and allow PRPs to be located in the CMB. The logic ensures that if some of the PRP is in the CMB, all of it must be located there, as per the specification. Also combine nvme_dma_{read,write}_prp into a single nvme_dma_prp that takes an additional DMADirection parameter. Sig

[PATCH v5 01/26] nvme: rename trace events to nvme_dev

Change the prefix of all nvme device related trace events to 'nvme_dev' to not clash with trace events from the nvme block driver. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 185 +- hw/block/trace-events | 172 +++--

[PATCH v5 09/26] nvme: add temperature threshold feature

It might seem wierd to implement this feature for an emulated device, but it is mandatory to support and the feature is useful for testing asynchronous event request support, which will be added in a later patch. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 50 +

[PATCH v5 12/26] nvme: add missing mandatory features

Add support for returning a resonable response to Get/Set Features of mandatory features. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 57 --- hw/block/trace-events | 2 ++ include/block/nvme.h | 3 ++- 3 files changed, 58 insertions(+), 4 de

[PATCH v5 23/26] pci: allocate pci id for nvme

The emulated nvme device (hw/block/nvme.c) is currently using an internal Intel device id. Prepare to change that by allocating a device id under the 1b36 (Red Hat, Inc.) vendor id. Signed-off-by: Klaus Jensen --- MAINTAINERS| 1 + docs/specs/nvme.txt| 10 ++ docs/specs

[PATCH v5 24/26] nvme: change controller pci id

There are two reasons for changing this: 1. The nvme device currently uses an internal Intel device id. 2. Since commits "nvme: fix write zeroes offset and count" and "nvme: support multiple namespaces" the controller device no longer has the quirks that the Linux kernel think it ha

[PATCH v5 21/26] nvme: add support for scatter gather lists

For now, support the Data Block, Segment and Last Segment descriptor types. See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). Signed-off-by: Klaus Jensen Acked-by: Fam Zheng --- block/nvme.c | 18 +- hw/block/nvme.c | 375 +++--

[PATCH v5 17/26] nvme: allow multiple aios per command

This refactors how the device issues asynchronous block backend requests. The NvmeRequest now holds a queue of NvmeAIOs that are associated with the command. This allows multiple aios to be issued for a command. Only when all requests have been completed will the device post a completion queue entr

Re: [PATCH v3 21/21] iotests: Check that @replaces can replace filters

31.01.2020 0:44, Max Reitz wrote: Signed-off-by: Max Reitz You forget my r-b: Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH v5 10/26] nvme: add support for the get log page command

Add support for the Get Log Page command and basic implementations of the mandatory Error Information, SMART / Health Information and Firmware Slot Information log pages. In violation of the specification, the SMART / Health Information log page does not persist information over the lifetime of th

[PATCH v3 0/1] qemu-img: Add --target-is-zero to indicate that a target is blank

qemu-img: Add --target-is-zero to indicate that a target is blank v3: - Merge with the rST docs. - No more need to fix @var -> @code. v2: - Remove target_is_zero, preferring to set has_zero_init directly (Mark Kanda). - Disallow --target-is-zero in the presence of a backing file (Max Reitz)

[PATCH v5 20/26] nvme: handle dma errors

Handling DMA errors gracefully is required for the device to pass the block/011 test ("disable PCI device while doing I/O") in the blktests suite. With this patch the device passes the test by retrying "critical" transfers (posting of completion entries and processing of submission queue entries).

[PATCH v5 00/26] nvme: support NVMe v1.3d, SGLs and multiple namespaces

Hi, Changes since v4 - Changed vendor and device id to use a Red Hat allocated one. For backwards compatibility add the 'x-use-intel-id' nvme device parameter. This is off by default but is added as a machine compat property to be true for machine types <= 4.2. - SGL mapping code has

[PATCH v5 11/26] nvme: add support for the asynchronous event request command

Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.2 ("Asynchronous Event Request command"). Mostly imported from Keith's qemu-nvme tree. Modified with a max number of queued events (controllable with the aer_max_queued device parameter). The spec states that the co

[PATCH v5 26/26] nvme: make lba data size configurable

Signed-off-by: Klaus Jensen --- hw/block/nvme-ns.c | 2 +- hw/block/nvme-ns.h | 4 +++- hw/block/nvme.c| 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index 0e5be44486f4..981d7101b8f2 100644 --- a/hw/block/nvme-ns.c +++ b/hw/block/

Re: [PATCH v2 1/2] qemu-img: Add --target-is-zero to convert

On Monday, 2020-02-03 at 21:20:16 +03, Vladimir Sementsov-Ogievskiy wrote: > 24.01.2020 13:34, David Edmondson wrote: >> In many cases the target of a convert operation is a newly provisioned >> target that the user knows is blank (filled with zeroes). In this >> situation there is no requirement

[PATCH v5 18/26] nvme: use preallocated qsg/iov in nvme_dma_prp

Since clean up of the request qsg/iov has been moved to the common nvme_enqueue_req_completion function, there is no need to use a stack allocated qsg/iov in nvme_dma_prp. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) d

Re: Making QEMU easier for management tools and applications

Andrea Bolognani writes: > On Fri, 2020-01-31 at 07:50 +0100, Markus Armbruster wrote: >> Kevin Wolf writes: >> > Much of this threads plays with the though that maybe we don't need any >> > compatibility and make the radical conclusion that we don't need any >> > human-friendly interface at all

[PATCH v5 15/26] nvme: bump supported specification to 1.3

Add new fields to the Identify Controller and Identify Namespace data structures accoding to NVM Express 1.3d. NVM Express 1.3d requires the following additional features: - addition of the Namespace Identification Descriptor List (CNS 03h) for the Identify command - support for returning

[PATCH v5 22/26] nvme: support multiple namespaces

This adds support for multiple namespaces by introducing a new 'nvme-ns' device model. The nvme device creates a bus named from the device name ('id'). The nvme-ns devices then connect to this and registers themselves with the nvme device. This changes how an nvme device is created. Example with t

[PATCH v3 1/1] qemu-img: Add --target-is-zero to convert

In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero, allowing the user to indicate that a

[PATCH v5 25/26] nvme: remove redundant NvmeCmd pointer parameter

The command struct is available in the NvmeRequest that we generally pass around anyway. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 198 1 file changed, 98 insertions(+), 100 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c inde

Re: [PATCH v3 18/21] iotests: Resolve TODOs in 041

31.01.2020 0:44, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 2/4] linux-user: Use `qemu_log' for strace

Le 04/02/2020 à 03:55, Josh Kunz a écrit : > On Tue, Jan 28, 2020 at 7:07 AM Laurent Vivier wrote: >> >> Le 17/01/2020 à 20:28, Josh Kunz a écrit : >>> This change switches linux-user strace logging to use the newer `qemu_log` >>> logging subsystem rather than the older `gemu_log` (notice the "g")

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

On 30.01.2020 17:58, Stefan Hajnoczi wrote: On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote: The goal is to reduce the amount of requests issued by a guest on 1M reads/writes. This rises the performance up to 4% on that kind of disk access pattern. The maximum chunk size to b

Re: [PATCH] ui/cocoa: Drop workarounds for pre-10.12 OSX

On Mon, 3 Feb 2020 at 19:59, G 3 wrote: >> Our official OSX support policy covers the last two released versions. >> Currently that is 10.14 and 10.15. We also may work on older versions, but >> don't guarantee it. >> >> In commit 50290c002c045280f8d in mid-2019 we introduced some uses of >> CLOC

Re: Need help understanding assertion fail.

On Mon, 3 Feb 2020 at 21:32, Wayne Li wrote: > > I see. So you're saying that it might be possible that my guest could be > generating TCG ops that can't be translated into PPC instructions because the > displacement value is to big. While the same TCG ops can be translated into > x86 instruc

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

On Tue, 4 Feb 2020 at 03:51, Gavin Shan wrote: > Note: I'm still investigating the code to see how SError can be injected when > TCG > is used. I think we need same function when TCG is enabled, or it's something > for > future. TCG doesn't currently implement SError -- it could be added, but t

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > 3) qemu could add a "hotpluggable=no" commandline option to all PCI devices > (including vfio-pci) and then do whatever is necessary to make sure this is > honored in the emulated hardware (is it possible to set this on a per-slot > bas

Re: [RFC PATCH] audio: proper support for float samples in mixeng

On Mon, 3 Feb 2020 at 20:38, Zoltán Kővágó wrote: > > On 2020-02-03 11:00, Peter Maydell wrote: > > On Sun, 2 Feb 2020 at 19:39, Kővágó, Zoltán wrote: > >> > >> This adds proper support for float samples in mixeng by adding a new > >> audio format for it. > >> > >> Limitations: only native endian

Re: [PATCH v3 16/21] iotests: Add VM.assert_block_path()

31.01.2020 0:44, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v5 00/26] nvme: support NVMe v1.3d, SGLs and multiple namespaces

Patchew URL: https://patchew.org/QEMU/20200204095208.269131-1-k.jen...@samsung.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v5 00/26] nvme: support NVMe v1.3d, SGLs and multiple namespaces Message-id: 20200204095208.2691

Re: [PATCH v2 1/2] target/arm: kvm: Inject events at the last stage of sync

On Wed, Jan 29, 2020 at 08:24:40PM +, Beata Michalska wrote: > KVM_SET_VCPU_EVENTS might actually lead to vcpu registers being modified. > As such this should be the last step of sync to avoid potential overwriting > of whatever changes KVM might have done. > > Signed-off-by: Beata Michalska

Re: [PATCH 1/2] configure: Allow user to specify sphinx-build binary

Peter Maydell writes: > Currently we insist on using 'sphinx-build' from the $PATH; > allow the user to specify the binary to use. This will be > more useful as we become pickier about the capabilities > we require (eg needing a Python 3 sphinx-build). > > Signed-off-by: Peter Maydell > --- > I

[PATCH] .travis.yml: ensure python3-sphinx installed for docs

Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c1c6df475a8..8bdebd36c1f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -194,7 +194,7 @@ matrix: addons: apt: packages: -

Re: Does Libvirt's json parser support single quoted string in qmp json string?

Daniel P. Berrangé writes: > On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > [adding Markus] >> > >> > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: >> >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: >> >>> On 1/31/20 4:38 AM, Peter

[PATCH 0/4] virtiofsd coverity fixes

From: "Dr. David Alan Gilbert" Hi, This is a set of fixes that fixes things that coverity pointed out. Only the last one (the NULL check in do_read) is probably important. Dave Dr. David Alan Gilbert (4): virtiofsd: Remove fuse_req_getgroups virtiofsd: fv_create_listen_socket error path s

[PATCH 3/4] virtiofsd: load_capng missing unlock

From: "Dr. David Alan Gilbert" Missing unlock in error path. Fixes: Covertiy CID 1413123 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index e6f2

[PATCH 2/4] virtiofsd: fv_create_listen_socket error path socket leak

From: "Dr. David Alan Gilbert" If we fail when bringing up the socket we can leak the listen_fd; in practice the daemon will exit so it's not really a problem. Fixes: Coverity CID 1413121 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virtio.c | 2 ++ 1 file changed, 2 insertio

[PATCH 1/4] virtiofsd: Remove fuse_req_getgroups

From: "Dr. David Alan Gilbert" Remove fuse_req_getgroups that's unused in virtiofsd; it came in from libfuse but we don't actually use it. It was called from fuse_getgroups which we previously removed (but had left it's header in). Coverity had complained about null termination in it, but remov

[PATCH 4/4] virtiofsd: do_read missing NULL check

From: "Dr. David Alan Gilbert" Missing a NULL check if the argument fetch fails. Fixes: Coverity CID 1413119 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_

[RFC 1/9] memory: Add function for finding flat memory ranges

From: Igor Kotrasinski Given an address this lets us find the largest contiguous memory range at that address. Signed-off-by: Igor Kotrasinski --- include/exec/memory.h | 19 + memory.c | 79 ++- 2 files changed, 97 inser

[RFC 7/9] hw/misc/memexpose: Add memexpose memory region device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 2 + hw/misc/memexpose/Makefile.objs | 1 + hw/misc/memexpose/memexpose-memregion.c | 142 hw/misc/memexpose/memexpose-memregion.h | 41 + 4

[RFC 4/9] hw/misc/memexpose: Add documentation

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- docs/specs/memexpose-spec.txt | 168 ++ 1 file changed, 168 insertions(+) create mode 100644 docs/specs/memexpose-spec.txt diff --git a/docs/specs/memexpose-spec.txt b/docs/specs/memexpose-spec.

[RFC 0/9] Add an interVM memory sharing device

From: Igor Kotrasinski This patchset adds a "memory exposing" device that allows two QEMU instances to share arbitrary memory regions. Unlike ivshmem, it does not create a new region of memory that's shared between VMs, but instead allows one VM to access any memory region of the other VM we choo

[RFC 3/9] memory: Hack - use shared memory when possible

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- hw/core/numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 0d1b4be..02fd7f5 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -785,8 +785,8 @@ static void allocate_syst

[RFC 2/9] memory: Support mmap offset for fd-backed memory regions

From: Igor Kotrasinski The memexpose device will receive shared memory from another VM and map parts of it as memory regions. For that, we need to be able to mmap the region at an offset from shared memory's start. Signed-off-by: Igor Kotrasinski --- backends/hostmem-memfd.c | 2 +- exec.c

[RFC 9/9] hw/arm/virt: Hack in support for memexpose device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- hw/arm/virt.c | 110 +- include/hw/arm/virt.h | 5 +++ 2 files changed, 114 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f788fe2..ba35b21 100644

[RFC 6/9] hw/misc/memexpose: Add memexpose pci device

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 1 + hw/misc/memexpose/Makefile.objs | 1 + hw/misc/memexpose/memexpose-pci.c | 218 ++ 3 files changed, 220 insertions(+) create mode 100644 hw/misc/memexpo

[RFC 8/9] hw/misc/memexpose: Add simple tests

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- MAINTAINERS | 1 + tests/qtest/Makefile.include | 2 + tests/qtest/memexpose-test.c | 364 +++ 3 files changed, 367 insertions(+) create mode 100644 tests/qtest/memexpose-tes

[RFC 5/9] hw/misc/memexpose: Add core memexpose files

From: Igor Kotrasinski Signed-off-by: Igor Kotrasinski --- Kconfig.host | 3 + MAINTAINERS| 8 + Makefile | 1 + configure | 8 + hw/mem/Kconfig | 3 + hw/misc/Makefile

Re: [PATCH v3 17/21] iotests/041: Drop superfluous shutdowns

31.01.2020 0:44, Max Reitz wrote: All tearDowns in 041 shutdown the VM. Thus, test cases do not need to do it themselves (unless they need the VM to be down for some post-operation check). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 0/4] linux-user: fix use of SIGRTMIN

Le 04/02/2020 à 01:03, Josh Kunz a écrit : > On Sat, Feb 1, 2020 at 4:27 AM Laurent Vivier wrote: >> This has been tested with Go (golang 1.10.1 linux/arm64, bionic) on x86_64 >> fedora 31. We can avoid the failure in this case allowing the unsupported >> signals when we don't provide the "act" pa

Re: [PATCH] .travis.yml: ensure python3-sphinx installed for docs

On 2/4/20 11:51 AM, Alex Bennée wrote: Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c1c6df475a8..8bdebd36c1f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -194,7 +194,7 @@ matrix: addons:

Re: [PATCH v5 05/20] linux-user: mips: Update syscall numbers to kernel 5.5 rc3 level

On Tue, Jan 14, 2020 at 5:40 PM Laurent Vivier wrote: > > Le 13/01/2020 à 21:34, Aleksandar Markovic a écrit : > > From: Aleksandar Markovic > > > > Update mips syscall numbers based on Linux kernel tag v5.5-rc3 > > (commit 46cf053e). > > > > Signed-off-by: Aleksandar Markovic > > --- > > linux

Re: [PATCH 1/4] virtiofsd: Remove fuse_req_getgroups

On 2/4/20 12:04 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Remove fuse_req_getgroups that's unused in virtiofsd; it came in from libfuse but we don't actually use it. It was called from fuse_getgroups which we previously removed (but had left it's header in). Cover

Re: [PATCH 2/4] virtiofsd: fv_create_listen_socket error path socket leak

On 2/4/20 12:04 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" If we fail when bringing up the socket we can leak the listen_fd; in practice the daemon will exit so it's not really a problem. Fixes: Coverity CID 1413121 Signed-off-by: Dr. David Alan Gilbert --- tools

Re: [PATCH 4/4] virtiofsd: do_read missing NULL check

On 2/4/20 12:05 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Missing a NULL check if the argument fetch fails. Surprisingly all other calls to fuse_mbuf_iter_advance() do the check. Reviewed-by: Philippe Mathieu-Daudé Fixes: Coverity CID 1413119 Signed-off-by: D

Re: [PATCH 3/4] virtiofsd: load_capng missing unlock

Hi David, On 2/4/20 12:05 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Missing unlock in error path. Fixes: Covertiy CID 1413123 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/v

[PATCH 3/9] linux-user: m68k: Update syscall numbers to kernel 5.5 level

From: Aleksandar Markovic Update m68k syscall numbers based on Linux kernel v5.5. CC: Laurent Vivier Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/m68k/syscall_nr.h | 50 +++- 1 file changed, 49 insertions(+), 1 deletion

[PATCH 2/9] linux-user: arm: Update syscall numbers to kernel 5.5 level

From: Aleksandar Markovic Update arm syscall numbers based on Linux kernel v5.5. CC: Peter Maydell Signed-off-by: Aleksandar Markovic --- linux-user/arm/syscall_nr.h | 44 1 file changed, 44 insertions(+) diff --git a/linux-user/arm/syscall_nr.h b

[PATCH 0/9] linux-user: Update syscall numbers to kernel 5.5 level

From: Aleksandar Markovic Hello, folks! This series is a spin-off of another larger linux-user series that become too large to handle, hence these patches related to syscall numbers are now in this, separate, series. Now that kernel 5.5 is released few days ago, it is time to reflect what can b

[PATCH 4/9] linux-user: microblaze: Update syscall numbers to kernel 5.5 level

From: Aleksandar Markovic Update microblaze syscall numbers based on Linux kernel v5.5. CC: Edgar E. Iglesias Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/microblaze/syscall_nr.h | 45 ++ 1 file changed, 45 insertions(+) d

  1   2   3   4   >