Patchew URL: https://patchew.org/QEMU/1580803317-4422-1-git-send-email-aleksandar.marko...@rt-rk.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL v2 0/3] MIPS queue for February 4th, 2020 Message-id: 1580803317-4422-1-git-send-email-aleksandar.marko...@rt-rk.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/1580803317-4422-1-git-send-email-aleksandar.marko...@rt-rk.com -> patchew/1580803317-4422-1-git-send-email-aleksandar.marko...@rt-rk.com Switched to a new branch 'test' 593562b target/mips: Separate FPU-related helpers into their own file be0410a target/mips: Separate CP0-related helpers into their own file 19de371 target/mips: Fix handling of LL/SC instructions after 7dd547e5ab === OUTPUT BEGIN === 1/3 Checking commit 19de371ace95 (target/mips: Fix handling of LL/SC instructions after 7dd547e5ab) 2/3 Checking commit be0410a7fd55 (target/mips: Separate CP0-related helpers into their own file) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 ERROR: space prohibited after that '&' (ctx:WxW) #202: FILE: target/mips/cp0_helper.c:169: + tcu = (v >> CP0TCSt_TCU0) & 0xf; ^ ERROR: space prohibited after that '&' (ctx:WxW) #203: FILE: target/mips/cp0_helper.c:170: + tmx = (v >> CP0TCSt_TMX) & 0x1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #205: FILE: target/mips/cp0_helper.c:172: + tksu = (v >> CP0TCSt_TKSU) & 0x3; ^ ERROR: space prohibited after that '&' (ctx:WxW) #1678: FILE: target/mips/cp0_helper.c:1645: + if (!((env->CP0_VPControl >> CP0VPCtl_DIS) & 1)) { ^ ERROR: space prohibited after that '&' (ctx:WxW) #1696: FILE: target/mips/cp0_helper.c:1663: + if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { ^ total: 5 errors, 1 warnings, 3358 lines checked Patch 2/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/3 Checking commit 593562bee47d (target/mips: Separate FPU-related helpers into their own file) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: spaces required around that '*' (ctx:WxV) #1164: FILE: target/mips/fpu_helper.c:1133: + float_status *status) \ ^ total: 1 errors, 1 warnings, 3806 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1580803317-4422-1-git-send-email-aleksandar.marko...@rt-rk.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com