Re: [PULL 00/34] ppc-for-5.0 queue 20200131

2020-02-02 Thread David Gibson
On Fri, Jan 31, 2020 at 04:42:14PM +, Peter Maydell wrote: > On Fri, 31 Jan 2020 at 06:09, David Gibson > wrote: > > > > The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20200130' in

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread Thomas Huth
On 01/02/2020 23.46, Greg Kurz wrote: > Some default features of the pseries machine are only available with > KVM. Warnings are printed when the pseries machine is used with another > accelerator: > > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-ccf-assist=on > qemu-sy

Re: [PULL 32/41] target/mips: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

2020-02-02 Thread Thomas Huth
On 01/02/2020 21.12, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 1/8/20 4:45 AM, Richard Henderson wrote: >> The separate suffixed functions were used to construct >> some do_##insn function switched on mmu_idx. The interface >> is exactly identical to the *_mmuidx_ra functions. Replace >

Re: Making QEMU easier for management tools and applications

2020-02-02 Thread Kevin Wolf
Am 31.01.2020 um 13:27 hat Eric Blake geschrieben: > On 1/28/20 6:54 AM, Kevin Wolf wrote: > > > > > > > The arguments as dotted keys: > > > > > > id=bar,backend.type=file,backend.data.out=/tmp/bar.log > > > > > > Observe there's quite some of nesting. While that's somewhat cumbersome > >

Re: [PATCH v2 3/5] a standone-alone tool to directly share disk image file via vhost-user protocol

2020-02-02 Thread Kevin Wolf
Am 31.01.2020 um 17:42 hat Coiby Xu geschrieben: > > Yes, I think at least for the moment it should work fine this way. > > Eventually, I'd like to integrate it with --export (and associated QMP > > commands, which are still to be created), too. Maybe at that point we > > want to make the QOM objec

Re: [PULL 00/34] ppc-for-5.0 queue 20200131

2020-02-02 Thread Greg Kurz
On Sun, 2 Feb 2020 19:43:58 +1100 David Gibson wrote: > On Fri, Jan 31, 2020 at 04:42:14PM +, Peter Maydell wrote: > > On Fri, 31 Jan 2020 at 06:09, David Gibson > > wrote: > > > > > > The following changes since commit > > > 928173659d6e5dc368284f73f90ea1d129e1f57d: > > > > > > Merge re

Re: Making QEMU easier for management tools and applications

2020-02-02 Thread Paolo Bonzini
Il dom 2 feb 2020, 10:22 Kevin Wolf ha scritto: > Am 31.01.2020 um 13:27 hat Eric Blake geschrieben: > > On 1/28/20 6:54 AM, Kevin Wolf wrote: > > > > > > > > > > The arguments as dotted keys: > > > > > > > > id=bar,backend.type=file,backend.data.out=/tmp/bar.log > > > > > > > > Observe ther

[PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h

2020-02-02 Thread Heyi Guo
Update comments in tests/qtest/bios-tables-test.c to reflect the current path of bios-tables-test-allowed-diff.h, which is now under tests/qtest/ as well. Signed-off-by: Heyi Guo --- Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Thomas Huth Cc: Laurent Vivier Cc: Paolo Bonzini --- tests/

Re: VW ELF loader

2020-02-02 Thread Alexey Kardashevskiy
On 02/02/2020 06:04, Paolo Bonzini wrote: On 01/02/20 14:39, Alexey Kardashevskiy wrote: QEMU needs to load GRUB from the disk. The current workaround is to read it from qcow2, save in a file and then call load_elf(). Not nice. 2 problems with that. 1. when load_elf calls address_space_writ

[Bug 1861605] [NEW] LL/SC broken for MIPS after 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f

2020-02-02 Thread Alexander Richardson
Public bug reported: In that commit the env->llval value is loaded as an unsigned value (instead of sign-extended as before and therefore the CMPXCHG in gen_st_cond() in translate.c fails. I have committed a fix for this issue as https://github.com/CTSRD- CHERI/qemu/commit/a18d80c629989d002794f55

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-02-02 Thread gengdongjiu
sorry for the late response due to Chinese new year On 2020/1/28 22:41, Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:19 +0800 > Dongjiu Geng wrote: > > in addition to comments of others: > >> Record the GHEB address via fw_cfg file, when recording >> a error to CPER, it will use this address

[Bug 1861605] Re: LL/SC broken for MIPS after 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f

2020-02-02 Thread Alexander Richardson
The fix I linked is incorrect, the correct URL is https://github.com /CTSRD-CHERI/qemu/commit/a833317eeb0387dcfa7615a78e74f8b48990b8bc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1861605 Title: L

Re: [PATCH 2/4] target/arm: Update MSR access to UAO

2020-02-02 Thread Peter Maydell
On Sun, 2 Feb 2020 at 01:00, Richard Henderson wrote: > > Does the "on exception entry PSTATE.UAO is zeroed" behaviour > > fall out automatically for us? > > Yes, aarch64_pstate_mode() returns a clean PSTATE. > > > How about "on exception entry > > from aarch32 to aarch64 SPSR_ELx.UAO is set to ze

[Bug 1861605] Re: LL/SC broken for MIPS after 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f

2020-02-02 Thread Alexander Richardson
New patch: https://github.com/qemu/qemu/commit/6ff8dec97f1a105d0da96c67ee24c75e437df162 ** Description changed: In that commit the env->llval value is loaded as an unsigned value (instead of sign-extended as before and therefore the CMPXCHG in gen_st_cond() in translate.c fails. - I have

[PATCH v3 0/2] RISC-V TIME CSR for privileged mode

2020-02-02 Thread Anup Patel
This series adds emulation of TIME CSRs for privileged mode. With this series, we see approximately 25+% improvement in hackbench numbers for non-virtualized (or Host) Linux and 40+% improvement in hackbench numbers for Guest/VM Linux. These patches are based on mainline/alistair/riscv-hyp-ext-v0.

Re: [PATCH v22 7/9] ACPI: Record Generic Error Status Block(GESB) table

2020-02-02 Thread gengdongjiu
On 2020/1/28 23:29, Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:21 +0800 > Dongjiu Geng wrote: > >> kvm_arch_on_sigbus_vcpu() error injection uses source_id as >> index in etc/hardware_errors to find out Error Status Data >> Block entry corresponding to error source. So supported source_id >>

[PATCH v3 2/2] hw/riscv: Provide rdtime callback for TCG in CLINT emulation

2020-02-02 Thread Anup Patel
This patch extends CLINT emulation to provide rdtime callback for TCG. This rdtime callback will be called wheneven TIME CSRs are read in privileged modes. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis --- hw/riscv/sifive_clint.c | 6 +- hw/riscv/sifive_e.c | 2

[PATCH v3 1/2] target/riscv: Emulate TIME CSRs for privileged mode

2020-02-02 Thread Anup Patel
Currently, TIME CSRs are emulated only for user-only mode. This patch add TIME CSRs emulation for privileged mode. For privileged mode, the TIME CSRs will return value provided by rdtime callback which is registered by QEMU machine/platform emulation (i.e. CLINT emulation). If rdtime callback is n

Re: [PATCH v22 3/9] ACPI: Build related register address fields via hardware error fw_cfg blob

2020-02-02 Thread gengdongjiu
On 2020/1/23 23:14, Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:17 +0800 > Dongjiu Geng wrote: > >> This patch builds error_block_address and read_ack_register fields >> in hardware errors table , the error_block_address points to Generic >> Error Status Block(GESB) via bios_linker. The max s

[PATCH 0/1] coreaudio: fix coreaudio playback

2020-02-02 Thread Volker Rümelin
Hi, here is a new patch for the CoreAudio playback problem. This patch is Zoltán's patch from https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02142.html and a improved version of my patch squashed together. I actually tested the changes in audio/audio_template.h, audio/mixeng.c and au

[PATCH] coreaudio: fix coreaudio playback

2020-02-02 Thread Volker Rümelin
There are reports that since commit 2ceb8240fa "coreaudio: port to the new audio backend api" audio playback with CoreAudio is broken. This patch reverts some parts the commit. Because of changes in the audio subsystem the audio clip function in v4.1.0 of coreaudio.c had to be moved to mixeng.c an

Re: [PATCH v22 4/9] ACPI: Build Hardware Error Source Table

2020-02-02 Thread gengdongjiu
On 2020/1/23 23:48, Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:18 +0800 > Dongjiu Geng wrote: > >> This patch builds Hardware Error Source Table(HEST) via fw_cfg blobs. >> Now it only supports ARMv8 SEA, a type of Generic Hardware Error >> Source version 2(GHESv2) error source. Afterwards

[PATCH] target/mips: Fix ll/sc after 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f

2020-02-02 Thread James Clarke
From: Alex Richardson After 7dd547e5ab6b31e7a0cfc182d3ad131dd55a948f the env->llval value is loaded as an unsigned value (instead of sign-extended as before). Therefore, the CMPXCHG in gen_st_cond() in translate.c fails if the sign bit is set in the loaded value. Fix this by sign-extending the ll

Re: [PATCH rc4 06/29] target/avr: Add defintions of AVR core types

2020-02-02 Thread Joaquin de Andres
On 1/31/20 1:02 AM, Aleksandar Markovic wrote: From: Michael Rolnik AVR core types are: - avr1 - avr2 - avr25 - avr3 - avr31 - avr35 - avr4 - avr5 - avr51 - avr6 - avrtiny - xmega2 - xmega3 - xmega4 - xmega5 - xmega6 - xmega7 Each core type c

Re: [PATCH] riscv: virt: Allow PCI address 0

2020-02-02 Thread Bin Meng
Hi Palmer, On Sat, Nov 23, 2019 at 6:41 AM Palmer Dabbelt wrote: > > On Fri, 22 Nov 2019 07:27:52 PST (-0800), bmeng...@gmail.com wrote: > > When testing e1000 with the virt machine, e1000's I/O space cannot > > be accessed. Debugging shows that the I/O BAR (BAR1) is correctly > > written with ad

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread BALATON Zoltan
On Sat, 1 Feb 2020, Greg Kurz wrote: Some default features of the pseries machine are only available with KVM. Warnings are printed when the pseries machine is used with another accelerator: qemu-system-ppc64: warning: TCG doesn't support requested feature, cap-ccf-assist=on qemu-system-ppc64: w

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread BALATON Zoltan
On Sun, 2 Feb 2020, BALATON Zoltan wrote: On Sat, 1 Feb 2020, Greg Kurz wrote: Some default features of the pseries machine are only available with KVM. Warnings are printed when the pseries machine is used with another accelerator: qemu-system-ppc64: warning: TCG doesn't support requested feat

Re: VW ELF loader

2020-02-02 Thread Paolo Bonzini
Il dom 2 feb 2020, 12:51 Alexey Kardashevskiy ha scritto: > > QEMU must not load GRUB from disk, that's the firmware's task. If you > > want to kill SLOF, you can rewrite it, but loading the kernel GRUB from > > disk within QEMU is a bad idea: the next feature you'll be requested to > > implemen

Re: [PATCH 0/1] coreaudio: fix coreaudio playback

2020-02-02 Thread Howard Spoelstra
On Sun, Feb 2, 2020 at 3:03 PM Volker Rümelin wrote: > Hi, > > here is a new patch for the CoreAudio playback problem. This patch > is Zoltán's patch from > https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02142.html > and a improved version of my patch squashed together. > > I actuall

Re: [PATCH v4 04/20] hw/arm/allwinner-h3: add USB host controller

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:37 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Allwinner H3 System on Chip contains multiple USB 2.0 bus > > connections which provide software access using the Enhanced > > Host Controller Interface (EHCI) and Open Host Controll

Re: [PATCH v4 04/20] hw/arm/allwinner-h3: add USB host controller

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:44 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 7:37 PM, Philippe Mathieu-Daudé wrote: > > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > >> The Allwinner H3 System on Chip contains multiple USB 2.0 bus > >> connections which provide software access using the Enhanced > >

[RFC PATCH] audio: proper support for float samples in mixeng

2020-02-02 Thread Kővágó, Zoltán
This adds proper support for float samples in mixeng by adding a new audio format for it. Limitations: only native endianness is supported. Signed-off-by: Kővágó, Zoltán --- This patch is meant to be applied on top of "[PATCH] coreaudio: fix coreaudio playback" by Volker Rümelin, available at:

Re: [PATCH] coreaudio: fix coreaudio playback

2020-02-02 Thread Zoltán Kővágó
On 2020-02-02 15:06, Volker Rümelin wrote: There are reports that since commit 2ceb8240fa "coreaudio: port to the new audio backend api" audio playback with CoreAudio is broken. This patch reverts some parts the commit. Because of changes in the audio subsystem the audio clip function in v4.1.0

Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type

2020-02-02 Thread Zoltán Kővágó
On 2020-01-28 09:30, Volker Rümelin wrote: Hi, Unfortunately it's not that simple to simply revert the patch since the old backend api no longer exists.  Also I don't have a Mac so it's almost impossible for me to test the results.  I looked at the specified commit and I think I found a probl

[Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2020-02-02 Thread Philippe Vaucher
Ah, great thanks. It looks like there are patches that fix qemu, although the setup looks a bit complex. I'll report if I get something going. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805913 Ti

Re: [PATCH v4 06/20] hw/arm/allwinner: add CPU Configuration module

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:52 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > Various Allwinner System on Chip designs contain multiple processors > > that can be configured and reset using the generic CPU Configuration > > module interface. This commit adds suppo

Re: [PATCH v4 07/20] hw/arm/allwinner: add Security Identifier device

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:57 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Security Identifier device found in various Allwinner System on Chip > > designs gives applications a per-board unique identifier. This commit > > adds support for the Allwinner Secu

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-02 Thread Niek Linnenbank
Hi Corey, Thanks for reviewing! On Mon, Jan 20, 2020 at 6:59 PM Corey Minyard wrote: > On Sat, Jan 18, 2020 at 04:25:08PM +0100, Philippe Mathieu-Daudé wrote: > > Cc'ing Corey/David for good advices about using UUID. > > Is there any reason you didn't use the built-in qemu UUID for this? It >

Re: [PATCH v4 08/20] hw/arm/allwinner: add SD/MMC host controller

2020-02-02 Thread Niek Linnenbank
Hi Philippe, On Sun, Jan 19, 2020 at 8:02 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Allwinner System on Chip families sun4i and above contain > > an integrated storage controller for Secure Digital (SD) and > > Multi Media Card (MMC) interfaces. This c

[Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2020-02-02 Thread Marcin Konarski
This problem affected my virtual environment which I used (via qemu- static) to build my project for RaspberryPI platform. After I upgraded my virtual Raspbian to buster release `readdir` stopped working (as described in this thread) due to mapping of 64 inode numbers to qemu 32bit ARM land. I need

Re: [PATCH v4 10/20] hw/arm/allwinner-h3: add Boot ROM support

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 8:14 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > A real Allwinner H3 SoC contains a Boot ROM which is the > > first code that runs right after the SoC is powered on. > > The Boot ROM is responsible for loading user code (e.g. a bootloa

Re: [RFC PATCH] audio: proper support for float samples in mixeng

2020-02-02 Thread Howard Spoelstra
On Sun, Feb 2, 2020 at 8:38 PM Kővágó, Zoltán wrote: > This adds proper support for float samples in mixeng by adding a new > audio format for it. > > Limitations: only native endianness is supported. > > Signed-off-by: Kővágó, Zoltán > --- > > This patch is meant to be applied on top of "[PATCH

Re: [PATCH v4 02/20] hw/arm: add Xunlong Orange Pi PC machine

2020-02-02 Thread Niek Linnenbank
On Tue, Jan 21, 2020 at 5:39 PM Igor Mammedov wrote: > On Sun, 19 Jan 2020 01:50:44 +0100 > Niek Linnenbank wrote: > > > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > > based embedded computer with mainline support in both U-Boot > > and Linux. The board comes with a Quad Core Cor

Re: [PATCH v4 02/20] hw/arm: add Xunlong Orange Pi PC machine

2020-02-02 Thread Niek Linnenbank
On Sun, Jan 19, 2020 at 7:04 PM Philippe Mathieu-Daudé wrote: > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > > based embedded computer with mainline support in both U-Boot > > and Linux. The board comes with a Quad Core Cortex A7 @ 1.

[PATCH] audio/dsound: fix invalid parameters error

2020-02-02 Thread Kővágó, Zoltán
Windows (unlike wine) bails out when IDirectSoundBuffer8::Lock is called with zero length. Also, hw->pos_emul handling was incorrect when calling this function for the first time. Signed-off-by: Kővágó, Zoltán Reported-by: KJ Liew --- I've tested this patch on wine and a borrowed Windows 8.1 l

[PATCH v2 4/7] arm/acpi: fix PCI _PRT definition

2020-02-02 Thread Heyi Guo
The address field in each _PRT mapping package should be constructed with high word for device# and low word for function#, so it is wrong to use bus_no as the high word. Enumerate all possible slots (i.e. PCI_SLOT_MAX) instead. Signed-off-by: Heyi Guo --- Cc: Peter Maydell Cc: "Michael S. Tsir

[PATCH v2 0/7] Some cleanup in arm/virt/acpi

2020-02-02 Thread Heyi Guo
Remove conflict _ADR objects, and fix and refine PCI device definition in ACPI/DSDT. Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org v1 -> v2: - flow the work flow in tests/qtest/bios-table-test.c to post ACPI rel

[PATCH v2 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT

2020-02-02 Thread Heyi Guo
We are going to change ARM virt ACPI DSDT table, which will cause make check to fail, so temporarily add related golden masters to ignore list. Signed-off-by: Heyi Guo --- Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.org Cc: qemu-devel@non

[PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS

2020-02-02 Thread Heyi Guo
The original code defines a named object for the resource template but then returns the resource template object itself; the resulted output is like below: Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Name (RBUF, ResourceTemplate () { WordBusNumber (Resourc

[PATCH v2 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0

2020-02-02 Thread Heyi Guo
The sub device "RP0" under PCI0 in ACPI/DSDT does not contain any method or property other than "_ADR", so it is safe to remove it. Signed-off-by: Heyi Guo Acked-by: "Michael S. Tsirkin" --- Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.or

[PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices

2020-02-02 Thread Heyi Guo
Using _UID of 0 for all PCI interrupt link devices absolutely violates the spec. Simply increase one by one. Signed-off-by: Heyi Guo --- Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Shannon Zhao Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/virt-acpi-build

[PATCH v2 7/7] virt/acpi: update golden masters for DSDT update

2020-02-02 Thread Heyi Guo
Differences between disassembled ASL files: diff --git a/DSDT.dsl.orig b/DSDT.dsl index ed3e5f0fa9..10cf70c886 100644 --- a/DSDT.dsl.orig +++ b/DSDT.dsl @@ -5,13 +5,13 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of DSDT, Thu Jan 23 16:00:04 2020 + * Disassembly of DSDT.

[PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-02-02 Thread Heyi Guo
According to ACPI spec, _ADR should be used for device on a bus that has a standard enumeration algorithm, but not for device which is on system bus and must be enumerated by OSPM. And it is not recommended to contain both _HID and _ADR in a single device. See ACPI 6.3, section 6.1, top of page 34

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread David Gibson
On Sat, Feb 01, 2020 at 11:46:16PM +0100, Greg Kurz wrote: > Some default features of the pseries machine are only available with > KVM. Warnings are printed when the pseries machine is used with another > accelerator: > > qemu-system-ppc64: warning: TCG doesn't support requested feature, > cap-cc

Re: [PATCH] tests: Silent various warnings with pseries

2020-02-02 Thread David Gibson
On Sun, Feb 02, 2020 at 06:31:17PM +0100, BALATON Zoltan wrote: > On Sun, 2 Feb 2020, BALATON Zoltan wrote: > > On Sat, 1 Feb 2020, Greg Kurz wrote: > > > Some default features of the pseries machine are only available with > > > KVM. Warnings are printed when the pseries machine is used with anoth

Re: VW ELF loader

2020-02-02 Thread David Gibson
On Sun, Feb 02, 2020 at 06:38:59PM +0100, Paolo Bonzini wrote: > Il dom 2 feb 2020, 12:51 Alexey Kardashevskiy ha scritto: > > > > QEMU must not load GRUB from disk, that's the firmware's task. If you > > > want to kill SLOF, you can rewrite it, but loading the kernel GRUB from > > > disk within

Re: VW ELF loader

2020-02-02 Thread David Gibson
On Sat, Feb 01, 2020 at 08:04:25PM +0100, Paolo Bonzini wrote: > On 01/02/20 14:39, Alexey Kardashevskiy wrote: > > QEMU needs to load GRUB from the disk. The current workaround is to read > > it from qcow2, save in a file and then call load_elf(). Not nice. > > > > 2 problems with that. > > > >

[PATCH] boot-order-test: fix memleaks in boot-order-test

2020-02-02 Thread pannengyuan
From: Pan Nengyuan It's not a big deal, but 'check qtest-ppc/ppc64' runs fail if sanitizers is enabled. The memory leak stack is as follow: Direct leak of 128 byte(s) in 4 object(s) allocated from: #0 0x7f11756f5970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1 0x7f1174f2549d

[PATCH qemu] spapr/rtas: Print message from "ibm,os-term"

2020-02-02 Thread Alexey Kardashevskiy
The "ibm,os-term" RTAS call has a single parameter which is a pointer to a message from the guest kernel about the termination cause; this prints it. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_rtas.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/ppc/spapr_rtas.c b/hw/pp

[RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-02 Thread Cleber Rosa
This is a crude and straightforward mapping of Peter's "remake-merge-builds" and "pull-buildtest" scripts. Some characteristics were removed for simplicity sake (but eventually will), including: * number of simultaneous make jobs * make's synchronous output, not needed because of previous point

[RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs

2020-02-02 Thread Cleber Rosa
At this point it seems that all jobs depend on those steps, with maybe the EDK2 jobs as exceptions. The jobs that will be added will not want those scripts to be run, so let's move these steps to the appropriate jobs, while still trying to avoid repetition. Signed-off-by: Cleber Rosa --- .gitla

Re: [RFC] QEMU Gating CI

2020-02-02 Thread Cleber Rosa
On Fri, Jan 17, 2020 at 02:33:54PM +, Peter Maydell wrote: > On Mon, 2 Dec 2019 at 14:06, Cleber Rosa wrote: > > > > RFC: QEMU Gating CI > > === > > > > This RFC attempts to address most of the issues described in > > "Requirements/GatinCI"[1]. An also relevant write up is the

[PATCH qemu v6 0/6] spapr: Kill SLOF

2020-02-02 Thread Alexey Kardashevskiy
This is v6 of an effort to implement Open Firmware Client Interface in QEMU. The feature is described in 6/6, 1/6..5/6 are small but necessary preparations. With this thing, I can boot unmodified Ubuntu 18.04 and Fedora 30 directly from the disk without SLOF. This is based on sha1 532fe321cf06 R

[PATCH qemu v6 1/6] ppc: Start CPU in the default mode which is big-endian 32bit

2020-02-02 Thread Alexey Kardashevskiy
At the moment we enforce 64bit mode on a CPU when reset. This does not make difference as SLOF or Linux set the desired mode straight away. However if we ever boot something other than these two, this might not work as, for example, GRUB expects the default MSR state and does not work properly. Th

[PATCH qemu v6 4/6] spapr/cas: Separate CAS handling from rebuilding the FDT

2020-02-02 Thread Alexey Kardashevskiy
At the moment "ibm,client-architecture-support" ("CAS") is implemented in SLOF and QEMU assists via the custom H_CAS hypercall which copies an updated flatten device tree (FDT) blob to the SLOF memory which it then uses to update its internal tree. When we enable the OpenFirmware client interface

[PATCH qemu v6 6/6] spapr: Implement Open Firmware client interface

2020-02-02 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2

[PATCH qemu v6 3/6] spapr/spapr: Make vty_getchars public

2020-02-02 Thread Alexey Kardashevskiy
A serial device fetches the data from the chardev backend as soon as input happens and stores it in its internal device specific buffer, every char device implements it again. Since there is no unified interface to read such buffer, we will have to read characters directly from VIO_SPAPR_VTY_DEVICE

[PATCH qemu v6 2/6] ppc/spapr: Move GPRs setup to one place

2020-02-02 Thread Alexey Kardashevskiy
At the moment "pseries" starts in SLOF which only expects the FDT blob pointer in r3. As we are going to introduce a OpenFirmware support in QEMU, we will be booting OF clients directly and these expect a stack pointer in r1, the OF entry point in r5 and in addition to this, Linux looks at r3/r4 fo

[PATCH qemu v6 5/6] spapr: Allow changing offset for -kernel image

2020-02-02 Thread Alexey Kardashevskiy
This allows moving the kernel in the guest memory. The option is useful for step debugging (as Linux is linked at 0x0); it also allows loading grub which is normally linked to run at 0x2. This uses the existing kernel address by default. Signed-off-by: Alexey Kardashevskiy --- include/hw/pp

Re: [Bug 1860759] Re: [REGRESSION] option `-snapshot` ignored with blockdev

2020-02-02 Thread Ildar
this answers the whole question. Thanks a lot. closing ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860759 Title: [REGRESSION] option `-snapsho

Re: [PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:01AM +0800, Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device on a bus that > has a standard enumeration algorithm, but not for device which is on > system bus and must be enumerated by OSPM. And it is not recommended > to contain both _HID and _

Re: [PATCH v2 7/7] virt/acpi: update golden masters for DSDT update

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:05AM +0800, Heyi Guo wrote: > Differences between disassembled ASL files: > > diff --git a/DSDT.dsl.orig b/DSDT.dsl > index ed3e5f0fa9..10cf70c886 100644 > --- a/DSDT.dsl.orig > +++ b/DSDT.dsl > @@ -5,13 +5,13 @@ > * > * Disassembling to symbolic ASL+ operators >

Re: [PATCH v2 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:14:59AM +0800, Heyi Guo wrote: > We are going to change ARM virt ACPI DSDT table, which will cause make > check to fail, so temporarily add related golden masters to ignore > list. > > Signed-off-by: Heyi Guo Reviewed-by: Michael S. Tsirkin > --- > Cc: Peter Maydell

Re: [PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:03AM +0800, Heyi Guo wrote: > Using _UID of 0 for all PCI interrupt link devices absolutely violates > the spec. Simply increase one by one. > > Signed-off-by: Heyi Guo Reviewed-by: Michael S. Tsirkin > --- > Cc: Peter Maydell > Cc: "Michael S. Tsirkin" > Cc: I

Re: [PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:04AM +0800, Heyi Guo wrote: > The original code defines a named object for the resource template but > then returns the resource template object itself; the resulted output > is like below: > > Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings > { >

Re: [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h

2020-02-02 Thread Thomas Huth
On 02/02/2020 12.00, Heyi Guo wrote: > Update comments in tests/qtest/bios-tables-test.c to reflect the > current path of bios-tables-test-allowed-diff.h, which is now under > tests/qtest/ as well. > > Signed-off-by: Heyi Guo > > --- > > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Thom

Re: [PATCH v2 4/7] arm/acpi: fix PCI _PRT definition

2020-02-02 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 08:15:02AM +0800, Heyi Guo wrote: > The address field in each _PRT mapping package should be constructed > with high word for device# and low word for function#, so it is wrong > to use bus_no as the high word. Enumerate all possible slots > (i.e. PCI_SLOT_MAX) instead. > >

[PULL 02/35] ppc/pnv: improve error logging when a PNOR update fails

2020-02-02 Thread David Gibson
From: Cédric Le Goater Print out the offset at which the error occured. Signed-off-by: Cédric Le Goater Message-Id: <20200108090348.21224-3-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PULL 01/35] ppc/pnv: use QEMU unit definition MiB

2020-02-02 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20200108090348.21224-2-...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_p

[PULL 03/35] ppc:virtex_ml507: remove unused arguments

2020-02-02 Thread David Gibson
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <1579100861-73692-71-git-send-email-imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/virtex_ml507.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/ppc/vir

[PULL 00/35] ppc-for-5.0 queue 20200203

2020-02-02 Thread David Gibson
The following changes since commit 28db64fce555a03b4ca256d5b6f4290abdfbd9e8: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2020-01-31 17:37:00 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.0-20200203

[PULL 10/35] ppc/pnv: Add support for HRMOR on Radix host

2020-02-02 Thread David Gibson
From: Cédric Le Goater When in HV mode, if EA[0] is 0, the Hypervisor Offset Real Mode Register controls the access. Signed-off-by: Cédric Le Goater Message-Id: <20200127144154.10170-2-...@kaod.org> Signed-off-by: David Gibson --- target/ppc/mmu-radix64.c | 6 ++ 1 file changed, 6 inserti

[PULL 08/35] target/ppc: add support for Hypervisor Facility Unavailable Exception

2020-02-02 Thread David Gibson
From: Cédric Le Goater The privileged message send and clear instructions (msgsndp & msgclrp) are privileged, but will generate a hypervisor facility unavailable exception if not enabled in the HFSCR and executed in privileged non-hypervisor state. Add checks when accessing the DPDES register an

[PULL 06/35] spapr: Fail CAS if option vector table cannot be parsed

2020-02-02 Thread David Gibson
From: Greg Kurz Most of the option vector helpers have assertions to check their arguments aren't null. The guest can provide an arbitrary address for the CAS structure that would result in such null arguments. Fail CAS with H_PARAMETER and print a warning instead of aborting QEMU. Signed-off-by

[PULL 22/35] spapr: Enable DD2.3 accelerated count cache flush in pseries-5.0 machine

2020-02-02 Thread David Gibson
For POWER9 DD2.2 cpus, the best current Spectre v2 indirect branch mitigation is "count cache disabled", which is configured with: -machine cap-ibs=fixed-ccd However, this option isn't available on DD2.3 CPUs with KVM, because they don't have the count cache disabled. For POWER9 DD2.3 cpus, it

[PULL 05/35] target/ppc: Clarify the meaning of return values in kvm_handle_debug

2020-02-02 Thread David Gibson
From: Fabiano Rosas The kvm_handle_debug function can return 0 to go back into the guest or return 1 to notify the gdbstub thread and pass control to GDB. Signed-off-by: Fabiano Rosas Message-Id: <20200110151344.278471-2-faro...@linux.ibm.com> Tested-by: Leonardo Bras Signed-off-by: David Gibs

[PULL 09/35] spapr: Don't allow multiple active vCPUs at CAS

2020-02-02 Thread David Gibson
From: Greg Kurz According to the description of "ibm,client-architecture-support" that can found in LoPAPR "B.6.2.3 Root Node Methods": If multiple partition processors or threads are active at the time of the ibm,client-architecture-support method call, or an error is detected in the format of

[PULL 13/35] tpm: Move tpm_tis_show_buffer to tpm_util.c

2020-02-02 Thread David Gibson
From: Stefan Berger Signed-off-by: Stefan Berger Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Message-Id: <20200121152935.649898-2-stef...@linux.ibm.com> Signed-off-by: David Gibson --- hw/tpm/tpm_tis.c| 32 hw/tpm/tpm_util.c | 25 +

[PULL 16/35] tpm_spapr: Support suspend and resume

2020-02-02 Thread David Gibson
From: Stefan Berger Extend the tpm_spapr frontend with VM suspend and resume support. Signed-off-by: Stefan Berger Message-Id: <20200121152935.649898-5-stef...@linux.ibm.com> Reviewed-by: Marc-André Lureau Signed-off-by: David Gibson --- hw/tpm/tpm_spapr.c | 52 +

[PULL 14/35] spapr: Implement get_dt_compatible() callback

2020-02-02 Thread David Gibson
From: Stefan Berger For devices that cannot be statically initialized, implement a get_dt_compatible() callback that allows us to ask the device for the 'compatible' value. Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau Reviewed-by: David Gibson Message-Id: <20200121152935.649898

[PULL 07/35] target/ppc: Add privileged message send facilities

2020-02-02 Thread David Gibson
From: Cédric Le Goater The Processor Control facility for POWER8 processors and later provides a mechanism for the hypervisor to send messages to other threads in the system (msgsnd instruction) and cause hypervisor-level exceptions. Privileged non-hypervisor programs can also send messages (msgs

[PULL 18/35] docs/specs/tpm: reST-ify TPM documentation

2020-02-02 Thread David Gibson
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Message-Id: <20200121152935.649898-7-stef...@linux.ibm.com> Signed-off-by: David Gibson --- docs/specs/index.rst | 1 + docs/specs/tpm.rst | 503 +++ docs/specs/tpm.

[PULL 12/35] ppc/pnv: Add support for "hostboot" mode

2020-02-02 Thread David Gibson
From: Cédric Le Goater When the "hb-mode" option is activated on the powernv machine, the firmware is mapped at 0x800 and the HRMOR of the HW threads are set to the same address. The PNOR mapping on the FW address space of the LPC bus is left enabled to let the firmware load any other images

[PULL 11/35] ppc/pnv: remove useless "core-pir" property alias.

2020-02-02 Thread David Gibson
From: Cédric Le Goater Commit 158e17a65e1a ("ppc/pnv: Link "chip" property to PnvCore::chip pointer") introduced some cleanups of the PnvCore realize handler. Let's continue by reworking a bit the interface of the PnvCore handlers for the CPU threads. These changes make the "core-pir" property al

[PULL 04/35] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2020-02-02 Thread David Gibson
From: Thomas Huth It's been deprecated since QEMU v3.1. The 40p machine should be used nowadays instead. Reviewed-by: Philippe Mathieu-Daudé Acked-by: Hervé Poussineau Signed-off-by: Thomas Huth Message-Id: <20200114114617.28854-1-th...@redhat.com> Signed-off-by: David Gibson --- .gitmodule

[PULL 15/35] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2020-02-02 Thread David Gibson
From: Stefan Berger Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 works with this emulation. This TPM emulator also handles the TPM 2 case. Signed-off-

[PULL 17/35] hw/ppc/Kconfig: Enable TPM_SPAPR as part of PSERIES config

2020-02-02 Thread David Gibson
From: Stefan Berger Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau Reviewed-by: David Gibson Message-Id: <20200121152935.649898-6-stef...@linux.ibm.com> [dwg: Use default in Kconfig rather than select to avoid breaking Windows host build] Signed-off-by: David Gibson --- hw/tpm/

[PULL 30/35] ppc: spapr: Activate the FWNMI functionality

2020-02-02 Thread David Gibson
From: Aravinda Prasad This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 5.0. Signed-off-by: Aravinda Prasad Signed-off-by: Ganesh Goudar Message-Id: <20200130184423.20519-8-ganes...@linux.ibm.com> Signed-off-by: David Gibson --- hw/ppc/spapr.c | 3 ++-

[PULL 20/35] ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge

2020-02-02 Thread David Gibson
From: Cédric Le Goater This is a model of the PCIe Host Bridge (PHB3) found on a POWER8 processor. It includes the PowerBus logic interface (PBCQ), IOMMU support, a single PCIe Gen.3 Root Complex, and support for MSI and LSI interrupt sources as found on a POWER8 system using the XICS interrupt c

[PULL 26/35] target/ppc: Handle NMI guest exit

2020-02-02 Thread David Gibson
From: Aravinda Prasad Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reaso

  1   2   >