Re: [RFC] coreaudio: fix coreaudio_test.diff

2020-01-31 Thread Gerd Hoffmann
On Fri, Jan 31, 2020 at 08:37:50AM +0100, Volker Rümelin wrote: > > > > Hi all, > > > > Thanks to the generous help from Mark, I can now report that it is good to > > hear coreaudio has been restored into a working state with this patch! I > > tested qemu-system-ppc running MacOS and OSX. > > > >

Re: Making QEMU easier for management tools and applications

2020-01-31 Thread Markus Armbruster
Paolo Bonzini writes: > On 31/01/20 07:50, Markus Armbruster wrote: Consider chardev-add. Example: {"execute": "chardev-add", "arguments": {"id": "bar", "backend": {"type": "file", "data": {"out": "/tmp/bar.

Re: [RFC] coreaudio: fix coreaudio_test.diff

2020-01-31 Thread Mark Cave-Ayland
On 31/01/2020 08:03, Gerd Hoffmann wrote: >> Thank you for testing the two patches. I will wait a few days to see if >> Zoltán wants to write a cleaned up patch. Otherwise I'll try to write a >> patch that's acceptable for submission. > > I'm busy collecting pending audio fixes for the next pul

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-31 Thread Laurent Vivier
Le 30/01/2020 à 12:52, Peter Maydell a écrit : > On Thu, 30 Jan 2020 at 11:20, Laurent Vivier wrote: >> >> Le 30/01/2020 à 12:09, Aleksandar Markovic a écrit : >>> Laurent, all this seems to be dependant on whether you are ready to >>> mentor the project. Are you? >> >> Yes, of course. >> >>> The

Re: [RFC] coreaudio: fix coreaudio_test.diff

2020-01-31 Thread Howard Spoelstra
On Fri, Jan 31, 2020 at 9:35 AM Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 31/01/2020 08:03, Gerd Hoffmann wrote: > > >> Thank you for testing the two patches. I will wait a few days to see if > Zoltán wants to write a cleaned up patch. Otherwise I'll try to write a > patch that

Re: [PATCH rc4 24/29] hw/avr: Add some ATmega microcontrollers

2020-01-31 Thread Thomas Huth
On 31/01/2020 05.11, Aleksandar Markovic wrote: > On Fri, Jan 31, 2020 at 4:45 AM Aleksandar Markovic > wrote: >> >> On Fri, Jan 31, 2020 at 4:09 AM Philippe Mathieu-Daudé >> wrote: >>> >>> Hi Aleksandar, >>> >>> Cc'ing Thomas & Daniel who are not lawyers but tried to explain me few >>> times ho

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-31 Thread Marc Zyngier
On 2020-01-31 06:59, Gavin Shan wrote: On 1/29/20 8:04 PM, Marc Zyngier wrote: On 2020-01-29 02:44, Alexey Kardashevskiy wrote: On 28/01/2020 17:48, Gavin Shan wrote: but a NMI is injected through LAPIC on x86. So I'm not sure what architect (system reset on ppc or injecting NMI on x86) aarc

Re: [PATCH rc4 24/29] hw/avr: Add some ATmega microcontrollers

2020-01-31 Thread Aleksandar Markovic
On Fri, Jan 31, 2020 at 10:35 AM Thomas Huth wrote: > > On 31/01/2020 05.11, Aleksandar Markovic wrote: > > On Fri, Jan 31, 2020 at 4:45 AM Aleksandar Markovic > > wrote: > >> > >> On Fri, Jan 31, 2020 at 4:09 AM Philippe Mathieu-Daudé > >> wrote: > >>> > >>> Hi Aleksandar, > >>> > >>> Cc'ing T

Re: [PATCH v2 06/29] python/qemu: Add binutils::binary_get_arch()

2020-01-31 Thread Cornelia Huck
On Wed, 29 Jan 2020 22:23:22 +0100 Philippe Mathieu-Daudé wrote: > Add a helper to query the architecture of a QEMU binary. > We simply send the 'query-target' command over a QMP socket. > > Signed-off-by: Philippe Mathieu-Daudé > --- > python/qemu/binutils.py | 15 +++ >

Re: Improving QOM documentation [Was: Re: Making QEMU easier for management tools and applications]

2020-01-31 Thread Kashyap Chamarthy
On Fri, Jan 31, 2020 at 07:11:15AM +0100, Markus Armbruster wrote: > Kashyap Chamarthy writes: [...] > > What can be done to improve QOM documentation (or lack thereof)? > > Are you trying to push us from idle grousing to actually improve things? > No fair! I first wrote it as a semi-complaint

Re: [PATCH v2 07/29] tests/acceptance: Use the 'arch' tag to verify QEMU binary target

2020-01-31 Thread Cornelia Huck
On Wed, 29 Jan 2020 22:23:23 +0100 Philippe Mathieu-Daudé wrote: > We already use the 'arch' tag in Avocado tests. Tests can set > it to restrict their use on a particular target architecture. > > If the QEMU binary does not target the required architecture, > the tests will be cancelled (skippe

Re: [PATCH v2 08/29] python/qemu: Add binutils::binary_get_machines()

2020-01-31 Thread Cornelia Huck
On Wed, 29 Jan 2020 22:23:24 +0100 Philippe Mathieu-Daudé wrote: > Add a helper to query the list of machines built into a QEMU binary. > We simply send the 'query-machines' command over a QMP socket. > > Signed-off-by: Philippe Mathieu-Daudé > --- > python/qemu/binutils.py | 15 +

[Bug 1860920] Re: qemu-s390x-softmmu: crash

2020-01-31 Thread Thomas Huth
Suggested patch: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg07514.html "target/s390x/translate: Fix RNSBG instruction" ** Changed in: qemu Assignee: (unassigned) => Thomas Huth (th-huth) ** Changed in: qemu Status: New => Confirmed -- You received this bug notification

Re: [PATCH v2 09/29] tests/acceptance: Use 'machine' tag to check if available in QEMU binary

2020-01-31 Thread Cornelia Huck
On Wed, 29 Jan 2020 22:23:25 +0100 Philippe Mathieu-Daudé wrote: > We already use the 'machine' tag in Avocado tests. > If the requested machine is not available in the QEMU binary, > the tests will be cancelled (skipped): > > $ python -m avocado --show=app run > tests/acceptance/x86_cpu_mode

[Bug 1860920] Re: qemu-s390x-softmmu: crash

2020-01-31 Thread Jean-Gabriel Kammerer
Sorry for delay in answering, replacing 0x55 by 0x54 works fine for me. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860920 Title: qemu-s390x-softmmu: crash Status in QEMU: Confirmed

Re: [PATCH] spapr: Enable DD2.3 accelerated count cache flush in pseries-5.0 machine

2020-01-31 Thread Michael Ellerman
David Gibson writes: > For POWER9 DD2.2 cpus, the best current Spectre v2 indirect branch > mitigation is "count cache disabled", which is configured with: > -machine cap-ibs=fixed-ccd > However, this option isn't available on DD2.3 CPUs with KVM, because they > don't have the count cache disa

Re: Improving QOM documentation [Was: Re: Making QEMU easier for management tools and applications]

2020-01-31 Thread Peter Maydell
On Fri, 31 Jan 2020 at 06:11, Markus Armbruster wrote: > Beware, personal opinion. > > When you put documentation next to the code it documents (which you > absolutely should, because it's your only realistic chance to keep the > two in sync), then extracting API comments is useful, because it > c

[Bug 1861468] Re: always fail to build qemu statically

2020-01-31 Thread Peter Maydell
QEMU is not really intended to be built statically except for the 'linux-user' emulators. The configure script will allow you to build the system emulator binaries and the tools statically, but that is more on a "if it happens to work for you, great" basis, rather than a supported one. In general:

Re: [PATCH rc4 24/29] hw/avr: Add some ATmega microcontrollers

2020-01-31 Thread Philippe Mathieu-Daudé
On Fri, Jan 31, 2020 at 10:40 AM Aleksandar Markovic wrote: > On Fri, Jan 31, 2020 at 10:35 AM Thomas Huth wrote: > > On 31/01/2020 05.11, Aleksandar Markovic wrote: > > > On Fri, Jan 31, 2020 at 4:45 AM Aleksandar Markovic > > > wrote: > > >> > > >> On Fri, Jan 31, 2020 at 4:09 AM Philippe Math

Re: Improving QOM documentation [Was: Re: Making QEMU easier for management tools and applications]

2020-01-31 Thread Paolo Bonzini
Il ven 31 gen 2020, 11:36 Peter Maydell ha scritto: > On Fri, 31 Jan 2020 at 06:11, Markus Armbruster wrote: > > Beware, personal opinion. > > > > When you put documentation next to the code it documents (which you > > absolutely should, because it's your only realistic chance to keep the > > tw

Re: [PATCH rc4 24/29] hw/avr: Add some ATmega microcontrollers

2020-01-31 Thread Aleksandar Markovic
On Fri, Jan 31, 2020 at 11:45 AM Philippe Mathieu-Daudé wrote: > > On Fri, Jan 31, 2020 at 10:40 AM Aleksandar Markovic > wrote: > > On Fri, Jan 31, 2020 at 10:35 AM Thomas Huth wrote: > > > On 31/01/2020 05.11, Aleksandar Markovic wrote: > > > > On Fri, Jan 31, 2020 at 4:45 AM Aleksandar Markov

Re: [PATCH] xen-bus/block: explicitly assign event channels to an AioContext

2020-01-31 Thread Anthony PERARD
On Wed, Jan 29, 2020 at 10:22:14PM +, Julien Grall wrote: > Hi Anthony, > > On 19/12/2019 17:11, Anthony PERARD wrote: > > On Mon, Dec 16, 2019 at 02:34:51PM +, Paul Durrant wrote: > > > It is not safe to close an event channel from the QEMU main thread when > > > that channel's poller is

Re: [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral

2020-01-31 Thread Philippe Mathieu-Daudé
On Thu, Jan 30, 2020 at 11:44 PM Aleksandar Markovic wrote: > On Fri, Jan 24, 2020 at 1:07 PM Sarah Harris wrote: > > > > Hi, > > > > Do I understand correctly that you need Ed to email a "Signed-off-by: Ed > > Robbins " himself? > > Ed's cc'ed already, but I'll email him directly to make sure h

Re: [PATCH 1/2] !fixup "hw/misc: Add limited support for AVR power device"

2020-01-31 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > - convert DB_PRINT() to trace-events > - fix style/indentation > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/avr_power.c | 17 + > hw/misc/trace-events | 4 > 2 files changed, 13 insertions(+), 8 deletions(-) > > diff --git a

[Bug 1861468] Re: always fail to build qemu statically

2020-01-31 Thread Alex Bennée
** Tags added: build faq static -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1861468 Title: always fail to build qemu statically Status in QEMU: Invalid Bug description: I want to build qemu

Re: [PATCH 2/2] !fixup "hw/timer: Add limited support for AVR 16-bit timer peripheral"

2020-01-31 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Convert DB_PRINT() to trace events. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/avr_timer16.c | 25 +++-- > hw/timer/trace-events | 12 > 2 files changed, 27 insertions(+), 10 deletions(-) > > diff --git a/hw/ti

Re: [PULL 00/18] Block patches

2020-01-31 Thread Peter Maydell
On Thu, 30 Jan 2020 at 21:31, Stefan Hajnoczi wrote: > > The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200130' into staging (2020-01-30 > 16:19:04 +) > > are available in the Git repo

RE: [RFC v3 06/25] scripts/update-linux-headers: Import iommu.h

2020-01-31 Thread Liu, Yi L
> From: Cornelia Huck [mailto:coh...@redhat.com] > Sent: Wednesday, January 29, 2020 8:25 PM > To: Liu, Yi L > Subject: Re: [RFC v3 06/25] scripts/update-linux-headers: Import iommu.h > > On Wed, 29 Jan 2020 04:16:37 -0800 > "Liu, Yi L" wrote: > > > From: Eric Auger > > > > Update the script t

Re: [RFC PATCH v3 0/6] target/arm/kvm: Adjust virtual time

2020-01-31 Thread Andrea Bolognani
On Mon, 2020-01-20 at 11:10 +0100, Andrew Jones wrote: > v3: > - Added a target/arm/kvm_arm.h comment cleanup patch (1/6) > - Minor refactoring of assert_has_feature_enabled/disabled in 4/6, >kept Richard's r-b. > - Rewrote kvm-no-adjvtime documentation in 6/6. > - Reworked approach in 5/6

RE: [RFC v3 03/25] hw/iommu: introduce IOMMUContext

2020-01-31 Thread Liu, Yi L
Hi David, > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Friday, January 31, 2020 12:07 PM > To: Liu, Yi L > Subject: Re: [RFC v3 03/25] hw/iommu: introduce IOMMUContext > > On Wed, Jan 29, 2020 at 04:16:34AM -0800, Liu, Yi L wrote: > > From: Peter Xu > > > > Currently, many

RE: [RFC v3 02/25] hw/iommu: introduce DualStageIOMMUObject

2020-01-31 Thread Liu, Yi L
Hi David, > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Friday, January 31, 2020 11:59 AM > To: Liu, Yi L > Subject: Re: [RFC v3 02/25] hw/iommu: introduce DualStageIOMMUObject > > On Wed, Jan 29, 2020 at 04:16:33AM -0800, Liu, Yi L wrote: > > From: Liu Yi L > > > > Currentl

RE: [RFC v3 07/25] header file update VFIO/IOMMU vSVA APIs

2020-01-31 Thread Liu, Yi L
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf > Of Cornelia Huck > Sent: Wednesday, January 29, 2020 8:29 PM > To: Liu, Yi L > Subject: Re: [RFC v3 07/25] header file update VFIO/IOMMU vSVA APIs > > On Wed, 29 Jan 2020 04:16:38 -0800 > "Liu, Yi L" wrote: > > > F

Re: [PATCH v2 0/8] qemu-img, qemu-trace-stap, virtfs-proxy-helper: convert to rST

2020-01-31 Thread Peter Maydell
I know it's only a week, but could I ping for review on this? (statements of the form "I do want to review but need more time" also welcome.) Given the potential for conflicts with other changes that touch the docs, plus that there's other patchsets which depend on this one, it would be nice to put

Re: [RFC PATCH v3 0/6] target/arm/kvm: Adjust virtual time

2020-01-31 Thread Peter Maydell
On Fri, 31 Jan 2020 at 11:40, Andrea Bolognani wrote: > > On Mon, 2020-01-20 at 11:10 +0100, Andrew Jones wrote: > > v3: > > - Added a target/arm/kvm_arm.h comment cleanup patch (1/6) > > - Minor refactoring of assert_has_feature_enabled/disabled in 4/6, > >kept Richard's r-b. > > - Rewrote

Re: [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum

2020-01-31 Thread Andrey Shinkevich
On 29/01/2020 17:17, Thomas Huth wrote: Commit d9df28e7b07 ("iotests: check whitelisted formats") added the modern @iotests.skip_if_unsupported() to the functions in this test, so we don't need the old explicit test here anymore. Signed-off-by: Thomas Huth --- tests/qemu-iotests/139 | 3 ---

Re: Making QEMU easier for management tools and applications

2020-01-31 Thread Eric Blake
On 1/28/20 9:36 AM, Markus Armbruster wrote: Cc: Eric for netdev_add QAPIfication. These are the known "cheats" in QMP. There's also netdev_add, but Eric has patches to QAPIfy it properly. Eric, I hope you can dust them off. Yes, I'll move that up on my todo list. When I originally did t

Re: Making QEMU easier for management tools and applications

2020-01-31 Thread Eric Blake
On 1/28/20 6:54 AM, Kevin Wolf wrote: The arguments as dotted keys: id=bar,backend.type=file,backend.data.out=/tmp/bar.log Observe there's quite some of nesting. While that's somewhat cumbersome in JSON, it's a lot worse with dotted keys, because there nesting means repeated key prefixe

Re: [PATCH 1/2] !fixup "hw/misc: Add limited support for AVR power device"

2020-01-31 Thread Philippe Mathieu-Daudé
On Fri, Jan 31, 2020 at 12:27 PM Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > > > - convert DB_PRINT() to trace-events > > - fix style/indentation > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > hw/misc/avr_power.c | 17 + > > hw/misc/trace-events | 4 >

[Bug 1860759] Re: [REGRESSION] option `-snapshot` ignored with blockdev

2020-01-31 Thread Max Reitz
Hi, The technical difference is that -blockdev requires you (the user or management software) to create all block graph nodes explicitly. -drive snapshot=on implicitly creates a qcow2 node above the actual disk image (and that node points to a temporary image in /tmp). So because it’s implicit a

[PATCH v7 07/11] fw_cfg: introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v7 00/11] error: auto propagated local_err part I

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Hi all! v7 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v7 Changes v6->v7: 01: - improve commit message - fix typo in comment [Eric] - add Eric's and Greg's r-b 02: - grammar/wording [Eric] - add Eric's and Greg's r-b 03: - improve com

[PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Add functions to clean Error **errp: call corresponding Error *err cleaning function an set pointer to NULL. New functions: error_free_errp error_report_errp warn_report_errp Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Eric Blake --- CC: Eric Blake C

[PATCH v7 04/11] hw/sd/ssi-sd: fix error handling in ssi_sd_realize

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
It's wrong to use same err object as errp parameter for several function calls without intermediate checking for error: we'll crash if try to set err object twice. Fix that, using new ERRP_AUTO_PROPAGATE macro. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- hw/sd/ssi-s

[PATCH v7 06/11] pflash: introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v7 08/11] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v7 09/11] TPM: introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v7 02/11] error: auto propagated local_err

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. It has three goals: 1. Fix issue with error_fatal and error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than informati

[PATCH v7 05/11] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v7 11/11] xen: introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v7 10/11] nbd: introduce ERRP_AUTO_PROPAGATE

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

Re: [PATCH v5 02/41] target/arm: Enable HCR_E2H for VHE

2020-01-31 Thread Peter Maydell
On Wed, 29 Jan 2020 at 23:56, Richard Henderson wrote: > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h| 7 --- > target/arm/helper.c | 6 +- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/target/arm/cpu.h b/target/arm/cpu

[PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \

Re: [PATCH 0/5] python/qemu: qmp: Fix, delint and improvements

2020-01-31 Thread Wainer dos Santos Moschetta
On 1/30/20 8:41 PM, Philippe Mathieu-Daudé wrote: On 12/27/19 2:40 PM, Wainer dos Santos Moschetta wrote: I started fixing an issue on exception handling which in some places currently use the deprecated (in Python 3.3) `socket.error`. Then I ended up delinting the module code and making some

Re: [PATCH v5 30/41] target/arm: Flush tlb for ASID changes in EL2&0 translation regime

2020-01-31 Thread Peter Maydell
On Wed, 29 Jan 2020 at 23:56, Richard Henderson wrote: > > Since we only support a single ASID, flush the tlb when it changes. > > Note that TCR_EL2, like TCR_EL1, has the A1 bit that chooses between > the two TTBR* registers for the location of the ASID. > > Signed-off-by: Richard Henderson > --

Re: [Xen-devel] [PATCH v7 00/11] error: auto propagated local_err part I

2020-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200131130118.1716-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v7 00/11] error: auto propagated local_err part I Message-id: 20200131130118.1716-

Re: [PATCH v5 31/41] target/arm: Flush tlbs for E2&0 translation regime

2020-01-31 Thread Peter Maydell
On Wed, 29 Jan 2020 at 23:56, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v5: Flush all EL2 regimes with TLBI ALLE2 (pmm). > --- > target/arm/helper.c | 34 +++--- > 1 file changed, 27 insertions(+), 7 deletions(-) Reviewed-by: Peter Maydell

Re: [PATCH v5 28/41] target/arm: Add VHE system register redirection and aliasing

2020-01-31 Thread Peter Maydell
On Wed, 29 Jan 2020 at 23:56, Richard Henderson wrote: > > Several of the EL1/0 registers are redirected to the EL2 version when in > EL2 and HCR_EL2.E2H is set. Many of these registers have side effects. > Link together the two ARMCPRegInfo structures after they have been > properly instantiated

Re: [Xen-devel] [PATCH v7 00/11] error: auto propagated local_err part I

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
31.01.2020 16:12, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200131130118.1716-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v7 00/11] error: auto propagated l

Re: [PATCH v2 29/29] MAINTAINERS: Add Acceptance tests reviewers

2020-01-31 Thread Wainer dos Santos Moschetta
On 1/30/20 6:41 AM, Thomas Huth wrote: On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote: Acceptance tests can test any piece of the QEMU codebase. As such, the directory holding them does not belong to a specific subsystem with designated maintainers. Each subsystem covered by a test is welc

Re: [PATCH v10 1/2] docs: improve qcow2 spec about extending image header

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
20.01.2020 22:42, Eric Blake wrote: On 1/20/20 11:13 AM, Vladimir Sementsov-Ogievskiy wrote: Make it more obvious how to add new fields to the version 3 header and how to interpret them. The specification is adjusted so for new defined optional fields: s/so for/so that for/ 1. Software may

Re: [PULL 0/5] Tracing patches

2020-01-31 Thread Peter Maydell
On Thu, 30 Jan 2020 at 21:38, Stefan Hajnoczi wrote: > > The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200130' into staging (2020-01-30 > 16:19:04 +) > > are available in the Git repo

Re: [PATCH v10 1/2] docs: improve qcow2 spec about extending image header

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
21.01.2020 19:18, Max Reitz wrote: On 20.01.20 20:42, Eric Blake wrote: On 1/20/20 11:13 AM, Vladimir Sementsov-Ogievskiy wrote: Make it more obvious how to add new fields to the version 3 header and how to interpret them. The specification is adjusted so for new defined optional fields: s/s

[PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
The patch adds a new additional field to the qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (ZSTD) is to be added in further commit. Suggested-by: Deni

[PATCH v11 1/2] docs: improve qcow2 spec about extending image header

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Make it more obvious how to add new fields to the version 3 header and how to interpret them. The specification is adjusted so that for new defined optional fields: 1. Software may support some of these optional fields and ignore the others, which means that features may be backported to downs

[PATCH v11 0/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
v11: 01: grammar/wording [Eric] add Eric's r-b 02: empty lines between paragraphs [Eric] Vladimir Sementsov-Ogievskiy (2): docs: improve qcow2 spec about extending image header docs: qcow2: introduce compression type feature docs/interop/qcow2.txt | 62 +++

Re: [PATCH v5 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2020-01-31 Thread Philippe Mathieu-Daudé
On 1/31/20 8:08 AM, Thomas Huth wrote: On 30/01/2020 23.31, Philippe Mathieu-Daudé wrote: On 1/21/20 10:52 AM, Thomas Huth wrote: We are going to enable some of the python-based tests in the "auto" group, and these tests require virtio-blk to work properly. Running iotests without virtio-blk li

Re: [PULL 0/5] Tracing patches

2020-01-31 Thread Philippe Mathieu-Daudé
On 1/31/20 2:57 PM, Peter Maydell wrote: On Thu, 30 Jan 2020 at 21:38, Stefan Hajnoczi wrote: The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200130' into staging (2020-01-30 16:19:04 +

Re: [PATCH rc4 00/29] target/avr merger

2020-01-31 Thread Michael Rolnik
Looks good. Thanks On Fri, Jan 31, 2020 at 3:24 AM Philippe Mathieu-Daudé wrote: > On 1/31/20 1:12 AM, Aleksandar Markovic wrote: > > Michael, Philippe, > > > > Can you guys do a quick checkup of this rc4? rc4, rc3,and rc2 should > > be functionally 100% equivalent. > > Tested OK. > > git-backpo

Re: [PULL 0/5] Tracing patches

2020-01-31 Thread Philippe Mathieu-Daudé
On 1/31/20 3:38 PM, Philippe Mathieu-Daudé wrote: On 1/31/20 2:57 PM, Peter Maydell wrote: On Thu, 30 Jan 2020 at 21:38, Stefan Hajnoczi wrote: The following changes since commit 928173659d6e5dc368284f73f90ea1d129e1f57d:    Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-a

[Bug 1851972] Re: pc-q35-4.1 and AMD Navi 5700/XT incompatible

2020-01-31 Thread Joey Adams
Commit d1972be13f ("accel/kvm: Make "kernel_irqchip" default on") fixes the default mixup I described above. This isn't related to Marshall's issue as it involves qemu 3.0 vs 3.1, but at least it cleans up some confusion. -- You received this bug notification because you are a member of qemu- de

Re: [PATCH v11 1/2] docs: improve qcow2 spec about extending image header

2020-01-31 Thread Eric Blake
On 1/31/20 8:22 AM, Vladimir Sementsov-Ogievskiy wrote: Make it more obvious how to add new fields to the version 3 header and how to interpret them. The specification is adjusted so that for new defined optional fields: 1. Software may support some of these optional fields and ignore the o

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Eric Blake
On 1/31/20 8:22 AM, Vladimir Sementsov-Ogievskiy wrote: The patch adds a new additional field to the qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (Z

Re: [PATCH 1/2] !fixup "hw/misc: Add limited support for AVR power device"

2020-01-31 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On Fri, Jan 31, 2020 at 12:27 PM Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >> > - convert DB_PRINT() to trace-events >> > - fix style/indentation >> > >> > Signed-off-by: Philippe Mathieu-Daudé >> > --- >> > hw/misc/avr_power.c | 17 +-

[Bug 1859310] Re: libvirt probing fails due to assertion failure with KVM and 'none' machine type

2020-01-31 Thread Joey Adams
This was fixed in commit 8f54bbd0b4 "x86: Check for machine state object class before typecasting it". ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [PATCH 5/6] tests/boot_linux_console: add extract_from_rpm method

2020-01-31 Thread Liam Merwick
On 30/01/2020 19:19, Wainer dos Santos Moschetta wrote: On 1/30/20 1:34 PM, Liam Merwick wrote: On 30/01/2020 12:05, Stefano Garzarella wrote: On Mon, Jan 27, 2020 at 04:36:33PM +, Liam Merwick wrote: Add a method to extract a specified file from an RPM to the test's working directory and

Re: [PATCH 6/6] tests/boot_linux_console: add PVH acceptance tests

2020-01-31 Thread Liam Merwick
On 30/01/2020 23:57, Philippe Mathieu-Daudé wrote: On 1/27/20 5:36 PM, Liam Merwick wrote: Add tests to boot an uncompressed kernel using the x86/HVM direct boot ABI. The vmlinux binary is obtained from a small RPM for Kata containers and extracted using the new extract_from_rpm() method. Sign

[PATCH v4 08/80] alpha/dp264: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 13/80] arm/digic_boards: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 01/80] numa: remove deprecated -mem-path fallback to anonymous RAM

2020-01-31 Thread Igor Mammedov
it has been deprecated since 4.0 by commit cb79224b7 (deprecate -mem-path fallback to anonymous RAM) Deprecation period ran out and it's time to remove it so it won't get in a way of switching to using hostmem backend for RAM. Signed-off-by: Igor Mammedov --- CC:libvir-l...@redhat.com CC: ehabk.

[PATCH v4 02/80] machine: introduce memory-backend property

2020-01-31 Thread Igor Mammedov
Property will contain link to memory backend that will be used for backing initial RAM. Follow up commit will alias -mem-path and -mem-prealloc CLI options into memory backend options to make memory handling consistent (using only hostmem backend family for guest RAM allocation). Signed-off-by: Ig

[PATCH v4 04/80] machine: introduce convenience MachineState::ram

2020-01-31 Thread Igor Mammedov
the new field will be used by boards to get access to main RAM memory region and will help to save boiler plate in boards which often introduce a field or variable just for this purpose. Memory region will be equivalent to what currently used memory_region_allocate_system_memory() is returning apa

[PATCH v4 05/80] initialize MachineState::ram in NUMA case

2020-01-31 Thread Igor Mammedov
In case of NUMA there are 2 cases to consider: 1. '-numa node,memdev', the only one that will be available for 5.0 and newer machine types. In this case reuse current behavior, with only difference memdevs are put into MachineState::ram container + a temporary glue to keep memory_

[PATCH v4 10/80] arm/aspeed: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 12/80] arm/cubieboard: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 03/80] machine: alias -mem-path and -mem-prealloc into memory-foo backend

2020-01-31 Thread Igor Mammedov
Allow machine to opt in for hostmem backend based initial RAM even if user uses old -mem-path/prealloc options by providing MachineClass::default_ram_id Follow up patches will incrementally convert machines to new API, by dropping memory_region_allocate_system_memory() and setting default_ram_id

[PATCH v4 11/80] arm/collie: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 06/80] vl.c: move -m parsing after memory backends has been processed

2020-01-31 Thread Igor Mammedov
It will be possible for main RAM to come from memory-backend and we should check that size specified in -m matches the size of the backend and [MachineState::]ram_size also matches backend's size. However -m parsing (set_memory_options()) happens before backends are intialized (object_create_delay

[PATCH v4 31/80] arm/versatilepb: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 33/80] arm/virt: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and then map memory region provided by MachineState::ram

[PATCH v4 07/80] vl.c: ensure that ram_size matches size of machine.memory-backend

2020-01-31 Thread Igor Mammedov
Extend set_memory_options() to check that size specified by -m matches the size of backend pointed by memory-backend. And in case of -m was omitted adjust ram_size to match that of explicitly provided backend. Signed-off-by: Igor Mammedov --- CC: pa...@linux.ibm.com CC: pbonz...@redhat.com --- v

[PATCH v4 09/80] arm/aspeed: actually check RAM size

2020-01-31 Thread Igor Mammedov
It's supposed that SOC will check if "-m" provided RAM size is valid by setting "ram-size" property and then board would read back valid (possibly corrected value) to map RAM MemoryReging with valid size. It isn't doing so, since check is called only indirectly from aspeed_sdmc_reset()->asc->comp

[PATCH v4 15/80] arm/imx25_pdk: drop RAM size fixup

2020-01-31 Thread Igor Mammedov
If user provided non-sense RAM size, board will complain and continue running with max RAM size supported. Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user. Make it error message and exit to force user fix CLI, instead of accepting non-

[PATCH v4 41/80] hppa: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 19/80] arm/kzm: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 14/80] arm/highbank: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 24/80] arm/musicpal: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 22/80] arm/mps2-tz: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 16/80] arm/imx25_pdk: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

[PATCH v4 00/80] refactor main RAM allocation to use hostmem backend

2020-01-31 Thread Igor Mammedov
v4: - pick up new Reviewed-by-s - Fix access to uninitialized pagesize/hpsize in "[PATCH REPOST v3 74/80] exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()" - Make explicitly provided memory-backend work by using string property instead of link so it would be possible to de

[PATCH v4 46/80] m68k/an5206: use memdev for RAM

2020-01-31 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializi

  1   2   3   >