Re: [PATCH v3 08/21] migration: Make multifd_load_setup() get an Error parameter

2020-01-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We need to change the full chain to pass the Error parameter. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > > --- > > Always use a local_err, and in case of error propagate/print it as needed. > --- > migration/migratio

Re: [PATCH] s390x: sigp: Fix sense running reporting

2020-01-24 Thread David Hildenbrand
> No idea. > How many people use smp with tcg? > The kernel uses it (pcpu_running()) to decide whether - To send an emergency call or an external call (external calls are faster when the CPU is already running - e.g., SIE HW assist) - In arch_vcpu_is_preempted(), for an heuristic So nothing

Re: [PULL 12/29] target/ppc: move FP and VMX registers into aligned vsr register array

2020-01-24 Thread Peter Maydell
On Tue, 8 Jan 2019 at 22:46, David Gibson wrote: > > From: Mark Cave-Ayland > > The VSX register array is a block of 64 128-bit registers where the first 32 > registers consist of the existing 64-bit FP registers extended to 128-bit > using new VSR registers, and the last 32 registers are the VMX

Re: [PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 1

2020-01-24 Thread Peter Maydell
On Tue, 21 Jan 2020 at 23:41, Palmer Dabbelt wrote: > > The following changes since commit 28b58f19d269633b3d14b6aebf1e92b3cd3ab56e: > > ui/gtk: Get display refresh rate with GDK version 3.22 or later (2020-01-16 > 14:03:45 +) > > are available in the Git repository at: > > g...@github.co

Re: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)

2020-01-24 Thread Kevin Wolf
Am 24.01.2020 um 11:48 hat Felipe Franciosi geschrieben: > > On Jan 24, 2020, at 10:04 AM, Philippe Mathieu-Daudé > > wrote: > > On 1/23/20 11:58 PM, Peter Lieven wrote: > >>> Am 23.01.2020 um 22:29 schrieb Felipe Franciosi : > On Jan 23, 2020, at 5:46 PM, Philippe Mathieu-Daudé > wro

Re: [PATCH v3 18/21] migration: Make no compression operations into its own structure

2020-01-24 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> It will be used later. >> >> Signed-off-by: Juan Quintela >> >> +int migrate_multifd_method(void) >> +{ >> +MigrationState *s; >> + >> +s = migrate_get_current(); >> + >> +return s->parameters.multifd

Re: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)

2020-01-24 Thread Philippe Mathieu-Daudé
On 1/24/20 2:39 PM, Kevin Wolf wrote: Am 24.01.2020 um 11:48 hat Felipe Franciosi geschrieben: On Jan 24, 2020, at 10:04 AM, Philippe Mathieu-Daudé wrote: On 1/23/20 11:58 PM, Peter Lieven wrote: Am 23.01.2020 um 22:29 schrieb Felipe Franciosi : On Jan 23, 2020, at 5:46 PM, Philippe Mathieu-D

Re: [PATCH v3 19/21] migration: Add zlib compression multifd support

2020-01-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > hw/core/qdev-properties.c| 2 +- > migration/Makefile.objs | 1 + > migration/multifd-zlib.c | 289 +++ > migration/multifd.c | 6 + > migration/multifd.

Re: [PATCH] iscsi: Don't access non-existent scsi_lba_status_descriptor

2020-01-24 Thread Kevin Wolf
Am 23.01.2020 um 21:37 hat John Snow geschrieben: > On 1/23/20 12:05 PM, Kevin Wolf wrote: > > In iscsi_co_block_status(), we may have received num_descriptors == 0 > > from the iscsi server. Therefore, we can't unconditionally access > > lbas->descriptors[0]. Add the missing check. > > > > Signed

Re: [PATCH v3 18/21] migration: Make no compression operations into its own structure

2020-01-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> It will be used later. > >> > >> Signed-off-by: Juan Quintela > >> > > >> +int migrate_multifd_method(void) > >> +{ > >> +MigrationState *s; > >> + > >> +

[PATCH v2] s390x: sigp: Fix sense running reporting

2020-01-24 Thread Janosch Frank
The logic was inverted and reported running if the cpu was stopped. Let's fix that. Signed-off-by: Janosch Frank Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS") Reviewed-by: David Hildenbrand --- Switched the actions instead of the condition so the comment still applies.

Re: qemu-img convert vs writing another copy tool

2020-01-24 Thread Richard W.M. Jones
On Fri, Jan 24, 2020 at 09:55:55AM +, Richard W.M. Jones wrote: > On Thu, Jan 23, 2020 at 01:21:28PM -0600, Eric Blake wrote: > > Could we also teach this to parse 'qemu-img map --output=json' > > format? And/or add 'qemu-img map --output=XYZ' (different from the > > current --output=human') th

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Laurent Vivier
On 24/01/2020 13:43, Amit Shah wrote: > On Thu, 2020-01-23 at 16:16 +0100, Laurent Vivier wrote: >> The kernel needs sometime to be able to cancel an ongoing command. >> >> For instance, if the virtio-rng device uses the egd backend >> and this backend doesn't provide data, the buffer provided by t

Re: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)

2020-01-24 Thread Kevin Wolf
Am 24.01.2020 um 14:42 hat Philippe Mathieu-Daudé geschrieben: > On 1/24/20 2:39 PM, Kevin Wolf wrote: > > Am 24.01.2020 um 11:48 hat Felipe Franciosi geschrieben: > > > On Jan 24, 2020, at 10:04 AM, Philippe Mathieu-Daudé > > > wrote: > > > > Also shouldn't we report some warning in case of such

Re: [Question] Regarding containers "unattached/peripheral/anonymous" - their relation with hot(un)plug of devices

2020-01-24 Thread Igor Mammedov
On Fri, 24 Jan 2020 11:20:15 + Salil Mehta wrote: > Hello, > I am working on vCPU Hotplug feature for ARM64 and I am in mid of > understanding some aspect of device_add/device_del interface of the QEMU. > > Observations: > 1. Any object initialised by qmp_device_add() gets into /machine/una

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Stefan Hajnoczi
On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: > The kernel needs sometime to be able to cancel an ongoing command. > > For instance, if the virtio-rng device uses the egd backend > and this backend doesn't provide data, the buffer provided by the > kernel is kept as long as it is

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Laurent Vivier
On 24/01/2020 12:02, Stefan Hajnoczi wrote: > On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: >> The kernel needs sometime to be able to cancel an ongoing command. >> >> For instance, if the virtio-rng device uses the egd backend >> and this backend doesn't provide data, the buffer

Re: [PATCH rc2 00/25] target/avr merger

2020-01-24 Thread Michael Rolnik
Just one patch attached. Thanks. On Fri, Jan 24, 2020 at 2:49 PM Philippe Mathieu-Daudé wrote: > On 1/24/20 12:41 PM, Michael Rolnik wrote: > > Tested-by: Michael Rolnik mailto:mrol...@gmail.com>> > > Thanks a lot! > > > The only thing I want to change is instead of -kernel put -bios in > > qemu

Re: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)

2020-01-24 Thread Philippe Mathieu-Daudé
On 1/24/20 2:52 PM, Kevin Wolf wrote: Am 24.01.2020 um 14:42 hat Philippe Mathieu-Daudé geschrieben: On 1/24/20 2:39 PM, Kevin Wolf wrote: Am 24.01.2020 um 11:48 hat Felipe Franciosi geschrieben: On Jan 24, 2020, at 10:04 AM, Philippe Mathieu-Daudé wrote: Also shouldn't we report some warnin

Re: [PATCH 0/5] target/s390x: Do not leak stack address in translate_one

2020-01-24 Thread Cornelia Huck
On Fri, 24 Jan 2020 10:43:32 +0100 Thomas Huth wrote: > On 24/01/2020 00.22, Richard Henderson wrote: > > Thomas' patch avoids the leak, but I think we can do a bit more to > > cleaning in this area, and move the structure inline to DisasContext. > > > Sounds like a good idea to me. Cornelia, c

Re: [PATCH 0/5] target/s390x: Do not leak stack address in translate_one

2020-01-24 Thread Cornelia Huck
On Thu, 23 Jan 2020 13:22:43 -1000 Richard Henderson wrote: > Thomas' patch avoids the leak, but I think we can do a bit more to > cleaning in this area, and move the structure inline to DisasContext. > > > r~ > > > Richard Henderson (5): > target/s390x: Move struct DisasFields definition e

Re: [PATCH] hw/s390x: Add a more verbose comment about get_machine_class() and the wrappers

2020-01-24 Thread David Hildenbrand
On 23.01.20 18:02, Thomas Huth wrote: > While working on the "Enable adapter interruption suppression again" > recently, I had to discover that the meaning of get_machine_class() > and the related *_allowed() wrappers is not very obvious. Add a more > verbose comment here to clarify how these shoul

Re: [PULL v2 00/59] Misc (x86 and QOM) patches for 2020-01-23

2020-01-24 Thread Paolo Bonzini
On 24/01/20 00:31, Richard Henderson wrote: > On 1/23/20 9:20 AM, Paolo Bonzini wrote: >> Il gio 23 gen 2020, 19:43 Peter Maydell > > ha scritto: >> When I try to build-test this merge, the clang sanitizer >> build seems to fail whenever it tries to link any

Re: [PULL v2 00/59] Misc (x86 and QOM) patches for 2020-01-23

2020-01-24 Thread Paolo Bonzini
On 24/01/20 11:11, Peter Maydell wrote: > On Fri, 24 Jan 2020 at 09:18, Paolo Bonzini wrote: >> >> The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: >> >> Merge remote-tracking branch >> 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 >> 15:2

Re: [PATCH] hw/s390x: Add a more verbose comment about get_machine_class() and the wrappers

2020-01-24 Thread Cornelia Huck
On Thu, 23 Jan 2020 18:02:56 +0100 Thomas Huth wrote: > While working on the "Enable adapter interruption suppression again" > recently, I had to discover that the meaning of get_machine_class() > and the related *_allowed() wrappers is not very obvious. Add a more > verbose comment here to clari

Re: Making QEMU easier for management tools and applications

2020-01-24 Thread Kevin Wolf
Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: > On Fri, Jan 24, 2020 at 08:59:41AM +0100, Markus Armbruster wrote: > > John Snow writes: > > > > > On 1/23/20 2:01 PM, Daniel P. Berrangé wrote: > > >> So when configuring objects you'll always provide a JSON/YAML doc. > > >> They've go

Documentation and VFIO on SPARC

2020-01-24 Thread Graeme Brett Houston
2 Queries: 1st is there any Good Documentation on Writing VGA devices? 2nd Can VFIO devices be successfully passed to the sparc engine & hopefully Solaris 9 actually bootup I am thinking a Actual PCI SPARC Card with OpenFirmware ROM and other dev ices i am interested in getting a PCI trace f

Re: [PATCH v2] s390x: sigp: Fix sense running reporting

2020-01-24 Thread Cornelia Huck
On Fri, 24 Jan 2020 08:48:18 -0500 Janosch Frank wrote: > The logic was inverted and reported running if the cpu was stopped. > Let's fix that. > > Signed-off-by: Janosch Frank > Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS") > Reviewed-by: David Hildenbrand > --- > >

RE: [Question] Regarding containers "unattached/peripheral/anonymous" - their relation with hot(un)plug of devices

2020-01-24 Thread Salil Mehta
> From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Friday, January 24, 2020 1:54 PM > To: Salil Mehta > > On Fri, 24 Jan 2020 11:20:15 + > Salil Mehta wrote: > > > Hello, > > I am working on vCPU Hotplug feature for ARM64 and I am in mid of > > understanding > > some aspect of devi

[PATCH] acpi: cpuhp: document how to use CPHP_GET_CPU_ID_CMD command

2020-01-24 Thread Igor Mammedov
Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but did not sufficiently described how to use it. Fix it by adding missing command documentation and suggested work-flow to enumerate possible architecture specific CPU IDs. Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD comman

Re: [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests

2020-01-24 Thread Philippe Mathieu-Daudé
On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: Added boot Linux test cases that launch QEMU with kvm enabled. Likewise it was added tests for tcg. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/boot_linux_console.py | 88 -- 1 file changed, 68

[PATCH v2 1/4] linux-user: Add support for FS_IOC_FSXATTR ioctls

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Both FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR accept a pointer to the structure struct fsxattr { __u32 fsx_xflags; /* xflags field value (get/set) */ __u32 fsx_extsize;/* extsize field value (get/set)*/ __u32 fsx_nextents; /*

Re: [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests

2020-01-24 Thread Thomas Huth
On 24/01/2020 16.45, Philippe Mathieu-Daudé wrote: > On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: >> Added boot Linux test cases that launch QEMU with kvm >> enabled. Likewise it was added tests for tcg. >> >> Signed-off-by: Wainer dos Santos Moschetta >> --- >>   tests/acceptance/boot_l

[PATCH v2 4/4] linux-user: Add support for FDGETFDCSTAT ioctl

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic FDGETFDCSTAT's third agrument is a pointer to the structure: struct floppy_fdc_state { int spec1; int spec2; int dtr; unsigned char version; unsigned char dor; unsigned long address; unsigned int rawcmd:2; unsigned int reset:1; unsign

[PATCH v2 0/4] linux-user: Add support for fs and fd ioctls

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This series is a spin-off of v5 of earlier series "linux-user: Misc patches for 5.0", that became too large to manage. I will submit the rest of that large series separately. The only difference between patches in this series and in the former series is that all Laurent

[PATCH v2 2/4] linux-user: Add support for FITRIM ioctl

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic FITRIM ioctl accepts a pointer to the structure struct fstrim_range { __u64 start; __u64 len; __u64 minlen; }; as its third argument. All ioctls in this group (FI* ioctl) are guarded with "#ifdef", so the guards are used in this implementation too for cons

Re: [Bug 1860759] Re: [REGRESSION] option `-snapshot` ignored with blockdev

2020-01-24 Thread Eric Blake
On 1/24/20 4:41 AM, Ildar wrote: Max, thanks a lot for the explanation. Do you mean that snapshot-ing isn't possible totally for blockdev? Then I guess some libvirt users are in trouble :(( Actually I didn't quite caught the reason why a blockdev supports backing but not {backing to a file on /tm

[PATCH v2 3/4] linux-user: Add support for FIFREEZE and FITHAW ioctls

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Both FIFREEZE and FITHAW ioctls accept an integer as their third argument. All ioctls in this group (FI* ioctl) are guarded with "#ifdef", so the guards are used in this implementation too for consistency (however, many of ioctls in FI* group became old enough that thei

Re: [PATCH] acpi: cpuhp: document how to use CPHP_GET_CPU_ID_CMD command

2020-01-24 Thread Laszlo Ersek
Hi Igor, On 01/24/20 16:17, Igor Mammedov wrote: > Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but > did not sufficiently described how to use it. Fix it by adding > missing command documentation and suggested work-flow to enumerate > possible architecture specific CPU IDs. > > Fix

Re: [Question] Regarding containers "unattached/peripheral/anonymous" - their relation with hot(un)plug of devices

2020-01-24 Thread Igor Mammedov
On Fri, 24 Jan 2020 15:02:10 + Salil Mehta wrote: > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Friday, January 24, 2020 1:54 PM > > To: Salil Mehta > > > > On Fri, 24 Jan 2020 11:20:15 + > > Salil Mehta wrote: > > > > > Hello, > > > I am working on vCPU Hotplug fea

Re: [PATCH v3 09/21] migration: Add multifd-compress parameter

2020-01-24 Thread Eric Blake
On 1/23/20 5:58 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- Rename it to NONE Fix typos (dave) We don't need to chek values returned by visit_type_MultifdCompress (markus) Fix yet more typos (wei) --- hw/core/q

Booting Debian in qemu-system-alpha

2020-01-24 Thread John Paul Adrian Glaubitz
Hi! Has anyone had any success recently booting Debian on qemu-system-alpha? I just built qemu-system using the alpha-softmmu target from git and tried to run Debian's Alpha port but the output hangs very early: root@nofan:/local_scratch/alpha-system> ./qemu-system-alpha -m 512 -nographic -driv

Re: [PATCH v3 19/21] migration: Add zlib compression multifd support

2020-01-24 Thread Eric Blake
On 1/23/20 5:58 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela --- +++ b/qapi/migration.json @@ -499,7 +499,7 @@ # ## { 'enum': 'MultifdCompress', - 'data': [ 'none' ] } + 'data': [ 'none', 'zlib' ] } Patch 9 added 'none' and documented it; it looks odd if 'zlib' is not d

Re: [PATCH v3 21/21] migration: Add zstd compression multifd support

2020-01-24 Thread Eric Blake
On 1/23/20 5:58 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/migration.c| 6 + migration/multifd-zstd.c | 304 +++ migration/multifd.h

[PATCH v2 0/8] qemu-img, qemu-trace-stap, virtfs-proxy-helper: convert to rST

2020-01-24 Thread Peter Maydell
This patchset converts the following documentation to rST format: * qemu-img * qemu-trace-stap * virtfs-proxy-helper (That means everything in step 3 in the plan: https://wiki.qemu.org/Features/Documentation#3:_Convert_things_which_are_mostly_standalone_manpages will be done except for qemu-cpu

[PATCH v2 1/8] Makefile: Ensure we don't run Sphinx in parallel for manpages

2020-01-24 Thread Peter Maydell
Sphinx will corrupt its doctree cache if we run two copies of it in parallel. In commit 6bda415c10d966c8d3 we worked around this by having separate doctrees for 'html' vs 'manpage' runs. However now that we have more than one manpage produced from a single manual we can run into this again when try

[PATCH v2 2/8] hxtool: Support SRST/ERST directives

2020-01-24 Thread Peter Maydell
We want to add support for including rST document fragments in our .hx files, in the same way we currently have texinfo fragments. These will be delimited by SRST and ERST directives, in the same way the texinfo is delimited by STEXI/ETEXI. The rST fragments will not be extracted by the hxtool scri

[PATCH v2 6/8] qemu-img-cmds.hx: Remove texinfo document fragments

2020-01-24 Thread Peter Maydell
Now the qemu-img documentation has been converted to rST, we can remove the texinfo document fragments from qemu-img-cmds.hx, as they are no longer used. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- qemu-img-cmds.hx | 56 +++- 1 fil

[PATCH v2 3/8] docs/sphinx: Add new hxtool Sphinx extension

2020-01-24 Thread Peter Maydell
Some of our documentation includes sections which are created by assembling fragments of texinfo from a .hx source file into a .texi file, which is then included from qemu-doc.texi or qemu-img.texi. For Sphinx, rather than creating a file to include, the most natural way to handle this is to have

[PATCH v2 7/8] scripts/qemu-trace-stap: Convert documentation to rST

2020-01-24 Thread Peter Maydell
The qemu-trace-stap documentation is currently in scripts/qemu-trace-stap.texi in Texinfo format, which we present to the user as: * a qemu-trace-stap manpage * but not (unusually for QEMU) part of the HTML docs Convert the documentation to rST format that lives in the docs/ subdirectory, and pr

[PATCH v2 5/8] qemu-img: Convert invocation documentation to rST

2020-01-24 Thread Peter Maydell
The qemu-img documentation is currently in qemu-nbd.texi in Texinfo format, which we present to the user as: * a qemu-img manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-img manpage * part of the inter

[PATCH v2 4/8] qemu-img-cmds.hx: Add rST documentation fragments

2020-01-24 Thread Peter Maydell
Add the rST versions of the documentation fragments. Once we've converted qemu-img.texi to rST we can delete the texi fragments; for the moment we leave them in place. (Commit created with the aid of emacs query-replace-regexp from "@var{\([^}]*\)}" to "\,(upcase \1))".) Signed-off-by: Peter Mayd

[PATCH v2 8/8] virtfs-proxy-helper: Convert documentation to rST

2020-01-24 Thread Peter Maydell
The virtfs-proxy-helper documentation is currently in fsdev/qemu-trace-stap.texi in Texinfo format, which we present to the user as: * a virtfs-proxy-helper manpage * but not (unusually for QEMU) part of the HTML docs Convert the documentation to rST format that lives in the docs/ subdirectory,

Re: [PULL v2 00/59] Misc (x86 and QOM) patches for 2020-01-23

2020-01-24 Thread Peter Maydell
On Fri, 24 Jan 2020 at 09:18, Paolo Bonzini wrote: > > The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 > 15:29:25 +) > > are available in the git reposit

Re: QEMU for aarch64 with plugins seems to fail basic consistency checks

2020-01-24 Thread Alex Bennée
Robert Henry writes: > I wrote a QEMU plugin for aarch64 where the insn and mem callbacks > print out the specifics of the guest instructions as they are > "executed". I expect this trace stream to be well behaved but it is > not. Can you post your plugin? It's hard to diagnose what might be

[PATCH v4 5/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch adds a field "target_info" to the structure disassemble_info. The purpose of this field is to enable targets to pass to disassembler code any additional data thet deem suitable. Signed-off-by: Aleksandar Markovic --- include/disas/dis-asm.h | 3 +++ 1 file

[PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains a variety of fixes and improvements for target MIPS. v3->v4: - split micromips R6 disassembler patch to more manageable parts - added new field to disassemble_info structure - CRC32 refactoring is as is in this version, but refactoring is

[PATCH v4 3/7] target/mips: Amend CP0 WatchHi register implementation

2020-01-24 Thread Aleksandar Markovic
From: Yongbok Kim WatchHi is extended by the field MemoryMapID with the GINVT instruction. The field is accessible by MTHC0/MFHC0 in 32-bit architectures and DMTC0/ DMFC0 in 64-bit architectures. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +-

[PATCH v4 1/7] target/mips: Rectify documentation on deprecating r4k machine

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the documented (in file qemu-deprecated.texi) release since r4k machine is deprecated from 4.2 to 5.0. Fixes: d32dc61421b Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- qemu-deprecated.texi | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Micromips instruction sets (in all variants R2, R3, R5, R6) represent significant departure from regular mips R2, R3, R5, R6. That is the main reason a separate module is developed for the purpose of disassembling micromips sets. This patch is limited to micromips 32R6

[PATCH v4 2/7] target/mips: Add support for MIPS<32|64>R6 CRC32 ISA

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Add support for eight CRC-related MIPS<32|64>R6 instructions. Signed-off-by: Aleksandar Markovic --- disas/mips.c| 8 +++ target/mips/helper.h| 2 + target/mips/op_helper.c | 19 target/mips/translate.c | 127 +

[PATCH v4 4/7] target/mips: Add implementation of GINVT instruction

2020-01-24 Thread Aleksandar Markovic
From: Yongbok Kim Implement emulation of GINVT instruction. As QEMU doesn't support caches and virtualization, this implementation covers only GINVT (Global Invalidate TLB) instruction among TLB-related instructions. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- disas/mips

Re: [PATCH v2 8/8] virtfs-proxy-helper: Convert documentation to rST

2020-01-24 Thread Greg Kurz
On Fri, 24 Jan 2020 16:26:06 + Peter Maydell wrote: > The virtfs-proxy-helper documentation is currently in > fsdev/qemu-trace-stap.texi in Texinfo format, which we > present to the user as: > * a virtfs-proxy-helper manpage > * but not (unusually for QEMU) part of the HTML docs > > Conver

OpenBIOS update broke Linux boot on qemu-system-sparc64

2020-01-24 Thread Thomas Huth
Hi Mark, today, I noticed that the Sparc64 image from the QEMU advent calendar 2018 does not work anymore with the recent QEMU: https://www.qemu-advent-calendar.org/2018/download/day23.tar.xz The Linux kernel now crashes during the boot process. Bisecting the issues pointed to: commit e9d

[PATCH 2/8] tests/vm: increased max timeout for vm boot.

2020-01-24 Thread Robert Foley
Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/basevm

[PATCH 0/8] tests/vm: Add support for aarch64 VMs

2020-01-24 Thread Robert Foley
This patch adds support for 2 aarch64 VMs. - Ubuntu 18.04 aarch64 VM - CentOS 8 aarch64 VM In order to add support for the two new aarch64 VMs, we generalized and parameterized basevm.py. We added a new concept of a configuration, which is really just a set of parameters which define how to

[PATCH 1/8] tests/vm: Debug mode shows ssh output.

2020-01-24 Thread Robert Foley
Add changes to tests/vm/basevm.py so that during debug mode we show ssh output. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index ed5dd4f3d0..991115

[PATCH 6/8] tests/vm: add --boot-console switch

2020-01-24 Thread Robert Foley
Added ability to view console during boot via --boot-console switch. This helps debug issues that occur during the boot sequence. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/

[PATCH 7/8] tests/vm: Added a new script for ubuntu.aarch64.

2020-01-24 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 7

[PATCH 4/8] tests/vm: Add configuration to basevm.py

2020-01-24 Thread Robert Foley
Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration which we might want t

[PATCH 3/8] tests/vm: change wait_ssh to optionally wait for root.

2020-01-24 Thread Robert Foley
Allow wait_ssh to wait for root user to be ready. This solves the issue where we perform a wait_ssh() successfully, but the root user is not yet ready to be logged in. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 9 +++-- 1 file changed, 7 insertions(+), 2 d

[PATCH 5/8] tests/vm: Added configuration file support

2020-01-24 Thread Robert Foley
Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example config_example.yml. Signed-off-by: Robert Foley

[PATCH 8/8] tests/vm: Added a new script for centos.aarch64.

2020-01-24 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 52 + tests/vm/centos.aarch64 | 218 +++

[PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

2020-01-24 Thread Thomas Huth
The 2018 edition of the QEMU advent calendar 2018 featured Linux images for various non-x86 machines. We can use them for a boot tests in our acceptance test suite. Let's also make sure that we build the corresponding machines in Travis, and while we're there, drop the superfluous --python paramet

Re: [PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0

2020-01-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579883929-1517-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1579883929-1517-1-git-send-email-aleksandar.marko...@rt-rk.com Subjec

Re: [PATCH 2/8] tests/vm: increased max timeout for vm boot.

2020-01-24 Thread Philippe Mathieu-Daudé
Hi Robert, On 1/24/20 5:53 PM, Robert Foley wrote: Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 2 +- 1 file changed, 1 i

Re: [PATCH REPOST v3 53/80] mips/mips_jazz: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
On Thu, Jan 23, 2020 at 1:15 PM Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_

Re: [PATCH REPOST v3 54/80] mips/mips_malta: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
On Thu, Jan 23, 2020 at 1:19 PM Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_

Re: [PATCH REPOST v3 56/80] mips/mips_r4k: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
On Thu, Jan 23, 2020 at 1:24 PM Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_

Re: [PATCH REPOST v3 55/80] mips/mips_mipssim: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
On Thu, Jan 23, 2020 at 1:22 PM Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_

Re: [PATCH v1 06/59] mips-semi.c: remove 'uhi_done' label in helper_do_semihosting()

2020-01-24 Thread Aleksandar Markovic
On Mon, Jan 6, 2020 at 7:29 PM Daniel Henrique Barboza < danielhb...@gmail.com> wrote: > The label 'uhi_done' is a simple 'return' call and can > be removed for a bit more clarity in the code. > > CC: Aurelien Jarno > CC: Aleksandar Markovic > CC: Aleksandar Rikalo > Signed-off-by: Daniel Henri

Re: [PATCH v4 3/7] target/mips: Amend CP0 WatchHi register implementation

2020-01-24 Thread Aleksandar Rikalo
> From: Yongbok Kim > > WatchHi is extended by the field MemoryMapID with the GINVT instruction. > The field is accessible by MTHC0/MFHC0 in 32-bit architectures and DMTC0/ > DMFC0 in 64-bit architectures. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > --- >  target/mip

Re: [PATCH v4 4/7] target/mips: Add implementation of GINVT instruction

2020-01-24 Thread Aleksandar Rikalo
> From: Yongbok Kim > > Implement emulation of GINVT instruction. As QEMU doesn't support > caches and virtualization, this implementation covers only GINVT > (Global Invalidate TLB) instruction among TLB-related instructions. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic

Re: [PATCH v4 5/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > > This patch adds a field "target_info" to the structure > disassemble_info. The purpose of this field is to enable targets > to pass to disassembler code any additional data thet deem suitable. > > Signed-off-by: Aleksandar Markovic > --- >  include/disas/dis-asm.h

Re: [PATCH 1/8] tests/vm: Debug mode shows ssh output.

2020-01-24 Thread Alex Bennée
Robert Foley writes: > Add changes to tests/vm/basevm.py so that during debug > mode we show ssh output. nit: space > > Signed-off-by: Robert Foley > Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée > --- > tests/vm/basevm.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(

[PATCH] target/arm/arm-semi: Don't let the guest close stdin/stdout/stderr

2020-01-24 Thread Peter Maydell
The guest can use the semihosting API to open a handle corresponding to QEMU's own stdin, stdout, or stderr. When the guest closes this handle, we should not close the underlying host stdin/stdout/stderr the way we would do if the handle corresponded to a host fd we'd opened on behalf of the guest

[PULL 1/7] target/mips: Rectify documentation on deprecating r4k machine

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the documented (in file qemu-deprecated.texi) release since r4k machine is deprecated from 4.2 to 5.0. Fixes: d32dc61421b Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-Id: <1579883929-1517-2-git-send-email-aleksandar.marko...@r

[PULL 3/7] mips-semi.c: remove 'uhi_done' label in helper_do_semihosting()

2020-01-24 Thread Aleksandar Markovic
From: Daniel Henrique Barboza The label 'uhi_done' is a simple 'return' call and can be removed for a bit more clarity in the code. CC: Aurelien Jarno CC: Aleksandar Markovic CC: Aleksandar Rikalo Signed-off-by: Daniel Henrique Barboza Reviewed-by: Aleksandar Markovic Message-Id: <202001061

[PULL 4/7] mips/mips_jazz: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 5/7] mips/mips_malta: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 2/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch adds a field "target_info" to the structure disassemble_info. The purpose of this field is to enable targets to pass to disassembler code any additional data thet deem suitable. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <

[PULL 0/7] MIPS queue for January 24th, 2020

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf1' into staging (2020-01-24 12:34:04 +) are available in the git repository at: https://github.com/AMarkovic/

[PULL 6/7] mips/mips_mipssim: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL 7/7] mips/mips_r4k: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

Re: [EXTERNAL][PULL 0/7] MIPS queue for January 24th, 2020

2020-01-24 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Cc: peter.mayd...@linaro.org; Aleksandar Markovic > Subject: [EXTERNAL][PULL 0/7] MIPS queue for January 24th, 2020 I forgot one "Signed-off-by:". Will send v2 shortly. Thanks, Aleksandar

Re: [EXTERNAL] Re: QEMU for aarch64 with plugins seems to fail basic consistency checks

2020-01-24 Thread Robert Henry
I found at least one problem with my plugin. I was assuming that the insn data from struct qemu_plugin_insn *insn = qemu_plugin_tb_get_insn(tb, i); could be passed into qemu_plugin_register_vcpu_insn_exec_cb both as the 1st argument AND as the user data last argument. This assumed that ins

[PULL v2 2/7] disas: Add a field for target-dependant data

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch adds a field "target_info" to the structure disassemble_info. The purpose of this field is to enable targets to pass to disassembler code any additional data thet deem suitable. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id: <

[PULL v2 6/7] mips/mips_mipssim: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL v2 4/7] mips/mips_jazz: use memdev for RAM

2020-01-24 Thread Aleksandar Markovic
From: Igor Mammedov memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead

[PULL v2 0/7] MIPS queue for Jan 24th, 2020

2020-01-24 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf1' into staging (2020-01-24 12:34:04 +) are available in the git repository at: https://github.com/AMarkovic/

<    1   2   3   >